@bananapus/core-v6 0.0.15 → 0.0.16

package/test/TestPayHooks.sol

@@ -1,7 +1,24 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBPayHook} from "../src/interfaces/IJBPayHook.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesetDataHook} from "../src/interfaces/IJBRulesetDataHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBAfterPayRecordedContext} from "../src/structs/JBAfterPayRecordedContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBPayHookSpecification} from "../src/structs/JBPayHookSpecification.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {JBTokenAmount} from "../src/structs/JBTokenAmount.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
 
 contract TestPayHooks_Local is TestBaseWorkflow {
     uint8 private constant _WEIGHT_DECIMALS = 18;
@@ -118,25 +135,27 @@ contract TestPayHooks_Local is TestBaseWorkflow {
             bytes memory _hookMetadata = bytes("Some data hook metadata");
 
             // Package up the specification struct.
-            _specifications[i] = JBPayHookSpecification(IJBPayHook(_hookAddress), _payHookAmounts[i], _hookMetadata);
+            _specifications[i] = JBPayHookSpecification({
+                hook: IJBPayHook(_hookAddress), amount: _payHookAmounts[i], metadata: _hookMetadata
+            });
 
             // Keep a reference to the data that'll be received by the hook.
             JBAfterPayRecordedContext memory _postRecordPayContext = JBAfterPayRecordedContext({
                 payer: _payer,
                 projectId: _projectId,
                 rulesetId: _ruleset.id,
-                amount: JBTokenAmount(
-                    JBConstants.NATIVE_TOKEN,
-                    _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
-                    _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
-                    _nativePayAmount
-                ),
-                forwardedAmount: JBTokenAmount(
-                    JBConstants.NATIVE_TOKEN,
-                    _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
-                    _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
-                    _payHookAmounts[i]
-                ),
+                amount: JBTokenAmount({
+                    token: JBConstants.NATIVE_TOKEN,
+                    decimals: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
+                    currency: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
+                    value: _nativePayAmount
+                }),
+                forwardedAmount: JBTokenAmount({
+                    token: JBConstants.NATIVE_TOKEN,
+                    decimals: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
+                    currency: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
+                    value: _payHookAmounts[i]
+                }),
                 weight: _WEIGHT,
                 newlyIssuedTokenCount: mulDiv(_nativePayAmount, _DATA_HOOK_WEIGHT, 10 ** _NATIVE_TOKEN_DECIMALS),
                 beneficiary: _beneficiary,

package/test/TestPermissions.sol

@@ -1,7 +1,24 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {MockERC20} from "./mock/MockERC20.sol";
+import {JBPermissions} from "../src/JBPermissions.sol";
+import {JBPermissioned} from "../src/abstract/JBPermissioned.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBPermissions} from "../src/interfaces/IJBPermissions.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IJBToken} from "../src/interfaces/IJBToken.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBPermissionsData} from "../src/structs/JBPermissionsData.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 
 contract TestPermissions_Local is TestBaseWorkflow {
     IJBController private _controller;
@@ -135,6 +152,7 @@ contract TestPermissions_Local is TestBaseWorkflow {
         address _op,
         uint56 _projectId,
         uint8 _checkedId,
+        // forge-lint: disable-next-line(mixed-case-variable)
         uint8[] memory _set_permissions
     )
         public
@@ -143,6 +161,7 @@ contract TestPermissions_Local is TestBaseWorkflow {
         vm.assume(_set_permissions.length != 0);
         vm.assume(_account != trustedForwarder());
 
+        // forge-lint: disable-next-line(mixed-case-variable)
         uint256[] memory _check_permissions = new uint256[](1);
         _check_permissions[0] = _checkedId;
 

package/test/TestPermissionsEdge.sol

@@ -1,7 +1,10 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBPermissions} from "../src/JBPermissions.sol";
+import {JBPermissionsData} from "../src/structs/JBPermissionsData.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 
 /// @notice Defense-in-depth validation of JBPermissions ROOT escalation prevention.
 /// Verifies that ROOT operators cannot forward ROOT, cannot set wildcard permissions,
@@ -231,6 +234,7 @@ contract TestPermissionsEdge_Local is TestBaseWorkflow {
         uint256 idx;
         for (uint256 i = 1; i < 256; i++) {
             if ((bitmap >> i) & 1 == 1) {
+                // forge-lint: disable-next-line(unsafe-typecast)
                 ids[idx] = uint8(i);
                 idx++;
             }

package/test/TestPermit2Terminal.sol

@@ -1,7 +1,23 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {MetadataResolverHelper} from "./helpers/MetadataResolverHelper.sol";
+import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBPrices} from "../src/interfaces/IJBPrices.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSingleAllowance} from "../src/structs/JBSingleAllowance.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {IAllowanceTransfer, IPermit2} from "@uniswap/permit2/src/interfaces/IPermit2.sol";
 import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import {MockPriceFeed} from "./mock/MockPriceFeed.sol";
 
@@ -20,6 +36,7 @@ contract TestPermit2Terminal_Local is TestBaseWorkflow {
     uint256 _projectId;
 
     // Permit2 params.
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 DOMAIN_SEPARATOR;
     address from;
     uint256 fromPrivateKey;
@@ -126,7 +143,13 @@ contract TestPermit2Terminal_Local is TestBaseWorkflow {
 
         // Setup: prepare permit details for signing.
         IAllowanceTransfer.PermitDetails memory details = IAllowanceTransfer.PermitDetails({
-            token: address(_usdc), amount: uint160(_coins), expiration: uint48(_expiration), nonce: 0
+            // forge-lint: disable-next-line(unsafe-typecast)
+            token: address(_usdc),
+            // forge-lint: disable-next-line(unsafe-typecast)
+            amount: uint160(_coins),
+            // forge-lint: disable-next-line(unsafe-typecast)
+            expiration: uint48(_expiration),
+            nonce: 0
         });
 
         IAllowanceTransfer.PermitSingle memory permit =
@@ -137,7 +160,9 @@ contract TestPermit2Terminal_Local is TestBaseWorkflow {
 
         JBSingleAllowance memory permitData = JBSingleAllowance({
             sigDeadline: _deadline,
+            // forge-lint: disable-next-line(unsafe-typecast)
             amount: uint160(_coins),
+            // forge-lint: disable-next-line(unsafe-typecast)
             expiration: uint48(_expiration),
             nonce: uint48(0),
             signature: sig
@@ -191,7 +216,13 @@ contract TestPermit2Terminal_Local is TestBaseWorkflow {
 
         // Setup: prepare permit details for signing.
         IAllowanceTransfer.PermitDetails memory details = IAllowanceTransfer.PermitDetails({
-            token: address(_usdc), amount: uint160(_coins), expiration: uint48(_expiration), nonce: 0
+            // forge-lint: disable-next-line(unsafe-typecast)
+            token: address(_usdc),
+            // forge-lint: disable-next-line(unsafe-typecast)
+            amount: uint160(_coins),
+            // forge-lint: disable-next-line(unsafe-typecast)
+            expiration: uint48(_expiration),
+            nonce: 0
         });
 
         IAllowanceTransfer.PermitSingle memory permit =
@@ -202,7 +233,9 @@ contract TestPermit2Terminal_Local is TestBaseWorkflow {
 
         JBSingleAllowance memory permitData = JBSingleAllowance({
             sigDeadline: _deadline,
+            // forge-lint: disable-next-line(unsafe-typecast)
             amount: uint160(_coins),
+            // forge-lint: disable-next-line(unsafe-typecast)
             expiration: uint48(_expiration),
             nonce: uint48(0),
             signature: sig

package/test/TestRulesetQueueing.sol

@@ -1,7 +1,22 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBController} from "../src/JBController.sol";
+import {JBDeadline} from "../src/JBDeadline.sol";
+import {JBRulesets} from "../src/JBRulesets.sol";
+import {JBApprovalStatus} from "../src/enums/JBApprovalStatus.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 // A project's rulesets can be queued, and re-queued as long as the current ruleset approval hook approves.
 contract TestRulesetQueuing_Local is TestBaseWorkflow {
@@ -13,8 +28,12 @@ contract TestRulesetQueuing_Local is TestBaseWorkflow {
     IJBTerminal private _terminal;
     uint112 private _weight;
 
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 private _DEADLINE_DURATION = 3 days;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 private _RULESET_DURATION_DAYS = 6;
+    // forge-lint: disable-next-line(unsafe-typecast)
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint32 private _RULESET_DURATION = uint32(_RULESET_DURATION_DAYS * 1 days);
 
     function setUp() public override {
@@ -779,6 +798,7 @@ contract TestRulesetQueuing_Local is TestBaseWorkflow {
         // Package up another config to overwrite.
         JBRulesetConfig[] memory _secondQueued = new JBRulesetConfig[](1);
 
+        // forge-lint: disable-next-line(unsafe-typecast)
         _secondQueued[0].mustStartAtOrAfter = uint48(block.timestamp + _DEADLINE_DURATION);
         _secondQueued[0].duration = _RULESET_DURATION;
         _secondQueued[0].weight = _weightSecondQueued;
@@ -805,10 +825,13 @@ contract TestRulesetQueuing_Local is TestBaseWorkflow {
         _duration = bound(_duration, 1, block.timestamp);
 
         JBRuleset memory _ruleset = JBRuleset({
+            // forge-lint: disable-next-line(unsafe-typecast)
             id: uint48(_rulesetId),
             basedOnId: 0,
             cycleNumber: 1,
+            // forge-lint: disable-next-line(unsafe-typecast)
             start: uint48(_start),
+            // forge-lint: disable-next-line(unsafe-typecast)
             duration: uint32(_duration),
             weight: 1,
             weightCutPercent: 0,

package/test/TestRulesetQueuingStress.sol

@@ -1,7 +1,20 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBDeadline} from "../src/JBDeadline.sol";
+import {JBApprovalStatus} from "../src/enums/JBApprovalStatus.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
 /// @notice Mock approval hook that always returns a configurable status.
 contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
@@ -350,6 +363,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                     pid,
                     0,
                     FOURTEEN_DAYS,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     uint112(INITIAL_WEIGHT + uint112(i) * 100e18),
                     0,
                     IJBRulesetApprovalHook(address(0))
@@ -544,6 +558,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
 
             _queueRuleset(
                 pid,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 uint48(originalStart + SEVEN_DAYS),
                 SEVEN_DAYS,
                 INITIAL_WEIGHT * 2,
@@ -563,6 +578,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
             // 1 second after first boundary -> should snap to second boundary.
             _queueRuleset(
                 pid,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 uint48(originalStart + SEVEN_DAYS + 1),
                 SEVEN_DAYS,
                 INITIAL_WEIGHT * 2,
@@ -599,6 +615,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                     pid,
                     0,
                     SEVEN_DAYS,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     uint112(INITIAL_WEIGHT + uint112(i) * 100e18),
                     0,
                     IJBRulesetApprovalHook(address(0))
@@ -608,6 +625,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                 JBRuleset memory current = _rulesets.currentOf(pid);
                 assertEq(
                     current.weight,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     INITIAL_WEIGHT + uint112(i) * 100e18,
                     string.concat("Cycle ", vm.toString(i + 1), " weight mismatch")
                 );
@@ -765,6 +783,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                     pid,
                     0,
                     SEVEN_DAYS,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     uint112(INITIAL_WEIGHT + uint112(i) * 100e18),
                     0,
                     IJBRulesetApprovalHook(address(0))

package/test/TestRulesetWeightCaching.sol

@@ -1,7 +1,11 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
 
 // A ruleset's weight can be cached to make larger intervals calculable while staying within the gas limit.
 contract TestRulesetWeightCaching_Local is TestBaseWorkflow {

package/test/TestSplits.sol

@@ -1,7 +1,27 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBTerminalStore} from "../src/JBTerminalStore.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBDirectory} from "../src/interfaces/IJBDirectory.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBSplitHook} from "../src/interfaces/IJBSplitHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBSplitGroupIds} from "../src/libraries/JBSplitGroupIds.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplit} from "../src/structs/JBSplit.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {IERC20Metadata} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
 
 contract TestSplits_Local is TestBaseWorkflow {
     IJBController private _controller;
@@ -304,6 +324,7 @@ contract TestSplits_Local is TestBaseWorkflow {
         // Set up a payout split recipient.
         _splits[0] = JBSplit({
             preferAddToBalance: false,
+            // forge-lint: disable-next-line(unsafe-typecast)
             percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT / _multiplier),
             projectId: 0,
             beneficiary: _splitsGuy,
@@ -314,6 +335,7 @@ contract TestSplits_Local is TestBaseWorkflow {
         // A dummy used to check that splits groups of "0" don't bypass payout limits.
         _splits[1] = JBSplit({
             preferAddToBalance: false,
+            // forge-lint: disable-next-line(unsafe-typecast)
             percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT / _multiplier),
             projectId: 0,
             beneficiary: _splitsGuy,

package/test/TestTerminalMigration.sol

@@ -1,7 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 /// @notice E2E test: Pay into terminal A -> migrate to terminal B -> verify balances, surplus, cash outs.
 contract TestTerminalMigration_Local is TestBaseWorkflow {

package/test/TestTokenFlow.sol

@@ -1,7 +1,24 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBController} from "../src/JBController.sol";
+import {JBERC20} from "../src/JBERC20.sol";
+import {JBTokens} from "../src/JBTokens.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IJBToken} from "../src/interfaces/IJBToken.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {Clones} from "@openzeppelin/contracts/proxy/Clones.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
 
 // Launch project, issue token or set the token, mint token, burn token.
 contract TestTokenFlow_Local is TestBaseWorkflow {

package/test/TestWeightCacheStaleAfterRejection.sol

@@ -1,10 +1,24 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBApprovalStatus} from "../src/enums/JBApprovalStatus.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
 /// @notice Mock approval hook that ALWAYS rejects queued rulesets.
 contract AlwaysRejectApprovalHook is IJBRulesetApprovalHook {
+    // forge-lint: disable-next-line(mixed-case-function)
     function DURATION() external pure override returns (uint256) {
         return 0;
     }

package/test/WeirdTokenTests.t.sol

@@ -1,7 +1,19 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBSplitHook} from "../src/interfaces/IJBSplitHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplit} from "../src/structs/JBSplit.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
 import {ERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
 
@@ -92,6 +104,7 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
         rulesetConfig[0].metadata = JBRulesetMetadata({
             reservedPercent: 0,
             cashOutTaxRate: 0,
+            // forge-lint: disable-next-line(unsafe-typecast)
             baseCurrency: uint32(uint160(token)),
             pausePay: false,
             pauseCreditTransfers: false,
@@ -115,6 +128,7 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
 
         JBTerminalConfig[] memory terminalConfigurations = new JBTerminalConfig[](1);
         JBAccountingContext[] memory tokensToAccept = new JBAccountingContext[](1);
+        // forge-lint: disable-next-line(unsafe-typecast)
         tokensToAccept[0] = JBAccountingContext({token: token, decimals: decimals, currency: uint32(uint160(token))});
         terminalConfigurations[0] =
             JBTerminalConfig({terminal: jbMultiTerminal(), accountingContextsToAccept: tokensToAccept});
@@ -676,9 +690,11 @@ contract RebasingToken is ERC20 {
     function rebaseHolder(address target, int256 percent) external {
         uint256 balance = balanceOf(target);
         if (percent > 0) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             uint256 increase = (balance * uint256(percent)) / 100;
             _mint(target, increase);
         } else if (percent < 0) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             uint256 decrease = (balance * uint256(-percent)) / 100;
             if (decrease > 0 && decrease <= balance) {
                 _burn(target, decrease);

package/test/fork/TestChainlinkPriceFeedFork.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 
 import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";
 
@@ -68,6 +68,7 @@ contract TestChainlinkPriceFeedFork is Test {
         // Cross-check against raw latestRoundData.
         (, int256 rawPrice,,,) = AggregatorV3Interface(ETH_USD_FEED).latestRoundData();
         uint256 feedDecimals = AggregatorV3Interface(ETH_USD_FEED).decimals();
+        // forge-lint: disable-next-line(unsafe-typecast)
         uint256 expected18 = uint256(rawPrice) * 10 ** (18 - feedDecimals);
         assertEq(price18, expected18, "Price mismatch vs raw feed");
     }
@@ -85,15 +86,19 @@ contract TestChainlinkPriceFeedFork is Test {
 
         // Raw feed is 8 decimals — price8 should match it exactly.
         (, int256 rawPrice,,,) = AggregatorV3Interface(ETH_USD_FEED).latestRoundData();
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price8, uint256(rawPrice), "8-decimal mismatch");
 
         // 6 decimals = raw / 100 (truncated).
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price6, uint256(rawPrice) / 1e2, "6-decimal mismatch");
 
         // 18 decimals = raw * 1e10.
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price18, uint256(rawPrice) * 1e10, "18-decimal mismatch");
 
         // 27 decimals = raw * 1e19.
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price27, uint256(rawPrice) * 1e19, "27-decimal mismatch");
     }
 

package/test/formal/BondingCurveProperties.t.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.17;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBCashOuts} from "../../src/libraries/JBCashOuts.sol";
 import {JBFees} from "../../src/libraries/JBFees.sol";
 import {JBConstants} from "../../src/libraries/JBConstants.sol";
@@ -21,6 +21,7 @@ contract BondingCurveProperties is Test {
     // Property 1: Boundedness — cashOutFrom never exceeds surplus
     // =========================================================================
     /// @notice cashOutFrom(S, c, T, r) <= S for all valid inputs.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_cashOut_boundedness(
         uint256 surplus,
         uint256 cashOutCount,
@@ -62,6 +63,7 @@ contract BondingCurveProperties is Test {
     // Property 2: Monotonicity — more tokens → more reclaim
     // =========================================================================
     /// @notice cashOutFrom(S, c1, T, r) <= cashOutFrom(S, c2, T, r) when c1 <= c2.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_cashOut_monotonicity(
         uint256 surplus,
         uint256 c1,
@@ -112,6 +114,7 @@ contract BondingCurveProperties is Test {
     // Property 3: Full redemption — when c >= T, result is S (full surplus)
     // =========================================================================
     /// @notice When cashOutCount >= totalSupply, the full surplus is returned.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_cashOut_fullRedemption(uint256 surplus, uint256 totalSupply, uint256 cashOutTaxRate) public pure {
         vm.assume(surplus > 0 && surplus <= type(uint128).max);
         vm.assume(totalSupply > 0 && totalSupply <= type(uint128).max);
@@ -136,6 +139,7 @@ contract BondingCurveProperties is Test {
     // Property 4: Max tax → zero reclaim
     // =========================================================================
     /// @notice When cashOutTaxRate == MAX_CASH_OUT_TAX_RATE, result is 0.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_cashOut_maxTaxIsZero(uint256 surplus, uint256 cashOutCount, uint256 totalSupply) public pure {
         vm.assume(surplus > 0 && surplus <= type(uint128).max);
         vm.assume(totalSupply > 0 && totalSupply <= type(uint128).max);
@@ -160,6 +164,7 @@ contract BondingCurveProperties is Test {
     /// @notice Splitting a cash out into two parts should never yield more than a single cash out.
     ///         cashOutFrom(S, a, T, r) + cashOutFrom(S', b, T', r) <= cashOutFrom(S, a+b, T, r)
     ///         where S' = S - cashOutFrom(S, a, T, r) and T' = T - a
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_cashOut_noArbitrage(
         uint256 surplus,
         uint256 a,
@@ -244,6 +249,7 @@ contract BondingCurveProperties is Test {
     /// @notice The forward and reverse fee functions should be consistent:
     ///         amount - feeAmountFrom(amount, fee) + feeAmountResultingIn(net, fee) >= feeAmountFrom(amount, fee)
     ///         where net = amount - feeAmountFrom(amount, fee)
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_fee_roundTrip(uint256 amount, uint256 feePercent) public pure {
         vm.assume(amount > 0 && amount <= type(uint128).max);
         vm.assume(feePercent > 0 && feePercent < MAX_FEE);
@@ -275,6 +281,7 @@ contract BondingCurveProperties is Test {
     // Property 7: Metadata packing round-trip
     // =========================================================================
     /// @notice packRulesetMetadata(m) → expandMetadata should return the original metadata.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_metadataPacking_roundTrip(
         uint16 reservedPercent,
         uint16 cashOutTaxRate,