@babylonjs/core 5.17.1 → 5.20.0

package/Physics/Plugins/ammoJSPlugin.d.ts

@@ -378,8 +378,8 @@ export declare class AmmoJSPlugin implements IPhysicsEnginePlugin {
     dispose(): void;
     /**
      * Does a raycast in the physics world
-     * @param from when should the ray start?
-     * @param to when should the ray end?
+     * @param from where should the ray start?
+     * @param to where should the ray end?
      * @returns PhysicsRaycastResult
      */
     raycast(from: Vector3, to: Vector3): PhysicsRaycastResult;

package/Physics/Plugins/ammoJSPlugin.js

@@ -805,7 +805,7 @@ var AmmoJSPlugin = /** @class */ (function () {
         if (ignoreChildren === void 0) { ignoreChildren = false; }
         var object = impostor.object;
         var returnValue;
-        var extendSize = impostor.getObjectExtendSize();
+        var impostorExtents = impostor.getObjectExtents();
         if (!ignoreChildren) {
             var meshChildren = impostor.object.getChildMeshes ? impostor.object.getChildMeshes(true) : [];
             returnValue = new this.bjsAMMO.btCompoundShape();
@@ -852,50 +852,50 @@ var AmmoJSPlugin = /** @class */ (function () {
         switch (impostor.type) {
             case PhysicsImpostor.SphereImpostor:
                 // Is there a better way to compare floats number? With an epsilon or with a Math function
-                if (Scalar.WithinEpsilon(extendSize.x, extendSize.y, 0.0001) && Scalar.WithinEpsilon(extendSize.x, extendSize.z, 0.0001)) {
-                    returnValue = new this.bjsAMMO.btSphereShape(extendSize.x / 2);
+                if (Scalar.WithinEpsilon(impostorExtents.x, impostorExtents.y, 0.0001) && Scalar.WithinEpsilon(impostorExtents.x, impostorExtents.z, 0.0001)) {
+                    returnValue = new this.bjsAMMO.btSphereShape(impostorExtents.x / 2);
                 }
                 else {
                     // create a btMultiSphereShape because it's not possible to set a local scaling on a btSphereShape
                     var positions = [new this.bjsAMMO.btVector3(0, 0, 0)];
                     var radii = [1];
                     returnValue = new this.bjsAMMO.btMultiSphereShape(positions, radii, 1);
-                    returnValue.setLocalScaling(new this.bjsAMMO.btVector3(extendSize.x / 2, extendSize.y / 2, extendSize.z / 2));
+                    returnValue.setLocalScaling(new this.bjsAMMO.btVector3(impostorExtents.x / 2, impostorExtents.y / 2, impostorExtents.z / 2));
                 }
                 break;
             case PhysicsImpostor.CapsuleImpostor:
                 {
                     // https://pybullet.org/Bullet/BulletFull/classbtCapsuleShape.html#details
                     // Height is just the height between the center of each 'sphere' of the capsule caps
-                    var capRadius = extendSize.x / 2;
-                    returnValue = new this.bjsAMMO.btCapsuleShape(capRadius, extendSize.y - capRadius * 2);
+                    var capRadius = impostorExtents.x / 2;
+                    returnValue = new this.bjsAMMO.btCapsuleShape(capRadius, impostorExtents.y - capRadius * 2);
                 }
                 break;
             case PhysicsImpostor.CylinderImpostor:
-                this._tmpAmmoVectorA.setValue(extendSize.x / 2, extendSize.y / 2, extendSize.z / 2);
+                this._tmpAmmoVectorA.setValue(impostorExtents.x / 2, impostorExtents.y / 2, impostorExtents.z / 2);
                 returnValue = new this.bjsAMMO.btCylinderShape(this._tmpAmmoVectorA);
                 break;
             case PhysicsImpostor.PlaneImpostor:
             case PhysicsImpostor.BoxImpostor:
-                this._tmpAmmoVectorA.setValue(extendSize.x / 2, extendSize.y / 2, extendSize.z / 2);
+                this._tmpAmmoVectorA.setValue(impostorExtents.x / 2, impostorExtents.y / 2, impostorExtents.z / 2);
                 returnValue = new this.bjsAMMO.btBoxShape(this._tmpAmmoVectorA);
                 break;
             case PhysicsImpostor.MeshImpostor: {
                 if (impostor.getParam("mass") == 0) {
-                    // Only create btBvhTriangleMeshShape impostor is static
+                    // Only create btBvhTriangleMeshShape if the impostor is static
                     // See https://pybullet.org/Bullet/phpBB3/viewtopic.php?t=7283
                     if (this.onCreateCustomMeshImpostor) {
                         returnValue = this.onCreateCustomMeshImpostor(impostor);
                     }
                     else {
-                        var tetraMesh = new this.bjsAMMO.btTriangleMesh();
-                        impostor._pluginData.toDispose.push(tetraMesh);
-                        var triangeCount = this._addMeshVerts(tetraMesh, object, object);
-                        if (triangeCount == 0) {
+                        var triMesh = new this.bjsAMMO.btTriangleMesh();
+                        impostor._pluginData.toDispose.push(triMesh);
+                        var triangleCount = this._addMeshVerts(triMesh, object, object);
+                        if (triangleCount == 0) {
                             returnValue = new this.bjsAMMO.btCompoundShape();
                         }
                         else {
-                            returnValue = new this.bjsAMMO.btBvhTriangleMeshShape(tetraMesh);
+                            returnValue = new this.bjsAMMO.btBvhTriangleMeshShape(triMesh);
                         }
                     }
                     break;
@@ -908,22 +908,22 @@ var AmmoJSPlugin = /** @class */ (function () {
                     returnValue = this.onCreateCustomConvexHullImpostor(impostor);
                 }
                 else {
-                    var convexMesh = new this.bjsAMMO.btConvexHullShape();
-                    var triangeCount = this._addHullVerts(convexMesh, object, object);
-                    if (triangeCount == 0) {
+                    var convexHull = new this.bjsAMMO.btConvexHullShape();
+                    var triangleCount = this._addHullVerts(convexHull, object, object);
+                    if (triangleCount == 0) {
                         // Cleanup Unused Convex Hull Shape
-                        impostor._pluginData.toDispose.push(convexMesh);
+                        impostor._pluginData.toDispose.push(convexHull);
                         returnValue = new this.bjsAMMO.btCompoundShape();
                     }
                     else {
-                        returnValue = convexMesh;
+                        returnValue = convexHull;
                     }
                 }
                 break;
             }
             case PhysicsImpostor.NoImpostor:
                 // Fill with sphere but collision is disabled on the rigid body in generatePhysicsBody, using an empty shape caused unexpected movement with joints
-                returnValue = new this.bjsAMMO.btSphereShape(extendSize.x / 2);
+                returnValue = new this.bjsAMMO.btSphereShape(impostorExtents.x / 2);
                 break;
             case PhysicsImpostor.CustomImpostor:
                 // Only usable when the plugin's onCreateCustomShape is set
@@ -1340,8 +1340,8 @@ var AmmoJSPlugin = /** @class */ (function () {
      * @returns the radius
      */
     AmmoJSPlugin.prototype.getRadius = function (impostor) {
-        var exntend = impostor.getObjectExtendSize();
-        return exntend.x / 2;
+        var extents = impostor.getObjectExtents();
+        return extents.x / 2;
     };
     /**
      * Gets the box size of the impostor
@@ -1349,10 +1349,10 @@ var AmmoJSPlugin = /** @class */ (function () {
      * @param result the resulting box size
      */
     AmmoJSPlugin.prototype.getBoxSizeToRef = function (impostor, result) {
-        var exntend = impostor.getObjectExtendSize();
-        result.x = exntend.x;
-        result.y = exntend.y;
-        result.z = exntend.z;
+        var extents = impostor.getObjectExtents();
+        result.x = extents.x;
+        result.y = extents.y;
+        result.z = extents.z;
     };
     /**
      * Disposes of the impostor
@@ -1364,7 +1364,7 @@ var AmmoJSPlugin = /** @class */ (function () {
         this.bjsAMMO.destroy(this._overlappingPairCache);
         this.bjsAMMO.destroy(this._dispatcher);
         this.bjsAMMO.destroy(this._collisionConfiguration);
-        // Dispose of tmp variables
+        // Dispose of temp variables
         this.bjsAMMO.destroy(this._tmpAmmoVectorA);
         this.bjsAMMO.destroy(this._tmpAmmoVectorB);
         this.bjsAMMO.destroy(this._tmpAmmoVectorC);
@@ -1375,8 +1375,8 @@ var AmmoJSPlugin = /** @class */ (function () {
     };
     /**
      * Does a raycast in the physics world
-     * @param from when should the ray start?
-     * @param to when should the ray end?
+     * @param from where should the ray start?
+     * @param to where should the ray end?
      * @returns PhysicsRaycastResult
      */
     AmmoJSPlugin.prototype.raycast = function (from, to) {