@amg555/frameforge-mcp 2.7.6 → 2.7.7

package/.agent/skills/gstack-ship/sections/greptile.md.tmpl

@@ -1,93 +0,0 @@
-## Step 10: Address Greptile review comments (if PR exists)
-
-Check for a PR first. Greptile reviews a PR, so with no PR, no `gh`, no `gh` login or
-a non-GitHub remote there is nothing to triage yet:
-
-```bash
-if ! command -v gh >/dev/null 2>&1; then echo "PR: skip (gh not installed)"
-elif ! gh auth status >/dev/null 2>&1; then echo "PR: skip (gh not logged in)"
-elif ! _GH_ERR=$(gh repo view --json nameWithOwner -q .nameWithOwner 2>&1 >/dev/null); then echo "PR: skip (not a GitHub remote: $(printf '%s' "$_GH_ERR" | head -1))"
-elif _PR_ERR=$(gh pr view --json number -q .number 2>&1 >/dev/null); then echo "PR: exists"
-else case "$_PR_ERR" in *"no pull requests found"*) echo "PR: skip (no PR yet)" ;; *) echo "PR: skip (PR lookup failed: $(printf '%s' "$_PR_ERR" | head -1))" ;; esac
-fi
-```
-
-Only `PR: exists` dispatches. `PR: skip (<reason>)` → do not dispatch; record
-"Greptile: not run (<reason>); runs on the PR once it exists" and continue to Step 11.
-
-**Early PR (Step 6.5):** when the record holds `EARLY_PR` and `EARLY_PR_OPENED_AT`, first
-wait for Greptile's review of that PR, substituting both values:
-
-```bash
-~/.claude/skills/gstack/bin/gstack-greptile-early wait <pr-number> --since <opened-at>
-```
-
-Each call returns within about 90 seconds; relay its progress line. Rerun on
-`GREPTILE_REVIEW: pending`. `complete` dispatches below. `timeout` or `unavailable` takes
-the Unavailable triage route with that line as the reason, never a claim of zero
-comments. Comments on the early head are triaged against the current diff
-(`already_fixed` when the code has moved on).
-
-Dispatch a subagent through Agent with `subagent_type: "general-purpose"` and
-`run_in_background: false`, using Step 7's shared foreground-dispatch rule.
-It fetches and classifies all Greptile comments,
-including escalation tiers; the parent handles decisions and queues approved fixes.
-
-**Subagent prompt:**
-
-> You are classifying Greptile review comments for a /ship workflow. Read `~/.claude/skills/gstack/review/greptile-triage.md` and follow the fetch, filter, classify, and **escalation detection** steps. Do NOT fix code, do NOT reply to comments, do NOT commit — report only.
->
-> For each comment, assign: `classification` (`valid_actionable`, `already_fixed`, `false_positive`, `suppressed`), `escalation_tier` (1 or 2), the file:line or [top-level] tag, body summary, and permalink URL.
->
-> Return one JSON object on the LAST LINE:
-> `{"status":"complete|no_pr|unavailable","total":N,"comments":[{"classification":"...","escalation_tier":N,"ref":"file:line","summary":"...","permalink":"url"},...],"reason":"..."}`
-> Use `complete` only after a successful fetch, including zero comments; `no_pr` only after confirming no PR exists; `unavailable` for `gh`/API errors or incomplete classification. The latter two return zero total and an empty array. State the failure reason for `unavailable`; otherwise use an empty reason.
-
-**Parent processing:**
-
-Parse the LAST line as JSON. Require the declared status, a nonnegative integer
-total matching the comments array, and the status/reason invariants above. An
-unknown or missing status is unavailable, never an empty successful review.
-
-For `no_pr`, record "Greptile: no PR exists"; for `complete` with zero comments,
-record "Greptile: fetched, zero comments". Both continue to Step 11.
-
-**Unavailable triage:** A returned `unavailable`, failed dispatch, invalid result,
-or missing completion after ~10 minutes takes this route. Stop a running child
-and confirm it stopped before continuing. Print `Greptile triage did not complete — review the PR comments manually`.
-Include `Greptile triage: UNAVAILABLE (dispatch failed)` and the actual reason in
-Step 19's review results; Step 20 has no triage field. Continue to Step 11 without
-claiming zero comments or completed triage. This optional triage does not block ship.
-
-Otherwise, print: `+ {total} Greptile comments ({valid_actionable} valid, {already_fixed} already fixed, {false_positive} FP)`.
-
-For each comment in `comments`:
-
-**VALID & ACTIONABLE:** Use AskUserQuestion with:
-- The comment (file:line or [top-level] + body summary + permalink URL)
-- `RECOMMENDATION: Choose A because [one-line reason]`
-- Options: A) Fix now, B) Acknowledge and ship anyway, C) It's a false positive
-- If user chooses A: queue the approved fix without editing here. After that fix passes review and tests, use the **Fix reply template** from greptile-triage.md (inline diff + explanation) and save per-project/global greptile-history (type: fix).
-- If user chooses C: reply using the **False Positive reply template** from greptile-triage.md (include evidence + suggested re-rank), save to both per-project and global greptile-history (type: fp).
-
-**VALID BUT ALREADY FIXED:** Reply using the **Already Fixed reply template** from greptile-triage.md — no AskUserQuestion needed:
-- Include what was done and the fixing commit SHA
-- Save to both per-project and global greptile-history (type: already-fixed)
-
-**FALSE POSITIVE:** Use AskUserQuestion:
-- Show the comment and why you think it's wrong (file:line or [top-level] + body summary + permalink URL)
-- Options:
-  - A) Reply to Greptile explaining the false positive (recommended if clearly wrong)
-  - B) Fix it anyway (if trivial)
-  - C) Ignore silently
-- If user chooses A: reply using the **False Positive reply template** from greptile-triage.md (include evidence + suggested re-rank), save to both per-project and global greptile-history (type: fp)
-- If user chooses B: queue the approved fix, as above.
-
-**SUPPRESSED:** Skip silently — these are known false positives from previous triage.
-
-**After triage:** If fixes were approved, save their approvals and comment references.
-Run Step 9's full review/fix loop, then return here. Finish the saved replies
-without asking again about completed fixes, and classify new comments.
-With no queued fixes, continue to Step 11.
-
----

package/.agent/skills/gstack-ship/sections/handoff.md

@@ -1,22 +0,0 @@
-<!-- AUTO-GENERATED from handoff.md.tmpl — do not edit directly -->
-<!-- Regenerate: bun run gen:skill-docs -->
-## Step 18-H: Handoff without a PR (automation lanes)
-
-Replaces the pr-body section when the run must not open a PR (`--no-pr`, an
-automation lane, an unattended parent said so). Nothing here publishes.
-
-1. Verify-only checks: write Step 16's per-lane pass/fail/skip counts, naming the
-   lanes that need a remote (`requires-remote`), to `.gstack/tmp/ship-gate.json`
-   as the pr-body section does, then:
-   ```bash
-   ~/.claude/skills/gstack/bin/gstack-ship-receipt write --base <base> --gate @.gstack/tmp/ship-gate.json
-   ```
-2. Send the completion message, identifiers first, in this order: the `SHIP_RECEIPT:`
-   line and receipt block (`pr: none`); `branch:` and `sha:` (`git rev-parse HEAD`),
-   pushed or `not pushed`; `inputs:` the plan or issue, the base SHA and the spend
-   cap; `before/after:` one row per claimed metric, measured on base and on this
-   SHA with the command used; `escalation:` the one condition that stops the merge
-   (a `requires-remote` lane, an open gate finding, an unverified claim) or `none`.
-   Full thread ids (`jam_…`) in any cross-thread reference, never a short code.
-   Prose may follow the identifiers; nothing may precede them.
-3. Skip Steps 19 and 21. Run Step 20 with `"version":null` when NO_VERSION applied.

package/.agent/skills/gstack-ship/sections/handoff.md.tmpl

@@ -1,20 +0,0 @@
-## Step 18-H: Handoff without a PR (automation lanes)
-
-Replaces the pr-body section when the run must not open a PR (`--no-pr`, an
-automation lane, an unattended parent said so). Nothing here publishes.
-
-1. Verify-only checks: write Step 16's per-lane pass/fail/skip counts, naming the
-   lanes that need a remote (`requires-remote`), to `.gstack/tmp/ship-gate.json`
-   as the pr-body section does, then:
-   ```bash
-   ~/.claude/skills/gstack/bin/gstack-ship-receipt write --base <base> --gate @.gstack/tmp/ship-gate.json
-   ```
-2. Send the completion message, identifiers first, in this order: the `SHIP_RECEIPT:`
-   line and receipt block (`pr: none`); `branch:` and `sha:` (`git rev-parse HEAD`),
-   pushed or `not pushed`; `inputs:` the plan or issue, the base SHA and the spend
-   cap; `before/after:` one row per claimed metric, measured on base and on this
-   SHA with the command used; `escalation:` the one condition that stops the merge
-   (a `requires-remote` lane, an open gate finding, an unverified claim) or `none`.
-   Full thread ids (`jam_…`) in any cross-thread reference, never a short code.
-   Prose may follow the identifiers; nothing may precede them.
-3. Skip Steps 19 and 21. Run Step 20 with `"version":null` when NO_VERSION applied.

package/.agent/skills/gstack-ship/sections/manifest.json

@@ -1,92 +0,0 @@
-{
-  "$schema": "https://gstack.dev/schemas/section-manifest.json",
-  "skill": "ship",
-  "version": 1,
-  "note": "PASSIVE registry (v2 plan T9 / CM2). Fields are IDs, file paths, human titles, and human-readable trigger text ONLY. The skeleton's decision-tree prose is the ONLY place that decides WHEN to read a section; required section reads are checked by test/skill-e2e-ship-section-loading.test.ts. No machine predicate here \u2014 see docs/designs/v2_PLAN.md:663.",
-  "sections": [
-    {
-      "id": "apple-release",
-      "file": "apple-release.md",
-      "title": "Apple App Store / TestFlight release adapter",
-      "trigger": "App Store/TestFlight distribution is requested for an Apple app (.xcodeproj, .xcworkspace, or an app-product Swift package) \u2014 read at Step 0.9 before the branch gate; an Apple repository-landing request follows the normal pipeline"
-    },
-    {
-      "id": "tests",
-      "file": "tests.md",
-      "title": "Test bootstrap, run, triage + eval suites",
-      "trigger": "running the test suites and (if prompt files changed) the eval suites (Steps 4-6)"
-    },
-    {
-      "id": "greptile-early",
-      "file": "greptile-early.md",
-      "title": "Early Greptile PR",
-      "trigger": "opening the PR early for a parallel Greptile review after the free tests pass (Step 6.5)"
-    },
-    {
-      "id": "measure",
-      "file": "measure.md",
-      "title": "Measure-then-fix loop for a red eval or free shard",
-      "trigger": "a paid eval case is red or a free-suite shard failed (Steps 5-6) \u2014 read from the tests section; diagnostic reruns, then the gate once"
-    },
-    {
-      "id": "test-coverage",
-      "file": "test-coverage.md",
-      "title": "Test coverage audit (subagent)",
-      "trigger": "auditing test coverage of the diff (Step 7)"
-    },
-    {
-      "id": "plan-completion",
-      "file": "plan-completion.md",
-      "title": "Plan completion + verification audit (subagent)",
-      "trigger": "auditing plan completion, verification, and scope drift (Step 8)"
-    },
-    {
-      "id": "review-army",
-      "file": "review-army.md",
-      "title": "Pre-landing review + specialist army",
-      "trigger": "the pre-landing review and specialist dispatch (Step 9)"
-    },
-    {
-      "id": "shared-code-reuse",
-      "file": "shared-code-reuse.md",
-      "title": "Verified reuse of skipped shared-code advice",
-      "trigger": "reusing explicitly skipped shared-code advice (Step 9.3)"
-    },
-    {
-      "id": "greptile",
-      "file": "greptile.md",
-      "title": "Address Greptile review comments",
-      "trigger": "addressing Greptile review comments when a PR exists (Step 10)"
-    },
-    {
-      "id": "adversarial",
-      "file": "adversarial.md",
-      "title": "Adversarial review + learnings refresh",
-      "trigger": "the adversarial review and learnings capture (Step 11)"
-    },
-    {
-      "id": "changelog",
-      "file": "changelog.md",
-      "title": "CHANGELOG entry (release-summary + itemized)",
-      "trigger": "writing the CHANGELOG entry (Step 13)"
-    },
-    {
-      "id": "documentation",
-      "file": "documentation.md",
-      "title": "Pre-publication documentation audit and completion gate",
-      "trigger": "auditing docs before final commit/verification (Step 14.5), on every ship"
-    },
-    {
-      "id": "pr-body",
-      "file": "pr-body.md",
-      "title": "PR/MR creation and documentation outcome",
-      "trigger": "preparing the title and creating or updating the PR/MR with the verified documentation outcome (Steps 18-19)"
-    },
-    {
-      "id": "handoff",
-      "file": "handoff.md",
-      "title": "Handoff without a PR (automation lanes)",
-      "trigger": "handing the branch to a coordinator instead of opening a PR (--no-pr or an automation lane; Step 18)"
-    }
-  ]
-}

package/.agent/skills/gstack-ship/sections/measure.md

@@ -1,66 +0,0 @@
-<!-- AUTO-GENERATED from measure.md.tmpl — do not edit directly -->
-<!-- Regenerate: bun run gen:skill-docs -->
-## Measure-then-fix loop (a red paid eval or a failed free-suite shard)
-
-Every rerun here is **diagnostic, not a verdict**: it never changes the recorded
-verdict of the run that failed, its artifacts are labeled `diagnostic` under
-`.context/ship-measure/` (never the eval history), and the lane verdict comes
-only from the one full gate run at the end. Never raise a budget, lower a
-threshold, add a verdict retry or skip a case to get a pass.
-`ship-measure` below means `bun run ~/.claude/skills/gstack/scripts/ship-measure.ts`.
-
-**Failed free-suite shard (Step 5).** Before calling the failure pre-existing or
-pushing, rerun that shard's exact file list (in run order) with
-`ship-measure free --files <f1,f2,...>` (gstack local runs: `--shard <i>`): 10
-reruns, rerun 1 alone as the baseline and the rest labeled parallel, each with
-its own HOME and state root, the flaky retry off, under a 10-minute cap.
-`ship_rerun_backend=ubicloud` with `UBICLOUD_API_KEY` set runs them on one
-Ubicloud VM. If the runner cannot take a file list, rerun the whole failing
-command 10 times. Report the pass rate, the completed count (for example 6 of 10
-completed at the cap) and one failure capture, then continue the triage.
-
-**Red paid eval (Step 6).** For each red case:
-
-1. **Classify.** Read the red line's cause, evidence and Expected/Received
-   (`failure_cause`, `failure_detail`; gstack: `bun run eval:pass-rates --run <run> --case <id>`).
-   Name it: product change from this branch, detector or actor defect, fixture
-   defect, provider event, or model miss. A detector fix gets a free replay test
-   before any paid trial. A red that is infrastructure (provider outage, runner
-   loss) may skip measurement: `ship-measure skip --case <id> --reason "<why>"`
-   labels it `unmeasured` in the PR body. It never counts as a pass.
-2. **Show the plan.** Print `ship-measure table` (trials, bar and budget per
-   kind, from the `ship_measure_*` gstack config keys) and the estimate:
-   per-trial cost from pass-rate history times trials, or "estimate unknown".
-3. **Measure.** `ship-measure measure --case <id> --round baseline [--cost-per-trial <usd>]`
-   runs the case alone on the current head at its kind's count, in parallel,
-   through the project's documented single-case eval command,
-   `--command '<command> {case}'` (found the way Step 4 finds test commands;
-   gstack needs none and accepts judge ids). With no documented command, ask
-   once and record the answer in the report. Exit 2 needs approval: ask once
-   with its reason, then rerun with `--approved`.
-4. **Decide by the exit code** (MEETS 9/10, MEETS-qualified 8/10 with every
-   red qualifying, EXTEND 7/10; behavior 11/12, 10/12, 9/12):
-   - 0: MEETS or MEETS-qualified; done.
-   - 5: needs-classify. Record each listed red from its capture:
-     `ship-measure classify --case <id> --round <r> --trials <2,5> --class <class> --evidence "<path:line>"`.
-     Qualifying: `provider` (only on the trial's own provider error),
-     `judge-noise`, `model-miss` (cite the line). Fix round: `timeout`,
-     `hang`, `regression`, `fixable`. `unclassified`: reviewed, no evidence.
-   - 6: EXTEND. `ship-measure extend --case <id> --round <r>` once, on the
-     unchanged tree; never a third batch.
-   - 1: BELOW, a fix round.
-5. **Fix at the cause.** Root-cause the failed trials from their captures in
-   `.context/ship-measure/<case>/<round>/tNN/` and change the cause.
-6. **Re-measure.** `ship-measure measure --case <id> --round round-<n> --fix "<cause and change>"`,
-   then item 4. Call a case fixed only with a named causal change and every
-   failure in the closing measurement explained;
-   report "observed k/n after fix at <cause>", never a proven rate.
-7. **Stop.** Exit 3 is a named red (round limit, budget, or two void
-   batches): stop, do not push, and report `ship-measure report` with every trial.
-
-**Gate once.** When every red case measures at or above target, run the full
-gate once (Step 6 item 2). When the project's CI runs that gate on push (gstack:
-the pull request's `evals` workflow), the push is the gate run: push and read
-that run, and do not also start the gate command (gstack's `bun run eval:bg:pr`
-on a pushed head dispatches a second paid run). Put the `ship-measure report` table (estimated
-and actual spend per case) in the PR body.

package/.agent/skills/gstack-ship/sections/measure.md.tmpl

@@ -1,64 +0,0 @@
-## Measure-then-fix loop (a red paid eval or a failed free-suite shard)
-
-Every rerun here is **diagnostic, not a verdict**: it never changes the recorded
-verdict of the run that failed, its artifacts are labeled `diagnostic` under
-`.context/ship-measure/` (never the eval history), and the lane verdict comes
-only from the one full gate run at the end. Never raise a budget, lower a
-threshold, add a verdict retry or skip a case to get a pass.
-`ship-measure` below means `bun run ~/.claude/skills/gstack/scripts/ship-measure.ts`.
-
-**Failed free-suite shard (Step 5).** Before calling the failure pre-existing or
-pushing, rerun that shard's exact file list (in run order) with
-`ship-measure free --files <f1,f2,...>` (gstack local runs: `--shard <i>`): 10
-reruns, rerun 1 alone as the baseline and the rest labeled parallel, each with
-its own HOME and state root, the flaky retry off, under a 10-minute cap.
-`ship_rerun_backend=ubicloud` with `UBICLOUD_API_KEY` set runs them on one
-Ubicloud VM. If the runner cannot take a file list, rerun the whole failing
-command 10 times. Report the pass rate, the completed count (for example 6 of 10
-completed at the cap) and one failure capture, then continue the triage.
-
-**Red paid eval (Step 6).** For each red case:
-
-1. **Classify.** Read the red line's cause, evidence and Expected/Received
-   (`failure_cause`, `failure_detail`; gstack: `bun run eval:pass-rates --run <run> --case <id>`).
-   Name it: product change from this branch, detector or actor defect, fixture
-   defect, provider event, or model miss. A detector fix gets a free replay test
-   before any paid trial. A red that is infrastructure (provider outage, runner
-   loss) may skip measurement: `ship-measure skip --case <id> --reason "<why>"`
-   labels it `unmeasured` in the PR body. It never counts as a pass.
-2. **Show the plan.** Print `ship-measure table` (trials, bar and budget per
-   kind, from the `ship_measure_*` gstack config keys) and the estimate:
-   per-trial cost from pass-rate history times trials, or "estimate unknown".
-3. **Measure.** `ship-measure measure --case <id> --round baseline [--cost-per-trial <usd>]`
-   runs the case alone on the current head at its kind's count, in parallel,
-   through the project's documented single-case eval command,
-   `--command '<command> {case}'` (found the way Step 4 finds test commands;
-   gstack needs none and accepts judge ids). With no documented command, ask
-   once and record the answer in the report. Exit 2 needs approval: ask once
-   with its reason, then rerun with `--approved`.
-4. **Decide by the exit code** (MEETS 9/10, MEETS-qualified 8/10 with every
-   red qualifying, EXTEND 7/10; behavior 11/12, 10/12, 9/12):
-   - 0: MEETS or MEETS-qualified; done.
-   - 5: needs-classify. Record each listed red from its capture:
-     `ship-measure classify --case <id> --round <r> --trials <2,5> --class <class> --evidence "<path:line>"`.
-     Qualifying: `provider` (only on the trial's own provider error),
-     `judge-noise`, `model-miss` (cite the line). Fix round: `timeout`,
-     `hang`, `regression`, `fixable`. `unclassified`: reviewed, no evidence.
-   - 6: EXTEND. `ship-measure extend --case <id> --round <r>` once, on the
-     unchanged tree; never a third batch.
-   - 1: BELOW, a fix round.
-5. **Fix at the cause.** Root-cause the failed trials from their captures in
-   `.context/ship-measure/<case>/<round>/tNN/` and change the cause.
-6. **Re-measure.** `ship-measure measure --case <id> --round round-<n> --fix "<cause and change>"`,
-   then item 4. Call a case fixed only with a named causal change and every
-   failure in the closing measurement explained;
-   report "observed k/n after fix at <cause>", never a proven rate.
-7. **Stop.** Exit 3 is a named red (round limit, budget, or two void
-   batches): stop, do not push, and report `ship-measure report` with every trial.
-
-**Gate once.** When every red case measures at or above target, run the full
-gate once (Step 6 item 2). When the project's CI runs that gate on push (gstack:
-the pull request's `evals` workflow), the push is the gate run: push and read
-that run, and do not also start the gate command (gstack's `bun run eval:bg:pr`
-on a pushed head dispatches a second paid run). Put the `ship-measure report` table (estimated
-and actual spend per case) in the PR body.