@adaptabletools/adaptable 23.0.4 → 23.0.5-canary.1

package/src/Api/Internal/CalculatedColumnInternalApi.js

@@ -4,10 +4,6 @@ import ArrayExtensions from '../../Utilities/Extensions/ArrayExtensions';
 import StringExtensions from '../../Utilities/Extensions/StringExtensions';
 import { CALCULATED_COLUMN_TYPE } from '../../AdaptableState/Common/AdaptableColumn';
 export class CalculatedColumnInternalApi extends ApiBase {
-    /**
-     * Returns all the references in the AdaptableState of the given CalculatedColumn
-     * @param calculatedColumn CalculatedColumn to be checked
-     */
     getCalculatedColumnModuleReferences(calculatedColumn) {
         const references = [];
         this.getAdaptableInternalApi()
@@ -21,10 +17,6 @@ export class CalculatedColumnInternalApi extends ApiBase {
         });
         return references;
     }
-    /**
-     * Returns all Calculated Columns whose Expression contains the ColumnId
-     * @param columnId ColumnId to check
-     */
     getCalculatedColumnsReferencingColumnId(columnId) {
         const calcColumns = [];
         this.getCalculatedColumnApi()
@@ -36,18 +28,10 @@ export class CalculatedColumnInternalApi extends ApiBase {
         });
         return calcColumns;
     }
-    /**
-     * Gets any ColumnIds referenced in a Calculated Column
-     * @param calculatedColumn Calculated Column to check
-     */
     getReferencedColumnIdsForCalculatedColumn(calculatedColumn) {
         const columnIds = this.getExpressionApi().getColumnsFromExpression(this.getExpressionApi().getAdaptableQueryExpression(calculatedColumn.Query));
         return columnIds;
     }
-    /**
-     * Gets any ColumnIds referenced in a Calculated Column
-     * @param calculatedColumnId CalculatedColumnId to check
-     */
     getReferencedColumnIdsForCalculatedColumnId(calculatedColumnId) {
         const calculatedColumn = this.getCalculatedColumnApi()
             .getCalculatedColumns()
@@ -102,7 +86,6 @@ export class CalculatedColumnInternalApi extends ApiBase {
                 if (isExternalEvaluation) {
                     return params.data?.[calculatedColumn.ColumnId];
                 }
-                // if the grid data is NOT client side, we can aggregate only simple scalar expression (which depend on row data, not on other rows)
                 if (this.getGridApi().getAgGridRowModelType() !== 'clientSide' &&
                     StringExtensions.IsNotNullOrEmpty(calculatedColumn.Query.AggregatedScalarExpression)) {
                     return params.data?.[calculatedColumn.ColumnId];

package/src/Api/Internal/ChartingInternalApi.js

@@ -25,7 +25,6 @@ export class ChartingInternalApi extends ApiBase {
         }
         return candidate;
     }
-    // External lib charting service
     isExternalChartOpened(chartDefinition) {
         const externalChartingOptions = this.getChartingOptions().externalChartingOptions;
         if (!externalChartingOptions?.isChartOpened) {

package/src/Api/Internal/ColumnFilterInternalApi.js

@@ -6,20 +6,11 @@ import { COLUMN_FILTER_WINDOW } from '../../View/Components/Popups/WindowPopups/
 import { ApiBase } from '../Implementation/ApiBase';
 import { AdaptableFilterHandler } from '../../agGrid/AdaptableFilterHandler';
 export class ColumnFilterInternalApi extends ApiBase {
-    /**
-     * Returns Predicate Definition for given Column and Quick Filter shortcut
-     * @param shortcut Quick Filter shortcut to lookup
-     * @param column AdapTable Column being Filtered
-     */
     findPredicateDefByShortcut(shortcut, column) {
         return this.getColumnFilterApi()
             .getFilterPredicateDefsForColumn(column)
             .find((predicateDef) => this.getPredicateDefShortcuts(predicateDef)?.includes(shortcut));
     }
-    /**
-     * Creates an Equality Filter based on given Grid Cells
-     * @param gridCells cells to create Filter for
-     */
     createValuesColumnFilterForCells(gridCells) {
         if (!gridCells) {
             return null;
@@ -36,10 +27,6 @@ export class ColumnFilterInternalApi extends ApiBase {
         const [savedFilter] = this.getColumnFilterApi().setColumnFilters([filter]) || [null];
         return savedFilter;
     }
-    /**
-     *  Creates an Equality Filter based on given Grid Cell
-     * @param gridCell cell to create Filter for
-     */
     createEqualityColumnFilterForCell(gridCell) {
         if (!gridCell) {
             return null;
@@ -57,11 +44,6 @@ export class ColumnFilterInternalApi extends ApiBase {
         const [savedFilter] = this.getColumnFilterApi().setColumnFilters([filter]) || [null];
         return savedFilter;
     }
-    /**
-     * Calls AdapTableQL to evaluate Filter for given Row
-     * @param columnFilter Column Filter to use
-     * @param node Row Node to evaluate
-     */
     evaluateColumnFilter(columnFilter, node) {
         if (!columnFilter.Predicates.length) {
             return true;
@@ -97,24 +79,9 @@ export class ColumnFilterInternalApi extends ApiBase {
             predicatesOperator: columnFilter.PredicatesOperator,
             ...this.getAdaptableInternalApi().buildBaseContext(),
         };
-        //  #column_filter_predicates_evaluation
         return this.getPredicateApi().handlePredicates(columnFilter.Predicates, predicateDefHandlerContext, true);
     }
-    /**
-     * Checks if the filter action should trigger Column Filtering
-     *
-     * @param action Filtering Action
-     */
     shouldNewColumnFilterTriggerColumnFiltering(action) {
-        // trigger filter change only:
-        // - new -> new filter is active
-        // - clear -> previous filters was active
-        // - clearAll -> a filter was active
-        // - edit -> same => input change
-        // - edit -> different & new is active
-        // - edit -> different & old was active
-        // - set -> new filter is active
-        // filter -> suspend changes
         const isNewAndActive = action.type === LayoutRedux.LAYOUT_COLUMN_FILTER_ADD &&
             this.getColumnFilterApi().isColumnFilterActive(action.columnFilter);
         const isClearAndPreviousWasActive = action.type === LayoutRedux.LAYOUT_COLUMN_FILTER_CLEAR &&
@@ -127,19 +94,15 @@ export class ColumnFilterInternalApi extends ApiBase {
         if (action.type === LayoutRedux.LAYOUT_COLUMN_FILTER_EDIT) {
             const newFilter = action.columnFilter;
             const previous = this.getColumnFilterApi().getColumnFilterForColumn(newFilter.ColumnId);
-            // same filter edit, so always trigger
             if (previous &&
                 newFilter &&
-                // same predicates
                 areArraysEqual(previous.Predicates.map((p) => p.PredicateId), newFilter.Predicates.map((p) => p.PredicateId))) {
                 isEditTrigger = true;
-                // new filter is active
             }
             else if (this.getColumnFilterApi().isColumnFilterActive(newFilter)) {
                 isEditTrigger = true;
             }
             else if (this.getColumnFilterApi().isColumnFilterActive(previous)) {
-                // previous filter was active
                 isEditTrigger = true;
             }
         }
@@ -158,17 +121,11 @@ export class ColumnFilterInternalApi extends ApiBase {
             isSetAndActive ||
             isSuspendChanged);
     }
-    /**
-     * Compares to sets of Column Filters to see if they are identical
-     * @param filters1
-     * @param filters2
-     */
     areColumnFiltersDifferent(oldFilters, newFilters) {
         if (ArrayExtensions.IsNullOrEmpty(oldFilters) && ArrayExtensions.IsNullOrEmpty(newFilters)) {
             return false;
         }
         return !ArrayExtensions.areArraysEqualWithCustomComparator(oldFilters, newFilters, (filter1, filter2) => {
-            // Compare basic properties
             if (filter1.ColumnId !== filter2.ColumnId) {
                 return false;
             }
@@ -178,12 +135,10 @@ export class ColumnFilterInternalApi extends ApiBase {
             if ((filter1.IsSuspended || false) !== (filter2.IsSuspended || false)) {
                 return false;
             }
-            // Compare predicates (regardless of order)
             return ArrayExtensions.areArraysEqualWithCustomComparator(filter1.Predicates, filter2.Predicates, (pred1, pred2) => {
                 if (pred1.PredicateId !== pred2.PredicateId) {
                     return false;
                 }
-                // Compare inputs array (might be primitives or objects)
                 return ArrayExtensions.areArraysEqualWithCustomComparator(pred1.Inputs, pred2.Inputs, (input1, input2) => {
                     if (input1 === input2) {
                         return true;
@@ -191,7 +146,6 @@ export class ColumnFilterInternalApi extends ApiBase {
                     if (typeof input1 !== typeof input2) {
                         return false;
                     }
-                    // For object inputs, use JSON comparison
                     if (typeof input1 === 'object' && input1 !== null && input2 !== null) {
                         return JSON.stringify(input1) === JSON.stringify(input2);
                     }
@@ -237,16 +191,11 @@ export class ColumnFilterInternalApi extends ApiBase {
             },
         });
     }
-    /**
-     * First we try to get the cached values from the FilterHandler
-     * Only if the FilterHandler is not available we fallback to the GridApi method
-     */
     async getColumnFilterValues(options) {
         const filterOptions = this.getOptionsApi().getFilterOptions();
         const newOptions = {
             columnId: options.columnId,
             get currentSearchValue() {
-                // we need this in order to keep it lazy
                 return options.currentSearchValue;
             },
             previousResult: undefined,
@@ -278,7 +227,6 @@ export class ColumnFilterInternalApi extends ApiBase {
             };
             return manuallyApplyColumnFilterOpt(context);
         }
-        // fallback, should never happen
         return false;
     }
     getAdaptableFilterHandler(columnId) {

package/src/Api/Internal/ColumnInternalApi.js

@@ -11,13 +11,6 @@ export function getAutoRowGroupColumnIdFor(columnId) {
     return `${AG_GRID_GROUPED_COLUMN}-${columnId}`;
 }
 export class ColumnInternalApi extends ApiBase {
-    /**
-     * Retrieves 'ColumnType' property for a given Column
-     *   isCumulativeAggregate(input: string): boolean {
-     *     return !!this.getNodesFromExpression(input, 'CUMUL')?.length;
-     *   }
-     * @param columnId Column to use
-     */
     getAgGridColumnType(columnId) {
         return this._adaptable.getAgGridColumnType(columnId);
     }
@@ -36,9 +29,6 @@ export class ColumnInternalApi extends ApiBase {
         });
         return uniq(colTypes).filter((c) => StringExtensions.IsNotNullOrEmptyOrWhiteSpace(c));
     }
-    /**
-     * Retrieves a list providing the Friendly Name / Caption for all columns
-     */
     getAllColumnFriendlyNames() {
         return this.getColumnApi()
             .getColumns()
@@ -49,18 +39,10 @@ export class ColumnInternalApi extends ApiBase {
     getAutoRowGroupColumnIdFor(columnId) {
         return getAutoRowGroupColumnIdFor(columnId);
     }
-    /**
-     * Retrieves AG Grid's field property for the column
-     * @param columnId columnId to look up
-     */
     getAgGridColumnFieldForAdaptableColumn(columnId) {
         const agGridColumn = this.getAgGridColumnForAdaptableColumn(columnId);
         return agGridColumn.getColDef().field || '';
     }
-    /**
-     * Retrieves AG Grid's column for an Adaptable column
-     * @param columnId columnId to look up
-     */
     getAgGridColumnForAdaptableColumn(columnId) {
         return this._adaptable.getAgGridColumnForColumnId(columnId);
     }
@@ -75,7 +57,6 @@ export class ColumnInternalApi extends ApiBase {
                 this.getColumnApi().isFdc3Column(columnId));
     }
     getColumnHeaderName(params) {
-        // this is the same object, but casting it makes it easier to work with
         const isColumn = !params.columnGroup;
         const columnParams = params;
         const isColumnGroup = !!params.columnGroup;
@@ -83,16 +64,13 @@ export class ColumnInternalApi extends ApiBase {
         const defaultHeaderName = params.colDef?.headerName ??
             (isColumn ? StringExtensions.CamelCaseToHumanText(columnParams.colDef?.field) : '') ??
             '';
-        // for now we override ONLY the header names
         if (params.location !== 'header') {
             return defaultHeaderName;
         }
-        // 1. Layout specific header has the highest priority
         const layoutSpecificCustomHeader = this.getLayoutApi().getCurrentLayout().ColumnHeaders?.[isColumn ? columnParams.column.getColId() : columnGroupParams.columnGroup.getGroupId()];
         if (layoutSpecificCustomHeader) {
             return layoutSpecificCustomHeader;
         }
-        // 2. check for custom ColumnOptions.columnHeader
         if (typeof this.getColumnOptions().columnHeader === 'function') {
             const columnHeaderContext = this.buildColumnHeaderContext(params, defaultHeaderName);
             if (columnHeaderContext === 'skip') {
@@ -101,7 +79,6 @@ export class ColumnInternalApi extends ApiBase {
             const customHeader = this.getColumnOptions().columnHeader(columnHeaderContext);
             return customHeader;
         }
-        // 3. fallback to default header name
         return defaultHeaderName;
     }
     buildColumnHeaderContext(params, defaultHeaderName) {
@@ -114,7 +91,6 @@ export class ColumnInternalApi extends ApiBase {
             currentLayoutName: currentLayout.Name,
             currentLayoutType: currentLayoutType,
         };
-        // makes it easier to work with
         const currentTableLayout = currentLayout;
         const currentPivotLayout = currentLayout;
         if (params.column?.getColId() === AG_GRID_GROUPED_COLUMN) {
@@ -131,7 +107,6 @@ export class ColumnInternalApi extends ApiBase {
         if (params.column?.getColId().startsWith(`${AG_GRID_GROUPED_COLUMN}-`)) {
             const columnType = 'rowGroupColumn';
             const columnId = params.column.getColId();
-            // remove `${AG_GRID_GROUPED_COLUMN}-` from beginning of columnId
             const groupColumnId = columnId.substring(`${AG_GRID_GROUPED_COLUMN}-`.length);
             return {
                 ...baseContext,
@@ -144,8 +119,6 @@ export class ColumnInternalApi extends ApiBase {
             if (params.columnGroup) {
                 const columnType = 'tableColumnGroup';
                 if (!params.colDef?.children) {
-                    // AG Grid created virtual column groups for all columns
-                    // we want to skip those
                     return 'skip';
                 }
                 return {
@@ -178,7 +151,6 @@ export class ColumnInternalApi extends ApiBase {
         if (baseContext.currentLayoutType === 'pivot') {
             if (params.columnGroup) {
                 if (!params.colDef?.pivotKeys) {
-                    // we might have user defined colGroups, but we are not interested in them in pivot mode
                     return 'skip';
                 }
                 const columnType = 'pivotColumnGroup';
@@ -200,7 +172,6 @@ export class ColumnInternalApi extends ApiBase {
                     const aggregatedColumnId = pivotValueCol?.getColId();
                     const currentLayoutAggCols = currentPivotLayout.PivotAggregationColumns?.map((col) => col.ColumnId);
                     if (!currentLayoutAggCols?.includes(aggregatedColumnId)) {
-                        // this column is not an aggregation column
                         return 'skip';
                     }
                     return {
@@ -254,7 +225,6 @@ export class ColumnInternalApi extends ApiBase {
                     const aggregatedColumnId = pivotValueCol?.getColId();
                     const currentLayoutAggCols = currentPivotLayout.PivotAggregationColumns?.map((col) => col.ColumnId);
                     if (!currentLayoutAggCols?.includes(aggregatedColumnId)) {
-                        // this column is not an aggregation column
                         return 'skip';
                     }
                     return {
@@ -268,7 +238,6 @@ export class ColumnInternalApi extends ApiBase {
                 }
             }
         }
-        // if nothing matched, we skip this column[group]
         return 'skip';
     }
     hasArrayDataType(column) {
@@ -285,7 +254,6 @@ export class ColumnInternalApi extends ApiBase {
         return this.getColumnApi().hasColumnType(columnIdentifier, HIDDEN_COLUMN_TYPE);
     }
     getColumnDateTypes() {
-        // this is required because Adaptable uses 'date' type for all AG Grid date types: 'date', 'dateString'
         return ['date'];
     }
 }

package/src/Api/Internal/CustomSortInternalApi.js

@@ -18,7 +18,6 @@ export class CustomSortInternalApi extends ApiBase {
         return `${value}`;
     }
     getDefaultCustomSortComparer(columnId, columnValues) {
-        // have to return a function that may not have access to this
         const gridApi = this.getGridApi();
         const columnDataType = this.getColumnApi().getColumnDataTypeForColumnId(columnId);
         const _this = this;
@@ -31,22 +30,18 @@ export class CustomSortInternalApi extends ApiBase {
             let containsFirstElement = indexFirstElement >= 0;
             let indexSecondElement = columnValues.indexOf(secondCustomSortValue);
             let containsSecondElement = indexSecondElement >= 0;
-            //if none of the element are in the list we jsut return normal compare
             if (!containsFirstElement && !containsSecondElement) {
                 if (valueA == valueB) {
                     return 0;
                 }
                 return valueA < valueB ? -1 : 1;
             }
-            //if first item not in the list make sure we put it after the second item
             if (!containsFirstElement) {
                 return 1;
             }
-            //if second item not in the list make sure we put it after the first item
             if (!containsSecondElement) {
                 return -1;
             }
-            //return the comparison from the list if the two items are in the list
             return indexFirstElement - indexSecondElement;
         };
     }

package/src/Api/Internal/DashboardInternalApi.js

@@ -1,38 +1,15 @@
 import { ALL_TOOLBARS } from '../../AdaptableState/Common/Types';
 import { ApiBase } from '../Implementation/ApiBase';
 export class DashboardInternalApi extends ApiBase {
-    /**
-     * Registry of reset-callbacks keyed by Custom-Toolbar name. Each
-     * `CustomToolbarCmp` registers itself on mount so the public
-     * {@link DashboardApi.resetCustomToolbarFormData} method can ask
-     * a specific instance to roll its `toolbarForm` data back to its
-     * declared `defaultValue`s without re-mounting the component.
-     */
     customToolbarFormResetters = new Map();
-    /**
-     * Register a reset callback for a Custom Toolbar. Idempotent: a second
-     * registration for the same name overwrites the previous entry, so a
-     * remount of the same toolbar always wins.
-     */
     registerCustomToolbarFormResetter(toolbarName, resetter) {
         this.customToolbarFormResetters.set(toolbarName, resetter);
     }
-    /**
-     * Tear down a previously-registered reset callback, but only if it's
-     * still the active one. Guards against a stale unmount clobbering a
-     * registration made by a fresh mount of the same toolbar.
-     */
     unregisterCustomToolbarFormResetter(toolbarName, resetter) {
         if (this.customToolbarFormResetters.get(toolbarName) === resetter) {
             this.customToolbarFormResetters.delete(toolbarName);
         }
     }
-    /**
-     * Invokes the registered reset callback for the given toolbar (or all
-     * registered toolbars when `toolbarName` is omitted). Silently no-ops
-     * if no toolbar is registered under the given name - this is benign
-     * (e.g. the toolbar has not yet mounted, or it has no `toolbarForm`).
-     */
     resetCustomToolbarFormData(toolbarName) {
         if (toolbarName) {
             const fn = this.customToolbarFormResetters.get(toolbarName);

package/src/Api/Internal/DataImportInternalApi.js

@@ -56,7 +56,6 @@ export class DataImportInternalApi extends ApiBase {
         };
         this.getAlertApi().displayAdaptableAlert(alert);
         const dataImportedInfo = this.getEventApi().internalApi.fireDataImportedEvent(importData, addedRows, updatedRows);
-        // Dispatch action (purely so it will be in Audit Log)
         this.getAdaptableInternalApi().dispatchReduxAction(InternalRedux.DataImportCompleted(dataImportedInfo));
     }
 }

package/src/Api/Internal/EventInternalApi.js

@@ -36,7 +36,6 @@ export class EventInternalApi extends ApiBase {
             const visibleInNewState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, newDashboardState);
             const visibleInOldState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, oldDashboardState);
             if (visibleInNewState && visibleInOldState) {
-                // check for dashboard collapse/expand/hidden changes
                 return ((oldDashboardState.IsCollapsed && !newDashboardState.IsCollapsed) ||
                     (oldDashboardState.IsHidden && !newDashboardState.IsHidden));
             }
@@ -46,7 +45,6 @@ export class EventInternalApi extends ApiBase {
             const visibleInNewState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, newDashboardState);
             const visibleInOldState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, oldDashboardState);
             if (visibleInNewState && visibleInOldState) {
-                // check for dashboard collapse/expand/hidden changes
                 return ((!oldDashboardState.IsCollapsed && newDashboardState.IsCollapsed) ||
                     (!oldDashboardState.IsHidden && newDashboardState.IsHidden));
             }

package/src/Api/Internal/ExportInternalApi.js

@@ -8,26 +8,19 @@ import Helper from '../../Utilities/Helpers/Helper';
 import * as PopupRedux from '../../Redux/ActionsReducers/PopupRedux';
 import { SystemExportBegin, SystemExportEnd } from '../../Redux/ActionsReducers/InternalRedux';
 export class ExportInternalApi extends ApiBase {
-    /**
-     * Value Items for Report Name Selection
-     */
     getAllAvailableReportNames() {
         return this.getExportApi()
             .getAllReports()
             .map((report) => report.Name);
     }
     isDataChangeInReport(cellDataChangedInfo, report) {
-        // for All Data Report any data change is true so get out asap
         if (report.Name == 'All Data') {
             return true;
         }
-        // Start with the DataChanged Column and go through all possibilities
         switch (report.ReportColumnScope) {
             case 'AllColumns':
-                // has to be relevant so continue to rows
                 break;
             case 'ScopeColumns':
-                // use the Scope object which will tell us if the Column is relevant
                 if (!this.getAdaptableApi().columnScopeApi.isColumnInScopeColumns(cellDataChangedInfo.column, report.Scope)) {
                     return false;
                 }
@@ -41,27 +34,23 @@ export class ExportInternalApi extends ApiBase {
                 }
                 break;
             case 'VisibleColumns':
-                //  hope that visible column property is updated whenever the layout changes... (need to check!)
                 if (!cellDataChangedInfo.column.visible) {
                     return false;
                 }
                 break;
         }
-        // now do rows
         switch (report.ReportRowScope) {
             case 'AllRows':
                 return true;
             case 'ExpressionRows':
-                return true; // TODO this is the only difficult one - do we check AdapTableQL?  if we can then that is good as we can then do a delta after all...
+                return true;
             case 'SelectedRows':
-                // CellSelection
                 let selectedCellInfo = this.getAdaptableApi().gridApi.getSelectedCellInfo();
                 if (selectedCellInfo && selectedCellInfo.gridCells) {
                     if (selectedCellInfo.gridCells.find((gc) => gc.primaryKeyValue == cellDataChangedInfo.primaryKeyValue)) {
                         return true;
                     }
                 }
-                // Row Selection
                 let selectedRowInfo = this.getAdaptableApi().gridApi.getSelectedRowInfo();
                 if (selectedRowInfo && selectedRowInfo.gridRows) {
                     if (selectedRowInfo.gridRows.find((gr) => gr.primaryKeyValue == cellDataChangedInfo.primaryKeyValue)) {
@@ -243,8 +232,6 @@ export class ExportInternalApi extends ApiBase {
                 Id: 'export-destination-form',
                 Form: customDestination?.form,
                 prepareContext: (context) => {
-                    // we want to give the current popup time to close
-                    // and we reopen with a delay in case this button action causes another popup
                     return new Promise((resolve) => {
                         setTimeout(() => {
                             const preparedContext = {
@@ -342,8 +329,6 @@ export class ExportInternalApi extends ApiBase {
                 type: 'csv',
             };
         }
-        // theoretically 'VisualExcel' is not a valid export format for this function and should be suppressed from UI
-        // but just in case, we handle it here and return a "raw", unstyled Excel file
         if (exportFormat === 'Excel' || exportFormat === 'VisualExcel') {
             const excelExportConverter = this.buildExcelConverter(exportContext.report.Name, exportFormat, exportContext.destination);
             const excelData = excelExportConverter(reportData);

package/src/Api/Internal/ExpressionInternalApi.js

@@ -1,11 +1,6 @@
 import { ApiBase } from '../Implementation/ApiBase';
 import ArrayExtensions from '../../Utilities/Extensions/ArrayExtensions';
 export class ExpressionInternalApi extends ApiBase {
-    /**
-     * Checks if a column is referenced in a given Expression
-     * @param columnId Column to Check
-     * @param expression Expression to Lookup
-     */
     isColumnReferencedInExpression(columnId, expression) {
         const colIds = this.getExpressionApi().getColumnsFromExpression(expression);
         return colIds.some((c) => c === columnId);
@@ -44,9 +39,6 @@ export class ExpressionInternalApi extends ApiBase {
         }
         if (predicates) {
             context.predicates = predicates;
-            // need to find a way to get the columns in the predicates
-            // cand do later
-            //        this.getAdaptableApi().columnScopeApi.getColumnsInScope();
         }
         return !evaluateExpressionExternallyFn(context);
     }
@@ -67,21 +59,6 @@ export class ExpressionInternalApi extends ApiBase {
             ...field,
             label: field.label || field.name,
         }));
-        // const existingFields = new Set<string>();
-        // Exclude fields already in options
-        // optionFields.forEach((field) => existingFields.add(field.value));
-        // const queriableColumns = this.getColumnApi().getQueryableColumns();
-        // Exclude queriable columns
-        // queriableColumns.forEach((column) => existingFields.add(column.field));
-        // const dataFields = this.getFieldsFromData(data).reduce<AdaptableField[]>((acc, field) => {
-        //   if (!existingFields.has(field)) {
-        //     acc.push({
-        //       label: field,
-        //       value: field,
-        //     });
-        //   }
-        //   return acc;
-        // }, []);
         return optionFields;
     }
     getFieldType(field) {

package/src/Api/Internal/Fdc3InternalApi.js

@@ -159,14 +159,12 @@ export class Fdc3InternalApi extends ApiBase {
     handleIntentResolution(intentResolution, context, raisedIntent, app) {
         const relevantRaiseIntentConfig = this.getAllRaiseIntentConfigs().find((config) => config.intentType === raisedIntent && config.contextType === context.type);
         if (typeof relevantRaiseIntentConfig?.handleIntentResolution === 'function') {
-            // call intent specific resolution handler
             relevantRaiseIntentConfig.handleIntentResolution({
                 ...this.getAdaptableInternalApi().buildBaseContext(),
                 intentResolution,
             });
         }
         else {
-            // call global resolution handler (if any)
             this.getFdc3Options().intents?.handleIntentResolution?.({
                 ...this.getAdaptableInternalApi().buildBaseContext(),
                 intentResolution,
@@ -222,7 +220,6 @@ export class Fdc3InternalApi extends ApiBase {
         const defaultConfig = this.getAdaptableInternalApi()
             .getFdc3Service()
             .getUiControlsDefaultConfiguration();
-        // @ts-ignore
         const intentIcon = defaultConfig?.intents[intentType]?.icon ?? {
             name: 'fdc3',
         };
@@ -232,14 +229,12 @@ export class Fdc3InternalApi extends ApiBase {
         const defaultConfig = this.getAdaptableInternalApi()
             .getFdc3Service()
             .getUiControlsDefaultConfiguration();
-        // @ts-ignore
         const contextIcon = defaultConfig?.contexts[contextType]?.icon ?? {
             name: 'fdc3',
         };
         return contextIcon;
     }
     mapRowValueToContextData(rowNode, contextMapping = {}) {
-        // recursively map the row node values to the context data
         const mapContext = (obj) => {
             return Object.keys(obj).reduce((mappedData, contextKey) => {
                 const valueReference = obj[contextKey];
@@ -250,20 +245,16 @@ export class Fdc3InternalApi extends ApiBase {
                     mappedData[contextKey] = mapContext(valueReference);
                 }
                 else {
-                    // map value from row node
-                    // first validate refs
                     if (typeof valueReference !== 'string' ||
                         (!valueReference.startsWith(ColumnRefTypePrefix) &&
                             !valueReference.startsWith(FieldRefTypePrefix))) {
                         this.logError(`Invalid FDC3 value reference for '${contextKey}': ${valueReference}`);
                         return mappedData;
                     }
-                    // '_coldId.columnId'
                     if (valueReference.startsWith(ColumnRefTypePrefix)) {
                         const columnId = valueReference.replace(ColumnRefTypePrefix, '');
                         mappedData[contextKey] = this.getGridApi().getRawValueFromRowNode(rowNode, columnId);
                     }
-                    // '_field.fieldName'
                     if (valueReference.startsWith(FieldRefTypePrefix)) {
                         const fieldId = valueReference.replace(FieldRefTypePrefix, '');
                         mappedData[contextKey] = this.getAdaptableInternalApi().getValueUsingField(rowNode.data, fieldId);

package/src/Api/Internal/FlashingCellInternalApi.js

@@ -3,16 +3,11 @@ import { cloneObject } from '../../Utilities/Helpers/Helper';
 import * as AlertRedux from '../../Redux/ActionsReducers/AlertRedux';
 import { FLASHING_CELL_ROW_KEY } from '../../Utilities/Services/FlashingCellService';
 export class FlashingCellInternalApi extends ApiBase {
-    /**
-     * Merges a Flashing Cell Definition with default values
-     * @param flashingCellDefinition Flashing Cell Definition to Merge
-     */
     mergeFlashingCellDefinitionWithDefaults(flashingCellDefinition) {
         let flashingDefaults = this.getFlashingCellOptions();
         if (!flashingDefaults) {
             return flashingCellDefinition;
         }
-        // deep clone it, otherwise we will mutate&share(!!) the global flashingCellOptions object
         flashingDefaults = cloneObject(flashingDefaults);
         if (!flashingCellDefinition.DownChangeStyle && flashingDefaults.defaultDownChangeStyle) {
             flashingCellDefinition.DownChangeStyle = flashingDefaults.defaultDownChangeStyle;