@adaptabletools/adaptable 23.0.4 → 23.0.5-canary.1

package/src/layout-manager/src/simplifyLayoutModel.js

@@ -21,22 +21,13 @@ export function simplifyTableLayoutModel(layout) {
         delete layout.RowGroupedColumns;
     }
     if (!layout.RowGroupedColumns && layout.RowGroupValues) {
-        // delete layout.RowGroupValues;
     }
     if (!layout.SuppressAggFuncInHeader) {
         delete layout.SuppressAggFuncInHeader;
     }
-    // this is the default value
-    // if (layout.RowGroupValues && layout.RowGroupValues.RowGroupDisplay === 'always-collapsed') {
-    //   delete layout.RowGroupValues;
-    // }
-    // if it's a property, but is undefined
-    // make sure we delete it
     if (!layout.RowGroupValues && Object.prototype.hasOwnProperty.call(layout, 'RowGroupValues')) {
         delete layout.RowGroupValues;
     }
-    // if it's a property, but is undefined
-    // make sure we delete it
     if (!layout.ColumnGroupValues &&
         Object.prototype.hasOwnProperty.call(layout, 'ColumnGroupValues')) {
         delete layout.ColumnGroupValues;
@@ -96,8 +87,6 @@ export function simplifyPivotLayoutModel(layout) {
     if (layout.PivotGrandTotal === undefined) {
         delete layout.PivotGrandTotal;
     }
-    // if it's a property, but is undefined
-    // make sure we delete it
     if (!layout.ColumnGroupValues &&
         Object.prototype.hasOwnProperty.call(layout, 'ColumnGroupValues')) {
         delete layout.ColumnGroupValues;

package/src/layout-manager/src/sortColumnIdsByOrder.js

@@ -5,26 +5,19 @@ function insertAtCorrectIndex(result, colId, visibleColumnsIndexes, hiddenColIds
         return;
     }
     if (hiddenColIds.has(prevColId)) {
-        insertAtCorrectIndex(result, colId, visibleColumnsIndexes, hiddenColIds, offset + 1, 
-        /* do not advance this as, as we've encountered a hidden column*/ lastVisibleOffset);
+        insertAtCorrectIndex(result, colId, visibleColumnsIndexes, hiddenColIds, offset + 1, lastVisibleOffset);
         return;
     }
     const prevCol_visibilityIndex = visibleColumnsIndexes[prevColId];
     const currentCol_visibilityIndex = visibleColumnsIndexes[colId];
     if (currentCol_visibilityIndex < prevCol_visibilityIndex) {
-        insertAtCorrectIndex(result, colId, visibleColumnsIndexes, hiddenColIds, offset + 1, 
-        /*make sure we sync with the normal offset, as we've hit a visible col*/ offset + 1);
+        insertAtCorrectIndex(result, colId, visibleColumnsIndexes, hiddenColIds, offset + 1, offset + 1);
     }
     else {
         result.splice(result.length - lastVisibleOffset, 0, colId);
     }
 }
 const ALLOW_MISSING_COLUMNS = true;
-/**
- * This method takes a list of column ids (the current order) and the desired column order
- * and returns the column ids in the desired order, while keeping the hidden columns in their original order.
- *
- */
 export function sortColumnIdsByOrder(columnIds, desiredColumnOrder) {
     const desiredColumnOrderSet = new Set(desiredColumnOrder);
     const columnIdsSet = new Set(columnIds);
@@ -38,8 +31,6 @@ export function sortColumnIdsByOrder(columnIds, desiredColumnOrder) {
         const colId = columnIds[i];
         const colVisible = visibleColumnsIndexes[colId] != null;
         if (!colVisible) {
-            // for cols not present in this layout, we keep them
-            // where they are
             result.push(colId);
             continue;
         }
@@ -50,7 +41,6 @@ export function sortColumnIdsByOrder(columnIds, desiredColumnOrder) {
         desiredColumnOrder.forEach((colId, index, arr) => {
             if (!columnIdsSet.has(colId)) {
                 let nextColId = null;
-                // look for the next colId that is in the columnIdsSet
                 for (let i = index + 1; i < arr.length; i++) {
                     if (columnIdsSet.has(arr[i])) {
                         nextColId = arr[i];

package/src/lib/utils.js

@@ -17,7 +17,6 @@ export const getFocusableElements = (root) => {
         if (el.hasAttribute('disabled') || el.getAttribute('aria-hidden') === 'true') {
             return false;
         }
-        // ignore elements that aren't actually rendered (e.g. display:none)
         return !!(el.offsetWidth || el.offsetHeight || el.getClientRects().length);
     });
 };

package/src/migration/AdaptableUpgradeHelper.js

@@ -29,7 +29,6 @@ export class AdaptableUpgradeHelper {
             return state;
         }
         if (fromVersion < 16) {
-            // until version 16 we didn't have versioning
             fromVersion = 16;
         }
         const versionUpgrades = Array.from(upgradeHelper.versionUpgrades.keys());
@@ -44,7 +43,6 @@ export class AdaptableUpgradeHelper {
         return updatedState;
     }
     getCurrentMajorVersion(version) {
-        // is good enough for now, we just need to make sure we don't forget to update it
         return parseInt(version.split('.')[0]) || 24;
     }
     getConsoleLogger() {

package/src/migration/VersionUpgrade17.js

@@ -21,7 +21,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
         ]);
     }
     migrateChartingState(state) {
-        // const allChartDefinitions = this.api.chartingApi.getChartDefinitions();
         const allChartDefinitions = state.Charting?.ChartDefinitions;
         if (Array.isArray(allChartDefinitions)) {
             allChartDefinitions
@@ -32,8 +31,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
                     delete charDefinition.model;
                 }
                 if (!('Name' in charDefinition)) {
-                    // default to chartId
-                    // @ts-ignore possible because First iteration had no 'Name' and model was under 'model' key (lowercase)
                     charDefinition.Name = charDefinition.Model.chartId;
                 }
             });
@@ -41,7 +38,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
         return state;
     }
     migrateColumnFilterState(state) {
-        // Update Module Buttons
         const moduleButtons = state.Dashboard?.ModuleButtons;
         if (moduleButtons?.length && !moduleButtons.includes('ColumnFilter')) {
             const dashboardState = state.Dashboard ?? {};
@@ -52,7 +48,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
                 return moduleButton;
             });
         }
-        // Update Toolbars
         const tabs = state.Dashboard?.Tabs;
         if (Array.isArray(tabs)) {
             state.Dashboard.Tabs = tabs.map((tab) => {
@@ -60,14 +55,12 @@ export class VersionUpgrade17 extends VersionUpgrade {
                     !tab.Toolbars.includes('ColumnFilter')) {
                     return {
                         ...tab,
-                        // replace with 'GridFilter'
                         Toolbars: tab.Toolbars.map((t) => (t == 'Filter' ? 'ColumnFilter' : t)),
                     };
                 }
                 return tab;
             });
         }
-        // - move pinned toolbars
         const pinnedToolbars = state.Dashboard?.PinnedToolbars;
         if (pinnedToolbars && !pinnedToolbars?.includes('ColumnFilter')) {
             state.Dashboard.PinnedToolbars = pinnedToolbars.map((pinnedToolbar) => {
@@ -77,7 +70,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
                 return pinnedToolbar;
             });
         }
-        // Update Status Bar
         const statusBars = state.StatusBar?.StatusBars;
         if (statusBars) {
             state.StatusBar.StatusBars = statusBars.map((panel) => {
@@ -95,7 +87,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
         return state;
     }
     migrateDashboardState(state) {
-        // let dashboardState: any = this.api.dashboardApi.getDashboardState();
         let dashboardState = state.Dashboard;
         if (dashboardState?.VisibleButtons) {
             this.logger.warn(`Migrating deprecated DashboardState.VisibleButtons: [${dashboardState.VisibleButtons}].`);
@@ -103,7 +94,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
                 ...state.Dashboard.ModuleButtons,
                 ...dashboardState.VisibleButtons,
             ];
-            //@ts-ignore delete as no longer needed
             delete state.Dashboard.VisibleButtons;
         }
         return state;
@@ -120,16 +110,12 @@ export class VersionUpgrade17 extends VersionUpgrade {
         return state;
     }
     migrateFormatColumnState(state) {
-        // const formatColumns = this.api.formatColumnApi.getFormatColumns();
         const formatColumns = state.FormatColumn?.FormatColumns || [];
         formatColumns.forEach((formatColumn) => {
             if (formatColumn.Rule && 'Predicate' in formatColumn.Rule) {
-                //@ts-ignore ignore
                 updateSingleToMultiplePredicates(formatColumn.Rule);
             }
         });
-        // update ConditionalStyle StatusBarPanel
-        // const oldStatusBars = this.api.internalApi.getState().StatusBar.StatusBars;
         const statusBars = state.StatusBar?.StatusBars || [];
         let replaceConditionalStyleStatusBar = false;
         statusBars.forEach((statusBar) => ({
@@ -144,14 +130,10 @@ export class VersionUpgrade17 extends VersionUpgrade {
                 })),
             ],
         }));
-        // update ConditionalStyle dashboard buttons
-        // const dashboardModuleButtons = this.api.internalApi.getState().Dashboard.ModuleButtons as any;
         const dashboardModuleButtons = state.Dashboard?.ModuleButtons;
         if (dashboardModuleButtons && dashboardModuleButtons.includes('ConditionalStyle')) {
             dashboardModuleButtons[dashboardModuleButtons.indexOf('ConditionalStyle')] = 'FormatColumn';
         }
-        // update ConditionalStyle toolPanel buttons
-        // const toolPanelModuleButtons = this.api.internalApi.getState().ToolPanel.ModuleButtons as any;
         const toolPanelModuleButtons = state.ToolPanel?.ModuleButtons;
         if (toolPanelModuleButtons && toolPanelModuleButtons.includes('ConditionalStyle')) {
             toolPanelModuleButtons[toolPanelModuleButtons.indexOf('ConditionalStyle')] = 'FormatColumn';
@@ -159,7 +141,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
         return state;
     }
     migrateFreeTextColumnState(state) {
-        // make sure all default to type string
         const allFreeTextColumns = state.FreeTextColumn?.FreeTextColumns || [];
         for (const freeTextColumn of allFreeTextColumns) {
             const unTypedCol = freeTextColumn;
@@ -191,7 +172,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
         if (!oldQueryState) {
             return state;
         }
-        // - move query to current layout
         const expression = oldQueryState.CurrentQuery;
         const currentLayout = state.Layout.Layouts?.find((l) => l.Name === state.Layout.CurrentLayout);
         const currentGridFilter = currentLayout?.GridFilter;
@@ -202,13 +182,11 @@ export class VersionUpgrade17 extends VersionUpgrade {
                 Expression: expression,
             };
         }
-        // - move dashboard/toolbar
         state.Dashboard.Tabs?.forEach((tab) => {
             if (tab.Toolbars.includes('Query')) {
                 tab.Toolbars = tab.Toolbars.map((t) => (t == 'Query' ? 'GridFilter' : t));
             }
         });
-        // - move pinned toolbars
         let updatePinnedToolbars = false;
         if (state.Dashboard.PinnedToolbars) {
             state.Dashboard.PinnedToolbars = state.Dashboard.PinnedToolbars.map((pinnedToolbar) => {
@@ -221,9 +199,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
         return state;
     }
     migrateNamedQueryState(state) {
-        // - move named queries from old Query State to this Module
-        // Note: GridFilter Module moves the "old" CurrentQuery into Layout
-        // const oldQueryState: QueryState = this.api.internalApi.getAdaptableState().Query;
         const oldQueryState = state.Query;
         const oldNamedQueries = oldQueryState?.NamedQueries;
         if (ArrayExtensions.IsNotNullOrEmpty(oldNamedQueries)) {
@@ -246,7 +221,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
             return state;
         }
         this.logger.info(`Migrating ${formatColumnsWithColumnStyles.length} FormatColumn styles to StyledColumns.`, formatColumnsWithColumnStyles);
-        // delete the format columns with column styles
         state.FormatColumn.FormatColumns = state.FormatColumn.FormatColumns?.filter((fc) => !fc.ColumnStyle);
         const styledColumns = formatColumnsWithColumnStyles
             .map((formatColumn) => {
@@ -267,9 +241,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
         return state;
     }
     migrateToolPanelState(state) {
-        // const deprecatedToolPanelConfigs: AdaptableToolPanels | undefined = (
-        //   this.api.toolPanelApi.getToolPanelState() as any
-        // ).VisibleToolPanels;
         const deprecatedToolPanelConfigs = state.ToolPanel
             ?.VisibleToolPanels;
         if (deprecatedToolPanelConfigs?.length) {
@@ -292,11 +263,9 @@ export class VersionUpgrade17 extends VersionUpgrade {
         if (ArrayExtensions.IsEmpty(state.FlashingCell?.FlashingCellDefinitions) &&
             ArrayExtensions.IsNotNullOrEmpty(alertState?.FlashingAlertDefinitions)) {
             state.FlashingCell.FlashingCellDefinitions = alertState.FlashingAlertDefinitions;
-            //@ts-ignore delete as no longer needed
             delete state.Alert.FlashingAlertDefinitions;
         }
         state.Alert?.AlertDefinitions?.forEach((alertDefinition) => {
-            // if ShowPopup then change to DisplayNotificate
             if (alertDefinition.AlertProperties &&
                 alertDefinition.AlertProperties.ShowPopup &&
                 alertDefinition.AlertProperties.ShowPopup == true &&
@@ -304,7 +273,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
                 alertDefinition.AlertProperties.DisplayNotification = true;
                 alertDefinition.AlertProperties.ShowPopup = undefined;
             }
-            // if no rule but a predicate then use that
             if (!alertDefinition.Rule) {
                 if (alertDefinition.Predicate && alertDefinition.Predicate != undefined) {
                     const predicate = alertDefinition.Predicate;
@@ -315,7 +283,6 @@ export class VersionUpgrade17 extends VersionUpgrade {
                 }
             }
             else {
-                //migrate alert definitions with `AggregationExpression` (now `AggregatedBooleanExpression`)
                 const obsoleteAggregationExpression = alertDefinition.Rule['AggregationExpression'];
                 if (obsoleteAggregationExpression) {
                     alertDefinition.Rule.AggregatedBooleanExpression = obsoleteAggregationExpression;

package/src/migration/VersionUpgrade20.js

@@ -16,7 +16,6 @@ function transition_pre_20(layout) {
         delete l.ColumnHeadersMap;
     }
     if (l.ColumnWidthMap) {
-        //@ts-ignore
         layout.ColumnWidths = l.ColumnWidthMap;
         delete l.ColumnWidthMap;
     }
@@ -63,25 +62,18 @@ function transition_pre_20(layout) {
             const filter = {
                 ...columnFilter,
             };
-            // version 19 had a single predicate, while version 20 has an array of predicates
-            // @ts-ignore
             if (filter.Predicate) {
-                // @ts-ignore
                 filter.Predicates = [filter.Predicate];
-                // @ts-ignore
                 delete filter.Predicate;
             }
             if (!Array.isArray(filter.Predicates)) {
                 filter.Predicates = [];
             }
             filter.Predicates = filter.Predicates.map((p) => {
-                // the following predicate ids were renamed:
-                // Values -> In
                 if (p.PredicateId === 'Values') {
                     p = { ...p };
                     p.PredicateId = 'In';
                 }
-                // ExcludeValues -> NotIn
                 if (p.PredicateId === 'ExcludeValues') {
                     p = { ...p };
                     p.PredicateId = 'NotIn';
@@ -150,7 +142,6 @@ export class VersionUpgrade20 extends VersionUpgrade {
     }
     migrateColTypeToDataType(state) {
         this.logger.info('Migrating column types to data types.');
-        // Calculated Column DataType
         const calculatedColumnState = state.CalculatedColumn;
         if (calculatedColumnState && calculatedColumnState.CalculatedColumns) {
             calculatedColumnState.CalculatedColumns.forEach((cc) => {
@@ -168,7 +159,6 @@ export class VersionUpgrade20 extends VersionUpgrade {
                 }
             });
         }
-        // FreeText Column DataType
         const freeTextColumnState = state.FreeTextColumn;
         if (freeTextColumnState && freeTextColumnState.FreeTextColumns) {
             freeTextColumnState.FreeTextColumns.forEach((fc) => {
@@ -192,18 +182,12 @@ export class VersionUpgrade20 extends VersionUpgrade {
         const sparklineState = state.StyledColumn;
         if (sparklineState && sparklineState.StyledColumns) {
             sparklineState.StyledColumns.forEach((styledColumn) => {
-                // @ts-ignore renamed 'SparkLineStyle' to 'SparklineStyle'
                 if (styledColumn.SparkLineStyle == undefined) {
                     return;
                 }
-                // @ts-ignore renamed 'SparkLineStyle' to 'SparklineStyle'
-                // @ts-ignore
                 styledColumn.SparklineStyle = styledColumn.SparkLineStyle;
-                // @ts-ignore
                 delete styledColumn.SparkLineStyle;
-                // @ts-ignore the previous type was "column"
                 if (styledColumn.SparklineStyle?.options?.type === 'column') {
-                    // @ts-ignore the previous type was "column"
                     styledColumn.SparklineStyle.options.type = 'bar';
                     styledColumn.SparklineStyle.options.direction = 'vertical';
                 }
@@ -225,13 +209,9 @@ export class VersionUpgrade20 extends VersionUpgrade {
                 if (obsoleteHighlightStyle) {
                     const obsoleteKeys = ['fill', 'stroke', 'strokeWidth'];
                     obsoleteKeys.forEach((obsoleteKey) => {
-                        if (
-                        // @ts-ignore
-                        obsoleteHighlightStyle?.[obsoleteKey] != undefined) {
+                        if (obsoleteHighlightStyle?.[obsoleteKey] != undefined) {
                             const itemHighlightStyle = obsoleteHighlightStyle.item ?? {};
-                            // @ts-ignore
                             itemHighlightStyle[obsoleteKey] = obsoleteHighlightStyle?.[obsoleteKey];
-                            // @ts-ignore
                             delete styledColumn.SparklineStyle.options.highlightStyle[obsoleteKey];
                         }
                     });

package/src/migration/VersionUpgrade21.js

@@ -9,11 +9,8 @@ export class VersionUpgrade21 extends VersionUpgrade {
         const layoutState = state.Layout;
         if (layoutState && layoutState.Layouts) {
             layoutState.Layouts = layoutState.Layouts.map((layout) => {
-                //@ts-ignore
                 if (layout.ColumnWidths && !layout.ColumnSizing) {
-                    //@ts-ignore
                     layout.ColumnSizing = columnWidthsToColumnSizing(layout.ColumnWidths);
-                    //@ts-ignore
                     delete layout.ColumnWidths;
                 }
                 return layout;

package/src/migration/VersionUpgrade22.js

@@ -6,7 +6,6 @@ export class VersionUpgrade22 extends VersionUpgrade {
         this.migrateNamedObjectState(state);
         return state;
     }
-    // We have added a Name property to all AdapTable objects
     migrateNamedObjectState(state) {
         this.patchCustomSortName(state.CustomSort);
         this.patchFlashingCellName(state.FlashingCell);
@@ -16,7 +15,6 @@ export class VersionUpgrade22 extends VersionUpgrade {
         this.patchAlertName(state.Alert);
         this.patchScheduleName(state.Schedule);
     }
-    // We have moved CellAlignment (renamed Alignment) from independent property into Style
     migrateFormatColumnState(state) {
         const formatColumnState = state.FormatColumn;
         if (formatColumnState && formatColumnState.FormatColumns) {
@@ -29,14 +27,11 @@ export class VersionUpgrade22 extends VersionUpgrade {
                         ExcludeTotalRows: false,
                     };
                 }
-                //@ts-ignore
                 if (formatColumn.CellAlignment) {
                     formatColumn.Style = {
                         ...formatColumn.Style,
-                        //@ts-ignore
                         Alignment: formatColumn.CellAlignment,
                     };
-                    //@ts-ignore
                     delete formatColumn.CellAlignment;
                 }
                 return formatColumn;
@@ -127,7 +122,6 @@ export class VersionUpgrade22 extends VersionUpgrade {
             return;
         }
         const legacySchedule = scheduleState;
-        // Patch Reminder Schedules
         legacySchedule.Reminders?.forEach((reminder) => {
             if (!reminder.Name) {
                 const header = reminder.Header || '';
@@ -135,7 +129,6 @@ export class VersionUpgrade22 extends VersionUpgrade {
                 reminder.Name = `Reminder-${this.hashStrings(['Reminder', header, message])}`;
             }
         });
-        // Patch Report Schedules
         legacySchedule.ReportSchedules?.forEach((report) => {
             if (!report.Name) {
                 const reportName = report.ReportName || '';
@@ -171,10 +164,6 @@ export class VersionUpgrade22 extends VersionUpgrade {
         }
         return hash + 1000;
     }
-    /**
-     * Stringifies an object after removing metadata properties (Uuid, Source, AdaptableVersion)
-     * to ensure deterministic hashing regardless of generated values.
-     */
     stringifyWithoutMetadata(obj) {
         if (!obj) {
             return '';

package/src/migration/VersionUpgrade23.js

@@ -1,11 +1,5 @@
 import { VersionUpgrade } from './VersionUpgrade';
 import { mergeBarStyleCellTextProperties } from '../Utilities/Helpers/StyledColumns/BarStylesHelper';
-/**
- * Forward v22 `{ CellText, CellTextPosition }` into the canonical per-value
- * layout. Each token in `CellText` becomes one placement on the
- * `CellTextLayout` with `Horizontal: 'Left'` and `Vertical = CellTextPosition`.
- * Returns `undefined` when no v22 cell-text was configured.
- */
 const migrateLegacyPercentBarCellText = (legacy) => {
     const tokens = legacy.CellText ?? [];
     if (!tokens.length) {
@@ -52,18 +46,6 @@ export class VersionUpgrade23 extends VersionUpgrade {
         const { Schedule: _removed, ...stateWithoutSchedule } = state;
         return stateWithoutSchedule;
     }
-    /**
-     * v22 Percent Bar stored cell-text overlay settings as flat
-     * `CellText: CellTextOptions` + `CellTextPosition: 'Above' | 'Below' | 'Merged'`
-     * keys on `PercentBarStyle`. v23 replaces them with the per-value
-     * `CellTextProperties.CellTextLayout: { CellValue?, PercentValue? }`, where
-     * each value carries its own `Horizontal` and `Vertical` placement.
-     *
-     * The flat keys are forwarded onto the new layout (`Horizontal: 'Left'`,
-     * `Vertical` taken from `CellTextPosition`) and stripped from the parent
-     * style. Range Bar and Bullet Chart never shipped cell-text overlays in
-     * v22 so they need no migration here.
-     */
     migratePercentBarCellText(state) {
         const columns = state.StyledColumn?.StyledColumns;
         if (!columns?.length) {
@@ -87,31 +69,6 @@ export class VersionUpgrade23 extends VersionUpgrade {
             }
         }
     }
-    /**
-     * `RowScope` (which row kinds — data / group / summary / total — render
-     * the style) was originally a Badge-only concept. It applies equally to
-     * every Styled Column type, so we lift it to the top-level `StyledColumn`
-     * object. The Badge-only wizard "Rows" step is replaced by a universal
-     * "Scope" step that covers both column and row kinds.
-     *
-     * Migration: if `StyledColumn.BadgeStyle.RowScope` exists and the
-     * top-level `StyledColumn.RowScope` is not already set, lift it up.
-     * Then delete the nested copy so we only have one source of truth going
-     * forward.
-     */
-    /**
-     * v22 Badge icon settings lived as four flat keys on
-     * `BadgeStyleDefinition`: `Icon`, `IconPosition`, `IconOnly` (and the
-     * v23 canary-only `IconGap`). v23 groups them under
-     * `IconProperties: { Icon, Position, Gap, IconOnly }`.
-     *
-     * Migration: per badge, if any of the flat keys are present, build
-     * `IconProperties` (renaming `IconPosition → Position` and `IconGap → Gap`,
-     * leaving `IconOnly` as-is) and strip the flat keys from the parent.
-     * `IconProperties.Icon` is required, so if the only flat fields set were
-     * decoration flags (`IconPosition` / `IconOnly` / `IconGap`) without an
-     * `Icon`, those flags are dropped (they had no effect anyway).
-     */
     migrateBadgeIconProperties(state) {
         const columns = state.StyledColumn?.StyledColumns;
         if (!columns?.length) {
@@ -169,12 +126,6 @@ export class VersionUpgrade23 extends VersionUpgrade {
             this.logger.info(`Promoted BadgeStyle.RowScope → StyledColumn.RowScope on column "${sc.ColumnId}" (v23).`);
         }
     }
-    /**
-     * `Name` was added as a mandatory property on `StyledColumn` (mirroring every
-     * other named state object). Existing state has no `Name`, so we generate a
-     * default of the form `${TypeLabel}-${ColumnId}` — e.g. `Badge-tradeId`,
-     * `Sparkline-history`. Users can rename them later via the wizard.
-     */
     patchStyledColumnName(state) {
         const columns = state.StyledColumn?.StyledColumns;
         if (!columns?.length) {
@@ -201,23 +152,6 @@ export class VersionUpgrade23 extends VersionUpgrade {
             return 'Rating';
         return 'StyledColumn';
     }
-    /**
-     * `BadgeStyleDefinition.Style` was a full `AdaptableStyle` until v23.
-     * v23 replaces it with the cut-down {@link BadgePillStyle}:
-     * - `BackColor`, `ForeColor`, `BorderColor`, `FontWeight`, `FontStyle`,
-     *   `TextDecoration` map across as-is to `PillStyle`.
-     * - `BorderRadius` is dropped: `Shape` (`Pill | Rounded | Square`) owns
-     *   pill shape now. If a definition had a `BorderRadius` but no `Shape`,
-     *   we infer one (`>= 12` → `Pill`, `0` → `Square`, else `Rounded`).
-     * - `Alignment` is dropped from the pill (badge-row alignment is
-     *   column-level): when *any* pill in a column carried an `Alignment`
-     *   we lift it to `BadgeStyle.Font.Alignment` (first non-empty wins;
-     *   user can change later). Format Column alignment is therefore not
-     *   inherited for these columns post-migration, preserving the v22
-     *   visual layout.
-     * - `ClassName` and `FontSize` are dropped silently — they had no
-     *   reliable runtime effect on badges in v22.
-     */
     migrateBadgeStyleToPillStyle(state) {
         const columns = state.StyledColumn?.StyledColumns;
         if (!columns?.length) {
@@ -272,13 +206,6 @@ export class VersionUpgrade23 extends VersionUpgrade {
             }
         }
     }
-    /**
-     * Recognises the *legacy* diverging pattern — two ranges meeting at `0`
-     * with `ReverseGradient: true` on the negative band — and rewrites it as a
-     * single `ZeroCentred` declaration. Two-range gradients that just *happen*
-     * to share a zero boundary (without `ReverseGradient`) are left alone, since
-     * those are valid plain two-range gradients post-v23.
-     */
     migrateStyledColumnGradientZeroCentred(state) {
         const columns = state.StyledColumn?.StyledColumns;
         if (!columns?.length) {

package/src/parser/src/evaluator.js

@@ -3,7 +3,6 @@ export function evaluateNode(node, context) {
     if (typeof node === 'boolean' ||
         typeof node === 'number' ||
         typeof node === 'string' ||
-        // handles NULL literal
         node == null) {
         return node;
     }

package/src/parser/src/index.js

@@ -1,5 +1,4 @@
 import { evaluateNode } from './evaluator';
-// @ts-ignore
 import parser from './parser';
 export { findPathTo } from './utils';
 const getParser = () => {