@adaptabletools/adaptable 23.0.4 → 23.0.5-canary.1

package/src/Utilities/Services/ValidationService.js

@@ -9,9 +9,7 @@ export class ValidationService {
         this.adaptableApi = adaptableApi;
         this.adaptableApi = adaptableApi;
     }
-    // Not sure where to put this: was in the Module but might be better here until I can work out a way of having an event with a callback...
     getValidationRulesForDataChange(cellDataChangedInfo) {
-        // if the new value is the same as the old value then we can get out as we dont see it as an edit?
         if (cellDataChangedInfo.oldValue == cellDataChangedInfo.newValue) {
             return [];
         }
@@ -60,21 +58,6 @@ export class ValidationService {
                 cellDataChangedInfo: cellDataChangedInfo,
             };
             this.adaptableApi.eventApi.internalApi.fireAlertFiredEvent(alert);
-            // This is not needed because the change event is triggered regardless
-            // if the edit is succesful. This is because (I think) Adaptable uses a non-standard way ot detecting data changes.
-            // https://github.com/AdaptableTools/adaptable/issues/2197
-            // failedRules.forEach((alertDefinition) => {
-            //   const alert: AdaptableAlert = ObjectFactory.CreateCellChangedAlert(
-            //     cellDataChangedInfo.column.friendlyName,
-            //     this.adaptableApi.alertApi.internalApi.getAlertDescription(
-            //       alertDefinition,
-            //       cellDataChangedInfo
-            //     ),
-            //     alertDefinition,
-            //     cellDataChangedInfo
-            //   );
-            //   this.adaptableApi.alertApi.showAdaptableAlert(alert);
-            // });
             return false;
         }
         return true;
@@ -108,11 +91,8 @@ export class ValidationService {
                 if (validationResult.newCellValue === undefined) {
                     validationResult.newCellValue = cellDataChangedInfo.newValue;
                 }
-                // If they have changed the return value then we should update the grid, log the function change
-                // otherwise the value will persist
                 if (validationResult.newCellValue !== cellDataChangedInfo.newValue) {
                     cellDataChangedInfo.newValue = validationResult.newCellValue;
-                    // this.adaptable.setValue(cellDataChangedInfo, false);
                     const row = cellDataChangedInfo.rowNode?.data;
                     if (!row) {
                         return;
@@ -151,6 +131,5 @@ export class ValidationService {
         return returnMessage;
     }
     destroy() {
-        // TO DO
     }
 }

package/src/Utilities/createAgStatusPanelComponent.js

@@ -11,9 +11,6 @@ export const createAgStatusPanelComponent = (component, adaptable, context) => {
             }), adaptable);
             return (_jsx("div", { className: "ab-StatusBar", ref: (node) => {
                     if (node) {
-                        // in React rendering, AG Grid renders an additional extra div
-                        // around the status panel container, with className of 'ag-react-container'
-                        // which needs to be stretched in order to fill the status panel
                         node.parentElement.style.display = 'flex';
                     }
                 }, children: children }));

package/src/Utilities/getExpressionViewItems.js

@@ -2,10 +2,8 @@ import { jsx as _jsx } from "react/jsx-runtime";
 import { ExpressionPreview } from '../components/ExpressionEditor/ExpressionPreview';
 import { Tag } from '../components/Tag';
 export const getExpressionViewItems = (query, api) => {
-    // const expressionText = api.internalApi.getAdaptableQueryExpressionText(query);
     return {
         name: 'Expression',
-        // values: [],
         view: (_jsx(Tag, { children: _jsx(ExpressionPreview, { query: query }) })),
     };
 };

package/src/Utilities/getObjectTagsViewItems.js

@@ -17,7 +17,6 @@ export const getObjectTagsViewItems = (object, api) => {
             const handleToggleTag = React.useCallback(() => {
                 let tags = props.data.Tags ?? [];
                 if (hasCurrentLayoutAsTag) {
-                    // remove layout
                     tags = tags.filter((tag) => tag !== currentLayoutName);
                 }
                 else {

package/src/Utilities/getScrollbarSize.js

@@ -15,7 +15,6 @@ export default () => {
         elStyle.height = '200px';
         elStyle.top = '-99999px';
         elStyle.overflow = 'scroll';
-        //@ts-ignore
         elStyle.MsOverflowStyle = 'scrollbar';
         document.body.appendChild(div);
         result = div.offsetWidth - div.clientWidth;

package/src/Utilities/logDeprecation.js

@@ -1,7 +1,4 @@
 const doOnceFlags = {};
-/**
- * If the key was passed before, then do NOT execute the func
- */
 const doOnce = (func, key) => {
     if (doOnceFlags[key]) {
         return;

package/src/Utilities/resolveContainerElement.js

@@ -1,34 +1,14 @@
-/**
- * Resolves a container option value to an `HTMLElement`.
- *
- * Resolution order:
- * 1. If `container` is `null`/`undefined`, returns `null`.
- * 2. If `container` is a function, it is called with the provided `context` and the result is resolved.
- * 3. If the value is an `HTMLElement`, it is returned directly.
- * 4. If the value is an `AdaptableCSSSelector` (`{ selector: string }`), `document.querySelectorAll` is used.
- *    If multiple elements match, the first is returned and a console warning is logged.
- * 5. If the value is a `string`, it is treated as an element ID and `document.getElementById` is used.
- *
- * @param container - The container reference to resolve.
- * @param context - Optional context passed to the function form of the container.
- * @param doc - The document to query against (defaults to `globalThis.document`).
- * @returns The resolved `HTMLElement`, or `null` if not found.
- */
 export function resolveContainerElement(container, context, doc = globalThis.document) {
     if (container == null) {
         return null;
     }
-    // Unwrap function form — pass context if the container is a function
     const value = typeof container === 'function' ? container(context) : container;
-    // Guard against null/undefined returned by a callback (e.g. document.getElementById(...))
     if (value == null) {
         return null;
     }
-    // Direct HTMLElement reference
     if (value instanceof HTMLElement) {
         return value;
     }
-    // CSS Selector object
     if (typeof value === 'object' && 'selector' in value) {
         const matches = doc.querySelectorAll(value.selector);
         if (matches.length > 1) {
@@ -36,7 +16,6 @@ export function resolveContainerElement(container, context, doc = globalThis.doc
         }
         return matches[0] ?? null;
     }
-    // String element ID
     if (typeof value === 'string') {
         return doc.getElementById(value);
     }

package/src/Utilities/runIfNotResolvedIn.js

@@ -1,10 +1,3 @@
-/**
- * Calls the callback if the promise does not resolve in a amount of time.
- *
- * @param promise
- * @param callback Called if promise does not resolve in the time defined by 'delay'
- * @param delay Time after which if the promise was not resolved the callback (fn) is called.
- */
 export const runIfNotResolvedIn = async (promise, callback, delay = 100) => {
     let isFulfilled = false;
     promise?.then(() => {

package/src/Utilities/sortColumnStateForVisibleColumns.js

@@ -5,26 +5,18 @@ function insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset =
         return;
     }
     if (prevColState.hide) {
-        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, 
-        /* do not advance this as, as we've encountered a hidden column*/ lastVisibleOffset);
+        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, lastVisibleOffset);
         return;
     }
     const prevCol_visibilityIndex = visibleColumnsIndexes[prevColState.colId];
     const currentCol_visibilityIndex = visibleColumnsIndexes[colState.colId];
     if (currentCol_visibilityIndex < prevCol_visibilityIndex) {
-        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, 
-        /*make sure we sync with the normal offset, as we've hit a visible col*/ offset + 1);
+        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, offset + 1);
     }
     else {
         result.splice(result.length - lastVisibleOffset, 0, colState);
     }
 }
-/**
- * This method takes a column state and the list of visible columns
- * and returns a new column state that respects the order of the visible columns
- * while trying to keep the hidden columns in their original order.
- *
- */
 export function sortColumnStateForVisibleColumns(columnState, visibleColumns) {
     const visibleColumnsIndexes = visibleColumns.reduce((acc, colId, index) => {
         acc[colId] = index;
@@ -35,8 +27,6 @@ export function sortColumnStateForVisibleColumns(columnState, visibleColumns) {
         const colState = columnState[i];
         const colVisible = visibleColumnsIndexes[colState.colId] != null;
         if (!colVisible) {
-            // for cols not present in this layout, we keep them
-            // where they are
             result.push(colState);
             continue;
         }

package/src/Utilities/waitForTimeout.js

@@ -1,4 +1,3 @@
-// waits for the given ms milliseconds
 export function waitForTimeout(ms) {
     return new Promise((resolve) => {
         setTimeout(() => {

package/src/Utilities/wizardSelection.js

@@ -1,7 +1,5 @@
 import { cn } from '../lib/utils';
-/** Selected wizard option — Tailwind overrides SimpleButton outlined defaults. */
 export const WIZARD_SELECTION_ACTIVE_CLASSES = cn('ab-WizardSelection--active', 'twa:!border-[var(--ab-cmp-wizard-selection__border)]', 'twa:!bg-[var(--ab-cmp-wizard-selection__background)]', 'twa:!text-accent', 'twa:font-medium');
-/** Unselected wizard option — muted so the active choice reads immediately. */
 export const WIZARD_SELECTION_INACTIVE_CLASSES = cn('twa:!border-[color-mix(in_srgb,var(--ab-color-primarydark)_40%,transparent)]', 'twa:!text-[color-mix(in_srgb,var(--ab-color-foreground)_55%,transparent)]');
 export const getCollapsibleWizardCardCollapsedClasses = (surface = 'popup') => cn(surface === 'panel'
     ? 'twa:border-[var(--ab-cmp-collapsible-wizard-card__collapsed-border)] twa:bg-card'

package/src/View/AdaptablePopover/index.js

@@ -15,7 +15,7 @@ export class AdaptablePopover extends React.Component {
         const title = StringExtensions.IsNotNullOrEmpty(this.props.headerText)
             ? this.props.headerText
             : '';
-        const icon = 'info'; // - think this is wrong - UIHelper.getGlyphByMessageType(messageType);
+        const icon = 'info';
         const color = UIHelper.getColorByMessageType(messageType);
         const iconStyle = {
             color,

package/src/View/AdaptableView.js

@@ -20,11 +20,7 @@ class AdaptableView extends React.Component {
         const adaptableOptions = this.props.AdaptableApi.optionsApi.getAdaptableOptions();
         return (_jsxs("div", { children: [_jsx(GridCellPopup, {}), _jsx(QuickSearchDrawer, {}), this.props.AdaptableApi.internalApi
                     .getModuleService()
-                    .isAdapTableModulePresent('Dashboard') && _jsx(Dashboard, { api: this.props.AdaptableApi }), this.props.PopupState.PromptPopup.ShowPromptPopup && (_jsx(AdaptablePopupPrompt, { message: this.props.PopupState.PromptPopup.Message, header: this.props.PopupState.PromptPopup.Header, onClose: this.props.onClosePromptPopup, onConfirm: this.props.onConfirmPromptPopup, onConfirmActionCreator: this.props.PopupState.PromptPopup.ConfirmActionCreator, defaultValue: this.props.PopupState.PromptPopup.DefaultValue })), Boolean(this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup) && (_jsx(AdaptablePopupConfirmation, { header: this.props.PopupState.ConfirmationPopup.Header, messsage: this.props.PopupState.ConfirmationPopup.Msg, showPopup: this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup, cancelButtonText: this.props.PopupState.ConfirmationPopup.CancelButtonText, confirmButtonText: this.props.PopupState.ConfirmationPopup.ConfirmButtonText, onCancel: this.props.onCancelConfirmationPopup, onConfirm: this.props.onConfirmConfirmationPopup, showInputBox: this.props.PopupState.ConfirmationPopup.ShowInputBox, messageType: this.props.PopupState.ConfirmationPopup.MessageType, api: this.props.AdaptableApi })), Boolean(this.props.PopupState.ScreenPopup.ShowScreenPopup) && (_jsx(AdaptablePopup, { componentName: this.props.PopupState.ScreenPopup.ComponentName, componentModule: this.props.PopupState.ScreenPopup.ComponentModule, onHide: this.props.onCloseScreenPopup, api: this.props.AdaptableApi, onClearParams: () => this.props.onClearPopupParams(), moduleParams: this.props.PopupState.ScreenPopup.Params, moduleProps: this.props.PopupState.ScreenPopup.PopupProps })), _jsx(ToastContainer
-                // Ensure to set containerId to avoid memory leaks when Adaptable instance is destroyed and re-created many times
-                , { 
-                    // Ensure to set containerId to avoid memory leaks when Adaptable instance is destroyed and re-created many times
-                    containerId: `Toastify-${adaptableOptions.adaptableId}`, limit: adaptableOptions.notificationsOptions.maxNotifications, closeButton: false, icon: false, theme: "colored" }), watermark?.show && _jsx(LicenseWatermark, { children: watermark?.text }), _jsx(WindowPopups, {}), _jsx(FormPopups, {}), _jsx(ProgressIndicator, {})] }));
+                    .isAdapTableModulePresent('Dashboard') && _jsx(Dashboard, { api: this.props.AdaptableApi }), this.props.PopupState.PromptPopup.ShowPromptPopup && (_jsx(AdaptablePopupPrompt, { message: this.props.PopupState.PromptPopup.Message, header: this.props.PopupState.PromptPopup.Header, onClose: this.props.onClosePromptPopup, onConfirm: this.props.onConfirmPromptPopup, onConfirmActionCreator: this.props.PopupState.PromptPopup.ConfirmActionCreator, defaultValue: this.props.PopupState.PromptPopup.DefaultValue })), Boolean(this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup) && (_jsx(AdaptablePopupConfirmation, { header: this.props.PopupState.ConfirmationPopup.Header, messsage: this.props.PopupState.ConfirmationPopup.Msg, showPopup: this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup, cancelButtonText: this.props.PopupState.ConfirmationPopup.CancelButtonText, confirmButtonText: this.props.PopupState.ConfirmationPopup.ConfirmButtonText, onCancel: this.props.onCancelConfirmationPopup, onConfirm: this.props.onConfirmConfirmationPopup, showInputBox: this.props.PopupState.ConfirmationPopup.ShowInputBox, messageType: this.props.PopupState.ConfirmationPopup.MessageType, api: this.props.AdaptableApi })), Boolean(this.props.PopupState.ScreenPopup.ShowScreenPopup) && (_jsx(AdaptablePopup, { componentName: this.props.PopupState.ScreenPopup.ComponentName, componentModule: this.props.PopupState.ScreenPopup.ComponentModule, onHide: this.props.onCloseScreenPopup, api: this.props.AdaptableApi, onClearParams: () => this.props.onClearPopupParams(), moduleParams: this.props.PopupState.ScreenPopup.Params, moduleProps: this.props.PopupState.ScreenPopup.PopupProps })), _jsx(ToastContainer, { containerId: `Toastify-${adaptableOptions.adaptableId}`, limit: adaptableOptions.notificationsOptions.maxNotifications, closeButton: false, icon: false, theme: "colored" }), watermark?.show && _jsx(LicenseWatermark, { children: watermark?.text }), _jsx(WindowPopups, {}), _jsx(FormPopups, {}), _jsx(ProgressIndicator, {})] }));
     }
 }
 function mapStateToProps(state, ownProps) {

package/src/View/AdaptableWizardView/AdaptableConfigurationDialog/ColumnsList.js

@@ -332,10 +332,6 @@ const ColumnsList = ({ columns: cols, handle, onValidityChange, onChange, onSele
                 }, domProps: tableDOMProps, columns: columnsMap }) }) }));
 };
 function areEqual() {
-    /**
-     * Make the ColumnList not render on subsequent prop changes
-     * in order to boost performance
-     */
     return true;
 }
 export default React.memo(ColumnsList, areEqual);

package/src/View/AdaptableWizardView/AdaptableConfigurationDialog/ConfigurationWizard.js

@@ -7,7 +7,6 @@ import { ConfigurationWizardColumnsStep } from './ConfigurationWizardColumnsStep
 import GridOptionsForm from './GridOptionsForm';
 import EntitlementsForm from './EntitlementsForm';
 import { UIElementsForm } from './UIOptions/UiOptionsForm';
-import { AdaptableOptionsForm } from './AdaptableOptionsForm';
 import { applyDefaultAdaptableOptions } from '../../../AdaptableOptions/DefaultAdaptableOptions';
 export const ConfigurationWizard = (props) => {
     const [isPrimaryKeySelected, setIsValid] = React.useState(true);
@@ -44,7 +43,6 @@ export const ConfigurationWizard = (props) => {
                 return newColumn;
             });
             const columnDefs = adaptableConfig.gridOptions.columnDefs;
-            // handle the layout creation
             let Layouts = newAdaptableOptions.initialState?.Layout?.Layouts || [];
             const NewLayout = {
                 TableColumns: columnDefs.map((col) => col.colId ?? col.field),
@@ -53,7 +51,6 @@ export const ConfigurationWizard = (props) => {
             let currentLayoutName = NewLayout.Name;
             let found = false;
             if (!Layouts.length) {
-                // no layouts, make this the only one
                 Layouts = [NewLayout];
             }
             else {
@@ -62,10 +59,7 @@ export const ConfigurationWizard = (props) => {
                         return layout;
                     }
                     if (layout.TableColumns?.length === 0) {
-                        // when finding the first empty layout
-                        // set its column to be those of the new layout
                         found = true;
-                        // and grab the name so we can put it in the Layout.CurrentLayout state
                         currentLayoutName = layout.Name;
                         layout = { ...layout };
                         layout.TableColumns = NewLayout.TableColumns;
@@ -133,12 +127,6 @@ export const ConfigurationWizard = (props) => {
             },
             render: () => (_jsx(ConfigurationWizardColumnsStep, { adaptableConfig: adaptableConfig, setPrimaryKeyIsNotSelected: handlePrimaryKeyColumnIsNotSelected, onChange: setAdaptableConfig, selectedColumns: selectedColumns, onSelectionChange: handleColumnSelectionChange, onColumnChange: handleColumnsChange, columnsHandle: columnsHandle })),
         },
-        {
-            title: 'AdapTable Options',
-            details: 'Configure Adaptable Options',
-            isValid: () => adaptableConfig.adaptableOptions.adaptableId ? true : 'Adaptable ID is required',
-            render: () => (_jsx(AdaptableOptionsForm, { adaptableOptions: adaptableConfig.adaptableOptions, onChangedAdaptableOptions: handleAdaptableOptionsChange })),
-        },
         {
             title: 'AG Grid Options',
             details: 'Configure AG Grid Options',
@@ -154,17 +142,6 @@ export const ConfigurationWizard = (props) => {
             details: 'Configure Entitlements',
             render: () => (_jsx(EntitlementsForm, { adaptableOptions: adaptableConfig.adaptableOptions, onChangedAptableOptions: handleAdaptableOptionsChange })),
         },
-        /**
-        financePlugin && {
-          title: 'Finance',
-          details: 'Finance Options',
-          render: () => (
-            <FinanceForm
-              adaptableConfig={adaptableConfig}
-              onChangedAdaptableConfig={setAdaptableConfig}
-            />
-          ),
-        },  */
     ].filter(Boolean);
     if (props.startSections) {
         sections = [

package/src/View/AdaptableWizardView/AdaptableConfigurationDialog/EntitlementsForm.js

@@ -40,7 +40,6 @@ const EntitlementsListForm = (props) => {
     }, [abOptions?.entitlementOptions]);
     const handleOnChange = React.useCallback((module, accessLevel) => {
         let newEntitlements = entitlements;
-        // change
         if (entitlementsMap[module]) {
             newEntitlements = newEntitlements.map((entitlement) => {
                 if (entitlement.adaptableModule === module) {
@@ -50,7 +49,6 @@ const EntitlementsListForm = (props) => {
             });
         }
         else {
-            // new
             newEntitlements = [
                 ...newEntitlements,
                 { adaptableModule: module, accessLevel: accessLevel },

package/src/View/AdaptableWizardView/Wizard.js

@@ -34,16 +34,6 @@ export const reducer = (state, action) => {
     }
     return state;
 };
-/**
- * The wizard in a few modes:
- *
- * 1. Based on data:
- * 1.1 Drag and drop a file
- * 1.2 Fetch data from a url
- *
- * 2. Based on configuration:
- * Provide a schema, on how the data looks like.
- */
 export const Wizard = (props) => {
     const [state, dispatch] = useReducer(reducer, {
         ...initialState,
@@ -86,8 +76,6 @@ export const Wizard = (props) => {
                 adaptableOptions: state.adaptableOptions,
                 gridOptions: state.gridOptions,
             }, onCancel: () => {
-                // change the file droppable component key
-                // so it's remounted and it's in the initial state
                 setDroppableKey(Date.now());
                 dispatch({
                     type: 'CANCEL',

package/src/View/AdaptableWizardView/helper.js

@@ -1,13 +1,3 @@
-/**
- * There are two ways in which the datasource can be dropped in the wizard:
- *
- * 1. array of objects - eg: [{"lastName":"John","firstName":"Bobson"},{"lastName":"Mike","firstName":"Richardson"},...]
- * 2. array of arrays - eg: [["lastName","firstName"],["John","Bobson"],["Mike","Richardson"],...]
- *
- * Although the second one is more compact, the first one is what we need for the datasource of the grid,
- * so if we receive v2, we transform it to 1
- * @param json
- */
 export const prepareDataSource = (json, _file) => {
     if (!Array.isArray(json) || !json.length) {
         return {
@@ -20,7 +10,6 @@ export const prepareDataSource = (json, _file) => {
     let data = [];
     let primaryKey;
     if (Array.isArray(json[0])) {
-        // we are in v2, as described above, so this is the list of columns
         columns = json[0];
         for (let i = 1, len = json.length; i < len; i++) {
             const it = json[i];

package/src/View/Alert/ActiveAlertsPanel.js

@@ -7,11 +7,9 @@ export const ActiveAlertsPanel = () => {
     const adaptable = useAdaptable();
     const filterModule = adaptable.ModuleService.getModuleById(ModuleConstants.AlertModuleId);
     const alerts = useSelector((state) => state.Internal.AdaptableAlerts);
-    // map the suspended property from the underlying AlertDefinitions
     alerts.forEach((alert) => {
         const liveAlertDef = adaptable.api.alertApi.getAlertDefinitionById(alert.alertDefinition.Uuid);
         if (liveAlertDef) {
-            // @ts-ignore theoretically AdaptableAlert is not Suspendable; practically <AdaptableObjectCompactList> expects it
             alert.IsSuspended = liveAlertDef.IsSuspended;
         }
     });

package/src/View/Alert/AlertStatusSubPanel.js

@@ -14,13 +14,9 @@ export const AlertStatusPanel = () => {
         .getModuleService()
         .getModuleById(ModuleConstants.AlertModuleId);
     const statusbarHighlightDuration = adaptableApi.optionsApi.getAlertOptions().statusbarHighlightDuration;
-    /**
-     * Using a selector to so the component updates each time an alert is triggered.
-     */
     const alerts = useSelector((state) => state.Internal.AdaptableAlerts);
     const text = alerts.length == 0 ? '0 Alerts' : alerts.length == 1 ? '1 Alert' : alerts.length + ' Alerts';
     const handleAction = React.useCallback(() => adaptableApi.alertApi.openAlertSettingsPanel(), []);
-    // blinking logic
     const previousAlerts = React.useRef(alerts);
     const timeoutId = React.useRef(null);
     React.useEffect(() => {
@@ -38,10 +34,6 @@ export const AlertStatusPanel = () => {
             clearTimeout(timeoutId.current);
             timeoutId.current = null;
         }
-        /**
-         * Cannot clear timeout in the useEffect cleanup function, because this logic is not
-         * called for each case. e.g. it is skipped for when alerts are not added.
-         */
         timeoutId.current = setTimeout(() => {
             setStyle(initialStyle);
         }, statusbarHighlightDuration);

package/src/View/Alert/Utilities/getAlertType.js

@@ -9,12 +9,6 @@ export var AlertType;
     AlertType["Observable"] = "Observable";
     AlertType["Scheduled"] = "Scheduled";
 })(AlertType || (AlertType = {}));
-/**
- * Based on alert shape the type is derived.
- * In the future the alert will get a type property.
- *
- * @param alert
- */
 export const getAlertType = (alert) => {
     if (isScheduledAlertDefinition(alert)) {
         return AlertType.Scheduled;
@@ -39,7 +33,6 @@ export const getAlertType = (alert) => {
     if (predicates) {
         return getRuleAlertProperties(alert)?.PreventEdit ? AlertType.Validation : AlertType.DataChange;
     }
-    // the object is not a valid alert
     return null;
 };
 export const getAlertTypeText = (alertType) => {

package/src/View/Alert/Utilities/getDefaultAlertDefinition.js

@@ -1,16 +1,11 @@
 import ObjectFactory from '../../../Utilities/ObjectFactory';
 import { CreateEmptyScheduledAlertDefinition } from '../../../Utilities/Helpers/Scheduling/ScheduledAlertHelper';
 import { AlertType } from './getAlertType';
-/**
- * This logic should be moved into Object factory once we have types on alert definitions
- * @param type AlertType
- */
 export const getDefaultAlertDefinition = (alertDefinition, type) => {
     const newAlert = {
         ...ObjectFactory.CreateEmptyAlertDefinition(),
         Uuid: alertDefinition.Uuid,
     };
-    // can only be all
     if (type === AlertType.Observable ||
         type === AlertType.Aggregation ||
         type === AlertType.RowChange) {

package/src/View/Alert/Utilities/mapAlertDefinition.js

@@ -12,8 +12,6 @@ export const mapAlertDefinition = (api, alertDefinition) => {
             return alertCommand;
         }
     };
-    // the only case needed is when changing from AddedRow to RemovedRow
-    // map FormButton Actions
     if (alertDefinition.AlertForm && typeof alertDefinition.AlertForm !== 'string') {
         const alertButtons = alertDefinition.AlertForm?.Buttons;
         alertButtons?.forEach((alertButton) => {
@@ -28,7 +26,6 @@ export const mapAlertDefinition = (api, alertDefinition) => {
             }
         });
     }
-    // behaviours
     if (isRemovedRowChangeAlert) {
         delete alertDefinition.AlertProperties.HighlightRow;
         delete alertDefinition.AlertProperties.JumpToRow;

package/src/View/Alert/Wizard/AlertWizard.js

@@ -57,8 +57,6 @@ export const AlertWizard = (props) => {
     const setAlertDefinition = useCallback((data) => {
         doSetAlertDefinition(data);
     }, []);
-    // Alert type is based initialy on data, but can be changed by the user
-    // the default objects do not neccesary have enough information to determine the type
     const [alertType, setAlertType] = useState(() => {
         return getAlertType(alertDefinition) ?? AlertType.DataChange;
     });

package/src/View/Alert/Wizard/isValidAlertRules.js

@@ -14,7 +14,6 @@ export const isValidAlertRules = (alert, api, context) => {
     if (typeof isRuleValid === 'string') {
         return isRuleValid;
     }
-    // boolean expressions may also be saved as named queries
     if (context.namedQuery != false) {
         const isValidName = api.namedQueryApi.isValidNamedQuery(context.namedQuery);
         if (!isValidName.valid) {

package/src/View/BulkUpdate/BulkUpdatePopup.js

@@ -26,7 +26,6 @@ class BulkUpdatePopupComponent extends React.Component {
         let hasDataTypeError = false;
         let dataTypeErrorMessage = '';
         if (col && StringExtensions.IsNotNullOrEmpty(this.props.BulkUpdateValue)) {
-            // check that the update value is a number for a numeric column.  not issue for dates as we dont allow free text
             if (col.dataType == 'number') {
                 if (isNaN(Number(this.props.BulkUpdateValue))) {
                     hasDataTypeError = true;

package/src/View/CalculatedColumn/Wizard/CalculatedColumnSettingsWizardSection.js

@@ -64,7 +64,5 @@ export const CalculatedColumnSettingsWizardSection = (props) => {
     ];
     return (_jsx(Box, { "data-name": 'calculated-column-settings', children: _jsxs(Flex, { flexDirection: "column", className: "twa:gap-3 twa:p-3", children: [_jsxs(Card, { shadow: false, children: [_jsxs(Card.Title, { children: [_jsx(Box, { className: "twa:font-medium", children: "Data Type" }), _jsx(Box, { className: "twa:text-xs twa:opacity-70 twa:font-normal twa:max-w-[520px]", children: "Choose the data type for the Calculated Column values" })] }), _jsxs(Card.Body, { className: "twa:p-1 twa:gap-1", children: [_jsx(SingleSelect, { "data-name": "column-type", placeholder: "Select Data Type", items: options, value: dataType, onValueChange: (value) => handleDataTypeChange(value), className: "twa:max-w-[300px]" }), ErrorMessage ? (_jsx(Box, { className: "twa:text-2 twa:text-destructive", children: ErrorMessage })) : null] })] }), _jsxs(Card, { shadow: false, children: [_jsxs(Card.Title, { children: [_jsx(Box, { className: "twa:font-medium", children: "Width" }), _jsx(Box, { className: "twa:text-xs twa:opacity-70 twa:font-normal twa:max-w-[520px]", children: "Optional Column Width in pixels" })] }), _jsx(Card.Body, { className: "twa:p-1", children: _jsx(Input, { "data-name": "column-width", type: "number", className: "twa:max-w-[300px]", value: Width || '', onChange: (e) => handleSpecialColumnSettingsChange({
                                     Width: Number(e.target.value),
-                                }) }) })] }), _jsx(SpecialColumnSettingsWizardStep, { isEditable: false, 
-                    // @ts-ignore CalculatedColumn has a broader DataType
-                    settings: data.CalculatedColumnSettings, onChange: handleSpecialColumnSettingsChange })] }) }));
+                                }) }) })] }), _jsx(SpecialColumnSettingsWizardStep, { isEditable: false, settings: data.CalculatedColumnSettings, onChange: handleSpecialColumnSettingsChange })] }) }));
 };

package/src/View/CalculatedColumn/Wizard/CalculatedColumnWizard.js

@@ -55,7 +55,6 @@ export const CalculatedColumnWizard = (props) => {
             });
         }
         else {
-            // Aggregated, Cumulative & Quantile are all AggregatedScalarExpression
             setCalculatedColumn({
                 ...calculatedColumn,
                 Query: {

package/src/View/CalculatedColumn/utils.d.ts

@@ -1,2 +1,2 @@
 import { AdaptableApi, CalculatedColumn } from '../../types';
-export declare const getExpressionType: (calculatedColumn: CalculatedColumn, api: AdaptableApi) => "AggregatedScalarExpression" | "ScalarExpression" | "CumulativeAggregatedExpression" | "QuantileAggregatedExpression";
+export declare const getExpressionType: (calculatedColumn: CalculatedColumn, api: AdaptableApi) => "ScalarExpression" | "AggregatedScalarExpression" | "CumulativeAggregatedExpression" | "QuantileAggregatedExpression";

package/src/View/CellSummary/CellSummaryPopup.js

@@ -7,10 +7,7 @@ import { PanelWithButton } from '../Components/Panels/PanelWithButton';
 class CellSummaryPopupComponent extends React.Component {
     componentDidMount() {
         if (this.props.popupParams?.source === 'ColumnMenu' && this.props.popupParams?.column) {
-            // if the summary was requested from the column menu, we need to select the entire column
-            // afterwards, we will go on with the cell summary logic, as that will evaluate the current(column) cell selection
             this.props.api.columnApi.selectColumn(this.props.popupParams?.column.columnId);
-            // we also need to update the internal state of the selected cells
             this.props.api.internalApi.getAdaptableInstance().refreshSelectedCellsState();
         }
         this.props.onCreateCellSummary();

package/src/View/CellSummary/CellSummaryStatusBarSubPanelPopover.js

@@ -4,11 +4,5 @@ import { useSelector } from 'react-redux';
 export const CellSummaryStatusBarSubPanelPopover = () => {
     const cellSummary = useSelector((state) => state.Internal.CellSummary.CellSummaryInfo);
     const summary = _jsx(CellSummaryDetails, { CellSummary: cellSummary });
-    return cellSummary && cellSummary.Count ? (summary) : (
-    // the extra wrapper is added because the empty text is rendered
-    // inside a  EmptyContent, hat has position absolute
-    (_jsx(
-        "div",
-        { style: { position: 'relative', width: '100%', height: 80 }, children: summary }
-    )));
+    return cellSummary && cellSummary.Count ? (summary) : (_jsx("div", { style: { position: 'relative', width: '100%', height: 80 }, children: summary }));
 };

package/src/View/Charting/EditChartButton.js

@@ -5,10 +5,7 @@ import * as ModuleConstants from '../../Utilities/Constants/ModuleConstants';
 import { useDispatch } from 'react-redux';
 export const EditChartButton = (props) => {
     const dispatch = useDispatch();
-    return (_jsx(ButtonEdit, { iconSize: props.iconSize, tooltip: "Edit Chart", 
-        // It gets complicated when a chart is both open and opened in edit wizard
-        // There an be conflicts between the two open charts (preview and main) and the changes to the active chart may not be syncronized correctly.
-        disabled: !props.chart || props.isOpen, accessLevel: props.accessLevel, onClick: () => dispatch(PopupRedux.PopupShowScreen(ModuleConstants.ChartingModuleId, 'Chart', {
+    return (_jsx(ButtonEdit, { iconSize: props.iconSize, tooltip: "Edit Chart", disabled: !props.chart || props.isOpen, accessLevel: props.accessLevel, onClick: () => dispatch(PopupRedux.PopupShowScreen(ModuleConstants.ChartingModuleId, 'Chart', {
             action: 'Edit',
             value: props.chart,
             source: 'Toolbar',

package/src/View/Charting/ShowChartButton.js

@@ -43,9 +43,6 @@ const ShowExternalChartButton = (props) => {
     const adaptable = useAdaptable();
     const chartingOptions = adaptable.adaptableOptions?.chartingOptions;
     const chartContainers = chartingOptions?.chartContainers;
-    /**
-     * Need to refresh after the chart is closed/opened
-     */
     const { isOpen, showChart: onShow, hideChart: onHide, } = useExternalChartState(props.chartDefinition);
     const containerOptions = chartContainers
         ? chartContainers?.map((contianerDef) => ({

package/src/View/Charting/useAgChartState.js

@@ -39,13 +39,8 @@ export const useAgChartState = (chartDefinition) => {
         }
         const chartRef = adaptable.api.chartingApi.getChartRef(chartDefinition.Model.chartId);
         if (chartRef) {
-            // chart alredy opened
             return;
         }
-        /**
-         * When using a custom container, make sure multiple charts are not opened in the same container.
-         * If multple charts are opened in the same contianer, it infinitly adds the charts to the container.
-         */
         if (chartContainer && element) {
             if (chartContainer.chartsDisplay !== 'multiple') {
                 closeAlreadyOpenedChartsInContainer(element);

package/src/View/Charting/useChartingElements.js

@@ -19,16 +19,13 @@ export const useChartingElements = ({ elementType, accessLevel, size = 'normal',
     const chartingOptions = adaptable.adaptableOptions?.chartingOptions;
     const chartContainers = chartingOptions?.chartContainers;
     const [selectedChartId, setSelectedChartId] = React.useState(() => {
-        // ID is kept in state becaus that does not change, the definition might change
         return allChartDefinitions.length > 0 ? allChartDefinitions[0].Uuid : null;
     });
     const selectedChart = allChartDefinitions.find((chart) => chart.Uuid === selectedChartId);
     const isAgChart = isAgChartDefinition(selectedChart);
     const chartAccessLevel = AdaptableHelper.getAccessLevelForObject(selectedChart, accessLevel);
     const [selectedContainer, setSelectedContainer] = React.useState(null);
-    // Need to always call as they the rule for hooks
     const { isOpen: isAgChartOpen, showChart: showAgChart, closeChart: hideAgChart, } = useAgChartState(isAgChart ? selectedChart : undefined);
-    // Need to always call as they the rule for hooks
     const { isOpen: isExternalChartOpened, showChart: showExternalChart, hideChart: hideExternalChart, } = useExternalChartState(!isAgChart ? selectedChart : undefined);
     const isOpen = isAgChart ? isAgChartOpen : isExternalChartOpened;
     const showChart = isAgChart ? showAgChart : showExternalChart;
@@ -53,7 +50,6 @@ export const useChartingElements = ({ elementType, accessLevel, size = 'normal',
         selectedChartValue = 'No Charts';
     }
     React.useEffect(() => {
-        // select first
         if (!selectedChart && chartDefinitions.length > 0) {
             setSelectedChartId(chartDefinitions[0].Uuid);
         }