@1agh/maude 1.0.11 → 1.2.0

package/apps/studio/test/config-reload.test.ts

@@ -1,230 +0,0 @@
-// Config hot-reload — `/design:setup-ds` rewrites `.design/config.json`
-// mid-session; the server must re-read it so a newly added canvas group
-// (`system`) reaches /_index-data and scaffolded DS files show in the tree.
-// reloadConfig mutates ctx.cfg IN PLACE so every `const { cfg } = ctx`
-// capture sees the fresh values.
-// RCA: .ai/logs/rca/issue-ds-scaffold-files-not-in-filetree-stale-config.md
-
-import { describe, expect, test } from 'bun:test';
-import { mkdirSync, mkdtempSync, rmSync, unlinkSync, writeFileSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-
-import { type Context, createBus, reloadConfig } from '../context.ts';
-
-/** The pre-scaffold e2e fixture shape — UI-only group, no design systems. */
-const BOOT_CONFIG = {
-  name: 'e2e-fixture',
-  designRoot: '.design',
-  canvasGroups: [{ label: 'UI kit', path: 'ui' }],
-  designSystems: [],
-};
-
-/** What /design:setup-ds writes: system group + DS entry + tokens path. */
-const SCAFFOLDED_CONFIG = {
-  ...BOOT_CONFIG,
-  tokensCssRel: 'system/kanban-glass/colors_and_type.css',
-  canvasGroups: [
-    { label: 'Design system', path: 'system' },
-    { label: 'UI kit', path: 'ui' },
-  ],
-  designSystems: [{ name: 'kanban-glass', path: 'system/kanban-glass' }],
-  defaultDesignSystem: 'kanban-glass',
-};
-
-function sandbox(): { root: string; designRoot: string } {
-  const root = mkdtempSync(join(tmpdir(), 'cfg-reload-test-'));
-  const designRoot = join(root, '.design');
-  mkdirSync(designRoot, { recursive: true });
-  writeFileSync(join(designRoot, 'config.json'), JSON.stringify(BOOT_CONFIG, null, 2));
-  return { root, designRoot };
-}
-
-/** Mirrors what createContext builds at boot from BOOT_CONFIG. */
-function mkCtx(root: string, designRoot: string): Context {
-  return {
-    cfg: {
-      name: 'e2e-fixture',
-      projectLabel: null,
-      designRoot: '.design',
-      canvasGroups: [{ label: 'UI kit', path: 'ui' }],
-      designSystems: [],
-      rootClass: 'app',
-      themeDefault: 'dark',
-      tokensCssRel: 'system/colors_and_type.css',
-      teamAccentDefault: null,
-      handoffTargets: [],
-      newCanvasDir: 'ui',
-      newComponentDir: 'ui/components',
-      _source: '.design/config.json',
-    },
-    projectLabel: 'e2e-fixture Design',
-    paths: {
-      repoRoot: root,
-      designRel: '.design',
-      designRoot,
-      serverInfoFile: join(designRoot, '_server.json'),
-      activeFile: join(designRoot, '_active.json'),
-      commentsDir: join(designRoot, '_comments'),
-      canvasStateDir: join(designRoot, '_canvas-state'),
-      historyDir: join(designRoot, '_history'),
-      tokensUrlRel: '.design/system/colors_and_type.css',
-      systemDirRel: 'system',
-    },
-    bus: createBus(),
-  };
-}
-
-describe('reloadConfig', () => {
-  test('a group added on disk reaches a boot-time captured cfg reference (the bug)', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    // What every module factory holds: the object reference, captured at boot.
-    const captured = ctx.cfg;
-    try {
-      writeFileSync(join(designRoot, 'config.json'), JSON.stringify(SCAFFOLDED_CONFIG, null, 2));
-      expect(reloadConfig(ctx)).toBe(true);
-      // The capture sees the scaffolded groups — no restart needed.
-      expect(captured.canvasGroups.map((g) => g.path)).toEqual(['system', 'ui']);
-      expect(captured.designSystems?.[0]?.name).toBe('kanban-glass');
-      // normalizeDesignSystems runs on reload too (derived per-DS tokens path).
-      expect(captured.designSystems?.[0]?.tokensCssRel).toBe(
-        'system/kanban-glass/colors_and_type.css'
-      );
-      expect(captured.defaultDesignSystem).toBe('kanban-glass');
-      // Derived paths recompute in place.
-      expect(ctx.paths.tokensUrlRel).toBe('.design/system/kanban-glass/colors_and_type.css');
-      expect(ctx.paths.systemDirRel).toBe('system');
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-
-  test('an unchanged config reports false (no spurious nudges)', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    try {
-      reloadConfig(ctx); // sync ctx.cfg to the on-disk file once
-      expect(reloadConfig(ctx)).toBe(false);
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-
-  test('invalid JSON mid-edit keeps the running config', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    try {
-      writeFileSync(join(designRoot, 'config.json'), '{ "name": "half-writ');
-      expect(reloadConfig(ctx)).toBe(false);
-      expect(ctx.cfg.name).toBe('e2e-fixture');
-      expect(ctx.cfg.canvasGroups.map((g) => g.path)).toEqual(['ui']);
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-
-  test('a deleted config keeps the running config (no downgrade to defaults)', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    try {
-      unlinkSync(join(designRoot, 'config.json'));
-      expect(reloadConfig(ctx)).toBe(false);
-      expect(ctx.cfg.name).toBe('e2e-fixture');
-      expect(ctx.cfg._source).toBe('.design/config.json');
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-
-  test('designRoot is not hot-reloadable — kept, rest of the change applies', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    try {
-      writeFileSync(
-        join(designRoot, 'config.json'),
-        JSON.stringify({ ...BOOT_CONFIG, name: 'renamed', designRoot: 'designs' }, null, 2)
-      );
-      expect(reloadConfig(ctx)).toBe(true);
-      expect(ctx.cfg.name).toBe('renamed');
-      expect(ctx.cfg.designRoot).toBe('.design');
-      expect(ctx.paths.designRel).toBe('.design');
-      expect(ctx.projectLabel).toBe('renamed Design');
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-
-  test('linkedHub is boot-pinned — a live add is ignored, the rest applies', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    try {
-      writeFileSync(
-        join(designRoot, 'config.json'),
-        JSON.stringify(
-          {
-            ...BOOT_CONFIG,
-            name: 'renamed',
-            linkedHub: { url: 'wss://evil.example', linkedAt: 1, syncTsx: true },
-          },
-          null,
-          2
-        )
-      );
-      expect(reloadConfig(ctx)).toBe(true);
-      expect(ctx.cfg.name).toBe('renamed');
-      expect(ctx.cfg.linkedHub).toBeUndefined();
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-
-  test('design-root escapes are clamped: bad group dropped, bad tokensCssRel reset', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    try {
-      writeFileSync(
-        join(designRoot, 'config.json'),
-        JSON.stringify(
-          {
-            ...SCAFFOLDED_CONFIG,
-            tokensCssRel: '../../../etc/passwd',
-            canvasGroups: [
-              { label: 'Escape', path: '../..' },
-              { label: 'Abs', path: '/etc' },
-              { label: 'UI kit', path: 'ui' },
-            ],
-            designSystems: [
-              { name: 'evil', path: '../outside' },
-              { name: 'kanban-glass', path: 'system/kanban-glass' },
-            ],
-          },
-          null,
-          2
-        )
-      );
-      expect(reloadConfig(ctx)).toBe(true);
-      expect(ctx.cfg.canvasGroups.map((g) => g.path)).toEqual(['ui']);
-      expect(ctx.cfg.tokensCssRel).toBe('system/colors_and_type.css');
-      expect(ctx.cfg.designSystems?.map((d) => d.name)).toEqual(['kanban-glass']);
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-
-  test('a config.json created after a defaults boot applies', () => {
-    const { root, designRoot } = sandbox();
-    const ctx = mkCtx(root, designRoot);
-    // Simulate a boot without config.json (createContext fell back to defaults).
-    unlinkSync(join(designRoot, 'config.json'));
-    ctx.cfg._source = 'defaults';
-    try {
-      writeFileSync(join(designRoot, 'config.json'), JSON.stringify(SCAFFOLDED_CONFIG, null, 2));
-      expect(reloadConfig(ctx)).toBe(true);
-      expect(ctx.cfg._source).toBe('.design/config.json');
-      expect(ctx.cfg.canvasGroups.map((g) => g.path)).toEqual(['system', 'ui']);
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  });
-});

package/apps/studio/test/config-version.test.ts

@@ -1,88 +0,0 @@
-// The running version reaches the client — feature-release-reaches-the-fleet.
-//
-// Reading which release a Maude was actually running used to mean probing
-// production by hand, and the first probe of the v0.57.0 incident was MISREAD
-// (a 401 that looked like "route exists" was the blanket answer for any unknown
-// path). The fix has three surfaces reporting one version: the hub's `/health`,
-// this `/_config`, and the status-bar chip the client draws from it.
-//
-// What is asserted here is the middle one, plus the two properties that make it
-// safe to put there: it is resolved through the SINGLE version function, and it
-// carries nothing else.
-
-import { afterAll, describe, expect, test } from 'bun:test';
-import type { Subprocess } from 'bun';
-
-import { resolveMaudeVersion } from '../whats-new.ts';
-import { bootServer, killProc, makeSandbox, nextPort } from './_helpers.ts';
-
-const procs: Subprocess[] = [];
-afterAll(async () => {
-  for (const p of procs) await killProc(p);
-});
-
-async function boot(env: Record<string, string> = {}) {
-  const { root } = makeSandbox();
-  const port = nextPort();
-  procs.push(await bootServer(root, port, env));
-  return `http://localhost:${port}`;
-}
-
-describe('/_config names the release it is running', () => {
-  test('the version is present, and is a real version', async () => {
-    const base = await boot();
-    const cfg = (await (await fetch(`${base}/_config`)).json()) as { version?: string };
-
-    expect(typeof cfg.version).toBe('string');
-    // `0.0.0` was the private-workspace placeholder these manifests carried
-    // before they joined the release line — reporting it is the bug, not a pass.
-    expect(cfg.version).not.toBe('0.0.0');
-    expect(cfg.version).toMatch(/^\d+\.\d+\.\d+/);
-  });
-
-  test('it is the SAME answer the What’s New feed uses', async () => {
-    // One resolution path (DDR-045). Two would eventually disagree, and a chip
-    // that contradicts the feed beside it is worse than no chip.
-    const base = await boot();
-    const cfg = (await (await fetch(`${base}/_config`)).json()) as { version?: string };
-    const feed = (await (await fetch(`${base}/_api/whats-new`)).json()) as { version?: string };
-
-    expect(cfg.version).toBe(resolveMaudeVersion());
-    expect(cfg.version).toBe(feed.version);
-  });
-});
-
-describe('the version rides along, and nothing else does', () => {
-  test('a cloud tab gets the version too', async () => {
-    // `/_config` reaches a browser on someone else's machine in workspace mode.
-    // A git tag is public, so the version is fine there — this pins that it
-    // actually arrives, since the chip is the cloud's only version surface.
-    const base = await boot({
-      MAUDE_WORKSPACE_MODE: '1',
-      MAUDE_WORKSPACE_ALLOW_DEV_MODULES: '1',
-      MAUDE_PROJECT_NAME: 'Alligators',
-    });
-    const cfg = (await (await fetch(`${base}/_config`)).json()) as {
-      version?: string;
-      cloud?: unknown;
-    };
-
-    expect(typeof cfg.version).toBe('string');
-    expect(cfg.cloud).toBeDefined();
-  });
-
-  test('no server path or secret came with it', async () => {
-    const base = await boot();
-    const cfg = (await (await fetch(`${base}/_config`)).json()) as Record<string, unknown>;
-
-    // The version was the one field this change added. Anything matching these
-    // shapes arriving in the browser payload is a leak, and the review that
-    // waves it through will be the one that reads "it was already there".
-    for (const key of Object.keys(cfg)) {
-      expect(key).not.toMatch(/token$/i);
-      expect(key).not.toMatch(/secret|password|apiKey/i);
-    }
-    const serialized = JSON.stringify(cfg);
-    expect(serialized).not.toMatch(/BEGIN [A-Z ]*PRIVATE KEY/);
-  });
-});

package/apps/studio/test/context-resolve-tokens.test.ts

@@ -1,97 +0,0 @@
-// Per-DS tokensCssRel auto-resolution — load-bearing for DDR-048. When a
-// config entry doesn't spell out `tokensCssRel`, the dev-server must derive
-// it from `<entry.path>/colors_and_type.css` so the System view can read the
-// scaffolded layout without forcing every config author to repeat the path.
-
-import { describe, expect, test } from 'bun:test';
-import { normalizeDesignSystems } from '../context';
-
-const baseCfg = {
-  name: 'fixture',
-  projectLabel: null,
-  designRoot: '.design',
-  canvasGroups: [],
-  rootClass: 'app',
-  themeDefault: 'dark' as const,
-  tokensCssRel: 'system/colors_and_type.css',
-  teamAccentDefault: null,
-  handoffTargets: [],
-  newCanvasDir: 'ui',
-  newComponentDir: 'ui/components',
-  _source: '.design/config.json' as const,
-};
-
-describe('normalizeDesignSystems', () => {
-  test('no designSystems → passthrough (top-level tokensCssRel is the only source)', () => {
-    const out = normalizeDesignSystems({ ...baseCfg, designSystems: undefined });
-    expect(out.designSystems).toBeUndefined();
-    expect(out.tokensCssRel).toBe('system/colors_and_type.css');
-  });
-
-  test('empty designSystems array → passthrough', () => {
-    const out = normalizeDesignSystems({ ...baseCfg, designSystems: [] });
-    expect(out.designSystems).toEqual([]);
-  });
-
-  test('entry without tokensCssRel → derived from <path>/colors_and_type.css', () => {
-    const out = normalizeDesignSystems({
-      ...baseCfg,
-      designSystems: [{ name: 'studyfi', path: 'system/studyfi' }],
-    });
-    expect(out.designSystems?.[0].tokensCssRel).toBe('system/studyfi/colors_and_type.css');
-  });
-
-  test('entry with explicit tokensCssRel → preserved (leading slash trimmed)', () => {
-    const out = normalizeDesignSystems({
-      ...baseCfg,
-      designSystems: [
-        { name: 'studyfi', path: 'system/studyfi', tokensCssRel: '/system/studyfi/tokens.css' },
-      ],
-    });
-    expect(out.designSystems?.[0].tokensCssRel).toBe('system/studyfi/tokens.css');
-  });
-
-  test('path with leading + trailing slashes → normalized', () => {
-    const out = normalizeDesignSystems({
-      ...baseCfg,
-      designSystems: [{ name: 'alpha', path: '/system/alpha/' }],
-    });
-    expect(out.designSystems?.[0].path).toBe('system/alpha');
-    expect(out.designSystems?.[0].tokensCssRel).toBe('system/alpha/colors_and_type.css');
-  });
-
-  test('multiple entries → each resolved independently', () => {
-    const out = normalizeDesignSystems({
-      ...baseCfg,
-      designSystems: [
-        { name: 'alpha', path: 'system/alpha' },
-        { name: 'beta', path: 'system/beta', tokensCssRel: 'system/beta/custom.css' },
-      ],
-    });
-    expect(out.designSystems?.[0].tokensCssRel).toBe('system/alpha/colors_and_type.css');
-    expect(out.designSystems?.[1].tokensCssRel).toBe('system/beta/custom.css');
-  });
-
-  test('preserves unrelated entry fields (description, rootClass, themes)', () => {
-    const out = normalizeDesignSystems({
-      ...baseCfg,
-      designSystems: [
-        {
-          name: 'studyfi',
-          path: 'system/studyfi',
-          description: 'StudyFi production mirror',
-          rootClass: 'studyfi',
-          themeDefault: 'light',
-          themes: ['light', 'dark'],
-          newCanvasDir: 'ui/studyfi',
-        },
-      ],
-    });
-    const entry = out.designSystems?.[0];
-    expect(entry?.description).toBe('StudyFi production mirror');
-    expect(entry?.rootClass).toBe('studyfi');
-    expect(entry?.themeDefault).toBe('light');
-    expect(entry?.themes).toEqual(['light', 'dark']);
-    expect(entry?.newCanvasDir).toBe('ui/studyfi');
-  });
-});