@1agh/maude 1.0.11 → 1.2.0

package/apps/studio/test/sync-codec.test.ts

@@ -1,230 +0,0 @@
-// Codec unit tests — Phase 9 Task 4.
-//
-// Verify Y.Doc <-> disk round-trips for the three classes of files the sync
-// agent shuttles: HTML body, comments JSON, annotations SVG.
-
-import { describe, expect, test } from 'bun:test';
-import * as Y from 'yjs';
-
-import { Y_TYPES } from '../collab/persistence.ts';
-import {
-  annotationsFromDoc,
-  applyAnnotationsToDoc,
-  applyCommentsToDoc,
-  applyHtmlToDoc,
-  bodyEditAtFromDoc,
-  commentsFromDoc,
-  htmlFromDoc,
-  stampBodyEdit,
-  Y_SYNC_TYPES,
-} from '../sync/codec.ts';
-
-describe('HTML codec', () => {
-  test('htmlFromDoc returns empty string for a fresh doc', () => {
-    const doc = new Y.Doc();
-    expect(htmlFromDoc(doc)).toBe('');
-  });
-
-  test('applyHtmlToDoc → htmlFromDoc round-trip', () => {
-    const doc = new Y.Doc();
-    applyHtmlToDoc(doc, '<button>hello</button>');
-    expect(htmlFromDoc(doc)).toBe('<button>hello</button>');
-  });
-
-  test('applyHtmlToDoc with identical content is a no-op', () => {
-    const doc = new Y.Doc();
-    applyHtmlToDoc(doc, '<button>hi</button>');
-    let updates = 0;
-    doc.on('update', () => {
-      updates++;
-    });
-    const changed = applyHtmlToDoc(doc, '<button>hi</button>');
-    expect(changed).toBe(false);
-    expect(updates).toBe(0);
-  });
-
-  test('applyHtmlToDoc emits a minimal op via common prefix + suffix', () => {
-    const doc = new Y.Doc();
-    applyHtmlToDoc(doc, '<button class="cta">Click</button>');
-
-    // Yjs requires `event.changes.delta` to be read inside the observer.
-    let inserts = '';
-    let deletes = 0;
-    const yText = doc.getText(Y_SYNC_TYPES.html);
-    yText.observe((evt) => {
-      for (const d of evt.changes.delta) {
-        if (typeof d.insert === 'string') inserts += d.insert;
-        if (typeof d.delete === 'number') deletes += d.delete;
-      }
-    });
-
-    applyHtmlToDoc(doc, '<button class="cta">Tap</button>');
-    expect(htmlFromDoc(doc)).toBe('<button class="cta">Tap</button>');
-
-    // The change is "Click" → "Tap". With shared prefix
-    // `<button class="cta">` and shared suffix `</button>`, the delta should
-    // only touch the middle.
-    expect(inserts).toBe('Tap');
-    expect(deletes).toBe('Click'.length);
-  });
-
-  test('applyHtmlToDoc handles complete replace (no shared prefix)', () => {
-    const doc = new Y.Doc();
-    applyHtmlToDoc(doc, 'aaaa');
-    applyHtmlToDoc(doc, 'bbbb');
-    expect(htmlFromDoc(doc)).toBe('bbbb');
-  });
-
-  test('applyHtmlToDoc tags transaction with origin', () => {
-    const doc = new Y.Doc();
-    applyHtmlToDoc(doc, 'seed');
-
-    let observedOrigin: unknown = 'unset';
-    doc.on('update', (_update: Uint8Array, origin: unknown) => {
-      observedOrigin = origin;
-    });
-
-    const myOrigin = { id: 'sync-agent' };
-    applyHtmlToDoc(doc, 'changed', myOrigin);
-    expect(observedOrigin).toBe(myOrigin);
-  });
-});
-
-describe('Comments codec', () => {
-  test('commentsFromDoc returns empty array for a fresh doc', () => {
-    expect(commentsFromDoc(new Y.Doc())).toEqual([]);
-  });
-
-  test('applyCommentsToDoc → commentsFromDoc round-trip', () => {
-    const doc = new Y.Doc();
-    const snap = [{ id: 'c1', body: 'hi' }];
-    applyCommentsToDoc(doc, snap);
-    expect(commentsFromDoc(doc)).toEqual(snap);
-  });
-
-  test('applyCommentsToDoc with identical content is a no-op', () => {
-    const doc = new Y.Doc();
-    applyCommentsToDoc(doc, [{ id: 'c1' }]);
-    let updates = 0;
-    doc.on('update', () => {
-      updates++;
-    });
-    const changed = applyCommentsToDoc(doc, [{ id: 'c1' }]);
-    expect(changed).toBe(false);
-    expect(updates).toBe(0);
-  });
-
-  test('applyCommentsToDoc replaces existing entries on disk-wins update', () => {
-    const doc = new Y.Doc();
-    applyCommentsToDoc(doc, [{ id: 'c1' }, { id: 'c2' }]);
-    applyCommentsToDoc(doc, [{ id: 'c3' }]);
-    expect(commentsFromDoc(doc)).toEqual([{ id: 'c3' }]);
-  });
-
-  test('comments share Y_TYPES.comments name with Phase 6 persistence', () => {
-    const doc = new Y.Doc();
-    applyCommentsToDoc(doc, [{ id: 'c1' }]);
-    // The Phase 6 persistence layer reads from this name directly.
-    expect(doc.getArray(Y_TYPES.comments).toArray()).toEqual([{ id: 'c1' }]);
-  });
-});
-
-describe('Annotations codec', () => {
-  test('annotationsFromDoc returns null for a fresh doc', () => {
-    expect(annotationsFromDoc(new Y.Doc())).toBeNull();
-  });
-
-  test('applyAnnotationsToDoc → annotationsFromDoc round-trip', () => {
-    const doc = new Y.Doc();
-    applyAnnotationsToDoc(doc, '<svg></svg>');
-    expect(annotationsFromDoc(doc)).toBe('<svg></svg>');
-  });
-
-  test('applyAnnotationsToDoc with null clears the entry', () => {
-    const doc = new Y.Doc();
-    applyAnnotationsToDoc(doc, '<svg></svg>');
-    applyAnnotationsToDoc(doc, null);
-    expect(annotationsFromDoc(doc)).toBeNull();
-  });
-
-  test('applyAnnotationsToDoc with identical content is a no-op', () => {
-    const doc = new Y.Doc();
-    applyAnnotationsToDoc(doc, '<svg></svg>');
-    let updates = 0;
-    doc.on('update', () => {
-      updates++;
-    });
-    const changed = applyAnnotationsToDoc(doc, '<svg></svg>');
-    expect(changed).toBe(false);
-    expect(updates).toBe(0);
-  });
-
-  test('annotations share Y_TYPES.annotations name with Phase 5 persistence', () => {
-    const doc = new Y.Doc();
-    applyAnnotationsToDoc(doc, '<svg>x</svg>');
-    expect(doc.getMap<string>(Y_TYPES.annotations).get('svg')).toBe('<svg>x</svg>');
-  });
-});
-
-// syncMeta lane — DDR-102. The doc-side body-edit stamp the cold-start
-// newest-wins decision reads. Dedicated Y.Map lane because meta's
-// `last_modified` is in META_LOCAL_KEYS (per-machine, never syncs).
-describe('syncMeta codec (DDR-102)', () => {
-  test('bodyEditAtFromDoc returns null on a fresh doc (older-peer interop)', () => {
-    const doc = new Y.Doc();
-    expect(bodyEditAtFromDoc(doc)).toBeNull();
-  });
-
-  test('stampBodyEdit → bodyEditAtFromDoc round-trip with explicit nowMs', () => {
-    const doc = new Y.Doc();
-    stampBodyEdit(doc, undefined, 1_700_000_000_000);
-    expect(bodyEditAtFromDoc(doc)).toBe(1_700_000_000_000);
-    const by = doc.getMap<unknown>(Y_SYNC_TYPES.syncMeta).get('by');
-    expect(typeof by).toBe('string');
-    expect((by as string).length).toBeGreaterThan(0);
-    expect((by as string).length).toBeLessThanOrEqual(32);
-  });
-
-  test('stampBodyEdit defaults to Date.now()', () => {
-    const doc = new Y.Doc();
-    const before = Date.now();
-    stampBodyEdit(doc);
-    const after = Date.now();
-    const at = bodyEditAtFromDoc(doc);
-    expect(at).not.toBeNull();
-    expect(at as number).toBeGreaterThanOrEqual(before);
-    expect(at as number).toBeLessThanOrEqual(after);
-  });
-
-  test('a hostile/garbage bodyEditAt value reads as null', () => {
-    const doc = new Y.Doc();
-    doc.getMap<unknown>(Y_SYNC_TYPES.syncMeta).set('bodyEditAt', 'not-a-number');
-    expect(bodyEditAtFromDoc(doc)).toBeNull();
-    doc.getMap<unknown>(Y_SYNC_TYPES.syncMeta).set('bodyEditAt', Number.POSITIVE_INFINITY);
-    expect(bodyEditAtFromDoc(doc)).toBeNull();
-  });
-
-  test('body apply + stamp wrapped in one transaction emits ONE update', () => {
-    const doc = new Y.Doc();
-    let updates = 0;
-    doc.on('update', () => {
-      updates++;
-    });
-    const origin = { agent: 'test' };
-    doc.transact(() => {
-      applyHtmlToDoc(doc, '<div>v1</div>', origin);
-      stampBodyEdit(doc, origin, 123);
-    }, origin);
-    expect(updates).toBe(1);
-    expect(htmlFromDoc(doc)).toBe('<div>v1</div>');
-    expect(bodyEditAtFromDoc(doc)).toBe(123);
-  });
-
-  test('the stamp syncs to a peer doc via update exchange', () => {
-    const a = new Y.Doc();
-    const b = new Y.Doc();
-    a.on('update', (u: Uint8Array) => Y.applyUpdate(b, u));
-    stampBodyEdit(a, undefined, 456);
-    expect(bodyEditAtFromDoc(b)).toBe(456);
-  });
-});

package/apps/studio/test/sync-cold-seed-dedup.test.ts

@@ -1,187 +0,0 @@
-// Concurrent cold-seed de-duplication — F1 regression.
-//
-// RCA: `.ai/logs/rca/issue-collab-cold-seed-tsx-duplication.md`. When TWO
-// dev-servers seed the SAME canvas slug into an EMPTY hub at the SAME instant,
-// each reads `docBody === empty` before the other's `seed-local-up` write has
-// propagated, so both apply their (identical) body. Two `applyHtmlToDoc`
-// insertions from two Yjs clientIDs into one Y.Text are NOT content-deduped by
-// the CRDT — the body doubled (two `export default`), failing the canvas build.
-//
-// The fix elects a single writer (`syncMeta.seededBy` — Y.Map LWW converges it
-// to ONE clientID on every peer) which, inside a bounded post-seed window,
-// re-applies the canonical body so `applyHtmlToDoc`'s diff deletes the trailing
-// duplicate. These tests pin: (1) simultaneous seed → one copy, (2) a fresh peer
-// booting against an already-doubled hub recovers, (3) the sequential control
-// stays clean (no over-eager collapse of legitimately-adopted state).
-
-import { afterEach, beforeEach, describe, expect, test } from 'bun:test';
-import { mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import * as Y from 'yjs';
-
-import { type CanvasSyncAgent, createCanvasSyncAgent } from '../sync/agent.ts';
-import { htmlFromDoc } from '../sync/codec.ts';
-import { createEchoGuard } from '../sync/echo-guard.ts';
-
-// A realistic canvas body — the un-buildable failure is `export default` × 2.
-const BODY = [
-  'import { DesignCanvas } from "@maude/canvas-lib";',
-  'export default function Screen() {',
-  '  return <DesignCanvas><h1>Shared draft</h1></DesignCanvas>;',
-  '}',
-  '',
-].join('\n');
-
-const TRANSPORT = Symbol('transport');
-
-let dirA: string;
-let dirB: string;
-let docA: Y.Doc;
-let docB: Y.Doc;
-let agentA: CanvasSyncAgent | undefined;
-let agentB: CanvasSyncAgent | undefined;
-
-function pathsFor(dir: string) {
-  return {
-    html: join(dir, 'screen.tsx'),
-    comments: join(dir, '_comments', 'screen.json'),
-    annotations: join(dir, 'screen.annotations.svg'),
-  };
-}
-
-function writeLocalBody(dir: string, body: string): void {
-  // Seed disk before the agent reconciles (the local side of the cold start).
-  writeFileSync(pathsFor(dir).html, body);
-}
-
-function makeAgent(doc: Y.Doc, dir: string): CanvasSyncAgent {
-  const a = createCanvasSyncAgent({
-    slug: 'screen',
-    doc,
-    paths: pathsFor(dir),
-    echoGuard: createEchoGuard(),
-    flushMs: 0, // synchronous flush via queueMicrotask
-  });
-  a.start();
-  return a;
-}
-
-/** Bidirectional full-state exchange, looped until the de-dup repair (which
- *  fires synchronously inside applyUpdate) has propagated + settled. */
-function syncDocs(d1: Y.Doc, d2: Y.Doc, rounds = 6): void {
-  for (let i = 0; i < rounds; i++) {
-    Y.applyUpdate(d2, Y.encodeStateAsUpdate(d1), TRANSPORT);
-    Y.applyUpdate(d1, Y.encodeStateAsUpdate(d2), TRANSPORT);
-  }
-}
-
-beforeEach(() => {
-  dirA = mkdtempSync(join(tmpdir(), 'cold-seed-a-'));
-  dirB = mkdtempSync(join(tmpdir(), 'cold-seed-b-'));
-  docA = new Y.Doc();
-  docB = new Y.Doc();
-});
-
-afterEach(() => {
-  agentA?.stop();
-  agentB?.stop();
-  agentA = undefined;
-  agentB = undefined;
-  rmSync(dirA, { recursive: true, force: true });
-  rmSync(dirB, { recursive: true, force: true });
-});
-
-describe('concurrent cold-seed → single body', () => {
-  test('two peers seed identical bodies into an empty hub at once → ONE copy', async () => {
-    writeLocalBody(dirA, BODY);
-    writeLocalBody(dirB, BODY);
-    agentA = makeAgent(docA, dirA);
-    agentB = makeAgent(docB, dirB);
-
-    // The race: BOTH reconcile against an empty doc before either propagates.
-    await agentA.reconcile();
-    await agentB.reconcile();
-
-    // Hub merges both seeds — the moment the duplication would surface.
-    syncDocs(docA, docB);
-
-    // Both docs converge to exactly ONE copy (no doubled `export default`).
-    expect(htmlFromDoc(docA)).toBe(BODY);
-    expect(htmlFromDoc(docB)).toBe(BODY);
-    // And the count of `export default` is 1 — the build-breaking signature gone.
-    expect(htmlFromDoc(docA).match(/export default/g)?.length).toBe(1);
-
-    // Disk on both peers mirrors the single copy.
-    await agentA.flush();
-    await agentB.flush();
-    expect(readFileSync(pathsFor(dirA).html, 'utf8')).toBe(BODY);
-    expect(readFileSync(pathsFor(dirB).html, 'utf8')).toBe(BODY);
-  });
-
-  test('adopt-mode concurrent seed also self-heals to one copy', async () => {
-    writeLocalBody(dirA, BODY);
-    writeLocalBody(dirB, BODY);
-    agentA = createCanvasSyncAgent({
-      slug: 'screen',
-      doc: docA,
-      paths: pathsFor(dirA),
-      echoGuard: createEchoGuard(),
-      flushMs: 0,
-      adopt: true,
-    });
-    agentB = createCanvasSyncAgent({
-      slug: 'screen',
-      doc: docB,
-      paths: pathsFor(dirB),
-      echoGuard: createEchoGuard(),
-      flushMs: 0,
-      adopt: true,
-    });
-    agentA.start();
-    agentB.start();
-
-    await agentA.reconcile();
-    await agentB.reconcile();
-    syncDocs(docA, docB);
-
-    expect(htmlFromDoc(docA)).toBe(BODY);
-    expect(htmlFromDoc(docB)).toBe(BODY);
-  });
-});
-
-describe('recovery of an already-duplicated hub (requirement #3)', () => {
-  test('a peer booting against a doubled doc collapses it on reconcile', async () => {
-    writeLocalBody(dirA, BODY);
-    // Simulate a hub that already concatenated two identical seeds.
-    const t = docA.getText('html');
-    t.insert(0, BODY);
-    t.insert(BODY.length, BODY);
-    expect(htmlFromDoc(docA)).toBe(BODY + BODY);
-
-    agentA = makeAgent(docA, dirA);
-    await agentA.reconcile();
-
-    expect(htmlFromDoc(docA)).toBe(BODY);
-    expect(htmlFromDoc(docA).match(/export default/g)?.length).toBe(1);
-  });
-});
-
-describe('sequential control — no over-eager collapse', () => {
-  test('B joining after A seeded adopts the single copy (no duplication)', async () => {
-    writeLocalBody(dirA, BODY);
-    writeLocalBody(dirB, BODY);
-    agentA = makeAgent(docA, dirA);
-    agentB = makeAgent(docB, dirB);
-
-    // A seeds first and FULLY propagates before B reconciles.
-    await agentA.reconcile();
-    syncDocs(docA, docB);
-    // B now sees the hub already holds the body → noop (adopt), no second seed.
-    await agentB.reconcile();
-    syncDocs(docA, docB);
-
-    expect(htmlFromDoc(docA)).toBe(BODY);
-    expect(htmlFromDoc(docB)).toBe(BODY);
-  });
-});