typo 5.0.2 → 5.0.3.98

data/spec/models/blacklist_pattern_spec.rb

@@ -0,0 +1,12 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe BlacklistPattern, 'from Test::Unit' do
+  before do
+    @blacklist_pattern = BlacklistPattern.find(:first)
+  end
+
+  # Replace this with your real tests.
+  def test_truth
+    assert_kind_of BlacklistPattern,  @blacklist_pattern
+  end
+end

data/spec/models/blog_spec.rb

@@ -1,8 +1,6 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe "Given the first Blog fixture" do
-  fixtures :blogs, :contents, :sidebars
-
   before(:each) { @blog = blogs(:default) }
 
   it ":blog_name == 'test blog'" do
@@ -22,7 +20,15 @@ describe "Given the first Blog fixture" do
     @blog.url_for(:controller => 'articles', :action => 'read', :id => 1).should == 'http://myblog.net/articles/read/1'
   end
 
-  it "blog has one sidebar" do
-    @blog.should have(1).sidebars
+  it "should be the only blog allowed" do
+    Blog.new.should_not be_valid
+  end
+end
+
+describe "Given no blogs" do
+  before(:each)  { Blog.destroy_all }
+
+  it "should allow the creation of a valid default blog" do
+    Blog.new.should be_valid
   end
 end

data/spec/models/cache_support_spec.rb

@@ -1,8 +1,6 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe 'Given a published article' do
-  fixtures :blogs, :contents, :feedback, :users, :text_filters
-
   before(:each) do
     @article = contents(:article1)
   end
@@ -34,8 +32,6 @@ describe 'Given a published article' do
 end
 
 describe "Given an unpublished article" do
-  fixtures :blogs, :contents, :feedback, :users, :text_filters
-
   before(:each) { @article = contents(:article4) }
 
   it "publishing smashes the cache" do

data/spec/models/category_spec.rb

@@ -1,8 +1,6 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe 'Given the results of Category.find_all_with_article_counters' do
-  fixtures :contents, :categories, :categorizations, :blogs
-
   before(:each) { @cats = Category.find_all_with_article_counters }
 
   it "Categories should be sorted by category.position" do
@@ -17,8 +15,6 @@ describe 'Given the results of Category.find_all_with_article_counters' do
 end
 
 describe 'Given the fixtures' do
-  fixtures :contents, :categories, :categorizations, :blogs
-
   it 'find gets the order right' do
     cats = Category.find(:all)
     cats.should == cats.sort_by { |c| c.position }
@@ -41,7 +37,7 @@ describe 'Given the fixtures' do
 
   it 'A category knows its url' do
     categories(:software).permalink_url.should ==
-      'http://myblog.net/articles/category/software'
+      'http://myblog.net/category/software'
   end
 end
 

data/spec/models/comment_spec.rb

@@ -0,0 +1,186 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+require 'dns_mock'
+
+describe Comment do
+  before(:each) do
+    CachedModel.cache_reset
+  end
+
+  def test_permalink_url
+    c = feedback(:old_comment)
+    assert_equal "http://myblog.net/2004/05/01/inactive-article#comment-#{c.id}", c.permalink_url
+  end
+
+  def test_edit_url
+    c = feedback(:old_comment)
+    assert_equal "http://myblog.net/admin/comments/edit/#{c.id}", c.edit_url
+  end
+
+  def test_delete_url
+    c = feedback(:old_comment)
+    assert_equal "http://myblog.net/admin/comments/destroy/#{c.id}", c.delete_url
+  end
+
+  def test_save_regular
+    assert feedback(:comment2).save
+    assert_equal "http://www.google.com", feedback(:comment2).url
+  end
+
+  def test_save_spam
+    assert feedback(:spam_comment).save
+    assert_equal "http://fakeurl.com", feedback(:spam_comment).url
+  end
+
+  def test_create_comment
+    c = Comment.new
+    c.author = 'Bob'
+    c.article_id = contents(:article1).id
+    c.body = 'nice post'
+    c.ip = '1.2.3.4'
+
+    assert c.save
+    assert c.guid.size > 15
+  end
+
+  def test_reject_spam_rbl
+    cmt = Comment.new do |c|
+      c.author = "Spammer"
+      c.body = %{This is just some random text. <a href="http://chinaaircatering.com">without any senses.</a>. Please disregard.}
+      c.url = "http://buy-computer.us"
+      c.ip = "212.42.230.206"
+    end
+    assert cmt.spam?
+    assert !cmt.status_confirmed?
+  end
+
+  def test_not_spam_but_rbl_lookup_succeeds
+    cmt      = Comment.new do |c|
+      c.author = "Not a Spammer"
+      c.body   = "Useful commentary!"
+      c.url    = "http://www.bofh.org.uk"
+      c.ip     = "10.10.10.10"
+    end
+    assert !cmt.spam?
+    assert !cmt.status_confirmed?
+  end
+
+  def test_reject_spam_pattern
+    cmt = Comment.new do |c|
+      c.author = "Another Spammer"
+      c.body = "Texas hold-em poker crap"
+      c.url = "http://texas.hold-em.us"
+    end
+    assert cmt.spam?
+    assert !cmt.status_confirmed?
+  end
+
+  def test_reject_spam_uri_limit
+    c = Comment.new do |c|
+      c.author = "Yet Another Spammer"
+      c.body = %{ <a href="http://www.one.com/">one</a> <a href="http://www.two.com/">two</a> <a href="http://www.three.com/">three</a> <a href="http://www.four.com/">four</a> }
+      c.url = "http://www.uri-limit.com"
+      c.ip = "123.123.123.123"
+    end
+
+    assert c.spam?
+    assert !c.status_confirmed?
+  end
+
+  def test_reject_article_age
+    c = Comment.new do |c|
+      c.author = "Old Spammer"
+      c.body = "Old trackback body"
+      c.article = contents(:inactive_article)
+    end
+
+    assert ! c.save
+    assert c.errors.invalid?('article_id')
+
+    c.article = @article1
+
+    assert c.save
+    assert c.errors.empty?
+  end
+
+  def test_modify_old_comment
+    c = contents(:inactive_article).comments.first
+    c.body = 'Comment body <em>italic</em> <strong>bold</strong>'
+    assert c.save
+    assert c.errors.empty?
+  end
+
+  def test_article_relation
+    assert feedback(:comment2).article
+    assert_equal contents(:article1), feedback(:comment2).article
+  end
+
+  def test_xss_rejection
+    c = Comment.new do |c|
+      c.body = "Test foo <script>do_evil();</script>"
+      c.author = 'Bob'
+      c.article_id = contents(:article1).id
+    end
+
+    # Test each filter to make sure that we don't allow scripts through.
+    # Yes, this is ugly.
+    ['','textile','markdown','smartypants','markdown smartypants'].each do |filter|
+      Blog.default.comment_text_filter = filter
+
+      assert c.save
+      assert c.errors.empty?
+
+      assert c.html(:body) !~ /<script>/
+    end
+  end
+
+  def test_withdraw
+    c = Comment.find(feedback(:comment2).id)
+    assert c.withdraw!
+    assert ! c.published?
+    assert c.spam?
+    assert c.status_confirmed?
+    c.reload
+    assert ! c.published?
+    assert c.spam?
+    assert c.status_confirmed?
+  end
+
+  def test_published
+    a = Article.new(:title => 'foo')
+    assert a.save
+
+    assert_equal 0, a.published_comments.size
+    c = a.comments.build(:body => 'foo', :author => 'bob', :published => true, :published_at => Time.now)
+    assert c.save
+    assert c.published?
+    c.reload
+    a.reload
+
+    assert_equal 1, a.published_comments.size
+    c.withdraw!
+
+    a = Article.new(:title => 'foo')
+    assert_equal 0, a.published_comments.size
+  end
+
+  def test_status_confirmed
+    a = contents(:spammed_article)
+    assert !a.comments[0].status_confirmed?
+    assert  a.comments[1].status_confirmed?
+
+    a.reload
+    assert_equal 1,
+      a.comments.find_all_by_status_confirmed(true).size
+    assert_equal 1,
+      a.comments.find_all_by_status_confirmed(true).size
+    a.comments[0].withdraw!
+    assert_equal 2,
+      a.comments.find_all_by_status_confirmed(true).size
+  end
+
+  def test_default_filter
+    a = Comment.find(:first)
+    assert_equal 'markdown', a.default_text_filter.name
+  end
+end

data/spec/models/configuration_spec.rb

@@ -1,7 +1,10 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe 'Given a new blog' do
-  before(:each) { @blog = Blog.new }
+  before(:each) do
+    Blog.delete_all
+    @blog = Blog.new
+  end
 
   # Must find a better name for this key!
   it 'Global spam protection is not enabled' do
@@ -69,8 +72,8 @@ describe 'Given a new blog' do
     @blog.should be_show_extended_on_rss
   end
 
-  it '#theme should be "standard_issue"' do
-    @blog.theme.should == 'standard_issue'
+  it '#theme should be "typographic"' do
+    @blog.theme.should == 'typographic'
   end
 
   it 'should not use gravatar' do
@@ -84,7 +87,7 @@ describe 'Given a new blog' do
   end
 
   it 'should ping technorati, blog.gs and weblogs.com' do
-    @blog.ping_urls.should == "http://rpc.technorati.com/rpc/ping\nhttp://ping.blo.gs/\nhttp://rpc.weblogs.com/RPC2"
+    @blog.ping_urls.should == "http://blogsearch.google.com/ping/RPC2\nhttp://rpc.technorati.com/rpc/ping\nhttp://ping.blo.gs/\nhttp://rpc.weblogs.com/RPC2"
   end
 
   it 'should send outbound pings' do
@@ -95,11 +98,6 @@ describe 'Given a new blog' do
     @blog.email_from.should == 'typo@example.com'
   end
 
-  it 'Jabber address and password should be blank' do
-    @blog.jabber_address.should be_blank
-    @blog.jabber_password.should be_blank
-  end
-
   it '#is_okay should be false until #blog_name is explicitly set' do
     @blog.should_not be_configured
     @blog.blog_name = 'Specific blog name'

data/spec/models/content_state/feedback_states_spec.rb

@@ -0,0 +1,64 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe 'FeedbackStates from Test::Unit' do
+  before(:each) do
+    @comment = contents(:article1).comments.build(:author => 'Piers',
+                                                  :body => 'Body')
+  end
+
+  def test_ham_all_the_way
+    assert @comment.unclassified?
+    assert   @comment.published?
+    assert   @comment.just_published?
+    assert   @comment.just_changed_published_status?
+    assert   @comment.save
+    assert   @comment.just_changed_published_status?
+    assert   @comment.just_published?
+    @comment = Comment.find(@comment.id)
+    assert ! @comment.just_changed_published_status?
+    assert ! @comment.just_published?
+    @comment.confirm_classification
+    assert   @comment.published?
+    assert ! @comment.just_published?
+    assert ! @comment.just_changed_published_status?
+  end
+
+  def test_spam_all_the_way
+    class << @comment
+      def classify
+        :spam
+      end
+    end
+    assert @comment.unclassified?
+    assert ! @comment.published?
+    assert ! @comment.just_published?
+    assert ! @comment.just_changed_published_status?
+    assert   @comment.save
+    assert ! @comment.published?
+    assert ! @comment.just_published?
+    assert ! @comment.just_changed_published_status?
+    @comment = Comment.find(@comment.id)
+    assert ! @comment.just_changed_published_status?
+    assert ! @comment.just_published?
+    @comment.confirm_classification
+    assert ! @comment.published?
+    assert ! @comment.just_published?
+    assert ! @comment.just_changed_published_status?
+  end
+
+  def test_presumed_spam_marked_as_ham
+    @comment[:state] = 'presumed_spam'
+    @comment.mark_as_ham
+    assert @comment.published?
+    assert @comment.just_published?
+    assert @comment.just_changed_published_status?
+  end
+
+  def test_presumed_ham_marked_as_spam
+    @comment[:state] = 'presumed_ham'
+    @comment.mark_as_spam
+    assert ! @comment.published?
+    assert ! @comment.just_published?
+    assert   @comment.just_changed_published_status?
+  end
+end

data/spec/models/notification_spec.rb

@@ -0,0 +1,8 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+class NotificationTest < Test::Unit::TestCase
+  # Replace this with your real tests.
+  def test_truth
+    assert true
+  end
+end

data/spec/models/page_spec.rb

@@ -1,8 +1,6 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe 'Given the fixture :first_page' do
-  fixtures :contents, :blogs
-
   before(:each) do
     @page = contents(:first_page)
   end
@@ -87,13 +85,7 @@ describe 'Given a valid page' do
   it_should_behave_like "ValidPageHelper"
 
   it 'default filter should be fetched from the blog' do
-    blog = mock_model(Blog)
-    Blog.stub!(:find).and_return(blog)
-    textfilter = mock_model(TextFilter)
-    textfilter.stub!(:to_text_filter).and_return(textfilter)
-
-    blog.should_receive(:text_filter).and_return(textfilter)
-    @page = Page.new(valid_attributes.merge(:blog => blog))
-    @page.default_text_filter.should == textfilter
+    @page = Page.new()
+    @page.default_text_filter.name.should == Blog.default.text_filter
   end
 end

data/spec/models/ping_pinger_spec.rb

@@ -0,0 +1,33 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe 'Ping::Pinger with Test::Unit' do
+  before do
+    # avoid mocking constructor until we need it for something
+    @pinger = Ping::Pinger.allocate
+    class << @pinger
+      attr_writer :response
+    end
+  end
+
+  def test_pingback_url_nil
+    @pinger.response = mock('response')
+    @pinger.response.stub!(:body).and_return('')
+    @pinger.response.stub!(:[]).and_return(nil)
+    assert_nil @pinger.pingback_url
+  end
+
+  # TODO: why do we assume that we can XML attribute order?
+  def test_pingback_url_from_body
+    @pinger.response = mock('response')
+    @pinger.response.stub!(:body).and_return('<link rel="pingback" href="foo" />')
+    @pinger.response.stub!(:[]).and_return(nil)
+    assert_equal 'foo', @pinger.pingback_url
+  end
+
+  def test_pingback_url
+    @pinger.response = mock('response')
+    @pinger.response.stub!(:body).and_return('')
+    @pinger.response.stub!(:[]).and_return(:x_pingback)
+    assert_equal :x_pingback, @pinger.pingback_url
+  end
+end