typo 5.0.2 → 5.0.3.98

data/spec/controllers/xml_controller_spec.rb

@@ -0,0 +1,232 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + '/../../test/test_helper'
+require 'xml_controller'
+require 'dns_mock'
+
+# This test now has optional support for validating the generated RSS feeds.
+# Since Ruby doesn't have a RSS/Atom validator, I'm using the Python source
+# for http://feedvalidator.org and calling it via 'system'.
+#
+# To install the validator, download the source from
+# http://sourceforge.net/cvs/?group_id=99943
+# Then copy src/feedvalidator and src/rdflib into a Python lib directory.
+# Finally, copy src/demo.py into your path as 'feedvalidator', make it executable,
+# and change the first line to something like '#!/usr/bin/python'.
+
+if($validator_installed == nil)
+  $validator_installed = false
+  begin
+    IO.popen("feedvalidator 2> /dev/null","r") do |pipe|
+      if (pipe.read =~ %r{Validating http://www.intertwingly.net/blog/index.})
+        puts "Using locally installed Python feed validator"
+        $validator_installed = true
+      end
+    end
+  rescue
+    nil
+  end
+end
+
+# Re-raise errors caught by the controller.
+class XmlController; def rescue_action(e) raise e end; end
+
+describe XmlController do
+  integrate_views
+
+  def assert_select(*args, &block)
+    @html_document ||= HTML::Document.new(@response.body, false, true)
+    super(*args,&block)
+  end
+
+  before do
+    Article.create!(:title => "News from the future!",
+                    :body => "The future is cool!",
+                    :keywords => "future",
+                    :created_at => Time.now + 12.minutes)
+  end
+
+  def assert_feedvalidator(rss, todo=nil)
+    return unless $validator_installed
+
+    begin
+      file = Tempfile.new('typo-feed-test')
+      filename = file.path
+      file.write(rss)
+      file.close
+
+      messages = ''
+
+      IO.popen("feedvalidator file://#{filename}") do |pipe|
+        messages = pipe.read
+      end
+
+      okay, messages = parse_validator_messages(messages)
+
+      if todo && ! ENV['RUN_TODO_TESTS']
+        assert !okay, messages + "\nTest unexpectedly passed!\nFeed text:\n"+rss
+      else
+        assert okay, messages + "\nFeed text:\n"+rss
+      end
+    end
+  end
+
+  def parse_validator_messages(message)
+    messages=message.split(/\n/).reject do |m|
+      m =~ /Feeds should not be served with the "text\/plain" media type/ ||
+      m =~ /Self reference doesn't match document location/
+    end
+
+    if(messages.size > 1)
+      [false, messages.join("\n")]
+    else
+      [true, ""]
+    end
+  end
+
+  def assert_moved_permanently_to(location)
+    assert_response :moved_permanently
+    assert_equal location, @response.headers["Location"]
+  end
+
+  def test_feed_rss20
+    get :feed, :format => 'rss20', :type => 'feed'
+    assert_moved_permanently_to formatted_articles_url(:rss)
+  end
+
+  def test_feed_rss20_comments
+    get :feed, :format => 'rss20', :type => 'comments'
+    assert_response :moved_permanently
+    assert_moved_permanently_to formatted_admin_comments_url(:rss)
+  end
+
+  def test_feed_rss20_trackbacks
+    get :feed, :format => 'rss20', :type => 'trackbacks'
+    assert_response :success
+    assert_xml @response.body
+    assert_feedvalidator @response.body
+    assert_rss20
+  end
+
+  def test_feed_rss20_article
+    get :feed, :format => 'rss20', :type => 'article', :id => contents(:article1).id
+    assert_moved_permanently_to formatted_article_url(contents(:article1), :rss)
+  end
+
+  def test_feed_rss20_category
+    get :feed, :format => 'rss20', :type => 'category', :id => 'personal'
+    assert_moved_permanently_to(formatted_category_url('personal', 'rss'))
+  end
+
+  def test_feed_rss20_tag
+    get :feed, :format => 'rss20', :type => 'tag', :id => 'foo'
+    assert_moved_permanently_to(formatted_tag_url('foo', 'rss'))
+  end
+
+  def test_feed_atom10_feed
+    get :feed, :format => 'atom10', :type => 'feed'
+    assert_response :moved_permanently
+    assert_moved_permanently_to formatted_articles_url('atom')
+  end
+
+  def test_feed_atom10_comments
+    get :feed, :format => 'atom10', :type => 'comments'
+    assert_response :moved_permanently
+    assert_moved_permanently_to formatted_admin_comments_url('atom')
+  end
+
+  def test_feed_atom10_trackbacks
+    get :feed, :format => 'atom10', :type => 'trackbacks'
+    assert_response :success
+    assert_xml @response.body
+    assert_feedvalidator @response.body
+
+    assert_equal(assigns(:items).sort { |a, b| b.created_at <=> a.created_at },
+                 assigns(:items))
+
+    assert_atom10
+
+    assert_select 'title[type=html]'
+    assert_select 'summary'
+  end
+
+  def test_feed_atom10_article
+    get :feed, :format => 'atom10', :type => 'article', :id => contents(:article1).id
+    assert_moved_permanently_to formatted_article_url(contents(:article1), 'atom')
+  end
+
+  def test_feed_atom10_category
+    get :feed, :format => 'atom10', :type => 'category', :id => 'personal'
+    assert_moved_permanently_to(formatted_category_url('personal', 'atom'))
+  end
+
+  def test_feed_atom10_tag
+    get :feed, :format => 'atom10', :type => 'tag', :id => 'foo'
+    assert_moved_permanently_to(formatted_tag_url('foo', 'atom'))
+  end
+
+  def test_articlerss
+    get :articlerss, :id => contents(:article1).id
+    assert_response :redirect
+  end
+
+  def test_commentrss
+    get :commentrss, :id => 1
+    assert_response :redirect
+  end
+
+  def test_trackbackrss
+    get :trackbackrss, :id => 1
+    assert_response :redirect
+  end
+
+  def test_bad_format
+    get :feed, :format => 'atom04', :type => 'feed'
+    assert_response :missing
+  end
+
+  def test_bad_type
+    get :feed, :format => 'rss20', :type => 'foobar'
+    assert_response :missing
+  end
+
+  def test_rsd
+    get :rsd, :id => 1
+    assert_response :success
+    assert_nothing_raised do
+      assert REXML::Document.new(@response.body)
+    end
+  end
+
+  def test_atom03
+    get :feed, :format => 'atom03', :type => 'feed'
+    assert_response :moved_permanently
+    assert_moved_permanently_to formatted_articles_url('atom')
+  end
+
+  def test_itunes
+    get :itunes
+    assert_response :success
+    assert_xml @response.body
+    assert_feedvalidator @response.body, :todo
+  end
+
+  # TODO(laird): make this more robust
+  def test_sitemap
+    get :feed, :format => 'googlesitemap', :type => 'sitemap'
+
+    assert_response :success
+    assert_xml @response.body
+  end
+
+  def assert_rss20
+    assert_select 'rss:root[version=2.0] > channel item', :count => assigns(:items).size
+  end
+
+  def assert_atom10
+    assert_select 'feed:root[xmlns="http://www.w3.org/2005/Atom"] > entry', :count => assigns(:items).size
+  end
+
+  def set_extended_on_rss(value)
+    this_blog.show_extended_on_rss = value
+  end
+end

data/spec/models/article_closing_spec.rb

@@ -0,0 +1,38 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe "CommentClosing from Test::Unit; no I don't know why it's in article_closing_spec.rb" do
+  def an_article(options = {})
+    Article.create(options.reverse_merge(:user_id => 1, :body => 'Foo', :title => 'Bar'))
+  end
+
+  before(:each) do
+    @blog = blogs(:default)
+    @blog.sp_article_auto_close = 0
+    @blog.default_allow_comments = true
+  end
+
+  def test_new_article_should_be_open_if_auto_close_is_zero
+    art = an_article
+    art.created_at = Time.now
+    assert !art.comments_closed?
+  end
+
+  def test_old_article_should_be_open_if_auto_close_is_zero
+    art = an_article(:created_at => Time.now - 1000.days)
+    assert !art.comments_closed?
+  end
+
+  def test_new_article_should_be_open_if_auto_close_is_thirty
+    @blog.sp_article_auto_close = 30
+    art = an_article
+    assert !art.comments_closed?
+    art.created_at = Time.now - 29.days
+    assert !art.comments_closed?
+  end
+
+  def test_old_article_should_be_closed_if_auto_close_is_thirty
+    @blog.sp_article_auto_close = 30
+    art = an_article(:created_at => Time.now - 31.days)
+    assert art.comments_closed?
+  end
+end

data/spec/models/article_spec.rb

@@ -1,17 +1,293 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "a valid Article" do
-  before(:each) do
-    @a = Article.new(:title => 'Test article', :body => 'body',
-                     :author => mock_model(User), :blog => mock_model(Blog))
+describe Article do
+  before do
+    @articles = []
   end
 
-  it "should be valid" do
-    @a.should be_valid
+  def assert_results_are(*expected)
+    assert_equal expected.size, @articles.size
+    expected.each do |i|
+      assert @articles.include?(i.is_a?(Symbol) ? contents(i) : i)
+    end
   end
 
-  it "should cast #published = '0' to false" do
-    @a.published = '0'
-    @a.published.should == false
+  def test_content_fields
+    a = Article.new
+    assert_equal [:body, :extended], a.content_fields
   end
+
+  def test_permalink_url
+    a = contents(:article3)
+    assert_equal 'http://myblog.net/2004/06/01/article-3', a.permalink_url
+  end
+
+  def test_edit_url
+    a = contents(:article3)
+    assert_equal "http://myblog.net/admin/content/edit/#{a.id}", a.edit_url
+  end
+
+  def test_delete_url
+    a = contents(:article3)
+    assert_equal "http://myblog.net/admin/content/destroy/#{a.id}", a.delete_url
+  end
+
+  def test_feed_url
+    a = contents(:article3)
+    assert_equal "http://myblog.net/xml/atom10/article/#{a.id}/feed.xml", a.feed_url(:atom10)
+    assert_equal "http://myblog.net/xml/rss20/article/#{a.id}/feed.xml", a.feed_url(:rss20)
+  end
+
+  def test_create
+    a = Article.new
+    a.user_id = 1
+    a.body = "Foo"
+    a.title = "Zzz"
+    assert a.save
+
+    a.categories << Category.find(categories(:software).id)
+    assert_equal 1, a.categories.size
+
+    b = Article.find(a.id)
+    assert_equal 1, b.categories.size
+  end
+
+  def test_permalink
+    assert_equal( contents(:article3), Article.find_by_date(2004,06,01) )
+    assert_equal( [contents(:article2), contents(:article1)],
+                  Article.find_all_by_date(2.days.ago.year) )
+  end
+
+  def test_permalink_with_title
+    assert_equal( contents(:article3),
+                  Article.find_by_permalink(2004, 06, 01, "article-3") )
+    assert_raises(ActiveRecord::RecordNotFound) do
+      Article.find_by_permalink(2005, 06, 01, "article-5")
+    end
+  end
+
+  def test_strip_title
+    assert_equal "article-3", "Article-3".to_url
+    assert_equal "article-3", "Article 3!?#".to_url
+    assert_equal "there-is-sex-in-my-violence", "There is Sex in my Violence!".to_url
+    assert_equal "article", "-article-".to_url
+    assert_equal "lorem-ipsum-dolor-sit-amet-consectetaur-adipisicing-elit", "Lorem ipsum dolor sit amet, consectetaur adipisicing elit".to_url
+    assert_equal "my-cats-best-friend", "My Cat's Best Friend".to_url
+  end
+
+  def test_perma_title
+    assert_equal "article-1", contents(:article1).stripped_title
+    assert_equal "article-2", contents(:article2).stripped_title
+    assert_equal "article-3", contents(:article3).stripped_title
+  end
+
+  def test_html_title
+    a = Article.new
+    a.title = "This <i>is</i> a <b>test</b>"
+    assert a.save
+
+    assert_equal 'this-is-a-test', a.permalink
+  end
+
+  def test_urls
+    urls = contents(:article4).html_urls
+    assert_equal ["http://www.example.com/public"], urls
+  end
+
+  ### XXX: Should we have a test here?
+  def test_send_pings
+  end
+
+  ### XXX: Should we have a test here?
+  def test_send_multiple_pings
+  end
+
+  def test_tags
+    a = Article.new(:title => 'Test tag article',
+                    :keywords => 'test tag tag stuff');
+
+    assert_kind_of Article, a
+    assert_equal 0, a.tags.size
+
+    a.keywords_to_tags
+
+    assert_equal 3, a.tags.size
+    assert_equal ["test", "tag", "stuff"].sort , a.tags.collect {|t| t.name}.sort
+    assert a.save
+
+    a.keywords = 'tag bar stuff foo'
+    a.keywords_to_tags
+
+    assert_equal 4, a.tags.size
+    assert_equal ["foo", "bar", "tag", "stuff"].sort , a.tags.collect {|t| t.name}.sort
+
+    a.keywords='tag bar'
+    a.keywords_to_tags
+
+    assert_equal 2, a.tags.size
+
+    a.keywords=''
+    a.keywords_to_tags
+
+    assert_equal 0, a.tags.size
+
+    b = Article.new(:title => 'Tag Test 2',
+                    :keywords => 'tag test article one two three')
+
+    assert_kind_of Article,b
+    assert_equal 0, b.tags.size
+
+    c = Article.new(:title => 'Foo', :keywords => 'test "tag test" web2.0')
+    c.keywords_to_tags
+
+    assert_equal 3, c.tags.size
+    assert_equal ['test', 'tagtest', 'web2-0'].sort, c.tags.collect(&:name).sort
+  end
+
+  def test_find_published_by_tag_name
+    @articles = Tag.find_by_name(tags(:foo).name).published_articles
+
+    assert_results_are(:article1, :article2)
+  end
+
+
+  def test_find_published
+    @articles = Article.find_published
+    assert_results_are(:search_target, :article1, :article2,
+                       :article3, :inactive_article,:xmltest,
+                       :spammed_article)
+
+    @articles = Article.find_published(:all,
+                                                  :conditions => "title = 'Article 1!'")
+    assert_results_are :article1
+  end
+
+  def test_just_published_flag
+    art = Article.new(:title => 'title',
+                                   :body => 'body',
+                                   :published => true)
+    assert art.just_changed_published_status?
+    assert art.save
+
+    art = Article.find(art.id)
+    assert !art.just_changed_published_status?
+
+    art = Article.create!(:title => 'title2',
+                          :body => 'body',
+                          :published => false)
+
+    assert ! art.just_changed_published_status?
+  end
+
+  def test_future_publishing
+    assert_sets_trigger(Article.create!(:title => 'title', :body => 'body',
+                                        :published => true,
+                                        :published_at => Time.now + 4.seconds))
+  end
+
+  def test_future_publishing_without_published_flag
+    assert_sets_trigger Article.create!(:title => 'title', :body => 'body',
+                                        :published_at => Time.now + 4.seconds)
+  end
+
+  def test_triggers_are_dependent
+    art = Article.create!(:title => 'title', :body => 'body',
+                          :published_at => Time.now + 1.hour)
+    assert_equal 1, Trigger.count
+    art.destroy
+    assert_equal 0, Trigger.count
+  end
+
+  def assert_sets_trigger(art)
+    assert_equal 1, Trigger.count
+    assert Trigger.find(:first, :conditions => ['pending_item_id = ?', art.id])
+    sleep 4
+    Trigger.fire
+    art.reload
+    assert art.published
+  end
+
+  def test_find_published_by_category
+    Article.create!(:title      => "News from the future!",
+                    :body       => "The future is cool!",
+                    :keywords   => "future",
+                    :published_at => Time.now + 12.minutes)
+
+    @articles = Category.find_by_permalink('personal').published_articles
+    assert_results_are :article1, :article2, :article3
+
+    @articles = Category.find_by_permalink('software').published_articles
+    assert_results_are :article1
+  end
+
+  def test_find_published_by_nonexistent_category_raises_exception
+    assert_raises ActiveRecord::RecordNotFound do
+      Category.find_by_permalink('does-not-exist').published_articles
+    end
+  end
+
+  def test_destroy_file_upload_associations
+    a = contents(:article1)
+    assert_equal 2, a.resources.size
+    a.resources << resources(:resource3)
+    assert_equal 3, a.resources.size
+    a.destroy
+    assert_equal 0, Resource.find(:all, :conditions => "article_id = #{a.id}").size
+  end
+
+  def test_notifications
+    a = Article.new(:title => 'New Article', :body => 'Foo', :author => 'Tobi', :user => users(:tobi))
+    assert a.save
+
+    assert_equal 2, a.notify_users.size
+    assert_equal ['bob', 'randomuser'], a.notify_users.collect {|u| u.login }.sort
+  end
+
+  def test_tags_on_update
+    contents(:article3).update_attribute :keywords, "my new tags"
+    assert_equal 3, contents(:article3).reload.tags.size
+    assert contents(:article3).tags.include?(Tag.find_by_name("new"))
+  end
+
+  # this also tests time_delta, indirectly
+  def test_find_all_by_date
+    feb28 = Article.new(:published => true)
+    mar1  = Article.new(:published => true)
+    mar2  = Article.new(:published => true)
+
+    feb28.title = "February 28"
+    mar1.title  = "March 1"
+    mar2.title  = "March 2"
+
+    feb28.created_at = feb28.published_at = "2004-02-28"
+    mar1.created_at  = mar1.published_at = "2004-03-01"
+    mar2.created_at  = mar2.published_at = "2004-03-02"
+
+    [feb28, mar1, mar2].each do |x|
+      x.state = :published
+      x.save
+    end
+
+    assert_equal(1, Article.find_all_by_date(2004,02).size)
+    assert_equal(2, Article.find_all_by_date(2004,03).size)
+    assert_equal(1, Article.find_all_by_date(2004,03,01).size)
+  end
+
+  def test_withdrawal
+    art = Article.find(contents(:article1).id)
+    assert   art.published?
+    assert ! art.withdrawn?
+    art.withdraw!
+    assert ! art.published?
+    assert   art.withdrawn?
+    art.reload
+    assert ! art.published?
+    assert   art.withdrawn?
+  end
+
+  def test_default_filter
+    a = Article.find(contents(:article1).id)
+    assert_equal 'textile', a.default_text_filter.name
+  end
+
 end