txgh-server 3.1.0 → 4.0.0.beta

data/spec/webhooks/gitlab/request_handler_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+require 'helpers/gitlab_payload_builder'
+require 'helpers/nil_logger'
+require 'helpers/standard_txgh_setup'
+require 'helpers/test_request'
+
+describe TxghServer::Webhooks::Gitlab::RequestHandler do
+  include StandardTxghSetup
+
+  let(:logger) { NilLogger.new }
+  let(:ref) { 'heads/my_ref' }
+  let(:headers) { { 'HTTP_X_GITLAB_EVENT' => event } }
+  let(:body) { payload.to_json }
+  let(:request) { TestRequest.new(body: body, headers: headers) }
+  let(:handler) { described_class.new(request, logger) }
+
+  describe '#handle_request' do
+    context 'push event' do
+      let(:event) { 'Push Hook' }
+      let(:payload) { GitlabPayloadBuilder.push_payload(gitlab_repo_name, ref).tap { |p| p.add_commit } }
+
+      it 'does not execute if unauthorized' do
+        expect_any_instance_of(TxghServer::Webhooks::Gitlab::PushHandler).to_not receive(:execute)
+        response = handler.handle_request
+        expect(response.status).to eq(401)
+      end
+
+      context 'with an authentic request' do
+        before(:each) do
+          allow(handler).to receive(:authentic_request?).and_return(true)
+        end
+
+        it 'handles the request with the push handler' do
+          expect_any_instance_of(TxghServer::Webhooks::Gitlab::PushHandler).to receive(:execute).and_return(:response)
+          expect(handler.handle_request).to eq(:response)
+        end
+      end
+    end
+
+    context 'delete event' do
+      let(:event) { 'Push Hook' }
+      let(:payload) { GitlabPayloadBuilder.delete_payload(gitlab_repo_name, ref) }
+
+      it 'does not execute if unauthorized' do
+        expect_any_instance_of(TxghServer::Webhooks::Gitlab::DeleteHandler).to_not receive(:execute)
+        response = handler.handle_request
+        expect(response.status).to eq(401)
+      end
+
+      context 'with an authentic request' do
+        before(:each) do
+          allow(handler).to receive(:authentic_request?).and_return(true)
+        end
+
+        it 'handles the request with the delete handler' do
+          expect_any_instance_of(TxghServer::Webhooks::Gitlab::DeleteHandler).to receive(:execute).and_return(:response)
+          expect(handler.handle_request).to eq(:response)
+        end
+      end
+    end
+
+    context 'unrecognized event' do
+      let(:event) { 'foo' }
+      let(:payload) { { repository: { full_name: gitlab_repo_name } } }
+
+      it 'responds with a 400' do
+        allow(handler).to receive(:authentic_request?).and_return(true)
+        response = handler.handle_request
+        expect(response.status).to eq(400)
+      end
+    end
+  end
+end

data/spec/webhooks/gitlab/status_updater_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+require 'helpers/standard_txgh_setup'
+
+describe TxghServer::Webhooks::Gitlab::StatusUpdater do
+  include StandardTxghSetup
+
+  let(:updater) { TxghServer::Webhooks::Gitlab::StatusUpdater.new(transifex_project, gitlab_repo, ref) }
+  let(:gitlab_error_response) do
+    OpenStruct.new({
+      code: 404,
+      request: double(base_uri: 'https://gitlab.com/api/v3', path: '/foo'),
+      parsed_response: ::Gitlab::ObjectifiedHash.new(
+        error_description: 'Displayed error_description',
+        error: 'also will not be displayed'
+      )
+    })
+  end
+
+  describe '#report_error_and_update_status' do
+    let(:description) { 'An error done occurred, fool' }
+    let(:target_url) { 'http://you-goofed.com' }
+
+    let(:status_params) do
+      { description: description, target_url: target_url }
+    end
+
+    let(:error_params) { { foo: 'bar' } }
+
+    before(:each) do
+      Txgh.events.subscribe(Txgh::Events::ERROR_CHANNEL) { error_params }
+      Txgh.events.subscribe('gitlab.status.error') { status_params }
+    end
+
+    it 'reports the error and updates the status' do
+      expect(Txgh::GitlabStatus).to(
+        receive(:error).with(transifex_project, gitlab_repo, ref, status_params)
+      )
+
+      expect(Txgh.events).to receive(:publish_error!)
+      updater.report_error_and_update_status(StandardError.new)
+    end
+
+    it 'avoids blowing up on gitlab error' do
+      expect(Txgh::GitlabStatus).to(
+        receive(:error).and_raise(::Gitlab::Error::BadRequest.new(gitlab_error_response))
+      )
+
+      expect { updater.report_error_and_update_status(StandardError.new) }.to_not raise_error
+    end
+  end
+
+  describe '#update_status' do
+    it 'updates the gitlab status' do
+      expect(Txgh::GitlabStatus).to receive(:update)
+      updater.update_status
+    end
+
+    it 'avoids blowing up on gitlab error' do
+      expect(Txgh::GitlabStatus).to(
+        receive(:update).and_raise(::Gitlab::Error::BadRequest.new(gitlab_error_response))
+      )
+
+      expect { updater.update_status }.to_not raise_error
+    end
+  end
+end

data/spec/webhooks/transifex/hook_handler_spec.rb

@@ -2,10 +2,7 @@ require 'spec_helper'
 require 'helpers/nil_logger'
 require 'helpers/standard_txgh_setup'
 
-include TxghServer
-include TxghServer::Webhooks::Transifex
-
-describe HookHandler do
+describe TxghServer::Webhooks::Transifex::HookHandler do
   include StandardTxghSetup
 
   let(:requested_resource_slug) do
@@ -13,7 +10,7 @@ describe HookHandler do
   end
 
   let(:handler) do
-    HookHandler.new(
+    TxghServer::Webhooks::Transifex::HookHandler.new(
       project: transifex_project,
       repo: github_repo,
       resource_slug: requested_resource_slug,

data/spec/webhooks/transifex/request_handler_spec.rb

@@ -4,9 +4,7 @@ require 'helpers/standard_txgh_setup'
 require 'helpers/test_request'
 require 'uri'
 
-include TxghServer::Webhooks
-
-describe Transifex::RequestHandler do
+describe TxghServer::Webhooks::Transifex::RequestHandler do
   include StandardTxghSetup
 
   let(:logger) { NilLogger.new }
@@ -44,7 +42,7 @@ describe Transifex::RequestHandler do
     end
 
     it 'does not execute if unauthorized' do
-      expect_any_instance_of(Transifex::HookHandler).to_not receive(:execute)
+      expect_any_instance_of(TxghServer::Webhooks::Transifex::HookHandler).to_not receive(:execute)
       response = handler.handle_request
       expect(response.status).to eq(401)
     end
@@ -55,7 +53,7 @@ describe Transifex::RequestHandler do
       end
 
       it 'handles the request with the hook handler' do
-        expect_any_instance_of(Transifex::HookHandler).to receive(:execute).and_return(:response)
+        expect_any_instance_of(TxghServer::Webhooks::Transifex::HookHandler).to receive(:execute).and_return(:response)
         expect(handler.handle_request).to eq(:response)
       end
 

data/spec/zip_stream_response_spec.rb

@@ -1,9 +1,7 @@
 require 'spec_helper'
 require 'tempfile'
 
-include TxghServer
-
-describe ZipStreamResponse do
+describe TxghServer::ZipStreamResponse do
   def read_zip_from(file)
     contents = {}
 
@@ -26,7 +24,7 @@ describe ZipStreamResponse do
   end
 
   let(:response) do
-    ZipStreamResponse.new(attachment, enum)
+    described_class.new(attachment, enum)
   end
 
   describe '#write_to' do

data/txgh-server.gemspec

@@ -11,13 +11,12 @@ Gem::Specification.new do |s|
   s.description = s.summary = 'An HTTP server for interacting with txgh.'
 
   s.platform = Gem::Platform::RUBY
-  s.has_rdoc = true
 
   s.add_dependency 'mime-types', '~> 2.0'
   s.add_dependency 'sinatra', '~> 1.4'
   s.add_dependency 'sinatra-contrib', '~> 1.4'
   s.add_dependency 'rubyzip', '>= 1.0', '<= 1.1.2'
-  s.add_dependency 'txgh', '~> 6.1'
+  s.add_dependency 'txgh', '7.0.0.beta'
 
   s.require_path = 'lib'
   s.files = Dir['{lib,spec}/**/*', 'README.md', 'txgh-server.gemspec', 'LICENSE']

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: txgh-server
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 4.0.0.beta
 platform: ruby
 authors:
 - Matthew Jackowski
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-18 00:00:00.000000000 Z
+date: 2020-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mime-types
@@ -77,16 +77,16 @@ dependencies:
   name: txgh
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: 7.0.0.beta
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: 7.0.0.beta
 description: An HTTP server for interacting with txgh.
 email:
 - mattjjacko@gmail.com
@@ -100,6 +100,7 @@ files:
 - lib/txgh-server/application.rb
 - lib/txgh-server/download_handler.rb
 - lib/txgh-server/github_request_auth.rb
+- lib/txgh-server/gitlab_request_auth.rb
 - lib/txgh-server/response.rb
 - lib/txgh-server/response_helpers.rb
 - lib/txgh-server/stream_response.rb
@@ -111,6 +112,15 @@ files:
 - lib/txgh-server/triggers/push_handler.rb
 - lib/txgh-server/version.rb
 - lib/txgh-server/webhooks.rb
+- lib/txgh-server/webhooks/git.rb
+- lib/txgh-server/webhooks/git/blank_attributes.rb
+- lib/txgh-server/webhooks/git/delete_attributes.rb
+- lib/txgh-server/webhooks/git/delete_handler.rb
+- lib/txgh-server/webhooks/git/ping_handler.rb
+- lib/txgh-server/webhooks/git/push_attributes.rb
+- lib/txgh-server/webhooks/git/push_handler.rb
+- lib/txgh-server/webhooks/git/request_handler.rb
+- lib/txgh-server/webhooks/git/status_updater.rb
 - lib/txgh-server/webhooks/github.rb
 - lib/txgh-server/webhooks/github/blank_attributes.rb
 - lib/txgh-server/webhooks/github/delete_attributes.rb
@@ -120,6 +130,14 @@ files:
 - lib/txgh-server/webhooks/github/push_handler.rb
 - lib/txgh-server/webhooks/github/request_handler.rb
 - lib/txgh-server/webhooks/github/status_updater.rb
+- lib/txgh-server/webhooks/gitlab.rb
+- lib/txgh-server/webhooks/gitlab/blank_attributes.rb
+- lib/txgh-server/webhooks/gitlab/delete_attributes.rb
+- lib/txgh-server/webhooks/gitlab/delete_handler.rb
+- lib/txgh-server/webhooks/gitlab/push_attributes.rb
+- lib/txgh-server/webhooks/gitlab/push_handler.rb
+- lib/txgh-server/webhooks/gitlab/request_handler.rb
+- lib/txgh-server/webhooks/gitlab/status_updater.rb
 - lib/txgh-server/webhooks/transifex.rb
 - lib/txgh-server/webhooks/transifex/hook_handler.rb
 - lib/txgh-server/webhooks/transifex/request_handler.rb
@@ -127,7 +145,9 @@ files:
 - spec/application_spec.rb
 - spec/download_handler_spec.rb
 - spec/github_request_auth_spec.rb
+- spec/gitlab_request_auth_spec.rb
 - spec/helpers/github_payload_builder.rb
+- spec/helpers/gitlab_payload_builder.rb
 - spec/helpers/integration_setup.rb
 - spec/helpers/test_request.rb
 - spec/integration/cassettes/pull.yml
@@ -136,7 +156,6 @@ files:
 - spec/integration/config/tx.config
 - spec/integration/hooks_spec.rb
 - spec/integration/payloads/github_postbody.json
-- spec/integration/payloads/github_postbody_l10n.json
 - spec/integration/payloads/github_postbody_release.json
 - spec/integration/triggers_spec.rb
 - spec/spec_helper.rb
@@ -149,6 +168,12 @@ files:
 - spec/webhooks/github/push_handler_spec.rb
 - spec/webhooks/github/request_handler_spec.rb
 - spec/webhooks/github/status_updater_spec.rb
+- spec/webhooks/gitlab/delete_attributes_spec.rb
+- spec/webhooks/gitlab/delete_handler_spec.rb
+- spec/webhooks/gitlab/push_attributes_spec.rb
+- spec/webhooks/gitlab/push_handler_spec.rb
+- spec/webhooks/gitlab/request_handler_spec.rb
+- spec/webhooks/gitlab/status_updater_spec.rb
 - spec/webhooks/transifex/hook_handler_spec.rb
 - spec/webhooks/transifex/request_handler_spec.rb
 - spec/zip_stream_response_spec.rb
@@ -167,12 +192,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.5
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: An HTTP server for interacting with txgh.

data/spec/integration/payloads/github_postbody_l10n.json

@@ -1,136 +0,0 @@
-{
-  "ref": "refs/tags/L10N",
-  "before": "0000000000000000000000000000000000000000",
-  "after": "6eebc3eee49e8d46f6dbec16fe3360961bfdd8ed",
-  "created": true,
-  "deleted": false,
-  "forced": true,
-  "base_ref": "refs/heads/master",
-  "compare": "https://github.com/txgh-bot/txgh-test-resources/compare/L10N",
-  "commits": [
-
-  ],
-  "head_commit": {
-    "id": "6eebc3eee49e8d46f6dbec16fe3360961bfdd8ed",
-    "distinct": true,
-    "message": "10",
-    "timestamp": "2015-11-19T12:56:33-08:00",
-    "url": "https://github.com/txgh-bot/txgh-test-resources/commit/6eebc3eee49e8d46f6dbec16fe3360961bfdd8ed",
-    "author": {
-      "name": "Txgh Bot",
-      "email": "txgh.bot@gmail.com",
-      "username": "txgh-bot"
-    },
-    "committer": {
-      "name": "Txgh Bot",
-      "email": "txgh.bot@gmail.com",
-      "username": "txgh-bot"
-    },
-    "added": [
-
-    ],
-    "removed": [
-
-    ],
-    "modified": [
-      "sample.po"
-    ]
-  },
-  "repository": {
-    "id": 41740726,
-    "name": "txgh-test-resources",
-    "full_name": "txgh-bot/txgh-test-resources",
-    "owner": {
-      "name": "txgh-bot",
-      "email": "txgh.bot@gmail.com"
-    },
-    "private": false,
-    "html_url": "https://github.com/txgh-bot/txgh-test-resources",
-    "description": "Translation test repo for txgh",
-    "fork": false,
-    "url": "https://github.com/txgh-bot/txgh-test-resources",
-    "forks_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/forks",
-    "keys_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/keys{/key_id}",
-    "collaborators_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/collaborators{/collaborator}",
-    "teams_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/teams",
-    "hooks_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/hooks",
-    "issue_events_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/issues/events{/number}",
-    "events_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/events",
-    "assignees_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/assignees{/user}",
-    "branches_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/branches{/branch}",
-    "tags_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/tags",
-    "blobs_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/git/blobs{/sha}",
-    "git_tags_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/git/tags{/sha}",
-    "git_refs_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/git/refs{/sha}",
-    "trees_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/git/trees{/sha}",
-    "statuses_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/statuses/{sha}",
-    "languages_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/languages",
-    "stargazers_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/stargazers",
-    "contributors_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/contributors",
-    "subscribers_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/subscribers",
-    "subscription_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/subscription",
-    "commits_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/commits{/sha}",
-    "git_commits_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/git/commits{/sha}",
-    "comments_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/comments{/number}",
-    "issue_comment_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/issues/comments{/number}",
-    "contents_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/contents/{+path}",
-    "compare_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/compare/{base}...{head}",
-    "merges_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/merges",
-    "archive_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/{archive_format}{/ref}",
-    "downloads_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/downloads",
-    "issues_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/issues{/number}",
-    "pulls_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/pulls{/number}",
-    "milestones_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/milestones{/number}",
-    "notifications_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/notifications{?since,all,participating}",
-    "labels_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/labels{/name}",
-    "releases_url": "https://api.github.com/repos/txgh-bot/txgh-test-resources/releases{/id}",
-    "created_at": 1441114620,
-    "updated_at": "2015-09-01T13:37:00Z",
-    "pushed_at": 1447966674,
-    "git_url": "git://github.com/txgh-bot/txgh-test-resources.git",
-    "ssh_url": "git@github.com:txgh-bot/txgh-test-resources.git",
-    "clone_url": "https://github.com/txgh-bot/txgh-test-resources.git",
-    "svn_url": "https://github.com/txgh-bot/txgh-test-resources",
-    "homepage": null,
-    "size": 12,
-    "stargazers_count": 0,
-    "watchers_count": 0,
-    "language": null,
-    "has_issues": true,
-    "has_downloads": true,
-    "has_wiki": true,
-    "has_pages": false,
-    "forks_count": 0,
-    "mirror_url": null,
-    "open_issues_count": 0,
-    "forks": 0,
-    "open_issues": 0,
-    "watchers": 0,
-    "default_branch": "master",
-    "stargazers": 0,
-    "master_branch": "master"
-  },
-  "pusher": {
-    "name": "txgh-bot",
-    "email": "txgh.bot@gmail.com"
-  },
-  "sender": {
-    "login": "txgh-bot",
-    "id": 974299,
-    "avatar_url": "https://avatars.githubusercontent.com/u/974299?v=3",
-    "gravatar_id": "",
-    "url": "https://api.github.com/users/txgh-bot",
-    "html_url": "https://github.com/txgh-bot",
-    "followers_url": "https://api.github.com/users/txgh-bot/followers",
-    "following_url": "https://api.github.com/users/txgh-bot/following{/other_user}",
-    "gists_url": "https://api.github.com/users/txgh-bot/gists{/gist_id}",
-    "starred_url": "https://api.github.com/users/txgh-bot/starred{/owner}{/repo}",
-    "subscriptions_url": "https://api.github.com/users/txgh-bot/subscriptions",
-    "organizations_url": "https://api.github.com/users/txgh-bot/orgs",
-    "repos_url": "https://api.github.com/users/txgh-bot/repos",
-    "events_url": "https://api.github.com/users/txgh-bot/events{/privacy}",
-    "received_events_url": "https://api.github.com/users/txgh-bot/received_events",
-    "type": "User",
-    "site_admin": false
-  }
-}