txgh-server 3.1.0 → 4.0.0.beta

data/lib/txgh-server/webhooks/github/status_updater.rb

@@ -3,15 +3,7 @@ require 'octokit'
 module TxghServer
   module Webhooks
     module Github
-      class StatusUpdater
-        attr_reader :project, :repo, :branch
-
-        def initialize(project, repo, branch)
-          @project = project
-          @repo = repo
-          @branch = branch
-        end
-
+      class StatusUpdater < TxghServer::Webhooks::Git::StatusUpdater
         def report_error_and_update_status(error)
           error_params = Txgh.events.publish_error!(error)
 

data/lib/txgh-server/webhooks/gitlab.rb

@@ -0,0 +1,14 @@
+module TxghServer
+  module Webhooks
+    module Gitlab
+      autoload :BlankAttributes,  'txgh-server/webhooks/gitlab/blank_attributes'
+      autoload :DeleteAttributes, 'txgh-server/webhooks/gitlab/delete_attributes'
+      autoload :DeleteHandler,    'txgh-server/webhooks/gitlab/delete_handler'
+      autoload :Handler,          'txgh-server/webhooks/gitlab/handler'
+      autoload :PushHandler,      'txgh-server/webhooks/gitlab/push_handler'
+      autoload :PushAttributes,   'txgh-server/webhooks/gitlab/push_attributes'
+      autoload :RequestHandler,   'txgh-server/webhooks/gitlab/request_handler'
+      autoload :StatusUpdater,    'txgh-server/webhooks/gitlab/status_updater'
+    end
+  end
+end

data/lib/txgh-server/webhooks/gitlab/blank_attributes.rb

@@ -0,0 +1,8 @@
+module TxghServer
+  module Webhooks
+    module Gitlab
+      class BlankAttributes < TxghServer::Webhooks::Git::BlankAttributes
+      end
+    end
+  end
+end

data/lib/txgh-server/webhooks/gitlab/delete_attributes.rb

@@ -0,0 +1,17 @@
+module TxghServer
+  module Webhooks
+    module Gitlab
+      class DeleteAttributes < TxghServer::Webhooks::Git::DeleteAttributes
+        class << self
+          def repo_name(payload)
+            payload.fetch('repository').fetch('name')
+          end
+
+          def ref_type(_payload)
+            'branch'
+          end
+        end
+      end
+    end
+  end
+end

data/lib/txgh-server/webhooks/gitlab/delete_handler.rb

@@ -0,0 +1,8 @@
+module TxghServer
+  module Webhooks
+    module Gitlab
+      class DeleteHandler < TxghServer::Webhooks::Git::DeleteHandler
+      end
+    end
+  end
+end

data/lib/txgh-server/webhooks/gitlab/push_attributes.rb

@@ -0,0 +1,29 @@
+module TxghServer
+  module Webhooks
+    module Gitlab
+      class PushAttributes < TxghServer::Webhooks::Git::PushAttributes
+        class << self
+          def repo_name(payload)
+            payload.fetch('repository').fetch('name')
+          end
+
+          def added_files(payload)
+            extract_files(payload, 'added')
+          end
+
+          def modified_files(payload)
+            extract_files(payload, 'modified')
+          end
+
+          def author(payload)
+            payload.fetch('user_name')
+          end
+
+          def extract_files(payload, state)
+            payload.fetch('commits').flat_map { |c| c[state] }.uniq
+          end
+        end
+      end
+    end
+  end
+end

data/lib/txgh-server/webhooks/gitlab/push_handler.rb

@@ -0,0 +1,13 @@
+module TxghServer
+  module Webhooks
+    module Gitlab
+      class PushHandler < TxghServer::Webhooks::Git::PushHandler
+        private
+
+        def status_updater
+          @status_updater = TxghServer::Webhooks::Gitlab::StatusUpdater.new(project, repo, branch)
+        end
+      end
+    end
+  end
+end

data/lib/txgh-server/webhooks/gitlab/request_handler.rb

@@ -0,0 +1,59 @@
+require 'json'
+
+module TxghServer
+  module Webhooks
+    module Gitlab
+      class RequestHandler < TxghServer::Webhooks::Git::RequestHandler
+        def handle_request
+          handle_safely do
+            if gitlab_event == 'Push Hook'
+              if delete_event?
+                DeleteHandler.new(project, repo, logger, attributes).execute
+              else
+                PushHandler.new(project, repo, logger, attributes).execute
+              end
+            else
+              respond_with_error(400, 'Unexpected event type')
+            end
+          end
+        end
+
+        private
+
+        def attributes
+          unless gitlab_event == 'Push Hook'
+            return BlankAttributes.from_webhook_payload(payload)
+          end
+
+          if delete_event?
+            return DeleteAttributes.from_webhook_payload(payload)
+          end
+
+          PushAttributes.from_webhook_payload(payload)
+        end
+
+        def gitlab_event
+          request.env['HTTP_X_GITLAB_EVENT']
+        end
+
+        def delete_event?
+          payload.fetch('after', {}) == '0000000000000000000000000000000000000000'
+        end
+
+        def git_repo_name
+          payload.fetch('project', {})['path_with_namespace']
+        end
+
+        def authentic_request?
+          if repo.webhook_protected?
+            GitlabRequestAuth.authentic_request?(
+              request, repo.webhook_secret
+            )
+          else
+            true
+          end
+        end
+      end
+    end
+  end
+end

data/lib/txgh-server/webhooks/gitlab/status_updater.rb

@@ -0,0 +1,37 @@
+require 'gitlab'
+
+module TxghServer
+  module Webhooks
+    module Gitlab
+      class StatusUpdater < TxghServer::Webhooks::Git::StatusUpdater
+        def report_error_and_update_status(error)
+          error_params = Txgh.events.publish_error!(error)
+
+          Txgh.events.publish_each('gitlab.status.error', error_params) do |status_params|
+            if status_params
+              update_status_safely do
+                Txgh::GitlabStatus.error(project, repo, branch, status_params)
+              end
+            end
+          end
+        end
+
+        def update_status
+          update_status_safely do
+            Txgh::GitlabStatus.update(project, repo, branch)
+          end
+        end
+
+        private
+
+        def update_status_safely
+          yield
+        rescue ::Gitlab::Error::Unprocessable, ::Gitlab::Error::BadRequest
+          # raised because we've tried to create too many statuses for the commit
+        rescue Txgh::TransifexNotFoundError
+          # raised if transifex resource can't be found
+        end
+      end
+    end
+  end
+end

data/lib/txgh-server/webhooks/transifex/request_handler.rb

@@ -29,7 +29,7 @@ module TxghServer
           handle_safely do
             handler = TxghServer::Webhooks::Transifex::HookHandler.new(
               project: config.transifex_project,
-              repo: config.github_repo,
+              repo: config.git_repo,
               resource_slug: payload[:resource],
               language: payload[:language],
               logger: logger

data/spec/application_spec.rb

@@ -94,7 +94,7 @@ describe TxghServer::WebhookEndpoints do
   end
 
   let(:config) do
-    Txgh::Config::ConfigPair.new(project_config, repo_config)
+    Txgh::Config::ConfigPair.new(project_config, github_config)
   end
 
   before(:each) do
@@ -103,7 +103,7 @@ describe TxghServer::WebhookEndpoints do
     )
 
     allow(Txgh::Config::KeyManager).to(
-      receive(:config_from_repo).with(repo_name).and_return(config)
+      receive(:config_from_repo).with(github_repo_name).and_return(config)
     )
   end
 
@@ -145,7 +145,7 @@ describe TxghServer::WebhookEndpoints do
       allow(TxghServer::Webhooks::Transifex::HookHandler).to(
         receive(:new) do |options|
           expect(options[:project].name).to eq(project_name)
-          expect(options[:repo].name).to eq(repo_name)
+          expect(options[:repo].name).to eq(github_repo_name)
           handler
         end
       )
@@ -186,7 +186,7 @@ describe TxghServer::WebhookEndpoints do
       header(
         TxghServer::GithubRequestAuth::GITHUB_HEADER,
         TxghServer::GithubRequestAuth.compute_signature(
-          body, config.github_repo.webhook_secret
+          body, config.git_repo.webhook_secret
         )
       )
     end
@@ -198,7 +198,7 @@ describe TxghServer::WebhookEndpoints do
         allow(TxghServer::Webhooks::Github::PushHandler).to(
           receive(:new) do |project, repo, logger, attributes|
             expect(project.name).to eq(project_name)
-            expect(repo.name).to eq(repo_name)
+            expect(repo.name).to eq(github_repo_name)
             handler
           end
         )
@@ -209,7 +209,7 @@ describe TxghServer::WebhookEndpoints do
           receive(:execute).and_return(respond_with(200, true))
         )
 
-        payload = GithubPayloadBuilder.push_payload(repo_name, ref)
+        payload = GithubPayloadBuilder.push_payload(github_repo_name, ref)
         payload.add_commit
 
         sign_with payload.to_json
@@ -220,7 +220,7 @@ describe TxghServer::WebhookEndpoints do
       end
 
       it 'returns unauthorized if not properly signed' do
-        payload = GithubPayloadBuilder.push_payload(repo_name, ref)
+        payload = GithubPayloadBuilder.push_payload(github_repo_name, ref)
 
         header 'X-GitHub-Event', 'push'
         post '/github', payload.to_json
@@ -229,7 +229,7 @@ describe TxghServer::WebhookEndpoints do
       end
 
       it 'returns invalid request if event unrecognized' do
-        payload = GithubPayloadBuilder.push_payload(repo_name, ref)
+        payload = GithubPayloadBuilder.push_payload(github_repo_name, ref)
 
         sign_with payload.to_json
         header 'X-GitHub-Event', 'foobar'
@@ -239,7 +239,7 @@ describe TxghServer::WebhookEndpoints do
       end
 
       it 'returns internal error on unexpected error' do
-        payload = GithubPayloadBuilder.push_payload(repo_name, ref)
+        payload = GithubPayloadBuilder.push_payload(github_repo_name, ref)
 
         expect(Txgh::Config::KeyManager).to(
           receive(:config_from_repo).and_raise(StandardError)
@@ -266,7 +266,7 @@ describe TxghServer::TriggerEndpoints do
   end
 
   let(:config) do
-    Txgh::Config::ConfigPair.new(project_config, repo_config)
+    Txgh::Config::ConfigPair.new(project_config, github_config)
   end
 
   before(:each) do
@@ -275,7 +275,7 @@ describe TxghServer::TriggerEndpoints do
     )
 
     allow(Txgh::Config::KeyManager).to(
-      receive(:config_from_repo).with(repo_name).and_return(config)
+      receive(:config_from_repo).with(github_repo_name).and_return(config)
     )
   end
 

data/spec/download_handler_spec.rb

@@ -2,12 +2,10 @@ require 'spec_helper'
 require 'helpers/standard_txgh_setup'
 require 'yaml'
 
-include TxghServer
-
-describe DownloadHandler do
+describe TxghServer::DownloadHandler do
   include StandardTxghSetup
 
-  let(:format) { DownloadHandler::DEFAULT_FORMAT }
+  let(:format) { described_class::DEFAULT_FORMAT }
 
   let(:params) do
     {
@@ -30,7 +28,7 @@ describe DownloadHandler do
     end
 
     it 'responds with a streaming zip and has the project name as the attachment' do
-      response = DownloadHandler.handle_request(request)
+      response = described_class.handle_request(request)
       expect(response).to be_streaming
       expect(response).to be_a(ZipStreamResponse)
       expect(response.attachment).to eq(project_name)
@@ -40,7 +38,7 @@ describe DownloadHandler do
       let(:format) { '.tgz' }
 
       it 'responds with a streaming tgz download' do
-        response = DownloadHandler.handle_request(request)
+        response = described_class.handle_request(request)
         expect(response).to be_streaming
         expect(response).to be_a(TgzStreamResponse)
       end
@@ -49,7 +47,7 @@ describe DownloadHandler do
     context 'when an error occurs' do
       before(:each) do
         expect(request).to receive(:params).and_raise(StandardError)
-        response = DownloadHandler.handle_request(request)
+        response = described_class.handle_request(request)
         expect(response).to_not be_streaming
         expect(response.status).to eq(500)
       end
@@ -58,7 +56,7 @@ describe DownloadHandler do
 
   context '#execute' do
     let(:handler) do
-      DownloadHandler.new(transifex_project, github_repo, params, logger)
+      described_class.new(transifex_project, github_repo, params, logger)
     end
 
     it 'responds with a streaming zip download' do

data/spec/github_request_auth_spec.rb

@@ -1,9 +1,7 @@
 require 'spec_helper'
 require 'rack'
 
-include TxghServer
-
-describe GithubRequestAuth do
+describe TxghServer::GithubRequestAuth do
   let(:secret) { 'abc123' }
   let(:params) { '{"param1":"value1","param2":"value2","param3":123}' }
   let(:valid_signature) { 'ea62c3f65c8e42f155d96a25b7ba6eb5d320630e' }
@@ -11,28 +9,28 @@ describe GithubRequestAuth do
   describe '.authentic_request?' do
     it 'returns true if the request is signed correctly' do
       request = Rack::Request.new(
-        GithubRequestAuth::RACK_HEADER => "sha1=#{valid_signature}",
+        described_class::RACK_HEADER => "sha1=#{valid_signature}",
         'rack.input' => StringIO.new(params)
       )
 
-      authentic = GithubRequestAuth.authentic_request?(request, secret)
+      authentic = described_class.authentic_request?(request, secret)
       expect(authentic).to eq(true)
     end
 
     it 'returns false if the request is not signed correctly' do
       request = Rack::Request.new(
-        GithubRequestAuth::RACK_HEADER => 'incorrect',
+        described_class::RACK_HEADER => 'incorrect',
         'rack.input' => StringIO.new(params)
       )
 
-      authentic = GithubRequestAuth.authentic_request?(request, secret)
+      authentic = described_class.authentic_request?(request, secret)
       expect(authentic).to eq(false)
     end
   end
 
   describe '.compute_signature' do
     it 'calculates the signature and formats it as an http header' do
-      value = GithubRequestAuth.compute_signature(params, secret)
+      value = described_class.compute_signature(params, secret)
       expect(value).to eq("sha1=#{valid_signature}")
     end
   end

data/spec/gitlab_request_auth_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+require 'rack'
+
+describe TxghServer::GitlabRequestAuth do
+  let(:secret) { 'abc123' }
+
+  describe '.authentic_request?' do
+    it 'returns true if the request is signed correctly' do
+      request = Rack::Request.new(
+        described_class::RACK_HEADER => secret
+      )
+
+      authentic = described_class.authentic_request?(request, secret)
+      expect(authentic).to eq(true)
+    end
+
+    it 'returns false if the request is not signed correctly' do
+      request = Rack::Request.new(
+        described_class::RACK_HEADER => 'incorrect'
+      )
+
+      authentic = described_class.authentic_request?(request, secret)
+      expect(authentic).to eq(false)
+    end
+  end
+end

data/spec/helpers/gitlab_payload_builder.rb

@@ -0,0 +1,132 @@
+require 'json'
+
+class GitlabPayloadBuilder
+  class << self
+    def push_payload(*args)
+      GitlabPushPayload.new(*args)
+    end
+
+    def delete_payload(*args)
+      GitlabDeletePayload.new(*args)
+    end
+  end
+end
+
+class GitlabPayload
+  def to_h
+    # convert symbolized keys to strings
+    JSON.parse(to_json)
+  end
+
+  def to_json
+    @result.to_json
+  end
+
+  def merge!(hash)
+    @result.merge!(hash)
+  end
+
+  private
+
+  def digits
+    @@digits ||= ('a'..'f').to_a + ('0'..'9').to_a
+  end
+
+  def generate_timestamp
+    Time.now.strftime('%Y-%m-%dT%H:%M:%S%:z')
+  end
+
+  def generate_sha
+    blank_commit_id.gsub(/0/) { digits.sample }
+  end
+
+  def blank_commit_id
+    '0' * 40
+  end
+end
+
+class GitlabDeletePayload < GitlabPayload
+  attr_reader :repo, :ref
+
+  def initialize(repo, ref)
+    @repo = repo
+    @ref = ref
+
+    @result = {
+      ref: "refs/#{ref}",
+      before: generate_sha,
+      after: blank_commit_id,
+      project: {
+        path_with_namespace: repo
+      },
+      repository: {
+        name: repo.split('/').last
+      }
+    }
+  end
+end
+
+class GitlabPushPayload < GitlabPayload
+  attr_reader :repo, :ref, :before, :after
+
+  DEFAULT_USER = {
+    name: 'Test User',
+    email: 'test@user.com',
+    username: 'testuser'
+  }
+
+  def initialize(repo, ref, before = nil, after = nil)
+    @repo = repo
+    @ref = ref
+    @before = before || blank_commit_id
+    @after = after || generate_sha
+
+    @result = {
+      ref: "refs/#{ref}",
+      before: @before,
+      after: @after,
+      commits: [],
+      user_name: DEFAULT_USER[:username],
+      project: {
+        path_with_namespace: repo
+      },
+      repository: {
+        name: repo.split('/').last
+      }
+    }
+  end
+
+  def add_commit(options = {})
+    id = if commits.empty? && !options.include?(:id)
+      after
+    else
+      options.fetch(:id) { generate_sha }
+    end
+
+    commit_data = {
+      id: id,
+      message: options.fetch(:message, 'Default commit message'),
+      timestamp: options.fetch(:timestamp) { generate_timestamp },
+      url: "https://gitlab.com/#{repo}/-/commit/#{id}",
+      author: options.fetch(:author, DEFAULT_USER),
+      committer: options.fetch(:committer, DEFAULT_USER),
+      added: options.fetch(:added, []),
+      removed: options.fetch(:removed, []),
+      modified: options.fetch(:modified, [])
+    }
+
+    if commit_data[:id] == after
+      @result[:head_commit] = commit_data
+    end
+
+    commits << commit_data
+  end
+
+  def commits
+    @result[:commits]
+  end
+
+  def head_commit
+    @result[:head_commit]
+  end
+end