txgh-server 3.1.0 → 4.0.0.beta

data/spec/integration/hooks_spec.rb

@@ -96,7 +96,7 @@ describe 'hook integration tests', integration: true do
     header(
       GithubRequestAuth::GITHUB_HEADER,
       GithubRequestAuth.compute_signature(
-        body, config.github_repo.webhook_secret
+        body, config.git_repo.webhook_secret
       )
     )
   end

data/spec/tgz_stream_response_spec.rb

@@ -3,9 +3,7 @@ require 'spec_helper'
 require 'stringio'
 require 'zlib'
 
-include TxghServer
-
-describe TgzStreamResponse do
+describe TxghServer::TgzStreamResponse do
   def read_tgz_from(io)
     contents = {}
 
@@ -29,7 +27,7 @@ describe TgzStreamResponse do
   end
 
   let(:response) do
-    TgzStreamResponse.new(attachment, enum)
+    described_class.new(attachment, enum)
   end
 
   describe '#write_to' do

data/spec/transifex_request_auth_spec.rb

@@ -1,9 +1,7 @@
 require 'spec_helper'
 require 'rack'
 
-include TxghServer
-
-describe TransifexRequestAuth do
+describe TxghServer::TransifexRequestAuth do
   let(:secret) { 'abc123' }
   let(:params) { { param1: 'value1', param2: 'value2', param3: 123 }.to_json }
   let(:date_str) { Time.now.strftime('%a, %d %b %Y %H:%M:%S GMT') }
@@ -19,31 +17,31 @@ describe TransifexRequestAuth do
   describe '.authentic_request?' do
     it 'returns true if the request is signed correctly' do
       request = Rack::Request.new(
-        TransifexRequestAuth::RACK_HEADER => valid_signature,
+        described_class::RACK_HEADER => valid_signature,
         'HTTP_DATE' => date_str,
         'REQUEST_METHOD' => http_verb,
         'HTTP_X_TX_URL' => url,
         'rack.input' => StringIO.new(params)
       )
 
-      authentic = TransifexRequestAuth.authentic_request?(request, secret)
+      authentic = described_class.authentic_request?(request, secret)
       expect(authentic).to eq(true)
     end
 
     it 'returns false if the request is not signed correctly' do
       request = Rack::Request.new(
-        TransifexRequestAuth::RACK_HEADER => 'incorrect',
+        described_class::RACK_HEADER => 'incorrect',
         'rack.input' => StringIO.new(params)
       )
 
-      authentic = TransifexRequestAuth.authentic_request?(request, secret)
+      authentic = described_class.authentic_request?(request, secret)
       expect(authentic).to eq(false)
     end
   end
 
   describe '.compute_signature' do
     it 'calculates the signature and formats it as an http header' do
-      value = TransifexRequestAuth.compute_signature(
+      value = described_class.compute_signature(
         http_verb: http_verb,
         date_str: date_str,
         url: url,

data/spec/webhooks/github/delete_attributes_spec.rb

@@ -1,10 +1,7 @@
 require 'spec_helper'
 require 'helpers/github_payload_builder'
 
-include TxghServer
-include TxghServer::Webhooks::Github
-
-describe DeleteAttributes do
+describe TxghServer::Webhooks::Github::DeleteAttributes do
   let(:repo_name) { 'my_repo' }
   let(:ref) { 'heads/my_ref' }
 
@@ -13,7 +10,7 @@ describe DeleteAttributes do
   end
 
   describe '#from_webhook_payload' do
-    let(:attributes) { DeleteAttributes.from_webhook_payload(payload.to_h) }
+    let(:attributes) { TxghServer::Webhooks::Github::DeleteAttributes.from_webhook_payload(payload.to_h) }
 
     it 'pulls out repo name' do
       expect(attributes.repo_name).to eq(repo_name)

data/spec/webhooks/github/delete_handler_spec.rb

@@ -2,22 +2,19 @@ require 'spec_helper'
 require 'helpers/github_payload_builder'
 require 'helpers/standard_txgh_setup'
 
-include TxghServer
-include TxghServer::Webhooks::Github
-
-describe DeleteHandler do
+describe TxghServer::Webhooks::Github::DeleteHandler do
   include StandardTxghSetup
 
   let(:handler) do
-    DeleteHandler.new(transifex_project, github_repo, logger, attributes)
+    TxghServer::Webhooks::Github::DeleteHandler.new(transifex_project, github_repo, logger, attributes)
   end
 
   let(:attributes) do
-    DeleteAttributes.from_webhook_payload(payload.to_h)
+    TxghServer::Webhooks::Github::DeleteAttributes.from_webhook_payload(payload.to_h)
   end
 
   let(:payload) do
-    GithubPayloadBuilder.delete_payload(repo_name, ref)
+    GithubPayloadBuilder.delete_payload(github_repo_name, ref)
   end
 
   it 'deletes resources' do

data/spec/webhooks/github/ping_handler_spec.rb

@@ -1,12 +1,9 @@
 require 'spec_helper'
 require 'helpers/nil_logger'
 
-include TxghServer
-include TxghServer::Webhooks::Github
-
-describe PingHandler do
+describe TxghServer::Webhooks::Github::PingHandler do
   let(:handler) do
-    PingHandler.new(NilLogger.new)
+    TxghServer::Webhooks::Github::PingHandler.new(NilLogger.new)
   end
 
   it 'responds with a 200 success' do

data/spec/webhooks/github/push_attributes_spec.rb

@@ -1,10 +1,7 @@
 require 'spec_helper'
 require 'helpers/github_payload_builder'
 
-include TxghServer
-include TxghServer::Webhooks::Github
-
-describe PushAttributes do
+describe TxghServer::Webhooks::Github::PushAttributes do
   let(:repo_name) { 'my_repo' }
   let(:ref) { 'heads/my_ref' }
   let(:added) { ['added_file.txt'] }
@@ -15,7 +12,7 @@ describe PushAttributes do
   end
 
   describe '#from_webhook_payload' do
-    let(:attributes) { PushAttributes.from_webhook_payload(payload.to_h) }
+    let(:attributes) { TxghServer::Webhooks::Github::PushAttributes.from_webhook_payload(payload.to_h) }
 
     it "when no head commit, uses the pusher's name instead" do
       payload.merge!(pusher: { name: 'Fu Barro', email: 'fu@barro.com' })
@@ -29,7 +26,7 @@ describe PushAttributes do
     end
 
     describe '#from_webhook_payload' do
-      let(:attributes) { PushAttributes.from_webhook_payload(payload.to_h) }
+      let(:attributes) { TxghServer::Webhooks::Github::PushAttributes.from_webhook_payload(payload.to_h) }
 
       it 'pulls out repo name' do
         expect(attributes.repo_name).to eq(repo_name)

data/spec/webhooks/github/push_handler_spec.rb

@@ -2,22 +2,19 @@ require 'spec_helper'
 require 'helpers/github_payload_builder'
 require 'helpers/standard_txgh_setup'
 
-include TxghServer
-include TxghServer::Webhooks::Github
-
-describe PushHandler do
+describe TxghServer::Webhooks::Github::PushHandler do
   include StandardTxghSetup
 
   let(:handler) do
-    PushHandler.new(transifex_project, github_repo, logger, attributes)
+    TxghServer::Webhooks::Github::PushHandler.new(transifex_project, github_repo, logger, attributes)
   end
 
   let(:attributes) do
-    PushAttributes.from_webhook_payload(payload.to_h)
+    TxghServer::Webhooks::Github::PushAttributes.from_webhook_payload(payload.to_h)
   end
 
   let(:payload) do
-    GithubPayloadBuilder.push_payload(repo_name, ref)
+    GithubPayloadBuilder.push_payload(github_repo_name, ref)
   end
 
   let(:modified_files) do
@@ -87,7 +84,7 @@ describe PushHandler do
     let(:after) { '0' * 40 }
 
     let(:payload) do
-      GithubPayloadBuilder.push_payload(repo_name, ref, before, after)
+      GithubPayloadBuilder.push_payload(github_repo_name, ref, before, after)
     end
 
     it "doesn't upload anything" do

data/spec/webhooks/github/request_handler_spec.rb

@@ -4,9 +4,7 @@ require 'helpers/nil_logger'
 require 'helpers/standard_txgh_setup'
 require 'helpers/test_request'
 
-include TxghServer::Webhooks
-
-describe Github::RequestHandler do
+describe TxghServer::Webhooks::Github::RequestHandler do
   include StandardTxghSetup
 
   let(:logger) { NilLogger.new }
@@ -19,10 +17,10 @@ describe Github::RequestHandler do
   describe '#handle_request' do
     context 'push event' do
       let(:event) { 'push' }
-      let(:payload) { GithubPayloadBuilder.push_payload(repo_name, ref).tap { |p| p.add_commit } }
+      let(:payload) { GithubPayloadBuilder.push_payload(github_repo_name, ref).tap { |p| p.add_commit } }
 
       it 'does not execute if unauthorized' do
-        expect_any_instance_of(Github::PushHandler).to_not receive(:execute)
+        expect_any_instance_of(TxghServer::Webhooks::Github::PushHandler).to_not receive(:execute)
         response = handler.handle_request
         expect(response.status).to eq(401)
       end
@@ -33,7 +31,7 @@ describe Github::RequestHandler do
         end
 
         it 'handles the request with the push handler' do
-          expect_any_instance_of(Github::PushHandler).to receive(:execute).and_return(:response)
+          expect_any_instance_of(TxghServer::Webhooks::Github::PushHandler).to receive(:execute).and_return(:response)
           expect(handler.handle_request).to eq(:response)
         end
       end
@@ -41,10 +39,10 @@ describe Github::RequestHandler do
 
     context 'delete event' do
       let(:event) { 'delete' }
-      let(:payload) { GithubPayloadBuilder.delete_payload(repo_name, ref) }
+      let(:payload) { GithubPayloadBuilder.delete_payload(github_repo_name, ref) }
 
       it 'does not execute if unauthorized' do
-        expect_any_instance_of(Github::DeleteHandler).to_not receive(:execute)
+        expect_any_instance_of(TxghServer::Webhooks::Github::DeleteHandler).to_not receive(:execute)
         response = handler.handle_request
         expect(response.status).to eq(401)
       end
@@ -55,7 +53,7 @@ describe Github::RequestHandler do
         end
 
         it 'handles the request with the delete handler' do
-          expect_any_instance_of(Github::DeleteHandler).to receive(:execute).and_return(:response)
+          expect_any_instance_of(TxghServer::Webhooks::Github::DeleteHandler).to receive(:execute).and_return(:response)
           expect(handler.handle_request).to eq(:response)
         end
       end
@@ -63,7 +61,7 @@ describe Github::RequestHandler do
 
     context 'unrecognized event' do
       let(:event) { 'foo' }
-      let(:payload) { { repository: { full_name: repo_name } } }
+      let(:payload) { { repository: { full_name: github_repo_name } } }
 
       it 'responds with a 400' do
         allow(handler).to receive(:authentic_request?).and_return(true)

data/spec/webhooks/github/status_updater_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
 require 'helpers/standard_txgh_setup'
 
-include TxghServer::Webhooks::Github
-
-describe StatusUpdater do
+describe TxghServer::Webhooks::Github::StatusUpdater do
   include StandardTxghSetup
 
-  let(:updater) { StatusUpdater.new(transifex_project, github_repo, ref) }
+  let(:updater) { TxghServer::Webhooks::Github::StatusUpdater.new(transifex_project, github_repo, ref) }
 
   describe '#report_error_and_update_status' do
     let(:description) { 'An error done occurred, fool' }

data/spec/webhooks/gitlab/delete_attributes_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+require 'helpers/gitlab_payload_builder'
+
+describe TxghServer::Webhooks::Gitlab::DeleteAttributes do
+  let(:repo_name) { 'my_repo' }
+  let(:ref) { 'heads/my_ref' }
+
+  let(:payload) do
+    GitlabPayloadBuilder.delete_payload(repo_name, ref)
+  end
+
+  describe '#from_webhook_payload' do
+    let(:attributes) { TxghServer::Webhooks::Gitlab::DeleteAttributes.from_webhook_payload(payload.to_h) }
+
+    it 'pulls out repo name' do
+      expect(attributes.repo_name).to eq(repo_name)
+    end
+
+    it 'pulls out ref' do
+      expect(attributes.ref).to eq("refs/#{ref}")
+    end
+
+    it 'pulls out ref type' do
+      expect(attributes.ref_type).to eq('branch')
+    end
+  end
+end

data/spec/webhooks/gitlab/delete_handler_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+require 'helpers/gitlab_payload_builder'
+require 'helpers/standard_txgh_setup'
+
+describe TxghServer::Webhooks::Gitlab::DeleteHandler do
+  include StandardTxghSetup
+
+  let(:handler) do
+    TxghServer::Webhooks::Gitlab::DeleteHandler.new(transifex_project, gitlab_repo, logger, attributes)
+  end
+
+  let(:attributes) do
+    TxghServer::Webhooks::Gitlab::DeleteAttributes.from_webhook_payload(payload.to_h)
+  end
+
+  let(:payload) do
+    GitlabPayloadBuilder.delete_payload(gitlab_repo_name, ref)
+  end
+
+  it 'deletes resources' do
+    expect_any_instance_of(Txgh::ResourceDeleter).to receive(:delete_resources)
+    response = handler.execute
+    expect(response.status).to eq(200)
+    expect(response.body).to eq(true)
+  end
+
+  it 'does not delete resources if auto resource deletions are disabled' do
+    project_config['auto_delete_resources'] = 'false'
+    expect(transifex_api).to_not receive(:delete)
+    response = handler.execute
+    expect(response.status).to eq(200)
+    expect(response.body).to eq(true)
+  end
+end

data/spec/webhooks/gitlab/push_attributes_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+require 'helpers/gitlab_payload_builder'
+
+describe TxghServer::Webhooks::Gitlab::PushAttributes do
+  let(:repo_name) { 'my_repo' }
+  let(:ref) { 'heads/my_ref' }
+  let(:added) { ['added_file.txt'] }
+  let(:modified) { ['modified_file.txt'] }
+
+  let(:payload) do
+    GitlabPayloadBuilder.push_payload(repo_name, ref)
+  end
+
+  describe '#from_webhook_payload' do
+    let(:attributes) { TxghServer::Webhooks::Gitlab::PushAttributes.from_webhook_payload(payload.to_h) }
+
+    it "when no head commit, uses the pusher's name instead" do
+      payload.merge!(user_name: 'Fu Barro')
+      expect(attributes.author).to eq('Fu Barro')
+    end
+  end
+
+  context 'with a commit added to the payload' do
+    before(:each) do
+      payload.add_commit(added: added, modified: modified)
+    end
+
+    describe '#from_webhook_payload' do
+      let(:attributes) { TxghServer::Webhooks::Gitlab::PushAttributes.from_webhook_payload(payload.to_h) }
+
+      it 'pulls out repo name' do
+        expect(attributes.repo_name).to eq(repo_name)
+      end
+
+      it 'pulls out ref' do
+        expect(attributes.ref).to eq("refs/#{ref}")
+      end
+
+      it 'pulls out before sha' do
+        expect(attributes.before).to eq(payload.to_h['before'])
+      end
+
+      it 'pulls out after sha' do
+        expect(attributes.after).to eq(payload.to_h['after'])
+      end
+
+      it 'pulls out added files' do
+        expect(attributes.added_files.to_a).to eq(added)
+      end
+
+      it 'pulls out modified files' do
+        expect(attributes.modified_files.to_a).to eq(modified)
+      end
+
+      it 'combines all files into one handy array' do
+        expect(attributes.files.sort).to eq((added + modified).sort)
+      end
+
+      it 'pulls out the author' do
+        expect(attributes.author).to eq('testuser')
+      end
+    end
+  end
+end

data/spec/webhooks/gitlab/push_handler_spec.rb

@@ -0,0 +1,99 @@
+require 'spec_helper'
+require 'helpers/gitlab_payload_builder'
+require 'helpers/standard_txgh_setup'
+
+describe TxghServer::Webhooks::Gitlab::PushHandler do
+  include StandardTxghSetup
+
+  let(:handler) do
+    TxghServer::Webhooks::Gitlab::PushHandler.new(transifex_project, gitlab_repo, logger, attributes)
+  end
+
+  let(:attributes) do
+    TxghServer::Webhooks::Gitlab::PushAttributes.from_webhook_payload(payload.to_h)
+  end
+
+  let(:payload) do
+    GitlabPayloadBuilder.push_payload(gitlab_repo_name, ref)
+  end
+
+  let(:modified_files) do
+    file_sha = 'def456'
+    tx_config.resources.map do |resource|
+      { path: resource.source_file, sha: file_sha.next! }
+    end
+  end
+
+  let(:updater) { double(:updater) }
+
+  before(:each) do
+    payload.add_commit(
+      modified: modified_files.map { |f| f[:path] }
+    )
+
+    allow(Txgh::ResourceUpdater).to receive(:new).and_return(updater)
+  end
+
+  it 'correctly uploads modified resources to transifex' do
+    tx_config.resources.each do |resource|
+      expect(updater).to(
+        receive(:update_resource) do |resource, categories|
+          expect(resource.project_slug).to eq(project_name)
+          expect(resource.resource_slug).to eq(resource_slug)
+          expect(categories).to eq('author' => 'testuser')
+        end
+      )
+    end
+
+    expect(Txgh::GitlabStatus).to(
+      receive(:update).with(transifex_project, gitlab_repo, ref)
+    )
+
+    response = handler.execute
+    expect(response.status).to eq(200)
+    expect(response.body).to eq(true)
+  end
+
+  context 'with an error' do
+    let(:description) { 'An error done occurred, fool' }
+    let(:target_url) { 'http://you-goofed.com' }
+
+    let(:status_params) do
+      { description: description, target_url: target_url }
+    end
+
+    let(:error_params) { { foo: 'bar' } }
+
+    before(:each) do
+      Txgh.events.subscribe(Txgh::Events::ERROR_CHANNEL) { error_params }
+      Txgh.events.subscribe('gitlab.status.error') { status_params }
+    end
+
+    it 'reports errors and updates the gitlab status' do
+      expect(Txgh::GitlabStatus).to(
+        receive(:error).with(transifex_project, gitlab_repo, ref, status_params)
+      )
+
+      expect(handler).to receive(:should_process?).and_raise(StandardError)
+      handler.execute
+    end
+  end
+
+  context 'with a deleted branch' do
+    let(:before) { nil }
+    let(:after) { '0' * 40 }
+
+    let(:payload) do
+      GitlabPayloadBuilder.push_payload(gitlab_repo_name, ref, before, after)
+    end
+
+    it "doesn't upload anything" do
+      expect(updater).to_not receive(:update_resource)
+      expect(gitlab_api).to_not receive(:create_ref)
+
+      response = handler.execute
+      expect(response.status).to eq(200)
+      expect(response.body).to eq(true)
+    end
+  end
+end