toyrobot 0.0.1 → 0.0.2

data/test/{test_command_matcher_place.rb → test_command_parser_place.rb}

@@ -1,14 +1,14 @@
 require_relative '../lib/toy_robot/command/parser/place'
-require_relative 'test_command_matcher_interface'
+require_relative 'test_command_parser_interface'
 require 'minitest/autorun'
 
 module ToyRobot
-  class CommandMatcherPlaceTest < MiniTest::Unit::TestCase
-    include CommandMatcherInterfaceTest
+  class CommandParserPlaceTest < MiniTest::Unit::TestCase
+    include CommandParserInterfaceTest
 
     def setup
       @object = Command::Parser::Place
-      @object_token = Command::Token::PLACE
+      @object_msg = :place
       @object_valid_str = 'PLACE 0,0,NORTH'
       @object_invalid_strs = [
         'PLACE',
@@ -25,32 +25,32 @@ module ToyRobot
 
     def test_that_response_args_know_x
       assert_equal 123,
-                   @object.build_with_match('PLACE 123,0,NORTH').args.x
+                   @object.build_with_match('PLACE 123,0,NORTH').args[:x]
     end
 
     def test_that_response_args_know_y
       assert_equal 123,
-                   @object.build_with_match('PLACE 0,123,NORTH').args.y
+                   @object.build_with_match('PLACE 0,123,NORTH').args[:y]
     end
 
     def test_that_response_args_knows_north_orientation
       assert_equal Pose::Orientation::NORTH,
-                   @object.build_with_match('PLACE 0,123,NORTH').args.orientation
+                   @object.build_with_match('PLACE 0,123,NORTH').args[:orientation]
     end
 
     def test_that_response_args_knows_south_orientation
       assert_equal Pose::Orientation::SOUTH,
-                   @object.build_with_match('PLACE 0,123,SOUTH').args.orientation
+                   @object.build_with_match('PLACE 0,123,SOUTH').args[:orientation]
     end
 
     def test_that_response_args_knows_east_orientation
       assert_equal Pose::Orientation::EAST,
-                   @object.build_with_match('PLACE 0,123,EAST').args.orientation
+                   @object.build_with_match('PLACE 0,123,EAST').args[:orientation]
     end
 
     def test_that_response_args_knows_west_orientation
       assert_equal Pose::Orientation::WEST,
-                   @object.build_with_match('PLACE 0,123,WEST').args.orientation
+                   @object.build_with_match('PLACE 0,123,WEST').args[:orientation]
     end
   end
 end

data/test/{test_command_matcher_report.rb → test_command_parser_report.rb}

@@ -1,14 +1,14 @@
-require_relative '../lib/toy_robot/command/parser/base'
-require_relative 'test_command_matcher_interface'
+require_relative '../lib/toy_robot/command/parser/report'
+require_relative 'test_command_parser_interface'
 require 'minitest/autorun'
 
 module ToyRobot
-  class CommandMatcherReportTest < MiniTest::Unit::TestCase
-    include CommandMatcherInterfaceTest
+  class CommandParserReportTest < MiniTest::Unit::TestCase
+    include CommandParserInterfaceTest
 
     def setup
       @object = Command::Parser::Report
-      @object_token = Command::Token::REPORT
+      @object_msg = :report
       @object_valid_str = 'REPORT'
       @object_invalid_strs = [
         'REPORT ',

data/test/test_command_parser_right.rb

@@ -0,0 +1,20 @@
+require_relative '../lib/toy_robot/command/parser/right'
+require_relative 'test_command_parser_interface'
+require 'minitest/autorun'
+
+module ToyRobot
+  class CommandParserRightTest < MiniTest::Unit::TestCase
+    include CommandParserInterfaceTest
+
+    def setup
+      @object = Command::Parser::Right
+      @object_msg = :right
+      @object_valid_str = 'RIGHT'
+      @object_invalid_strs = [
+        'RIGHT ',
+        'RIGHTY',
+        'RIGHT 180'
+      ]
+    end
+  end
+end

data/test/test_controller.rb

@@ -0,0 +1,64 @@
+require_relative '../lib/toy_robot/controller'
+require 'minitest/autorun'
+
+module ToyRobot
+  class ControllerTest < MiniTest::Unit::TestCase
+    def setup
+      @robot = MiniTest::Mock.new
+      @view = MiniTest::Mock.new
+      @controller = Controller.new(
+        robot: @robot,
+        view: @view
+      )
+    end
+
+    def test_respond_to_public_interface
+      assert_respond_to @controller, :place
+      assert_respond_to @controller, :move
+      assert_respond_to @controller, :right
+      assert_respond_to @controller, :left
+      assert_respond_to @controller, :report
+    end
+
+    def test_it_delegates_a_place_command_to_robot
+      args = Object.new
+      @robot.expect(:place, nil, [args])
+
+      @controller.place(args)
+
+      @robot.verify
+    end
+
+    def test_it_delegates_a_move_command_to_robot
+      @robot.expect(:move, nil)
+
+      @controller.move(nil)
+
+      @robot.verify
+    end
+
+    def test_it_delegates_a_left_command_to_robot
+      @robot.expect(:left, nil)
+
+      @controller.left(nil)
+
+      @robot.verify
+    end
+
+    def test_it_delegates_a_right_command_to_robot
+      @robot.expect(:right, nil)
+
+      @controller.right(nil)
+
+      @robot.verify
+    end
+
+    def test_it_delegates_a_report_command_to_view
+      @view.expect(:report, nil)
+
+      @controller.report(nil)
+
+      @view.verify
+    end
+  end
+end

data/test/test_pose.rb

@@ -1,9 +1,12 @@
 require_relative '../lib/toy_robot/pose'
+require_relative 'test_pose_interface'
 require_relative 'test_reporter_interface'
+
 require 'minitest/autorun'
 
 module ToyRobot
   class PoseTest < MiniTest::Unit::TestCase
+    include PoseInterfaceTest
     include ReporterInterfaceTest
 
     def setup
@@ -16,25 +19,18 @@ module ToyRobot
       )
     end
 
-    def test_public_interface
-      assert_respond_to @pose, :adjacent
-      assert_respond_to @pose, :rotate!
-      assert_respond_to @pose, :report
-      assert_respond_to @pose, :x
-      assert_respond_to @pose, :y
-      assert_respond_to @pose, :orientation
-    end
-
     def test_it_can_be_initialized_without_arguments
       assert Pose.new
     end
 
-    def test_that_adjacent_returns_a_pose
-      assert_instance_of Pose, @pose.adjacent
-    end
+    def test_that_it_can_mutate
+      mutated_pose_attrs = {
+        x: 5,
+        y: 5,
+        orientation: 'random'
+      }
 
-    def test_that_adjacent_pose_is_not_the_reciever
-      refute_equal @pose, @pose.adjacent
+      assert_pose mutated_pose_attrs, @pose.mutate!(mutated_pose_attrs)
     end
 
     def test_that_knows_adjacent_when_facing_east
@@ -125,16 +121,16 @@ module ToyRobot
       end
     end
 
-    def test_that_it_reports_x
-      assert_includes @pose.report, :x
+    def test_that_hash_like_access_to_x_returns_instance_variable_x
+      assert_equal @pose.instance_variable_get(:@x), @pose[:x]
     end
 
-    def test_that_it_reports_y
-      assert_includes @pose.report, :y
+    def test_that_hash_like_access_to_y_returns_instance_variable_y
+      assert_equal @pose.instance_variable_get(:@y), @pose[:y]
     end
 
-    def test_that_it_reports_orientation
-      assert_includes @pose.report, :orientation
+    def test_that_hash_like_access_to_orientation_returns_instance_variable_orientation
+      assert_equal @pose.instance_variable_get(:@orientation), @pose[:orientation]
     end
 
     def assert_pose(expected_pose_hash, actual)

data/test/test_pose_double.rb

@@ -0,0 +1,15 @@
+require_relative 'pose_double'
+require_relative 'test_pose_interface'
+require_relative 'test_reporter_interface'
+require 'minitest/autorun'
+
+module ToyRobot
+  class PoseDoubleTest < MiniTest::Unit::TestCase
+    include PoseInterfaceTest
+    include ReporterInterfaceTest
+
+    def setup
+      @object = PoseDouble.new
+    end
+  end
+end

data/test/test_pose_interface.rb

@@ -0,0 +1,26 @@
+module ToyRobot
+  module PoseInterfaceTest
+    def test_pose_public_interface
+      assert_respond_to @object, :mutate!
+      assert_respond_to @object, :adjacent
+      assert_respond_to @object, :rotate!
+      assert_respond_to @object, :[]
+    end
+
+    def test_that_mutate_returns_the_receiver
+      assert_equal @object, @object.mutate!
+    end
+
+    def test_that_adjacent_returns_a_pose_object
+      assert_instance_of @object.class, @object.adjacent
+    end
+
+    def test_that_adjacent_does_not_return_the_receiver
+      refute_equal @object, @object.adjacent
+    end
+
+    def test_that_rotate_returns_the_receiver
+      assert_equal @object, @object.rotate!(1337)
+    end
+  end
+end

data/test/test_reporter_interface.rb

@@ -1,7 +1,19 @@
 module ToyRobot
   module ReporterInterfaceTest
-    def test_it_implement_the_reproter_interface
+    def test_it_implements_the_reproter_interface
       assert_respond_to @object, :report
     end
+
+    def test_that_it_reports_x
+      assert_includes @object.report, :x
+    end
+
+    def test_that_it_reports_y
+      assert_includes @object.report, :y
+    end
+
+    def test_that_it_reports_orientation
+      assert_includes @object.report, :orientation
+    end
   end
 end

data/test/test_robot.rb

@@ -1,5 +1,7 @@
 require_relative '../lib/toy_robot/robot'
 require_relative 'test_reporter_interface'
+require_relative 'board_double'
+require_relative 'pose_double'
 require 'minitest/autorun'
 
 module ToyRobot
@@ -7,64 +9,105 @@ module ToyRobot
     include ReporterInterfaceTest
 
     def setup
-      @observer = MiniTest::Mock.new.expect(:on_board?, true)
-      @robot = @object = Robot.new(placement: @observer)
+      @board = BoardDouble.new
+      @pose = PoseDouble.new
+      @robot = @object = Robot.new(board: @board, pose: @pose)
+      @mock = MiniTest::Mock.new
     end
 
     def teardown
-      @observer = nil
-      @robot = nil
+      @board, @pose, @robot, @mock = nil, nil, nil, nil
     end
 
-    def test_respond_to_public_interface
+    def test_that_it_implements_robot_public_interface
       assert_respond_to @robot, :place
       assert_respond_to @robot, :move
       assert_respond_to @robot, :right
       assert_respond_to @robot, :left
     end
 
+    def test_that_place_returns_nil
+      assert_nil @robot.place(nil)
+    end
+
+    def test_that_move_returns_nil
+      assert_nil @robot.move
+    end
+
+    def test_that_right_returns_nil
+      assert_nil @robot.right
+    end
+
+    def test_that_left_returns_nil
+      assert_nil @robot.left
+    end
+
     def test_that_it_places
-      placement = MiniTest::Mock.new.expect(:update, nil, [nil])
-      @robot.instance_variable_set(:@placement, placement)
+      @board.stub :valid_pose?, true do
+        @robot.instance_variable_set(:@pose, @mock)
+        @mock.expect(:mutate!, nil, ['a valid pose'])
+
+        @robot.place('a valid pose')
 
-      @robot.place(nil)
-      placement.verify
+        @mock.verify
+      end
     end
 
-    def test_that_it_moves
-      @observer.expect(:advance, nil)
-      @robot.move
-      @observer.verify
+    def test_that_it_does_not_place_if_pose_is_invalid
+      @board.stub :valid_pose?, false do
+        @robot.instance_variable_set(:@pose, @mock)
+
+        @robot.place('a invalid pose')
+
+        @mock.verify
+      end
+    end
+
+    def test_that_it_moves_one_step_at_a_time
+      @board.stub :valid_pose?, true do
+        @robot.instance_variable_set(:@pose, @mock)
+        @mock.expect(:adjacent, 'a adjacent pose')
+        @mock.expect(:mutate!, nil, ['a adjacent pose'])
+
+        @robot.move
+
+        @mock.verify
+      end
+    end
+
+    def test_that_it_does_not_move_if_next_to_border
+      @board.stub :valid_pose?, false do
+        @robot.instance_variable_set(:@pose, @mock)
+
+        @robot.move
+
+        @mock.verify
+      end
     end
 
     def test_that_it_turns_right
-      @observer.expect(:rotate, nil, [90])
+      @robot.instance_variable_set(:@pose, @mock)
+      @mock.expect(:rotate!, nil, [90])
       @robot.right
-      @observer.verify
+      @mock.verify
     end
 
     def test_that_it_turns_left
-      @observer.expect(:rotate, nil, [-90])
+      @robot.instance_variable_set(:@pose, @mock)
+      @mock.expect(:rotate!, nil, [-90])
       @robot.left
-      @observer.verify
-    end
-
-    def test_that_it_reports
-      @observer.expect(:report, nil)
-      @robot.report
-      @observer.verify
+      @mock.verify
     end
 
     def test_that_it_ignores_commands_if_unplaced
-      observer = MiniTest::Mock.new
-      @robot.instance_variable_set(:@placement, observer)
+      @robot.instance_variable_set(:@board, nil)
+      @robot.instance_variable_set(:@pose, @mock)
 
       [:move, :right, :left, :report].each do |command|
-        observer.expect(:on_board?, false)
         @robot.send(command)
       end
 
-      observer.verify
+      @mock.verify
     end
   end
 end

data/toyrobot.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'toyrobot'
-  spec.version       = '0.0.1'
+  spec.version       = '0.0.2'
   spec.authors       = ['Matias Anaya']
   spec.email         = ['matiasanaya@gmail.com']
   spec.summary       = %q{A toy robot simulator}