surveyor 1.2.0 → 1.3.0

data/spec/controllers/surveyor_controller_spec.rb

@@ -21,12 +21,12 @@ describe SurveyorController do
       response.should render_template('new')
     end
 
-    it "should list codes and survey_versions for all surveys" do
+    it "assigns surveys_by_access_code to surveys grouped by access_code" do
       original = Factory(:survey, :title => "Foo", :access_code => 'foo')
       supplant = Factory(:survey, :title => "Foo", :access_code => 'foo', :survey_version => 1)
-      hash = {"foo"=>{"title"=>"Foo", "survey_versions"=>[0, 1]}}
+      hash = {"foo"=>[supplant, original]}
       do_get
-      assigns(:codes).should eq hash
+      assigns(:surveys_by_access_code).should eq hash
     end
   end
 

data/spec/factories.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 # http://github.com/thoughtbot/factory_girl/tree/master
 require 'rubygems'
 require 'factory_girl'
@@ -5,13 +6,26 @@ require 'factory_girl'
 Factory.sequence(:unique_survey_access_code){|n| "simple survey #{UUIDTools::UUID.random_create.to_s}" }
 
 Factory.define :survey do |s|
-  s.title           {"Simple survey"}
-  s.description     {"A simple survey for testing"}
-  s.access_code     {Factory.next :unique_survey_access_code}
-  s.active_at       {Time.now}
-  s.inactive_at     {}
-  s.css_url         {}
-  s.survey_version  {0}
+  s.title           "Simple survey"
+  s.description     "A simple survey for testing"
+  s.access_code     { Factory.next :unique_survey_access_code }
+  s.survey_version  0
+end
+
+Factory.define :survey_translation do |t|
+  t.locale "es"
+  t.translation %(title: "Un idioma nunca es suficiente"
+survey_sections:
+  one:
+    title: "Uno"
+questions:
+  hello:
+    text: "¡Hola!"
+  name:
+    text: "¿Cómo se llama Usted?"
+    answers:
+      name:
+        help_text: "Mi nombre es...")
 end
 
 Factory.sequence(:survey_section_display_order){|n| n }

data/spec/helpers/formtastic_custom_input_spec.rb

@@ -5,12 +5,11 @@ describe Surveyor::Helpers::FormtasticCustomInput do
   context "input helpers" do
     it "should translate response class into attribute" do
       helper.response_class_to_method(:string).should == :string_value
-      helper.response_class_to_method(:other_and_string).should == :string_value
       helper.response_class_to_method(:integer).should == :integer_value
       helper.response_class_to_method(:float).should == :float_value
       helper.response_class_to_method(:datetime).should == :datetime_value
-      helper.response_class_to_method(:date).should == :datetime_value
-      helper.response_class_to_method(:time).should == :datetime_value
+      helper.response_class_to_method(:date).should == :date_value
+      helper.response_class_to_method(:time).should == :time_value
     end
   end
 end

data/spec/helpers/surveyor_helper_spec.rb

@@ -1,110 +1,77 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe SurveyorHelper do
-
-  before(:each) do
-
-  end
-  it "should return the question text with number" do
-    q1 = Factory(:question)
-    q2 = Factory(:question, :display_type => "label")
-    q3 = Factory(:question, :dependency => Factory(:dependency))
-    q4 = Factory(:question, :display_type => "image", :text => "something.jpg")
-    q5 = Factory(:question, :question_group => Factory(:question_group))
-    helper.q_text(q1).should == "<span class='qnum'>1) </span>#{q1.text}"
-    helper.q_text(q2).should == q2.text
-    helper.q_text(q3).should == q3.text
-
-    dir = "images"
-    if Rails.application.config.respond_to?(:assets) && Rails.application.config.assets
-      dir = "assets"
-    end
-
-    helper.q_text(q4).should == %Q(<img alt="Something" src="/#{dir}/something.jpg" />)
-    helper.q_text(q5).should == q5.text
-  end
-  require 'mustache'
-  class FakeMustacheContext < ::Mustache
-    def site
-      "Northwestern"
+  context "numbering" do
+    let(:asset_directory){ asset_pipeline_enabled? ? "assets" : "images" }
+    before do
+      ActionController::Base.helpers.config.assets_dir = "public" unless asset_pipeline_enabled?
     end
-    def somethingElse
-      "something new"
+    it "should return the question text with number, except for labels, dependencies, images, and grouped questions" do
+      q1 = Factory(:question)
+      q2 = Factory(:question, :display_type => "label")
+      q3 = Factory(:question, :dependency => Factory(:dependency))
+      q4 = Factory(:question, :display_type => "image", :text => "something.jpg")
+      q5 = Factory(:question, :question_group => Factory(:question_group))
+      helper.q_text(q1).should == "<span class='qnum'>1) </span>#{q1.text}"
+      helper.q_text(q2).should == q2.text
+      helper.q_text(q3).should == q3.text
+      helper.q_text(q4).should == %Q(<img alt="Something" src="/#{asset_directory}/something.jpg" />)
+      helper.q_text(q5).should == q5.text
     end
-
-    def group
-      "NUBIC"
-    end
-  end
-  it "should return text with with substituted value" do
-    q1 = Factory(:question, :text => "You are in {{site}}")
-    label = Factory(:question, :display_type => "label", :text => "Testing {{somethingElse}}")
-    helper.q_text(q1, FakeMustacheContext).should == "<span class='qnum'>1) </span>You are in Northwestern"
-    helper.q_text(label, FakeMustacheContext).should == "Testing something new"
-  end
-  it "should return help_text for question with substituted value" do
-    q2 = Factory(:question, :display_type => "label", :text => "Is you site Northwestern?", :help_text => "If your site is not {{site}}, pick 'no' for the answer")
-    helper.render_help_text(q2, FakeMustacheContext).should == "If your site is not Northwestern, pick 'no' for the answer"
-  end
-  it "should return help_text for group text with number" do
-    g1 = Factory(:question_group, :text => "You are part of the {{group}}")
-    helper.q_text(g1, FakeMustacheContext).should == "<span class='qnum'>1) </span>You are part of the NUBIC"
-  end
-  it "should return help_text for group text" do
-    g1 = Factory(:question_group, :text => "You are part of the {{group}}", :help_text => "Make sure you know what the {{group}} stands for")
-    helper.render_help_text(g1, FakeMustacheContext).should == "Make sure you know what the NUBIC stands for"
-  end
-
-  it "should return rendered text for answer" do
-    q1 = Factory(:question, :text => "Do you work for {{site}}", :answers => [a1 = Factory(:answer, :text => "No, I don't work for {{site}}"), a2 = Factory(:answer, :text => "Yes, I do work for {{site}}") ])
-    helper.a_text(a1, nil, FakeMustacheContext).should == "No, I don't work for Northwestern"
-    helper.a_text(a2, nil, FakeMustacheContext).should == "Yes, I do work for Northwestern"
   end
 
-  it "should return the group text with number" do
-    g1 = Factory(:question_group)
-    helper.q_text(g1, FakeMustacheContext).should == "<span class='qnum'>1) </span>#{g1.text}"
+  context "with mustache text substitution" do
+    require 'mustache'
+    let(:mustache_context){ Class.new(::Mustache){ def site; "Northwestern"; end; def somethingElse; "something new"; end; def group; "NUBIC"; end } }
+    it "substitues values into Question#text" do
+      q1 = Factory(:question, :text => "You are in {{site}}")
+      label = Factory(:question, :display_type => "label", :text => "Testing {{somethingElse}}")
+      helper.q_text(q1, mustache_context).should == "<span class='qnum'>1) </span>You are in Northwestern"
+      helper.q_text(label, mustache_context).should == "Testing something new"
+    end
   end
 
-  it "should find or create responses, with index" do
-    q1 = Factory(:question, :answers => [a = Factory(:answer, :text => "different")])
-    q2 = Factory(:question, :answers => [b = Factory(:answer, :text => "strokes")])
-    q3 = Factory(:question, :answers => [c = Factory(:answer, :text => "folks")])
-    rs = Factory(:response_set, :responses => [r1 = Factory(:response, :question => q1, :answer => a), r3 = Factory(:response, :question => q3, :answer => c, :response_group => 1)])
+  context "response methods" do
+    it "should find or create responses, with index" do
+      q1 = Factory(:question, :answers => [a = Factory(:answer, :text => "different")])
+      q2 = Factory(:question, :answers => [b = Factory(:answer, :text => "strokes")])
+      q3 = Factory(:question, :answers => [c = Factory(:answer, :text => "folks")])
+      rs = Factory(:response_set, :responses => [r1 = Factory(:response, :question => q1, :answer => a), r3 = Factory(:response, :question => q3, :answer => c, :response_group => 1)])
+
+      helper.response_for(rs, nil).should == nil
+      helper.response_for(nil, q1).should == nil
+      helper.response_for(rs, q1).should == r1
+      helper.response_for(rs, q1, a).should == r1
+      helper.response_for(rs, q2).attributes.reject{|k,v| k == "api_id"}.should == Response.new(:question => q2, :response_set => rs).attributes.reject{|k,v| k == "api_id"}
+      helper.response_for(rs, q2, b).attributes.reject{|k,v| k == "api_id"}.should == Response.new(:question => q2, :response_set => rs).attributes.reject{|k,v| k == "api_id"}
+      helper.response_for(rs, q3, c, "1").should == r3
 
-    helper.response_for(rs, nil).should == nil
-    helper.response_for(nil, q1).should == nil
-    helper.response_for(rs, q1).should == r1
-    helper.response_for(rs, q1, a).should == r1
-    helper.response_for(rs, q2).attributes.reject{|k,v| k == "api_id"}.should == Response.new(:question => q2, :response_set => rs).attributes.reject{|k,v| k == "api_id"}
-    helper.response_for(rs, q2, b).attributes.reject{|k,v| k == "api_id"}.should == Response.new(:question => q2, :response_set => rs).attributes.reject{|k,v| k == "api_id"}
-    helper.response_for(rs, q3, c, "1").should == r3
-
-  end
-  it "should keep an index of responses" do
-    helper.response_idx.should == "1"
-    helper.response_idx.should == "2"
-    helper.response_idx(false).should == "2"
-    helper.response_idx.should == "3"
-  end
-  it "should translate response class into attribute" do
-    helper.rc_to_attr(:string).should == :string_value
-    helper.rc_to_attr(:text).should == :text_value
-    helper.rc_to_attr(:integer).should == :integer_value
-    helper.rc_to_attr(:float).should == :float_value
-    helper.rc_to_attr(:datetime).should == :datetime_value
-    helper.rc_to_attr(:date).should == :date_value
-    helper.rc_to_attr(:time).should == :time_value
-  end
+    end
+    it "should keep an index of responses" do
+      helper.response_idx.should == "1"
+      helper.response_idx.should == "2"
+      helper.response_idx(false).should == "2"
+      helper.response_idx.should == "3"
+    end
+    it "should translate response class into attribute" do
+      helper.rc_to_attr(:string).should == :string_value
+      helper.rc_to_attr(:text).should == :text_value
+      helper.rc_to_attr(:integer).should == :integer_value
+      helper.rc_to_attr(:float).should == :float_value
+      helper.rc_to_attr(:datetime).should == :datetime_value
+      helper.rc_to_attr(:date).should == :date_value
+      helper.rc_to_attr(:time).should == :time_value
+    end
 
-  it "should translate response class into as" do
-    helper.rc_to_as(:string).should == :string
-    helper.rc_to_as(:text).should == :text
-    helper.rc_to_as(:integer).should == :string
-    helper.rc_to_as(:float).should == :string
-    helper.rc_to_as(:datetime).should == :string
-    helper.rc_to_as(:date).should == :string
-    helper.rc_to_as(:time).should == :string
+    it "should translate response class into as" do
+      helper.rc_to_as(:string).should == :string
+      helper.rc_to_as(:text).should == :text
+      helper.rc_to_as(:integer).should == :string
+      helper.rc_to_as(:float).should == :string
+      helper.rc_to_as(:datetime).should == :string
+      helper.rc_to_as(:date).should == :string
+      helper.rc_to_as(:time).should == :string
+    end
   end
 
   context "overriding methods" do
@@ -121,7 +88,6 @@ describe SurveyorHelper do
         end
       end
     end
-
     it "should translate response class into as" do
       helper.rc_to_as(:string).should == :string
       helper.rc_to_as(:text).should == :text
@@ -131,7 +97,6 @@ describe SurveyorHelper do
       helper.rc_to_as(:date).should == :date          # not string
       helper.rc_to_as(:time).should == :time
     end
-
     after do
       module SurveyorHelper
         include Surveyor::Helpers::SurveyorHelperMethods
@@ -142,7 +107,7 @@ describe SurveyorHelper do
     end
   end
 
-  # Make sure that this context runs after the previous context 'overriding methods'
+  # run this context after 'overriding methods'
   context "post override test" do
     # Sanity check
     it "should translate response class into as after override" do
@@ -150,5 +115,4 @@ describe SurveyorHelper do
       helper.rc_to_as(:date).should == :string      # back to string
     end
   end
-
 end

data/spec/models/answer_spec.rb

@@ -1,67 +1,175 @@
+# encoding: UTF-8
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Answer, "when creating a new answer" do
-  before(:each) do
-    @answer = Factory(:answer, :text => "Red")
-  end
-  
-  it "should be valid" do
-    @answer.should be_valid
-  end
-  
-  # this causes issues with building and saving answers to questions within a grid.
-  # it "should be invalid without a question_id" do
-  #   @answer.question_id = nil
-  #   @answer.should_not be_valid
-  # end
-  
-  it "should tell me its css class" do
-    @answer.custom_class = "foo bar"
-    @answer.css_class.should == "foo bar"
-    @answer.is_exclusive = true
-    @answer.css_class.should == "exclusive foo bar"
-  end
-  
-  it "should hide the label when display_type hidden_label is set" do
-    @answer.split_or_hidden_text.should == "Red"
-    @answer.display_type = "hidden_label"
-    @answer.split_or_hidden_text.should == ""
-  end
-  it "should split up pre/post labels" do
-    @answer.text = "before|after|extra"
-    @answer.split_or_hidden_text(:pre).should == "before"
-    @answer.split_or_hidden_text(:post).should == "after|extra"
-  end
-  it "should delete validation when it is deleted" do
-    v_id = Factory(:validation, :answer => @answer).id
-    @answer.destroy
-    Validation.find_by_id(v_id).should be_nil
+describe Answer do
+  let(:answer){ Factory(:answer) }
+
+  context "when creating" do
+    it { answer.should be_valid }
+    it "deletes validation when deleted" do
+      v_id = Factory(:validation, :answer => answer).id
+      answer.destroy
+      Validation.find_by_id(v_id).should be_nil
+    end
+    it "protects #api_id" do
+      saved_attrs = answer.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { answer.update_attributes(:api_id => "NEW") }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        answer.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      answer.attributes.should == saved_attrs
+    end
+    it "protects #created_at" do
+      saved_attrs = answer.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { answer.update_attributes(:created_at => 3.days.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        answer.attributes = {:created_at => 3.days.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      answer.attributes.should == saved_attrs
+    end
+    it "protects #updated_at" do
+      saved_attrs = answer.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { answer.update_attributes(:updated_at => 3.hours.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        answer.attributes = {:updated_at => 3.hours.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      answer.attributes.should == saved_attrs
+    end
   end
-  
-  it "should have an api_id" do
-    @answer.api_id.length.should == 36
+
+  context "with mustache text substitution" do
+    require 'mustache'
+    let(:mustache_context){ Class.new(::Mustache){ def site; "Northwestern"; end; def foo; "bar"; end } }
+    it "subsitutes Mustache context variables" do
+      answer.text = "You are in {{site}}"
+      answer.in_context(answer.text, mustache_context).should == "You are in Northwestern"
+      answer.text_for(nil, mustache_context).should == "You are in Northwestern"
+
+      answer.help_text = "{{site}} is your site"
+      answer.in_context(answer.help_text, mustache_context).should == "Northwestern is your site"
+      answer.help_text_for(mustache_context).should == "Northwestern is your site"
+
+      answer.default_value = "{{site}}"
+      answer.in_context(answer.default_value, mustache_context).should == "Northwestern"
+      answer.default_value_for(mustache_context).should == "Northwestern"
+    end
   end
-  
-  it "should protect api_id, timestamps" do
-    saved_attrs = @answer.attributes
-    if defined? ActiveModel::MassAssignmentSecurity::Error
-      lambda {@answer.update_attributes(:created_at => 3.days.ago, :updated_at => 3.hours.ago)}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-      lambda {@answer.update_attributes(:api_id => "NEW")}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-    else
-      @answer.attributes = {:created_at => 3.days.ago, :updated_at => 3.hours.ago} # automatically protected by Rails
-      @answer.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
-    end
-    @answer.attributes.should == saved_attrs
+
+  context "with translations" do
+    require 'yaml'
+    let(:survey){ Factory(:survey) }
+    let(:survey_section){ Factory(:survey_section) }
+    let(:survey_translation){
+      Factory(:survey_translation, :locale => :es, :translation => {
+        :questions => {
+          :name => {
+            :answers => {
+              :name => {
+                :help_text => "Mi nombre es..."
+              }
+            }
+          }
+        }
+      }.to_yaml)
+    }
+    let(:question){ Factory(:question, :reference_identifier => "name") }
+    before do
+      answer.reference_identifier = "name"
+      answer.help_text = "My name is..."
+      answer.text = nil
+      answer.question = question
+      question.survey_section = survey_section
+      survey_section.survey = survey
+      survey.translations << survey_translation
+    end
+    it "returns its own translation" do
+      answer.translation(:es)[:help_text].should == "Mi nombre es..."
+    end
+    it "returns translations in views" do
+      answer.help_text_for(nil, :es).should == "Mi nombre es..."
+    end
+    it "returns its own default values" do
+      answer.translation(:de).should == {"text" => nil, "help_text" => "My name is...", "default_value" => nil}
+    end
+    it "returns default values in views" do
+      answer.help_text_for(nil, :de).should == "My name is..."
+    end
   end
-  
-  require 'mustache'
-  class FakeMustacheContext < ::Mustache
-    def site
-      "Northwestern"
+
+  context "handling strings" do
+    it "#split preserves strings" do
+      answer.split(answer.text).should == "My favorite color is clear"
+    end
+    it "#split(:pre) preserves strings" do
+      answer.split(answer.text, :pre).should == "My favorite color is clear"
+    end
+    it "#split(:post) preserves strings" do
+      answer.split(answer.text, :post).should == ""
+    end
+    it "#split splits strings" do
+      answer.text = "before|after|extra"
+      answer.split(answer.text).should == "before|after|extra"
+    end
+    it "#split(:pre) splits strings" do
+      answer.text = "before|after|extra"
+      answer.split(answer.text, :pre).should == "before"
+    end
+    it "#split(:post) splits strings" do
+      answer.text = "before|after|extra"
+      answer.split(answer.text, :post).should == "after|extra"
     end
   end
-  it "should substitute 'Northwestern' in place {{site}}" do
-      @answer.text = "You are in {{site}}"
-      @answer.split_or_hidden_text(nil, FakeMustacheContext).should == "You are in Northwestern"
+
+  context "for views" do
+    let(:asset_directory){ asset_pipeline_enabled? ? "assets" : "images" }
+    before do
+      ActionController::Base.helpers.config.assets_dir = "public" unless asset_pipeline_enabled?
+    end
+    it "#text_for with #display_type == image" do
+      answer.text = "rails.png"
+      answer.display_type = :image
+      answer.text_for.should == %(<img alt="Rails" src="/#{asset_directory}/rails.png" />)
+    end
+    it "#text_for with #display_type == hidden_label" do
+      answer.text = "Red"
+      answer.text_for.should == "Red"
+      answer.display_type = "hidden_label"
+      answer.text_for.should == ""
+    end
+    it "#default_value_for"
+    it "#help_text_for"
+    it "reports DOM ready #css_class from #custom_class" do
+      answer.custom_class = "foo bar"
+      answer.css_class.should == "foo bar"
+    end
+    it "reports DOM ready #css_class from #custom_class and #is_exclusive" do
+      answer.custom_class = "foo bar"
+      answer.is_exclusive = true
+      answer.css_class.should == "exclusive foo bar"
+    end
+    it "#text_for preserves strings" do
+      answer.text_for.should == "My favorite color is clear"
+    end
+    it "#text_for(:pre) preserves strings" do
+      answer.text_for(:pre).should == "My favorite color is clear"
+    end
+    it "#text_for(:post) preserves strings" do
+      answer.text_for(:post).should == ""
+    end
+    it "#text_for splits strings" do
+      answer.text = "before|after|extra"
+      answer.text_for.should == "before|after|extra"
+    end
+    it "#text_for(:pre) splits strings" do
+      answer.text = "before|after|extra"
+      answer.text_for(:pre).should == "before"
+    end
+    it "#text_for(:post) splits strings" do
+      answer.text = "before|after|extra"
+      answer.text_for(:post).should == "after|extra"
+    end
   end
 end