surveyor 1.2.0 → 1.3.0

data/spec/models/question_group_spec.rb

@@ -1,47 +1,93 @@
+# encoding: UTF-8
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe QuestionGroup do
-  before(:each) do
-    @question_group = Factory(:question_group)
-  end
+  let(:question_group){ Factory(:question_group) }
+  let(:dependency){ Factory(:dependency) }
+  let(:response_set){ Factory(:response_set) }
 
-  it "should be valid" do
-    @question_group.should be_valid
-  end
-  it "should have defaults" do
-    @question_group = QuestionGroup.new
-    @question_group.display_type.should == "inline"
-    @question_group.renderer.should == :inline
-    @question_group.display_type = nil
-    @question_group.renderer.should == :default
-  end
-  it "should return its custom css class" do
-    @question_group.custom_class = "foo bar"
-    @question_group.css_class(Factory(:response_set)).should == "foo bar"
-  end
-  it "should return its dependency class" do
-    @dependency = Factory(:dependency)
-    @question_group.dependency = @dependency
-    @dependency.should_receive(:is_met?).and_return(true)
-    @question_group.css_class(Factory(:response_set)).should == "g_dependent"
+  context "when creating" do
+    it { question_group.should be_valid }
+    it "#display_type = inline by default" do
+      question_group.display_type = "inline"
+      question_group.renderer.should == :inline
+    end
+    it "#renderer == 'default' when #display_type = nil" do
+      question_group.display_type = nil
+      question_group.renderer.should == :default
+    end
+    it "interprets symbolizes #display_type to #renderer" do
+      question_group.display_type = "foo"
+      question_group.renderer.should == :foo
+    end
+    it "reports DOM ready #css_class based on dependencies" do
+      question_group.dependency = dependency
+      dependency.should_receive(:is_met?).and_return(true)
+      question_group.css_class(response_set).should == "g_dependent"
 
-    @dependency.should_receive(:is_met?).and_return(false)
-    @question_group.css_class(Factory(:response_set)).should == "g_dependent g_hidden"
+      dependency.should_receive(:is_met?).and_return(false)
+      question_group.css_class(response_set).should == "g_dependent g_hidden"
 
-    @question_group.custom_class = "foo bar"
-    @dependency.should_receive(:is_met?).and_return(false)
-    @question_group.css_class(Factory(:response_set)).should == "g_dependent g_hidden foo bar"
+      question_group.custom_class = "foo bar"
+      dependency.should_receive(:is_met?).and_return(false)
+      question_group.css_class(response_set).should == "g_dependent g_hidden foo bar"
+    end
+    it "protects #api_id" do
+      saved_attrs = question_group.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { question_group.update_attributes(:api_id => "NEW") }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        question_group.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      question_group.attributes.should == saved_attrs
+    end
+    it "protects #created_at" do
+      saved_attrs = question_group.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { question_group.update_attributes(:created_at => 3.days.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        question_group.attributes = {:created_at => 3.days.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      question_group.attributes.should == saved_attrs
+    end
+    it "protects #updated_at" do
+      saved_attrs = question_group.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { question_group.update_attributes(:updated_at => 3.hours.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        question_group.attributes = {:updated_at => 3.hours.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      question_group.attributes.should == saved_attrs
+    end
   end
-  it "should protect api_id, timestamps" do
-    saved_attrs = @question_group.attributes
-    if defined? ActiveModel::MassAssignmentSecurity::Error
-      lambda {@question_group.update_attributes(:created_at => 3.days.ago, :updated_at => 3.hours.ago)}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-      lambda {@question_group.update_attributes(:api_id => "NEW")}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-    else
-      @question_group.attributes = {:created_at => 3.days.ago, :updated_at => 3.hours.ago} # automatically protected by Rails
-      @question_group.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
-    end
-    @question_group.attributes.should == saved_attrs
+
+  context "with translations" do
+    require 'yaml'
+    let(:survey){ Factory(:survey) }
+    let(:survey_section){ Factory(:survey_section) }
+    let(:survey_translation){
+      Factory(:survey_translation, :locale => :es, :translation => {
+        :question_groups => {
+          :goodbye => {
+            :text => "¡Adios!"
+          }
+        }
+      }.to_yaml)
+    }
+    let(:question){ Factory(:question) }
+    before do
+      question_group.text = "Goodbye"
+      question_group.reference_identifier = "goodbye"
+      question_group.questions = [question]
+      question.survey_section = survey_section
+      survey_section.survey = survey
+      survey.translations << survey_translation
+    end
+    it "returns its own translation" do
+      question_group.translation(:es)[:text].should == "¡Adios!"
+    end
+    it "returns its own default values" do
+      question_group.translation(:de).should == {"text" => "Goodbye", "help_text" => nil}
+    end
   end
-  
 end

data/spec/models/question_spec.rb

@@ -1,135 +1,207 @@
+# encoding: UTF-8
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Question, "when creating a new question" do
-  before(:each) do
-    @ss = mock_model(SurveySection)
-    @question = Question.new(:text => "What is your favorite color?", :survey_section => @ss, :is_mandatory => false, :display_order => 1)
-  end
-
-  it "should be invalid without text" do
-    @question.text = nil
-    @question.should have(1).error_on(:text)
-  end
-
-  it "should have a parent survey section" do
-    # this causes issues with building and saving
-    # @question.survey_section = nil
-    # @question.should have(1).error_on(:survey_section_id)
-  end
-
-  it "should not be mandatory by default" do
-    @question.mandatory?.should be_false
-  end
-
-  it "should convert pick attribute to string" do
-    @question.pick.should == "none"
-    @question.pick = :one
-    @question.pick.should == "one"
-    @question.pick = nil
-    @question.pick.should == nil
-  end
-
-  it "should split the text" do
-    @question.split_text.should == "What is your favorite color?"
-    @question.split_text(:pre).should == "What is your favorite color?"
-    @question.split_text(:post).should == ""
-    @question.text = "before|after|extra"
-    @question.split_text.should == "before|after|extra"
-    @question.split_text(:pre).should == "before"
-    @question.split_text(:post).should == "after|extra"
-  end
-
-  it "should have an api_id" do
-    @question.api_id.length.should == 36
-  end
-
-  it "should protect api_id, timestamps" do
-    saved_attrs = @question.attributes
-    if defined? ActiveModel::MassAssignmentSecurity::Error
-      lambda {@question.update_attributes(:created_at => 3.days.ago, :updated_at => 3.hours.ago)}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-      lambda {@question.update_attributes(:api_id => "NEW")}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-    else
-      @question.attributes = {:created_at => 3.days.ago, :updated_at => 3.hours.ago} # automatically protected by Rails
-      @question.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
-    end
-    @question.attributes.should == saved_attrs
-  end
-end
+describe Question do
+  let(:question){ Factory(:question) }
 
-describe Question, "that has answers" do
-  before(:each) do
-    @question = Factory(:question, :text => "What is your favorite color?")
-    Factory(:answer, :question => @question, :display_order => 3, :text => "blue")
-    Factory(:answer, :question => @question, :display_order => 1, :text => "red")
-    Factory(:answer, :question => @question, :display_order => 2, :text => "green")
-  end
-
-  it "should have answers" do
-    @question.answers.should have(3).answers
-  end
-
-  it "should retrieve those answers in display_order" do
-    @question.answers.map(&:display_order).should == [1,2,3]
-  end
-  it "should delete answers when it is deleted" do
-    answer_ids = @question.answers.map(&:id)
-    @question.destroy
-    answer_ids.each{|id| Answer.find_by_id(id).should be_nil}
+  context "when creating" do
+    it "is invalid without #text" do
+      question.text = nil
+      question.should have(1).error_on :text
+    end
+    it "#is_mandantory == false by default" do
+      question.mandatory?.should be_false
+    end
+    it "converts #pick to string" do
+      question.pick.should == "none"
+      question.pick = :one
+      question.pick.should == "one"
+      question.pick = nil
+      question.pick.should == nil
+    end
+    it "#renderer == 'default' when #display_type = nil" do
+      question.display_type = nil
+      question.renderer.should == :default
+    end
+    it "has #api_id with 36 characters by default" do
+      question.api_id.length.should == 36
+    end
+    it "#part_of_group? and #solo? are aware of question groups" do
+      question.question_group = Factory(:question_group)
+      question.solo?.should be_false
+      question.part_of_group?.should be_true
+
+      question.question_group = nil
+      question.solo?.should be_true
+      question.part_of_group?.should be_false
+    end
+    it "protects #api_id" do
+      saved_attrs = question.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { question.update_attributes(:api_id => "NEW") }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        question.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      question.attributes.should == saved_attrs
+    end
+    it "protects #created_at" do
+      saved_attrs = question.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { question.update_attributes(:created_at => 3.days.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        question.attributes = {:created_at => 3.days.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      question.attributes.should == saved_attrs
+    end
+    it "protects #updated_at" do
+      saved_attrs = question.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { question.update_attributes(:updated_at => 3.hours.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        question.attributes = {:updated_at => 3.hours.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      question.attributes.should == saved_attrs
+    end
   end
-end
 
-describe Question, "when interacting with an instance" do
-
-  before(:each) do
-    @question = Factory(:question)
+  context "with answers" do
+    let(:answer_1){ Factory(:answer, :question => question, :display_order => 3, :text => "blue")}
+    let(:answer_2){ Factory(:answer, :question => question, :display_order => 1, :text => "red")}
+    let(:answer_3){ Factory(:answer, :question => question, :display_order => 2, :text => "green")}
+    before do
+      [answer_1, answer_2, answer_3].each{|a| question.answers << a }
+    end
+    it{ question.should have(3).answers}
+    it "gets answers in order" do
+      question.answers.should == [answer_2, answer_3, answer_1]
+      question.answers.map(&:display_order).should == [1,2,3]
+    end
+    it "deletes child answers when deleted" do
+      answer_ids = question.answers.map(&:id)
+      question.destroy
+      answer_ids.each{|id| Answer.find_by_id(id).should be_nil}
+    end
   end
 
-  it "should return 'default' for nil display type" do
-    @question.display_type = nil
-    @question.renderer.should == :default
+  context "with dependencies" do
+    let(:response_set){ Factory(:response_set) }
+    let(:dependency){ Factory(:dependency) }
+    before do
+      question.dependency = dependency
+      dependency.stub!(:is_met?).with(response_set).and_return true
+    end
+    it "checks its dependency" do
+      question.triggered?(response_set).should be_true
+    end
+    it "deletes its dependency when deleted" do
+      d_id = question.dependency.id
+      question.destroy
+      Dependency.find_by_id(d_id).should be_nil
+    end
   end
 
-  it "should let you know if it is part of a group" do
-    @question.question_group = Factory(:question_group)
-    @question.solo?.should be_false
-    @question.part_of_group?.should be_true
-    @question.question_group = nil
-    @question.solo?.should be_true
-    @question.part_of_group?.should be_false
+  context "with mustache text substitution" do
+    require 'mustache'
+    let(:mustache_context){ Class.new(::Mustache){ def site; "Northwestern"; end; def foo; "bar"; end } }
+    it "subsitutes Mustache context variables" do
+      question.text = "You are in {{site}}"
+      question.in_context(question.text, mustache_context).should == "You are in Northwestern"
+    end
+    it "substitues in views" do
+      question.text = "You are in {{site}}"
+      question.text_for(nil, mustache_context).should == "You are in Northwestern"
+    end
   end
 
-  require 'mustache'
-  class FakeMustacheContext < ::Mustache
-    def site
-      "Northwestern"
+  context "with translations" do
+    require 'yaml'
+    let(:survey){ Factory(:survey) }
+    let(:survey_section){ Factory(:survey_section) }
+    let(:survey_translation){
+      Factory(:survey_translation, :locale => :es, :translation => {
+        :questions => {
+          :hello => {
+            :text => "¡Hola!"
+          }
+        }
+      }.to_yaml)
+    }
+    before do
+      question.reference_identifier = "hello"
+      question.survey_section = survey_section
+      survey_section.survey = survey
+      survey.translations << survey_translation
     end
-    def somethingElse
-      "something new"
+    it "returns its own translation" do
+      YAML.load(survey_translation.translation).should_not be_nil
+      question.translation(:es)[:text].should == "¡Hola!"
+    end
+    it "returns its own default values" do
+      question.translation(:de).should == {"text" => question.text, "help_text" => question.help_text}
+    end
+    it "returns translations in views" do
+      question.text_for(nil, nil, :es).should == "¡Hola!"
+    end
+    it "returns default values in views" do
+      question.text_for(nil, nil, :de).should == question.text
     end
   end
-  it "should substitute 'Northwestern' in place {{site}}" do
-      @question.text = "You are in {{site}}"
-      @question.render_question_text(FakeMustacheContext).should == "You are in Northwestern"
-  end
-
-end
 
-describe Question, "with dependencies" do
-  before(:each) do
-    @rs = mock_model(ResponseSet)
-    @question = Factory(:question)
+  context "handling strings" do
+    it "#split preserves strings" do
+      question.split(question.text).should == "What is your favorite color?"
+    end
+    it "#split(:pre) preserves strings" do
+      question.split(question.text, :pre).should == "What is your favorite color?"
+    end
+    it "#split(:post) preserves strings" do
+      question.split(question.text, :post).should == ""
+    end
+    it "#split splits strings" do
+      question.text = "before|after|extra"
+      question.split(question.text).should == "before|after|extra"
+    end
+    it "#split(:pre) splits strings" do
+      question.text = "before|after|extra"
+      question.split(question.text, :pre).should == "before"
+    end
+    it "#split(:post) splits strings" do
+      question.text = "before|after|extra"
+      question.split(question.text, :post).should == "after|extra"
+    end
   end
 
-  it "should check its dependency" do
-    @dependency = mock_model(Dependency)
-    @dependency.stub!(:is_met?).with(@rs).and_return(true)
-    @question.stub!(:dependency).and_return(@dependency)
-    @question.triggered?(@rs).should == true
-  end
-  it "should delete dependency when it is deleted" do
-    dep_id = Factory(:dependency, :question => @question).id
-    @question.destroy
-    Dependency.find_by_id(dep_id).should be_nil
+  context "for views" do
+    let(:asset_directory){ asset_pipeline_enabled? ? "assets" : "images" }
+    before do
+      ActionController::Base.helpers.config.assets_dir = "public" unless asset_pipeline_enabled?
+    end
+    it "#text_for with #display_type == image" do
+      question.text = "rails.png"
+      question.display_type = :image
+      question.text_for.should == %(<img alt="Rails" src="/#{asset_directory}/rails.png" />)
+    end
+    it "#help_text_for"
+    it "#text_for preserves strings" do
+      question.text_for.should == "What is your favorite color?"
+    end
+    it "#text_for(:pre) preserves strings" do
+      question.text_for(:pre).should == "What is your favorite color?"
+    end
+    it "#text_for(:post) preserves strings" do
+      question.text_for(:post).should == ""
+    end
+    it "#text_for splits strings" do
+      question.text = "before|after|extra"
+      question.text_for.should == "before|after|extra"
+    end
+    it "#text_for(:pre) splits strings" do
+      question.text = "before|after|extra"
+      question.text_for(:pre).should == "before"
+    end
+    it "#text_for(:post) splits strings" do
+      question.text = "before|after|extra"
+      question.text_for(:post).should == "after|extra"
+    end
   end
-
 end