surveyor 1.2.0 → 1.3.0

data/spec/models/survey_section_spec.rb

@@ -1,48 +1,85 @@
+# encoding: UTF-8
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe SurveySection, "when saving a survey_section" do
-  before(:each) do
-    @valid_attributes={:title => "foo", :survey_id => 2, :display_order => 4}
-    @survey_section = SurveySection.new(@valid_attributes)
-  end
+describe SurveySection do
+    let(:survey_section){ Factory(:survey_section) }
 
-  it "should be invalid without title" do
-    @survey_section.title = nil
-    @survey_section.should have(1).error_on(:title)
-  end
-  
-  it "should have a parent survey" do
-    # this causes issues with building and saving
-    # @survey_section.survey_id = nil
-    # @survey_section.should have(1).error_on(:survey)
-  end
-  it "should protect timestamps" do
-    saved_attrs = @survey_section.attributes
-    if defined? ActiveModel::MassAssignmentSecurity::Error
-      lambda {@survey_section.update_attributes(:created_at => 3.days.ago, :updated_at => 3.hours.ago)}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-    else
-      @survey_section.attributes = {:created_at => 3.days.ago, :updated_at => 3.hours.ago} # automatically protected by Rails
-    end
-    @survey_section.attributes.should == saved_attrs
+  context "when creating" do
+    it "is invalid without #title" do
+      survey_section.title = nil
+      survey_section.should have(1).error_on(:title)
+    end
+    it "protects #api_id" do
+      saved_attrs = survey_section.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { survey_section.update_attributes(:api_id => "NEW") }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        survey_section.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      survey_section.attributes.should == saved_attrs
+    end
+    it "protects #created_at" do
+      saved_attrs = survey_section.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { survey_section.update_attributes(:created_at => 3.days.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        survey_section.attributes = {:created_at => 3.days.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      survey_section.attributes.should == saved_attrs
+    end
+    it "protects #updated_at" do
+      saved_attrs = survey_section.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { survey_section.update_attributes(:updated_at => 3.hours.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        survey_section.attributes = {:updated_at => 3.hours.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      survey_section.attributes.should == saved_attrs
+    end
   end
-end
 
-describe SurveySection, "with questions" do
-  before(:each) do
-    @survey_section = Factory(:survey_section, :title => "Rhymes", :display_order => 4)
-    @q1 = @survey_section.questions.create(:text => "Peep", :display_order => 3)
-    @q2 = @survey_section.questions.create(:text => "Little", :display_order => 1)
-    @q3 = @survey_section.questions.create(:text => "Bo", :display_order => 2)
-  end
-  
-  it "should return questions sorted in display order" do
-    @survey_section.questions.should have(3).questions
-    @survey_section.questions.should == [@q2,@q3,@q1]
+  context "with questions" do
+    let(:question_1){ Factory(:question, :survey_section => survey_section, :display_order => 3, :text => "Peep")}
+    let(:question_2){ Factory(:question, :survey_section => survey_section, :display_order => 1, :text => "Little")}
+    let(:question_3){ Factory(:question, :survey_section => survey_section, :display_order => 2, :text => "Bo")}
+    before do
+      [question_1, question_2, question_3].each{|q| survey_section.questions << q }
+    end
+    it{ survey_section.should have(3).questions}
+    it "gets questions in order" do
+      survey_section.questions.should == [question_2, question_3, question_1]
+      survey_section.questions.map(&:display_order).should == [1,2,3]
+    end
+    it "deletes child questions when deleted" do
+      question_ids = survey_section.questions.map(&:id)
+      survey_section.destroy
+      question_ids.each{|id| Question.find_by_id(id).should be_nil}
+    end
   end
-  it "should delete questions when it is deleted" do
-    question_ids = @survey_section.questions.map(&:id)
-    @survey_section.destroy
-    question_ids.each{|id| Question.find_by_id(id).should be_nil}
+
+  context "with translations" do
+    require 'yaml'
+    let(:survey){ Factory(:survey) }
+    let(:survey_translation){
+      Factory(:survey_translation, :locale => :es, :translation => {
+        :survey_sections => {
+          :one => {
+            :title => "Uno"
+          }
+        }
+      }.to_yaml)
+    }
+    before do
+      survey_section.reference_identifier = "one"
+      survey_section.survey = survey
+      survey.translations << survey_translation
+    end
+    it "returns its own translation" do
+      YAML.load(survey_translation.translation).should_not be_nil
+      survey_section.translation(:es)[:title].should == "Uno"
+    end
+    it "returns its own default values" do
+      survey_section.translation(:de).should == {"title" => survey_section.title, "description" => survey_section.description}
+    end
   end
-  
 end

data/spec/models/survey_spec.rb

@@ -1,160 +1,191 @@
+# encoding: UTF-8
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-# Validations
-describe Survey, "when saving a new one" do
-  before(:each) do
-    @survey = Factory(:survey, :title => "Foo")
-  end
-
-  it "should be invalid without a title" do
-    @survey.title = nil
-    @survey.should have(1).error_on(:title)
-  end
-
-  it "should adjust the survey_version to save unique survey_version for each title" do
-    original = Survey.new(:title => "Foo")
-    original.save.should be_true
-    original.survey_version.should == 0
-    imposter = Survey.new(:title => "Foo")
-    imposter.save.should be_true
-    imposter.title.should == "Foo"
-    imposter.survey_version.should == 1
-    bandwagoneer = Survey.new(:title => "Foo")
-    bandwagoneer.save.should be_true
-    bandwagoneer.title.should == "Foo"
-    bandwagoneer.survey_version.should == 2
-  end
-  
-  it "should not allow to have duplicate survey_versions of the survey" do
-    survey = Survey.new(:title => "Foo")
-    survey.save.should be_true
-    imposter = Survey.new(:title => "Foo")
-    imposter.save.should be_true
-    imposter.survey_version = 0
-    imposter.save.should be_false
-    imposter.should have(1).error_on(:survey_version)
-  end
-
-  it "should not adjust the title when updating itself" do
-    original = Factory(:survey, :title => "Foo")
-    original.save.should be_true
-    original.update_attributes(:title => "Foo")
-    original.title.should == "Foo"
-  end
-
-  it "should have an api_id" do
-    @survey.api_id.length.should == 36
-  end
-end
-
-# Associations
-describe Survey, "that has sections" do
-  before(:each) do
-    @survey = Factory(:survey, :title => "Foo")
-    @s1 = Factory(:survey_section, :survey => @survey, :title => "wise", :display_order => 2)
-    @s2 = Factory(:survey_section, :survey => @survey, :title => "er", :display_order => 3)
-    @s3 = Factory(:survey_section, :survey => @survey, :title => "bud", :display_order => 1)
-    @q1 = Factory(:question, :survey_section => @s1, :text => "what is wise?", :display_order => 2)
-    @q2 = Factory(:question, :survey_section => @s2, :text => "what is er?", :display_order => 4)
-    @q3 = Factory(:question, :survey_section => @s2, :text => "what is mill?", :display_order => 3)
-    @q4 = Factory(:question, :survey_section => @s3, :text => "what is bud?", :display_order => 1)
-  end
-
-  it "should return survey_sections in display order" do
-    @survey.sections.should have(3).sections
-    @survey.sections.should == [@s3, @s1, @s2]
-  end
+describe Survey do
+  let(:survey){ Factory(:survey) }
 
-  it "should return survey_sections_with_questions in display order" do
-    @survey.sections_with_questions.map(&:questions).flatten.should have(4).questions
-    @survey.sections_with_questions.map(&:questions).flatten.should == [@q4,@q1,@q3,@q2]
-  end
-  it "should delete survey sections when it is deleted" do
-    section_ids = @survey.sections.map(&:id)
-    @survey.destroy
-    section_ids.each{|id| SurveySection.find_by_id(id).should be_nil}
+  context "when creating" do
+    it "is invalid without #title" do
+      survey.title = nil
+      survey.should have(1).error_on :title
+    end
+    it "adjust #survey_version" do
+      original = Survey.new(:title => "Foo")
+      original.save.should be_true
+      original.survey_version.should == 0
+      imposter = Survey.new(:title => "Foo")
+      imposter.save.should be_true
+      imposter.title.should == "Foo"
+      imposter.survey_version.should == 1
+      bandwagoneer = Survey.new(:title => "Foo")
+      bandwagoneer.save.should be_true
+      bandwagoneer.title.should == "Foo"
+      bandwagoneer.survey_version.should == 2
+    end
+    it "prevents duplicate #survey_version" do
+      original = Survey.new(:title => "Foo")
+      original.save.should be_true
+      imposter = Survey.new(:title => "Foo")
+      imposter.save.should be_true
+      imposter.survey_version = 0
+      imposter.save.should be_false
+      imposter.should have(1).error_on(:survey_version)
+    end
+    it "doesn't adjust #title when" do
+      original = Factory(:survey, :title => "Foo")
+      original.save.should be_true
+      original.update_attributes(:title => "Foo")
+      original.title.should == "Foo"
+    end
+    it "has #api_id with 36 characters by default" do
+      survey.api_id.length.should == 36
+    end
+    it "protects #access_code" do
+      saved_attrs = survey.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { survey.update_attributes(:access_code => "NEW") }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        survey.attributes = {:access_code => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      survey.attributes.should == saved_attrs
+    end
+    it "protects #api_id" do
+      saved_attrs = survey.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { survey.update_attributes(:api_id => "NEW") }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        survey.attributes = {:api_id => "NEW"} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      survey.attributes.should == saved_attrs
+    end
+    it "protects #created_at" do
+      saved_attrs = survey.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { survey.update_attributes(:created_at => 3.days.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        survey.attributes = {:created_at => 3.days.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      survey.attributes.should == saved_attrs
+    end
+    it "protects #updated_at" do
+      saved_attrs = survey.attributes
+      if defined? ActiveModel::MassAssignmentSecurity::Error
+        expect { survey.update_attributes(:updated_at => 3.hours.ago) }.to raise_error(ActiveModel::MassAssignmentSecurity::Error)
+      else
+        survey.attributes = {:updated_at => 3.hours.ago} # Rails doesn't return false, but this will be checked in the comparison to saved_attrs
+      end
+      survey.attributes.should == saved_attrs
+    end
   end
-end
 
-# Methods
-describe Survey do
-  before(:each) do
-    @survey = Survey.new
+  context "activating" do
+    it { survey.active?.should }
+    it "both #inactive_at and #active_at == nil by default" do
+      survey.active_at.should be_nil
+      survey.inactive_at.should be_nil
+    end
+    it "#active_at on a certain date/time" do
+      survey.inactive_at = 2.days.from_now
+      survey.active_at = 2.days.ago
+      survey.active?.should be_true
+    end
+    it "#inactive_at on a certain date/time" do
+      survey.active_at = 3.days.ago
+      survey.inactive_at = 1.days.ago
+      survey.active?.should be_false
+    end
+    it "#activate! and #deactivate!" do
+      survey.activate!
+      survey.active?.should be_true
+      survey.deactivate!
+      survey.active?.should be_false
+    end
+    it "nils out past values of #inactive_at on #activate!" do
+      survey.inactive_at = 5.days.ago
+      survey.active?.should be_false
+      survey.activate!
+      survey.active?.should be_true
+      survey.inactive_at.should be_nil
+    end
+    it "nils out pas values of #active_at on #deactivate!" do
+      survey.active_at = 5.days.ago
+      survey.active?.should be_true
+      survey.deactivate!
+      survey.active?.should be_false
+      survey.active_at.should be_nil
+    end
   end
 
-  it "should be inactive by default" do
-    @survey.active?.should == false
-  end
-  it "should have both inactive_at and active_at be null by default" do
-    @survey.active_at.should be_nil
-    @survey.inactive_at.should be_nil
-  end
-  
-  it "should be active or active as of a certain date/time" do
-    @survey.inactive_at = 2.days.from_now
-    @survey.active_at = 2.days.ago
-    @survey.active?.should be_true
-  end
+  context "with survey_sections" do
+    let(:s1){ Factory(:survey_section, :survey => survey, :title => "wise", :display_order => 2)}
+    let(:s2){ Factory(:survey_section, :survey => survey, :title => "er", :display_order => 3)}
+    let(:s3){ Factory(:survey_section, :survey => survey, :title => "bud", :display_order => 1)}
+    let(:q1){ Factory(:question, :survey_section => s1, :text => "what is wise?", :display_order => 2)}
+    let(:q2){ Factory(:question, :survey_section => s2, :text => "what is er?", :display_order => 4)}
+    let(:q3){ Factory(:question, :survey_section => s2, :text => "what is mill?", :display_order => 3)}
+    let(:q4){ Factory(:question, :survey_section => s3, :text => "what is bud?", :display_order => 1)}
+    before do
+      [s1, s2, s3].each{|s| survey.sections << s }
+      s1.questions << q1
+      s2.questions << q2
+      s2.questions << q3
+      s3.questions << q4
+    end
 
-  it "should be able to deactivate as of a certain date/time" do
-    @survey.active_at = 3.days.ago
-    @survey.inactive_at = 1.days.ago
-    @survey.active?.should be_false
+    it{ survey.should have(3).sections}
+    it "gets survey_sections in order" do
+      survey.sections.should == [s3, s1, s2]
+      survey.sections.map(&:display_order).should == [1,2,3]
+    end
+    it "gets survey_sections_with_questions in order" do
+      survey.sections_with_questions.map(&:questions).flatten.should have(4).questions
+      survey.sections_with_questions.map(&:questions).flatten.should == [q4,q1,q3,q2]
+    end
+    it "deletes child survey_sections when deleted" do
+      survey_section_ids = survey.sections.map(&:id)
+      survey.destroy
+      survey_section_ids.each{|id| SurveySection.find_by_id(id).should be_nil}
+    end
   end
 
-  it "should activate and deactivate" do
-    @survey.activate!
-    @survey.active?.should be_true
-    @survey.deactivate!
-    @survey.active?.should be_false
-  end
+  context "serialization" do
+    let(:s1){ Factory(:survey_section, :survey => survey, :title => "wise") }
+    let(:s2){ Factory(:survey_section, :survey => survey, :title => "er") }
+    let(:q1){ Factory(:question, :survey_section => s1, :text => "what is wise?") }
+    let(:q2){ Factory(:question, :survey_section => s2, :text => "what is er?") }
+    let(:q3){ Factory(:question, :survey_section => s2, :text => "what is mill?") }
+    before do
+      [s1, s2].each{|s| survey.sections << s }
+      s1.questions << q1
+      s2.questions << q2
+      s2.questions << q3
+    end
 
-  it "should should nil out values of inactive_at that are in the past on activate" do
-    @survey.inactive_at = 5.days.ago
-    @survey.active?.should be_false
-    @survey.activate!
-    @survey.active?.should be_true
-    @survey.inactive_at.should be_nil
+    it "includes title, sections, and questions" do
+      actual = survey.as_json
+      actual[:title].should == 'Simple survey'
+      actual[:sections].size.should == 2
+      actual[:sections][0][:questions_and_groups].size.should == 1
+      actual[:sections][1][:questions_and_groups].size.should == 2
+    end
   end
 
-  it "should should nil out values of active_at that are in the past on deactivate" do
-    @survey.active_at = 5.days.ago
-    @survey.active?.should be_true
-    @survey.deactivate!
-    @survey.active?.should be_false
-    @survey.active_at.should be_nil
-  end
-  
-  it "should protect access_code, api_id, active_at, inactive_at, timestamps" do
-    saved_attrs = @survey.attributes
-    if defined? ActiveModel::MassAssignmentSecurity::Error
-      lambda {@survey.update_attributes(:access_code => "NEW")}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-      lambda {@survey.update_attributes(:api_id => "AND")}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-      lambda {@survey.update_attributes(:active_at => 2.days.ago)}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-      lambda {@survey.update_attributes(:inactive_at => 3.days.from_now)}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-      lambda {@survey.update_attributes(:created_at => 3.days.ago, :updated_at => 3.hours.ago)}.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
-    else
-      @survey.update_attributes(:access_code => "NEW").should be_false
-      @survey.update_attributes(:api_id => "AND").should be_false
-      @survey.update_attributes(:active_at => 2.days.ago).should be_false
-      @survey.update_attributes(:inactive_at => 3.days.from_now).should be_false
-      @survey.attributes = {:created_at => 3.days.ago, :updated_at => 3.hours.ago} # automatically protected by Rails
-    end
-    @survey.attributes.should == saved_attrs
-  end
-  
-  it "should include title, sections, and questions when serialized" do
-    survey = Factory(:survey, :title => "Foo")
-    s1 = Factory(:survey_section, :survey => survey, :title => "wise")
-    s2 = Factory(:survey_section, :survey => survey, :title => "er")
-    q1 = Factory(:question, :survey_section => s1, :text => "what is wise?")
-    q2 = Factory(:question, :survey_section => s2, :text => "what is er?")
-    q3 = Factory(:question, :survey_section => s2, :text => "what is mill?")
-    
-    actual = survey.as_json
-    actual[:title].should == 'Foo'
-    actual[:sections].size.should == 2
-    actual[:sections][0][:questions_and_groups].size.should == 1
-    actual[:sections][1][:questions_and_groups].size.should == 2
+  context "with translations" do
+    require 'yaml'
+    let(:survey_translation){
+      Factory(:survey_translation, :locale => :es, :translation => {
+        :title => "Un idioma nunca es suficiente"
+      }.to_yaml)
+    }
+    before do
+      survey.translations << survey_translation
+    end
+    it "returns its own translation" do
+      YAML.load(survey_translation.translation).should_not be_nil
+      survey.translation(:es)[:title].should == "Un idioma nunca es suficiente"
+    end
+    it "returns its own default values" do
+      survey.translation(:de).should == {"title" => survey.title, "description" => survey.description}
+    end
   end
 end