suretax 0.2.3 → 1.0.0

data/spec/lib/suretax/connection_spec.rb

@@ -1,13 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Suretax::Connection do
-
   let(:connection) { Suretax::Connection.new }
 
-  context 'using v01 of the API' do
-
-    describe '#post' do
-      it_should_behave_like 'API connection' do
+  context "using v01 of the API" do
+    describe "#post" do
+      it_should_behave_like "API connection" do
         let(:api_path) { suretax_post_path }
         let(:request_body) { valid_encoded_test_request_body }
         let(:response) { connection.post(body: request_body) }
@@ -22,8 +20,8 @@ describe Suretax::Connection do
       end
     end
 
-    describe '#cancel' do
-      it_should_behave_like 'API connection' do
+    describe "#cancel" do
+      it_should_behave_like "API connection" do
         let(:api_path) { suretax_cancel_path }
         let(:request_body) { cancel_request_body }
         let(:response) { connection.cancel(body: request_body) }
@@ -37,13 +35,11 @@ describe Suretax::Connection do
         end
       end
     end
-
   end
 
-  context 'using v03 of the API' do
-
-    describe '#post' do
-      it_should_behave_like 'API connection' do
+  context "using v03 of the API" do
+    describe "#post" do
+      it_should_behave_like "API connection" do
         let(:api_path) { suretax_post_path }
         let(:request_body) { valid_encoded_test_request_body }
         let(:response) { connection.post(body: request_body) }
@@ -58,8 +54,8 @@ describe Suretax::Connection do
       end
     end
 
-    describe '#cancel' do
-      it_should_behave_like 'API connection' do
+    describe "#cancel" do
+      it_should_behave_like "API connection" do
         let(:api_path) { suretax_cancel_path }
         let(:request_body) { cancel_request_body }
         let(:response) { connection.cancel(body: request_body) }

data/spec/lib/suretax/response_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Suretax::Response do
   let(:api_response_class) {
-    Struct.new(:status,:body,:success) do
+    Struct.new(:status, :body, :success) do
       def success?
         success
       end
@@ -21,17 +21,16 @@ describe Suretax::Response do
 
   let(:client_response) { Suretax::Response.new(api_response_object) }
 
-  context 'when posting is successful' do
-
+  context "when posting is successful" do
     let(:response_body) do
       suretax_wrap_response(valid_test_response_body.to_json)
     end
 
-    it 'has a body' do
+    it "has a body" do
       expect(client_response.body).to be_instance_of(Hash)
     end
 
-    it 'has a status' do
+    it "has a status" do
       expect(client_response.status).to eql(200)
     end
 
@@ -39,18 +38,17 @@ describe Suretax::Response do
       expect(client_response).to be_success
     end
 
-    it 'has a response object' do
+    it "has a response object" do
       client_response.response.should respond_to(:status, :body)
     end
 
-    it 'should return the correct response body' do
-      expect(client_response.body['ResponseCode']).to eql('9999')
-      expect(client_response.body['TotalTax']).to eql('1.394490')
+    it "should return the correct response body" do
+      expect(client_response.body["ResponseCode"]).to eql("9999")
+      expect(client_response.body["TotalTax"]).to eql("1.394490")
     end
   end
 
-
-  context 'when posting is partially successful' do
+  context "when posting is partially successful" do
     let(:response_body) do
       suretax_wrap_response(success_with_item_errors.to_json)
     end
@@ -59,11 +57,11 @@ describe Suretax::Response do
       api_response_object.success = false
     end
 
-    it 'has a body' do
+    it "has a body" do
       expect(client_response.body).to be_instance_of(Hash)
     end
 
-    it 'responds with a 409' do
+    it "responds with a 409" do
       expect(client_response.status).to eql(409)
     end
 
@@ -71,18 +69,17 @@ describe Suretax::Response do
       expect(client_response).to_not be_success
     end
 
-    it 'has a response object' do
+    it "has a response object" do
       client_response.response.should respond_to(:status, :body)
     end
 
-    it 'should return the correct response body' do
-      expect(client_response.body['ResponseCode']).to eql('9001')
-      expect(client_response.body['TotalTax']).to eql('26.53')
+    it "should return the correct response body" do
+      expect(client_response.body["ResponseCode"]).to eql("9001")
+      expect(client_response.body["TotalTax"]).to eql("26.53")
     end
   end
 
-  context 'when posting fails' do
-
+  context "when posting fails" do
     let(:response_body) do
       suretax_wrap_response(post_failed_response_body.to_json)
     end
@@ -91,11 +88,11 @@ describe Suretax::Response do
       api_response_object.success = false
     end
 
-    it 'has a body' do
+    it "has a body" do
       expect(client_response.body).to be_instance_of(Hash)
     end
 
-    it 'responds with a 400' do
+    it "responds with a 400" do
       expect(client_response.status).to eql(400)
     end
 
@@ -103,29 +100,28 @@ describe Suretax::Response do
       expect(client_response).to_not be_success
     end
 
-    it 'has a response object' do
+    it "has a response object" do
       client_response.response.should respond_to(:status, :body)
     end
 
-    it 'should return the correct response body' do
-      expect(client_response.body['ResponseCode']).to eql('1101')
-      expect(client_response.body['TotalTax']).to be_nil
+    it "should return the correct response body" do
+      expect(client_response.body["ResponseCode"]).to eql("1101")
+      expect(client_response.body["TotalTax"]).to be_nil
     end
   end
 
-  context 'when posting fails from a malformed request' do
-
+  context "when posting fails from a malformed request" do
     let(:response_body) { suretax_wrap_response("invalid request") }
 
     before do
       api_response_object.success = true
     end
 
-    it 'has a body' do
-      expect(client_response.body).to eql('invalid request')
+    it "has a body" do
+      expect(client_response.body).to eql("invalid request")
     end
 
-    it 'responds with a 409' do
+    it "responds with a 409" do
       expect(client_response.status).to eql(400)
     end
 

data/spec/spec_helper.rb

@@ -1,39 +1,38 @@
-require 'dotenv'  # First line of spec_helper
+require "dotenv"  # First line of spec_helper
 Dotenv.load       # Second line of spec_helper
 
-require 'simplecov'
+require "simplecov"
 SimpleCov.start do
-  add_filter '/spec/'
-  add_filter '/.bundle/'
+  add_filter "/spec/"
+  add_filter "/.bundle/"
 end
 
-require 'pry'
-require 'rspec'
-require 'rspec/its'
-require 'suretax'
-require 'awesome_print'
-require 'webmock/rspec'
+require "pry"
+require "rspec"
+require "rspec/its"
+require "suretax"
+require "awesome_print"
+require "webmock/rspec"
 
 # Load support files
-Dir[File.expand_path(File.dirname(__FILE__) + '/support/**/*.rb')].each do
-  |support_file| require support_file
+Dir[File.expand_path(File.dirname(__FILE__) + "/support/**/*.rb")].each do |support_file|
+  require support_file
 end
 
 RSpec.configure do |config|
-
   config.before(:each) do
     Suretax.configure do |c|
-      c.validation_key  = ENV['SURETAX_VALIDATION_KEY']
-      c.client_number   = ENV['SURETAX_CLIENT_NUMBER']
+      c.validation_key  = ENV["SURETAX_VALIDATION_KEY"]
+      c.client_number   = ENV["SURETAX_CLIENT_NUMBER"]
     end
   end
 
   config.expect_with :rspec do |c|
-    c.syntax = [:should, :expect]
+    c.syntax = %i[should expect]
   end
 
   config.mock_with :rspec do |c|
-    c.syntax = [:should, :expect]
+    c.syntax = %i[should expect]
   end
 end
 

data/spec/support/cancellation_helper.rb

@@ -1,5 +1,4 @@
 module CancellationSpecHelper
-
   def cancel_response_body
     {
       "Successful" => "Y",

data/spec/support/connection_shared_examples.rb

@@ -1,7 +1,7 @@
-require 'spec_helper'
+require "spec_helper"
 
-shared_examples_for 'API connection' do
-  context 'with a valid request' do
+shared_examples_for "API connection" do
+  context "with a valid request" do
     before do
       stub_request(:post, "#{suretax_url}#{api_path}").to_return(
         status: 200,
@@ -9,17 +9,16 @@ shared_examples_for 'API connection' do
       )
     end
 
-    it 'should be successful' do
+    it "should be successful" do
       expect(response).to be_success
     end
 
-    it 'should have a urlencode header' do
-      expect(connection.headers['Content-Type']).to include('application/x-www-form-urlencoded')
+    it "should have a urlencode header" do
+      expect(connection.headers["Content-Type"]).to include("application/x-www-form-urlencoded")
     end
   end
 
-  context 'with an invalid request' do
-
+  context "with an invalid request" do
     let(:request_body) { {} }
 
     before do
@@ -29,9 +28,8 @@ shared_examples_for 'API connection' do
       )
     end
 
-    it 'should not be successful' do
+    it "should not be successful" do
       expect(response).to_not be_success
     end
   end
 end
-

data/spec/support/request_helper.rb

@@ -1,7 +1,6 @@
 # encoding: utf-8
 
 module RequestSpecHelper
-
   def valid_encoded_test_request_body
     {
       "ClientNumber"             => suretax_client_number,
@@ -38,9 +37,9 @@ module RequestSpecHelper
           "TransTypeCode"        => "010101",
           "SalesTypeCode"        => "R",
           "RegulatoryCode"       => "99",
-          "TaxExemptionCodeList" => [
-            "00",
-            "00"
+          "TaxExemptionCodeList" => %w[
+            00
+            00
           ],
           "UDF"                   => "",
           "ShipFromZipCode"       => "",
@@ -57,7 +56,7 @@ module RequestSpecHelper
           "MailOrder"             => "1",
           "CommonCarrier"         => "1",
           "OriginCountryCode"     => "",
-          "DestCountryCode"       => "",
+          "DestCountryCode"       => ""
         }
       ]
     }
@@ -71,7 +70,7 @@ module RequestSpecHelper
       "ItemMessages"   => [],
       "ClientTracking" => "track",
       "TotalTax"       => "1.394490",
-      "TransId"        => 2664495,
+      "TransId"        => 2_664_495,
       "GroupList"      => [
         {
           "StateCode"      => "CA",
@@ -132,10 +131,10 @@ module RequestSpecHelper
       "ItemMessages" => [],
       "ClientTracking" => "track",
       "TotalTax" => "1.394490",
-      "TransId" => 2872159,
+      "TransId" => 2_872_159,
       "GroupList" => [
         {
-        "LineNumber" => "1",
+          "LineNumber" => "1",
         "StateCode" => "CA",
         "InvoiceNumber" => "1",
         "CustomerNumber" => "000000007",
@@ -243,7 +242,8 @@ module RequestSpecHelper
             "PercentTaxable" => 1.0,
             "FeeRate" => 0.0,
             "TaxOnTax" => 0.0
-          }]
+          }
+        ]
         }
       ]
     }
@@ -257,7 +257,7 @@ module RequestSpecHelper
       "ItemMessages"=>[],
       "ClientTracking"=>nil,
       "TotalTax"=>nil,
-      "TransId"=>2667859,
+      "TransId"=>2_667_859,
       "GroupList"=>[]
     }
   end
@@ -306,7 +306,7 @@ module RequestSpecHelper
 
   def suretax_valid_request_params
     {
-       business_unit: "testing",
+      business_unit: "testing",
        client_number: suretax_client_number,
        client_tracking: "track",
        data_month: "7",
@@ -317,7 +317,7 @@ module RequestSpecHelper
        return_file_code: "0",
        total_revenue: "40",
        validation_key: suretax_key,
-       items: [ suretax_valid_request_item_params ]
+       items: [suretax_valid_request_item_params]
     }
   end
 
@@ -343,7 +343,7 @@ module RequestSpecHelper
       unit_type: nil,
       units: "1",
       zipcode: "",
-      tax_exemption_codes: [ "00", "00" ],
+      tax_exemption_codes: %w[00 00],
       aux_revenue: nil,
       aux_revenue_type: nil,
       ship_from_pob: nil,
@@ -351,5 +351,4 @@ module RequestSpecHelper
       common_carrier: nil
     }
   end
-
 end

data/spec/support/suretax_helper.rb

@@ -1,7 +1,6 @@
 module SuretaxSpecHelper
-
   def suretax_key
-    ENV['SURETAX_VALIDATION_KEY']
+    ENV["SURETAX_VALIDATION_KEY"]
   end
 
   def suretax_url
@@ -9,7 +8,7 @@ module SuretaxSpecHelper
   end
 
   def suretax_client_number
-    ENV['SURETAX_CLIENT_NUMBER']
+    ENV["SURETAX_CLIENT_NUMBER"]
   end
 
   def suretax_post_path
@@ -23,5 +22,4 @@ module SuretaxSpecHelper
   def suretax_wrap_response(json_string)
     "<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<string xmlns=\"http://tempuri.org/\">" + json_string + "</string>"
   end
-
 end

data/spec/support/validations_shared_examples.rb

@@ -1,28 +1,28 @@
-require 'spec_helper'
+require "spec_helper"
 
-shared_examples_for 'optional phone number' do
-  it 'can be blank' do
-    request_item.send("#{subject}=",nil)
+shared_examples_for "optional phone number" do
+  it "can be blank" do
+    request_item.send("#{subject}=", nil)
 
     expect(request_item.errors.any?).to eq false
   end
 
-  it 'must be numeric' do
-    request_item.send("#{subject}=",'abcdefghij')
+  it "must be numeric" do
+    request_item.send("#{subject}=", "abcdefghij")
 
     expect(request_item.errors.any?).to eq true
-    expect(request_item.errors.messages).to eq [%Q{Invalid #{subject}: abcdefghij}]
+    expect(request_item.errors.messages).to eq [%(Invalid #{subject}: abcdefghij)]
   end
 
-  it 'must ten digits' do
-    request_item.send("#{subject}=",'1' * 11)
+  it "must ten digits" do
+    request_item.send("#{subject}=", "1" * 11)
 
     expect(request_item.errors.any?).to eq true
-    expect(request_item.errors.messages).to eq [%Q{Invalid #{subject}: #{'1' * 11}}]
+    expect(request_item.errors.messages).to eq [%(Invalid #{subject}: #{'1' * 11})]
 
-    request_item.send("#{subject}=",'1' * 9)
+    request_item.send("#{subject}=", "1" * 9)
 
     expect(request_item.errors.any?).to eq true
-    expect(request_item.errors.messages).to eq [%Q{Invalid #{subject}: #{'1' * 9}}]
+    expect(request_item.errors.messages).to eq [%(Invalid #{subject}: #{'1' * 9})]
   end
 end