suretax 0.2.3 → 1.0.0

data/spec/lib/suretax/api/response_spec.rb

@@ -1,109 +1,107 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Suretax::Api::Response do
-
   let(:api_response) { Suretax::Api::Response.new(response_body) }
 
-
-  context 'for a normal post request' do
-    context 'with a successful response' do
+  context "for a normal post request" do
+    context "with a successful response" do
       let(:response_body) { valid_test_response_body }
 
-      it 'should return the API status code' do
-        expect(api_response.status).to eql('9999')
+      it "should return the API status code" do
+        expect(api_response.status).to eql("9999")
       end
 
-      it 'should be successful' do
+      it "should be successful" do
         expect(api_response).to be_success
       end
 
-      it 'should not have item errors' do
+      it "should not have item errors" do
         expect(api_response).not_to be_item_errors
       end
 
       it 'should have a message of "Success"' do
-        expect(api_response.message).to eql('Success')
+        expect(api_response.message).to eql("Success")
       end
 
-      it 'should have the correct total tax' do
+      it "should have the correct total tax" do
         expect(api_response.total_tax.to_f).to eql(1.394490)
       end
 
-      it 'should have a transaction id' do
-        expect(api_response.transaction).to eql('2664495')
+      it "should have a transaction id" do
+        expect(api_response.transaction).to eql("2664495")
       end
 
-      context 'invoice groups' do
-        it 'should be the correct number' do
+      context "invoice groups" do
+        it "should be the correct number" do
           expect(api_response.groups.count).to eql(1)
         end
 
-        it 'should respond to #invoice' do
+        it "should respond to #invoice" do
           expect(api_response.groups.first).to respond_to(:invoice)
         end
       end
     end
 
-    context 'with a partially successful response' do
+    context "with a partially successful response" do
       let(:response_body) { success_with_item_errors }
 
-      describe '#status' do
-        it 'should return the API status code' do
-          expect(api_response.status).to eql('9001')
+      describe "#status" do
+        it "should return the API status code" do
+          expect(api_response.status).to eql("9001")
         end
       end
 
-      describe '#success?' do
-        it 'should be true' do
+      describe "#success?" do
+        it "should be true" do
           expect(api_response).to be_success
         end
       end
 
       describe "#item_errors?" do
-        it 'should be true' do
+        it "should be true" do
           expect(api_response).to be_item_errors
         end
       end
 
       describe "#item_messages" do
-        it 'should be the correct number' do
+        it "should be the correct number" do
           expect(api_response.item_messages.size).to eql(1)
         end
 
-        it 'should response to #message' do
+        it "should response to #message" do
           expect(api_response.item_messages.first).to respond_to(:message)
         end
       end
 
-      describe '#message' do
+      describe "#message" do
         it 'should start with "Failure"' do
           expect(api_response.message).to match(/\ASuccess with item errors/i)
         end
       end
     end
 
-    context 'with a failure response' do
+    context "with a failure response" do
       let(:response_body) { post_failed_response_body }
 
-      describe '#status' do
-        it 'should return the API status code' do
-          expect(api_response.status).to eql('1101')
+      describe "#status" do
+        it "should return the API status code" do
+          expect(api_response.status).to eql("1101")
         end
       end
 
-      describe '#success?' do
-        it 'should be false' do
+      describe "#success?" do
+        it "should be false" do
           expect(api_response.success?).to eql false
         end
       end
 
       describe "#item_errors?" do
-        it 'should be false' do
+        it "should be false" do
           expect(api_response).not_to be_item_errors
         end
       end
 
-      describe '#message' do
+      describe "#message" do
         it 'should start with "Failure"' do
           expect(api_response.message).to match(/\AFailure/)
         end
@@ -111,40 +109,39 @@ describe Suretax::Api::Response do
     end
   end
 
-  context 'for a cancel post request' do
-    context 'with a successful response' do
+  context "for a cancel post request" do
+    context "with a successful response" do
       let(:response_body) { cancel_response_body }
 
-      it 'should return the API status code' do
-        expect(api_response.status).to eql('9999')
+      it "should return the API status code" do
+        expect(api_response.status).to eql("9999")
       end
 
-      it 'should be successful' do
+      it "should be successful" do
         expect(api_response).to be_success
       end
 
       it 'should have a message of "Success"' do
-        expect(api_response.message).to eql('Success')
+        expect(api_response.message).to eql("Success")
       end
 
-      it 'should have a transaction id' do
-        expect(api_response.transaction).to eql('0')
+      it "should have a transaction id" do
+        expect(api_response.transaction).to eql("0")
       end
 
-      it 'should have the client tracking code set' do
-        expect(api_response.client_tracking).to eql('test')
+      it "should have the client tracking code set" do
+        expect(api_response.client_tracking).to eql("test")
       end
     end
 
-    context 'with a failed request' do
-
+    context "with a failed request" do
       let(:response_body) { cancel_failed_response_body }
 
-      it 'should return the API status code' do
+      it "should return the API status code" do
         expect(api_response.status).to be_nil
       end
 
-      it 'should be successful' do
+      it "should be successful" do
         expect(api_response).to_not be_success
       end
 
@@ -152,14 +149,13 @@ describe Suretax::Api::Response do
         expect(api_response.message).to be_nil
       end
 
-      it 'should have a transaction id' do
-        expect(api_response.transaction).to eql('0')
+      it "should have a transaction id" do
+        expect(api_response.transaction).to eql("0")
       end
 
-      it 'should have the client tracking code set' do
+      it "should have the client tracking code set" do
         expect(api_response.client_tracking).to be_nil
       end
     end
   end
-
 end

data/spec/lib/suretax/api/tax_amount_spec.rb

@@ -1,37 +1,37 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Suretax::Api::Amount do
-  let(:tax_amount) { Suretax::Api::Amount.new('1.394490') }
+  let(:tax_amount) { Suretax::Api::Amount.new("1.394490") }
 
   let(:params) {
     {
-      amount: 1394490,
+      amount: 1_394_490,
       precision: 6,
-      divisor: 1000000
+      divisor: 1_000_000
     }
   }
 
-  it 'should return a Float for #to_f' do
+  it "should return a Float for #to_f" do
     expect(tax_amount.to_f).to eql(1.394490)
   end
 
-  it 'should return a String for #to_s' do
-    expect(tax_amount.to_s).to eql('1.394490')
+  it "should return a String for #to_s" do
+    expect(tax_amount.to_s).to eql("1.394490")
   end
 
-  it 'should provide an integer version via #to_i' do
-    expect(tax_amount.to_i).to eql(1394490)
+  it "should provide an integer version via #to_i" do
+    expect(tax_amount.to_i).to eql(1_394_490)
   end
 
-  it 'should provide a hard currency value via #cents' do
+  it "should provide a hard currency value via #cents" do
     expect(tax_amount.cents).to eql(139)
   end
 
-  it 'should give the number of decimal places via #precision' do
+  it "should give the number of decimal places via #precision" do
     expect(tax_amount.precision).to eql(6)
   end
 
-  it 'should give integer parameters for calculating the Float via #params' do
+  it "should give integer parameters for calculating the Float via #params" do
     expect(tax_amount.params).to eql(params)
   end
 end

data/spec/lib/suretax/api/tax_spec.rb

@@ -1,70 +1,68 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Suretax::Api::Tax do
-
   let(:tax) { Suretax::Api::Tax.new(tax_params) }
 
-  context 'with an API v01 response' do
-    let(:tax_params) { valid_test_response_body['GroupList'].first['TaxList'].first }
+  context "with an API v01 response" do
+    let(:tax_params) { valid_test_response_body["GroupList"].first["TaxList"].first }
 
-    it 'should have a code' do
-      expect(tax.code).to eql('106')
+    it "should have a code" do
+      expect(tax.code).to eql("106")
     end
 
-    it 'should have a description' do
-      expect(tax.description).to eql('CA EMERG TEL. USERS SURCHARGE')
+    it "should have a description" do
+      expect(tax.description).to eql("CA EMERG TEL. USERS SURCHARGE")
     end
 
-    it 'should have an amount' do
+    it "should have an amount" do
       expect(tax.amount.to_f).to eql(0.200760)
     end
-
   end
 
-  context 'with an API v03 response' do
-    let(:tax_params) { valid_v03_response_body['GroupList'].first['TaxList'].first }
+  context "with an API v03 response" do
+    let(:tax_params) { valid_v03_response_body["GroupList"].first["TaxList"].first }
 
-    it 'should have a code' do
-      expect(tax.code).to eql('106')
+    it "should have a code" do
+      expect(tax.code).to eql("106")
     end
 
-    it 'should have a description' do
-      expect(tax.description).to eql('CA EMERG TEL. USERS SURCHARGE')
+    it "should have a description" do
+      expect(tax.description).to eql("CA EMERG TEL. USERS SURCHARGE")
     end
 
-    it 'should have an amount' do
+    it "should have an amount" do
       expect(tax.amount.to_f).to eql(0.200760)
     end
 
-    it 'should have a revenue code' do
-      expect(tax.revenue).to eql('40')
+    it "should have a revenue code" do
+      expect(tax.revenue).to eql("40")
     end
 
-    it 'should have a county name' do
-      expect(tax.county).to eql('SAN DIEGO')
+    it "should have a county name" do
+      expect(tax.county).to eql("SAN DIEGO")
     end
 
-    it 'should have a city name' do
-      expect(tax.city).to eql('SAN DIEGO')
+    it "should have a city name" do
+      expect(tax.city).to eql("SAN DIEGO")
     end
 
-    it 'should have a tax rate' do
+    it "should have a tax rate" do
       expect(tax.rate.to_f).to eql(0.005)
     end
 
-    it 'should have a percent taxable' do
+    it "should have a percent taxable" do
       expect(tax.taxable.to_f).to eql(1.0)
     end
 
-    it 'should have a fee rate' do
+    it "should have a fee rate" do
       expect(tax.fee_rate.to_f).to eql 0.0
     end
 
-    it 'should have a tax on tax' do
+    it "should have a tax on tax" do
       expect(tax.tax_on_tax.to_f).to eql 0.5
     end
 
-    it 'should have a revenue base' do
+    it "should have a revenue base" do
       expect(tax.revenue_base.to_f).to eql 40.0
     end
   end

data/spec/lib/suretax/configuration_spec.rb

@@ -1,17 +1,15 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Suretax do
-
   let(:config) { Suretax.configuration }
-  let(:url)         { 'http://test.dev' }
-  let(:test_host)   { 'https://testapi.taxrating.net' }
+  let(:url)         { "http://test.dev" }
+  let(:test_host)   { "https://testapi.taxrating.net" }
 
   describe ".configure" do
-
-    let(:key)         { 'xxxxxxxx' }
-    let(:client)      { '9999999999' }
-    let(:post_path)   { '/Services/V04/SureTax.asmx/PostRequest' }
-    let(:cancel_path) { '/Services/V01/SureTax.asmx/CancelPostRequest' }
+    let(:key)         { "xxxxxxxx" }
+    let(:client)      { "9999999999" }
+    let(:post_path)   { "/Services/V04/SureTax.asmx/PostRequest" }
+    let(:cancel_path) { "/Services/V01/SureTax.asmx/CancelPostRequest" }
 
     before do
       Suretax.configure do |c|
@@ -21,27 +19,27 @@ describe Suretax do
       end
     end
 
-    it 'should allow me to set the validation key' do
+    it "should allow me to set the validation key" do
       expect(config.validation_key).to eql key
     end
 
-    it 'should allow me to set the API server base url' do
+    it "should allow me to set the API server base url" do
       expect(config.base_url).to eql test_host
     end
 
-    it 'should allow me to set the client number' do
+    it "should allow me to set the client number" do
       expect(config.client_number).to eql client
     end
 
-    it 'should allow me to set the default post path' do
+    it "should allow me to set the default post path" do
       expect(config.request_path).to eql post_path
     end
 
-    it 'should allow me to set the default cancel path' do
+    it "should allow me to set the default cancel path" do
       expect(config.cancel_path).to eql cancel_path
     end
 
-    it 'should default test mode' do
+    it "should default test mode" do
       expect(config.test?).to eql true
     end
 
@@ -49,7 +47,7 @@ describe Suretax do
       expect(config.request_version).to eql 4
     end
 
-    context 'when setting the mode' do
+    context "when setting the mode" do
       around(:each) do |test|
         original_url = Suretax.configuration.base_url
         Suretax.configuration.base_url = url
@@ -57,16 +55,16 @@ describe Suretax do
         Suretax.configuration.base_url = original_url
       end
 
-      it 'should allow me to select non-test mode' do
+      it "should allow me to select non-test mode" do
         expect(config.test?).to eql false
       end
     end
   end
 
-  describe 'production?' do
+  describe "production?" do
     subject { Suretax.configuration.test? }
 
-    context 'when using the test host' do
+    context "when using the test host" do
       around(:each) do |test|
         original_url = Suretax.configuration.base_url
         Suretax.configuration.base_url = test_host
@@ -76,7 +74,7 @@ describe Suretax do
       it { should eql true }
     end
 
-    context 'when using another host' do
+    context "when using another host" do
       around(:each) do |test|
         original_url = Suretax.configuration.base_url
         Suretax.configuration.base_url = url
@@ -87,16 +85,15 @@ describe Suretax do
     end
   end
 
-  describe 'loading from the app environment' do
-    it 'should allow me to set the validation key' do
+  describe "loading from the app environment" do
+    it "should allow me to set the validation key" do
       expect(suretax_key).to_not match(/\A\s*\z/)
       expect(config.validation_key).to include(suretax_key)
     end
 
-    it 'should allow me to set the API server base url' do
+    it "should allow me to set the API server base url" do
       expect(suretax_url).to_not match(/\A\s*\z/)
       expect(config.base_url).to include(suretax_url)
     end
   end
-
 end