suretax 0.2.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8eea17484cffad2ec21fedb1aaea5e82c30f11d
-  data.tar.gz: 4b09457c6438ca37dbdbaf17ae748571e329af61
+  metadata.gz: 5eaeb9eb9a7c58e6f33b2d62dc8b5263dd04031d
+  data.tar.gz: b3999b6f2efa44afafca10ee867ec26ceb9fb3d6
 SHA512:
-  metadata.gz: bd55c15f9346a5b0641b42de1b65fd13f2c54d0c6e1744426d15d55061ea77cd81487ccffd1e071c65cf3b40d8ebe54e46825f8b2d911d494ac5e4edb8eca193
-  data.tar.gz: 775f5acfc58fe56cfedb10779d05c84d20dbc3a48a3404b912660ff2232812c8af843d051258f731b0c1d4f2558b3958f0d9343b1fdcf76e5f0699c34e9985bc
+  metadata.gz: 4f1239082346ee9d24c8c636f83af1af1393aaa0172a99ecc4dbc35618e36e5d606110f03109df212da538bfe01629df6971fdf94ce008183a2b55cbe72bf1ce
+  data.tar.gz: 3256264cb0c9f55c5d4cc43e2248e29adbedef90efd3514ceab70d00fc3dc48e5028ed9e2a6f84fdd6b3e0196eb85f26aa187cbdc94909b7aed8d6c0c4766e05

data/.env.example

@@ -0,0 +1,4 @@
+SURETAX_VALIDATION_KEY=885aa2c6-1a61-4ec6-9aa6-296120572b5e
+SURETAX_CLIENT_NUMBER=000000123
+SURETAX_BASE_URL=https://testapi.taxrating.net
+SURETAX_REQUEST_VERSION=02

data/.rubocop.yml

@@ -0,0 +1,111 @@
+# This is the default configuration file. Enabling and disabling is configured
+# in separate files. This file adds all other parameters apart from Enabled.
+
+AllCops:
+  Include:
+    - "**/*.gemspec"
+    - "**/Rakefile"
+  Exclude:
+    - vendor/**/*
+    - db/**/*
+  TargetRubyVersion: 2.3
+
+Rails:
+  Enabled: true
+
+Style/CaseIndentation:
+  Enabled: false
+
+Style/Lambda:
+  Enabled: false
+
+Style/ConditionalAssignment:
+  Enabled: false
+
+Performance/Casecmp:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+LineLength:
+  Description: "Limit lines to 100 characters."
+  Max: 100
+  Enabled: true
+
+AlignHash:
+  Description: Align the elements of a hash literal if they span more than one line.
+  EnforcedLastArgumentHashStyle: ignore_implicit
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
+  Enabled: false
+
+AlignParameters:
+  EnforcedStyle: with_first_parameter
+  SupportedStyles:
+    - with_first_parameter
+    - with_fixed_indentation
+  Enabled: false
+
+Documentation:
+  Description: "Document classes and non-namespace modules."
+  Enabled: false
+
+AndOr:
+  Description: "Use &&/|| instead of and/or."
+  Enabled: false
+
+EndAlignment:
+  Description: "Align ends correctly."
+  Enabled: true
+
+CollectionMethods:
+  Description: "Preferred collection methods."
+  Enabled: true
+  PreferredMethods:
+    collect:  "map"
+    collect!: "map!"
+    reduce:   "inject"
+    detect:   "find"
+    find_all: "select"
+
+AssignmentInCondition:
+  Description: "Don't use assignment in conditions."
+  Enabled: false
+
+DoubleNegation:
+  Description: "Checks for uses of double negation (!!)."
+  Enabled: false
+
+Style/BlockDelimiters:
+  Description: >-
+                Avoid using {...} for multi-line blocks (multiline chaining is
+                always ugly).
+                Prefer {...} over do...end for single-line blocks.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#single-line-blocks'
+  Enabled: false
+
+SpaceBeforeFirstArg:
+  Description: "Checks that exactly one space is used between a method name and the first argument for method calls without parentheses."
+  Enabled: false
+
+DotPosition:
+  Description: "Checks the position of the dot in multi-line method calls."
+  Enabled: false
+
+ClassAndModuleChildren:
+  Description: "Checks style of children classes and modules."
+  Enabled: false
+
+RescueModifier:
+  Description: "Avoid using rescue in modifier form"
+  Enabled: false
+
+StringLiterals:
+  EnforcedStyle: double_quotes
+
+StringLiteralsInInterpolation:
+  Enabled: false

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in suretax.gemspec
 gemspec

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    suretax (0.2.1)
+    suretax (0.2.3)
       excon
       monetize
-      money (~> 6.5.1)
+      money (~> 6.9.0)
 
 GEM
   remote: https://rubygems.org/
@@ -17,13 +17,13 @@ GEM
     diff-lcs (1.2.5)
     docile (1.1.5)
     dotenv (1.0.2)
-    excon (0.54.0)
-    i18n (0.7.0)
+    excon (0.56.0)
+    i18n (0.8.4)
     method_source (0.8.2)
-    monetize (1.3.0)
-      money (~> 6.5.0)
-    money (6.5.1)
-      i18n (>= 0.6.4, <= 0.7.0)
+    monetize (1.7.0)
+      money (~> 6.9)
+    money (6.9.0)
+      i18n (>= 0.6.4, < 0.9)
     multi_json (1.10.1)
     pry (0.10.1)
       coderay (~> 1.1.0)
@@ -72,4 +72,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   1.13.6
+   1.15.1

data/lib/suretax.rb

@@ -11,7 +11,6 @@ require "suretax/api"
 require "money"
 
 module Suretax
-
   class << self
     attr_accessor :configuration
 

data/lib/suretax/api.rb

@@ -1,7 +1,7 @@
-require 'suretax/api/response'
-require 'suretax/api/request'
-require 'suretax/api/request_item'
-require 'suretax/api/cancel_request'
-require 'suretax/api/group'
-require 'suretax/api/tax'
-require 'suretax/api/tax_amount'
+require "suretax/api/response"
+require "suretax/api/request"
+require "suretax/api/request_item"
+require "suretax/api/cancel_request"
+require "suretax/api/group"
+require "suretax/api/tax"
+require "suretax/api/tax_amount"

data/lib/suretax/api/cancel_request.rb

@@ -17,7 +17,7 @@ module Suretax
                                             configuration.validation_key)
 
         options.each_pair do |key, value|
-          send("#{key.to_s}=", value.to_s)
+          send("#{key}=", value.to_s)
         end
       end
 
@@ -31,21 +31,21 @@ module Suretax
 
       def params
         {
-          'ClientNumber'   => client_number,
-          'ClientTracking' => client_tracking,
-          'TransId'        => transaction,
-          'ValidationKey'  => validation_key
+          "ClientNumber"   => client_number,
+          "ClientTracking" => client_tracking,
+          "TransId"        => transaction,
+          "ValidationKey"  => validation_key
         }
       end
 
       private
 
       def log_request
-        logger.info "\nSureTax Cancellation sent:\n#{params.inspect}" if logger
+        logger&.info "\nSureTax Cancellation sent:\n#{params.inspect}"
       end
 
       def log_response(response)
-        logger.info("\nSureTax Cancellation resp:\n#{response.inspect}") if logger
+        logger&.info("\nSureTax Cancellation resp:\n#{response.inspect}")
       end
 
       def logger

data/lib/suretax/api/group.rb

@@ -4,13 +4,12 @@ module Suretax
       attr_reader :state, :customer, :invoice, :taxes, :line
 
       def initialize(response_params)
-        @state = response_params.fetch('StateCode')
-        @invoice = response_params.fetch('InvoiceNumber')
-        @line = response_params['LineNumber']
-        @customer = response_params.fetch('CustomerNumber')
-        @taxes = response_params.fetch('TaxList').map { |tax| Tax.new(tax) }
+        @state = response_params.fetch("StateCode")
+        @invoice = response_params.fetch("InvoiceNumber")
+        @line = response_params["LineNumber"]
+        @customer = response_params.fetch("CustomerNumber")
+        @taxes = response_params.fetch("TaxList").map { |tax| Tax.new(tax) }
       end
-
     end
   end
 end

data/lib/suretax/api/item_message.rb

@@ -4,9 +4,9 @@ module Suretax
       attr_reader :line_number, :response_code, :message
 
       def initialize(response_params)
-        @line_number = response_params.fetch('LineNumber')
-        @response_code = response_params.fetch('ResponseCode')
-        @message = response_params.fetch('Message')
+        @line_number = response_params.fetch("LineNumber")
+        @response_code = response_params.fetch("ResponseCode")
+        @message = response_params.fetch("Message")
       end
     end
   end

data/lib/suretax/api/request.rb

@@ -34,14 +34,14 @@ module Suretax
                :items
 
       def initialize(options = {})
-        self.return_file_code = '0'
+        self.return_file_code = "0"
         self.client_number    = options.delete(:client_number)  || configuration.client_number
         self.validation_key   = options.delete(:validation_key) || configuration.validation_key
 
         default_data_date(options)
 
-        options.each_pair do |key,value|
-          self.send("#{key.to_s}=", value.to_s)
+        options.each_pair do |key, value|
+          send("#{key}=", value.to_s)
         end
 
         initialize_items(options)
@@ -60,12 +60,12 @@ module Suretax
       end
 
       def valid?
-        !errors.any?
+        errors.none?
       end
 
       def rollback
         if response
-          CancelRequest.new(transaction: response.transaction, 
+          CancelRequest.new(transaction: response.transaction,
             client_number: client_number, validation_key: validation_key,
             client_tracking: client_tracking).submit
         end
@@ -74,62 +74,62 @@ module Suretax
       def params
         {
           "ClientNumber"             => client_number,
-          "BusinessUnit"             => business_unit || '',
+          "BusinessUnit"             => business_unit || "",
           "ValidationKey"            => validation_key,
           "DataYear"                 => data_year,
           "DataMonth"                => data_month,
           "TotalRevenue"             => total_revenue.to_f,
           "ReturnFileCode"           => return_file_code,
-          "ClientTracking"           => client_tracking || '',
+          "ClientTracking"           => client_tracking || "",
           "IndustryExemption"        => industry_exemption,
           "ResponseType"             => response_type,
           "ResponseGroup"            => response_group,
           "STAN"                     => stan || "",
-          "ItemList"                 => items.map { |item| item.params }
+          "ItemList"                 => items.map(&:params)
         }
       end
 
       private
 
-        def default_data_date(options)
-          max_date = configuration.test? ? Date.today.prev_month : Date.today
+      def default_data_date(options)
+        max_date = configuration.test? ? Date.today.prev_month : Date.today
 
-          requested_date = begin
-                             Date.new(options.delete(:data_year).to_i, options.delete(:data_month).to_i, 1)
-                           rescue
-                             max_date
-                           end
+        requested_date = begin
+                           Date.new(options.delete(:data_year).to_i, options.delete(:data_month).to_i, 1)
+                         rescue
+                           max_date
+                         end
 
-          data_date = [requested_date, max_date].min
+        data_date = [requested_date, max_date].min
 
-          self.data_month = data_date.strftime('%m')
-          self.data_year  = data_date.strftime('%Y')
-        end
+        self.data_month = data_date.strftime("%m")
+        self.data_year  = data_date.strftime("%Y")
+      end
 
-        def initialize_items(options)
-          self.items = []
-          if options[:items].respond_to?(:each)
-            options[:items].each do |item_args|
-              self.items << RequestItem.new(item_args)
-            end
+      def initialize_items(options)
+        self.items = []
+        if options[:items].respond_to?(:each)
+          options[:items].each do |item_args|
+            items << RequestItem.new(item_args)
           end
         end
+      end
 
-        def log_request
-          logger.info "\nSureTax Request sent:\n#{params.inspect}" if logger
-        end
+      def log_request
+        logger&.info "\nSureTax Request sent:\n#{params.inspect}"
+      end
 
-        def logger
-          configuration.logger
-        end
+      def logger
+        configuration.logger
+      end
 
-        def configuration
-          Suretax.configuration
-        end
+      def configuration
+        Suretax.configuration
+      end
 
-        def connection
-          @connection ||= Connection.new
-        end
+      def connection
+        @connection ||= Connection.new
+      end
     end
   end
 end

data/lib/suretax/api/request_item.rb

@@ -1,8 +1,6 @@
 module Suretax
   module Api
-
     class RequestItem
-
       include Suretax::Concerns::Validatable
 
       attr_accessor :bill_to_number,
@@ -56,15 +54,13 @@ module Suretax
                :tax_exemption_codes
 
       def initialize(args = {})
-        args.each_pair do |key,value|
-          self.send("#{key.to_s}=",value.to_s)
+        args.each_pair do |key, value|
+          send("#{key}=", value.to_s)
         end
 
         @tax_exemption_codes = []
-        unless args[:tax_exemption_codes].nil?
-          args[:tax_exemption_codes].each do |code|
-            @tax_exemption_codes << code.to_s
-          end
+        args[:tax_exemption_codes]&.each do |code|
+          @tax_exemption_codes << code.to_s
         end
 
         validate!
@@ -75,17 +71,17 @@ module Suretax
           "LineNumber"           => line_number,
           "InvoiceNumber"        => invoice_number,
           "CustomerNumber"       => customer_number,
-          "OrigNumber"           => orig_number      || '',
-          "TermNumber"           => term_number      || '',
-          "BillToNumber"         => bill_to_number   || '',
+          "OrigNumber"           => orig_number      || "",
+          "TermNumber"           => term_number      || "",
+          "BillToNumber"         => bill_to_number   || "",
           "Zipcode"              => zipcode,
           "Plus4"                => plus_four,
-          "P2PZipcode"           => p_to_p_zipcode   || '',
-          "P2PPlus4"             => p_to_p_plus_four || '',
-          "TransDate"            => trans_date       || Date.today.strftime('%m-%d-%Y'),
+          "P2PZipcode"           => p_to_p_zipcode   || "",
+          "P2PPlus4"             => p_to_p_plus_four || "",
+          "TransDate"            => trans_date       || Date.today.strftime("%m-%d-%Y"),
           "Revenue"              => revenue.to_f,
           "Units"                => units.to_i,
-          "UnitType"             => presence(unit_type)        || '00',
+          "UnitType"             => presence(unit_type) || "00",
           "Seconds"              => seconds.to_i,
           "TaxIncludedCode"      => tax_included_code,
           "TaxSitusRule"         => tax_situs_rule,
@@ -93,7 +89,7 @@ module Suretax
           "SalesTypeCode"        => sales_type_code,
           "RegulatoryCode"       => regulatory_code,
           "TaxExemptionCodeList" => tax_exemption_codes,
-          "UDF"                   => user_defined_field || '',
+          "UDF"                   => user_defined_field || "",
           "ShipFromZipCode"       => ship_from_zipcode || "",
           "ShipFromPlus4"         => ship_from_plus_four || "",
           "OrderPlacementZipcode" => order_placement_zipcode || "",
@@ -113,7 +109,7 @@ module Suretax
       end
 
       def presence(value)
-        value if !blank(value)
+        value unless blank(value)
       end
 
       def blank(value)