solidus_core 2.10.0 → 2.11.0

data/spec/models/spree/order_contents_spec.rb

@@ -1,362 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::OrderContents, type: :model do
-  let!(:store) { create :store }
-  let(:order) { create(:order) }
-  let(:variant) { create(:variant) }
-  let!(:stock_location) { variant.stock_locations.first }
-  let(:stock_location_2) { create(:stock_location) }
-
-  subject(:order_contents) { described_class.new(order) }
-
-  context "#add" do
-    context 'given quantity is not explicitly provided' do
-      it 'should add one line item' do
-        line_item = subject.add(variant)
-        expect(line_item.quantity).to eq(1)
-        expect(order.line_items.size).to eq(1)
-      end
-    end
-
-    context 'given a shipment' do
-      let!(:shipment) { create(:shipment, order: order) }
-
-      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
-        expect(subject.order).to_not receive(:ensure_updated_shipments)
-        expect(shipment).to receive(:update_amounts)
-        subject.add(variant, 1, shipment: shipment)
-      end
-
-      context "with quantity=1" do
-        it "creates correct inventory" do
-          subject.add(variant, 1, shipment: shipment)
-          expect(order.inventory_units.count).to eq(1)
-        end
-      end
-
-      context "with quantity=2" do
-        it "creates correct inventory" do
-          subject.add(variant, 2, shipment: shipment)
-          expect(order.inventory_units.count).to eq(2)
-        end
-      end
-
-      context "called multiple times" do
-        it "creates correct inventory" do
-          subject.add(variant, 1, shipment: shipment)
-          subject.add(variant, 1, shipment: shipment)
-          expect(order.inventory_units.count).to eq(2)
-        end
-      end
-    end
-
-    context 'not given a shipment' do
-      it "ensures updated shipments" do
-        expect(subject.order).to receive(:ensure_updated_shipments)
-        subject.add(variant)
-      end
-    end
-
-    it 'should add line item if one does not exist' do
-      line_item = subject.add(variant, 1)
-      expect(line_item.quantity).to eq(1)
-      expect(order.line_items.size).to eq(1)
-    end
-
-    it 'should update line item if one exists' do
-      subject.add(variant, 1)
-      line_item = subject.add(variant, 1)
-      expect(line_item.quantity).to eq(2)
-      expect(order.line_items.size).to eq(1)
-    end
-
-    it "should update order totals" do
-      expect(order.item_total.to_f).to eq(0.00)
-      expect(order.total.to_f).to eq(0.00)
-
-      subject.add(variant, 1)
-
-      expect(order.item_total.to_f).to eq(19.99)
-      expect(order.total.to_f).to eq(19.99)
-    end
-
-    context "running promotions" do
-      let(:promotion) { create(:promotion, apply_automatically: true) }
-      let(:calculator) { Spree::Calculator::FlatRate.new(preferred_amount: 10) }
-
-      shared_context "discount changes order total" do
-        before { subject.add(variant, 1) }
-        it { expect(subject.order.total).not_to eq variant.price }
-      end
-
-      context "one active order promotion" do
-        let!(:action) { Spree::Promotion::Actions::CreateAdjustment.create(promotion: promotion, calculator: calculator) }
-
-        it "creates valid discount on order" do
-          subject.add(variant, 1)
-          expect(subject.order.adjustments.to_a.sum(&:amount)).not_to eq 0
-        end
-
-        include_context "discount changes order total"
-      end
-
-      context "one active line item promotion" do
-        let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(promotion: promotion, calculator: calculator) }
-
-        it "creates valid discount on order" do
-          subject.add(variant, 1)
-          expect(subject.order.line_item_adjustments.to_a.sum(&:amount)).not_to eq 0
-        end
-
-        include_context "discount changes order total"
-      end
-    end
-
-    describe 'tax calculations' do
-      let!(:zone) { create(:global_zone) }
-      let!(:tax_rate) do
-        create(:tax_rate, zone: zone, tax_categories: [variant.tax_category])
-      end
-
-      context 'when the order has a taxable address' do
-        before do
-          expect(order.tax_address.country_id).to be_present
-        end
-
-        it 'creates a tax adjustment' do
-          order_contents.add(variant)
-          line_item = order.find_line_item_by_variant(variant)
-          expect(line_item.adjustments.tax.count).to eq(1)
-        end
-      end
-
-      context 'when the order does not have a taxable address' do
-        before do
-          order.update!(ship_address: nil, bill_address: nil)
-          expect(order.tax_address.country_id).to be_nil
-        end
-
-        it 'creates a tax adjustment' do
-          order_contents.add(variant)
-          line_item = order.find_line_item_by_variant(variant)
-          expect(line_item.adjustments.tax.count).to eq(0)
-        end
-      end
-    end
-  end
-
-  context "#remove" do
-    context "given an invalid variant" do
-      it "raises an exception" do
-        expect {
-          subject.remove(variant, 1)
-        }.to raise_error(ActiveRecord::RecordNotFound)
-      end
-    end
-
-    context 'given quantity is not explicitly provided' do
-      it 'should remove one line item' do
-        line_item = subject.add(variant, 3)
-        subject.remove(variant)
-
-        expect(line_item.reload.quantity).to eq(2)
-      end
-    end
-
-    context 'given a shipment' do
-      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
-        subject.add(variant, 1)
-        shipment = create(:shipment)
-        expect(subject.order).to_not receive(:ensure_updated_shipments)
-        expect(shipment).to receive(:update_amounts)
-        subject.remove(variant, 1, shipment: shipment)
-      end
-    end
-
-    context 'not given a shipment' do
-      it "ensures updated shipments" do
-        subject.add(variant, 1)
-        expect(subject.order).to receive(:ensure_updated_shipments)
-        subject.remove(variant)
-      end
-    end
-
-    it 'should reduce line_item quantity if quantity is less the line_item quantity' do
-      line_item = subject.add(variant, 3)
-      subject.remove(variant, 1)
-
-      expect(line_item.reload.quantity).to eq(2)
-    end
-
-    it 'should remove line_item if quantity matches line_item quantity' do
-      subject.add(variant, 1)
-      subject.remove(variant, 1)
-
-      expect(order.reload.find_line_item_by_variant(variant)).to be_nil
-    end
-
-    it 'should remove line_item if quantity is greater than line_item quantity' do
-      subject.add(variant, 1)
-      subject.remove(variant, 2)
-
-      expect(order.reload.find_line_item_by_variant(variant)).to be_nil
-    end
-
-    it "should update order totals" do
-      expect(order.item_total.to_f).to eq(0.00)
-      expect(order.total.to_f).to eq(0.00)
-
-      subject.add(variant, 2)
-
-      expect(order.item_total.to_f).to eq(39.98)
-      expect(order.total.to_f).to eq(39.98)
-
-      subject.remove(variant, 1)
-      expect(order.item_total.to_f).to eq(19.99)
-      expect(order.total.to_f).to eq(19.99)
-    end
-  end
-
-  context "#remove_line_item" do
-    context 'given a shipment' do
-      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
-        line_item = subject.add(variant, 1)
-        shipment = create(:shipment)
-        expect(subject.order).to_not receive(:ensure_updated_shipments)
-        expect(shipment).to receive(:update_amounts)
-        subject.remove_line_item(line_item, shipment: shipment)
-      end
-    end
-
-    context 'not given a shipment' do
-      it "ensures updated shipments" do
-        line_item = subject.add(variant, 1)
-        expect(subject.order).to receive(:ensure_updated_shipments)
-        subject.remove_line_item(line_item)
-      end
-    end
-
-    it 'should remove line_item' do
-      line_item = subject.add(variant, 1)
-      subject.remove_line_item(line_item)
-
-      expect(order.reload.line_items).to_not include(line_item)
-    end
-
-    it "should update order totals" do
-      expect(order.item_total.to_f).to eq(0.00)
-      expect(order.total.to_f).to eq(0.00)
-
-      line_item = subject.add(variant, 2)
-
-      expect(order.item_total.to_f).to eq(39.98)
-      expect(order.total.to_f).to eq(39.98)
-
-      subject.remove_line_item(line_item)
-      expect(order.item_total.to_f).to eq(0.00)
-      expect(order.total.to_f).to eq(0.00)
-    end
-  end
-
-  context "update cart" do
-    let!(:shirt) { subject.add variant, 1 }
-
-    let(:params) do
-      { line_items_attributes: {
-        "0" => { id: shirt.id, quantity: 3 }
-      } }
-    end
-
-    it "changes item quantity" do
-      subject.update_cart params
-      expect(shirt.reload.quantity).to eq 3
-    end
-
-    it "updates order totals" do
-      expect {
-        subject.update_cart params
-      }.to change { subject.order.total }
-    end
-
-    context "submits item quantity 0" do
-      let(:params) do
-        { line_items_attributes: {
-          "0" => { id: shirt.id, quantity: 0 }
-        } }
-      end
-
-      it "removes item from order" do
-        expect {
-          subject.update_cart params
-        }.to change { subject.order.line_items.count }
-      end
-    end
-
-    it "ensures updated shipments" do
-      expect(subject.order).to receive(:ensure_updated_shipments)
-      subject.update_cart params
-    end
-  end
-
-  context "completed order" do
-    let(:order) { Spree::Order.create! state: 'complete', completed_at: Time.current }
-
-    before { order.shipments.create! stock_location_id: variant.stock_location_ids.first }
-
-    it "updates order payment state" do
-      expect {
-        subject.add variant
-      }.to change { order.payment_state }
-
-      expect {
-        subject.remove variant
-      }.to change { order.payment_state }
-    end
-  end
-
-  describe "#approve" do
-    context 'when a name is supplied' do
-      it 'approves the order' do
-        order.contents.approve(name: 'Jordan')
-        expect(order.approver).to be_nil
-        expect(order.approver_name).to eq('Jordan')
-        expect(order.approved_at).to be_present
-        expect(order.approved?).to be_truthy
-      end
-    end
-
-    context 'when a user is supplied' do
-      let(:user) { create(:user) }
-
-      it 'approves the order' do
-        order.contents.approve(user: user)
-        expect(order.approver).to eq(user)
-        expect(order.approver_name).to be_nil
-        expect(order.approved_at).to be_present
-        expect(order.approved?).to be_truthy
-      end
-    end
-
-    context 'when a user and a name are supplied' do
-      let(:user) { create(:user) }
-
-      it 'approves the order' do
-        order.contents.approve(user: user, name: 'Jordan')
-        expect(order.approver).to eq(user)
-        expect(order.approver_name).to eq('Jordan')
-        expect(order.approved_at).to be_present
-        expect(order.approved?).to be_truthy
-      end
-    end
-
-    context 'when neither a user nor a name are supplied' do
-      it 'raises' do
-        expect {
-          order.contents.approve
-        }.to raise_error(ArgumentError, 'user or name must be specified')
-      end
-    end
-  end
-end

data/spec/models/spree/order_inventory_spec.rb

@@ -1,285 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::OrderInventory, type: :model do
-  let(:order) { create :completed_order_with_totals }
-  let(:line_item) { order.line_items.first }
-  let(:shipment) { order.shipments.first }
-  let(:variant) { subject.variant }
-  let(:stock_item) { shipment.stock_location.stock_item(variant) }
-
-  subject { described_class.new(order, line_item) }
-
-  context "insufficient inventory units" do
-    let(:old_quantity) { 1 }
-    let(:new_quantity) { 3 }
-
-    before do
-      line_item.update!(quantity: old_quantity)
-
-      line_item.update_column(:quantity, new_quantity)
-      subject.line_item.reload
-    end
-
-    it 'creates the proper number of inventory units' do
-      expect(line_item.inventory_units.count).to eq(old_quantity)
-      subject.verify(shipment)
-      expect(line_item.inventory_units.count).to eq(new_quantity)
-    end
-
-    it "unstocks items" do
-      expect {
-        subject.verify(shipment)
-      }.to change { stock_item.reload.count_on_hand }.by(-2)
-    end
-
-    context "order is not completed" do
-      let(:inventory_unit_finalizer) { double(:inventory_unit_finalizer, run!: [true]) }
-
-      before do
-        allow(Spree::Stock::InventoryUnitsFinalizer)
-          .to receive(:new).and_return(inventory_unit_finalizer)
-
-        order.update_columns completed_at: nil
-      end
-
-      it "doesn't finalize the items" do
-        expect(inventory_unit_finalizer).to_not receive(:run!)
-
-        subject.verify(shipment)
-      end
-    end
-
-    context "inventory units state" do
-      before { shipment.inventory_units.destroy_all }
-      let(:new_quantity) { 5 }
-
-      it 'sets inventory_units state as per stock location availability' do
-        stock_item.update_columns(
-          backorderable: true,
-          count_on_hand: 3
-        )
-
-        subject.verify
-
-        units = shipment.inventory_units_for(subject.variant).group_by(&:state)
-        expect(units['backordered'].size).to eq(2)
-        expect(units['on_hand'].size).to eq(3)
-      end
-    end
-
-    context "store doesnt track inventory" do
-      let(:new_quantity) { 1 }
-
-      before { stub_spree_preferences(track_inventory_levels: false) }
-
-      it "creates on hand inventory units" do
-        variant.stock_items.each(&:really_destroy!)
-
-        subject.verify(shipment)
-
-        units = shipment.inventory_units_for(variant)
-        expect(units.count).to eq 1
-        expect(units.first).to be_on_hand
-      end
-    end
-
-    context "variant doesnt track inventory" do
-      before { variant.update!(track_inventory: false) }
-      let(:new_quantity) { 1 }
-
-      it "creates on hand inventory units" do
-        variant.stock_items.each(&:really_destroy!)
-
-        subject.verify(shipment)
-
-        units = shipment.inventory_units_for(variant)
-        expect(units.count).to eq 1
-        expect(units.first).to be_on_hand
-      end
-    end
-
-    it 'should create stock_movement' do
-      expect(subject.send(:add_to_shipment, shipment, 5)).to eq(5)
-
-      stock_item = shipment.stock_location.stock_item(subject.variant)
-      movement = stock_item.stock_movements.last
-      expect(movement.originator).to eq(shipment)
-      expect(movement.quantity).to eq(-5)
-    end
-
-    context "calling multiple times" do
-      it "creates the correct number of inventory units" do
-        line_item.update_columns(quantity: 2)
-        subject.verify(shipment)
-        expect(line_item.inventory_units.count).to eq(2)
-
-        line_item.update_columns(quantity: 3)
-        subject.verify(shipment)
-        expect(line_item.inventory_units.count).to eq(3)
-      end
-    end
-  end
-
-  context "#determine_target_shipment" do
-    let(:stock_location) { create :stock_location }
-    let(:variant) { line_item.variant }
-
-    before do
-      subject.verify
-
-      order.shipments.create(stock_location_id: stock_location.id, cost: 5)
-
-      shipped = order.shipments.create(stock_location_id: order.shipments.first.stock_location.id, cost: 10)
-      shipped.update_column(:state, 'shipped')
-    end
-
-    it 'should select first non-shipped shipment that already contains given variant' do
-      shipment = subject.send(:determine_target_shipment)
-      expect(shipment.shipped?).to be false
-      expect(shipment.inventory_units_for(variant)).not_to be_empty
-
-      expect(variant.stock_location_ids.include?(shipment.stock_location_id)).to be true
-    end
-
-    context "when no shipments already contain this varint" do
-      before do
-        subject.line_item.reload
-        subject.inventory_units.destroy_all
-      end
-
-      it 'selects first non-shipped shipment that leaves from same stock_location' do
-        shipment = subject.send(:determine_target_shipment)
-        shipment.reload
-        expect(shipment.shipped?).to be false
-        expect(shipment.inventory_units_for(variant)).to be_empty
-        expect(variant.stock_location_ids.include?(shipment.stock_location_id)).to be true
-      end
-    end
-  end
-
-  context 'when order has too many inventory units' do
-    let(:old_quantity) { 3 }
-    let(:new_quantity) { 2 }
-
-    before do
-      line_item.update!(quantity: old_quantity)
-
-      line_item.update_column(:quantity, new_quantity)
-      subject.line_item.reload
-    end
-
-    it 'should be a messed up order' do
-      expect(order.shipments.first.inventory_units_for(line_item.variant).size).to eq(3)
-      expect(line_item.quantity).to eq(2)
-    end
-
-    it 'should decrease the number of inventory units' do
-      subject.verify
-      expect(line_item.inventory_units.count).to eq 2
-      expect(order.inventory_units.count).to eq 2
-    end
-
-    context "order is not completed" do
-      before { order.update_columns(completed_at: nil) }
-
-      it "doesn't restock items" do
-        expect(shipment.stock_location).not_to receive(:restock)
-
-        expect {
-          subject.verify(shipment)
-        }.not_to change { stock_item.reload.count_on_hand }
-
-        expect(line_item.inventory_units.count).to eq(new_quantity)
-      end
-    end
-
-    it 'should change count_on_hand' do
-      expect {
-        subject.verify(shipment)
-      }.to change { stock_item.reload.count_on_hand }.by(1)
-    end
-
-    it 'should create stock_movement' do
-      stock_item = shipment.stock_location.stock_item(variant)
-
-      expect {
-        subject.verify(shipment)
-      }.to change { stock_item.stock_movements.count }.by(1)
-
-      movement = stock_item.stock_movements.last
-      expect(movement.originator).to eq shipment
-      expect(movement.quantity).to eq(1)
-    end
-
-    context 'with some backordered' do
-      let(:new_quantity) { 1 }
-
-      before do
-        line_item.inventory_units[0].update_columns(state: 'backordered')
-        line_item.inventory_units[1].update_columns(state: 'on_hand')
-        line_item.inventory_units[2].update_columns(state: 'backordered')
-      end
-
-      it 'should destroy backordered units first' do
-        on_hand_unit = line_item.inventory_units.find_by state: 'on_hand'
-
-        subject.verify(shipment)
-
-        expect(line_item.inventory_units.reload).to eq([on_hand_unit])
-      end
-    end
-
-    context 'with some shipped items' do
-      let(:old_quantity) { 2 }
-      let(:new_quantity) { 1 }
-
-      let(:shipped_unit) { line_item.inventory_units[0] }
-      before do
-        shipped_unit.update_columns(state: 'shipped')
-      end
-
-      it 'should destroy unshipped units first' do
-        subject.verify(shipment)
-
-        expect(line_item.inventory_units.reload).to eq([shipped_unit])
-      end
-
-      context 'trying to remove shipped units' do
-        let(:new_quantity) { 0 }
-
-        it 'only attempts to destroy as many units as are eligible, and return amount destroyed' do
-          subject.verify(shipment)
-
-          expect(line_item.inventory_units.reload).to eq([shipped_unit])
-        end
-      end
-    end
-
-    context 'destroying all units' do
-      let(:new_quantity) { 0 }
-
-      it 'should destroy shipment' do
-        expect {
-          subject.verify(shipment)
-        }.to change{ order.shipments.count }.from(1).to(0)
-      end
-    end
-
-    context "inventory unit line item and variant points to different products" do
-      let(:new_quantity) { 0 }
-      let(:different_line_item) { create(:line_item, order: order) }
-
-      let!(:different_inventory) do
-        shipment.set_up_inventory("on_hand", variant, order, different_line_item)
-      end
-
-      it "removes only units that match both line item and variant" do
-        subject.verify(shipment)
-
-        expect(different_inventory.reload).to be_persisted
-      end
-    end
-  end
-end