solidus_core 2.10.0 → 2.11.0

data/spec/models/spree/calculator/tiered_percent_spec.rb

@@ -1,197 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'shared_examples/calculator_shared_examples'
-
-RSpec.describe Spree::Calculator::TieredPercent, type: :model do
-  let(:calculator) { Spree::Calculator::TieredPercent.new }
-
-  it_behaves_like 'a calculator with a description'
-
-  describe "#valid?" do
-    subject { calculator.valid? }
-
-    context "when base percent is less than zero" do
-      before { calculator.preferred_base_percent = -1 }
-      it { is_expected.to be false }
-    end
-
-    context "when base percent is greater than 100" do
-      before { calculator.preferred_base_percent = 110 }
-      it { is_expected.to be false }
-    end
-
-    context "when tiers is a hash" do
-      context "and the key is not a positive number" do
-        before { calculator.preferred_tiers = { "nope" => 20 } }
-        it { is_expected.to be false }
-      end
-
-      context "and one of the values is not a percent" do
-        before { calculator.preferred_tiers = { 10 => 110 } }
-        it { is_expected.to be false }
-      end
-
-      context "and the key is an integer" do
-        before { calculator.preferred_tiers = { 20 => 20 } }
-        it "converts successfully" do
-          is_expected.to be true
-          expect(calculator.preferred_tiers).to eq({ BigDecimal('20') => BigDecimal('20') })
-        end
-      end
-
-      context "and the key is a float" do
-        before { calculator.preferred_tiers = { 20.5 => 20.5 } }
-        it "converts successfully" do
-          is_expected.to be true
-          expect(calculator.preferred_tiers).to eq({ BigDecimal('20.5') => BigDecimal('20.5') })
-        end
-      end
-
-      context "and the key is a string number" do
-        before { calculator.preferred_tiers = { "20" => 20 } }
-        it "converts successfully" do
-          is_expected.to be true
-          expect(calculator.preferred_tiers).to eq({ BigDecimal('20') => BigDecimal('20') })
-        end
-      end
-
-      context "and the key is a numeric string with spaces" do
-        before { calculator.preferred_tiers = { "  20 " => 20 } }
-        it "converts successfully" do
-          is_expected.to be true
-          expect(calculator.preferred_tiers).to eq({ BigDecimal('20') => BigDecimal('20') })
-        end
-      end
-
-      context "and the key is a string number with decimals" do
-        before { calculator.preferred_tiers = { "20.5" => "20.5" } }
-        it "converts successfully" do
-          is_expected.to be true
-          expect(calculator.preferred_tiers).to eq({ BigDecimal('20.5') => BigDecimal('20.5') })
-        end
-      end
-    end
-  end
-
-  describe "#compute" do
-    let(:order) do
-      create(
-        :order_with_line_items,
-        line_items_count: line_item_count,
-        line_items_price: price
-      )
-    end
-    let(:price) { 10 }
-    let(:preferred_currency) { "USD" }
-
-    before do
-      calculator.preferred_base_percent = 10
-      calculator.preferred_tiers = {
-        20 => 15,
-        30 => 20
-      }
-      calculator.preferred_currency = preferred_currency
-    end
-
-    context "with a line item" do
-      let(:line_item) { order.line_items.first }
-      subject { calculator.compute(line_item) }
-
-      context "for multiple line items" do
-        context "when amount falls within the first tier" do
-          let(:line_item_count) { 1 }
-          it { is_expected.to eq 1.0 }
-        end
-
-        context "when amount falls within the second tier" do
-          let(:line_item_count) { 2 }
-          it { is_expected.to eq 1.5 }
-        end
-
-        context "when amount falls within the third tier" do
-          let(:line_item_count) { 3 }
-          it { is_expected.to eq 2.0 }
-        end
-      end
-
-      context "for a single line item" do
-        let(:line_item_count) { 1 }
-
-        context "when amount falls within the first tier" do
-          let(:price) { 10 }
-          it { is_expected.to eq 1.0 }
-        end
-
-        context "when amount falls within the second tier" do
-          let(:price) { 20 }
-          it { is_expected.to eq 3.0 }
-        end
-
-        context "when amount falls within the third tier" do
-          let(:price) { 30 }
-          it { is_expected.to eq 6.0 }
-        end
-      end
-
-      context "when the order's currency does not match the calculator" do
-        let(:preferred_currency) { "JPY" }
-        let(:line_item_count) { 1 }
-        let(:price) { 15 }
-        it { is_expected.to eq 0 }
-
-        it "rounds based on currency" do
-          allow(order).to receive_messages currency: "JPY"
-          expect(subject).to eq(2)
-        end
-      end
-    end
-
-    context "with an order" do
-      subject { calculator.compute(order) }
-
-      let(:line_item_count) { 1 }
-
-      context "for multiple line items" do
-        context "when amount falls within the first tier" do
-          let(:line_item_count) { 1 }
-          it { is_expected.to eq 1.0 }
-        end
-
-        context "when amount falls within the second tier" do
-          let(:line_item_count) { 2 }
-          it { is_expected.to eq 3.0 }
-        end
-
-        context "when amount falls within the third tier" do
-          let(:line_item_count) { 3 }
-          it { is_expected.to eq 6.0 }
-        end
-      end
-
-      context "for a single line item" do
-        let(:line_item_count) { 1 }
-
-        context "when amount falls within the first tier" do
-          let(:price) { 10 }
-          it { is_expected.to eq 1.0 }
-        end
-
-        context "when amount falls within the second tier" do
-          let(:price) { 20 }
-          it { is_expected.to eq 3.0 }
-        end
-
-        context "when amount falls within the third tier" do
-          let(:price) { 30 }
-          it { is_expected.to eq 6.0 }
-        end
-      end
-
-      context "when the order's currency does not match the calculator" do
-        let(:preferred_currency) { "CAD" }
-        it { is_expected.to eq 0 }
-      end
-    end
-  end
-end

data/spec/models/spree/calculator_spec.rb

@@ -1,43 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::Calculator, type: :model do
-  class SimpleCalculator < Spree::Calculator
-    def compute_simple_computable(_line_item)
-      'computed'
-    end
-  end
-
-  class SimpleComputable
-  end
-
-  describe "#calculators" do
-    subject { Spree::Calculator.calculators }
-
-    it 'returns the (deprecated) calculator step' do
-      Spree::Deprecation.silence do
-        expect(subject).to be_a Spree::Core::Environment::Calculators
-      end
-    end
-  end
-
-  context "with computable" do
-    let(:calculator) { SimpleCalculator.new }
-    let(:computable) { SimpleComputable.new }
-
-    subject { SimpleCalculator.new.compute computable }
-
-    it 'calls compute method of class type' do
-      expect(subject).to eq  'computed'
-    end
-
-    context 'computable does not implement right function name' do
-      let(:computable) { Spree::LineItem.new }
-
-      it 'raises an error' do
-        expect { subject }.to raise_error NotImplementedError, /Please implement \'compute_line_item\(line_item\)\' in your calculator/
-      end
-    end
-  end
-end

data/spec/models/spree/carton_spec.rb

@@ -1,145 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::Carton do
-  let(:carton) { create(:carton) }
-
-  describe 'shipping method' do
-    it 'returns soft deleted shipping method' do
-      carton = create(:carton)
-      carton.shipping_method.discard
-      expect(carton.reload.shipping_method).to be_present
-    end
-  end
-
-  describe "#create" do
-    subject { carton }
-
-    it "raises no errors" do
-      subject
-    end
-  end
-
-  describe "#tracking_url" do
-    subject do
-      carton.tracking_url
-    end
-
-    let(:carton) { create(:carton, shipping_method: shipping_method) }
-    let(:shipping_method) do
-      create(:shipping_method, tracking_url: "https://example.com/:tracking")
-    end
-
-    context "when tracking is not present" do
-      it { is_expected.to be_nil }
-    end
-
-    context "when tracking is present" do
-      let(:carton) do
-        create(:carton, shipping_method: shipping_method, tracking: "1Z12345")
-      end
-
-      it "uses shipping method to determine url" do
-        is_expected.to eq("https://example.com/1Z12345")
-      end
-    end
-  end
-
-  describe "#to_param" do
-    subject do
-      carton.to_param
-    end
-
-    it { is_expected.to eq carton.number }
-  end
-
-  describe "#order_numbers" do
-    subject { carton.order_numbers }
-    let(:order) { carton.orders.first }
-
-    it "returns a list of the order numbers it is associated to" do
-      expect(subject).to eq [order.number]
-    end
-  end
-
-  describe "#shipment_numbers" do
-    subject { carton.shipment_numbers }
-    let(:shipment) { carton.shipments.first }
-
-    it "returns a list of the shipment numbers it is associated to" do
-      expect(subject).to eq [shipment.number]
-    end
-  end
-
-  describe "#order_emails" do
-    subject { carton.order_emails }
-
-    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
-    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
-    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
-    let(:email) { 'something@something.com' }
-
-    before do
-      first_order.update!(email: email)
-      second_order.update!(email: email)
-    end
-
-    it "returns a unique list of the order emails it is associated to" do
-      expect(subject).to eq [email]
-    end
-  end
-
-  describe "#manifest" do
-    subject { carton.manifest }
-
-    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
-    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
-    let(:first_line_item) { first_order.line_items.first }
-    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
-    let(:second_line_item) { second_order.line_items.first }
-
-    it "contains only the items in both the carton and order" do
-      expect(subject.map(&:line_item)).to match_array([first_line_item, second_line_item])
-    end
-  end
-
-  describe "#manifest_for_order" do
-    subject { carton.manifest_for_order(first_order) }
-
-    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
-    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
-    let(:first_line_item) { first_order.line_items.first }
-    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
-
-    it "contains only the items in both the carton and order" do
-      expect(subject.map(&:line_item)).to eq [first_line_item]
-    end
-  end
-
-  describe "#any_exchanges?" do
-    subject { carton.any_exchanges? }
-
-    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
-    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
-    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
-
-    context "when any of the inventory has an original return item" do
-      let(:return_item) { create(:return_item) }
-      before do
-        first_order.inventory_units.first.original_return_item = return_item
-        first_order.save
-      end
-
-      it "is true" do
-        expect(subject).to be_truthy
-      end
-    end
-
-    context "when none of the inventory has an original return item" do
-      it "is false" do
-        expect(subject).to be_falsey
-      end
-    end
-  end
-end

data/spec/models/spree/classification_spec.rb

@@ -1,126 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-module Spree
-  RSpec.describe Classification, type: :model do
-    # Regression test for https://github.com/spree/spree/issues/3494
-    it "cannot link the same taxon to the same product more than once" do
-      product = create(:product)
-      taxon = create(:taxon)
-      add_taxon = lambda { product.taxons << taxon }
-      add_taxon.call
-      expect(add_taxon).to raise_error(ActiveRecord::RecordInvalid)
-    end
-
-    let(:taxon_with_5_products) do
-      products = []
-      5.times do
-        products << create(:base_product)
-      end
-
-      create(:taxon, products: products)
-    end
-
-    def positions_to_be_valid(taxon)
-      positions = taxon.reload.classifications.map(&:position)
-      expect(positions).to eq((1..taxon.classifications.count).to_a)
-    end
-
-    it "has a valid fixtures" do
-      expect positions_to_be_valid(taxon_with_5_products)
-      expect(Spree::Classification.count).to eq 5
-    end
-
-    context "removing product from taxon" do
-      before :each do
-        element = taxon_with_5_products.products[1]
-        expect(element.classifications.first.position).to eq(2)
-        taxon_with_5_products.products.destroy(element)
-      end
-
-      it "resets positions" do
-        expect positions_to_be_valid(taxon_with_5_products)
-      end
-    end
-
-    context "Discard'ing a product" do
-      before :each do
-        element = taxon_with_5_products.products[1]
-        expect(element.classifications.first.position).to eq(2)
-        element.discard
-      end
-
-      it "resets positions" do
-        expect positions_to_be_valid(taxon_with_5_products)
-      end
-    end
-
-    context "replacing taxon's products" do
-      before :each do
-        products = taxon_with_5_products.products.to_a
-        products.pop(1)
-        taxon_with_5_products.products = products
-        taxon_with_5_products.save!
-      end
-
-      it "resets positions" do
-        expect positions_to_be_valid(taxon_with_5_products)
-      end
-    end
-
-    context "removing taxon from product" do
-      before :each do
-        element = taxon_with_5_products.products[1]
-        element.taxons.destroy(taxon_with_5_products)
-        element.save!
-      end
-
-      it "resets positions" do
-        expect positions_to_be_valid(taxon_with_5_products)
-      end
-    end
-
-    context "replacing product's taxons" do
-      before :each do
-        element = taxon_with_5_products.products[1]
-        element.taxons = []
-        element.save!
-      end
-
-      it "resets positions" do
-        expect positions_to_be_valid(taxon_with_5_products)
-      end
-    end
-
-    context "destroying classification" do
-      before :each do
-        classification = taxon_with_5_products.classifications[1]
-        classification.destroy
-      end
-
-      it "resets positions" do
-        expect positions_to_be_valid(taxon_with_5_products)
-      end
-    end
-
-    it "touches the product" do
-      taxon = taxon_with_5_products
-      classification = taxon.classifications.first
-      product = classification.product
-      product.update_columns(updated_at: 1.day.ago)
-      expect {
-        classification.touch
-      }.to change { product.reload.updated_at }
-    end
-
-    it "touches the taxon" do
-      taxon = taxon_with_5_products
-      classification = taxon.classifications.first
-      taxon.update_columns(updated_at: 1.day.ago)
-      expect {
-        classification.touch
-      }.to change { taxon.reload.updated_at }
-    end
-  end
-end

data/spec/models/spree/concerns/display_money_spec.rb

@@ -1,44 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-module Spree
-  RSpec.describe DisplayMoney do
-    let(:test_class) do
-      Class.new do
-        extend DisplayMoney
-        def total; 10.0; end
-      end
-    end
-
-    describe ".money_methods" do
-      before { test_class.money_methods :total }
-
-      context "currency is not defined" do
-        it "generates a display_method that builds a Spree::Money without options" do
-          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
-        end
-      end
-
-      context "currency is defined" do
-        before { test_class.class_eval { def currency; "USD"; end } }
-
-        it "generates a display_* method that builds a Spree::Money with currency" do
-          expect(test_class.new.display_total).to eq Spree::Money.new(10.0, currency: "USD")
-        end
-      end
-
-      context "with multiple + options" do
-        before do
-          test_class.class_eval { def amount; 20.0; end }
-          test_class.money_methods :total, amount: { no_cents: true }
-        end
-
-        it "generates a display_* method that builds a Spree::Money with the specified options" do
-          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
-          expect(test_class.new.display_amount).to eq Spree::Money.new(20.0, no_cents: true)
-        end
-      end
-    end
-  end
-end

data/spec/models/spree/concerns/ordered_property_value_list_spec.rb

@@ -1,52 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::OrderedPropertyValueList do
-  #
-  # Using ProductProperty as a subject
-  # since it includes OrderedPropertyValueList
-  #
-
-  context 'positioning' do
-    let(:product_1) { create(:product) }
-    let!(:property_1) { create(:product_property, product: product_1) }
-    let!(:property_2) { create(:product_property, product: product_1) }
-
-    let(:product_2) { create(:product) }
-    let!(:property_3) { create(:product_property, product: product_2) }
-    let!(:property_4) { create(:product_property, product: product_2) }
-
-    before do
-      property_1.update_attribute(:position, 0)
-      property_2.update_attribute(:position, 1)
-      property_3.update_attribute(:position, 0)
-      property_4.update_attribute(:position, 1)
-    end
-
-    it 'scopes position to the product' do
-      expect(property_1.reload.position).to eq(0)
-      expect(property_2.reload.position).to eq(1)
-      expect(property_3.reload.position).to eq(0)
-      expect(property_4.reload.position).to eq(1)
-    end
-  end
-
-  context "validations" do
-    let(:product_property) { create(:product_property) }
-
-    # Only MySQL stores or stores that were migrated prior to the Rails 4.2
-    # upgrade have length limitations on "value":
-    # > The PostgreSQL and SQLite adapters no longer add a default limit of 255
-    # > characters on string columns.
-    # http://guides.rubyonrails.org/4_2_release_notes.html#active-record-notable-changes
-    # https://github.com/rails/rails/pull/14579
-    if Spree::ProductProperty.columns_hash['value'].limit
-      it "should validate length of value" do
-        overflow_length = Spree::ProductProperty.columns_hash['value'].limit + 1
-        product_property.value = "x" * overflow_length
-        expect(product_property).not_to be_valid
-      end
-    end
-  end
-end