solidus_core 2.10.0 → 2.11.0

data/spec/lib/spree/core/testing_support/preferences_spec.rb

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Spree::TestingSupport::Preferences do
-  describe 'resetting the app configuration' do
-    around do |example|
-      with_unfrozen_spree_preference_store do
-        Spree::Deprecation.silence do
-          example.run
-        end
-      end
-    end
-
-    before do
-      reset_spree_preferences
-      @original_spree_mails_from = Spree::Config.mails_from
-      @original_spree_searcher_class = Spree::Config.searcher_class
-      class MySearcherClass; end
-      include Spree::TestingSupport::Preferences
-      Spree::Config.mails_from = "hello@myserver.com"
-      Spree::Config.searcher_class = MySearcherClass
-    end
-
-    it 'resets normal preferences' do
-      expect(Spree::Config.mails_from).to eq("hello@myserver.com")
-      reset_spree_preferences
-      expect(Spree::Config.mails_from).to eq(@original_spree_mails_from)
-    end
-
-    it 'resets cached configuration instance variables' do
-      expect(Spree::Config.searcher_class).to eq(MySearcherClass)
-      reset_spree_preferences
-      expect(Spree::Config.searcher_class).to eq(@original_spree_searcher_class)
-    end
-  end
-
-  describe '#stub_spree_preferences' do
-    it 'stubs method calls but does not affect actual stored Spree::Config settings' do
-      stub_spree_preferences(currency: 'FOO')
-      expect(Spree::Config.currency).to eq 'FOO'
-      expect(Spree::Config.preference_store[:currency]).to eq 'USD'
-    end
-  end
-
-  describe '#with_unfrozen_spree_preference_store' do
-    it 'changes the original settings, but returns them to original values at exit' do
-      with_unfrozen_spree_preference_store do
-        Spree::Config.mails_from = 'override@example.com'
-        expect(Spree::Config.mails_from).to eq 'override@example.com'
-        expect(Spree::Config.preference_store[:mails_from]).to eq 'override@example.com'
-      end
-
-      # both the original frozen store and the unfrozen store are unaffected by changes above:
-      expect(Spree::Config.mails_from).to eq 'store@example.com'
-      with_unfrozen_spree_preference_store do
-        expect(Spree::Config.mails_from).to eq 'store@example.com'
-      end
-    end
-  end
-end

data/spec/lib/spree/core/validators/email_spec.rb

@@ -1,53 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'spree/core/validators/email'
-
-RSpec.describe Spree::EmailValidator do
-  class Tester
-    include ActiveModel::Validations
-    attr_accessor :email_address
-    validates :email_address, 'spree/email' => true
-  end
-
-  let(:valid_emails) {
-    [
-      'valid@email.com',
-      'valid@email.com.uk',
-      'e@email.com',
-      'valid+email@email.com',
-      'valid-email@email.com',
-      'valid_email@email.com',
-      'valid.email@email.com'
-    ]
-  }
-  let(:invalid_emails) {
-    [
-      'invalid email@email.com',
-      '.invalid.email@email.com',
-      'invalid.email.@email.com',
-      '@email.com',
-      '.@email.com',
-      'invalidemailemail.com',
-      '@invalid.email@email.com',
-      'invalid@email@email.com',
-      'invalid.email@@email.com'
-    ]
-  }
-
-  it 'validates valid email addresses' do
-    tester = Tester.new
-    valid_emails.each do |email|
-      tester.email_address = email
-      expect(tester.valid?).to be true
-    end
-  end
-
-  it 'validates invalid email addresses' do
-    tester = Tester.new
-    invalid_emails.each do |email|
-      tester.email_address = email
-      expect(tester.valid?).to be false
-    end
-  end
-end

data/spec/lib/spree/core/version_spec.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Spree do
-  describe '.solidus_version' do
-    it "returns a string" do
-      expect(Spree.solidus_version).to be_a(String)
-    end
-  end
-
-  describe '.solidus_gem_version' do
-    it "returns a Gem::Version" do
-      expect(Spree.solidus_gem_version).to be_a(Gem::Version)
-    end
-
-    it "can be compared" do
-      expect(Spree.solidus_gem_version).to be > Gem::Version.new("1.0")
-    end
-  end
-end

data/spec/lib/spree/event/subscriber_spec.rb

@@ -1,85 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-require 'spree/event'
-
-RSpec.describe Spree::Event::Subscriber do
-  module M
-    include Spree::Event::Subscriber
-
-    event_action :event_name
-
-    def event_name(event)
-      # code that handles the event
-    end
-
-    def other_event(event)
-      # ...
-    end
-  end
-
-  describe '::subscribe!' do
-    before { M.unsubscribe! }
-
-    it 'adds new listeners to Spree::Event' do
-      expect { M.subscribe! }.to change { Spree::Event.listeners }
-    end
-
-    context 'when subscriptions are not registered' do
-      it 'does not trigger the event callback' do
-        expect(M).not_to receive(:event_name)
-        Spree::Event.fire 'event_name'
-      end
-    end
-
-    it 'subscribes event actions' do
-      M.subscribe!
-      expect(M).to receive(:event_name)
-      Spree::Event.fire 'event_name'
-    end
-
-    it 'does not subscribe event actions more than once' do
-      2.times { M.subscribe! }
-      expect(M).to receive(:event_name).once
-      Spree::Event.fire 'event_name'
-    end
-  end
-
-  describe '::unsubscribe' do
-    before { M.subscribe! }
-
-    it 'removes the subscription' do
-      expect(M).not_to receive(:event_name)
-      M.unsubscribe!
-      Spree::Event.fire 'event_name'
-    end
-  end
-
-  describe '::event_action' do
-    context 'when the action has not been declared' do
-      before { M.subscribe! }
-
-      it 'does not subscribe the action' do
-        expect(M).not_to receive(:other_event)
-        Spree::Event.fire 'other_event'
-      end
-    end
-
-    context 'when the action is declared' do
-      before do
-        M.event_action :other_event
-        M.subscribe!
-      end
-
-      after do
-        M.unsubscribe!
-        M.event_actions.delete(:other_event)
-      end
-
-      it 'subscribe the action' do
-        expect(M).to receive(:other_event)
-        Spree::Event.fire 'other_event'
-      end
-    end
-  end
-end

data/spec/lib/spree/event_spec.rb

@@ -1,130 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-require 'spree/event'
-
-RSpec.describe Spree::Event do
-  let(:subscription_name) { 'foo_bar' }
-  let(:item) { spy('object') }
-  let(:notifier) { ActiveSupport::Notifications.notifier }
-
-  subject { described_class }
-
-  it 'has default adapter' do
-    expect(subject.adapter).to eql Spree::Event::Adapters::ActiveSupportNotifications
-  end
-
-  context 'with the default adapter' do
-    before do
-      # ActiveSupport::Notifications does not provide an interface to clean all
-      # subscribers at once, so some low level brittle code is required
-      if Rails.gem_version >= Gem::Version.new('6.0.0')
-        @old_string_subscribers = notifier.instance_variable_get('@string_subscribers').dup
-        @old_other_subscribers = notifier.instance_variable_get('@other_subscribers').dup
-        notifier.instance_variable_get('@string_subscribers').clear
-        notifier.instance_variable_get('@other_subscribers').clear
-      else
-        @old_subscribers = notifier.instance_variable_get('@subscribers').dup
-        notifier.instance_variable_get('@subscribers').clear
-      end
-      @old_listeners = notifier.instance_variable_get('@listeners_for').dup
-      notifier.instance_variable_get('@listeners_for').clear
-    end
-
-    after do
-      if Rails.gem_version >= Gem::Version.new('6.0.0')
-        notifier.instance_variable_set '@string_subscribers', @old_string_subscribers
-        notifier.instance_variable_set '@other_subscribers', @old_other_subscribers
-      else
-        notifier.instance_variable_set '@subscribers', @old_subscribers
-      end
-      notifier.instance_variable_set '@listeners_for', @old_listeners
-    end
-
-    describe '#listeners' do
-      context 'when there is no subscription' do
-        it { expect(subject.listeners).to be_empty }
-
-        context 'after adding a subscription' do
-          before do
-            Spree::Event.subscribe(subscription_name) { item.do_something }
-          end
-
-          it 'includes the new subscription with custom suffix' do
-            expect(subject.listeners).to be_present
-            subscription_listeners = subject.listeners["#{subscription_name}.spree"]
-            expect(subscription_listeners).to be_a Array
-            expect(subscription_listeners.first).to be_a ActiveSupport::Notifications::Fanout::Subscribers::Timed
-          end
-        end
-      end
-    end
-
-    context 'subscriptions' do
-      describe '#subscribe' do
-        it 'can subscribe to events' do
-          Spree::Event.subscribe(subscription_name) { item.do_something }
-          Spree::Event.fire subscription_name
-          expect(item).to have_received :do_something
-        end
-      end
-
-      describe '#unsubscribe' do
-        context 'when unsubscribing using a subscription object as reference' do
-          let!(:subscription) { Spree::Event.subscribe(subscription_name) { item.do_something } }
-
-          before do
-            Spree::Event.subscribe(subscription_name) { item.do_something_else }
-          end
-
-          it 'can unsubscribe from single event by object' do
-            subject.unsubscribe subscription
-            Spree::Event.fire subscription_name
-            expect(item).not_to have_received :do_something
-            expect(item).to have_received :do_something_else
-          end
-        end
-
-        context 'when unsubscribing using a string as reference' do
-          before do
-            Spree::Event.subscribe(subscription_name) { item.do_something }
-            Spree::Event.subscribe(subscription_name) { item.do_something_else }
-          end
-
-          it 'can unsubscribe from multiple events with the same name' do
-            subject.unsubscribe subscription_name
-            Spree::Event.fire subscription_name
-            expect(item).not_to have_received :do_something
-            expect(item).not_to have_received :do_something_else
-          end
-        end
-      end
-    end
-  end
-
-  describe '.subscribers' do
-    let(:subscriber) { instance_double(Module, 'Subscriber') }
-    let(:subscriber_name) { instance_double(String, 'Subscriber name') }
-
-    before do
-      described_class.subscribers.clear
-      allow(subscriber).to receive(:name).and_return(subscriber_name)
-      allow(subscriber_name).to receive(:constantize).and_return(subscriber)
-      allow(subscriber_name).to receive(:to_s).and_return(subscriber_name)
-    end
-
-    it 'accepts the names of constants' do
-      Spree::Config.events.subscribers << subscriber_name
-
-      expect(described_class.subscribers.to_a).to eq([subscriber])
-    end
-
-    it 'discards duplicates' do
-      described_class.subscribers << subscriber_name
-      described_class.subscribers << subscriber_name
-      described_class.subscribers << subscriber_name
-
-      expect(described_class.subscribers.to_a).to eq([subscriber])
-    end
-  end
-end

data/spec/lib/spree/localized_number_spec.rb

@@ -1,45 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-require 'spree/localized_number'
-
-RSpec.describe Spree::LocalizedNumber do
-  context ".parse" do
-    before do
-      I18n.enforce_available_locales = false
-      I18n.locale = I18n.default_locale
-      I18n.backend.store_translations(:de, { number: { currency: { format: { delimiter: '.', separator: ',' } } } })
-    end
-
-    after do
-      I18n.locale = I18n.default_locale
-      I18n.enforce_available_locales = true
-    end
-
-    context "with an empty string" do
-      it "parses to 0" do
-        expect(subject.class.parse("")).to eq 0.0
-      end
-    end
-
-    context "with decimal point" do
-      it "captures the proper amount for a formatted price" do
-        expect(subject.class.parse('1,599.99')).to eql 1599.99
-      end
-    end
-
-    context "with decimal comma" do
-      it "captures the proper amount for a formatted price" do
-        I18n.locale = :de
-        expect(subject.class.parse('1.599,99')).to eql 1599.99
-      end
-    end
-
-    context "with a numeric price" do
-      it "uses the price as is" do
-        I18n.locale = :de
-        expect(subject.class.parse(1599.99)).to eql 1599.99
-      end
-    end
-  end
-end

data/spec/lib/spree/migrations_spec.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-module Spree
-  RSpec.describe Migrations do
-    let(:app_migrations) { [".", "34_add_title.rb", "52_add_text.rb"] }
-    let(:engine_migrations) { [".", "334_create_orders.spree.rb", "777_create_products.spree.rb"] }
-
-    let(:config) { double("Config", root: "dir") }
-
-    let(:engine_dir) { "dir/db/migrate" }
-    let(:app_dir) { "#{Rails.root}/db/migrate" }
-
-    subject { described_class.new(config, "spree") }
-
-    it "detects missing migrations" do
-      expect(Dir).to receive(:entries).with(app_dir).and_return app_migrations
-      expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
-
-      expect(subject.missing_migrations.size).to eq 2
-    end
-
-    context "no missing migrations" do
-      it "says nothing" do
-        expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
-        expect(Dir).to receive(:entries).with(app_dir).and_return(app_migrations + engine_migrations)
-        expect(subject.missing_migrations.size).to eq 0
-      end
-    end
-  end
-end