smash_and_grab 0.0.5alpha → 0.0.6alpha

data/test/smash_and_grab/abilities/drop_test.rb

@@ -0,0 +1,68 @@
+require_relative "../../teststrap"
+require_relative "helpers/ability_helper"
+describe SmashAndGrab::Abilities::Drop do
+  before do
+    @entity = Object.new
+    @object = Object.new
+    @map = Object.new
+    @tile = SmashAndGrab::Tile.new(:grass, nil, 1, 2)
+  end
+
+  subject { SmashAndGrab::Abilities.ability @entity, type: :drop }
+
+  behaves_like SmashAndGrab::Abilities::Ability
+
+  should "be initialized" do
+    subject.owner.should.equal @entity
+    subject.can_be_undone?.should.be.true
+    subject.skill.should.equal 0
+    subject.action_cost.should.equal 1
+  end
+
+  should "serialize to json correctly" do
+    JSON.parse(subject.to_json).symbolize.should.equal(
+        type: :drop,
+        skill: 0,
+        action_cost: 1
+    )
+  end
+
+  should "generate appropriate action_data" do
+    stub(@entity).id.returns 12
+    stub(@object).id.returns 13
+    stub(@entity).contents.returns @object
+    mock(@entity).tile.stub!.adjacent_tiles(@entity).stub!.find_all(&:empty?).stub!.sample.returns @tile
+    subject.action_data.should.equal(
+        ability: :drop,
+        skill: 0,
+        action_cost: 1,
+
+        owner_id: 12,
+        target_id: 13,
+        target_position: [1, 2],
+    )
+  end
+
+  describe "#do" do
+    should "remove action points and drop object onto the tile" do
+      stub(@entity).action_points.returns 1
+      mock(@entity).map.stub!.tile_at_grid(1, 2).returns @tile
+      mock(@entity).action_points = 0
+      mock(@entity).drop @tile
+
+      subject.do action_cost: 1, target_id: 13, target_position: [1, 2]
+    end
+  end
+
+  describe "#undo" do
+    should "give give action points and pick up the object from tile" do
+      stub(@object).tile.returns @tile
+      stub(@entity).map.stub!.object_by_id(13).returns @object
+      stub(@entity).action_points.returns 0
+      mock(@entity).action_points = 1
+      mock(@entity).pick_up @object
+
+      subject.undo action_cost: 1, target_id: 13, target_position: [1, 2]
+    end
+  end
+end

data/test/smash_and_grab/abilities/melee_test.rb

@@ -58,7 +58,7 @@ describe SmashAndGrab::Abilities::Melee do
 
     should "never give a value less than 1" do
       stub(subject).rand(is_a(Integer)) { 0 }
-      subject.random_damage == 1
+      subject.random_damage == 0
     end
   end
 
@@ -67,7 +67,7 @@ describe SmashAndGrab::Abilities::Melee do
       stub(@entity).map.stub!.object_by_id(13).returns @enemy
       stub(@entity).action_points.returns 1
       mock(@entity).action_points = 0
-      mock(@entity).melee(@enemy, 5)
+      mock(@entity).make_melee_attack(@enemy, 5)
 
       subject.do action_cost: 1, target_id: 13, damage: 5 #, target_position: [1, 2]
     end
@@ -79,7 +79,7 @@ describe SmashAndGrab::Abilities::Melee do
       stub(@entity).map.stub!.object_by_id(13).returns @enemy
       stub(@entity).action_points.returns 0
       mock(@entity).action_points = 1
-      mock(@entity).melee(@enemy, -5)
+      mock(@entity).make_melee_attack(@enemy, -5)
 
       subject.undo action_cost: 1, target_id: 13, damage: 5, target_position: [1, 2]
     end
@@ -87,7 +87,7 @@ describe SmashAndGrab::Abilities::Melee do
     should "give action points, health and return to map (if target dead)" do
       stub(@enemy).tile.returns nil
       mock(@enemy).tile = @tile
-      mock(@entity).melee(@enemy, -5)
+      mock(@entity).make_melee_attack(@enemy, -5)
 
       stub(@entity).map do
         stub(@map).object_by_id(13).returns @enemy

data/test/smash_and_grab/abilities/pick_up_test.rb

@@ -0,0 +1,68 @@
+require_relative "../../teststrap"
+require_relative "helpers/ability_helper"
+describe SmashAndGrab::Abilities::PickUp do
+  before do
+    @entity = Object.new
+    @object = Object.new
+    @map = Object.new
+    @tile = SmashAndGrab::Tile.new(:grass, nil, 1, 2)
+  end
+
+  subject { SmashAndGrab::Abilities.ability @entity, type: :pick_up }
+
+  behaves_like SmashAndGrab::Abilities::Ability
+
+  should "be initialized" do
+    subject.owner.should.equal @entity
+    subject.can_be_undone?.should.be.true
+    subject.skill.should.equal 0
+    subject.action_cost.should.equal 1
+  end
+
+  should "serialize to json correctly" do
+    JSON.parse(subject.to_json).symbolize.should.equal(
+        type: :pick_up,
+        skill: 0,
+        action_cost: 1
+    )
+  end
+
+  should "generate appropriate action_data" do
+    stub(@entity).id.returns 12
+    stub(@object).id.returns 13
+    stub(@object).tile.returns @tile
+    stub(@tile).object.returns @object
+    stub(subject).random_damage.returns 5
+    subject.action_data(@object).should.equal(
+        ability: :pick_up,
+        skill: 0,
+        action_cost: 1,
+
+        owner_id: 12,
+        target_id: 13,
+        target_position: [1, 2],
+    )
+  end
+
+  describe "#do" do
+    should "remove action points and pick up" do
+      stub(@entity).map.stub!.object_by_id(13).returns @object
+      stub(@entity).action_points.returns 1
+      mock(@entity).action_points = 0
+      mock(@entity).pick_up @object
+
+      subject.do action_cost: 1, target_id: 13, target_position: [1, 2]
+    end
+  end
+
+  describe "#undo" do
+    should "give give action points and drop" do
+      stub(@entity).action_points.returns 0
+      mock(@entity).map.stub!.tile_at_grid(1, 2).returns @tile
+      mock(@entity).action_points = 1
+      mock(@entity).drop @tile
+
+      subject.undo action_cost: 1, target_id: 13, target_position: [1, 2]
+    end
+  end
+end

data/test/smash_and_grab/abilities/ranged_test.rb

@@ -0,0 +1,105 @@
+require_relative "../../teststrap"
+require_relative "helpers/ability_helper"
+
+describe SmashAndGrab::Abilities::Ranged do
+  before do
+    @entity = Object.new
+    @enemy = Object.new
+    @map = Object.new
+    @tile = SmashAndGrab::Tile.new(:grass, nil, 1, 2)
+  end
+
+  subject { SmashAndGrab::Abilities.ability @entity, type: :ranged, skill: 5, max_range: 5 }
+
+  behaves_like SmashAndGrab::Abilities::Ability
+
+  should "fail if not given the required arguments" do
+    ->{ SmashAndGrab::Abilities.ability @entity, type: :ranged }.should.raise(ArgumentError).message.should.match /no :max_range specified/
+  end
+
+  should "be initialized" do
+    subject.owner.should.equal @entity
+    subject.can_be_undone?.should.be.false
+    subject.skill.should.equal 5
+    subject.action_cost.should.equal 1
+  end
+
+  should "serialize to json correctly" do
+    JSON.parse(subject.to_json).symbolize.should.equal(
+        type: :ranged,
+        skill: 5,
+        action_cost: 1,
+        min_range: 2,
+        max_range: 5
+    )
+  end
+
+  should "generate appropriate action_data" do
+    stub(@entity).id.returns 12
+    stub(@enemy).id.returns 13
+    stub(@enemy).tile.returns @tile
+    stub(@tile).object.returns @enemy
+    stub(subject).random_damage.returns 5
+    subject.action_data(@enemy).should.equal(
+        ability: :ranged,
+        skill: 5,
+        action_cost: 1,
+
+        owner_id: 12,
+        target_id: 13,
+        target_position: [1, 2],
+        damage: 5
+    )
+  end
+
+  describe "#random_damage" do
+    should "never give a value greater than skill" do
+      stub(subject).rand(is_a(Integer)) {|x| x - 1 }
+      subject.random_damage == 5
+    end
+
+    should "never give a value less than 1" do
+      stub(subject).rand(is_a(Integer)) { 0 }
+      subject.random_damage == 0
+    end
+  end
+
+  describe "#do" do
+    should "remove action points and health" do
+      stub(@entity).map.stub!.object_by_id(13).returns @enemy
+      stub(@entity).action_points.returns 1
+      mock(@entity).action_points = 0
+      mock(@entity).make_ranged_attack(@enemy, 5)
+
+      subject.do action_cost: 1, target_id: 13, damage: 5 #, target_position: [1, 2]
+    end
+  end
+
+  describe "#undo" do
+    should "give action points and health (if target alive)" do
+      stub(@enemy).tile.returns @tile
+      stub(@entity).map.stub!.object_by_id(13).returns @enemy
+      stub(@entity).action_points.returns 0
+      mock(@entity).action_points = 1
+      mock(@entity).make_ranged_attack(@enemy, -5)
+
+      subject.undo action_cost: 1, target_id: 13, damage: 5, target_position: [1, 2]
+    end
+
+    should "give action points, health and return to map (if target dead)" do
+      stub(@enemy).tile.returns nil
+      mock(@enemy).tile = @tile
+      mock(@entity).make_ranged_attack(@enemy, -5)
+
+      stub(@entity).map do
+        stub(@map).object_by_id(13).returns @enemy
+        stub(@map).tile_at_grid([1, 2]).returns @tile
+        @map
+      end
+      stub(@entity).action_points.returns 0
+      mock(@entity).action_points = 1
+
+      subject.undo action_cost: 1, target_id: 13, damage: 5, target_position: [1, 2]
+    end
+  end
+end

data/test/smash_and_grab/abilities/sprint_test.rb

@@ -2,22 +2,32 @@ require_relative "../../teststrap"
 require_relative "helpers/ability_helper"
 
 describe SmashAndGrab::Abilities::Sprint do
-  helper(:entity) { @entity ||= Object.new }
+  before do
+    @entity = Object.new
+    mock(@entity).subscribe :ended_turn
+  end
 
-  subject { SmashAndGrab::Abilities.ability entity, type: :sprint, skill: 3 }
+  subject { SmashAndGrab::Abilities.ability @entity, type: :sprint, skill: 3 }
 
   behaves_like SmashAndGrab::Abilities::Ability
 
   should "fail if not given the required arguments" do
-    ->{ SmashAndGrab::Abilities.ability entity, type: :sprint }.should.raise(ArgumentError).message.should.match /No skill value for/
+    ->{ SmashAndGrab::Abilities.ability @entity, type: :sprint }.should.raise(ArgumentError).message.should.match /No skill value for/
   end
 
   should "be initialized" do
-    subject.owner.should.equal entity
+    stub(@entity).max_action_points.returns 2
+    stub(@entity).action_points.returns 2
+    stub(@entity).max_movement_points.returns 5
+    stub(@entity).movement_points.returns 5
+
+    subject.owner.should.equal @entity
     subject.can_be_undone?.should.be.true
     subject.skill.should.equal 3
+    subject.active?.should.equal false
+    subject.activate?.should.equal true
+    subject.deactivate?.should.equal false
 
-    stub(entity).max_action_points.returns 2
     subject.action_cost.should.equal 2
   end
 
@@ -30,9 +40,9 @@ describe SmashAndGrab::Abilities::Sprint do
   end
 
   should "generate appropriate action_data" do
-    mock(entity).id.returns 12
-    mock(entity).max_movement_points.returns 11
-    mock(entity).max_action_points.returns 2
+    mock(@entity).id.returns 12
+    mock(@entity).max_movement_points.returns 11
+    mock(@entity).max_action_points.returns 2
     subject.action_data.should.equal(
       ability: :sprint,
       skill: 3,
@@ -46,30 +56,50 @@ describe SmashAndGrab::Abilities::Sprint do
   describe "owner has max_mp == 100" do
     { 1 => 1, 2 => 25, 3 => 50, 4 => 75, 5 => 100 }.each do |skill, expected_bonus|
       should "have #movement_bonus == #{expected_bonus} with #skill == #{skill}" do
-        mock(entity).max_movement_points.returns 100
+        mock(@entity).max_movement_points.returns 100
         mock(subject).skill.returns skill
         subject.movement_bonus.should.equal expected_bonus
       end
     end
   end
 
-  describe "#do" do
-    should "increase movement points and decrease action points" do
-      stub(entity).action_points.returns 2
-      mock(entity, :action_points=).with 0
-      mock(entity).movement_points.returns 5
-      mock(entity, :movement_points=).with 10
-      subject.do action_cost: 2, movement_bonus: 5
-    end
-  end
+  # Do and undo operate the same; they toggle on/off based on whether the ability is active?
+  [:do, :undo].each do |meth|
+    describe "##{meth}" do
+      should "toggle on to increase movement points and decrease action points" do
+        stub(@entity).max_action_points.returns 2
+        stub(@entity).action_points.returns 2
+        stub(@entity).max_movement_points.returns 5
+        stub(@entity).movement_points.returns 5
+
+        mock(@entity).action_points = 0
+        mock(@entity).movement_points = 10
+        subject.send meth, action_cost: 2, movement_bonus: 5
+
+        subject.activate?.should.equal false
+        subject.deactivate?.should.equal true
+      end
+
+      should "toggle off to decrease movement points and increase action points" do
+        # Activate first.
+        subject.instance_variable_set :@active, true
+
+        # Now deactivate.
+        stub(@entity).max_action_points.returns 2
+        stub(@entity).action_points.returns 0
+        stub(@entity).max_movement_points.returns 5
+        stub(@entity).movement_points.returns 10
 
-  describe "#undo" do
-    should "decrease movement points and increase action points" do
-      stub(entity).action_points.returns 0
-      mock(entity, :action_points=).with 2
-      stub(entity).movement_points.returns 10
-      mock(entity, :movement_points=).with 5
-      subject.undo action_cost: 2, movement_bonus: 5
+        mock(@entity).action_points = 2
+        mock(@entity).movement_points = 5
+        subject.send meth, action_cost: 2, movement_bonus: 5
+
+        stub(@entity).action_points.returns 2
+        stub(@entity).movement_points.returns 5
+
+        subject.activate?.should.equal true
+        subject.deactivate?.should.equal false
+      end
     end
   end
 end

data/test/smash_and_grab/map/faction_test.rb

@@ -12,23 +12,25 @@ shared SmashAndGrab::Factions::Faction do
 end
 
 describe SmashAndGrab::Factions::Faction do
-  helper(:baddies) { SmashAndGrab::Factions::Baddies.new nil }
-  helper(:goodies) { SmashAndGrab::Factions::Goodies.new nil }
-  helper(:bystanders) { SmashAndGrab::Factions::Bystanders.new nil }
+  before do
+    @baddies = SmashAndGrab::Factions::Baddies.new
+    @goodies = SmashAndGrab::Factions::Goodies.new
+    @bystanders =  SmashAndGrab::Factions::Bystanders.new
+  end
 
-  subject { described.new nil }
+  subject { described.new }
 
   describe SmashAndGrab::Factions::Goodies do
     behaves_like SmashAndGrab::Factions::Faction
 
     should "dislike baddies" do
-      subject.should.be.enemy? baddies
-      subject.should.not.be.friend? baddies
+      subject.should.be.enemy? @baddies
+      subject.should.not.be.friend? @baddies
     end
 
     should "like bystanders" do
-      subject.should.not.be.enemy? bystanders
-      subject.should.be.friend? bystanders
+      subject.should.not.be.enemy? @bystanders
+      subject.should.be.friend? @bystanders
     end
   end
 
@@ -36,13 +38,13 @@ describe SmashAndGrab::Factions::Faction do
     behaves_like SmashAndGrab::Factions::Faction
 
     should "dislike goodies" do
-      subject.should.be.enemy? goodies
-      subject.should.not.be.friend? goodies
+      subject.should.be.enemy? @goodies
+      subject.should.not.be.friend? @goodies
     end
 
     should "dislike bystanders" do
-      subject.should.be.enemy? bystanders
-      subject.should.not.be.friend? bystanders
+      subject.should.be.enemy? @bystanders
+      subject.should.not.be.friend? @bystanders
     end
   end
 
@@ -50,13 +52,13 @@ describe SmashAndGrab::Factions::Faction do
     behaves_like SmashAndGrab::Factions::Faction
 
     should "like goodies" do
-      subject.should.not.be.enemy? goodies
-      subject.should.be.friend? goodies
+      subject.should.not.be.enemy? @goodies
+      subject.should.be.friend? @goodies
     end
 
     should "dislike baddies" do
-      subject.should.be.enemy? baddies
-      subject.should.not.be.friend? baddies
+      subject.should.be.enemy? @baddies
+      subject.should.not.be.friend? @baddies
     end
   end
 end