simp-cli 1.0.12

data/spec/lib/simp/cli/config/item/puppet_hosts_entry_spec.rb

@@ -0,0 +1,85 @@
+require 'simp/cli/config/item/puppet_hosts_entry'
+require 'simp/cli/config/item/puppet_server'
+require 'simp/cli/config/item/puppet_server_ip'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetHostsEntry do
+  before :all do
+    @ci        = Simp::Cli::Config::Item::PuppetHostsEntry.new
+    @ci.silent = true   # turn off command line summary on stdout
+    @files_dir = File.expand_path( 'files', File.dirname( __FILE__ ) )
+    @tmp_dir   = File.expand_path( 'tmp', File.dirname( __FILE__ ) )
+  end
+
+  describe "#apply" do
+    before :context do
+      @tmp_file        = File.join( @tmp_dir, 'test__hosts' )
+      @file            = File.join( @files_dir,'hosts')
+      @ci.file         = @tmp_file
+
+      item             = Simp::Cli::Config::Item::PuppetServerIP.new
+      item.value       = '1.2.3.4'
+      @ci.config_items[item.key] = item
+
+      item             = Simp::Cli::Config::Item::PuppetServer.new
+      item.value       = 'puppet.domain.tld'
+      @ci.config_items[item.key] = item
+    end
+
+    context "with a fresh hosts file" do
+      before :context do
+        FileUtils.mkdir_p   @tmp_dir
+        FileUtils.copy_file @file, @tmp_file
+
+        @result = @ci.apply
+      end
+
+      it "configures hosts with the correct values" do
+        lines = File.readlines( @tmp_file ).join( "\n" )
+        expect( lines ).to match(%r{\bpuppet.domain.tld\b})
+      end
+
+      it "reports success" do
+        expect( @result ).to eq true
+      end
+
+      after :context do
+        FileUtils.rm @tmp_file
+      end
+    end
+
+
+    context "with an existing hosts file" do
+      before :context do
+        FileUtils.mkdir_p   @tmp_dir
+        FileUtils.copy_file @file, @tmp_file
+
+        @result = @ci.apply
+      end
+
+      it "configures hosts with the correct values" do
+        lines = File.readlines( @tmp_file ).join( "\n" )
+        expect( lines ).to match(%r{\bpuppet.domain.tld\b})
+      end
+
+      it "replaces puppet host/aliases with the correct values" do
+        lines = File.readlines( @tmp_file ).each do |line|
+          expect( line ).to_not match(%r{\bpuppet.example.com\b})
+        end
+      end
+
+      it "reports success" do
+        expect( @result ).to eq true
+      end
+
+      after :context do
+        FileUtils.rm @tmp_file
+      end
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end
+

data/spec/lib/simp/cli/config/item/puppet_server_ip_spec.rb

@@ -0,0 +1,24 @@
+require 'simp/cli/config/item/puppet_server_ip'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetServerIP do
+  before :each do
+    @ci = Simp::Cli::Config::Item::PuppetServerIP.new
+  end
+
+  describe "#validate" do
+    it "validates IPv4 IPs" do
+      expect( @ci.validate '192.168.1.1' ).to eq true
+    end
+
+    it "doesn't validate bad IPs" do
+      expect( @ci.validate 'x.x.x.x' ).to eq false
+      expect( @ci.validate '999.999.999.999' ).to eq false
+      expect( @ci.validate '192.168.1.1/24' ).to eq false
+      expect( @ci.validate nil ).to eq false
+      expect( @ci.validate false ).to eq false
+    end
+  end
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/puppet_server_spec.rb

@@ -0,0 +1,22 @@
+require 'simp/cli/config/item/puppet_server'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetServer do
+  before :each do
+    @ci = Simp::Cli::Config::Item::PuppetServer.new
+  end
+
+  describe "#validate" do
+    it "validates fqdns" do
+      expect( @ci.validate 'puppet' ).to eq true
+      expect( @ci.validate 'puppet.change.me' ).to eq true
+    end
+
+    it "doesn't validate bad fqdns" do
+      expect( @ci.validate 'puppet-' ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/puppetdb_port_spec.rb

@@ -0,0 +1,25 @@
+require 'simp/cli/config/item/puppetdb_port'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetDBPort do
+  before :each do
+    @ci = Simp::Cli::Config::Item::PuppetDBPort.new
+    @ci.silent = true
+  end
+
+  describe "#validate" do
+    it "validates proper port number" do
+      expect( @ci.validate '8139' ).to eq true
+    end
+
+    it "doesn't validate nonsense" do
+      expect( @ci.validate '0' ).to         eq false
+      expect( @ci.validate '-1' ).to        eq false
+      expect( @ci.validate '999999999' ).to eq false
+      expect( @ci.validate 'fred' ).to      eq false
+      expect( @ci.validate '' ).to          eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/puppetdb_server_spec.rb

@@ -0,0 +1,25 @@
+require 'simp/cli/config/item/puppetdb_server'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetDBServer do
+  before :each do
+    @ci = Simp::Cli::Config::Item::PuppetDBServer.new
+    @ci.silent = true
+  end
+
+  describe "#validate" do
+    it "validates puppet fqdn" do
+      expect( @ci.validate 'puppet.change.me' ).to eq true
+    end
+
+    it "validates hiera" do
+      expect( @ci.validate "%{hiera('puppet::server')}" ).to eq true
+    end
+
+    it "doesn't validate empty string" do
+      expect( @ci.validate '' ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/remove_ldap_from_hiera_spec.rb

@@ -0,0 +1,58 @@
+require 'simp/cli/config/item/remove_ldap_from_hiera'
+require 'simp/cli/config/item/hostname'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::RemoveLdapFromHiera do
+  before :each do
+    @ci        = Simp::Cli::Config::Item::RemoveLdapFromHiera.new
+    @ci.silent = true
+  end
+
+  describe "#strip_line?" do
+    it 'decides to strip ::ldap and openldap:: classes' do
+      expect(@ci.strip_line?('  - simp::ldap_server')).to be true
+      expect(@ci.strip_line?(%q{  - 'simp::ldap_server'})).to be true
+      expect(@ci.strip_line?('  - openldap')).to be true
+      expect(@ci.strip_line?('  - openldap::server')).to be true
+    end
+
+    it 'rejects false positives' do
+      expect(@ci.strip_line?( '#  - simp::ldap_server')).to be false
+      expect(@ci.strip_line?('  - randomldap::foo')).to be false
+    end
+  end
+
+  describe "#apply" do
+    context "with a valid fqdn" do
+      before :each do
+        @fqdn            = 'hostname.domain.tld'
+        @files_dir       = File.expand_path( 'files', File.dirname( __FILE__ ) )
+        @tmp_dir         = File.expand_path( 'tmp', File.dirname( __FILE__ ) )
+        @file            = File.join( @files_dir,'puppet.your.domain.yaml')
+        @tmp_file        = File.join( @tmp_dir, "#{@fqdn}.yaml" )
+        @ci.dir          = @tmp_dir
+
+        item             = Simp::Cli::Config::Item::Hostname.new
+        item.value       = @fqdn
+        @ci.config_items[item.key] = item
+        @new_file        = File.join( @tmp_dir, "#{@fqdn}.yaml" )
+
+        [@tmp_file, @new_file].each do |file|
+          FileUtils.rm file if File.exists? file
+        end
+
+        FileUtils.mkdir_p   @tmp_dir
+        FileUtils.copy_file @file, @tmp_file
+
+        @result = @ci.apply
+      end
+
+      it "file won't have any lines containing ldap" do
+        expect( File.open(@tmp_file).readlines.join("\n") ).not_to match(/ldap/)
+      end
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like 'a child of Simp::Cli::Config::Item'
+end

data/spec/lib/simp/cli/config/item/rename_fqdn_yaml_spec.rb

@@ -0,0 +1,63 @@
+require 'simp/cli/config/item/rename_fqdn_yaml'
+require 'simp/cli/config/item/hostname'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::RenameFqdnYaml do
+  before :all do
+    @ci        = Simp::Cli::Config::Item::RenameFqdnYaml.new
+    @ci.silent = true   # turn off command line summary on stdout
+  end
+
+  context "when ensuring the hosts entry" do
+    before :context do
+      @files_dir       = File.expand_path( 'files', File.dirname( __FILE__ ) )
+      @tmp_dir         = File.expand_path( 'tmp', File.dirname( __FILE__ ) )
+      @file            = File.join( @files_dir,'puppet.your.domain.yaml')
+      @tmp_file        = File.join( @tmp_dir, 'temp__puppet.your.domain.yaml' )
+      @ci.file         = @tmp_file
+
+      @fqdn            = 'hostname.domain.tld'
+      item             = Simp::Cli::Config::Item::Hostname.new
+      item.value       = @fqdn
+      @ci.config_items[item.key] = item
+      @new_file        = File.join( @tmp_dir, "#{@fqdn}.yaml" )
+    end
+
+
+    context "when moving the yaml file" do
+      before :context do
+        [@tmp_file, @new_file].each do |file|
+          FileUtils.rm file if File.exists? file
+        end
+
+        FileUtils.mkdir_p   @tmp_dir
+        FileUtils.copy_file @file, @tmp_file
+
+        @result = @ci.apply
+      end
+
+      it "places a file in the correct location" do
+        expect( File ).to exist( @new_file )
+      end
+
+      it "doesn't leave a file in the old location" do
+        expect( File ).not_to exist( @tmp_file )
+      end
+
+      it "reports success" do
+        expect( @result ).to eq true
+      end
+
+      after :context do
+        [@tmp_file, @new_file].each do |file|
+          FileUtils.rm file if File.exists? file
+        end
+      end
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end
+

data/spec/lib/simp/cli/config/item/rsync_base_spec.rb

@@ -0,0 +1,28 @@
+require 'simp/cli/config/item/rsync_base'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::RsyncBase do
+  before :each do
+    @ci = Simp::Cli::Config::Item::RsyncBase.new
+  end
+
+  describe "#validate" do
+    it "validates a good rsync base path" do
+      expect( @ci.validate "/var/simp/rsync/%{::operatingsystem}/%{::lsbmajdistrelease}" ).to eq true
+      expect( @ci.validate "/srv/simp/rsync/%{::operatingsystem}/%{::lsbmajdistrelease}" ).to eq true
+    end
+
+    it "doesn't validate bad rsync base paths" do
+      expect( @ci.validate '..' ).to eq false
+    end
+  end
+
+  describe "#recommended_value" do
+    it "recommends a /srv or /var/simp path" do
+      expect( @ci.recommended_value ).to match %r{^(/var/simp/rsync|/srv/simp/rsync|/srv/rsync)}
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/rsync_server_spec.rb

@@ -0,0 +1,41 @@
+require 'simp/cli/config/item/rsync_server'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::RsyncServer do
+  before :each do
+    @files_dir   = File.expand_path( 'files', File.dirname( __FILE__ ) )
+    @ci          = Simp::Cli::Config::Item::RsyncServer.new
+    @ci.silent   = true
+  end
+
+  describe "#validate" do
+    it "validates a good rsync server" do
+      expect( @ci.validate 'puppet.simp.dev' ).to eq true
+      expect( @ci.validate '127.0.0.1' ).to eq true
+    end
+
+    it "doesn't validate nonsense" do
+      expect( @ci.validate '..' ).to eq false
+    end
+  end
+
+  describe "os_value" do
+    it "reads address from rsyncd.conf file" do
+      @ci.file = File.join( @files_dir, 'rsyncd.conf' )
+      expect( @ci.os_value ).to eq '127.0.0.1'
+    end
+
+    it "returns nil if file does not contain address" do
+      @ci.file = '/dev/null'
+      expect( @ci.os_value ).to be_falsey
+    end
+
+    it "returns nil if file is not readable" do
+      @ci.file = '/proc/nonsense/blahblahblah/.........'
+      expect( @ci.os_value ).to be_falsey
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/rsync_timeout_spec.rb

@@ -0,0 +1,21 @@
+require 'simp/cli/config/item/rsync_timeout'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::RsyncTimeout do
+  before :each do
+    @ci = Simp::Cli::Config::Item::RsyncTimeout.new
+  end
+
+  describe "#validate" do
+    it "validates a good rsync timeout" do
+      expect( @ci.validate "1" ).to eq true
+    end
+
+    it "doesn't validate a bad rsync timeout" do
+      expect( @ci.validate '-1' ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/set_grub_password_spec.rb

@@ -0,0 +1,29 @@
+require 'simp/cli/config/item/set_grub_password'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::SetGrubPassword do
+  before :each do
+    @ci = Simp::Cli::Config::Item::SetGrubPassword.new
+  end
+
+  describe "#validate" do
+    it "validates yes/no" do
+      expect( @ci.validate 'yes' ).to eq true
+      expect( @ci.validate 'y' ).to   eq true
+      expect( @ci.validate 'Y' ).to   eq true
+      expect( @ci.validate 'no' ).to  eq true
+      expect( @ci.validate 'n' ).to   eq true
+      expect( @ci.validate 'NO' ).to  eq true
+      expect( @ci.validate true ).to   eq true
+      expect( @ci.validate false ).to  eq true
+    end
+
+    it "doesn't validate other things" do
+      expect( @ci.validate 'ydd' ).to  eq false
+      expect( @ci.validate 'gsdg' ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/simp_yum_servers_spec.rb

@@ -0,0 +1,41 @@
+require 'simp/cli/config/item/simp_yum_servers'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::SimpYumServers do
+  before :each do
+    @ci = Simp::Cli::Config::Item::SimpYumServers.new
+  end
+
+  describe "#validate" do
+    it "validates array with good hosts" do
+      expect( @ci.validate ['yum'] ).to eq true
+      expect( @ci.validate ['yum-server'] ).to eq true
+      expect( @ci.validate ['yum.yummityyum.org'] ).to eq true
+      expect( @ci.validate ['192.168.1.1'] ).to eq true
+      expect( @ci.validate ['192.168.1.1'] ).to eq true
+      expect( @ci.validate ["%{hiera('puppet::server')}"] ).to eq true
+      expect( @ci.validate ["%{::domain}"] ).to eq true
+
+      # yum_servers is allowed to be empty
+      expect( @ci.validate nil ).to eq true
+      expect( @ci.validate '   ' ).to eq true
+      expect( @ci.validate '' ).to eq true
+      expect( @ci.validate [] ).to eq true
+    end
+
+    it "doesn't validate array with bad hosts" do
+      expect( @ci.validate 0     ).to eq false
+      expect( @ci.validate false ).to eq false
+      expect( @ci.validate [nil] ).to eq false
+      expect( @ci.validate ['yum-'] ).to eq false
+      expect( @ci.validate ['-yum'] ).to eq false
+      expect( @ci.validate ['yum.yummityyum.org.'] ).to eq false
+      expect( @ci.validate ['.yum.yummityyum.org'] ).to eq false
+      expect( @ci.validate ["%[hiera('puppet::server')]"] ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end
+