simp-cli 1.0.12

data/spec/lib/simp/cli/config/item/add_ldap_to_hiera_spec.rb

@@ -0,0 +1,58 @@
+require 'simp/cli/config/item/add_ldap_to_hiera'
+require 'simp/cli/config/item/hostname'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::AddLdapToHiera do
+  before :each do
+    @ci        = Simp::Cli::Config::Item::AddLdapToHiera.new
+    @ci.silent = true
+  end
+
+  # describe "#contains_ldap?" do
+  #   it 'decides to strip ::ldap and openldap:: classes' do
+  #     expect(@ci.contains_ldap?('  - simp::ldap_server')).to be true
+  #     expect(@ci.contains_ldap?(%q{  - 'simp::ldap_server'})).to be true
+  #     expect(@ci.contains_ldap?('  - openldap')).to be true
+  #     expect(@ci.contains_ldap?('  - openldap::server')).to be true
+  #   end
+  #
+  #   it 'rejects false positives' do
+  #     expect(@ci.contains_ldap?( '#  - simp::ldap_server')).to be false
+  #     expect(@ci.contains_ldap?('  - randomldap::foo')).to be false
+  #   end
+  # end
+
+  describe "#apply" do
+    context "with a valid fqdn" do
+      before :each do
+        @fqdn            = 'hostname.domain.tld'
+        @files_dir       = File.expand_path( 'files', File.dirname( __FILE__ ) )
+        @tmp_dir         = File.expand_path( 'tmp', File.dirname( __FILE__ ) )
+        @file            = File.join( @files_dir,'puppet.your.domain.yaml')
+        @tmp_file        = File.join( @tmp_dir, "#{@fqdn}.yaml" )
+        @ci.dir          = @tmp_dir
+
+        item             = Simp::Cli::Config::Item::Hostname.new
+        item.value       = @fqdn
+        @ci.config_items[item.key] = item
+        @new_file        = File.join( @tmp_dir, "#{@fqdn}.yaml" )
+
+        [@tmp_file, @new_file].each do |file|
+          FileUtils.rm file if File.exists? file
+        end
+
+        FileUtils.mkdir_p   @tmp_dir
+        FileUtils.copy_file @file, @tmp_file
+
+        @result = @ci.apply
+      end
+
+      it "file will contain the simp::ldap_server class" do
+        expect( File.open(@tmp_file).readlines.join("\n") ).to match(/simp::ldap_server/)
+      end
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like 'a child of Simp::Cli::Config::Item'
+end

data/spec/lib/simp/cli/config/item/answers_yaml_file_writer_spec.rb

@@ -0,0 +1,86 @@
+require 'simp/cli/config/item/answers_yaml_file_writer'
+require 'simp/cli/config/item/puppet_server'
+require 'simp/cli/config/item/puppet_server_ip'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::AnswersYAMLFileWriter do
+  before :all do
+    @ci        = Simp::Cli::Config::Item::AnswersYAMLFileWriter.new
+    @ci.silent = true   # turn off command line summary on stdout
+    @tmp_dir   = File.expand_path( 'tmp', File.dirname( __FILE__ ) )
+  end
+
+
+  describe "#print_answers_yaml" do
+    before :each do
+      ci                = Simp::Cli::Config::Item.new
+      ci.key            = 'item'
+      ci.value          = 'foo'
+      ci.description    = 'A simple item'
+      list              = { foo: ci }
+
+      ci                = Simp::Cli::Config::ListItem.new
+      ci.key            = 'list'
+      ci.value          = ['one','two','three']
+      ci.description    = 'A simple list'
+      list[ci.key]      = ci
+
+      ci                = Simp::Cli::Config::YesNoItem.new
+      ci.key            = 'yesno'
+      ci.value          = true
+      ci.description    = 'A simple yes/no item'
+      list[ci.key]      = ci
+
+      @simple_item_list = list
+    end
+
+    it "prints parseable yaml" do
+      io = StringIO.new
+      @ci.print_answers_yaml( io, @simple_item_list )
+      y = YAML.load( io.string )
+
+      expect( y ).to be_kind_of Hash
+      expect( y ).not_to be_empty
+      expect( y['item'] ).to  eq('foo')
+      expect( y['list'] ).to  eq(['one','two','three'])
+      expect( y['yesno'] ).to eq(true)
+    end
+  end
+
+
+  context "when writing a yaml file" do
+    before :context do
+      item             = Simp::Cli::Config::Item::PuppetServerIP.new
+      item.value       = '1.2.3.4'
+      @ci.config_items[item.key] = item
+
+      item             = Simp::Cli::Config::Item::PuppetServer.new
+      item.value       = 'puppet.domain.tld'
+      @ci.config_items[item.key] = item
+
+      @tmp_file = File.expand_path( 'answers_yaml_file_writer.yaml', @tmp_dir )
+      FileUtils.mkdir_p   @tmp_dir
+      @ci.file = @tmp_file
+      @ci.apply
+    end
+
+    it "writes a file" do
+      expect( File.exists?( @tmp_file ) ).to be true
+    end
+
+    it "writes the correct values" do
+      lines = File.readlines( @tmp_file ).join( "\n" )
+      expect( lines ).to match(%r{^\W*puppet::server\W*:\W*puppet.domain.tld\b})
+      expect( lines ).to match(%r{^\W*puppet::server::ip\W*:\W*1.2.3.4\b})
+    end
+
+    after :context do
+      FileUtils.rm @tmp_file
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end
+

data/spec/lib/simp/cli/config/item/certificates_spec.rb

@@ -0,0 +1,50 @@
+require 'simp/cli/config/item/certificates'
+require 'simp/cli/config/item/hostname'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::Certificates do
+  before :each do
+    @ci        = Simp::Cli::Config::Item::Certificates.new
+    @ci.silent = true
+    @hostname  = 'puppet.testing.fqdn'
+    item       = Simp::Cli::Config::Item::Hostname.new
+    item.value = @hostname
+    @ci.config_items[ item.key ] = item
+
+    @files_dir = File.expand_path( 'files', File.dirname( __FILE__ ) )
+  end
+
+
+  describe "#apply" do
+    context 'using external files,' do
+      before :each do
+        @tmp_dir  = Dir.mktmpdir( File.basename(__FILE__),
+                                  File.expand_path('tmp', File.dirname( __FILE__ )) )
+        @tmp_dirs = {
+                      :keydist => File.join( @tmp_dir, 'keydist'),
+                      :fake_ca => File.join( @tmp_dir, 'FakeCA'),
+                    }
+        FileUtils.mkdir @tmp_dirs.values
+        src_dir   = File.join(@files_dir,'FakeCA')
+        FileUtils.cp_r( Dir["#{src_dir}/*"], @tmp_dirs[:fake_ca] )
+
+        @ci.dirs   = @tmp_dirs
+        @ci.apply
+      end
+
+      it 'runs gencerts_nopass.sh auto' do
+        dir = File.join( @tmp_dirs[:keydist], @hostname )
+        expect( File.exists? dir ).to be true
+      end
+
+      after :each do
+        FileUtils.remove_entry_secure @tmp_dir
+      end
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like 'a child of Simp::Cli::Config::Item'
+end
+

data/spec/lib/simp/cli/config/item/client_nets_spec.rb

@@ -0,0 +1,66 @@
+require 'simp/cli/config/item/client_nets'
+
+require 'simp/cli/config/item/ipaddress'
+require 'simp/cli/config/item/netmask'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::ClientNets do
+  before :each do
+    @ci = Simp::Cli::Config::Item::ClientNets.new
+    @ci.silent = true
+  end
+
+
+  describe "#recommended_value" do
+    it "recommends no CIDR notation when IP + netmask are unavailable" do
+      expect( @ci.recommended_value ).to be_nil
+    end
+
+    it "recommends correct CIDR notation for a given IP + netmask" do
+      @ci.config_items = create_prior_items( '10.10.6.227', '255.255.255.0' )
+      expect( @ci.recommended_value ).to eq ['10.10.6.0/24']
+
+      @ci.config_items = create_prior_items( '10.10.10.99', '255.255.255.224' )
+      expect( @ci.recommended_value ).to eq ['10.10.10.96/27']
+    end
+  end
+
+
+  describe "#validate" do
+    it "validates array of good cidr nets" do
+      expect( @ci.validate ['10.0.71.0/24'] ).to eq true
+      expect( @ci.validate ['1.2.3.0/24'] ).to eq true
+      expect( @ci.validate ['10.10.10.0/16', '192.168.1.0/23'] ).to eq true
+      # crazy, but valid CIDR (equiv to 33,554,432 class C networks!)
+      expect( @ci.validate ['1.2.3.0/0'] ).to eq true
+    end
+
+    it "doesn't validate array with bad cidr nets" do
+      expect( @ci.validate 0     ).to eq false
+      expect( @ci.validate nil   ).to eq false
+      expect( @ci.validate false ).to eq false
+      expect( @ci.validate [nil] ).to eq false
+      expect( @ci.validate ['1.2.3.999/24'] ).to eq false
+      expect( @ci.validate ['1.2.3.999/24/24'] ).to eq false
+      expect( @ci.validate ['1.2.3.999/z'] ).to eq false
+      expect( @ci.validate ['1.2.3.0/24', '192.168.1.0/99'] ).to eq false
+    end
+
+    it "doesn't validate an empty array" do
+      expect( @ci.validate [] ).to eq false
+    end
+  end
+
+  def create_prior_items ip, netmask
+    items = {}
+    _ip = Simp::Cli::Config::Item::IPAddress.new
+    _ip.value = ip
+    items[ _ip.key ] = _ip
+    _netmask = Simp::Cli::Config::Item::Netmask.new
+    _netmask.value = netmask
+    items[ _netmask.key ] = _netmask
+    items
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/common_runlevel_default_spec.rb

@@ -0,0 +1,27 @@
+require 'simp/cli/config/item/common_runlevel_default'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::CommonRunLevelDefault do
+  before :each do
+    @ci = Simp::Cli::Config::Item::CommonRunLevelDefault.new
+  end
+
+  describe "#validate" do
+    it "validates common_runlevel_defaults" do
+      expect( @ci.validate '1' ).to eq true
+      expect( @ci.validate '3' ).to eq true
+      expect( @ci.validate '5' ).to eq true
+    end
+
+    it "doesn't validate bad common_runlevel_defaults" do
+      expect( @ci.validate '' ).to eq false
+      expect( @ci.validate '0' ).to eq false
+      expect( @ci.validate '7' ).to eq false
+      expect( @ci.validate nil ).to eq false
+      expect( @ci.validate false ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/dns_search_spec.rb

@@ -0,0 +1,74 @@
+require 'simp/cli/config/item/dns_search'
+require 'simp/cli/config/item/hostname'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::DNSSearch do
+  before :all do
+    @files_dir = File.expand_path( 'files', File.dirname( __FILE__ ) )
+  end
+
+  before :each do
+    @ci = Simp::Cli::Config::Item::DNSSearch.new
+  end
+
+
+  describe '#recommended_value' do
+    context 'when /etc/resolv.conf is populated' do
+      it 'handles a single domain' do
+        @ci.file = File.join(@files_dir,'resolv.conf__single')
+        expect( @ci.recommended_value).to eq ['tasty.bacon']
+      end
+
+      it 'handles multiple domains' do
+        @ci.file = File.join(@files_dir,'resolv.conf__multiple')
+        expect( @ci.recommended_value).to eq ['tasty.bacon', 'yucky.bacon', 'instant.bacon']
+      end
+    end
+
+    context 'when /etc/resolv.conf is empty' do
+      before :each do
+        @ci.file = '/dev/null'
+      end
+
+      it 'recommends ipaddress (when available)' do
+        fqdn = Simp::Cli::Config::Item::Hostname.new
+        fqdn.value = 'puppet.snazzy.domain'
+        @ci.config_items[ fqdn.key ] = fqdn
+
+        expect( @ci.recommended_value.size ).to eq 1
+        expect( @ci.recommended_value      ).to eq ['snazzy.domain']
+      end
+
+      it 'recommends a must-change value (when ipaddress is not available)' do
+        expect( @ci.recommended_value.size  ).to eq 1
+        expect( @ci.recommended_value.first ).to match( /change/ )
+      end
+    end
+  end
+
+
+  describe "#validate" do
+    it "validates array with domains" do
+      expect( @ci.validate ['simp.dev', 'google.com', '0simp.dev'] ).to eq true
+    end
+
+    it "doesn't validate array with bad domains" do
+      expect( @ci.validate [nil]         ).to eq false
+      expect( @ci.validate ['simp.dev.'] ).to eq false
+      expect( @ci.validate ['.simp.dev'] ).to eq false
+    end
+
+    it "doesn't validate empty array" do
+      expect( @ci.validate []         ).to eq false
+    end
+
+    it "doesn't validate nonsense" do
+      expect( @ci.validate 0             ).to eq false
+      expect( @ci.validate nil           ).to eq false
+      expect( @ci.validate false         ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end
+

data/spec/lib/simp/cli/config/item/dns_servers_spec.rb

@@ -0,0 +1,76 @@
+require 'simp/cli/config/item/dns_servers'
+require 'simp/cli/config/item/ipaddress'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::DNSServers do
+  before :all do
+    @files_dir = File.expand_path( 'files', File.dirname( __FILE__ ) )
+  end
+
+  before :each do
+    @ci = Simp::Cli::Config::Item::DNSServers.new
+  end
+
+  describe '#recommended_value' do
+    context 'when /etc/resolv.conf is populated' do
+      it 'handles a single nameserver' do
+        @ci.file = File.join(@files_dir,'resolv.conf__single')
+        expect( @ci.recommended_value.size).to eq 1
+        expect( @ci.recommended_value).to eq ['10.0.0.1']
+      end
+
+      it 'handles multiple nameservers' do
+        @ci.file = File.join(@files_dir,'resolv.conf__multiple')
+        expect( @ci.recommended_value.size).to eq 3
+        expect( @ci.recommended_value).to eq ['10.0.0.1', '10.0.0.2', '10.0.0.3']
+      end
+    end
+
+    context 'when /etc/resolv.conf is empty' do
+      before :each do
+        @ci.file = '/dev/null'
+      end
+
+      it 'recommends ipaddress (when available)' do
+        ip = Simp::Cli::Config::Item::IPAddress.new
+        ip.value = '1.2.3.4'
+        @ci.config_items[ ip.key ] = ip
+
+        expect( @ci.recommended_value      ).to eq ['1.2.3.4']
+      end
+
+      it 'recommends a must-change value (when ipaddress is not available)' do
+        expect( @ci.recommended_value.first ).to match( /change/ )
+      end
+    end
+  end
+
+  describe '#validate' do
+    it 'validates array with good IPs' do
+      expect( @ci.validate ['10.0.71.1']              ).to eq true
+      expect( @ci.validate ['192.168.1.1', '8.8.8.8'] ).to eq true
+    end
+
+    it "doesn't validate array with bad IPs" do
+      expect( @ci.validate [nil]          ).to eq false
+      expect( @ci.validate ['1.2.3']      ).to eq false
+      expect( @ci.validate ['1.2.3.999']  ).to eq false
+      expect( @ci.validate ['8.8.8.8.']   ).to eq false
+      expect( @ci.validate ['1.2.3.4.5']  ).to eq false
+      expect( @ci.validate ['1.2.3.4/24'] ).to eq false
+    end
+
+    it "doesn't validate empty array" do
+      expect( @ci.validate []         ).to eq false
+    end
+
+    it "doesn't validate nonsense" do
+      expect( @ci.validate 0             ).to eq false
+      expect( @ci.validate nil           ).to eq false
+      expect( @ci.validate false         ).to eq false
+    end
+  end
+
+  it_behaves_like 'a child of Simp::Cli::Config::Item'
+end
+

data/spec/lib/simp/cli/config/item/failover_log_servers_spec.rb

@@ -0,0 +1,49 @@
+require 'simp/cli/config/item/failover_log_servers'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::FailoverLogServers do
+  before :each do
+    @ci = Simp::Cli::Config::Item::FailoverLogServers.new
+  end
+
+  describe "#recommended_value" do
+    it "recommends nil when gateway is unavailable" do
+      expect( @ci.recommended_value ).to be_nil
+    end
+  end
+
+  describe "#validate" do
+    it "validates array with good hosts" do
+      expect( @ci.validate ['log'] ).to eq true
+      expect( @ci.validate ['log-server'] ).to eq true
+      expect( @ci.validate ['log.loggitylog.org'] ).to eq true
+      expect( @ci.validate ['192.168.1.1'] ).to eq true
+      expect( @ci.validate ['192.168.1.1', 'log.loggitylog.org'] ).to eq true
+
+      # failover_log_servers is optional and can be empty
+      expect( @ci.validate nil   ).to eq true
+      expect( @ci.validate '' ).to    eq true
+      expect( @ci.validate '   ' ).to eq true
+    end
+
+    it "doesn't validate array with bad hosts" do
+      expect( @ci.validate 0     ).to eq false
+      expect( @ci.validate false ).to eq false
+      expect( @ci.validate [nil] ).to eq false
+      expect( @ci.validate ['log-'] ).to eq false
+      expect( @ci.validate ['-log'] ).to eq false
+      expect( @ci.validate ['log.loggitylog.org.'] ).to eq false
+      expect( @ci.validate ['.log.loggitylog.org'] ).to eq false
+
+    end
+
+    it "accepts an empty list" do
+      expect( @ci.validate [] ).to eq true
+      expect( @ci.validate "" ).to eq true
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end
+