simp-cli 1.0.12

data/spec/lib/simp/cli/config/item/network_conf_spec.rb

@@ -0,0 +1,63 @@
+require 'simp/cli/config/item/network_conf'
+
+require 'simp/cli/config/item/network_interface'
+require 'simp/cli/config/item/dns_search'
+require 'simp/cli/config/item/dns_servers'
+require 'simp/cli/config/item/gateway'
+require 'simp/cli/config/item/hostname'
+require 'simp/cli/config/item/ipaddress'
+require 'simp/cli/config/item/netmask'
+require 'simp/cli/config/item/network_dhcp'
+
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::NetworkConf do
+  before :each do
+    @ci = Simp::Cli::Config::Item::NetworkConf.new
+  end
+
+
+  # TODO: how to test this?
+  describe "#apply" do
+    it "will puppet apply a static network interface" do
+      @ci.config_items = init_config_items( {'dhcp' => 'static'} )
+      skip "FIXME: how shall we test NetworkConf#apply()?"
+      @ci.apply
+    end
+
+    it "will puppet apply a dhcp network interface" do
+      @ci.config_items = init_config_items( {'dhcp' => 'dhcp'} )
+      skip "FIXME: how shall we test NetworkConf#apply()?"
+      @ci.apply
+    end
+  end
+
+
+  # helper method to create a number of previous answers
+  def init_config_items( extra_answers={} )
+    answers = {}
+    things  = {
+      'NetworkInterface' => 'br1',
+      'DHCP'             => 'static',
+      'Hostname'         => 'scli.tasty.bacon',
+      'IPAddress'        => '10.0.71.50',
+      'Netmask'          => '255.255.255.0',
+      'Gateway'          => '10.0.71.1',
+      'DNSServers'       => ['10.0.71.7', '8.8.8.8'],
+      'DNSSearch'        => 'tasty.bacon',
+    }
+    things.each do |name,value|
+      item = Simp::Cli::Config::Item.const_get(name).new
+      if extra_answers.keys.include? item.key
+        item.value = extra_answers.fetch( item.key )
+      else
+        item.value = value
+      end
+      answers[ item.key ] = item
+    end
+    answers
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  #it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/network_dhcp_spec.rb

@@ -0,0 +1,11 @@
+require 'simp/cli/config/item/network_dhcp'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::DHCP do
+  before :each do
+    @ci = Simp::Cli::Config::Item::DHCP.new
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/network_interface_spec.rb

@@ -0,0 +1,26 @@
+require 'simp/cli/config/item/network_interface'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::NetworkInterface do
+  before :each do
+    @ci = Simp::Cli::Config::Item::NetworkInterface.new
+  end
+
+  describe "#initialize" do
+    subject{ @ci }
+    its(:key){ is_expected.to eq( 'network::interface') }
+  end
+
+  describe "#validate" do
+    subject{ @ci }
+    it "doesn't validate nonsensical interfaces" do
+      expect( @ci.validate( 'lo' ) ).to eq false
+      expect( @ci.validate( '' ) ).to eq false
+      # assuming no one has a "nerbaderp" interface...
+      expect( @ci.validate( 'nerbaderp' ) ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/network_setup_nic_spec.rb

@@ -0,0 +1,29 @@
+require 'simp/cli/config/item/network_setup_nic'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::SetupNIC do
+  before :each do
+    @ci = Simp::Cli::Config::Item::SetupNIC.new
+  end
+
+  describe "#validate" do
+    it "validates yes/no" do
+      expect( @ci.validate 'yes' ).to eq true
+      expect( @ci.validate 'y'   ).to eq true
+      expect( @ci.validate 'Y'   ).to eq true
+      expect( @ci.validate 'no'  ).to eq true
+      expect( @ci.validate 'n'   ).to eq true
+      expect( @ci.validate 'NO'  ).to eq true
+      expect( @ci.validate true  ).to eq true
+      expect( @ci.validate false ).to eq true
+    end
+
+    it "doesn't validate other things" do
+      expect( @ci.validate 'ydd'  ).to eq false
+      expect( @ci.validate 'gsdg' ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/ntp_servers_spec.rb

@@ -0,0 +1,43 @@
+require 'simp/cli/config/item/ntp_servers'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::NTPServers do
+  before :each do
+    @ci = Simp::Cli::Config::Item::NTPServers.new
+    @ci.silent = true
+  end
+
+#  describe "#recommended_value" do
+#  TODO: how to test this when os_value returns a valid value?
+#    it "recommends nil when gateway is unavailable" do
+#      expect( @ci.recommended_value ).to be_nil
+#    end
+#  end
+
+  describe "#validate" do
+    it "validates array with good hosts" do
+      expect( @ci.validate ['pool.ntp.org'] ).to eq true
+      expect( @ci.validate ['192.168.1.1'] ).to eq true
+      expect( @ci.validate ['192.168.1.1', 'pool.ntp.org'] ).to eq true
+      # NTP servers are optional, so nil is okay
+      expect( @ci.validate nil   ).to eq true
+    end
+
+    it "doesn't validate array with bad hosts" do
+      expect( @ci.validate 0     ).to eq false
+      expect( @ci.validate false ).to eq false
+      expect( @ci.validate [nil] ).to eq false
+      expect( @ci.validate ['pool.ntp.org.'] ).to eq false
+      expect( @ci.validate ['192.168.1.1.'] ).to eq false
+      expect( @ci.validate ['1.2.3.4/24'] ).to eq false
+    end
+
+    it "accepts an empty list" do
+      expect( @ci.validate [] ).to eq true
+      expect( @ci.validate "" ).to eq true
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/puppet_autosign_spec.rb

@@ -0,0 +1,55 @@
+require 'simp/cli/config/item/puppet_autosign'
+require 'simp/cli/config/item/hostname'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetAutosign do
+  before :each do
+    @file_dir  = File.expand_path( 'files',  File.dirname( __FILE__ ) )
+    tmp_dir    = File.expand_path( 'tmp',  File.dirname( __FILE__ ) )
+    @tmp_dir   = Dir.mktmpdir(File.basename(__FILE__), tmp_dir )
+    @ci        = Simp::Cli::Config::Item::PuppetAutosign.new
+    @ci.silent = true
+
+    # add hostname to ConfigItems
+    item             = Simp::Cli::Config::Item::Hostname.new
+    item.value       = 'puppet.domain.tld'
+    @ci.config_items[item.key] = item
+  end
+
+  describe "#apply" do
+    it 'persists an existing autosign.conf' do
+      # copy file from files to tmp
+      FileUtils.cp File.join( @file_dir, 'autosign.conf.used'), @tmp_dir
+      @ci.file   = File.join( @tmp_dir, 'autosign.conf.used' )
+      @ci.apply
+      lines = File.readlines( @ci.file ).join( "\n" )
+      expect( lines ).to match(%r{^puppet.fake.domain\n\s*server1.fake.domain\n\s*server2.fake.domain$})
+    end
+
+    it 'handles a newly-bootstrapped autosign.conf' do
+      # copy file from files to tmp
+      FileUtils.cp File.join( @file_dir, 'autosign.conf.new'), @tmp_dir
+      @ci.file   = File.join( @tmp_dir, 'autosign.conf.new' )
+      @ci.apply
+      lines = File.readlines( @ci.file ).join( "\n" )
+      expect( lines ).to match(%r{^puppet.domain.tld$})
+    end
+
+    it 'handles an empty autosign.conf' do
+      FileUtils.touch File.join( @tmp_dir, 'autosign.conf.empty' )
+      @ci.file   = File.join( @tmp_dir, 'autosign.conf.empty' )
+      @ci.apply
+      lines = File.readlines( @ci.file ).join( "\n" )
+      expect( lines ).to match(%r{^puppet.domain.tld$})
+    end
+  end
+
+  after :each do
+    FileUtils.remove_entry_secure @tmp_dir
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end
+

data/spec/lib/simp/cli/config/item/puppet_ca_port_spec.rb

@@ -0,0 +1,23 @@
+require 'simp/cli/config/item/puppet_ca_port'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetCAPort do
+  before :each do
+    @ci = Simp::Cli::Config::Item::PuppetCAPort.new
+  end
+
+  describe "#validate" do
+    it "validates acceptable ca ports" do
+      expect( @ci.validate '8140' ).to eq true
+      expect( @ci.validate '8141' ).to eq true
+    end
+
+    it "doesn't validate bad ca ports" do
+      expect( @ci.validate 'puppet' ).to eq false
+      expect( @ci.validate '70000' ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/puppet_ca_spec.rb

@@ -0,0 +1,22 @@
+require 'simp/cli/config/item/puppet_ca'
+require 'rspec/its'
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetCA do
+  before :each do
+    @ci = Simp::Cli::Config::Item::PuppetCA.new
+  end
+
+  describe "#validate" do
+    it "validates fqdns" do
+      expect( @ci.validate 'puppet' ).to eq true
+      expect( @ci.validate 'puppet.change.me' ).to eq true
+    end
+
+    it "doesn't validate bad fqdns" do
+      expect( @ci.validate 'puppet-' ).to eq false
+    end
+  end
+
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/puppet_conf_spec.rb

@@ -0,0 +1,110 @@
+require 'simp/cli/config/item/puppet_conf'
+require 'simp/cli/config/item/puppet_ca'
+require 'simp/cli/config/item/puppet_ca_port'
+require 'simp/cli/config/item/puppet_server'
+
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetConf do
+  before :context do
+    @ci = Simp::Cli::Config::Item::PuppetConf.new
+    @puppet_server  = 'puppet.nerd'
+    @puppet_ca      = 'puppetca.nerd'
+    @puppet_ca_port = '9999'
+    @use_fips       = true
+
+    previous_items = {}
+    s = Simp::Cli::Config::Item::PuppetServer.new
+    s.value = @puppet_server
+    previous_items[ s.key ] = s
+    s = Simp::Cli::Config::Item::PuppetCA.new
+    s.value = @puppet_ca
+    previous_items[ s.key ] = s
+    s = Simp::Cli::Config::Item::PuppetCAPort.new
+    s.value = @puppet_ca_port
+    previous_items[ s.key ] = s
+    s = Simp::Cli::Config::Item::UseFips.new
+    s.value = @use_fips
+    previous_items[ s.key ] = s
+
+    @ci.config_items = previous_items
+  end
+
+  describe "#apply" do
+    before :context do
+      @files_dir   = File.expand_path( 'files', File.dirname( __FILE__ ) )
+      @tmp_dir     = File.expand_path( 'tmp', File.dirname( __FILE__ ) )
+      @tmp_file    = File.join( @tmp_dir, 'test__puppet.conf' )
+      @puppet_conf = File.join( @files_dir,'puppet.conf')
+      FileUtils.mkdir_p @tmp_dir
+    end
+
+    context "when @skip_apply == true" do
+      before :context do
+        FileUtils.copy_file @puppet_conf, @tmp_file
+        @ci.file       = @tmp_file
+        @ci.skip_apply = true
+        @ci.silent     = true
+      end
+
+      it "does not alter puppet.conf" do
+        @ci.apply
+        expect( IO.read(@tmp_file) ).to eq IO.read(@puppet_conf)
+      end
+
+      after :context do
+        FileUtils.rm @tmp_file
+      end
+    end
+
+    context "edits the puppet.conf file" do
+      before :context do
+        FileUtils.copy_file @puppet_conf, @tmp_file
+        @ci.file       = @tmp_file
+        @ci.skip_apply = false
+        @ci.silent     = true
+        @ci.apply
+        @lines = File.readlines( @tmp_file ).join( "\n" )
+      end
+
+      it "configures server" do
+        expect( @lines ).to match(%r{^\s*server\s*=\s#{@puppet_server}} )
+      end
+
+      it "configures ca_server" do
+        expect( @lines ).to match(%r{^\s*ca_server\s*=\s#{@puppetca_server}} )
+      end
+
+      it "configures ca_port" do
+        expect( @lines ).to match(%r{^\s*ca_port\s*=\s#{@puppetca_port}} )
+      end
+
+      it "configures environmentpath" do
+        expect( @lines ).to match(%r{^\s*environmentpath\s*=\s/etc/puppet/environments} )
+      end
+
+      it "configures stringify_facts" do
+        expect( @lines ).to match(%r{^\s*stringify_facts\s*=\sfalse} )
+      end
+
+      it "configures digest_algorithm" do
+        expect( @lines ).to match(%r{^\s*digest_algorithm\s*=\ssha256} )
+      end
+
+      it "configures trusted_node_data" do
+        expect( @lines ).to match(%r{^\s*trusted_node_data\s*=\strue} )
+      end
+
+      it "configures keylength" do
+        expect( @lines ).to match(%r{^\s*keylength\s*=\s2048} )
+      end
+
+      after :context do
+        FileUtils.rm @tmp_file
+      end
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end

data/spec/lib/simp/cli/config/item/puppet_fileserver_spec.rb

@@ -0,0 +1,53 @@
+require 'simp/cli/config/item/puppet_fileserver'
+
+require 'simp/cli/config/item/hostname'
+
+require_relative( 'spec_helper' )
+
+describe Simp::Cli::Config::Item::PuppetFileServer do
+  before :all do
+    @ci = Simp::Cli::Config::Item::PuppetFileServer.new
+    @files_dir       = File.expand_path( 'files', File.dirname( __FILE__ ) )
+    @tmp_dir         = File.expand_path( 'tmp', File.dirname( __FILE__ ) )
+    @tmp_file        = File.join( @tmp_dir, 'test__fileserver.conf' )
+    @fileserver_conf = File.join( @files_dir,'fileserver.conf')
+    @ci.silent       = true
+  end
+
+  describe "#apply" do
+    context "edits the fileserver.conf file" do
+      before :context do
+        @ci.file         = @tmp_file
+      end
+
+      context "with a valid hostname (fqdn)" do
+        before :context do
+          FileUtils.mkdir_p   @tmp_dir
+          FileUtils.copy_file @fileserver_conf, @tmp_file
+
+          item             = Simp::Cli::Config::Item::Hostname.new
+          item.value       = "scli.tasty.bacon"
+          @ci.config_items = { 'hostname' => item }
+
+          @result = @ci.apply
+        end
+
+        it "configures server with correct domain" do
+          lines = File.readlines( @tmp_file ).join( "\n" )
+          expect( lines ).to match(%r{^\s*allow\s+\*.tasty.bacon} )
+        end
+
+        it "reports success" do
+          expect( @result ).to eq true
+        end
+
+        after :context do
+          FileUtils.rm @tmp_file
+        end
+      end
+    end
+  end
+
+  it_behaves_like "an Item that doesn't output YAML"
+  it_behaves_like "a child of Simp::Cli::Config::Item"
+end