shoes-core 4.0.0.pre4 → 4.0.0.pre5

data/spec/shoes/shared_examples/style.rb

@@ -1,5 +1,4 @@
 shared_examples_for "object with style" do
-
   def uses_app_default?(key)
     if defined? self.class::STYLES
       subject.style[key] && !subject.class::STYLES[key]
@@ -9,7 +8,6 @@ shared_examples_for "object with style" do
   end
 
   describe 'using app-level styles' do
-
     it 'initially uses app defaults' do
       app.style.each do |key, value|
         expect(subject.style[key]).to eq(value) if uses_app_default? key
@@ -37,7 +35,6 @@ shared_examples_for "object with style" do
   end
 
   describe 'using the style method' do
-
     it "merges new styles" do
       old_style = subject.style
       subject.style(left: 100, top: 50)
@@ -65,7 +62,6 @@ shared_examples_for "object with style" do
   end
 
   describe 'using setters and getters' do
-
     it 'has a style setter for all styles' do
       subject.supported_styles.each do |style|
         expect(subject).to respond_to("#{style}=".to_sym)
@@ -78,5 +74,4 @@ shared_examples_for "object with style" do
       end
     end
   end
-
 end

data/spec/shoes/slot_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Slot do
   include_context "dsl app"
@@ -11,7 +11,16 @@ describe Shoes::Slot do
   let(:input_opts) { {left: left, top: top, width: width, height: height} }
   subject(:slot) { Shoes::Slot.new(app, parent, input_opts) }
 
+  before do
+    # In production this is filled in by Stack and Flow, but we don't want to
+    # trip it in our tests against Slot directly.
+    allow(slot).to receive(:position_element) do |element, current_position|
+      slot.send(:move_to_next_line, element, current_position)
+    end
+  end
+
   it_behaves_like "object with dimensions"
+  it_behaves_like "object with hover"
 
   it_behaves_like "object with style" do
     let(:subject_without_style) { Shoes::Slot.new(app, parent) }
@@ -29,9 +38,8 @@ describe Shoes::Slot do
   end
 
   describe '#clear' do
-
     def add_text_block
-      Shoes::TextBlock.new app, slot, ['text']
+      Shoes::Para.new app, slot, ['text']
     end
 
     before :each do
@@ -61,7 +69,6 @@ describe Shoes::Slot do
         expect(subject.contents.size).to eq 1
       end
     end
-
   end
 
   describe '#remove_child' do
@@ -94,40 +101,6 @@ describe Shoes::Slot do
     end
   end
 
-  describe "hover" do
-    let(:callable) { double("block", call: nil) }
-    let(:block)    { Proc.new { callable.call } }
-
-    it "doesn't need hover proc to be called" do
-      expect(callable).to_not receive(:call)
-      subject.mouse_hovered
-    end
-
-    it "calls block on mouse_hovered" do
-      expect(callable).to receive(:call)
-
-      subject.hover(block)
-      subject.mouse_hovered
-    end
-  end
-
-  describe "leave" do
-    let(:callable) { double("block", call: nil) }
-    let(:block)    { Proc.new { callable.call } }
-
-    it "doesn't need leave proc to be called" do
-      expect(callable).to_not receive(:call)
-      subject.mouse_left
-    end
-
-    it "calls block on mouse_left" do
-      expect(callable).to receive(:call)
-
-      subject.leave(block)
-      subject.mouse_left
-    end
-  end
-
   describe "create_bound_block" do
     let(:callable) { double("block", call: nil) }
     let(:block)    { Proc.new { callable.call(self) } }

data/spec/shoes/sound_spec.rb

@@ -1,7 +1,8 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Sound do
-  let(:parent) { double("parent") }
+  let(:app_gui) { double("app gui") }
+  let(:parent) { double("parent", gui: app_gui) }
   let(:filepath) { "../../samples/sounds/61847__simon-rue__boink-v3.wav" }
   subject { Shoes::Sound.new(parent, filepath) }
 

data/spec/shoes/span_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Span do
   let(:app) { Shoes::App.new }
@@ -34,7 +34,7 @@ describe Shoes::Span do
     it 'does not try to merge with parent style when there are none' do
       parent = double 'parent'
       span.parent = parent
-      expect {span.style}.to_not raise_error()
+      expect {span.style}.to_not raise_error
     end
 
     it 'merges with the styles of the parent text' do

data/spec/shoes/spec_helper.rb

@@ -9,7 +9,7 @@ def unpack_styles(styles)
   supported_styles = []
   styles.each do |style|
     if Shoes::Common::Style::STYLE_GROUPS[style]
-      Shoes::Common::Style::STYLE_GROUPS[style].each{|s| supported_styles << s}
+      Shoes::Common::Style::STYLE_GROUPS[style].each {|s| supported_styles << s}
     else
       supported_styles << style
     end

data/spec/shoes/stack_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 require 'shoes/helpers/fake_element'
 
 describe Shoes::Stack do
@@ -7,9 +7,9 @@ describe Shoes::Stack do
   subject(:stack) { Shoes::Stack.new(app, app, input_opts) }
 
   it_behaves_like "Slot"
+  it_behaves_like "object with hover"
 
   describe 'Context' do
-
     class ContextObject
       def initialize(app)
         @app = app
@@ -23,7 +23,7 @@ describe Shoes::Stack do
     end
 
     it 'does not change the context' do
-      app = Shoes.app do ; end
+      app = Shoes.app do; end
       context_object = ContextObject.new app
       inside_stack = context_object.check_self_inside_stack
       expect(inside_stack).to be context_object
@@ -36,17 +36,17 @@ describe Shoes::Stack do
     it_behaves_like 'arranges elements underneath each other'
 
     describe 'small stack height' do
-      let(:input_opts){{height: element.height + 10}}
+      let(:input_opts) {{height: element.height + 10}}
       it_behaves_like 'set height and contents alignment'
     end
 
     describe 'big stack height' do
-      let(:input_opts){{height: 1000}}
+      let(:input_opts) {{height: 1000}}
       it_behaves_like 'set height and contents alignment'
     end
 
     describe 'with margin' do
-      let(:input_opts){{margin: 27}}
+      let(:input_opts) {{margin: 27}}
       it_behaves_like 'taking care of margin'
     end
   end

data/spec/shoes/star_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 shared_examples_for "basic star" do
   it "retains app" do
@@ -29,6 +29,7 @@ describe Shoes::Star do
   it_behaves_like "object with dimensions"
   it_behaves_like "movable object"
   it_behaves_like 'object with parent'
+  it_behaves_like "object with hover"
 
   describe "in_bounds?" do
     before do

data/spec/shoes/text_block_dimensions_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::TextBlockDimensions do
   let(:left)   { 0 }
@@ -62,14 +62,13 @@ describe Shoes::TextBlockDimensions do
 
     describe "with parent" do
       let(:parent) { double('parent', element_width: 100,
-                            x_dimension: double("x"),
-                            y_dimension: double("y")) }
+                                      x_dimension: double("x"),
+                                      y_dimension: double("y")) }
       subject { Shoes::TextBlockDimensions.new(parent, left, top, nil, height) }
 
       it "delegates to parent if no width of its own" do
         expect(subject.containing_width).to eq(100)
       end
     end
-
   end
 end

data/spec/shoes/text_block_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 require 'shoes/helpers/sample17_helper'
 
 describe Shoes::TextBlock do
@@ -6,13 +6,15 @@ describe Shoes::TextBlock do
 
   let(:text_link) { Shoes::Link.new(app, ['Hello']) }
   let(:text) { [text_link, ", world!"] }
-  subject(:text_block) { Shoes::TextBlock.new(app, parent, text, app: app) }
+  subject(:text_block) { Shoes::Para.new(app, parent, text, app: app) }
 
   it_behaves_like "object with style" do
-    let(:subject_without_style) { Shoes::TextBlock.new(app, parent, text) }
-    let(:subject_with_style) { Shoes::TextBlock.new(app, parent, text, arg_styles) }
+    let(:subject_without_style) { Shoes::Para.new(app, parent, text) }
+    let(:subject_with_style) { Shoes::Para.new(app, parent, text, arg_styles) }
   end
 
+  it_behaves_like "object with hover"
+
   describe "initialize" do
     it "creates gui object" do
       expect(text_block.gui).not_to be_nil
@@ -92,7 +94,7 @@ describe Shoes::TextBlock do
   end
 
   describe "font" do
-    let(:text_block) { Shoes::TextBlock.new(app, parent, ["Hello, world!"], style) }
+    let(:text_block) { Shoes::Para.new(app, parent, ["Hello, world!"], style) }
 
     context "with defaults" do
       let(:style) { Hash.new }
@@ -149,7 +151,7 @@ describe Shoes::TextBlock do
 
   describe "stroke" do
     it "should accept a hex code" do
-      s = Shoes::TextBlock.new(app, parent, ["Hello, world!"], stroke: "#fda", app: app)
+      s = Shoes::Para.new(app, parent, ["Hello, world!"], stroke: "#fda", app: app)
       color = s.style[:stroke]
       expect(color.red).to eql 255
       expect(color.green).to eql 221
@@ -164,7 +166,7 @@ describe Shoes::TextBlock do
     end
 
     context "when not explicitly set" do
-      subject(:text_block) { Shoes::TextBlock.new(app, parent, ["text"]) }
+      subject(:text_block) { Shoes::Para.new(app, parent, ["text"]) }
 
       it "delegates to calculated width" do
         subject.calculated_width = 240
@@ -194,18 +196,21 @@ describe Shoes::TextBlock do
     end
 
     context "when explicitly set" do
-      subject(:text_block) { Shoes::TextBlock.new(app, parent, ["text"], width: 120) }
+      subject(:text_block) { Shoes::Para.new(app, parent, ["text"], width: 120) }
 
       it "gets returned" do
         expect(subject.width).to eql 120
       end
 
       it "is used for desired width" do
-        subject.absolute_left = 20
-        expect(subject.desired_width).to eql 100
+        expect(subject.desired_width).to eql 120
       end
-    end
 
+      it "factors in if parent space is too small" do
+        subject.absolute_left = parent.element_width - 100
+        expect(subject.desired_width).to eql(100)
+      end
+    end
   end
 
   context "cursor management" do

data/spec/shoes/ui/picker_spec.rb

@@ -1,8 +1,7 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 require 'shoes/ui/picker'
 
 describe Shoes::UI::Picker do
-
   let(:swt_backend)  { "/gems/lib/shoes/swt/generate-backend.rb" }
   let(:faux_backend) { "/gems/lib/shoes/faux/generate-backend.rb" }
 
@@ -12,13 +11,13 @@ describe Shoes::UI::Picker do
   subject  { Shoes::UI::Picker.new(input, output) }
 
   it "selects single backend generator" do
-    allow(Gem).to receive(:find_files) { [ swt_backend ] }
+    allow(Gem).to receive(:find_files) { [swt_backend] }
     expect(subject.select_generator).to eq(swt_backend)
   end
 
   describe "with multiple backend generators" do
     before do
-      allow(Gem).to receive(:find_files) { [ faux_backend, swt_backend ] }
+      allow(Gem).to receive(:find_files) { [faux_backend, swt_backend] }
     end
 
     it "prompts with multiple backend generators" do
@@ -53,12 +52,12 @@ describe Shoes::UI::Picker do
     end
 
     it "fails if no matches" do
-      allow(Gem).to receive(:find_files) { [ ] }
+      allow(Gem).to receive(:find_files) { [] }
       expect { subject.select_generator }.to raise_error(ArgumentError)
     end
 
     it "selects by name" do
-      allow(Gem).to receive(:find_files) { [ swt_backend ] }
+      allow(Gem).to receive(:find_files) { [swt_backend] }
       expect(subject.select_generator("swt")).to eq(swt_backend)
     end
 

data/spec/shoes/url_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe 'Shoes.url' do
   let(:klazz) do
@@ -64,5 +64,4 @@ describe 'Shoes.url' do
   it 'instances report class as klazz (regression, do not ask...)' do
     expect(klazz.new.class).to eq klazz
   end
-
 end

data/spec/shoes/widget_spec.rb

@@ -1,7 +1,11 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 class Smile < Shoes::Widget
   def initialize(caption)
+    smile_magic caption
+  end
+
+  def smile_magic(caption)
     banner caption
   end
 end
@@ -50,11 +54,15 @@ describe Shoes::Widget do
         include RSpec::Matchers
 
         url '/', :check_smile
-        url '/smile', :smile
+        url '/smile', :smile_little_one
 
         def check_smile
           expect(self).to respond_to :smile
         end
+
+        def smile_little_one
+          smile 'little one'
+        end
       end
     end
 
@@ -63,7 +71,7 @@ describe Shoes::Widget do
     end
 
     it 'really smiles' do
-      expect_any_instance_of(Smile).to receive(:initialize)
+      expect_any_instance_of(Smile).to receive(:smile_magic)
       Shoes.app do visit '/smile' end
     end
   end

data/spec/shoes_spec.rb

@@ -2,18 +2,16 @@ require 'spec_helper'
 
 describe Shoes, 'load_backend' do
   it "raises ArgumentError on bad input" do
-    expect { Shoes.load_backend :bogus }.to raise_error
+    expect { Shoes.load_backend :bogus }.to raise_error(ArgumentError)
   end
 end
 
 describe Shoes, 'setup' do
-
   it 'knows this method' do
     expect(Shoes).to respond_to :setup
   end
 
   describe 'outputting on standard error' do
-
     def expect_stderr_puts(regex)
       expect($stderr).to receive(:puts).with(regex)
     end
@@ -40,5 +38,4 @@ describe Shoes, 'setup' do
       end
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -10,10 +10,11 @@ require 'shoes/core'
 require 'shoes/ui/cli'
 require 'fileutils'
 require 'shoes/helpers/fake_element'
+require 'shoes/helpers/fake_absolute_element'
 require 'shoes/helpers/inspect_helpers'
 
 require 'webmock/rspec'
-WebMock.disable_net_connect!(:allow => "codeclimate.com")
+WebMock.disable_net_connect!(allow: "codeclimate.com")
 
 shared_examples = File.expand_path('../shoes/shared_examples/**/*.rb', __FILE__)
 Dir[shared_examples].each { |f| require f }