shoes-core 4.0.0.pre4 → 4.0.0.pre5

data/spec/shoes/line_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Line do
   include_context "dsl app"
@@ -16,7 +16,8 @@ describe Shoes::Line do
       let(:subject_with_style) { Shoes::Line.new(app, parent, Shoes::Point.new(left, top), Shoes::Point.new(300, 430), arg_styles) }
     end
     it_behaves_like "object with dimensions"
-    it_behaves_like 'object with parent'
+    it_behaves_like "object with parent"
+    it_behaves_like "object with hover"
   end
 
   describe "line with point a at leftmost, topmost" do

data/spec/shoes/link_spec.rb

@@ -1,12 +1,32 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Link do
   let(:gui) { double("gui").as_null_object }
-  let(:app) { double("app", gui: gui, style: {}, element_styles: {}, warn: true) }
+  let(:user_facing_app) { double("user facing app") }
+  let(:element_styles) { Hash.new }
+  let(:app) { double("app", gui: gui, style: {}, element_styles: element_styles,
+                     warn: true, add_mouse_hover_control: nil) }
+  let(:parent) { double("parent") }
   let(:internal_app) { double("internal app", app: app, gui: gui, style: {}, element_styles: {}) }
   let(:texts) { ["text", "goes", "first"] }
 
-  subject { Shoes::Link.new(app, texts, color: :blue) }
+  subject {
+    link = Shoes::Link.new(app, texts, color: :blue)
+    link.parent = parent
+    link
+  }
+
+  before do
+    allow(user_facing_app).to receive(:style) do |clazz, styles|
+      element_styles[clazz] = styles
+    end
+
+    allow(parent).to receive(:eval_hover_block) do |blk|
+      blk.call(subject) if blk
+    end
+  end
+
+  it_behaves_like "object with hover"
 
   context "initialize" do
     it "should set up text" do
@@ -29,15 +49,15 @@ describe Shoes::Link do
                                 underline: false, bg: Shoes::COLORS[:green]) }
 
       it "should include defaults" do
-        expect(subject.style).to include(:stroke => Shoes::COLORS[:blue])
+        expect(subject.style).to include(stroke: Shoes::COLORS[:blue])
       end
 
       it "should override defaults" do
-        expect(subject.style).to include(:underline => false)
+        expect(subject.style).to include(underline: false)
       end
 
       it "should include other options" do
-        expect(subject.style).to include(:bg => Shoes::COLORS[:green])
+        expect(subject.style).to include(bg: Shoes::COLORS[:green])
       end
     end
 

data/spec/shoes/list_box_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::ListBox do
   include_context "dsl app"
@@ -49,7 +49,7 @@ describe Shoes::ListBox do
 
     it "updates the gui when self-modifying array methods like map! are called" do
       expect(list_box.gui).to receive(:update_items)
-      list_box.items.map!{"replaced!"}
+      list_box.items.map! {"replaced!"}
     end
   end
 

data/spec/shoes/oval_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Oval do
   include_context "dsl app"
@@ -18,6 +18,7 @@ describe Shoes::Oval do
     it_behaves_like "movable object"
     it_behaves_like "left, top as center"
     it_behaves_like "object with parent"
+    it_behaves_like "object with hover"
 
     #it_styles_with :art_styles, :center, :dimensions, :radius
   end

data/spec/shoes/packager_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Packager do
   subject { Shoes::Packager.new }

data/spec/shoes/point_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Point do
   subject { Shoes::Point.new(40, 50) }

data/spec/shoes/progress_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Progress do
   include_context "dsl app"

data/spec/shoes/radio_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Radio do
   include_context "dsl app"

data/spec/shoes/rect_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 shared_examples_for "basic rect" do
   it "retains app" do
@@ -36,4 +36,5 @@ describe Shoes::Rect do
   it_behaves_like "movable object"
   it_behaves_like "left, top as center"
   it_behaves_like 'object with parent'
+  it_behaves_like "object with hover"
 end

data/spec/shoes/renamed_delegate_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe RenamedDelegate do
-
   class ToDelegate
     def method_key
     end

data/spec/shoes/shape_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Shape do
   include_context "dsl app"

data/spec/shoes/shared_examples/common_methods.rb

@@ -25,7 +25,7 @@ shared_examples_for "movable object" do
 end
 
 shared_examples_for "left, top as center" do |*params|
-  let(:centered_object) { described_class.new(app, parent, left, top, width, height, *params, :center => true) }
+  let(:centered_object) { described_class.new(app, parent, left, top, width, height, *params, center: true) }
   it "should now be located somewhere" do
     expect(centered_object.left).to eq(left-(width/2))
     expect(centered_object.top).to eq(top-(height/2))

data/spec/shoes/shared_examples/dsl/animate.rb

@@ -20,7 +20,7 @@ shared_examples_for "animate DSL method" do
   end
 
   context "with hash argument" do
-    let(:animation) { dsl.animate(:framerate => 17) {} }
+    let(:animation) { dsl.animate(framerate: 17) {} }
 
     it "sets framerate" do
       expect(animation.framerate).to eq(17)

data/spec/shoes/shared_examples/dsl/background.rb

@@ -8,13 +8,13 @@ shared_examples_for "background DSL method" do
 
   context "with an invalid hex string" do
     it 'raises an argument error' do
-      expect{ subject.background('#ffq') }.to raise_error('Bad hex color: #ffq')
+      expect { subject.background('#ffq') }.to raise_error('Bad hex color: #ffq')
     end
   end
 
   context 'with no valid image' do
     it 'ignores the background' do
-      expect{ subject.background('fake-shoes.jpg') }.not_to raise_error
+      expect { subject.background('fake-shoes.jpg') }.not_to raise_error
     end
   end
 

data/spec/shoes/shared_examples/dsl/rgb.rb

@@ -5,13 +5,15 @@ shared_examples_for "rgb DSL method" do
   let(:alpha) { 133 } # cornflowerblue
 
   it "sends args to Shoes::Color" do
-    expect(Shoes::Color).to receive(:new).with(red, green, blue, alpha)
+    allow(Shoes::Color).to receive(:new)
     dsl.rgb(red, green, blue, alpha)
+    expect(Shoes::Color).to have_received(:new).with(red, green, blue, alpha)
   end
 
   it "defaults to opaque" do
-    expect(Shoes::Color).to receive(:new).with(red, green, blue, Shoes::Color::OPAQUE)
+    allow(Shoes::Color).to receive(:new)
     dsl.rgb(red, green, blue)
+    expect(Shoes::Color).to have_received(:new).with(red, green, blue, Shoes::Color::OPAQUE)
   end
 
   describe "named color method" do

data/spec/shoes/shared_examples/dsl/star.rb

@@ -106,6 +106,5 @@ shared_examples_for "star DSL method" do
         expect { subject }.to raise_error(ArgumentError)
       end
     end
-
   end
 end

data/spec/shoes/shared_examples/dsl/style.rb

@@ -4,7 +4,7 @@ shared_examples_for "style DSL method" do
     let(:size)   { 42 }
     let(:fill)   { Shoes::COLORS[:peru] }
     let(:font)  { "SOME FONT" }
-    let(:style)  { {:stroke => stroke, :size => size, :fill => fill, :font => font} }
+    let(:style)  { {stroke: stroke, size: size, fill: fill, font: font} }
 
     %w(Banner Title Subtitle Tagline Caption Para Inscription).each do |text_block|
       describe text_block do

data/spec/shoes/shared_examples/dsl/text_elements.rb

@@ -41,7 +41,7 @@ shared_examples_for "text element DSL methods" do
     end
 
     it 'should handle a splatted array of links' do
-      expect{dsl.span(*[dsl.link('foo'), dsl.link('foo')])}.not_to raise_error
+      expect {dsl.span(*[dsl.link('foo'), dsl.link('foo')])}.not_to raise_error
     end
 
     it 'should handle a splatted array of links and parse the color' do
@@ -51,7 +51,7 @@ shared_examples_for "text element DSL methods" do
 
     it 'should handle a splatted array of links with a block' do
       link = dsl.link('foo') { "Bar" }
-      expect{dsl.span(*[link, link])}.not_to raise_error
+      expect {dsl.span(*[link, link])}.not_to raise_error
     end
   end
 

data/spec/shoes/shared_examples/dsl/video.rb

@@ -1,5 +1,5 @@
 shared_examples_for 'video DSL method' do
   it 'throws a Shoes::NotImplementedError' do
-    expect{dsl.video}.to raise_error Shoes::NotImplementedError
+    expect {dsl.video}.to raise_error Shoes::NotImplementedError
   end
 end

data/spec/shoes/shared_examples/dsl_app_context.rb

@@ -3,5 +3,8 @@ shared_context "dsl app" do
   let(:input_opts) { Hash.new }
   let(:user_facing_app) { Shoes::App.new input_opts, &input_block }
   let(:app) { user_facing_app.instance_variable_get(:@__app__) }
-  let(:parent) { Shoes::Flow.new app, app }
+  let(:parent) { Shoes::Flow.new app, app,
+                                 width: Shoes::InternalApp::DEFAULT_OPTIONS[:width],
+                                 height: Shoes::InternalApp::DEFAULT_OPTIONS[:height]
+  }
 end

data/spec/shoes/shared_examples/hover.rb

@@ -0,0 +1,78 @@
+shared_examples "object with hover" do
+  let(:teal) { Shoes::COLORS[:teal] }
+  let(:gold) { Shoes::COLORS[:gold] }
+
+  let(:hover_class) { subject.hover_class }
+
+  it "registers hover" do
+    expect(subject).to receive(:add_mouse_hover_control)
+    subject.hover { }
+  end
+
+  it "registers with leave" do
+    expect(subject).to receive(:add_mouse_hover_control)
+    subject.leave { }
+  end
+
+  it "marks itself as hovered" do
+    subject.mouse_hovered
+    expect(subject.hovered?).to eq(true)
+  end
+
+  it "marks itself not hovered after leaving" do
+    subject.mouse_hovered
+    expect(subject.hovered?).to eq(true)
+
+    subject.mouse_left
+    expect(subject.hovered?).to eq(false)
+  end
+
+  it "only calls hover block once" do
+    count = 0
+    subject.hover do
+      count += 1
+    end
+
+    subject.mouse_hovered
+    subject.mouse_hovered
+
+    expect(count).to eq(1)
+  end
+
+  it "only calls leave block once after we're hovering" do
+    count = 0
+    subject.leave do
+      count += 1
+    end
+
+    subject.mouse_hovered
+    subject.mouse_left
+    subject.mouse_left
+
+    expect(count).to eq(1)
+  end
+
+  it "doesn't update styles on hover by default" do
+    original_style = subject.style.dup
+    subject.mouse_hovered
+
+    expect(subject.style).to eq(original_style)
+  end
+
+  it "updates styles on hover" do
+    user_facing_app.style(hover_class, stroke: teal)
+
+    subject.mouse_hovered
+    expect(subject.style[:stroke]).to eq(teal)
+  end
+
+  it "restores style after hover's done" do
+    user_facing_app.style(hover_class, stroke: teal)
+
+    subject.style[:stroke] = gold
+    subject.mouse_hovered
+    subject.mouse_left
+
+    expect(subject.style[:stroke]).to eq(gold)
+  end
+end

data/spec/shoes/shared_examples/slot.rb

@@ -90,7 +90,6 @@ shared_context 'element one with bottom and right' do
 end
 
 shared_examples_for 'positioning through :_position' do
-
   let(:element) {Shoes::FakeElement.new nil, height: 100, width: 50}
 
   def add_child_and_align
@@ -109,11 +108,34 @@ shared_examples_for 'positioning through :_position' do
     subject.contents_alignment
   end
 
+  it 'does not send _position if element does not need positioning' do
+    allow(element).to receive(:takes_up_space?)    { false }
+    allow(element).to receive(:needs_positioning?) { false }
+    expect(element).not_to receive(:_position)
+    add_child_and_align
+  end
+
+  it 'sends _position even when element does not take up space' do
+    allow(element).to receive(:takes_up_space?)    { false }
+    allow(element).to receive(:needs_positioning?) { true }
+    expect(element).to receive(:_position).and_call_original
+    add_child_and_align
+  end
+
   it 'is resilient to exceptions during positioning' do
     allow(element).to receive(:contents_alignment).and_raise("O_o")
     allow(subject).to receive(:puts)  # Quiet, you
     add_child_and_align
   end
+
+  describe 'absolute dimensions' do
+    let(:element) { Shoes::FakeAbsoluteElement.new }
+
+    it 'positions element via _position' do
+      expect(element).to receive(:_position).and_call_original
+      add_child_and_align
+    end
+  end
 end
 
 shared_examples_for 'element one positioned with top and left' do
@@ -261,8 +283,8 @@ end
 
 shared_examples_for 'prepending' do
   include_context 'two slot children'
-  let(:prepend1) {double 'prepend1'}
-  let(:prepend2) {double 'prepend2'}
+  let(:prepend1) { Shoes::FakeElement.new(nil, width: 100) }
+  let(:prepend2) { Shoes::FakeElement.new(nil, width: 100) }
 
   describe 'one element' do
     before :each do
@@ -304,7 +326,7 @@ shared_examples_for 'prepending' do
   describe 'two times' do
     before :each do
       subject.prepend { subject.add_child prepend1 }
-      subject.prepend {subject.add_child prepend2 }
+      subject.prepend { subject.add_child prepend2 }
     end
 
     it 'has the last prepended element as the first' do
@@ -384,6 +406,14 @@ shared_examples_for 'margin and positioning' do
     it 'leaves the left value as zero' do
       expect(element.absolute_left).to eq 0
     end
+
+    it 'sets the slot element_height to the height of the child + adjustment' do
+      expect(subject.element_height).to eq element.height
+    end
+
+    it 'sets the slot total height to element height + margin' do
+      expect(subject.height).to eq element.height + margin_top
+    end
   end
 
   describe 'margin left' do

data/spec/shoes/shared_examples/state.rb

@@ -1,7 +1,8 @@
 shared_examples_for "object with state" do
-  let(:input_opts) { {:state => "disabled"} }
+  let(:input_opts) { {state: "disabled"} }
 
-  it "should initialize" do
+  it "should initialize in the right state" do
+    expect_any_instance_of(Shoes.configuration.backend_class(described_class)).to receive(:enabled).with(false)
     expect(subject.state).to eq("disabled")
   end
 
@@ -16,4 +17,10 @@ shared_examples_for "object with state" do
     subject.state = "disabled"
     expect(subject.state).to eq("disabled")
   end
+
+  it "does not disable when a string other than disabled is passed" do
+    expect(subject.gui).to receive(:enabled).with(true)
+    subject.state = "enabled"
+    expect(subject.state).to eq("enabled")
+  end
 end