shoes-core 4.0.0.pre4 → 4.0.0.pre5

data/spec/shoes/dimensions_spec.rb

@@ -1,7 +1,6 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Dimensions do
-
   let(:parent_left) {left}
   let(:parent_top) {top}
   let(:parent_width) {width}
@@ -104,7 +103,6 @@ describe Shoes::Dimensions do
       its(:height) {should be_within(ONE_PIXEL).of 0.5 * parent.height}
 
       describe 'width/height change of the parent' do
-
         # note that here the first assertion/call is necessary as otherwise
         # the subject will only lazily get initialized after the parent width
         # is already adjusted and therefore wrong impls WILL PASS the tests
@@ -140,7 +138,6 @@ describe Shoes::Dimensions do
 
         its(:height) {should eq parent.element_height}
       end
-
     end
 
     describe 'with percentages' do
@@ -335,7 +332,6 @@ describe Shoes::Dimensions do
     end
   end
 
-
   describe 'setting ' do
     it 'has a setter for left' do
       subject.left = 66
@@ -405,7 +401,7 @@ describe Shoes::Dimensions do
 
   describe 'centered (e.g. left and top are seen as coords for the center)' do
     describe '5 arguments' do
-      subject {Shoes::Dimensions.new parent, 100, 50, 40, 20, :center => true}
+      subject {Shoes::Dimensions.new parent, 100, 50, 40, 20, center: true}
 
       its(:left) {should eq 80}
       its(:top) {should eq 40}
@@ -427,10 +423,10 @@ describe Shoes::Dimensions do
 
     describe 'hash' do
       subject {Shoes::Dimensions.new parent, left:   100,
-                                     top:    50,
-                                     width:  40,
-                                     height: 20,
-                                     center: true }
+                                             top:    50,
+                                             width:  40,
+                                             height: 20,
+                                             center: true }
 
       its(:left) {should eq 80}
       its(:top) {should eq 40}
@@ -447,7 +443,6 @@ describe Shoes::Dimensions do
   end
 
   describe 'in_bounds?' do
-
     let(:left) {10}
     let(:top) {20}
     let(:width) {100}
@@ -462,7 +457,7 @@ describe Shoes::Dimensions do
       it {is_expected.to be_in_bounds 30, 40}
       it {is_expected.to be_in_bounds left, top}
       it {is_expected.to be_in_bounds left + width - ONE_PIXEL,
-                              top + height - ONE_PIXEL}
+                                      top + height - ONE_PIXEL}
       it {is_expected.not_to be_in_bounds left + width, top + height}
       it {is_expected.not_to be_in_bounds 30, top + height}
       it {is_expected.not_to be_in_bounds left + width, 40}
@@ -489,7 +484,7 @@ describe Shoes::Dimensions do
       it {is_expected.to be_in_bounds 200, absolute_top}
       it {is_expected.to be_in_bounds absolute_left, absolute_top}
       it {is_expected.to be_in_bounds absolute_left + width - ONE_PIXEL,
-                              absolute_top + height - ONE_PIXEL
+                                      absolute_top + height - ONE_PIXEL
       }
       it {is_expected.not_to be_in_bounds 80, 400}
     end
@@ -530,7 +525,6 @@ describe Shoes::Dimensions do
       before :each do subject.bottom = bottom end
       it_behaves_like 'absolute_y_position'
     end
-
   end
 
   describe 'margins' do
@@ -572,7 +566,7 @@ describe Shoes::Dimensions do
       let(:margin_bottom) {17}
 
       shared_examples_for 'all distinct margins' do
-        its(:margin){should == [margin_left, margin_top, margin_right, margin_bottom]}
+        its(:margin) {should == [margin_left, margin_top, margin_right, margin_bottom]}
         its(:margin_left) {should == margin_left}
         its(:margin_top) {should == margin_top}
         its(:margin_right) {should == margin_right}
@@ -605,7 +599,6 @@ describe Shoes::Dimensions do
   end
 
   describe 'displace' do
-
     before :each do
       # need to have a rough positon
       subject.absolute_left = 0
@@ -617,7 +610,7 @@ describe Shoes::Dimensions do
       it 'modifies the value of element_left' do
         expect do
           subject.displace_left = displace_left
-        end.to change{subject.element_left}.by(displace_left)
+        end.to change {subject.element_left}.by(displace_left)
       end
 
       it 'does not modify the value of absolute_left' do
@@ -640,7 +633,7 @@ describe Shoes::Dimensions do
       it 'modifies the value of element_top' do
         expect do
           subject.displace_top = displace_top
-        end.to change{subject.element_top}.by(displace_top)
+        end.to change {subject.element_top}.by(displace_top)
       end
 
       it 'does not modify the value of absolute_top' do
@@ -656,7 +649,6 @@ describe Shoes::Dimensions do
         end
       end
     end
-
   end
 
   it {is_expected.to be_takes_up_space}
@@ -726,10 +718,10 @@ describe Shoes::Dimensions do
                                           margin: 20}
       subject {Shoes::ParentDimensions.new parent}
 
-      its(:left)   {should eq parent.left}
-      its(:top)    {should eq parent.top}
-      its(:width)  {should eq parent.width}
-      its(:height) {should eq parent.height}
+      its(:left)   {should eq nil}
+      its(:top)    {should eq nil}
+      its(:width)  {should eq parent.element_width}
+      its(:height) {should eq parent.element_height}
 
       its(:margin_left)   {should eq 0}
       its(:margin_top)    {should eq 0}
@@ -742,10 +734,10 @@ describe Shoes::Dimensions do
           parent.absolute_top  = top
         end
 
-        its(:absolute_left) {should eq parent.absolute_left}
-        its(:absolute_top)  {should eq parent.absolute_top}
-        its(:element_left)  {should eq parent.absolute_left}
-        its(:element_top)   {should eq parent.absolute_top}
+        its(:absolute_left) {should eq parent.element_left}
+        its(:absolute_top)  {should eq parent.element_top}
+        its(:element_left)  {should eq parent.element_left}
+        its(:element_top)   {should eq parent.element_top}
       end
     end
 
@@ -771,7 +763,6 @@ describe Shoes::Dimensions do
 end
 
 describe Shoes::DimensionsDelegations do
-
   describe 'with a DSL class and a dimensions method' do
     let(:dimensions) {double('dimensions')}
 
@@ -809,7 +800,7 @@ describe Shoes::DimensionsDelegations do
   end
 
   describe 'with any backend class that has a defined dsl method' do
-    let(:dsl){double 'dsl'}
+    let(:dsl) {double 'dsl'}
 
     class AnotherDummyClass
       include Shoes::BackendDimensionsDelegations
@@ -830,8 +821,7 @@ describe Shoes::DimensionsDelegations do
 
     it 'does not forward calls to parent' do
       expect(dsl).not_to receive :parent
-      expect {subject.parent}.to raise_error
+      expect {subject.parent}.to raise_error(NoMethodError)
     end
   end
-
 end

data/spec/shoes/download_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Download do
   include_context "dsl app"
@@ -19,7 +19,7 @@ describe Shoes::Download do
     expect(app.current_slot).to receive(:create_bound_block).at_least(1) { |blk| blk ? blk : nil }
 
     stub_request(:get, name)
-      .to_return(:status => response_status, :body => response_body, :headers => response_headers)
+      .to_return(status: response_status, body: response_body, headers: response_headers)
   end
 
   after do
@@ -144,7 +144,6 @@ describe Shoes::Download do
         expect(download.gui).to have_received(:eval_block).with(finish_proc, subject)
       end
     end
-
   end
 
   describe 'when things go wrong' do
@@ -158,6 +157,18 @@ describe Shoes::Download do
       download.join_thread
     end
 
+    it 'reports empty values for the response' do
+      error = StandardError.new("Nope")
+      allow(download).to receive(:open).and_raise(error)
+
+      download.start
+      download.join_thread
+
+      expect(download.response.body).to be_empty
+      expect(download.response.headers).to be_empty
+      expect(download.response.status).to be_empty
+    end
+
     it 'does not die on socket errors, but logs them' do
       error = SocketError.new('Badumz')
 

data/spec/shoes/flow_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 require 'shoes/helpers/fake_element'
 
 describe Shoes::Flow do
@@ -7,11 +7,11 @@ describe Shoes::Flow do
   subject(:flow) { Shoes::Flow.new(app, parent, input_opts, input_block) }
 
   it_behaves_like "clickable object"
-  it_behaves_like "hover and leave events"
   it_behaves_like "Slot"
+  it_behaves_like "object with hover"
 
   describe "initialize" do
-    let(:input_opts) { {:width => 131, :height => 137} }
+    let(:input_opts) { {width: 131, height: 137} }
     it "sets accessors" do
       expect(flow.parent).to eq(parent)
       expect(flow.width).to eq(131)
@@ -68,11 +68,10 @@ describe Shoes::Flow do
         let(:input_opts) {{width: element.width + element2.width}}
         it_behaves_like 'positioning in the same line'
       end
-
     end
 
     describe 'when the elements dont fit next to each other' do
-      let(:input_opts){ {width: element.width + element2.width - 10} }
+      let(:input_opts) { {width: element.width + element2.width - 10} }
       it_behaves_like 'arranges elements underneath each other'
 
       describe 'and a third element that goes into the second line' do
@@ -95,12 +94,12 @@ describe Shoes::Flow do
     end
 
     describe 'elements dont fit next to each other and set big height' do
-      let(:input_opts){ {width: element.width + 10, height: 1000} }
+      let(:input_opts) { { width: element.width + 10, height: 1000 } }
       it_behaves_like 'set height and contents alignment'
     end
 
     describe 'with margins and two elements not fitting next to each other' do
-      let(:input_opts){{width: element.width + 10, margin: 27}}
+      let(:input_opts) {{ width: element.width + 10, margin: 27 }}
       it_behaves_like 'taking care of margin'
     end
   end

data/spec/shoes/font_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 main_object = self
 
@@ -20,7 +20,7 @@ describe Shoes::Font do
       result = Shoes::Font.font_paths_from_dir(Shoes::FONT_DIR)
 
       expect(result).to include(Shoes::FONT_DIR + 'Coolvetica.ttf',
-                            Shoes::FONT_DIR + 'Lacuna.ttf')
+                                Shoes::FONT_DIR + 'Lacuna.ttf')
     end
 
     it 'handles sub directories' do
@@ -33,5 +33,4 @@ describe Shoes::Font do
       FileUtils.rm_r tmp_font_dir
     end
   end
-
 end

data/spec/shoes/framework_learning_spec.rb

@@ -1,4 +1,4 @@
-require "shoes/spec_helper"
+require 'spec_helper'
 
 module Learning
   class App
@@ -23,7 +23,6 @@ end
   end
 
 describe "A Shoes Framework" do
-
   it "should include Framework Plugins" do
     expect(Learning::App.new.gui).to eq("Peter")
   end

data/spec/shoes/gradient_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Gradient do
   let(:color1) { Shoes::COLORS[:honeydew] }
@@ -27,6 +27,5 @@ describe Shoes::Gradient do
       gradient_2 = Shoes::Gradient.new(color1, new_color)
       expect(subject).not_to eq(gradient_2)
     end
-
   end
 end

data/spec/shoes/helpers/fake_absolute_element.rb

@@ -0,0 +1,30 @@
+class Shoes
+  class FakeAbsoluteElement
+    include Common::Inspect
+    include Common::Visibility
+    include Common::Positioning
+    include Common::Remove
+
+    include Shoes::DimensionsDelegations
+
+    def initialize
+      @dimensions = AbsoluteDimensions.new 0, 0, 100, 100
+    end
+
+    def add_child(element)
+      true
+    end
+
+    def adjust_current_position(*_)
+    end
+
+    # Fake this out instead of using Common::Style to avoid things like touching
+    # app level styles, etc. that we don't need for testing purposes
+    def style
+      @style ||= {}
+      @style
+    end
+
+    attr_accessor :dimensions, :parent, :gui
+  end
+end

data/spec/shoes/helpers/sample17_helper.rb

@@ -10,7 +10,6 @@
 #   end
 #
 class Sample17Helper
-
   def initialize(app)
     # This gives us the Shoes::App
     @app = app.app

data/spec/shoes/image_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Image do
   include_context "dsl app"
@@ -23,6 +23,7 @@ describe Shoes::Image do
 
     it_behaves_like "movable object"
     it_behaves_like "object with dimensions"
+    it_behaves_like "object with hover"
 
     it_behaves_like "object with style" do
       let(:subject_without_style) { Shoes::Image.new(app, parent, filename) }

data/spec/shoes/input_box_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::InputBox do
   include_context "dsl app"
@@ -58,7 +58,7 @@ describe Shoes::InputBox do
 
   describe Shoes::EditLine do
     describe "secret" do
-      subject { Shoes::EditLine.new(app, parent, text, secret: true) }
+      subject { Shoes::EditLine.new(app, parent, text, secret: true, state: 'disabled') }
 
       it "gets initialized" do
         expect(subject.secret).to eq(true)

data/spec/shoes/integration_spec.rb

@@ -3,7 +3,6 @@ require 'spec_helper'
 # also for stuff that is hard/brittle to test in isolation
 describe 'Integration specs' do
   describe 'hover & leave' do
-
     # that #hover and #leave are called with @__app__.current_slot is hard to
     # test since therefore there needs to be a current slot which is only during
     # block execution, stubbing it seems fairly brittle and dependent on

data/spec/shoes/internal_app_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::InternalApp do
   include_context "dsl app"
@@ -31,7 +31,7 @@ describe Shoes::InternalApp do
     end
 
     context "with custom opts" do
-      let(:input_opts) { {:width => 150, :height => 2, :title => "Shoes::App Spec", :resizable => false} }
+      let(:input_opts) { {width: 150, height: 2, title: "Shoes::App Spec", resizable: false} }
 
       it "sets title", :qt do
         expect(subject.app_title).to eq input_opts[:title]
@@ -52,9 +52,9 @@ describe Shoes::InternalApp do
   end
 
   describe 'fullscreen' do
-    let(:input_opts) { {:fullscreen => true} }
+    let(:input_opts) { {fullscreen: true} }
 
-    it "sets fullscreen" do
+    it "sets fullscreen", :fullscreen do
       expect(subject.start_as_fullscreen?).to be_truthy
     end
   end
@@ -144,6 +144,5 @@ describe Shoes::InternalApp do
         end
       end
     end
-
   end
 end

data/spec/shoes/keypress_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Keypress do
   include_context "dsl app"

data/spec/shoes/keyrelease_spec.rb

@@ -1,4 +1,4 @@
-require 'shoes/spec_helper'
+require 'spec_helper'
 
 describe Shoes::Keyrelease do
   include_context "dsl app"
@@ -8,5 +8,4 @@ describe Shoes::Keyrelease do
   it "should clear" do
     expect(keyrelease).to respond_to(:remove)
   end
-
 end