shipit-engine 0.28.0 → 0.32.0

data/app/controllers/shipit/pull_requests_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class PullRequestsController < ShipitController
     def index
@@ -11,14 +12,14 @@ module Shipit
       else
         flash[:warning] = "Invalid or missing pull request number."
       end
-      redirect_to stack_pull_requests_path
+      redirect_to(stack_pull_requests_path)
     end
 
     def destroy
       pull_request = stack.pull_requests.find(params[:id])
       pull_request.cancel!
       flash[:success] = 'Merge canceled'
-      redirect_to stack_pull_requests_path
+      redirect_to(stack_pull_requests_path)
     end
 
     private

data/app/controllers/shipit/release_statuses_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class ReleaseStatusesController < ShipitController
     before_action :load_stack
@@ -10,9 +11,9 @@ module Shipit
       when 'failure'
         @deploy.report_faulty!(user: current_user)
       else
-        render status: :unprocessable_entity, json: {message: "Invalid `status` parameter"}
+        render(status: :unprocessable_entity, json: { message: "Invalid `status` parameter" })
       end
-      render status: :created, json: @deploy.last_release_status
+      render(status: :created, json: @deploy.last_release_status)
     end
 
     private

data/app/controllers/shipit/rollbacks_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class RollbacksController < ShipitController
     before_action :load_stack
@@ -5,9 +6,9 @@ module Shipit
 
     def create
       @rollback = @deploy.trigger_rollback(current_user, env: rollback_params[:env], force: params[:force].present?)
-      redirect_to stack_deploy_path(@stack, @rollback)
+      redirect_to(stack_deploy_path(@stack, @rollback))
     rescue Task::ConcurrentTaskRunning
-      redirect_to rollback_stack_deploy_path(@stack, @deploy)
+      redirect_to(rollback_stack_deploy_path(@stack, @deploy))
     end
 
     private

data/app/controllers/shipit/shipit_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class ShipitController < ApplicationController
     layout 'shipit'
@@ -27,7 +28,7 @@ module Shipit
     def ensure_required_settings
       return if Shipit.all_settings_present?
 
-      render 'shipit/missing_settings'
+      render('shipit/missing_settings')
     end
   end
 end

data/app/controllers/shipit/stacks_controller.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 module Shipit
   class StacksController < ShipitController
-    before_action :load_stack, only: %i(update destroy settings clear_git_cache refresh)
+    before_action :load_stack, only: %i(update destroy settings statistics clear_git_cache refresh)
 
     def new
       @stack = Stack.new
@@ -9,7 +10,21 @@ module Shipit
     def index
       @user_stacks = current_user.stacks_contributed_to
 
-      @stacks = Stack.order('(undeployed_commits_count > 0) desc', tasks_count: :desc).to_a
+      @stacks = Stack.all
+      if params[:repo]
+        @stacks = if (repository = Repository.from_github_repo_name(params[:repo]))
+          repository.stacks
+        else
+          Stack.none
+        end
+      end
+
+      @stacks = @stacks.order(Arel.sql('(undeployed_commits_count > 0) desc'), tasks_count: :desc)
+
+      @show_archived = params[:show_archived]
+      @stacks = @stacks.not_archived unless @show_archived
+
+      @stacks = @stacks.to_a
     end
 
     def show
@@ -43,11 +58,12 @@ module Shipit
 
     def lookup
       @stack = Stack.find(params[:id])
-      redirect_to stack_url(@stack)
+      redirect_to(stack_url(@stack))
     end
 
     def create
       @stack = Stack.new(create_params)
+      @stack.repository = repository
       unless @stack.save
         flash[:warning] = @stack.errors.full_messages.to_sentence
       end
@@ -56,32 +72,43 @@ module Shipit
 
     def destroy
       @stack.schedule_for_destroy!
-      redirect_to stacks_url
+      redirect_to(stacks_url)
     end
 
     def settings
     end
 
+    def all_tasks
+      @stack = Stack.from_param!(params[:id])
+      @tasks = @stack.tasks.where(type: nil).order(id: :desc).preload(:since_commit, :until_commit, :user).limit(10)
+    end
+
+    def statistics
+      previous_deploy_stats = Shipit::DeployStats.new(@stack.deploys.not_active.previous_seven_days)
+      @deploy_stats = Shipit::DeployStats.new(@stack.deploys.not_active.last_seven_days)
+      if @deploy_stats.empty?
+        flash[:warning] = 'Statistics not available without previous deploys'
+        return redirect_to(stack_path(@stack))
+      end
+      @diffs = @deploy_stats.compare(previous_deploy_stats)
+    end
+
     def refresh
       RefreshStatusesJob.perform_later(stack_id: @stack.id)
       RefreshCheckRunsJob.perform_later(stack_id: @stack.id)
       GithubSyncJob.perform_later(stack_id: @stack.id)
       flash[:success] = 'Refresh scheduled'
-      redirect_to request.referer.presence || stack_path(@stack)
+      redirect_to(request.referer.presence || stack_path(@stack))
     end
 
     def update
       options = {}
       unless @stack.update(update_params)
-        options = {flash: {warning: @stack.errors.full_messages.to_sentence}}
+        options = { flash: { warning: @stack.errors.full_messages.to_sentence } }
       end
 
-      reason = params[:stack][:lock_reason]
-      if reason.present?
-        @stack.lock(reason, current_user)
-      elsif @stack.locked?
-        @stack.unlock
-      end
+      update_lock
+      update_archived
 
       redirect_to(params[:return_to].presence || stack_settings_path(@stack), options)
     end
@@ -89,11 +116,32 @@ module Shipit
     def clear_git_cache
       ClearGitCacheJob.perform_later(@stack)
       flash[:success] = 'Git Cache clearing scheduled'
-      redirect_to stack_settings_path(@stack)
+      redirect_to(stack_settings_path(@stack))
     end
 
     private
 
+    def update_lock
+      if params[:stack].key?(:lock_reason)
+        reason = params[:stack][:lock_reason]
+        if reason.present?
+          @stack.lock(reason, current_user)
+        elsif @stack.locked?
+          @stack.unlock
+        end
+      end
+    end
+
+    def update_archived
+      if params[:stack][:archived].present?
+        if params[:stack][:archived] == "true"
+          @stack.archive!(current_user)
+        elsif @stack.archived?
+          @stack.unarchive!
+        end
+      end
+    end
+
     def map_to_undeployed_commit(commits, next_expected_commit_to_deploy:)
       commits.map.with_index do |c, i|
         index = commits.size - i - 1
@@ -106,7 +154,7 @@ module Shipit
     end
 
     def create_params
-      params.require(:stack).permit(:repo_name, :repo_owner, :environment, :branch, :deploy_url, :ignore_ci)
+      params.require(:stack).permit(:environment, :branch, :deploy_url, :ignore_ci)
     end
 
     def update_params
@@ -118,5 +166,21 @@ module Shipit
         :merge_queue_enabled,
       )
     end
+
+    def repository
+      @repository ||= Repository.find_or_create_by(owner: repo_owner, name: repo_name)
+    end
+
+    def repo_owner
+      repository_params[:repo_owner]
+    end
+
+    def repo_name
+      repository_params[:repo_name]
+    end
+
+    def repository_params
+      params.require(:stack).permit(:repo_owner, :repo_name)
+    end
   end
 end

data/app/controllers/shipit/status_controller.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 module Shipit
   class StatusController < ActionController::Base
     def version
-      render plain: Shipit.revision
+      render(plain: Shipit.revision)
     end
   end
 end

data/app/controllers/shipit/tasks_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class TasksController < ShipitController
     include Pagination
@@ -35,25 +36,25 @@ module Shipit
           env: task_params[:env],
           force: params[:force].present?,
         )
-        redirect_to [stack, @task]
+        redirect_to([stack, @task])
       rescue Task::ConcurrentTaskRunning
-        redirect_to new_stack_tasks_path(stack, @definition)
+        redirect_to(new_stack_tasks_path(stack, @definition))
       end
     end
 
     def abort
       task.abort!(rollback_once_aborted: params[:rollback].present?, aborted_by: current_user)
-      head :ok
+      head(:ok)
     end
 
     def tail
-      render json: TailTaskSerializer.new(task, context: params)
+      render(json: TailTaskSerializer.new(task, context: params))
     end
 
     def lookup
       @task = Task.find(params[:id])
 
-      redirect_to url_for_task
+      redirect_to(url_for_task)
     end
 
     private

data/app/controllers/shipit/webhooks_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class WebhooksController < ActionController::Base
     skip_before_action :verify_authenticity_token, raise: false
@@ -5,139 +6,11 @@ module Shipit
 
     respond_to :json
 
-    class Handler
-      class << self
-        attr_reader :param_parser
-
-        def params(&block)
-          @param_parser = ExplicitParameters::Parameters.define(&block)
-        end
-      end
-
-      attr_reader :params, :payload
-
-      def initialize(payload)
-        @payload = payload
-        @params = self.class.param_parser.parse!(payload)
-      end
-
-      def process
-        raise NotImplementedError
-      end
-
-      private
-
-      def stacks
-        @stacks ||= Stack.repo(repository_name)
-      end
-
-      def repository_name
-        payload.dig('repository', 'full_name')
-      end
-    end
-
-    class PushHandler < Handler
-      params do
-        requires :ref
-      end
-      def process
-        stacks.where(branch: branch).each(&:sync_github)
-      end
-
-      private
-
-      def branch
-        params.ref.gsub('refs/heads/', '')
-      end
-    end
-
-    class StatusHandler < Handler
-      params do
-        requires :sha, String
-        requires :state, String
-        accepts :description, String
-        accepts :target_url, String
-        accepts :context, String
-        accepts :created_at, String
-
-        accepts :branches, Array do
-          requires :name, String
-        end
-      end
-      def process
-        Commit.where(sha: params.sha).each do |commit|
-          commit.create_status_from_github!(params)
-        end
-      end
-    end
-
-    class CheckSuiteHandler < Handler
-      params do
-        requires :check_suite do
-          requires :head_sha, String
-          requires :head_branch, String
-        end
-      end
-      def process
-        stacks.where(branch: params.check_suite.head_branch).each do |stack|
-          stack.commits.where(sha: params.check_suite.head_sha).each(&:schedule_refresh_check_runs!)
-        end
-      end
-    end
-
-    class MembershipHandler < Handler
-      params do
-        requires :action, String
-        requires :team do
-          requires :id, Integer
-          requires :name, String
-          requires :slug, String
-          requires :url, String
-        end
-        requires :organization do
-          requires :login, String
-        end
-        requires :member do
-          requires :login, String
-        end
-      end
-      def process
-        team = find_or_create_team!
-        member = User.find_or_create_by_login!(params.member.login)
-
-        case params.action
-        when 'added'
-          team.add_member(member)
-        when 'removed'
-          team.members.delete(member)
-        else
-          raise ArgumentError, "Don't know how to perform action: `#{action.inspect}`"
-        end
-      end
-
-      private
-
-      def find_or_create_team!
-        Team.find_or_create_by!(github_id: params.team.id) do |team|
-          team.github_team = params.team
-          team.organization = params.organization.login
-        end
-      end
-    end
-
-    HANDLERS = {
-      'push' => PushHandler,
-      'status' => StatusHandler,
-      'membership' => MembershipHandler,
-      'check_suite' => CheckSuiteHandler,
-    }.freeze
-
     def create
-      if handler = HANDLERS[event]
-        handler.new(JSON.parse(request.raw_post)).process
-      end
+      params = JSON.parse(request.raw_post)
+      Shipit::Webhooks.for_event(event).each { |handler| handler.call(params) }
 
-      head :ok
+      head(:ok)
     end
 
     private
@@ -147,7 +20,7 @@ module Shipit
     end
 
     def check_if_ping
-      head :ok if event == 'ping'
+      head(:ok) if event == 'ping'
     end
 
     def event

data/app/helpers/shipit/chunks_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   module ChunksHelper
     def next_chunks_url(task)

data/app/helpers/shipit/deploys_helper.rb

@@ -1,18 +1,19 @@
+# frozen_string_literal: true
 module Shipit
   module DeploysHelper
     def render_checklist(checklist)
       return if checklist.blank?
-      render 'shipit/deploys/checklist', checklist: checklist
+      render('shipit/deploys/checklist', checklist: checklist)
     end
 
     def render_monitoring(stack)
       return unless stack.monitoring?
-      render 'shipit/deploys/monitoring', stack: stack
+      render('shipit/deploys/monitoring', stack: stack)
     end
 
     def render_checks(commit)
       return unless commit.stack.checks?
-      render 'shipit/commit_checks/checks', commit: commit
+      render('shipit/commit_checks/checks', commit: commit)
     end
 
     def render_monitoring_panel(panel_spec)