shipit-engine 0.28.0 → 0.32.0

data/test/controllers/release_statuses_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -10,7 +11,7 @@ module Shipit
 
     test ":create allow users to append release statuses and mark the deploy as success" do
       assert_difference -> { ReleaseStatus.count }, +1 do
-        post :create, params: {stack_id: @stack, deploy_id: @deploy.id, status: 'success'}
+        post :create, params: { stack_id: @stack, deploy_id: @deploy.id, status: 'success' }
         assert_response :created
       end
 
@@ -23,7 +24,7 @@ module Shipit
 
     test ":create allow users to append release statuses and mark the deploy as faulty" do
       assert_difference -> { ReleaseStatus.count }, +1 do
-        post :create, params: {stack_id: @stack, deploy_id: @deploy.id, status: 'failure'}
+        post :create, params: { stack_id: @stack, deploy_id: @deploy.id, status: 'failure' }
         assert_response :created
       end
 

data/test/controllers/rollbacks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -11,37 +12,37 @@ module Shipit
 
     test ":create persists a new rollback" do
       assert_difference '@stack.rollbacks.count', 1 do
-        post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+        post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       end
     end
 
     test ":create can receive an :env hash" do
-      env = {'SAFETY_DISABLED' => '1'}
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: env}}
+      env = { 'SAFETY_DISABLED' => '1' }
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id, env: env } }
       new_rollback = Rollback.last
       assert_equal env, new_rollback.env
     end
 
     test ":create ignore :env keys not declared in the deploy spec" do
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: {'H4X0R' => '1'}}}
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id, env: { 'H4X0R' => '1' } } }
       new_rollback = Rollback.last
       assert_equal({}, new_rollback.env)
     end
 
     test ":create redirects to the new deploy" do
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       assert_redirected_to stack_deploy_path(@stack, Rollback.last)
     end
 
     test ":create locks deploys" do
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       assert @stack.reload.locked?
     end
 
     test ":create redirects back to the :new page if there is an active deploy" do
       shipit_deploys(:shipit_running).update!(allow_concurrency: false, status: 'running')
       assert_no_difference '@stack.deploys.count' do
-        post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+        post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       end
       assert_redirected_to rollback_stack_deploy_path(@stack, @deploy)
     end
@@ -49,7 +50,7 @@ module Shipit
     test ":create with `force` option ignore the active deploys" do
       shipit_deploys(:shipit_running).update_column(:status, 'running')
       assert_difference '@stack.deploys.count', 1 do
-        post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}, force: 'true'}
+        post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id }, force: 'true' }
       end
       assert_redirected_to stack_deploy_path(@stack, Rollback.last)
     end

data/test/controllers/stacks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -46,13 +47,26 @@ module Shipit
       )
     end
 
+    test "#index list all stacks" do
+      get :index
+      assert_response :ok
+      assert_select ".stack", count: Stack.count
+    end
+
+    test "#index list a repo stacks if the :repo params is passed" do
+      repo = shipit_repositories(:shipit)
+      get :index, params: { repo: repo.full_name }
+      assert_response :ok
+      assert_select ".stack", count: repo.stacks.count
+    end
+
     test "#show is success" do
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
       assert_response :ok
     end
 
     test "#show with faulty and validating deploys is success" do
-      get :show, params: {id: shipit_stacks(:shipit_canaries).to_param}
+      get :show, params: { id: shipit_stacks(:shipit_canaries).to_param }
       assert_response :ok
     end
 
@@ -60,18 +74,18 @@ module Shipit
       @stack = shipit_stacks(:check_runs)
       assert_not_equal 0, CheckRun.where(stack_id: @stack.id).count
 
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
       assert_response :ok
     end
 
     test "#show handles locked stacks without a lock_author" do
       @stack.update!(lock_reason: "I am a lock with no author")
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
     end
 
     test "#show auto-links URLs in lock reason" do
       @stack.update!(lock_reason: 'http://google.com')
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
       assert_response :ok
       assert_select 'a[href="http://google.com"]'
     end
@@ -93,27 +107,38 @@ module Shipit
 
     test "#create when not valid renders new" do
       assert_no_difference "Stack.count" do
-        post :create, params: {stack: {repo_owner: 'some', repo_name: 'owner/path'}}
+        post :create, params: { stack: { repo_owner: 'some', repo_name: 'owner/path' } }
       end
       assert_response :success
     end
 
     test "#destroy enqueues a DestroyStackJob" do
       assert_enqueued_with(job: DestroyStackJob, args: [@stack]) do
-        delete :destroy, params: {id: @stack.to_param}
+        delete :destroy, params: { id: @stack.to_param }
       end
       assert_redirected_to stacks_path
     end
 
     test "#settings is success" do
-      get :settings, params: {id: @stack.to_param}
+      get :settings, params: { id: @stack.to_param }
       assert_response :success
     end
 
+    test "#statistics is success" do
+      get :statistics, params: { id: @stack.to_param }
+      assert_response :success
+    end
+
+    test "#statistics redirects to #show if no deploys are present" do
+      @stack.deploys.destroy_all
+      get :statistics, params: { id: @stack.to_param }
+      assert_redirected_to stack_path(@stack)
+    end
+
     test "#update allows to lock the stack" do
       refute @stack.locked?
 
-      patch :update, params: {id: @stack.to_param, stack: {lock_reason: 'Went out to eat some chips!'}}
+      patch :update, params: { id: @stack.to_param, stack: { lock_reason: 'Went out to eat some chips!' } }
       @stack.reload
       assert @stack.locked?
       assert_equal shipit_users(:walrus), @stack.lock_author
@@ -123,8 +148,32 @@ module Shipit
       @stack.update!(lock_reason: 'Went out to eat some chips!')
       assert @stack.locked?
 
-      patch :update, params: {id: @stack.to_param, stack: {lock_reason: ''}}
+      patch :update, params: { id: @stack.to_param, stack: { lock_reason: '' } }
+      @stack.reload
+      refute @stack.locked?
+      assert_instance_of AnonymousUser, @stack.lock_author
+    end
+
+    test "#update allows to archive the stack" do
+      refute @stack.archived?
+      refute @stack.locked?
+
+      patch :update, params: { id: @stack.to_param, stack: { archived: "true" } }
+      @stack.reload
+      assert @stack.archived?
+      assert @stack.locked?
+      assert_equal shipit_users(:walrus), @stack.lock_author
+      assert_equal "Archived", @stack.lock_reason
+    end
+
+    test "#update allows to dearchive the stack" do
+      @stack.archive!(shipit_users(:walrus))
+      assert @stack.locked?
+      assert @stack.archived?
+
+      patch :update, params: { id: @stack.to_param, stack: { archived: "false" } }
       @stack.reload
+      refute @stack.archived?
       refute @stack.locked?
       assert_instance_of AnonymousUser, @stack.lock_author
     end
@@ -135,7 +184,7 @@ module Shipit
       assert_enqueued_with(job: RefreshStatusesJob, args: [stack_id: @stack.id]) do
         assert_enqueued_with(job: RefreshCheckRunsJob, args: [stack_id: @stack.id]) do
           assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
-            post :refresh, params: {id: @stack.to_param}
+            post :refresh, params: { id: @stack.to_param }
           end
         end
       end
@@ -145,23 +194,23 @@ module Shipit
 
     test "#clear_git_cache queues a ClearGitCacheJob" do
       assert_enqueued_with(job: ClearGitCacheJob, args: [@stack]) do
-        post :clear_git_cache, params: {id: @stack.to_param}
+        post :clear_git_cache, params: { id: @stack.to_param }
       end
       assert_redirected_to stack_settings_path(@stack)
     end
 
     test "#clear_git_cache displays a flash message" do
-      post :clear_git_cache, params: {id: @stack.to_param}
+      post :clear_git_cache, params: { id: @stack.to_param }
       assert_equal 'Git Cache clearing scheduled', flash[:success]
     end
 
     test "#update redirects to return_to parameter" do
-      patch :update, params: {id: @stack.to_param, stack: {ignore_ci: false}, return_to: stack_path(@stack)}
+      patch :update, params: { id: @stack.to_param, stack: { ignore_ci: false }, return_to: stack_path(@stack) }
       assert_redirected_to stack_path(@stack)
     end
 
     test "#lookup redirects to the canonical URL" do
-      get :lookup, params: {id: @stack.id}
+      get :lookup, params: { id: @stack.id }
       assert_redirected_to stack_path(@stack)
     end
 

data/test/controllers/status_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/controllers/tasks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -11,7 +12,7 @@ module Shipit
     end
 
     test "tasks defined in the shipit.yml can be displayed" do
-      get :new, params: {stack_id: @stack, definition_id: @definition.id}
+      get :new, params: { stack_id: @stack, definition_id: @definition.id }
       assert_response :ok
     end
 
@@ -20,7 +21,7 @@ module Shipit
 
       assert_predicate @stack, :active_task?
       assert_no_difference -> { @stack.tasks.count } do
-        post :create, params: {stack_id: @stack, definition_id: @definition.id}
+        post :create, params: { stack_id: @stack, definition_id: @definition.id }
       end
       assert_redirected_to new_stack_tasks_path(@stack, @definition)
     end
@@ -30,7 +31,7 @@ module Shipit
 
       assert_predicate @stack, :active_task?
       assert_difference -> { @stack.tasks.count } do
-        post :create, params: {stack_id: @stack, definition_id: @definition.id, force: 'true'}
+        post :create, params: { stack_id: @stack, definition_id: @definition.id, force: 'true' }
       end
       assert_redirected_to stack_task_path(@stack, Task.last)
     end
@@ -38,34 +39,34 @@ module Shipit
     test "tasks defined in the shipit.yml can be triggered while the stack is being deployed if specified as such" do
       @definition = @stack.find_task_definition('flush_cache')
       assert_difference -> { @stack.tasks.count } do
-        post :create, params: {stack_id: @stack, definition_id: @definition.id}
+        post :create, params: { stack_id: @stack, definition_id: @definition.id }
       end
       assert_redirected_to stack_task_path(@stack, Task.last)
     end
 
     test "tasks with variables defined in the shipit.yml can be triggered with their variables set" do
-      env = {"FOO" => "0"}
+      env = { "FOO" => "0" }
 
-      post :create, params: {stack_id: @stack, definition_id: @definition.id, task: {env: env}, force: 'true'}
+      post :create, params: { stack_id: @stack, definition_id: @definition.id, task: { env: env }, force: 'true' }
 
       assert_redirected_to stack_tasks_path(@stack, Task.last)
     end
 
     test "triggered tasks can be observed" do
-      get :show, params: {stack_id: @stack, id: @task.id}
+      get :show, params: { stack_id: @stack, id: @task.id }
       assert_response :ok
     end
 
     test "triggered tasks can be observed as raw text" do
-      get :show, params: {stack_id: @stack, id: @task.id}, format: 'txt'
+      get :show, params: { stack_id: @stack, id: @task.id }, format: 'txt'
       assert_response :success
-      assert_equal("text/plain", @response.content_type)
+      assert_equal("text/plain", @response.media_type)
     end
 
     test ":abort call abort! on the deploy" do
       @task = shipit_deploys(:shipit_running)
       @task.ping
-      post :abort, params: {stack_id: @stack.to_param, id: @task.id}
+      post :abort, params: { stack_id: @stack.to_param, id: @task.id }
 
       @task.reload
       assert_response :success
@@ -77,7 +78,7 @@ module Shipit
     test ":abort schedule the rollback if `rollback` is present" do
       @task = shipit_deploys(:shipit_running)
       @task.ping
-      post :abort, params: {stack_id: @stack.to_param, id: @task.id, rollback: 'true'}
+      post :abort, params: { stack_id: @stack.to_param, id: @task.id, rollback: 'true' }
 
       @task.reload
       assert_response :success
@@ -87,13 +88,13 @@ module Shipit
     end
 
     test ":index list the stack deploys" do
-      get :index, params: {stack_id: @stack.to_param}
+      get :index, params: { stack_id: @stack.to_param }
       assert_response :success
       assert_select '.task-list .task', @stack.tasks.count
     end
 
     test ":index paginates with the `since` parameter" do
-      get :index, params: {stack_id: @stack.to_param, since: @stack.tasks.last.id}
+      get :index, params: { stack_id: @stack.to_param, since: @stack.tasks.last.id }
       assert_response :success
       assert_select '.task-list .task', @stack.tasks.count - 1
     end
@@ -102,7 +103,7 @@ module Shipit
       @task = shipit_deploys(:shipit_running)
       last_chunk = @task.chunks.last
 
-      get :tail, params: {stack_id: @stack.to_param, id: @task.id, last_id: last_chunk.id}, format: :json
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id, last_id: last_chunk.id }, format: :json
       assert_response :success
       assert_json_keys %w(url status output)
       assert_json 'status', @task.status
@@ -111,7 +112,7 @@ module Shipit
     test ":tail doesn't returns the next url if the task is finished" do
       @task = shipit_deploys(:shipit)
 
-      get :tail, params: {stack_id: @stack.to_param, id: @task.id}, format: :json
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
       assert_no_json 'url'
     end
@@ -119,7 +120,7 @@ module Shipit
     test ":tail returns the rollback url if the task have been aborted" do
       @task = shipit_deploys(:shipit_aborted)
 
-      get :tail, params: {stack_id: @stack.to_param, id: @task.id}, format: :json
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
       assert_json_keys %w(status output rollback_url)
     end
@@ -127,7 +128,7 @@ module Shipit
     test ":lookup returns stack task url if the task is an instance of Task" do
       @task = shipit_tasks(:shipit_restart)
 
-      get :lookup, params: {id: @task.id}
+      get :lookup, params: { id: @task.id }
 
       assert_redirected_to stack_task_path(@task.stack, @task)
     end
@@ -135,7 +136,7 @@ module Shipit
     test ":lookup returns stack deploy url if the task is an instance of Deploy" do
       @task = shipit_tasks(:shipit)
 
-      get :lookup, params: {id: @task.id}
+      get :lookup, params: { id: @task.id }
 
       assert_redirected_to stack_deploy_path(@task.stack, @task)
     end
@@ -143,7 +144,7 @@ module Shipit
     test ":lookup returns stack deploy url if the task is an instance of Rollback" do
       @task = shipit_tasks(:shipit_rollback)
 
-      get :lookup, params: {id: @task.id}
+      get :lookup, params: { id: @task.id }
 
       assert_redirected_to stack_deploy_path(@task.stack, @task)
     end

data/test/controllers/webhooks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -7,6 +8,17 @@ module Shipit
       GithubHook.any_instance.stubs(:verify_signature).returns(true)
     end
 
+    test "create github repository which is not yet present in the datastore" do
+      request.headers['X-Github-Event'] = 'push'
+      unknown_repo_payload = JSON.parse(payload(:push_master))
+      unknown_repo_payload["repository"]["full_name"] = "owner/unknown-repository"
+      unknown_repo_payload = unknown_repo_payload.to_json
+
+      assert_nothing_raised do
+        post :create, body: unknown_repo_payload, as: :json
+      end
+    end
+
     test ":push with the target branch queues a GithubSyncJob" do
       request.headers['X-Github-Event'] = 'push'
 
@@ -43,14 +55,14 @@ module Shipit
 
     test ":state with a unexisting commit respond with 200 OK" do
       request.headers['X-Github-Event'] = 'status'
-      params = {'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => [{'name' => 'master'}]}.to_json
+      params = { 'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => [{ 'name' => 'master' }] }.to_json
       post :create, body: params, as: :json
       assert_response :ok
     end
 
     test ":state in an untracked branche bails out" do
       request.headers['X-Github-Event'] = 'status'
-      params = {'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => []}.to_json
+      params = { 'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => [] }.to_json
       post :create, body: params, as: :json
       assert_response :ok
     end
@@ -68,7 +80,7 @@ module Shipit
       @request.headers['X-Github-Event'] = 'ping'
 
       assert_no_enqueued_jobs do
-        post :create, body: {zen: 'Git is beautiful'}.to_json, as: :json
+        post :create, body: { zen: 'Git is beautiful' }.to_json, as: :json
         assert_response :ok
       end
     end
@@ -76,7 +88,7 @@ module Shipit
     test "verifies webhook signature" do
       commit = shipit_commits(:first)
 
-      payload = {"sha" => commit.sha, "state" => "pending", "target_url" => "https://ci.example.com/1000/output"}.to_json
+      payload = { "sha" => commit.sha, "state" => "pending", "target_url" => "https://ci.example.com/1000/output" }.to_json
       signature = 'sha1=4848deb1c9642cd938e8caa578d201ca359a8249'
 
       @request.headers['X-Github-Event'] = 'push'
@@ -105,7 +117,7 @@ module Shipit
       @request.headers['X-Github-Event'] = 'membership'
       Shipit.github.api.expects(:user).with('george').returns(george)
       assert_difference -> { User.count }, 1 do
-        post :create, body: membership_params.merge(member: {login: 'george'}).to_json, as: :json
+        post :create, body: membership_params.merge(member: { login: 'george' }).to_json, as: :json
         assert_response :ok
       end
     end
@@ -121,7 +133,7 @@ module Shipit
     test ":membership can append an user membership" do
       @request.headers['X-Github-Event'] = 'membership'
       assert_difference -> { Membership.count }, 1 do
-        post :create, body: membership_params.merge(member: {login: 'bob'}).to_json, as: :json
+        post :create, body: membership_params.merge(member: { login: 'bob' }).to_json, as: :json
         assert_response :ok
       end
     end
@@ -137,19 +149,34 @@ module Shipit
     test ":membership can delete an user twice" do
       @request.headers['X-Github-Event'] = 'membership'
       assert_no_difference -> { Membership.count } do
-        post :create, body: membership_params.merge(action: 'removed', member: {login: 'bob'}).to_json, as: :json
+        post :create, body: membership_params.merge(action: 'removed', member: { login: 'bob' }).to_json, as: :json
         assert_response :ok
       end
     end
 
+    test "other events trigger custom handlers" do
+      event = 'pull_request'
+      mock_handler = mock
+      mock_handler.expects(:call).with(pull_request_params.stringify_keys).once
+      Shipit::Webhooks.register_handler(event, mock_handler)
+
+      @request.headers['X-Github-Event'] = event
+      post :create, body: pull_request_params.to_json, as: :json
+      assert_response :ok
+    end
+
     private
 
+    def pull_request_params
+      { action: 'opened', number: 2, pull_request: 'foobar' }
+    end
+
     def membership_params
-      {action: 'added', team: team_params, organization: {login: 'shopify'}, member: {login: 'walrus'}}
+      { action: 'added', team: team_params, organization: { login: 'shopify' }, member: { login: 'walrus' } }
     end
 
     def team_params
-      {id: shipit_teams(:shopify_developers).id, slug: 'developers', name: 'Developers', url: 'http://example.com'}
+      { id: shipit_teams(:shopify_developers).id, slug: 'developers', name: 'Developers', url: 'http://example.com' }
     end
 
     def george