shipit-engine 0.28.0 → 0.32.0

data/test/models/deploy_stats_test.rb

@@ -0,0 +1,113 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+module Shipit
+  class DeployStatsTest < ActiveSupport::TestCase
+    def setup
+      @stack = shipit_stacks(:shipit_stats)
+      @stats = Shipit::DeployStats.new(@stack.deploys.not_active)
+      @old_deploys = @stack.deploys.not_active.where(created_at: 62.minutes.ago..32.minutes.ago)
+      @new_deploys = @stack.deploys.not_active.where("created_at > ?", 32.minutes.ago)
+    end
+
+    test "#average_duration is accurate" do
+      assert_equal 225.0, @stats.average_duration
+    end
+
+    test "#median_duration is accurate" do
+      assert_equal 210.0, @stats.median_duration
+    end
+
+    test "#max_duration is accurate" do
+      assert_equal 360.0, @stats.max_duration
+    end
+
+    test "#min_duration is accurate" do
+      assert_equal 120.0, @stats.min_duration
+    end
+
+    test "#success_rate is accurate" do
+      assert_equal 75.0, @stats.success_rate
+    end
+
+    test "#average_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.average_duration
+    end
+
+    test "#median_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.median_duration
+    end
+
+    test "#max_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.max_duration
+    end
+
+    test "#min_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.min_duration
+    end
+
+    test "#success_rate handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.success_rate
+    end
+
+    test "#compare count handles empty compare count" do
+      comparison = Shipit::DeployStats.new([])
+      results = @stats.compare(comparison)
+      assert_equal 400, results[:count]
+    end
+
+    test "#compare average and median handles empty array" do
+      comparison = Shipit::DeployStats.new([])
+      results = @stats.compare(comparison)
+      assert_nil results[:average_duration]
+      assert_nil results[:median_duration]
+    end
+
+    test "#compare average is accurate when negative" do
+      new_data = Shipit::DeployStats.new(@new_deploys)
+      old_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(-53.84615384615385, results[:average_duration])
+    end
+
+    test "#compare median is accurate when negative" do
+      new_data = Shipit::DeployStats.new(@new_deploys)
+      old_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(-50, results[:median_duration])
+    end
+
+    test "#compare count is accurate when negative" do
+      new_data = Shipit::DeployStats.new(@new_deploys)
+      old_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(-66.66666666666666, results[:count])
+    end
+
+    test "#compare average is accurate" do
+      old_data = Shipit::DeployStats.new(@new_deploys)
+      new_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(116.66666666666667, results[:average_duration])
+    end
+
+    test "#compare median is accurate" do
+      old_data = Shipit::DeployStats.new(@new_deploys)
+      new_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(100, results[:median_duration])
+    end
+
+    test "#compare count is accurate" do
+      old_data = Shipit::DeployStats.new(@new_deploys)
+      new_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(200, results[:count])
+    end
+  end
+end

data/test/models/deploys_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -199,6 +200,7 @@ module Shipit
         since_commit: shipit.commits.first,
         until_commit: shipit.commits.last,
       )
+      deploy.stubs(:pull_request_head_for_commit).returns(nil)
 
       expect_event(deploy)
       deploy.save!
@@ -246,6 +248,8 @@ module Shipit
     end
 
     test "transitioning to success enqueues a last-deployed git reference update" do
+      Shipit.stubs(:update_latest_deployed_ref).returns(true)
+
       @deploy = shipit_deploys(:shipit_running)
       assert_enqueued_with(job: UpdateGithubLastDeployedRefJob, args: [@deploy.stack]) do
         @deploy.complete!
@@ -300,15 +304,17 @@ module Shipit
       end
     end
 
-    test "creating a deploy creates one CommitDeployment per commit" do
-      shipit = shipit_stacks(:shipit)
-      deploy = shipit.deploys.build(
-        since_commit: shipit.commits.first,
-        until_commit: shipit.commits.last,
-      )
+    test "transitioning to aborted schedule a rollback to the designated deploy if set" do
+      @rollback_to = shipit_deploys(:shipit_pending)
+      @deploy = shipit_deploys(:shipit_running)
+      @deploy.ping
+      @deploy.pid = 42
+      @deploy.abort!(rollback_once_aborted: true, rollback_once_aborted_to: @rollback_to, aborted_by: @user)
 
-      assert_difference -> { CommitDeployment.count }, deploy.commits.size do
-        deploy.save!
+      assert_difference -> { @stack.rollbacks.count }, 1 do
+        assert_enqueued_with(job: PerformTaskJob) do
+          @deploy.aborted!
+        end
       end
     end
 
@@ -338,10 +344,9 @@ module Shipit
       assert_equal shipit_commits(:second), @stack.last_deployed_commit
     end
 
-    def create_test_stack
+    def create_test_stack(repository: Shipit::Repository.find_or_create_by!(owner: "shopify-test", name: "shipit-engine-test"))
       Shipit::Stack.create(
-        repo_owner: "shopify-test",
-        repo_name: "shipit-engine-test",
+        repository: repository,
         environment: 'production',
         branch: "master",
         merge_queue_enabled: true,
@@ -441,6 +446,20 @@ module Shipit
       assert_equal "Shipit::Rollback", last_deploy.type
     end
 
+    test "#trigger_revert uses rollback_to if set" do
+      test_stack = create_test_stack
+      test_stack.save
+      test_stack.reload
+
+      running_deploy = shipit_deploys(:shipit_running)
+      rollback_to = shipit_deploys(:shipit_pending)
+
+      final_rollback = running_deploy.trigger_revert(rollback_to: rollback_to)
+
+      assert_equal "Shipit::Rollback", final_rollback.type
+      assert_equal 4, final_rollback.until_commit_id
+    end
+
     test "#trigger_revert skips unsuccessful deploys when reverting" do
       user_id = @user.id
       test_stack = create_test_stack
@@ -552,8 +571,7 @@ module Shipit
       user_id = @user.id
       test_stack = create_test_stack
       test_stack.save
-      other_stack = create_test_stack
-      other_stack.repo_name += "_other"
+      other_stack = create_test_stack(repository: Shipit::Repository.create!(owner: "_", name: "_some-other-repository"))
       other_stack.save
       other_stack.reload
       stack_id = test_stack.id
@@ -860,6 +878,35 @@ module Shipit
       end
     end
 
+    test "succeeding a deploy creates CommitDeploymentStatuses" do
+      @deploy = shipit_deploys(:shipit_running)
+      refute_empty @deploy.commit_deployments
+
+      assert_difference -> { CommitDeploymentStatus.count }, @deploy.commit_deployments.size do
+        @deploy.report_complete!
+      end
+
+      assert_equal 'success', CommitDeploymentStatus.last.status
+    end
+
+    test "creates one CommitDeployment and status per commit, and one more for the batch head" do
+      template_task = shipit_tasks(:shipit_pending)
+      deploy = template_task.stack.deploys.build(
+        since_commit: template_task.since_commit,
+        until_commit: template_task.until_commit,
+      )
+
+      expected_delta = deploy.commits.select(&:pull_request?).size + 1
+      assert_difference -> { CommitDeployment.count }, expected_delta do
+        assert_difference -> { CommitDeploymentStatus.count }, expected_delta do
+          deploy.save!
+        end
+      end
+
+      refute_nil CommitDeployment.find_by(sha: '6dcb09b5b57875f334f61aebed695e2e4193db5e')
+      refute_nil CommitDeployment.find_by(sha: deploy.until_commit.sha)
+    end
+
     private
 
     def expect_event(deploy)

data/test/models/duration_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/github_hook_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/hook_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -50,26 +51,29 @@ module Shipit
     end
 
     test ".emit calls #deliver on internal hooks" do
-      begin
-        original_receivers = Shipit.internal_hook_receivers
-        FakeReceiver = Module.new
-        FakeReceiver.expects(:deliver).with(:deploy, @stack, 'foo' => 42)
+      original_receivers = Shipit.internal_hook_receivers
+      FakeReceiver = Module.new
+      FakeReceiver.expects(:deliver).with(:deploy, @stack, 'foo' => 42)
 
-        Shipit.internal_hook_receivers << FakeReceiver
-        Hook.emit(:deploy, @stack, 'foo' => 42)
-      ensure
-        Shipit.internal_hook_receivers = original_receivers
-      end
+      Shipit.internal_hook_receivers << FakeReceiver
+      Hook.emit(:deploy, @stack, 'foo' => 42)
+    ensure
+      Shipit.internal_hook_receivers = original_receivers
     end
 
     test ".emit calls no internal hooks if there are no internal_hook_receivers" do
-      begin
-        original_receivers = Shipit.internal_hook_receivers
-        Shipit.internal_hook_receivers = nil
-        Hook.emit(:deploy, @stack, 'foo' => 42)
-      ensure
-        Shipit.internal_hook_receivers = original_receivers
-      end
+      original_receivers = Shipit.internal_hook_receivers
+      Shipit.internal_hook_receivers = nil
+      Hook.emit(:deploy, @stack, 'foo' => 42)
+    ensure
+      Shipit.internal_hook_receivers = original_receivers
+    end
+
+    test ".coerce_payload coerces anonymous user correctly" do
+      locked_stack = Stack.first
+      locked_stack.lock("Some Reason", nil)
+      serialized = Hook.coerce_payload(stack: locked_stack)
+      assert_json("stack.lock_author.anonymous", true, document: serialized)
     end
   end
 end

data/test/models/membership_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/output_chunk_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/pull_request_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -116,7 +117,7 @@ module Shipit
         )
       end
 
-      Shipit.github.api.expects(:statuses).with(@stack.github_repo_name, head_sha).returns([stub(
+      Shipit.github.api.expects(:statuses).with(@stack.github_repo_name, head_sha, per_page: 100).returns([stub(
         state: 'success',
         description: nil,
         context: 'default',
@@ -183,23 +184,29 @@ module Shipit
       refute_predicate @pr, :rejected?
     end
 
-    test "#reject_unless_mergeable! reject the PR if it has a missing CI status" do
+    test "#reject_unless_mergeable! reject the PR if it has a missing required CI status" do
+      @pr.stack.cached_deploy_spec.stubs(:required_statuses).returns(['ci/circle'])
       @pr.head.statuses.where(context: 'ci/circle').delete_all
 
-      assert_predicate @pr, :all_status_checks_passed?
+      refute_predicate @pr, :all_status_checks_passed?
       refute_predicate @pr, :any_status_checks_failed?
-      assert_equal false, @pr.reject_unless_mergeable!
-      refute_predicate @pr, :rejected?
+      assert_predicate @pr, :any_status_checks_missing?
+      assert_equal true, @pr.reject_unless_mergeable!
+      assert_predicate @pr, :rejected?
+      assert_equal 'ci_missing', @pr.rejection_reason
     end
 
     test "#reject_unless_mergeable! reject the PR if it has a missing CI status (multi-status)" do
+      @pr.stack.cached_deploy_spec.stubs(:required_statuses).returns(['ci/circle'])
       @pr.head.statuses.where(context: 'ci/circle').delete_all
       @pr.head.statuses.create!(stack: @pr.stack, state: 'success', context: 'ci/travis')
 
-      assert_predicate @pr, :all_status_checks_passed?
+      refute_predicate @pr, :all_status_checks_passed?
       refute_predicate @pr, :any_status_checks_failed?
-      assert_equal false, @pr.reject_unless_mergeable!
-      refute_predicate @pr, :rejected?
+      assert_predicate @pr, :any_status_checks_missing?
+      assert_equal true, @pr.reject_unless_mergeable!
+      assert_predicate @pr, :rejected?
+      assert_equal 'ci_missing', @pr.rejection_reason
     end
 
     test "#reject_unless_mergeable! rejects the PR if it is stale" do
@@ -265,7 +272,7 @@ module Shipit
           behind_by: 10,
         ),
       )
-      spec = {'merge' => {'max_divergence' => {'commits' => 1}}}
+      spec = { 'merge' => { 'max_divergence' => { 'commits' => 1 } } }
       @pr.stack.cached_deploy_spec = DeploySpec.new(spec)
       assert_predicate @pr, :stale?
     end
@@ -273,14 +280,14 @@ module Shipit
     test "#stale? returns true when the branch falls behind the maximum age" do
       @pr.base_commit = shipit_commits(:second)
       @pr.head.committed_at = 2.hours.ago
-      spec = {'merge' => {'max_divergence' => {'age' => '1h'}}}
+      spec = { 'merge' => { 'max_divergence' => { 'age' => '1h' } } }
       @pr.stack.cached_deploy_spec = DeploySpec.new(spec)
       assert_predicate @pr, :stale?
     end
 
     test "#stale? is false when base_commit information is missing" do
       @pr.base_commit = nil
-      spec = {'merge' => {'max_divergence' => {'age' => '1h', 'commits' => 10}}}
+      spec = { 'merge' => { 'max_divergence' => { 'age' => '1h', 'commits' => 10 } } }
       @pr.stack.cached_deploy_spec = DeploySpec.new(spec)
       refute_predicate @pr, :stale?
     end

data/test/models/release_statuses_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/rollbacks_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/shipit/check_run_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/shipit/repository_test.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+module Shipit
+  class RepositoryTest < ActiveSupport::TestCase
+    setup do
+      @repository = shipit_repositories(:shipit)
+    end
+
+    test "owner, and name uniqueness is enforced" do
+      clone = Repository.new(@repository.attributes.except('id'))
+      refute clone.save
+      assert_equal ["cannot be used more than once"], clone.errors[:name]
+    end
+
+    test "owner, name, and environment can only be ASCII" do
+      @repository.update(owner: 'héllò', name: 'wørld')
+      refute_predicate @repository, :valid?
+    end
+
+    test "owner and name are case insensitive" do
+      assert_no_difference -> { Repository.count } do
+        error = assert_raises ActiveRecord::RecordInvalid do
+          Repository.create!(
+            owner: @repository.owner.upcase,
+            name: @repository.name.upcase,
+          )
+        end
+        assert_equal 'Validation failed: Name cannot be used more than once', error.message
+      end
+
+      new_repository = Repository.create!(owner: 'FOO', name: 'BAR')
+      assert_equal new_repository, Repository.find_by(owner: 'foo', name: 'bar')
+    end
+
+    test "owner is automatically downcased" do
+      @repository.owner = 'George'
+      assert_equal 'george', @repository.owner
+    end
+
+    test "name is automatically downcased" do
+      @repository.name = 'Cyclim.se'
+      assert_equal 'cyclim.se', @repository.name
+    end
+
+    test "owner cannot contain a `/`" do
+      assert @repository.valid?
+      @repository.owner = 'foo/bar'
+      refute @repository.valid?
+    end
+
+    test "name cannot contain a `/`" do
+      assert @repository.valid?
+      @repository.name = 'foo/bar'
+      refute @repository.valid?
+    end
+
+    test "http_url" do
+      assert_equal "https://github.com/#{@repository.owner}/#{@repository.name}", @repository.http_url
+    end
+
+    test "git_url" do
+      assert_equal "https://github.com/#{@repository.owner}/#{@repository.name}.git", @repository.git_url
+    end
+
+    test "from_github_repo_name" do
+      owner = "repository-owner"
+      name = "repository-name"
+      github_repo_name = [owner, name].join("/")
+      expected_repository = Repository.create(owner: owner, name: name)
+
+      found_repository = Repository.from_github_repo_name(github_repo_name)
+
+      assert_equal(expected_repository, found_repository)
+    end
+  end
+end