sbf-dm-validations 1.3.0.beta

data/spec/integration/required_field_validator/association_spec.rb

@@ -0,0 +1,69 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'required_field_validator/association_spec' do
+
+  before :all do
+
+    class ::Artist
+
+      include DataMapper::Resource
+
+      property :id,   Serial
+      property :name, String,  :auto_validation => false
+
+      has n, :albums
+
+      validates_presence_of :name
+
+    end
+
+    class ::Album
+
+      include DataMapper::Resource
+
+      property :id,        Serial
+      property :name,      String,  :auto_validation => false
+      property :artist_id, Integer, :index => :artist
+
+      belongs_to :artist
+
+      validates_presence_of :name, :artist
+
+    end
+
+    Artist.auto_migrate!
+    Album.auto_migrate!
+  end
+
+
+  describe 'Album' do
+
+    before do
+      @artist = Artist.create(:name => "Oceanlab")
+      @album  = @artist.albums.new(:name => "Sirens of the sea")
+    end
+
+    describe 'with a missing artist' do
+      before do
+        @album.artist = nil
+      end
+
+      it 'is not valid' do
+        expect(@album).not_to be_valid
+      end
+
+      it 'has a meaninful error messages on association key property' do
+        @album.valid?
+        expect(@album.errors.on(:artist)).to eq [ 'Artist must not be blank' ]
+      end
+    end
+
+    describe 'with specified artist and name' do
+      it 'is valid' do
+        expect(@album).to be_valid
+      end
+    end
+  end
+
+end

data/spec/integration/required_field_validator/boolean_type_value_spec.rb

@@ -0,0 +1,164 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'required_field_validator/boolean_type_value_spec' do
+
+  # keep in mind any ScmOperation has a default value for brand property
+  # so it is used
+  describe 'GitOperation' do
+    before :all do
+      GitOperation.auto_migrate!
+    end
+
+    before do
+      @operation = GitOperation.new(:network_connection => true,
+                                    :clean_working_copy => true,
+                                    :message            => "I did it! I did it!! Hell yeah!!!")
+    end
+
+    describe "without operation name" do
+      before do
+        @operation.name = nil
+      end
+      it_behaves_like 'unnamed SCM operation'
+    end
+
+
+
+    describe "without network connection" do
+      before do
+        # now note that false make sense from readability
+        # point of view but is incorrect from validator
+        # point of view ;)
+        @operation.network_connection = nil
+      end
+
+      it "is valid for committing" do
+        expect(@operation).to be_valid_for_committing
+        expect(@operation.errors.on(:network_connection)).to be_nil
+      end
+
+      it "is not valid for pushing" do
+        expect(@operation).not_to be_valid_for_pushing
+        # Note: the previous API supported error messages as Hashes (context)
+        #   I will remove that capability, such that a Rule only stores the
+        #   message for the context to which the Rule is bound
+        #   This will provide the same information, but with a simpler API
+        # @operation.errors.on(:network_connection).
+        #   expect(first).to eq 'though git is advanced, it cannot push without network connectivity'
+        @operation.errors.on(:network_connection).
+          expect(first[:pushing]).to eq 'though git is advanced, it cannot push without network connectivity'
+      end
+
+      it "is not valid for pulling" do
+        expect(@operation).not_to be_valid_for_pulling
+        # NOTE: See previous spec, above
+        @operation.errors.on(:network_connection).
+          expect(first[:pulling]).to eq 'you must have network connectivity to pull from others'
+        # @operation.errors.on(:network_connection).
+        #   expect(first).to eq 'you must have network connectivity to pull from others'
+      end
+
+      it "is not valid in default context" do
+        expect(@operation).not_to be_valid
+      end
+    end
+
+    describe "with a network connection" do
+      before do
+        @operation.network_connection = false
+      end
+
+      it "is valid for committing" do
+        expect(@operation).to be_valid_for_committing
+      end
+
+      it "is valid for pushing" do
+        expect(@operation).to be_valid_for_pushing
+      end
+
+      it "is valid for pulling" do
+        expect(@operation).to be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        expect(@operation).not_to be_valid
+      end
+    end
+
+
+    describe "WITHOUT a clean working copy" do
+      before do
+        @operation.clean_working_copy = nil
+      end
+
+      it "is valid for committing" do
+        expect(@operation).to be_valid_for_committing
+      end
+
+      it "is valid for pushing" do
+        expect(@operation).to be_valid_for_pushing
+      end
+
+      it "is not valid for pulling" do
+        expect(@operation).not_to be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        expect(@operation).not_to be_valid
+      end
+    end
+
+    describe "with a clean working copy" do
+      before do
+        @operation.clean_working_copy = true
+      end
+
+      it "is valid for committing" do
+        expect(@operation).to be_valid_for_committing
+      end
+
+      it "is valid for pushing" do
+        expect(@operation).to be_valid_for_pushing
+      end
+
+      it "is valid for pulling" do
+        expect(@operation).to be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        expect(@operation).not_to be_valid
+      end
+    end
+  end
+
+
+  describe 'SubversionOperation' do
+    before do
+      SubversionOperation.auto_migrate!
+
+      @operation = SubversionOperation.new :name    => "ci", :network_connection => true,
+                                           :message => "v1.5.8", :clean_working_copy => true
+    end
+
+    describe "without operation name" do
+      before do
+        @operation.name = nil
+      end
+      it_behaves_like 'unnamed SCM operation'
+    end
+
+    describe "without network connection" do
+      before do
+        @operation.network_connection = nil
+      end
+
+      it "virtually useless" do
+        expect(@operation).not_to be_valid_for_committing
+        expect(@operation).not_to be_valid_for_log_viewing
+      end
+    end
+  end
+
+
+end

data/spec/integration/required_field_validator/date_type_value_spec.rb

@@ -0,0 +1,127 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'required_field_validator/date_type_value_spec' do
+
+  class Holiday
+    #
+    # Behaviors
+    #
+
+    include DataMapper::Resource
+
+    #
+    # Properties
+    #
+
+    property :id, Serial
+    property :on, Date,    :auto_validation => false
+
+    #
+    # Validations
+    #
+
+    validates_presence_of :on
+  end
+
+  describe 'Holiday' do
+    before :all do
+      Holiday.auto_migrate!
+    end
+
+    before do
+      @ny09 = Holiday.new(:on => Date.new(2008, 12, 31))
+      expect(@ny09).to be_valid
+    end
+
+
+    describe "with on = nil" do
+      before do
+        @ny09.on = nil
+      end
+
+      it "is NOT valid" do
+        # nil = missing for Date value
+        # and Holiday only has default validation context
+        expect(@ny09).not_to be_valid
+
+        # sanity check
+        @ny09.on = Date.new(2008, 12, 31)
+        expect(@ny09).to be_valid
+      end
+    end
+
+
+    describe "with on = valid date" do
+      before do
+        @ny09.on = 0.0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        expect(@ny09).to be_valid
+      end
+    end
+
+
+
+    describe "with on = 0" do
+      before do
+        @ny09.on = 0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        expect(@ny09).to be_valid
+      end
+    end
+
+
+
+    describe "with on = 100" do
+      before do
+        @ny09.on = 100
+      end
+
+      it "IS valid" do
+        expect(@ny09).to be_valid
+      end
+    end
+
+
+    describe "with on = 100.0" do
+      before do
+        @ny09.on = 100.0
+      end
+
+      it "IS valid" do
+        expect(@ny09).to be_valid
+      end
+    end
+
+
+    describe "with on = -1100" do
+      before do
+        # presence validator does not care
+        @ny09.on = -1100
+      end
+
+      it "IS valid" do
+        expect(@ny09).to be_valid
+      end
+    end
+
+
+    describe "with on = -1100.5" do
+      before do
+        # presence validator does not care
+        @ny09.on = -1100.5
+      end
+
+      it "IS valid" do
+        expect(@ny09).to be_valid
+      end
+    end
+  end
+
+end

data/spec/integration/required_field_validator/datetime_type_value_spec.rb

@@ -0,0 +1,127 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'required_field_validator/datetime_type_value_spec' do
+
+  class ScheduledOperation
+    #
+    # Behaviors
+    #
+
+    include DataMapper::Resource
+
+    #
+    # Properties
+    #
+
+    property :id, Serial
+    property :at, DateTime, :auto_validation => false
+
+    #
+    # Validations
+    #
+
+    validates_presence_of :at
+  end
+
+  describe 'ScheduledOperation' do
+    before :all do
+      ScheduledOperation.auto_migrate!
+    end
+
+    before do
+      @operation = ScheduledOperation.new(:at => DateTime.civil(2008, 06, 07, 15, 00, 00))
+      expect(@operation).to be_valid
+    end
+
+
+    describe "with on = nil" do
+      before do
+        @operation.at = nil
+      end
+
+      it "is NOT valid" do
+        # nil = missing for Date value
+        # and ScheduledOperation only has default validation context
+        expect(@operation).not_to be_valid
+
+        # sanity check
+        @operation.at = Date.new(2008, 12, 31)
+        expect(@operation).to be_valid
+      end
+    end
+
+
+    describe "with on = valid date" do
+      before do
+        @operation.at = 0.0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        expect(@operation).to be_valid
+      end
+    end
+
+
+
+    describe "with on = 0" do
+      before do
+        @operation.at = 0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        expect(@operation).to be_valid
+      end
+    end
+
+
+
+    describe "with on = 100" do
+      before do
+        @operation.at = 100
+      end
+
+      it "IS valid" do
+        expect(@operation).to be_valid
+      end
+    end
+
+
+    describe "with on = 100.0" do
+      before do
+        @operation.at = 100.0
+      end
+
+      it "IS valid" do
+        expect(@operation).to be_valid
+      end
+    end
+
+
+    describe "with on = -1100" do
+      before do
+        # presence validator does not care
+        @operation.at = -1100
+      end
+
+      it "IS valid" do
+        expect(@operation).to be_valid
+      end
+    end
+
+
+    describe "with on = -1100.5" do
+      before do
+        # presence validator does not care
+        @operation.at = -1100.5
+      end
+
+      it "IS valid" do
+        expect(@operation).to be_valid
+      end
+    end
+  end
+
+end

data/spec/integration/required_field_validator/float_type_value_spec.rb

@@ -0,0 +1,131 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'required_field_validator/float_type_value_spec' do
+
+  #
+  # Especially stupid example since Hg adds local repository revision
+  # to each new commit, but lets roll on with this SCM-ish classes and
+  # still show how Integer type values are validated for presence
+  #
+  class CpuConsumption
+    #
+    # Behaviors
+    #
+
+    include DataMapper::Resource
+
+    #
+    # Properties
+    #
+
+    property :id,      Serial
+    property :percent, Float,   :auto_validation => false
+
+    #
+    # Validations
+    #
+
+    validates_presence_of :percent
+  end
+
+  describe 'CpuConsumption' do
+    before :all do
+      CpuConsumption.auto_migrate!
+    end
+
+    before do
+      @metric = CpuConsumption.new(:percent => 20.0)
+      expect(@metric).to be_valid
+    end
+
+    describe "with percentage = 0.0" do
+      before do
+        @metric.percent = 0.0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        expect(@metric).to be_valid
+      end
+    end
+
+
+
+    describe "with percentage = 0" do
+      before do
+        @metric.percent = 0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        expect(@metric).to be_valid
+      end
+    end
+
+
+
+    describe "with percentage = 100" do
+      before do
+        @metric.percent = 100
+      end
+
+      it "IS valid" do
+        expect(@metric).to be_valid
+      end
+    end
+
+
+    describe "with percentage = 100.0" do
+      before do
+        @metric.percent = 100.0
+      end
+
+      it "IS valid" do
+        expect(@metric).to be_valid
+      end
+    end
+
+
+    describe "with percentage = -1100" do
+      before do
+        # presence validator does not care
+        @metric.percent = -1100
+      end
+
+      it "IS valid" do
+        expect(@metric).to be_valid
+      end
+    end
+
+
+    describe "with percentage = -1100.5" do
+      before do
+        # presence validator does not care
+        @metric.percent = -1100.5
+      end
+
+      it "IS valid" do
+        expect(@metric).to be_valid
+      end
+    end
+
+
+    describe "with percentage = nil" do
+      before do
+        @metric.percent = nil
+      end
+
+      it "is NOT valid" do
+        # nil = missing for float value
+        # and CpuConsumption only has default validation context
+        expect(@metric).not_to be_valid
+
+        # sanity check
+        @metric.percent = 100
+        expect(@metric).to be_valid
+      end
+    end
+  end
+
+end

data/spec/integration/required_field_validator/integer_type_value_spec.rb

@@ -0,0 +1,99 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'required_field_validator/integer_type_value_spec' do
+
+  #
+  # Especially stupid example since Hg adds local repository revision
+  # to each new commit, but lets roll on with this SCM-ish classes and
+  # still show how Integer type values are validated for presence
+  #
+  class HgCommit < ScmOperation
+    #
+    # Properties
+    #
+
+    property :local_repo_revision_num, Integer, :auto_validation => false
+
+    #
+    # Validations
+    #
+
+    validates_presence_of :local_repo_revision_num
+  end
+
+  describe 'HgCommit' do
+    before :all do
+      HgCommit.auto_migrate!
+    end
+
+    before do
+      @operation = HgCommit.new(:local_repo_revision_num => 90, :name => "ci")
+      expect(@operation).to be_valid
+    end
+
+    describe "with local revision number = 0" do
+      before do
+        @operation.local_repo_revision_num = 0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        expect(@operation).to be_valid
+      end
+    end
+
+
+
+    describe "with local revision number = 100" do
+      before do
+        @operation.local_repo_revision_num = 100
+      end
+
+      it "IS valid" do
+        expect(@operation).to be_valid
+      end
+    end
+
+
+    describe "with local revision number = 100.0 (float!)" do
+      before do
+        @operation.local_repo_revision_num = 100.0
+      end
+
+      it "IS valid" do
+        expect(@operation).to be_valid
+      end
+    end
+
+
+    describe "with local revision number = -1100" do
+      before do
+        # presence validator does not care
+        @operation.local_repo_revision_num = -1100
+      end
+
+      it "IS valid" do
+        expect(@operation).to be_valid
+      end
+    end
+
+
+    describe "with local revision number = nil" do
+      before do
+        @operation.local_repo_revision_num = nil
+      end
+
+      it "is NOT valid" do
+        # nil = missing for integer value
+        # and HgCommit only has default validation context
+        expect(@operation).not_to be_valid
+
+        # sanity check
+        @operation.local_repo_revision_num = 100
+        expect(@operation).to be_valid
+      end
+    end
+  end
+
+end