sbf-dm-validations 1.3.0.beta

data/spec/integration/conditional_validation/if_condition_spec.rb

@@ -0,0 +1,63 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::UDPPacket' do
+  before :all do
+    DataMapper::Validations::Fixtures::UDPPacket.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::UDPPacket.new
+  end
+
+  describe "that is transported encapsulated into IPv4 packet" do
+    before :all do
+      @model.underlying_ip_version = 4
+    end
+
+    describe "and has no checksum" do
+      before :all do
+        @model.checksum = nil
+      end
+
+      it_behaves_like 'valid model'
+    end
+
+    describe "and has no checksum algorithm" do
+      before :all do
+        @model.checksum_algorithm = nil
+      end
+
+      it_behaves_like 'valid model'
+    end
+  end
+
+
+  describe "that is transported encapsulated into IPv6 packet" do
+    before :all do
+      @model.underlying_ip_version = 6
+    end
+
+    describe "and has no checksum" do
+      before :all do
+        @model.checksum = nil
+      end
+
+      it_behaves_like 'invalid model'
+
+      it "has a meaningful error message" do
+        expect(@model.errors.on(:checksum)).to eq [ 'Checksum is mandatory when used with IPv6' ]
+      end
+    end
+
+    describe "and has no checksum algorithm" do
+      before :all do
+        @model.checksum_algorithm = nil
+      end
+
+      it_behaves_like 'invalid model'
+
+      it "has a meaningful error message" do
+        expect(@model.errors.on(:checksum_algorithm)).to eq [ 'Checksum is mandatory when used with IPv6' ]
+      end
+    end
+  end
+end

data/spec/integration/conditional_validation/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/confirmation_validator/confirmation_validator_spec.rb

@@ -0,0 +1,76 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+shared_examples 'reservation with mismatched person name' do
+  it 'has meaningful error message' do
+    expect(@model.errors.on(:person_name)).to eq ['Person name does not match the confirmation']
+  end
+end
+
+shared_examples 'reservation with mismatched seats number' do
+  it 'has meaningful error message' do
+    # Proc gets expanded here
+    expect(@model.errors.on(:number_of_seats)).to eq ['Reservation requires confirmation for number_of_seats']
+  end
+end
+
+
+describe 'DataMapper::Validations::Fixtures::Reservation' do
+  before :all do
+    DataMapper::Validations::Fixtures::Reservation.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::Reservation.new(:person_name                  => "Tyler Durden",
+                                                             :person_name_confirmation     => "Tyler Durden",
+                                                             :number_of_seats              => 2,
+                                                             :seats_confirmation           => 2)
+    expect(@model).to be_valid
+  end
+
+  describe "with matching person name and confirmation" do
+    before :all do
+      @model.person_name = "mismatch"
+    end
+
+    it_behaves_like 'invalid model'
+    it_behaves_like 'reservation with mismatched person name'
+  end
+
+
+  describe "with a blank person name and confirmation" do
+    before :all do
+      @model.person_name = ""
+    end
+
+    it_behaves_like 'invalid model'
+    it_behaves_like 'reservation with mismatched person name'
+  end
+
+
+  describe "with a missing person name and confirmation" do
+    before :all do
+      @model.person_name = nil
+    end
+
+    it_behaves_like 'invalid model'
+    it_behaves_like 'reservation with mismatched person name'
+  end
+
+
+  describe "with mismatching number of seats and confirmation" do
+    before :all do
+      @model.number_of_seats  = -1
+    end
+
+    it_behaves_like 'invalid model'
+    it_behaves_like 'reservation with mismatched seats number'
+  end
+
+
+  describe "with a blank number of seats and confirmation" do
+    before :all do
+      @model.number_of_seats = nil
+    end
+
+    it_behaves_like 'valid model'
+  end
+end

data/spec/integration/confirmation_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/datamapper_models/association_validation_spec.rb

@@ -0,0 +1,29 @@
+require_relative '../../spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::Product' do
+  before :all do
+    DataMapper::Validations::Fixtures::ProductCompany.auto_migrate!
+    DataMapper::Validations::Fixtures::Product.auto_migrate!
+
+    parent_model = DataMapper::Validations::Fixtures::ProductCompany
+    @parent = parent_model.new(:title => "Apple", :flagship_product => "Macintosh")
+    expect(@parent).to be_valid
+    expect(@parent.save).to be_true
+
+    model_model = DataMapper::Validations::Fixtures::Product
+    @model = model_model.new(:name => "MacBook Pro", :company => @parent)
+    expect(@model).to be_valid
+  end
+
+  describe "without company" do
+    before :all do
+      @model.company = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:company)).to eq [ 'Company must not be blank' ]
+    end
+  end
+end

data/spec/integration/datamapper_models/inheritance_spec.rb

@@ -0,0 +1,82 @@
+require_relative '../../spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::ServiceCompany' do
+  before :all do
+    DataMapper::Validations::Fixtures::ServiceCompany.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::ServiceCompany.new(:title => "Monsters, Inc.", :area_of_expertise => "Little children's nightmares")
+    @model.valid?
+  end
+
+  describe "without title" do
+    before :all do
+      @model.title = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message for inherited property" do
+      expect(@model.errors.on(:title)).to eq [ 'Company name is a required field' ]
+    end
+  end
+
+  describe "without area of expertise" do
+    before :all do
+      @model.area_of_expertise = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message for own property" do
+      expect(@model.errors.on(:area_of_expertise)).to eq [ 'Area of expertise must not be blank' ]
+    end
+  end
+end
+
+
+
+describe 'DataMapper::Validations::Fixtures::ProductCompany' do
+  before :all do
+    DataMapper::Validations::Fixtures::ProductCompany.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::ProductCompany.new(:title => "Apple", :flagship_product => "Macintosh")
+    @model.valid?
+  end
+
+  it_behaves_like 'valid model'
+
+  describe "without title" do
+    before :all do
+      @model.title = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has error message from the subclass itself" do
+      expect(@model.errors.on(:title)).to include('Product company must have a name')
+    end
+
+    # this may or may not be a desired behavior,
+    # but append vs. replace is a matter of opinion
+    # anyway
+    #
+    # TODO: there should be a way to clear validations for a field
+    # that subclasses can use
+    it "has error message from superclass" do
+      expect(@model.errors.on(:title)).to include('Company name is a required field')
+    end
+  end
+
+
+  describe "without flagship product" do
+    before :all do
+      @model.flagship_product = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message for own property" do
+      expect(@model.errors.on(:flagship_product)).to eq [ 'Flagship product must not be blank' ]
+    end
+  end
+end

data/spec/integration/dirty_attributes/dirty_attributes_spec.rb

@@ -0,0 +1,13 @@
+require_relative '../../spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::LlamaSpaceship' do
+  before :all do
+    DataMapper::Validations::Fixtures::LlamaSpaceship.auto_migrate!
+  end
+
+  it "validates even non dirty attributes" do
+    spaceship = DataMapper::Validations::Fixtures::LlamaSpaceship.create(:type => "custom", :color => "pink")
+    spaceship.type = "standard"
+    expect(spaceship).not_to be_valid
+  end
+end

data/spec/integration/duplicated_validations/duplicated_validations_spec.rb

@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::Page' do
+  before :all do
+    DataMapper::Validations::Fixtures::Page.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::Page.new(:id => 1024)
+  end
+
+  describe "without body" do
+    before :all do
+      @model.body = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "does not have duplicated error messages" do
+      expect(@model.errors.on(:body)).to eq ["Body must not be blank"]
+    end
+  end
+end

data/spec/integration/duplicated_validations/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/format_validator/email_format_validator_spec.rb

@@ -0,0 +1,139 @@
+# encoding: UTF-8
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::BillOfLading' do
+  before :all do
+    DataMapper::Validations::Fixtures::BillOfLading.auto_migrate!
+  end
+
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  @valid_email_addresses = [
+        '+1~1+@example.com',
+        '{_dave_}@example.com',
+        '"[[ dave ]]"@example.com',
+        'dave."dave"@example.com',
+        'test@example.com',
+        'test@example.co.uk',
+        'test@example.com.br',
+        '"J. P. \'s-Gravezande, a.k.a. The Hacker!"@example.com',
+        'me@[187.223.45.119]',
+        'someone@123.com',
+        'simon&garfunkel@songs.com'].each do |email|
+
+    describe "with email value of #{email} (RFC2822 compliant)" do
+      before :all do
+        @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:email => email))
+      end
+
+      it_behaves_like 'valid model'
+    end
+  end
+
+
+  @invalid_email_addresses = [
+        '-- dave --@example.com',
+        '[dave]@example.com',
+        '.dave@example.com',
+        'Max@Job 3:14',
+        'Job@Book of Job',
+        'test@localhost',
+        'J. P. \'s-Gravezande, a.k.a. The Hacker!@example.com',
+        "test@example.com\nsomething after the newline"].each do |email|
+    describe "with email value of #{email} (non RFC2822 compliant)" do
+      before :all do
+        @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:email => email))
+      end
+
+      it_behaves_like 'invalid model'
+    end
+  end
+
+  describe "with valid email including unicode characters" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:email => 'pelé@gmail.com'))
+    end
+
+    if (RUBY_VERSION == '1.9.2' && RUBY_ENGINE == 'jruby') || RUBY_VERSION == '1.9.3'
+      # Not supported on jruby 1.9 or 1.9.3 yet - see formats/email.rb
+      it 'does not raise an error' do
+        expect { @model.valid? }.not_to raise_error
+      end
+    else
+      # Unicode emails not supported on MRI18
+      unless !defined?(RUBY_ENGINE) && RUBY_VERSION == '1.8.7'
+        it 'behaves like valid model' do
+          expect(@model).to be_valid
+        end
+      end
+    end
+  end
+
+
+  it 'has a pre-defined URL format' do
+    bad = [ 'http:// example.com',
+            'ftp://example.com',
+            'http://.com',
+            'http://',
+            'test',
+            '...'
+          ]
+
+    good = [
+            'http://example.com',
+            'http://www.example.com',
+           ]
+
+    bol = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.except(:url))
+    expect(bol).not_to be_valid
+    expect(bol.errors.on(:url)).to eq [ 'Url has an invalid format' ]
+
+    bad.map do |e|
+      bol.url = e
+      bol.valid?
+      expect(bol.errors.on(:url)).to eq [ 'Url has an invalid format' ]
+    end
+
+    good.map do |e|
+      bol.url = e
+      bol.valid?
+      expect(bol.errors.on(:url)).to be_nil
+    end
+
+  end
+
+  describe 'with a regexp' do
+    before do
+      @bol = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes)
+      expect(@bol).to be_valid
+    end
+
+    describe 'if matched' do
+      before do
+        @bol.username = 'a12345'
+      end
+
+      it 'validates' do
+        expect(@bol).to be_valid
+      end
+    end
+
+    describe 'if not matched' do
+      before do
+        @bol.username = '12345'
+      end
+
+      it 'does not validate' do
+        expect(@bol).not_to be_valid
+      end
+
+      it 'sets an error message' do
+        @bol.valid?
+        expect(@bol.errors.on(:username)).to eq [ 'Username must have at least one letter' ]
+      end
+    end
+  end
+end

data/spec/integration/format_validator/format_validator_spec.rb

@@ -0,0 +1,64 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::BillOfLading' do
+  before :all do
+    DataMapper::Validations::Fixtures::BillOfLading.auto_migrate!
+  end
+
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  describe "with doc no with value of 'BAD CODE :)'" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:doc_no => 'BAD CODE :)'))
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has meaningful error message on invalid field" do
+      expect(@model.errors.on(:doc_no)).to eq [ 'Doc no has an invalid format' ]
+    end
+  end
+
+  describe "with doc no with value of 'A1234'" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:doc_no => 'A1234'))
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "with doc no with value of 'B123456X12'" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:doc_no => 'B123456X12'))
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "with missing url" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.except(:url))
+    end
+
+    it_behaves_like 'invalid model'
+  end
+
+  describe "with blank name" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:username => ''))
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "with blank email" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:email => ''))
+    end
+
+    it_behaves_like 'valid model'
+  end
+end

data/spec/integration/format_validator/regexp_validator_spec.rb

@@ -0,0 +1,33 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::BillOfLading' do
+  before :all do
+    DataMapper::Validations::Fixtures::BillOfLading.auto_migrate!
+  end
+
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  describe "with code of 123456" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:code => '123456'))
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+
+  describe "with code of 12" do
+    before :all do
+      @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:code => '12'))
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:code)).to eq [ 'Code format is invalid' ]
+    end
+  end
+end

data/spec/integration/format_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/format_validator/url_format_validator_spec.rb

@@ -0,0 +1,91 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::BillOfLading' do
+  before :all do
+    DataMapper::Validations::Fixtures::BillOfLading.auto_migrate!
+  end
+
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  invalid_uris = [ 'http:// example.com', 'ftp://example.com', 'http://.com', 'http://', 'test', '...',
+    # these are valid URIs from RFC perspective,
+    # but too often not the case for web apps
+    #
+    # TODO: add another format that is strictly
+    # RFC compliant so it can be used, for instance,
+    # for internal apps that may refer to local domains
+    # like http://backend:8080
+    "http://localhost:4000", "http://localhost" ]
+
+  invalid_uris.each do |uri|
+    describe "with URL of #{uri.inspect}" do
+      before :all do
+        @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:url => uri))
+      end
+
+      it_behaves_like 'invalid model'
+
+      it "has a meaningful error message" do
+        expect(@model.errors.on(:url)).to eq [ 'Url has an invalid format' ]
+      end
+    end
+  end
+
+  # http:// throws an exception in Addressable::URI, so it wouldn't make it to the validation part anyway :)
+  (invalid_uris - ['http:// example.com', 'http://']).each do |uri|
+    describe "with dm-type URI of #{uri.inspect}" do
+      before(:all) do
+        @model = DataMapper::Validations::Fixtures::SurrenderBillOfLading.new(valid_attributes.merge(:bank_url => uri))
+      end
+
+      it_behaves_like 'invalid model'
+
+      it "has a meaningful error message" do
+        expect(@model.errors.on(:bank_url)).to eq [ 'Bank url has an invalid format' ]
+      end
+    end
+  end
+
+  [ 'http://apple.com',
+    'http://www.apple.com',
+    "http://apple.com/",
+    "http://apple.com/iphone",
+    "http://www.google.com/search?client=safari&rls=en-us&q=LED&ie=UTF-8&oe=UTF-8",
+    "http://books.google.com",
+    "http://books.google.com/",
+    "http://db2.clouds.megacorp.net:8080",
+    "https://github.com",
+    "https://github.com/",
+    "http://www.example.com:8088/never/ending/path/segments/",
+    "http://db2.clouds.megacorp.net:8080/resources/10",
+    "http://www.example.com:8088/never/ending/path/segments",
+    "http://books.google.com/books?id=uSUJ3VhH4BsC&printsec=frontcover&dq=subject:%22+Linguistics+%22&as_brr=3&ei=DAHPSbGQE5rEzATk1sShAQ&rview=1",
+    "http://books.google.com:80/books?uid=14472359158468915761&rview=1",
+    "http://books.google.com/books?id=Ar3-TXCYXUkC&printsec=frontcover&rview=1",
+    "http://books.google.com/books/vp6ae081e454d30f89b6bca94e0f96fc14.js",
+    "http://www.google.com/images/cleardot.gif",
+    "http://books.google.com:80/books?id=Ar3-TXCYXUkC&printsec=frontcover&rview=1#PPA5,M1",
+    "http://www.hulu.com/watch/64923/terminator-the-sarah-connor-chronicles-to-the-lighthouse",
+    "http://hulu.com:80/browse/popular/tv",
+    "http://www.hulu.com/watch/62475/the-simpsons-gone-maggie-gone#s-p1-so-i0"
+  ].each do |uri|
+   describe "with URL of #{uri.inspect}" do
+     before :all do
+       @model = DataMapper::Validations::Fixtures::BillOfLading.new(valid_attributes.merge(:url => uri))
+     end
+
+      it_behaves_like 'valid model'
+    end
+
+   describe "with dm-type URI of #{uri.inspect}" do
+     before(:all) do
+       @model = DataMapper::Validations::Fixtures::SurrenderBillOfLading.new(valid_attributes.merge(:bank_url => uri))
+     end
+
+      it_behaves_like 'valid model'
+    end
+  end
+end

data/spec/integration/length_validator/default_value_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+require 'integration/length_validator/spec_helper'
+
+describe 'DataMapper::Validations::Fixtures::BoatDock' do
+  before :all do
+    DataMapper::Validations::Fixtures::BoatDock.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::BoatDock.new
+  end
+
+  describe 'with default values that are valid' do
+    it_behaves_like 'valid model'
+  end
+end