sbf-dm-validations 1.3.0.beta

data/spec/integration/automatic_validation/disabling_inferred_validation_spec.rb

@@ -0,0 +1,49 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe "A class with inferred validations disabled for all properties with an option" do
+  before :all do
+    @klass = Class.new do
+      include DataMapper::Resource
+
+      def self.name
+        'InferredValidation'
+      end
+
+      property :id,   DataMapper::Property::Serial,                     :auto_validation => false
+      property :name, String,                        :required => true, :auto_validation => false
+      property :bool, DataMapper::Property::Boolean, :required => true, :auto_validation => false
+    end
+
+    @model = @klass.new
+  end
+
+  describe "when instantiated w/o any attributes" do
+    it_behaves_like 'valid model'
+  end
+end
+
+
+describe "A class with inferred validations disabled for all properties with a block" do
+  before :all do
+    @klass = Class.new do
+      include DataMapper::Resource
+
+      def self.name
+        'InferredValidation'
+      end
+
+      without_auto_validations do
+        property :id,   DataMapper::Property::Serial
+        property :name, String,                        :required => true
+        property :bool, DataMapper::Property::Boolean, :required => true
+      end
+    end
+
+    @model = @klass.new
+  end
+
+  describe "when instantiated w/o any attributes" do
+    it_behaves_like 'valid model'
+  end
+end

data/spec/integration/automatic_validation/inferred_boolean_properties_validation_spec.rb

@@ -0,0 +1,100 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe "A model with a Boolean property" do
+  before :all do
+    @model = HasNullableBoolean.new(:id => 1)
+  end
+
+  describe "assigned a true" do
+    before :all do
+      @model.bool = true
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a false" do
+    before :all do
+      @model.bool = false
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a nil" do
+    before :all do
+      @model.bool = nil
+    end
+
+    it_behaves_like 'valid model'
+  end
+end
+
+describe "A model with a required Boolean property" do
+  before :all do
+    @model = HasRequiredBoolean.new(:id => 1)
+  end
+
+  describe "assigned a true" do
+    before :all do
+      @model.bool = true
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a false" do
+    before :all do
+      @model.bool = false
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a nil" do
+    before :all do
+      @model.bool = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:bool)).to eq [ 'Bool must not be nil' ]
+    end
+  end
+end
+
+describe "A model with a required paranoid Boolean property" do
+  before :all do
+    @model = HasRequiredParanoidBoolean.new(:id => 1)
+  end
+
+  describe "assigned a true" do
+    before :all do
+      @model.bool = true
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a false" do
+    before :all do
+      @model.bool = false
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a nil" do
+    before :all do
+      @model.bool = nil
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:bool)).to eq [ 'Bool must not be nil' ]
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_float_property_validation_spec.rb

@@ -0,0 +1,45 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+
+{ :float => Float, :big_decimal => BigDecimal }.each do |column, type|
+  describe "#{type} property" do
+    before :all do
+      SailBoat.auto_migrate!
+
+      @model = SailBoat.new(:id => 1)
+    end
+
+    describe "with an integer value" do
+      before :all do
+        @model.attributes = {column => 1}
+      end
+
+      it_behaves_like "valid model"
+    end
+
+    describe "with a float value" do
+      before :all do
+        @model.attributes = {column => 1.0}
+      end
+
+      it_behaves_like "valid model"
+    end
+
+    describe "with a BigDecimal value" do
+      before :all do
+        @model.attributes = {column => BigDecimal('1')}
+      end
+
+      it_behaves_like "valid model"
+    end
+
+    describe "with an uncoercible value" do
+      before :all do
+        @model.attributes = {column => "foo"}
+      end
+
+      it_behaves_like "invalid model"
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_format_validation_spec.rb

@@ -0,0 +1,35 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'SailBoat', "with a :format option on a property" do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model = SailBoat.new
+    expect(@model).to be_valid_for_format_test
+  end
+
+  describe "and value that matches the format" do
+    before :all do
+      @model.code = 'A1234'
+    end
+
+    it "passes inferred format validation" do
+      expect(@model).to be_valid_for_format_test
+    end
+  end
+
+  describe "and value that DOES NOT match the format" do
+    before :all do
+      @model.code = 'BAD CODE'
+    end
+
+    it "does not pass inferred format validation" do
+      expect(@model).not_to be_valid_for_format_test
+    end
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:code)).to eq [ 'Code has an invalid format' ]
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_integer_properties_validation_spec.rb

@@ -0,0 +1,70 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe "A model with an Integer property" do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model = SailBoat.new
+  end
+
+  # success case
+  describe "assigned to an integer" do
+    before :all do
+      @model.id = 1
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a value coercible into an integer" do
+    before :all do
+      @model.id = 1.0
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "assigned a value not coercible into an integer" do
+    before :all do
+      @model.id = "foo"
+    end
+
+    it "is invalid" do
+      expect(@model).not_to be_valid
+    end
+
+    it "has a meaningful default error message" do
+      expect(@model.errors.on(:id)).to eq [ 'Id must be an integer' ]
+    end
+  end
+
+  describe "assigned to a too-small integer" do
+    before :all do
+      @model.id = 0
+    end
+
+    it "is invalid" do
+      expect(@model).not_to be_valid
+    end
+
+    it "has a meaningful default error message" do
+      expect(@model.errors.on(:id)).to eq [ 'Id must be greater than or equal to 1' ]
+    end
+  end
+
+  describe "assigned to a too-large integer" do
+    before :all do
+      @model.id = 11
+    end
+
+    it "is invalid" do
+      expect(@model).not_to be_valid
+    end
+
+    it "has a meaningful default error message" do
+      expect(@model.errors.on(:id)).to eq [ 'Id must be less than or equal to 10' ]
+    end
+  end
+
+end

data/spec/integration/automatic_validation/inferred_length_validation_spec.rb

@@ -0,0 +1,142 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'SailBoat' do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model      = SailBoat.new(:id => 1)
+    expect(@model).to be_valid_for_length_test_1
+  end
+
+
+  describe "with a nil value on property that allows nil" do
+    before :all do
+      @model.allow_nil = nil
+    end
+
+    it "is valid" do
+      expect(@model).to be_valid_for_nil_test
+    end
+  end
+
+
+  describe "with 11 characters long description" do
+    before :all do
+      @model.description = 'ABCDEFGHIJK' #11
+    end
+
+    # validates_length_of is inferred from property's :length option
+    it "is invalid" do
+      expect(@model).not_to be_valid_for_length_test_1
+      expect(@model.errors.on(:description)).to eq [ 'Description must be at most 10 characters long' ]
+    end
+  end
+
+
+  describe "with 9 characters long description" do
+    before :all do
+      @model.description = 'ABCDEFGHI' # 9
+    end
+
+    # validates_length_of is inferred from property's :length option
+    it_behaves_like 'valid model'
+  end
+
+  describe "with 2 character long note" do
+    before :all do
+      @model = SailBoat.new(:notes => "AB")
+    end
+
+    it "is valid" do
+      expect(@model).to be_valid_for_length_test_2
+    end
+  end
+
+  describe "with 10 character long note" do
+    before :all do
+      @model = SailBoat.new(:notes => "ABCDEFGHIJ")
+    end
+
+    it "is valid" do
+      expect(@model).to be_valid_for_length_test_2
+    end
+  end
+
+  describe "with 11 character long note" do
+    before :all do
+      @model = SailBoat.new(:notes => "ABCDEFGHIJK")
+    end
+
+    it "is invalid" do
+      expect(@model).not_to be_valid_for_length_test_2
+    end
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:notes)).to eq [ 'Notes must be between 2 and 10 characters long' ]
+    end
+  end
+end
+
+
+
+describe 'DataMapper::Validations::Fixtures::SmsMessage' do
+  before :all do
+    DataMapper::Validations::Fixtures::SmsMessage.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::SmsMessage.new(:id => 10)
+  end
+
+  describe "with 2 character long note" do
+    before :all do
+      @model.body = "ab"
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "with 10 character long note" do
+    before :all do
+      @model.body = "ABCDEFGHIJ"
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "with 499 character long note" do
+    before :all do
+      @model.body = "a" * 499
+    end
+
+    it_behaves_like 'valid model'
+  end
+
+  describe "with 503 character long note" do
+    before :all do
+      @model.body = "a" * 503
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:body)).to eq [ 'Body must be between 1 and 500 characters long' ]
+    end
+  end
+
+  describe 'with an infinitely long note' do
+    before do
+      @original = @model.class.properties[:body]
+    end
+
+    after do
+      @model.class.property(@original.name, @original.class, @original.options)
+    end
+
+    it "raises when trying to set the upper bound of a property length range to Infinity" do
+      expected_msg = 'Infinity is not a valid upper bound for a length range'
+      expect {
+        @model.class.property :body, String, :length => (1..1.0/0)
+      }.to raise_error(ArgumentError, expected_msg)
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_presence_validation_spec.rb

@@ -0,0 +1,45 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'SailBoat' do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model      = SailBoat.new(:id => 1)
+    @model.name = 'Float'
+    expect(@model).to be_valid_for_presence_test
+  end
+
+  describe "without name" do
+    before :all do
+      @model.name = nil
+    end
+
+    # has validates_is_present for name thanks to :required => true
+    it "is invalid" do
+      expect(@model).not_to be_valid_for_presence_test
+      expect(@model.errors.on(:name)).to eq [ 'Name must not be blank' ]
+    end
+  end
+end
+
+
+
+describe 'SailBoat' do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model      = SailBoat.new(:id => 1)
+    @model.name = 'Float'
+    expect(@model).to be_valid_for_presence_test
+  end
+
+  describe "with a name" do
+    before :all do
+      # no op
+    end
+
+    # has validates_is_present for name thanks to :required => true
+    it_behaves_like 'valid model'
+  end
+end

data/spec/integration/automatic_validation/inferred_primitive_validation_spec.rb

@@ -0,0 +1,22 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'SailBoat' do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model = SailBoat.new(:id => 1)
+    expect(@model).to be_valid_for_primitive_test
+  end
+
+  describe "with invlid value assigned to primitive column" do
+    before :all do
+      @model.build_date = 'ABC'
+    end
+
+    it "is invalid" do
+      expect(@model).not_to be_valid_for_primitive_test
+      expect(@model.errors.on(:build_date)).to eq [ 'Build date must be of type Date' ]
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_uniqueness_validation_spec.rb

@@ -0,0 +1,48 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'uniqueness' do
+  describe 'single attribute' do
+    before :all do
+      class UniqueEventsSingle
+        include DataMapper::Resource
+
+        # storage_names[:default] = 'unique_events_single'
+
+        property :id,         Integer, :key => true
+        property :start_year, Integer, :unique => true
+      end
+      UniqueEventsSingle.auto_migrate!
+
+      @existing = UniqueEventsSingle.create(:id => 1, :start_year => 2008)
+      @new = UniqueEventsSingle.new(:id => 2, :start_year => 2008)
+    end
+
+    it 'validates' do
+      expect(@new).not_to be_valid
+    end
+  end
+
+  describe 'multiple attributes' do
+    before :all do
+      class UniqueEventsMultiple
+        include DataMapper::Resource
+
+        # storage_names[:default] = 'unique_events_multiple'
+
+        property :id, Integer, :key => true
+        property :start_year, Integer, :unique => :years
+        property :stop_year,  Integer, :unique => :years
+      end
+      UniqueEventsMultiple.auto_migrate!
+
+      @new = UniqueEventsMultiple.new(:id => 1, :start_year => 2008, :stop_year => 2009)
+    end
+
+    it 'validates uniquness' do
+      expect {
+        expect(@new).not_to be_valid
+      }.to raise_error(ArgumentError)
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_within_validation_spec.rb

@@ -0,0 +1,35 @@
+require_relative '../../spec_helper'
+require_relative 'spec_helper'
+
+describe 'A model with a :set & :default options on a property' do
+  before :all do
+    class ::LimitedBoat
+      include DataMapper::Resource
+      property :id,      DataMapper::Property::Serial
+      property :limited, String, :set => %w[ foo bar bang ], :default => 'foo'
+    end
+
+    LimitedBoat.finalize
+  end
+
+  describe "without value on that property" do
+    before :all do
+      @model = LimitedBoat.new
+    end
+
+    # default value is respected
+    it_behaves_like 'valid model'
+  end
+
+  describe "without value on that property that is not in allowed range/set" do
+    before :all do
+      @model = LimitedBoat.new(:limited => "blah")
+    end
+
+    it_behaves_like 'invalid model'
+
+    it "has a meaningful error message" do
+      expect(@model.errors.on(:limited)).to eq [ 'Limited must be one of foo, bar, bang' ]
+    end
+  end
+end

data/spec/integration/automatic_validation/spec_helper.rb

@@ -0,0 +1,57 @@
+# put validator specific fixture models and helpers here
+#
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite
+
+# TODO: one day we need to get rid of this remaining foobarness
+# and use a few more realistic models with ParanoidBoolean and all
+# that
+
+class SailBoat
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,            Integer,    :key => true, :min => 1, :max => 10
+
+  property :name,          String,                                :required => true,     :validates       => :presence_test
+  property :description,   String,     :length => 10,                                     :validates       => :length_test_1
+  property :notes,         String,     :length => 2..10,                                  :validates       => :length_test_2
+  property :no_validation, String,                                                        :auto_validation => false
+  property :salesman,      String,                                :required => true,     :validates       => [:multi_context_1, :multi_context_2]
+  property :code,          String,     :format => Proc.new { |code| code =~ /A\d{4}\z/ }, :validates       => :format_test
+  property :allow_nil,     String,     :length => 5..10,          :required => false,      :validates       => :nil_test
+  property :build_date,    Date,                                                          :validates       => :primitive_test
+  property :float,         Float,      :precision => 2, :scale => 1
+  property :big_decimal,   Decimal, :precision => 2, :scale => 1
+end
+
+class HasNullableBoolean
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,   Integer, :key => true
+  property :bool, Boolean # :required => false by default
+end
+
+class HasRequiredBoolean
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,   Integer, :key => true
+  property :bool, Boolean, :required => true
+end
+
+class HasRequiredParanoidBoolean
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,   Integer,         :key => true
+  property :bool, ParanoidBoolean, :required => true
+end

data/spec/integration/block_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite