rugged 1.3.1 → 1.9.0

data/vendor/libgit2/src/{iterator.c → libgit2/iterator.c}

@@ -9,6 +9,7 @@
 
 #include "tree.h"
 #include "index.h"
+#include "path.h"
 
 #define GIT_ITERATOR_FIRST_ACCESS   (1 << 15)
 #define GIT_ITERATOR_HONOR_IGNORES  (1 << 16)
@@ -25,9 +26,10 @@
 #define iterator__ignore_dot_git(I)    iterator__flag(I,IGNORE_DOT_GIT)
 #define iterator__descend_symlinks(I)  iterator__flag(I,DESCEND_SYMLINKS)
 
-
 static void iterator_set_ignore_case(git_iterator *iter, bool ignore_case)
 {
+	int (*vector_cmp)(const void *a, const void *b);
+
 	if (ignore_case)
 		iter->flags |= GIT_ITERATOR_IGNORE_CASE;
 	else
@@ -38,7 +40,9 @@ static void iterator_set_ignore_case(git_iterator *iter, bool ignore_case)
 	iter->prefixcomp = ignore_case ? git__prefixcmp_icase : git__prefixcmp;
 	iter->entry_srch = ignore_case ? git_index_entry_isrch : git_index_entry_srch;
 
-	git_vector_set_cmp(&iter->pathlist, (git_vector_cmp)iter->strcomp);
+	vector_cmp = ignore_case ? git__strcasecmp_cb : git__strcmp_cb;
+
+	git_vector_set_cmp(&iter->pathlist, vector_cmp);
 }
 
 static int iterator_range_init(
@@ -292,12 +296,13 @@ typedef enum {
 	ITERATOR_PATHLIST_IS_FILE = 1,
 	ITERATOR_PATHLIST_IS_DIR = 2,
 	ITERATOR_PATHLIST_IS_PARENT = 3,
-	ITERATOR_PATHLIST_FULL = 4,
+	ITERATOR_PATHLIST_FULL = 4
 } iterator_pathlist_search_t;
 
 static iterator_pathlist_search_t iterator_pathlist_search(
 	git_iterator *iter, const char *path, size_t path_len)
 {
+	int (*vector_cmp)(const void *a, const void *b);
 	const char *p;
 	size_t idx;
 	int error;
@@ -307,8 +312,10 @@ static iterator_pathlist_search_t iterator_pathlist_search(
 
 	git_vector_sort(&iter->pathlist);
 
-	error = git_vector_bsearch2(&idx, &iter->pathlist,
-		(git_vector_cmp)iter->strcomp, path);
+	vector_cmp = (iter->flags & GIT_ITERATOR_IGNORE_CASE) != 0 ?
+		git__strcasecmp_cb : git__strcmp_cb;
+
+	error = git_vector_bsearch2(&idx, &iter->pathlist, vector_cmp, path);
 
 	/* the given path was found in the pathlist.  since the pathlist only
 	 * matches directories when they're suffixed with a '/', analyze the
@@ -424,7 +431,7 @@ typedef struct {
 	git_tree *tree;
 
 	/* path to this particular frame (folder) */
-	git_buf path;
+	git_str path;
 
 	/* a sorted list of the entries for this frame (folder), these are
 	 * actually pointers to the iterator's entry pool.
@@ -441,7 +448,7 @@ typedef struct {
 	 * parent path.
 	 */
 	git_vector similar_trees;
-	git_array_t(git_buf) similar_paths;
+	git_array_t(git_str) similar_paths;
 } tree_iterator_frame;
 
 typedef struct {
@@ -450,7 +457,7 @@ typedef struct {
 	git_array_t(tree_iterator_frame) frames;
 
 	git_index_entry entry;
-	git_buf entry_path;
+	git_str entry_path;
 
 	/* a pool of entries to reduce the number of allocations */
 	git_pool entry_pool;
@@ -472,7 +479,7 @@ GIT_INLINE(tree_iterator_frame *) tree_iterator_current_frame(
 GIT_INLINE(int) tree_entry_cmp(
 	const git_tree_entry *a, const git_tree_entry *b, bool icase)
 {
-	return git_path_cmp(
+	return git_fs_path_cmp(
 		a->filename, a->filename_len, a->attr == GIT_FILEMODE_TREE,
 		b->filename, b->filename_len, b->attr == GIT_FILEMODE_TREE,
 		icase ? git__strncasecmp : git__strncmp);
@@ -508,20 +515,20 @@ static int tree_iterator_entry_sort_icase(const void *ptr_a, const void *ptr_b)
 }
 
 static int tree_iterator_compute_path(
-	git_buf *out,
+	git_str *out,
 	tree_iterator_entry *entry)
 {
-	git_buf_clear(out);
+	git_str_clear(out);
 
 	if (entry->parent_path)
-		git_buf_joinpath(out, entry->parent_path, entry->tree_entry->filename);
+		git_str_joinpath(out, entry->parent_path, entry->tree_entry->filename);
 	else
-		git_buf_puts(out, entry->tree_entry->filename);
+		git_str_puts(out, entry->tree_entry->filename);
 
 	if (git_tree_entry__is_tree(entry->tree_entry))
-		git_buf_putc(out, '/');
+		git_str_putc(out, '/');
 
-	if (git_buf_oom(out))
+	if (git_str_oom(out))
 		return -1;
 
 	return 0;
@@ -601,7 +608,7 @@ GIT_INLINE(int) tree_iterator_frame_push_neighbors(
 	tree_iterator_entry *entry, *new_entry;
 	git_tree *tree = NULL;
 	git_tree_entry *tree_entry;
-	git_buf *path;
+	git_str *path;
 	size_t new_size, i;
 	int error = 0;
 
@@ -612,7 +619,7 @@ GIT_INLINE(int) tree_iterator_frame_push_neighbors(
 			break;
 
 		if ((error = git_tree_lookup(&tree,
-			iter->base.repo, entry->tree_entry->oid)) < 0)
+			iter->base.repo, &entry->tree_entry->oid)) < 0)
 			break;
 
 		if (git_vector_insert(&parent_frame->similar_trees, tree) < 0)
@@ -621,7 +628,7 @@ GIT_INLINE(int) tree_iterator_frame_push_neighbors(
 		path = git_array_alloc(parent_frame->similar_paths);
 		GIT_ERROR_CHECK_ALLOC(path);
 
-		memset(path, 0, sizeof(git_buf));
+		memset(path, 0, sizeof(git_str));
 
 		if ((error = tree_iterator_compute_path(path, entry)) < 0)
 			break;
@@ -658,7 +665,7 @@ GIT_INLINE(int) tree_iterator_frame_push(
 	int error;
 
 	if ((error = git_tree_lookup(&tree,
-			iter->base.repo, entry->tree_entry->oid)) < 0 ||
+			iter->base.repo, &entry->tree_entry->oid)) < 0 ||
 		(error = tree_iterator_frame_init(iter, tree, entry)) < 0)
 		goto done;
 
@@ -681,7 +688,7 @@ done:
 static int tree_iterator_frame_pop(tree_iterator *iter)
 {
 	tree_iterator_frame *frame;
-	git_buf *buf = NULL;
+	git_str *buf = NULL;
 	git_tree *tree;
 	size_t i;
 
@@ -689,12 +696,12 @@ static int tree_iterator_frame_pop(tree_iterator *iter)
 
 	frame = git_array_pop(iter->frames);
 
-	git_vector_free(&frame->entries);
+	git_vector_dispose(&frame->entries);
 	git_tree_free(frame->tree);
 
 	do {
 		buf = git_array_pop(frame->similar_paths);
-		git_buf_dispose(buf);
+		git_str_dispose(buf);
 	} while (buf != NULL);
 
 	git_array_clear(frame->similar_paths);
@@ -702,9 +709,9 @@ static int tree_iterator_frame_pop(tree_iterator *iter)
 	git_vector_foreach(&frame->similar_trees, i, tree)
 		git_tree_free(tree);
 
-	git_vector_free(&frame->similar_trees);
+	git_vector_dispose(&frame->similar_trees);
 
-	git_buf_dispose(&frame->path);
+	git_str_dispose(&frame->path);
 
 	return 0;
 }
@@ -739,7 +746,7 @@ static void tree_iterator_set_current(
 
 	iter->entry.mode = tree_entry->attr;
 	iter->entry.path = iter->entry_path.ptr;
-	git_oid_cpy(&iter->entry.id, tree_entry->oid);
+	git_oid_cpy(&iter->entry.id, &tree_entry->oid);
 }
 
 static int tree_iterator_advance(const git_index_entry **out, git_iterator *i)
@@ -892,7 +899,7 @@ static void tree_iterator_clear(tree_iterator *iter)
 	git_array_clear(iter->frames);
 
 	git_pool_clear(&iter->entry_pool);
-	git_buf_clear(&iter->entry_path);
+	git_str_clear(&iter->entry_path);
 
 	iterator_clear(&iter->base);
 }
@@ -925,7 +932,7 @@ static void tree_iterator_free(git_iterator *i)
 	tree_iterator_clear(iter);
 
 	git_tree_free(iter->root);
-	git_buf_dispose(&iter->entry_path);
+	git_str_dispose(&iter->entry_path);
 }
 
 int git_iterator_for_tree(
@@ -1035,16 +1042,18 @@ typedef struct {
 	git_index *index;
 	git_vector index_snapshot;
 
+	git_oid_t oid_type;
+
 	git_array_t(filesystem_iterator_frame) frames;
 	git_ignores ignores;
 
 	/* info about the current entry */
 	git_index_entry entry;
-	git_buf current_path;
+	git_str current_path;
 	int current_is_ignored;
 
 	/* temporary buffer for advance_over */
-	git_buf tmp_buf;
+	git_str tmp_buf;
 } filesystem_iterator;
 
 
@@ -1266,11 +1275,11 @@ static int filesystem_iterator_entry_hash(
 	filesystem_iterator *iter,
 	filesystem_iterator_entry *entry)
 {
-	git_buf fullpath = GIT_BUF_INIT;
+	git_str fullpath = GIT_STR_INIT;
 	int error;
 
 	if (S_ISDIR(entry->st.st_mode)) {
-		memset(&entry->id, 0, GIT_OID_RAWSZ);
+		memset(&entry->id, 0, git_oid_size(iter->oid_type));
 		return 0;
 	}
 
@@ -1278,11 +1287,11 @@ static int filesystem_iterator_entry_hash(
 		return git_repository_hashfile(&entry->id,
 			iter->base.repo, entry->path, GIT_OBJECT_BLOB, NULL);
 
-	if (!(error = git_buf_joinpath(&fullpath, iter->root, entry->path)) &&
-	    !(error = git_path_validate_workdir_buf(iter->base.repo, &fullpath)))
-		error = git_odb_hashfile(&entry->id, fullpath.ptr, GIT_OBJECT_BLOB);
+	if (!(error = git_str_joinpath(&fullpath, iter->root, entry->path)) &&
+	    !(error = git_path_validate_str_length(iter->base.repo, &fullpath)))
+		error = git_odb__hashfile(&entry->id, fullpath.ptr, GIT_OBJECT_BLOB, iter->oid_type);
 
-	git_buf_dispose(&fullpath);
+	git_str_dispose(&fullpath);
 	return error;
 }
 
@@ -1336,8 +1345,8 @@ static int filesystem_iterator_frame_push(
 	filesystem_iterator_entry *frame_entry)
 {
 	filesystem_iterator_frame *new_frame = NULL;
-	git_path_diriter diriter = GIT_PATH_DIRITER_INIT;
-	git_buf root = GIT_BUF_INIT;
+	git_fs_path_diriter diriter = GIT_FS_PATH_DIRITER_INIT;
+	git_str root = GIT_STR_INIT;
 	const char *path;
 	filesystem_iterator_entry *entry;
 	struct stat statbuf;
@@ -1356,12 +1365,12 @@ static int filesystem_iterator_frame_push(
 	memset(new_frame, 0, sizeof(filesystem_iterator_frame));
 
 	if (frame_entry)
-		git_buf_joinpath(&root, iter->root, frame_entry->path);
+		git_str_joinpath(&root, iter->root, frame_entry->path);
 	else
-		git_buf_puts(&root, iter->root);
+		git_str_puts(&root, iter->root);
 
-	if (git_buf_oom(&root) ||
-	    git_path_validate_workdir_buf(iter->base.repo, &root) < 0) {
+	if (git_str_oom(&root) ||
+	    git_path_validate_str_length(iter->base.repo, &root) < 0) {
 		error = -1;
 		goto done;
 	}
@@ -1369,7 +1378,7 @@ static int filesystem_iterator_frame_push(
 	new_frame->path_len = frame_entry ? frame_entry->path_len : 0;
 
 	/* Any error here is equivalent to the dir not existing, skip over it */
-	if ((error = git_path_diriter_init(
+	if ((error = git_fs_path_diriter_init(
 			&diriter, root.ptr, iter->dirload_flags)) < 0) {
 		error = GIT_ENOTFOUND;
 		goto done;
@@ -1387,12 +1396,18 @@ static int filesystem_iterator_frame_push(
 	/* check if this directory is ignored */
 	filesystem_iterator_frame_push_ignores(iter, frame_entry, new_frame);
 
-	while ((error = git_path_diriter_next(&diriter)) == 0) {
+	while ((error = git_fs_path_diriter_next(&diriter)) == 0) {
 		iterator_pathlist_search_t pathlist_match = ITERATOR_PATHLIST_FULL;
+		git_str path_str = GIT_STR_INIT;
 		bool dir_expected = false;
 
-		if ((error = git_path_diriter_fullpath(&path, &path_len, &diriter)) < 0 ||
-		    (error = git_path_validate_workdir_with_len(iter->base.repo, path, path_len)) < 0)
+		if ((error = git_fs_path_diriter_fullpath(&path, &path_len, &diriter)) < 0)
+			goto done;
+
+		path_str.ptr = (char *)path;
+		path_str.size = path_len;
+
+		if ((error = git_path_validate_str_length(iter->base.repo, &path_str)) < 0)
 			goto done;
 
 		GIT_ASSERT(path_len > iter->root_len);
@@ -1414,7 +1429,7 @@ static int filesystem_iterator_frame_push(
 		 * we have an index, we can just copy the data out of it.
 		 */
 
-		if ((error = git_path_diriter_stat(&statbuf, &diriter)) < 0) {
+		if ((error = git_fs_path_diriter_stat(&statbuf, &diriter)) < 0) {
 			/* file was removed between readdir and lstat */
 			if (error == GIT_ENOTFOUND)
 				continue;
@@ -1471,8 +1486,8 @@ done:
 	if (error < 0)
 		git_array_pop(iter->frames);
 
-	git_buf_dispose(&root);
-	git_path_diriter_free(&diriter);
+	git_str_dispose(&root);
+	git_fs_path_diriter_free(&diriter);
 	return error;
 }
 
@@ -1486,7 +1501,7 @@ GIT_INLINE(int) filesystem_iterator_frame_pop(filesystem_iterator *iter)
 	filesystem_iterator_frame_pop_ignores(iter);
 
 	git_pool_clear(&frame->entry_pool);
-	git_vector_free(&frame->entries);
+	git_vector_dispose(&frame->entries);
 
 	return 0;
 }
@@ -1522,6 +1537,8 @@ static void filesystem_iterator_set_current(
 
 	if (iter->base.flags & GIT_ITERATOR_INCLUDE_HASH)
 		git_oid_cpy(&iter->entry.id, &entry->id);
+	else
+		git_oid_clear(&iter->entry.id, iter->oid_type);
 
 	iter->entry.path = entry->path;
 
@@ -1551,7 +1568,7 @@ static int filesystem_iterator_is_dir(
 	const filesystem_iterator_entry *entry)
 {
 	struct stat st;
-	git_buf fullpath = GIT_BUF_INIT;
+	git_str fullpath = GIT_STR_INIT;
 	int error = 0;
 
 	if (S_ISDIR(entry->st.st_mode)) {
@@ -1564,15 +1581,15 @@ static int filesystem_iterator_is_dir(
 		goto done;
 	}
 
-	if ((error = git_buf_joinpath(&fullpath, iter->root, entry->path)) < 0 ||
-	    (error = git_path_validate_workdir_buf(iter->base.repo, &fullpath)) < 0 ||
+	if ((error = git_str_joinpath(&fullpath, iter->root, entry->path)) < 0 ||
+	    (error = git_path_validate_str_length(iter->base.repo, &fullpath)) < 0 ||
 	    (error = p_stat(fullpath.ptr, &st)) < 0)
 		goto done;
 
 	*is_dir = S_ISDIR(st.st_mode);
 
 done:
-	git_buf_dispose(&fullpath);
+	git_str_dispose(&fullpath);
 	return error;
 }
 
@@ -1673,7 +1690,7 @@ static int filesystem_iterator_advance_into(
 	return filesystem_iterator_advance(out, i);
 }
 
-int git_iterator_current_workdir_path(git_buf **out, git_iterator *i)
+int git_iterator_current_workdir_path(git_str **out, git_iterator *i)
 {
 	filesystem_iterator *iter = GIT_CONTAINER_OF(i, filesystem_iterator, base);
 	const git_index_entry *entry;
@@ -1684,10 +1701,10 @@ int git_iterator_current_workdir_path(git_buf **out, git_iterator *i)
 		return 0;
 	}
 
-	git_buf_truncate(&iter->current_path, iter->root_len);
+	git_str_truncate(&iter->current_path, iter->root_len);
 
 	if (git_iterator_current(&entry, i) < 0 ||
-		git_buf_puts(&iter->current_path, entry->path) < 0)
+		git_str_puts(&iter->current_path, entry->path) < 0)
 		return -1;
 
 	*out = &iter->current_path;
@@ -1790,8 +1807,8 @@ static int filesystem_iterator_advance_over(
 		return filesystem_iterator_advance(out, i);
 	}
 
-	git_buf_clear(&iter->tmp_buf);
-	if ((error = git_buf_puts(&iter->tmp_buf, entry->path)) < 0)
+	git_str_clear(&iter->tmp_buf);
+	if ((error = git_str_puts(&iter->tmp_buf, entry->path)) < 0)
 		return error;
 
 	base = iter->tmp_buf.ptr;
@@ -1858,7 +1875,7 @@ static void filesystem_iterator_clear(filesystem_iterator *iter)
 	git_array_clear(iter->frames);
 	git_ignore__free(&iter->ignores);
 
-	git_buf_dispose(&iter->tmp_buf);
+	git_str_dispose(&iter->tmp_buf);
 
 	iterator_clear(&iter->base);
 }
@@ -1892,7 +1909,7 @@ static void filesystem_iterator_free(git_iterator *i)
 {
 	filesystem_iterator *iter = GIT_CONTAINER_OF(i, filesystem_iterator, base);
 	git__free(iter->root);
-	git_buf_dispose(&iter->current_path);
+	git_str_dispose(&iter->current_path);
 	git_tree_free(iter->tree);
 	if (iter->index)
 		git_index_snapshot_release(&iter->index_snapshot, iter->index);
@@ -1946,7 +1963,7 @@ static int iterator_for_filesystem(
 	iter->root[root_len] = '\0';
 	iter->root_len = root_len;
 
-	if ((error = git_buf_puts(&iter->current_path, iter->root)) < 0)
+	if ((error = git_str_puts(&iter->current_path, iter->root)) < 0)
 		goto on_error;
 
 	if ((error = iterator_init_common(&iter->base, repo, index, options)) < 0)
@@ -1961,9 +1978,12 @@ static int iterator_for_filesystem(
 
 	iter->index = index;
 	iter->dirload_flags =
-		(iterator__ignore_case(&iter->base) ? GIT_PATH_DIR_IGNORE_CASE : 0) |
+		(iterator__ignore_case(&iter->base) ?
+			GIT_FS_PATH_DIR_IGNORE_CASE : 0) |
 		(iterator__flag(&iter->base, PRECOMPOSE_UNICODE) ?
-			 GIT_PATH_DIR_PRECOMPOSE_UNICODE : 0);
+			GIT_FS_PATH_DIR_PRECOMPOSE_UNICODE : 0);
+
+	iter->oid_type = options->oid_type;
 
 	if ((error = filesystem_iterator_init(iter)) < 0)
 		goto on_error;
@@ -1979,10 +1999,15 @@ on_error:
 int git_iterator_for_filesystem(
 	git_iterator **out,
 	const char *root,
-	git_iterator_options *options)
+	git_iterator_options *given_opts)
 {
+	git_iterator_options options = GIT_ITERATOR_OPTIONS_INIT;
+
+	if (given_opts)
+		memcpy(&options, given_opts, sizeof(git_iterator_options));
+
 	return iterator_for_filesystem(out,
-		NULL, root, NULL, NULL, GIT_ITERATOR_FS, options);
+		NULL, root, NULL, NULL, GIT_ITERATOR_FS, &options);
 }
 
 int git_iterator_for_workdir_ext(
@@ -2009,6 +2034,12 @@ int git_iterator_for_workdir_ext(
 	options.flags |= GIT_ITERATOR_HONOR_IGNORES |
 		GIT_ITERATOR_IGNORE_DOT_GIT;
 
+	if (!options.oid_type)
+		options.oid_type = repo->oid_type;
+	else if (options.oid_type != repo->oid_type)
+		git_error_set(GIT_ERROR_INVALID,
+			"specified object ID type does not match repository object ID type");
+
 	return iterator_for_filesystem(out,
 		repo, repo_workdir, index, tree, GIT_ITERATOR_WORKDIR, &options);
 }
@@ -2024,7 +2055,7 @@ typedef struct {
 
 	/* the pseudotree entry */
 	git_index_entry tree_entry;
-	git_buf tree_buf;
+	git_str tree_buf;
 	bool skip_tree;
 
 	const git_index_entry *entry;
@@ -2058,14 +2089,14 @@ static bool index_iterator_create_pseudotree(
 	prev_path = iter->entry ? iter->entry->path : "";
 
 	/* determine if the new path is in a different directory from the old */
-	common_len = git_path_common_dirlen(prev_path, path);
+	common_len = git_fs_path_common_dirlen(prev_path, path);
 	relative_path = path + common_len;
 
 	if ((dirsep = strchr(relative_path, '/')) == NULL)
 		return false;
 
-	git_buf_clear(&iter->tree_buf);
-	git_buf_put(&iter->tree_buf, path, (dirsep - path) + 1);
+	git_str_clear(&iter->tree_buf);
+	git_str_put(&iter->tree_buf, path, (dirsep - path) + 1);
 
 	iter->tree_entry.mode = GIT_FILEMODE_TREE;
 	iter->tree_entry.path = iter->tree_buf.ptr;
@@ -2230,7 +2261,7 @@ static void index_iterator_free(git_iterator *i)
 	index_iterator *iter = GIT_CONTAINER_OF(i, index_iterator, base);
 
 	git_index_snapshot_release(&iter->entries, iter->base.index);
-	git_buf_dispose(&iter->tree_buf);
+	git_str_dispose(&iter->tree_buf);
 }
 
 int git_iterator_for_index(
@@ -2305,7 +2336,7 @@ void git_iterator_free(git_iterator *iter)
 
 	iter->cb->free(iter);
 
-	git_vector_free(&iter->pathlist);
+	git_vector_dispose(&iter->pathlist);
 	git__free(iter->start);
 	git__free(iter->end);
 

data/vendor/libgit2/src/{iterator.h → libgit2/iterator.h}

@@ -11,7 +11,7 @@
 
 #include "git2/index.h"
 #include "vector.h"
-#include "buffer.h"
+#include "str.h"
 #include "ignore.h"
 
 typedef struct git_iterator git_iterator;
@@ -21,7 +21,7 @@ typedef enum {
 	GIT_ITERATOR_TREE = 1,
 	GIT_ITERATOR_INDEX = 2,
 	GIT_ITERATOR_WORKDIR = 3,
-	GIT_ITERATOR_FS = 4,
+	GIT_ITERATOR_FS = 4
 } git_iterator_t;
 
 typedef enum {
@@ -42,7 +42,7 @@ typedef enum {
 	/** descend into symlinked directories */
 	GIT_ITERATOR_DESCEND_SYMLINKS = (1u << 7),
 	/** hash files in workdir or filesystem iterators */
-	GIT_ITERATOR_INCLUDE_HASH = (1u << 8),
+	GIT_ITERATOR_INCLUDE_HASH = (1u << 8)
 } git_iterator_flag_t;
 
 typedef enum {
@@ -63,6 +63,9 @@ typedef struct {
 
 	/* flags, from above */
 	unsigned int flags;
+
+	/* oid type - necessary for non-workdir filesystem iterators */
+	git_oid_t oid_type;
 } git_iterator_options;
 
 #define GIT_ITERATOR_OPTIONS_INIT {0}
@@ -278,11 +281,11 @@ extern bool git_iterator_current_tree_is_ignored(git_iterator *iter);
 
 /**
  * Get full path of the current item from a workdir iterator.  This will
- * return NULL for a non-workdir iterator.  The git_buf is still owned by
+ * return NULL for a non-workdir iterator.  The git_str is still owned by
  * the iterator; this is exposed just for efficiency.
  */
 extern int git_iterator_current_workdir_path(
-	git_buf **path, git_iterator *iter);
+	git_str **path, git_iterator *iter);
 
 /**
  * Retrieve the index stored in the iterator.