rugged 1.3.1 → 1.9.0

data/vendor/libgit2/src/{diff_print.c → libgit2/diff_print.c}

@@ -7,6 +7,7 @@
 
 #include "common.h"
 
+#include "buf.h"
 #include "diff.h"
 #include "diff_file.h"
 #include "patch_generate.h"
@@ -14,6 +15,7 @@
 #include "zstream.h"
 #include "blob.h"
 #include "delta.h"
+#include "repository.h"
 #include "git2/sys/diff.h"
 
 typedef struct {
@@ -21,20 +23,22 @@ typedef struct {
 	git_diff_line_cb print_cb;
 	void *payload;
 
-	git_buf *buf;
+	git_str *buf;
 	git_diff_line line;
 
 	const char *old_prefix;
 	const char *new_prefix;
 	uint32_t flags;
 	int id_strlen;
+	unsigned int sent_file_header;
+	git_oid_t oid_type;
 
 	int (*strcomp)(const char *, const char *);
 } diff_print_info;
 
 static int diff_print_info_init__common(
 	diff_print_info *pi,
-	git_buf *out,
+	git_str *out,
 	git_repository *repo,
 	git_diff_format_t format,
 	git_diff_line_cb cb,
@@ -45,16 +49,15 @@ static int diff_print_info_init__common(
 	pi->payload = payload;
 	pi->buf = out;
 
+	GIT_ASSERT(pi->oid_type);
+
 	if (!pi->id_strlen) {
 		if (!repo)
 			pi->id_strlen = GIT_ABBREV_DEFAULT;
-		else if (git_repository__configmap_lookup(&pi->id_strlen, repo, GIT_CONFIGMAP_ABBREV) < 0)
+		else if (git_repository__abbrev_length(&pi->id_strlen, repo) < 0)
 			return -1;
 	}
 
-	if (pi->id_strlen > GIT_OID_HEXSZ)
-		pi->id_strlen = GIT_OID_HEXSZ;
-
 	memset(&pi->line, 0, sizeof(pi->line));
 	pi->line.old_lineno = -1;
 	pi->line.new_lineno = -1;
@@ -65,7 +68,7 @@ static int diff_print_info_init__common(
 
 static int diff_print_info_init_fromdiff(
 	diff_print_info *pi,
-	git_buf *out,
+	git_str *out,
 	git_diff *diff,
 	git_diff_format_t format,
 	git_diff_line_cb cb,
@@ -77,6 +80,7 @@ static int diff_print_info_init_fromdiff(
 
 	if (diff) {
 		pi->flags = diff->opts.flags;
+		pi->oid_type = diff->opts.oid_type;
 		pi->id_strlen = diff->opts.id_abbrev;
 		pi->old_prefix = diff->opts.old_prefix;
 		pi->new_prefix = diff->opts.new_prefix;
@@ -89,7 +93,7 @@ static int diff_print_info_init_fromdiff(
 
 static int diff_print_info_init_frompatch(
 	diff_print_info *pi,
-	git_buf *out,
+	git_str *out,
 	git_patch *patch,
 	git_diff_format_t format,
 	git_diff_line_cb cb,
@@ -100,6 +104,7 @@ static int diff_print_info_init_frompatch(
 	memset(pi, 0, sizeof(diff_print_info));
 
 	pi->flags = patch->diff_opts.flags;
+	pi->oid_type = patch->diff_opts.oid_type;
 	pi->id_strlen = patch->diff_opts.id_abbrev;
 	pi->old_prefix = patch->diff_opts.old_prefix;
 	pi->new_prefix = patch->diff_opts.new_prefix;
@@ -142,7 +147,7 @@ static int diff_print_one_name_only(
 	const git_diff_delta *delta, float progress, void *data)
 {
 	diff_print_info *pi = data;
-	git_buf *out = pi->buf;
+	git_str *out = pi->buf;
 
 	GIT_UNUSED(progress);
 
@@ -150,15 +155,15 @@ static int diff_print_one_name_only(
 		delta->status == GIT_DELTA_UNMODIFIED)
 		return 0;
 
-	git_buf_clear(out);
-	git_buf_puts(out, delta->new_file.path);
-	git_buf_putc(out, '\n');
-	if (git_buf_oom(out))
+	git_str_clear(out);
+	git_str_puts(out, delta->new_file.path);
+	git_str_putc(out, '\n');
+	if (git_str_oom(out))
 		return -1;
 
 	pi->line.origin      = GIT_DIFF_LINE_FILE_HDR;
-	pi->line.content     = git_buf_cstr(out);
-	pi->line.content_len = git_buf_len(out);
+	pi->line.content     = git_str_cstr(out);
+	pi->line.content_len = git_str_len(out);
 
 	return pi->print_cb(delta, NULL, &pi->line, pi->payload);
 }
@@ -167,7 +172,7 @@ static int diff_print_one_name_status(
 	const git_diff_delta *delta, float progress, void *data)
 {
 	diff_print_info *pi = data;
-	git_buf *out = pi->buf;
+	git_str *out = pi->buf;
 	char old_suffix, new_suffix, code = git_diff_status_char(delta->status);
 	int(*strcomp)(const char *, const char *) = pi->strcomp ?
 		pi->strcomp : git__strcmp;
@@ -180,26 +185,26 @@ static int diff_print_one_name_status(
 	old_suffix = diff_pick_suffix(delta->old_file.mode);
 	new_suffix = diff_pick_suffix(delta->new_file.mode);
 
-	git_buf_clear(out);
+	git_str_clear(out);
 
 	if (delta->old_file.path != delta->new_file.path &&
 		strcomp(delta->old_file.path,delta->new_file.path) != 0)
-		git_buf_printf(out, "%c\t%s%c %s%c\n", code,
+		git_str_printf(out, "%c\t%s%c %s%c\n", code,
 			delta->old_file.path, old_suffix, delta->new_file.path, new_suffix);
 	else if (delta->old_file.mode != delta->new_file.mode &&
 		delta->old_file.mode != 0 && delta->new_file.mode != 0)
-		git_buf_printf(out, "%c\t%s%c %s%c\n", code,
+		git_str_printf(out, "%c\t%s%c %s%c\n", code,
 			delta->old_file.path, old_suffix, delta->new_file.path, new_suffix);
 	else if (old_suffix != ' ')
-		git_buf_printf(out, "%c\t%s%c\n", code, delta->old_file.path, old_suffix);
+		git_str_printf(out, "%c\t%s%c\n", code, delta->old_file.path, old_suffix);
 	else
-		git_buf_printf(out, "%c\t%s\n", code, delta->old_file.path);
-	if (git_buf_oom(out))
+		git_str_printf(out, "%c\t%s\n", code, delta->old_file.path);
+	if (git_str_oom(out))
 		return -1;
 
 	pi->line.origin      = GIT_DIFF_LINE_FILE_HDR;
-	pi->line.content     = git_buf_cstr(out);
-	pi->line.content_len = git_buf_len(out);
+	pi->line.content     = git_str_cstr(out);
+	pi->line.content_len = git_str_len(out);
 
 	return pi->print_cb(delta, NULL, &pi->line, pi->payload);
 }
@@ -208,17 +213,20 @@ static int diff_print_one_raw(
 	const git_diff_delta *delta, float progress, void *data)
 {
 	diff_print_info *pi = data;
-	git_buf *out = pi->buf;
+	git_str *out = pi->buf;
 	int id_abbrev;
 	char code = git_diff_status_char(delta->status);
-	char start_oid[GIT_OID_HEXSZ+1], end_oid[GIT_OID_HEXSZ+1];
+	char start_oid[GIT_OID_MAX_HEXSIZE + 1],
+	     end_oid[GIT_OID_MAX_HEXSIZE + 1];
+	size_t oid_hexsize;
+	bool id_is_abbrev;
 
 	GIT_UNUSED(progress);
 
 	if ((pi->flags & GIT_DIFF_SHOW_UNMODIFIED) == 0 && code == ' ')
 		return 0;
 
-	git_buf_clear(out);
+	git_str_clear(out);
 
 	id_abbrev = delta->old_file.mode ? delta->old_file.id_abbrev :
 		delta->new_file.id_abbrev;
@@ -230,49 +238,59 @@ static int diff_print_one_raw(
 		return -1;
 	}
 
+#ifdef GIT_EXPERIMENTAL_SHA256
+	GIT_ASSERT(delta->old_file.id.type == delta->new_file.id.type);
+	oid_hexsize = git_oid_hexsize(delta->old_file.id.type);
+#else
+	oid_hexsize = GIT_OID_SHA1_HEXSIZE;
+#endif
+
+	id_is_abbrev = (pi->id_strlen > 0 &&
+	                (size_t)pi->id_strlen <= oid_hexsize);
+
 	git_oid_tostr(start_oid, pi->id_strlen + 1, &delta->old_file.id);
 	git_oid_tostr(end_oid, pi->id_strlen + 1, &delta->new_file.id);
 
-	git_buf_printf(
-		out, (pi->id_strlen <= GIT_OID_HEXSZ) ?
-			":%06o %06o %s... %s... %c" : ":%06o %06o %s %s %c",
+	git_str_printf(out,
+		id_is_abbrev ? ":%06o %06o %s... %s... %c" : ":%06o %06o %s %s %c",
 		delta->old_file.mode, delta->new_file.mode, start_oid, end_oid, code);
 
 	if (delta->similarity > 0)
-		git_buf_printf(out, "%03u", delta->similarity);
+		git_str_printf(out, "%03u", delta->similarity);
 
 	if (delta->old_file.path != delta->new_file.path)
-		git_buf_printf(
+		git_str_printf(
 			out, "\t%s %s\n", delta->old_file.path, delta->new_file.path);
 	else
-		git_buf_printf(
+		git_str_printf(
 			out, "\t%s\n", delta->old_file.path ?
 			delta->old_file.path : delta->new_file.path);
 
-	if (git_buf_oom(out))
+	if (git_str_oom(out))
 		return -1;
 
 	pi->line.origin      = GIT_DIFF_LINE_FILE_HDR;
-	pi->line.content     = git_buf_cstr(out);
-	pi->line.content_len = git_buf_len(out);
+	pi->line.content     = git_str_cstr(out);
+	pi->line.content_len = git_str_len(out);
 
 	return pi->print_cb(delta, NULL, &pi->line, pi->payload);
 }
 
 static int diff_print_modes(
-	git_buf *out, const git_diff_delta *delta)
+	git_str *out, const git_diff_delta *delta)
 {
-	git_buf_printf(out, "old mode %o\n", delta->old_file.mode);
-	git_buf_printf(out, "new mode %o\n", delta->new_file.mode);
+	git_str_printf(out, "old mode %o\n", delta->old_file.mode);
+	git_str_printf(out, "new mode %o\n", delta->new_file.mode);
 
-	return git_buf_oom(out) ? -1 : 0;
+	return git_str_oom(out) ? -1 : 0;
 }
 
 static int diff_print_oid_range(
-	git_buf *out, const git_diff_delta *delta, int id_strlen,
+	git_str *out, const git_diff_delta *delta, int id_strlen,
 	bool print_index)
 {
-	char start_oid[GIT_OID_HEXSZ+1], end_oid[GIT_OID_HEXSZ+1];
+	char start_oid[GIT_OID_MAX_HEXSIZE + 1],
+	     end_oid[GIT_OID_MAX_HEXSIZE + 1];
 
 	if (delta->old_file.mode &&
 			id_strlen > delta->old_file.id_abbrev) {
@@ -295,34 +313,39 @@ static int diff_print_oid_range(
 
 	if (delta->old_file.mode == delta->new_file.mode) {
 		if (print_index)
-			git_buf_printf(out, "index %s..%s %o\n",
+			git_str_printf(out, "index %s..%s %o\n",
 				start_oid, end_oid, delta->old_file.mode);
 	} else {
 		if (delta->old_file.mode == 0)
-			git_buf_printf(out, "new file mode %o\n", delta->new_file.mode);
+			git_str_printf(out, "new file mode %o\n", delta->new_file.mode);
 		else if (delta->new_file.mode == 0)
-			git_buf_printf(out, "deleted file mode %o\n", delta->old_file.mode);
+			git_str_printf(out, "deleted file mode %o\n", delta->old_file.mode);
 		else
 			diff_print_modes(out, delta);
 
 		if (print_index)
-			git_buf_printf(out, "index %s..%s\n", start_oid, end_oid);
+			git_str_printf(out, "index %s..%s\n", start_oid, end_oid);
 	}
 
-	return git_buf_oom(out) ? -1 : 0;
+	return git_str_oom(out) ? -1 : 0;
 }
 
 static int diff_delta_format_path(
-	git_buf *out, const char *prefix, const char *filename)
+	git_str *out, const char *prefix, const char *filename)
 {
-	if (git_buf_joinpath(out, prefix, filename) < 0)
+	if (!filename) {
+		/* don't prefix "/dev/null" */
+ 		return git_str_puts(out, "/dev/null");
+	}
+
+	if (git_str_joinpath(out, prefix, filename) < 0)
 		return -1;
 
-	return git_buf_quote(out);
+	return git_str_quote(out);
 }
 
 static int diff_delta_format_with_paths(
-	git_buf *out,
+	git_str *out,
 	const git_diff_delta *delta,
 	const char *template,
 	const char *oldpath,
@@ -334,14 +357,14 @@ static int diff_delta_format_with_paths(
 	if (git_oid_is_zero(&delta->new_file.id))
 		newpath = "/dev/null";
 
-	return git_buf_printf(out, template, oldpath, newpath);
+	return git_str_printf(out, template, oldpath, newpath);
 }
 
 static int diff_delta_format_similarity_header(
-	git_buf *out,
+	git_str *out,
 	const git_diff_delta *delta)
 {
-	git_buf old_path = GIT_BUF_INIT, new_path = GIT_BUF_INIT;
+	git_str old_path = GIT_STR_INIT, new_path = GIT_STR_INIT;
 	const char *type;
 	int error = 0;
 
@@ -357,13 +380,13 @@ static int diff_delta_format_similarity_header(
 	else
 		type = "copy";
 
-	if ((error = git_buf_puts(&old_path, delta->old_file.path)) < 0 ||
-	    (error = git_buf_puts(&new_path, delta->new_file.path)) < 0 ||
-	    (error = git_buf_quote(&old_path)) < 0 ||
-	    (error = git_buf_quote(&new_path)) < 0)
+	if ((error = git_str_puts(&old_path, delta->old_file.path)) < 0 ||
+	    (error = git_str_puts(&new_path, delta->new_file.path)) < 0 ||
+	    (error = git_str_quote(&old_path)) < 0 ||
+	    (error = git_str_quote(&new_path)) < 0)
 		goto done;
 
-	git_buf_printf(out,
+	git_str_printf(out,
 		"similarity index %d%%\n"
 		"%s from %s\n"
 		"%s to %s\n",
@@ -371,12 +394,12 @@ static int diff_delta_format_similarity_header(
 		type, old_path.ptr,
 		type, new_path.ptr);
 
-	if (git_buf_oom(out))
+	if (git_str_oom(out))
 		error = -1;
 
 done:
-	git_buf_dispose(&old_path);
-	git_buf_dispose(&new_path);
+	git_str_dispose(&old_path);
+	git_str_dispose(&new_path);
 
 	return error;
 }
@@ -398,14 +421,14 @@ static bool delta_is_unchanged(const git_diff_delta *delta)
 }
 
 int git_diff_delta__format_file_header(
-	git_buf *out,
+	git_str *out,
 	const git_diff_delta *delta,
 	const char *oldpfx,
 	const char *newpfx,
 	int id_strlen,
 	bool print_index)
 {
-	git_buf old_path = GIT_BUF_INIT, new_path = GIT_BUF_INIT;
+	git_str old_path = GIT_STR_INIT, new_path = GIT_STR_INIT;
 	bool unchanged = delta_is_unchanged(delta);
 	int error = 0;
 
@@ -422,9 +445,9 @@ int git_diff_delta__format_file_header(
 			&new_path, newpfx, delta->new_file.path)) < 0)
 		goto done;
 
-	git_buf_clear(out);
+	git_str_clear(out);
 
-	git_buf_printf(out, "diff --git %s %s\n",
+	git_str_printf(out, "diff --git %s %s\n",
 		old_path.ptr, new_path.ptr);
 
 	if (unchanged && delta->old_file.mode != delta->new_file.mode)
@@ -446,12 +469,12 @@ int git_diff_delta__format_file_header(
 				"--- %s\n+++ %s\n", old_path.ptr, new_path.ptr);
 	}
 
-	if (git_buf_oom(out))
+	if (git_str_oom(out))
 		error = -1;
 
 done:
-	git_buf_dispose(&old_path);
-	git_buf_dispose(&new_path);
+	git_str_dispose(&old_path);
+	git_str_dispose(&new_path);
 
 	return error;
 }
@@ -467,7 +490,7 @@ static int format_binary(
 		"delta" : "literal";
 	const char *scan, *end;
 
-	git_buf_printf(pi->buf, "%s %" PRIuZ "\n", typename, inflatedlen);
+	git_str_printf(pi->buf, "%s %" PRIuZ "\n", typename, inflatedlen);
 	pi->line.num_lines++;
 
 	for (scan = data, end = data + datalen; scan < end; ) {
@@ -476,22 +499,22 @@ static int format_binary(
 			chunk_len = 52;
 
 		if (chunk_len <= 26)
-			git_buf_putc(pi->buf, (char)chunk_len + 'A' - 1);
+			git_str_putc(pi->buf, (char)chunk_len + 'A' - 1);
 		else
-			git_buf_putc(pi->buf, (char)chunk_len - 26 + 'a' - 1);
+			git_str_putc(pi->buf, (char)chunk_len - 26 + 'a' - 1);
 
-		git_buf_encode_base85(pi->buf, scan, chunk_len);
-		git_buf_putc(pi->buf, '\n');
+		git_str_encode_base85(pi->buf, scan, chunk_len);
+		git_str_putc(pi->buf, '\n');
 
-		if (git_buf_oom(pi->buf))
+		if (git_str_oom(pi->buf))
 			return -1;
 
 		scan += chunk_len;
 		pi->line.num_lines++;
 	}
-	git_buf_putc(pi->buf, '\n');
+	git_str_putc(pi->buf, '\n');
 
-	if (git_buf_oom(pi->buf))
+	if (git_str_oom(pi->buf))
 		return -1;
 
 	return 0;
@@ -501,7 +524,7 @@ static int diff_print_patch_file_binary_noshow(
 	diff_print_info *pi, git_diff_delta *delta,
 	const char *old_pfx, const char *new_pfx)
 {
-	git_buf old_path = GIT_BUF_INIT, new_path = GIT_BUF_INIT;
+	git_str old_path = GIT_STR_INIT, new_path = GIT_STR_INIT;
 	int error;
 
 	if ((error = diff_delta_format_path(&old_path, old_pfx, delta->old_file.path)) < 0 ||
@@ -513,8 +536,8 @@ static int diff_print_patch_file_binary_noshow(
 	pi->line.num_lines = 1;
 
 done:
-	git_buf_dispose(&old_path);
-	git_buf_dispose(&new_path);
+	git_str_dispose(&old_path);
+	git_str_dispose(&new_path);
 	return error;
 }
 
@@ -534,7 +557,7 @@ static int diff_print_patch_file_binary(
 			pi, delta, old_pfx, new_pfx);
 
 	pre_binary_size = pi->buf->size;
-	git_buf_printf(pi->buf, "GIT binary patch\n");
+	git_str_printf(pi->buf, "GIT binary patch\n");
 	pi->line.num_lines++;
 
 	if ((error = format_binary(pi, binary->new_file.type, binary->new_file.data,
@@ -543,7 +566,7 @@ static int diff_print_patch_file_binary(
 				   binary->old_file.datalen, binary->old_file.inflatedlen)) < 0) {
 		if (error == GIT_EBUFS) {
 			git_error_clear();
-			git_buf_truncate(pi->buf, pre_binary_size);
+			git_str_truncate(pi->buf, pre_binary_size);
 
 			return diff_print_patch_file_binary_noshow(
 				pi, delta, old_pfx, new_pfx);
@@ -554,6 +577,30 @@ static int diff_print_patch_file_binary(
 	return error;
 }
 
+GIT_INLINE(int) should_force_header(const git_diff_delta *delta)
+{
+	if (delta->old_file.mode != delta->new_file.mode)
+		return 1;
+
+	if (delta->status == GIT_DELTA_RENAMED || delta->status == GIT_DELTA_COPIED)
+		return 1;
+
+	return 0;
+}
+
+GIT_INLINE(int) flush_file_header(const git_diff_delta *delta, diff_print_info *pi)
+{
+	if (pi->sent_file_header)
+		return 0;
+
+	pi->line.origin      = GIT_DIFF_LINE_FILE_HDR;
+	pi->line.content     = git_str_cstr(pi->buf);
+	pi->line.content_len = git_str_len(pi->buf);
+	pi->sent_file_header = 1;
+
+	return pi->print_cb(delta, NULL, &pi->line, pi->payload);
+}
+
 static int diff_print_patch_file(
 	const git_diff_delta *delta, float progress, void *data)
 {
@@ -584,15 +631,22 @@ static int diff_print_patch_file(
 		 (pi->flags & GIT_DIFF_SHOW_UNTRACKED_CONTENT) == 0))
 		return 0;
 
+	pi->sent_file_header = 0;
+
 	if ((error = git_diff_delta__format_file_header(pi->buf, delta, oldpfx, newpfx,
 							id_strlen, print_index)) < 0)
 		return error;
 
-	pi->line.origin      = GIT_DIFF_LINE_FILE_HDR;
-	pi->line.content     = git_buf_cstr(pi->buf);
-	pi->line.content_len = git_buf_len(pi->buf);
+	/*
+	 * pi->buf now contains the file header data. Go ahead and send it
+	 * if there's useful data in there, like similarity. Otherwise, we
+	 * should queue it to send when we see the first hunk. This prevents
+	 * us from sending a header when all hunks were ignored.
+	 */
+	if (should_force_header(delta) && (error = flush_file_header(delta, pi)) < 0)
+		return error;
 
-	return pi->print_cb(delta, NULL, &pi->line, pi->payload);
+	return 0;
 }
 
 static int diff_print_patch_binary(
@@ -607,15 +661,25 @@ static int diff_print_patch_binary(
 		pi->new_prefix ? pi->new_prefix : DIFF_NEW_PREFIX_DEFAULT;
 	int error;
 
-	git_buf_clear(pi->buf);
+	if ((error = flush_file_header(delta, pi)) < 0)
+		return error;
+
+	/*
+	 * If the caller only wants the header, we just needed to make sure to
+	 * call flush_file_header
+	 */
+	if (pi->format == GIT_DIFF_FORMAT_PATCH_HEADER)
+		return 0;
+
+	git_str_clear(pi->buf);
 
 	if ((error = diff_print_patch_file_binary(
 		pi, (git_diff_delta *)delta, old_pfx, new_pfx, binary)) < 0)
 		return error;
 
 	pi->line.origin = GIT_DIFF_LINE_BINARY;
-	pi->line.content = git_buf_cstr(pi->buf);
-	pi->line.content_len = git_buf_len(pi->buf);
+	pi->line.content = git_str_cstr(pi->buf);
+	pi->line.content_len = git_str_len(pi->buf);
 
 	return pi->print_cb(delta, NULL, &pi->line, pi->payload);
 }
@@ -626,10 +690,21 @@ static int diff_print_patch_hunk(
 	void *data)
 {
 	diff_print_info *pi = data;
+	int error;
 
 	if (S_ISDIR(d->new_file.mode))
 		return 0;
 
+	if ((error = flush_file_header(d, pi)) < 0)
+		return error;
+
+	/*
+	 * If the caller only wants the header, we just needed to make sure to
+	 * call flush_file_header
+	 */
+	if (pi->format == GIT_DIFF_FORMAT_PATCH_HEADER)
+		return 0;
+
 	pi->line.origin      = GIT_DIFF_LINE_HUNK_HDR;
 	pi->line.content     = h->header;
 	pi->line.content_len = h->header_len;
@@ -644,10 +719,14 @@ static int diff_print_patch_line(
 	void *data)
 {
 	diff_print_info *pi = data;
+	int error;
 
 	if (S_ISDIR(delta->new_file.mode))
 		return 0;
 
+	if ((error = flush_file_header(delta, pi)) < 0)
+		return error;
+
 	return pi->print_cb(delta, hunk, line, pi->payload);
 }
 
@@ -659,7 +738,7 @@ int git_diff_print(
 	void *payload)
 {
 	int error;
-	git_buf buf = GIT_BUF_INIT;
+	git_str buf = GIT_STR_INIT;
 	diff_print_info pi;
 	git_diff_file_cb print_file = NULL;
 	git_diff_binary_cb print_binary = NULL;
@@ -680,6 +759,8 @@ int git_diff_print(
 		break;
 	case GIT_DIFF_FORMAT_PATCH_HEADER:
 		print_file = diff_print_patch_file;
+		print_binary = diff_print_patch_binary;
+		print_hunk = diff_print_patch_hunk;
 		break;
 	case GIT_DIFF_FORMAT_RAW:
 		print_file = diff_print_one_raw;
@@ -704,7 +785,7 @@ int git_diff_print(
 	}
 
 out:
-	git_buf_dispose(&buf);
+	git_str_dispose(&buf);
 	return error;
 }
 
@@ -714,7 +795,7 @@ int git_diff_print_callback__to_buf(
 	const git_diff_line *line,
 	void *payload)
 {
-	git_buf *output = payload;
+	git_str *output = payload;
 	GIT_UNUSED(delta); GIT_UNUSED(hunk);
 
 	if (!output) {
@@ -725,9 +806,9 @@ int git_diff_print_callback__to_buf(
 	if (line->origin == GIT_DIFF_LINE_ADDITION ||
 	    line->origin == GIT_DIFF_LINE_DELETION ||
 	    line->origin == GIT_DIFF_LINE_CONTEXT)
-		git_buf_putc(output, line->origin);
+		git_str_putc(output, line->origin);
 
-	return git_buf_put(output, line->content, line->content_len);
+	return git_str_put(output, line->content, line->content_len);
 }
 
 int git_diff_print_callback__to_file_handle(
@@ -761,18 +842,24 @@ int git_diff_print_callback__to_file_handle(
 	return 0;
 }
 
-/* print a git_diff to a git_buf */
+/* print a git_diff to a git_str */
 int git_diff_to_buf(git_buf *out, git_diff *diff, git_diff_format_t format)
 {
+	git_str str = GIT_STR_INIT;
 	int error;
 
 	GIT_ASSERT_ARG(out);
 	GIT_ASSERT_ARG(diff);
 
-	if ((error = git_buf_sanitize(out)) < 0)
-		return error;
+	if ((error = git_buf_tostr(&str, out)) < 0 ||
+	    (error = git_diff_print(diff, format, git_diff_print_callback__to_buf, &str)) < 0)
+		goto done;
+
+	error = git_buf_fromstr(out, &str);
 
-	return git_diff_print(diff, format, git_diff_print_callback__to_buf, out);
+done:
+	git_str_dispose(&str);
+	return error;
 }
 
 /* print a git_patch to an output callback */
@@ -781,7 +868,7 @@ int git_patch_print(
 	git_diff_line_cb print_cb,
 	void *payload)
 {
-	git_buf temp = GIT_BUF_INIT;
+	git_str temp = GIT_STR_INIT;
 	diff_print_info pi;
 	int error;
 
@@ -799,20 +886,20 @@ int git_patch_print(
 	}
 
 out:
-	git_buf_dispose(&temp);
+	git_str_dispose(&temp);
 	return error;
 }
 
-/* print a git_patch to a git_buf */
+/* print a git_patch to a git_str */
 int git_patch_to_buf(git_buf *out, git_patch *patch)
 {
-	int error;
+	GIT_BUF_WRAP_PRIVATE(out, git_patch__to_buf, patch);
+}
 
+int git_patch__to_buf(git_str *out, git_patch *patch)
+{
 	GIT_ASSERT_ARG(out);
 	GIT_ASSERT_ARG(patch);
 
-	if ((error = git_buf_sanitize(out)) < 0)
-		return error;
-
 	return git_patch_print(patch, git_diff_print_callback__to_buf, out);
 }