rugged 0.27.10 → 0.27.10.1

data/vendor/libgit2/src/tree-cache.c

@@ -120,14 +120,12 @@ static int read_tree_internal(git_tree_cache **out,
 
 	/* Parse children: */
 	if (tree->children_count > 0) {
-		size_t i, bufsize;
+		unsigned int i;
 
-		GIT_ERROR_CHECK_ALLOC_MULTIPLY(&bufsize, tree->children_count, sizeof(git_tree_cache*));
+		tree->children = git_pool_malloc(pool, tree->children_count * sizeof(git_tree_cache *));
+		GITERR_CHECK_ALLOC(tree->children);
 
-		tree->children = git_pool_malloc(pool, bufsize);
-		GIT_ERROR_CHECK_ALLOC(tree->children);
-
-		memset(tree->children, 0x0, bufsize);
+		memset(tree->children, 0x0, tree->children_count * sizeof(git_tree_cache *));
 
 		for (i = 0; i < tree->children_count; ++i) {
 			if (read_tree_internal(&tree->children[i], &buffer, buffer_end, pool) < 0)
@@ -140,7 +138,7 @@ static int read_tree_internal(git_tree_cache **out,
 	return 0;
 
  corrupted:
-	git_error_set(GIT_ERROR_INDEX, "corrupted TREE extension in index");
+	giterr_set(GITERR_INDEX, "corrupted TREE extension in index");
 	return -1;
 }
 
@@ -152,7 +150,7 @@ int git_tree_cache_read(git_tree_cache **tree, const char *buffer, size_t buffer
 		return -1;
 
 	if (buffer < buffer_end) {
-		git_error_set(GIT_ERROR_INDEX, "corrupted TREE extension in index (unexpected trailing data)");
+		giterr_set(GITERR_INDEX, "corrupted TREE extension in index (unexpected trailing data)");
 		return -1;
 	}
 
@@ -162,7 +160,7 @@ int git_tree_cache_read(git_tree_cache **tree, const char *buffer, size_t buffer
 static int read_tree_recursive(git_tree_cache *cache, const git_tree *tree, git_pool *pool)
 {
 	git_repository *repo;
-	size_t i, j, nentries, ntrees, alloc_size;
+	size_t i, j, nentries, ntrees;
 	int error;
 
 	repo = git_tree_owner(tree);
@@ -184,11 +182,9 @@ static int read_tree_recursive(git_tree_cache *cache, const git_tree *tree, git_
 			ntrees++;
 	}
 
-	GIT_ERROR_CHECK_ALLOC_MULTIPLY(&alloc_size, ntrees, sizeof(git_tree_cache *));
-
 	cache->children_count = ntrees;
-	cache->children = git_pool_mallocz(pool, alloc_size);
-	GIT_ERROR_CHECK_ALLOC(cache->children);
+	cache->children = git_pool_mallocz(pool, ntrees * sizeof(git_tree_cache *));
+	GITERR_CHECK_ALLOC(cache->children);
 
 	j = 0;
 	for (i = 0; i < nentries; i++) {
@@ -236,15 +232,12 @@ int git_tree_cache_read_tree(git_tree_cache **out, const git_tree *tree, git_poo
 
 int git_tree_cache_new(git_tree_cache **out, const char *name, git_pool *pool)
 {
-	size_t name_len, alloc_size;
+	size_t name_len;
 	git_tree_cache *tree;
 
 	name_len = strlen(name);
-
-	GIT_ERROR_CHECK_ALLOC_ADD3(&alloc_size, sizeof(git_tree_cache), name_len, 1);
-
-	tree = git_pool_malloc(pool, alloc_size);
-	GIT_ERROR_CHECK_ALLOC(tree);
+	tree = git_pool_malloc(pool, sizeof(git_tree_cache) + name_len + 1);
+	GITERR_CHECK_ALLOC(tree);
 
 	memset(tree, 0x0, sizeof(git_tree_cache));
 	/* NUL-terminated tree name */

data/vendor/libgit2/src/tree.c

@@ -10,7 +10,7 @@
 #include "commit.h"
 #include "git2/repository.h"
 #include "git2/object.h"
-#include "futils.h"
+#include "fileops.h"
 #include "tree-cache.h"
 #include "index.h"
 
@@ -18,7 +18,7 @@
 #define MAX_FILEMODE_BYTES 6
 
 #define TREE_ENTRY_CHECK_NAMELEN(n) \
-	if (n > UINT16_MAX) { git_error_set(GIT_ERROR_INVALID, "tree entry path too long"); }
+	if (n > UINT16_MAX) { giterr_set(GITERR_INVALID, "tree entry path too long"); }
 
 static bool valid_filemode(const int filemode)
 {
@@ -74,6 +74,14 @@ int git_tree_entry_cmp(const git_tree_entry *e1, const git_tree_entry *e2)
 	return entry_sort_cmp(e1, e2);
 }
 
+int git_tree_entry_icmp(const git_tree_entry *e1, const git_tree_entry *e2)
+{
+	return git_path_cmp(
+		e1->filename, e1->filename_len, git_tree_entry__is_tree(e1),
+		e2->filename, e2->filename_len, git_tree_entry__is_tree(e2),
+		git__strncasecmp);
+}
+
 /**
  * Allocate a new self-contained entry, with enough space after it to
  * store the filename and the id.
@@ -271,16 +279,16 @@ const git_oid *git_tree_entry_id(const git_tree_entry *entry)
 	return entry->oid;
 }
 
-git_object_t git_tree_entry_type(const git_tree_entry *entry)
+git_otype git_tree_entry_type(const git_tree_entry *entry)
 {
 	assert(entry);
 
 	if (S_ISGITLINK(entry->attr))
-		return GIT_OBJECT_COMMIT;
+		return GIT_OBJ_COMMIT;
 	else if (S_ISDIR(entry->attr))
-		return GIT_OBJECT_TREE;
+		return GIT_OBJ_TREE;
 	else
-		return GIT_OBJECT_BLOB;
+		return GIT_OBJ_BLOB;
 }
 
 int git_tree_entry_to_object(
@@ -289,7 +297,7 @@ int git_tree_entry_to_object(
 	const git_tree_entry *entry)
 {
 	assert(entry && object_out);
-	return git_object_lookup(object_out, repo, entry->oid, GIT_OBJECT_ANY);
+	return git_object_lookup(object_out, repo, entry->oid, GIT_OBJ_ANY);
 }
 
 static const git_tree_entry *entry_fromname(
@@ -334,25 +342,60 @@ const git_tree_entry *git_tree_entry_byid(
 	return NULL;
 }
 
+int git_tree__prefix_position(const git_tree *tree, const char *path)
+{
+	struct tree_key_search ksearch;
+	size_t at_pos, path_len;
+
+	if (!path)
+		return 0;
+
+	path_len = strlen(path);
+	TREE_ENTRY_CHECK_NAMELEN(path_len);
+
+	ksearch.filename = path;
+	ksearch.filename_len = (uint16_t)path_len;
+
+	/* Find tree entry with appropriate prefix */
+	git_array_search(
+		&at_pos, tree->entries, &homing_search_cmp, &ksearch);
+
+	for (; at_pos < tree->entries.size; ++at_pos) {
+		const git_tree_entry *entry = git_array_get(tree->entries, at_pos);
+		if (homing_search_cmp(&ksearch, entry) < 0)
+			break;
+	}
+
+	for (; at_pos > 0; --at_pos) {
+		const git_tree_entry *entry =
+			git_array_get(tree->entries, at_pos - 1);
+
+		if (homing_search_cmp(&ksearch, entry) > 0)
+			break;
+	}
+
+	return (int)at_pos;
+}
+
 size_t git_tree_entrycount(const git_tree *tree)
 {
 	assert(tree);
 	return tree->entries.size;
 }
 
-size_t git_treebuilder_entrycount(git_treebuilder *bld)
+unsigned int git_treebuilder_entrycount(git_treebuilder *bld)
 {
 	assert(bld);
 
-	return git_strmap_size(bld->map);
+	return git_strmap_num_entries(bld->map);
 }
 
 static int tree_error(const char *str, const char *path)
 {
 	if (path)
-		git_error_set(GIT_ERROR_TREE, "%s - %s", str, path);
+		giterr_set(GITERR_TREE, "%s - %s", str, path);
 	else
-		git_error_set(GIT_ERROR_TREE, "%s", str);
+		giterr_set(GITERR_TREE, "%s", str);
 	return -1;
 }
 
@@ -375,18 +418,20 @@ static int parse_mode(uint16_t *mode_out, const char *buffer, size_t buffer_len,
 	return 0;
 }
 
-int git_tree__parse_raw(void *_tree, const char *data, size_t size)
+int git_tree__parse(void *_tree, git_odb_object *odb_obj)
 {
 	git_tree *tree = _tree;
 	const char *buffer;
 	const char *buffer_end;
 
-	buffer = data;
-	buffer_end = buffer + size;
+	if (git_odb_object_dup(&tree->odb_obj, odb_obj) < 0)
+		return -1;
+
+	buffer = git_odb_object_data(tree->odb_obj);
+	buffer_end = buffer + git_odb_object_size(tree->odb_obj);
 
-	tree->odb_obj = NULL;
 	git_array_init_to_size(tree->entries, DEFAULT_TREE_SIZE);
-	GIT_ERROR_CHECK_ARRAY(tree->entries);
+	GITERR_CHECK_ARRAY(tree->entries);
 
 	while (buffer < buffer_end) {
 		git_tree_entry *entry;
@@ -403,7 +448,7 @@ int git_tree__parse_raw(void *_tree, const char *data, size_t size)
 		if ((nul = memchr(buffer, 0, buffer_end - buffer)) == NULL)
 			return tree_error("failed to parse tree: object is corrupted", NULL);
 
-		if ((filename_len = nul - buffer) == 0 || filename_len > UINT16_MAX)
+		if ((filename_len = nul - buffer) == 0)
 			return tree_error("failed to parse tree: can't parse filename", NULL);
 
 		if ((buffer_end - (nul + 1)) < GIT_OID_RAWSZ)
@@ -412,10 +457,10 @@ int git_tree__parse_raw(void *_tree, const char *data, size_t size)
 		/* Allocate the entry */
 		{
 			entry = git_array_alloc(tree->entries);
-			GIT_ERROR_CHECK_ALLOC(entry);
+			GITERR_CHECK_ALLOC(entry);
 
 			entry->attr = attr;
-			entry->filename_len = (uint16_t)filename_len;
+			entry->filename_len = filename_len;
 			entry->filename = buffer;
 			entry->oid = (git_oid *) ((char *) buffer + filename_len + 1);
 		}
@@ -427,21 +472,6 @@ int git_tree__parse_raw(void *_tree, const char *data, size_t size)
 	return 0;
 }
 
-int git_tree__parse(void *_tree, git_odb_object *odb_obj)
-{
-	git_tree *tree = _tree;
-
-	if ((git_tree__parse_raw(tree,
-	    git_odb_object_data(odb_obj),
-	    git_odb_object_size(odb_obj))) < 0)
-		return -1;
-
-	if (git_odb_object_dup(&tree->odb_obj, odb_obj) < 0)
-		return -1;
-
-	return 0;
-}
-
 static size_t find_next_dir(const char *dirname, git_index *index, size_t start)
 {
 	size_t dirlen, i, entries = git_index_entrycount(index);
@@ -459,36 +489,6 @@ static size_t find_next_dir(const char *dirname, git_index *index, size_t start)
 	return i;
 }
 
-static git_object_t otype_from_mode(git_filemode_t filemode)
-{
-	switch (filemode) {
-	case GIT_FILEMODE_TREE:
-		return GIT_OBJECT_TREE;
-	case GIT_FILEMODE_COMMIT:
-		return GIT_OBJECT_COMMIT;
-	default:
-		return GIT_OBJECT_BLOB;
-	}
-}
-
-static int check_entry(git_repository *repo, const char *filename, const git_oid *id, git_filemode_t filemode)
-{
-	if (!valid_filemode(filemode))
-		return tree_error("failed to insert entry: invalid filemode for file", filename);
-
-	if (!valid_entry_name(repo, filename))
-		return tree_error("failed to insert entry: invalid name for a tree entry", filename);
-
-	if (git_oid_is_zero(id))
-		return tree_error("failed to insert entry: invalid null OID", filename);
-
-	if (filemode != GIT_FILEMODE_COMMIT &&
-	    !git_object__is_valid(repo, id, otype_from_mode(filemode)))
-		return tree_error("failed to insert entry: invalid object specified", filename);
-
-	return 0;
-}
-
 static int append_entry(
 	git_treebuilder *bld,
 	const char *filename,
@@ -499,17 +499,21 @@ static int append_entry(
 	git_tree_entry *entry;
 	int error = 0;
 
-	if (validate && ((error = check_entry(bld->repo, filename, id, filemode)) < 0))
-		return error;
+	if (validate && !valid_entry_name(bld->repo, filename))
+		return tree_error("failed to insert entry: invalid name for a tree entry", filename);
+
+	if (validate && git_oid_iszero(id))
+		return tree_error("failed to insert entry: invalid null OID for a tree entry", filename);
 
 	entry = alloc_entry(filename, strlen(filename), id);
-	GIT_ERROR_CHECK_ALLOC(entry);
+	GITERR_CHECK_ALLOC(entry);
 
 	entry->attr = (uint16_t)filemode;
 
-	if ((error = git_strmap_set(bld->map, entry->filename, entry)) < 0) {
+	git_strmap_insert(bld->map, entry->filename, entry, &error);
+	if (error < 0) {
 		git_tree_entry_free(entry);
-		git_error_set(GIT_ERROR_TREE, "failed to append entry %s to the tree builder", filename);
+		giterr_set(GITERR_TREE, "failed to append entry %s to the tree builder", filename);
 		return -1;
 	}
 
@@ -572,7 +576,7 @@ static int write_tree(
 			char *subdir, *last_comp;
 
 			subdir = git__strndup(entry->path, next_slash - entry->path);
-			GIT_ERROR_CHECK_ALLOC(subdir);
+			GITERR_CHECK_ALLOC(subdir);
 
 			/* Write out the subtree */
 			written = write_tree(&sub_oid, repo, index, subdir, i, shared_buf);
@@ -629,7 +633,7 @@ int git_tree__write_index(
 	assert(oid && index && repo);
 
 	if (git_index_has_conflicts(index)) {
-		git_error_set(GIT_ERROR_INDEX,
+		giterr_set(GITERR_INDEX,
 			"cannot create a tree from a not fully merged index.");
 		return GIT_EUNMERGED;
 	}
@@ -650,7 +654,7 @@ int git_tree__write_index(
 	}
 
 	ret = write_tree(oid, repo, index, "", 0, &shared_buf);
-	git_buf_dispose(&shared_buf);
+	git_buf_free(&shared_buf);
 
 	if (old_ignore_case)
 		git_index__set_ignore_case(index, true);
@@ -683,11 +687,11 @@ int git_treebuilder_new(
 	assert(builder_p && repo);
 
 	bld = git__calloc(1, sizeof(git_treebuilder));
-	GIT_ERROR_CHECK_ALLOC(bld);
+	GITERR_CHECK_ALLOC(bld);
 
 	bld->repo = repo;
 
-	if (git_strmap_new(&bld->map) < 0) {
+	if (git_strmap_alloc(&bld->map) < 0) {
 		git__free(bld);
 		return -1;
 	}
@@ -713,6 +717,18 @@ on_error:
 	return -1;
 }
 
+static git_otype otype_from_mode(git_filemode_t filemode)
+{
+	switch (filemode) {
+	case GIT_FILEMODE_TREE:
+		return GIT_OBJ_TREE;
+	case GIT_FILEMODE_COMMIT:
+		return GIT_OBJ_COMMIT;
+	default:
+		return GIT_OBJ_BLOB;
+	}
+}
+
 int git_treebuilder_insert(
 	const git_tree_entry **entry_out,
 	git_treebuilder *bld,
@@ -722,21 +738,36 @@ int git_treebuilder_insert(
 {
 	git_tree_entry *entry;
 	int error;
+	git_strmap_iter pos;
 
 	assert(bld && id && filename);
 
-	if ((error = check_entry(bld->repo, filename, id, filemode)) < 0)
-		return error;
+	if (!valid_filemode(filemode))
+		return tree_error("failed to insert entry: invalid filemode for file", filename);
+
+	if (!valid_entry_name(bld->repo, filename))
+		return tree_error("failed to insert entry: invalid name for a tree entry", filename);
 
-	if ((entry = git_strmap_get(bld->map, filename)) != NULL) {
+	if (git_oid_iszero(id))
+		return tree_error("failed to insert entry: invalid null OID", filename);
+
+	if (filemode != GIT_FILEMODE_COMMIT &&
+	    !git_object__is_valid(bld->repo, id, otype_from_mode(filemode)))
+		return tree_error("failed to insert entry: invalid object specified", filename);
+
+	pos = git_strmap_lookup_index(bld->map, filename);
+	if (git_strmap_valid_index(bld->map, pos)) {
+		entry = git_strmap_value_at(bld->map, pos);
 		git_oid_cpy((git_oid *) entry->oid, id);
 	} else {
 		entry = alloc_entry(filename, strlen(filename), id);
-		GIT_ERROR_CHECK_ALLOC(entry);
+		GITERR_CHECK_ALLOC(entry);
+
+		git_strmap_insert(bld->map, entry->filename, entry, &error);
 
-		if ((error = git_strmap_set(bld->map, entry->filename, entry)) < 0) {
+		if (error < 0) {
 			git_tree_entry_free(entry);
-			git_error_set(GIT_ERROR_TREE, "failed to insert %s", filename);
+			giterr_set(GITERR_TREE, "failed to insert %s", filename);
 			return -1;
 		}
 	}
@@ -751,8 +782,16 @@ int git_treebuilder_insert(
 
 static git_tree_entry *treebuilder_get(git_treebuilder *bld, const char *filename)
 {
+	git_tree_entry *entry = NULL;
+	git_strmap_iter pos;
+
 	assert(bld && filename);
-	return git_strmap_get(bld->map, filename);
+
+	pos = git_strmap_lookup_index(bld->map, filename);
+	if (git_strmap_valid_index(bld->map, pos))
+		entry = git_strmap_value_at(bld->map, pos);
+
+	return entry;
 }
 
 const git_tree_entry *git_treebuilder_get(git_treebuilder *bld, const char *filename)
@@ -780,7 +819,7 @@ int git_treebuilder_write(git_oid *oid, git_treebuilder *bld)
 
 	error = git_treebuilder_write_with_buffer(oid, bld, &buffer);
 
-	git_buf_dispose(&buffer);
+	git_buf_free(&buffer);
 	return error;
 }
 
@@ -797,7 +836,7 @@ int git_treebuilder_write_with_buffer(git_oid *oid, git_treebuilder *bld, git_bu
 
 	git_buf_clear(tree);
 
-	entrycount = git_strmap_size(bld->map);
+	entrycount = git_strmap_num_entries(bld->map);
 	if ((error = git_vector_init(&entries, entrycount, entry_sort_cmp)) < 0)
 		goto out;
 
@@ -826,7 +865,7 @@ int git_treebuilder_write_with_buffer(git_oid *oid, git_treebuilder *bld, git_bu
 	}
 
 	if ((error = git_repository_odb__weakptr(&odb, bld->repo)) == 0)
-		error = git_odb_write(oid, odb, tree->ptr, tree->size, GIT_OBJECT_TREE);
+		error = git_odb_write(oid, odb, tree->ptr, tree->size, GIT_OBJ_TREE);
 
 out:
 	git_vector_free(&entries);
@@ -896,14 +935,14 @@ int git_tree_entry_bypath(
 	filename_len = subpath_len(path);
 
 	if (filename_len == 0) {
-		git_error_set(GIT_ERROR_TREE, "invalid tree path given");
+		giterr_set(GITERR_TREE, "invalid tree path given");
 		return GIT_ENOTFOUND;
 	}
 
 	entry = entry_fromname(root, path, filename_len);
 
 	if (entry == NULL) {
-		git_error_set(GIT_ERROR_TREE,
+		giterr_set(GITERR_TREE,
 			   "the path '%.*s' does not exist in the given tree", (int) filename_len, path);
 		return GIT_ENOTFOUND;
 	}
@@ -913,7 +952,7 @@ int git_tree_entry_bypath(
 		/* If there are more components in the path...
 		 * then this entry *must* be a tree */
 		if (!git_tree_entry__is_tree(entry)) {
-			git_error_set(GIT_ERROR_TREE,
+			giterr_set(GITERR_TREE,
 				   "the path '%.*s' exists but is not a tree", (int) filename_len, path);
 			return GIT_ENOTFOUND;
 		}
@@ -958,7 +997,7 @@ static int tree_walk(
 		if (preorder) {
 			error = callback(path->ptr, entry, payload);
 			if (error < 0) { /* negative value stops iteration */
-				git_error_set_after_callback_function(error, "git_tree_walk");
+				giterr_set_after_callback_function(error, "git_tree_walk");
 				break;
 			}
 			if (error > 0) { /* positive value skips this entry */
@@ -994,7 +1033,7 @@ static int tree_walk(
 		if (!preorder) {
 			error = callback(path->ptr, entry, payload);
 			if (error < 0) { /* negative value stops iteration */
-				git_error_set_after_callback_function(error, "git_tree_walk");
+				giterr_set_after_callback_function(error, "git_tree_walk");
 				break;
 			}
 			error = 0;
@@ -1014,14 +1053,14 @@ int git_tree_walk(
 	git_buf root_path = GIT_BUF_INIT;
 
 	if (mode != GIT_TREEWALK_POST && mode != GIT_TREEWALK_PRE) {
-		git_error_set(GIT_ERROR_INVALID, "invalid walking mode for tree walk");
+		giterr_set(GITERR_INVALID, "invalid walking mode for tree walk");
 		return -1;
 	}
 
 	error = tree_walk(
 		tree, callback, &root_path, payload, (mode == GIT_TREEWALK_PRE));
 
-	git_buf_dispose(&root_path);
+	git_buf_free(&root_path);
 
 	return error;
 }
@@ -1038,7 +1077,7 @@ static int on_dup_entry(void **old, void *new)
 {
 	GIT_UNUSED(old); GIT_UNUSED(new);
 
-	git_error_set(GIT_ERROR_TREE, "duplicate entries given for update");
+	giterr_set(GITERR_TREE, "duplicate entries given for update");
 	return -1;
 }
 
@@ -1107,14 +1146,14 @@ static int create_popped_tree(tree_stack_entry *current, tree_stack_entry *poppe
 	git_buf_puts(component, popped->name);
 	git__free(popped->name);
 
-	GIT_ERROR_CHECK_ALLOC(component->ptr);
+	GITERR_CHECK_ALLOC(component->ptr);
 
 	/* Error out if this would create a D/F conflict in this update */
 	if (current->tree) {
 		const git_tree_entry *to_replace;
 		to_replace = git_tree_entry_byname(current->tree, component->ptr);
-		if (to_replace && git_tree_entry_type(to_replace) != GIT_OBJECT_TREE) {
-			git_error_set(GIT_ERROR_TREE, "D/F conflict when updating tree");
+		if (to_replace && git_tree_entry_type(to_replace) != GIT_OBJ_TREE) {
+			giterr_set(GITERR_TREE, "D/F conflict when updating tree");
 			return -1;
 		}
 	}
@@ -1141,7 +1180,7 @@ int git_tree_create_updated(git_oid *out, git_repository *repo, git_tree *baseli
 	}
 
 	root_elem = git_array_alloc(stack);
-	GIT_ERROR_CHECK_ALLOC(root_elem);
+	GITERR_CHECK_ALLOC(root_elem);
 	memset(root_elem, 0, sizeof(*root_elem));
 
 	if (baseline && (error = git_tree_dup(&root_elem->tree, baseline)) < 0)
@@ -1190,14 +1229,14 @@ int git_tree_create_updated(git_oid *out, git_repository *repo, git_tree *baseli
 			if (!entry)
 				entry = treebuilder_get(last->bld, component.ptr);
 
-			if (entry && git_tree_entry_type(entry) != GIT_OBJECT_TREE) {
-				git_error_set(GIT_ERROR_TREE, "D/F conflict when updating tree");
+			if (entry && git_tree_entry_type(entry) != GIT_OBJ_TREE) {
+				giterr_set(GITERR_TREE, "D/F conflict when updating tree");
 				error = -1;
 				goto cleanup;
 			}
 
 			new_entry = git_array_alloc(stack);
-			GIT_ERROR_CHECK_ALLOC(new_entry);
+			GITERR_CHECK_ALLOC(new_entry);
 			memset(new_entry, 0, sizeof(*new_entry));
 
 			new_entry->tree = NULL;
@@ -1208,7 +1247,7 @@ int git_tree_create_updated(git_oid *out, git_repository *repo, git_tree *baseli
 				goto cleanup;
 
 			new_entry->name = git__strdup(component.ptr);
-			GIT_ERROR_CHECK_ALLOC(new_entry->name);
+			GITERR_CHECK_ALLOC(new_entry->name);
 
 			/* Get to the start of the next component */
 			path += component.size + 1;
@@ -1224,7 +1263,7 @@ int git_tree_create_updated(git_oid *out, git_repository *repo, git_tree *baseli
 				const git_tree_entry *e = git_treebuilder_get(last->bld, basename);
 				if (e && git_tree_entry_type(e) != git_object__type_from_filemode(update->filemode)) {
 					git__free(basename);
-					git_error_set(GIT_ERROR_TREE, "cannot replace '%s' with '%s' at '%s'",
+					giterr_set(GITERR_TREE, "cannot replace '%s' with '%s' at '%s'",
 						   git_object_type2string(git_tree_entry_type(e)),
 						   git_object_type2string(git_object__type_from_filemode(update->filemode)),
 						   update->path);
@@ -1244,7 +1283,7 @@ int git_tree_create_updated(git_oid *out, git_repository *repo, git_tree *baseli
 				break;
 			}
 			default:
-				git_error_set(GIT_ERROR_TREE, "unknown action for update");
+				giterr_set(GITERR_TREE, "unknown action for update");
 				error = -1;
 				goto cleanup;
 		}
@@ -1286,7 +1325,7 @@ cleanup:
 		}
 	}
 
-	git_buf_dispose(&component);
+	git_buf_free(&component);
 	git_array_clear(stack);
 	git_vector_free(&entries);
 	return error;