ruby-trello 2.0.0 → 2.3.1

data/spec/unit/trello/association_fetcher/has_many_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationFetcher::HasMany do
+
+  describe '#new' do
+    let(:board) { instance_double(Trello::Board) }
+    let(:has_many) {
+      Trello::AssociationFetcher::HasMany.new(board, 'cards', {filter: :all})
+    }
+
+    it 'has model_class attribute' do
+      expect(has_many.model).to eq(board)
+    end
+
+    it 'has name attribute' do
+      expect(has_many.name).to eq('cards')
+    end
+
+    it 'has options attribute' do
+      expect(has_many.options).to eq({filter: :all})
+    end
+  end
+
+  describe '.fetch' do
+    let(:board) { instance_double(Trello::Board) }
+    let(:params) { instance_double(Trello::AssociationFetcher::HasMany::Params) }
+    let(:fetch_result) { double('fetch result') }
+    let(:has_many_fetcher) {
+      Trello::AssociationFetcher::HasMany.new(board, 'cards', {filter: :all})
+    }
+
+    it 'return the result from HasMany::Fetch and HasMany::Params' do
+      expect(Trello::AssociationFetcher::HasMany::Params)
+        .to receive(:new)
+        .with(
+          association_owner: board,
+          association_name: 'cards',
+          association_options: { filter: :all },
+          filter: { a: 1 }
+        ).and_return(params)
+      expect(Trello::AssociationFetcher::HasMany::Fetch)
+        .to receive(:execute)
+        .with(params)
+        .and_return(fetch_result)
+
+      expect(has_many_fetcher.fetch(a: 1)).to eq(fetch_result)
+    end
+  end
+
+end

data/spec/unit/trello/association_fetcher/has_one/fetch_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationFetcher::HasOne::Fetch do
+
+  describe '.execute' do
+    let(:client) { instance_double(Trello::Client) }
+    let(:association_owner) { double('association_owner', client: client) }
+    let(:association_restful_id) { 1 }
+    let(:association_class) { double('association_class') }
+    let(:result) { double('result') }
+
+    let(:params) { instance_double('params',
+      association_owner: association_owner,
+      association_restful_name: association_restful_name,
+      association_restful_id: association_restful_id,
+      association_class: association_class
+    )}
+
+    context 'when association_restful_name exists' do
+      let(:association_restful_name) { 'organizations' }
+
+      before do
+        allow(Trello).to receive(:client).and_return(client)
+        allow(client)
+          .to receive(:find)
+          .with(association_restful_name, association_restful_id)
+          .and_return(result)
+      end
+
+      it 'return the result from Trello.client' do
+        expect(Trello::AssociationFetcher::HasOne::Fetch.execute(params)).to eq(result)
+      end
+    end
+
+    context 'when association_restful_name does not exist' do
+      let(:association_restful_name) { nil }
+
+      before do
+        allow(association_class)
+          .to receive(:find)
+          .with(association_restful_id)
+          .and_return(result)
+      end
+
+      it 'return the result from association_class' do
+        expect(Trello::AssociationFetcher::HasOne::Fetch.execute(params)).to eq(result)
+      end
+    end
+  end
+
+end

data/spec/unit/trello/association_fetcher/has_one/params_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationFetcher::HasOne::Params do
+
+  let(:params) { Trello::AssociationFetcher::HasOne::Params.new(
+    association_owner: association_owner,
+    association_name: association_name,
+    association_options: association_options,
+  )}
+
+  let(:association_owner) { double('owner', id: 1, organization_id: 9) }
+  let(:association_name) { 'organization' }
+  let(:association_options) { { using: :organization_id } }
+
+  describe 'association_class' do
+    context 'when explicit set :via in association_options' do
+      let(:association_options) { { via: Trello::Organization } }
+
+      it 'return the value under the :via key' do
+        expect(params.association_class).to eq(Trello::Organization)
+      end
+    end
+
+    context 'when does not set :via in association_options' do
+      before do
+        allow(Trello::AssociationInferTool)
+          .to receive(:infer_class_on_name)
+          .with(association_name)
+          .and_return(Trello::Organization)
+      end
+
+      it 'return association_class use AssociationInferTool' do
+        expect(params.association_class).to eq(Trello::Organization)
+      end
+    end
+  end
+
+  describe 'association_owner' do
+    it 'return association_owner directly' do
+      expect(params.association_owner).to eq(association_owner)
+    end
+  end
+
+  describe 'association_restful_name' do
+    context 'when explicit set :path in association_options' do
+      let(:association_options) { { path: :organizations } }
+
+      it 'return :path directly' do
+        expect(params.association_restful_name).to eq(:organizations)
+      end
+    end
+
+    context 'when does not set :path in association_options' do
+      let(:association_options) { {} }
+
+      it 'return nil' do
+        expect(params.association_restful_name).to eq(nil)
+      end
+    end
+  end
+
+  describe 'association_restful_id' do
+    context 'when explicit set :using in association_options' do
+      let(:association_options) { { using: :organization_id } }
+
+      it 'return the result from association_owner.<using> directly' do
+        expect(params.association_restful_id).to eq(9)
+      end
+    end
+
+    context 'when does not set :using in association_options' do
+      let(:association_options) { {} }
+
+      it 'return the result from association_owner.id directly' do
+        expect(params.association_restful_id).to eq(1)
+      end
+    end
+  end
+
+
+end

data/spec/unit/trello/association_fetcher/has_one_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationFetcher::HasOne do
+
+  describe '#new' do
+    let(:board) { instance_double(Trello::Board) }
+    let(:has_one) {
+      Trello::AssociationFetcher::HasOne.new(board, 'organization', { using: :test_id })
+    }
+
+    it 'has model attribute' do
+      expect(has_one.model).to eq(board)
+    end
+
+    it 'has name attribute' do
+      expect(has_one.name).to eq('organization')
+    end
+
+    it 'has options attribute' do
+      expect(has_one.options).to eq({ using: :test_id })
+    end
+  end
+
+  describe '.fetch' do
+    let(:board) { instance_double(Trello::Board) }
+    let(:params) { instance_double(Trello::AssociationFetcher::HasOne::Params) }
+    let(:fetch_result) { double('fetch result') }
+    let(:has_one_fetcher) {
+      Trello::AssociationFetcher::HasOne.new(board, 'organization', { using: :test_id })
+    }
+
+    it 'return result from HasOne::Fetch and HasOne::Params' do
+      expect(Trello::AssociationFetcher::HasOne::Params)
+        .to receive(:new)
+        .with(
+          association_owner: board,
+          association_name: 'organization',
+          association_options: { using: :test_id }
+        ).and_return(params)
+      expect(Trello::AssociationFetcher::HasOne::Fetch)
+        .to receive(:execute)
+        .with(params)
+        .and_return(fetch_result)
+
+      expect(has_one_fetcher.fetch).to eq(fetch_result)
+    end
+  end
+
+end

data/spec/unit/trello/association_infer_tool_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationInferTool do
+
+  describe '.infer_restful_resource_on_class' do
+    let(:infer) { lambda { |klass|
+      Trello::AssociationInferTool.infer_restful_resource_on_class(klass)
+     } }
+
+    it 'can infer boards on Trello::Board' do
+      expect(infer.call(Trello::Board)).to eq('boards')
+    end
+
+    it 'can infer cards on Trello::Card' do
+      expect(infer.call(Trello::Card)).to eq('cards')
+    end
+
+    it 'can infer members on Trello::Member' do
+      expect(infer.call(Trello::Member)).to eq('members')
+    end
+  end
+
+  describe '.infer_class_on_name' do
+    let(:infer) { lambda { |association_name|
+      Trello::AssociationInferTool.infer_class_on_name(association_name)
+     } }
+
+    it 'can infer Trello::Board on boards' do
+      expect(infer.call('boards')).to eq(Trello::Board)
+    end
+
+    it 'can infer Trello::Card on cards' do
+      expect(infer.call('cards')).to eq(Trello::Card)
+    end
+
+    it 'can infer Trello::Member on members' do
+      expect(infer.call('members')).to eq(Trello::Member)
+    end
+  end
+
+end

data/spec/unit/trello/basic_data_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+RSpec.describe Trello::BasicData do
+
+  describe '.register_attributes' do
+    around do |example|
+      module Trello
+        class FakeCard < BasicData
+        end
+      end
+
+      example.run
+
+      Trello.send(:remove_const, 'FakeCard')
+    end
+
+    it 'call execute on RegisterAttributes' do
+      expect(Trello::RegisterAttributes)
+        .to receive(:execute)
+        .with(Trello::FakeCard, [:id, :name, :desc], [:id, :name])
+
+      Trello::FakeCard.class_eval do
+        register_attributes :id, :name, :desc, readonly: [:id, :name]
+      end
+    end
+  end
+
+  describe '.many' do
+    let(:association_name) { 'cards' }
+    let(:association_options) { { test: 'test' } }
+
+    it 'call build on AssociationBuilder::HasMany' do
+      expect(AssociationBuilder::HasMany)
+        .to receive(:build)
+        .with(Trello::BasicData, association_name, association_options)
+
+      Trello::BasicData.many(association_name, association_options)
+    end
+  end
+
+  describe '.one' do
+    let(:association_name) { 'card' }
+    let(:association_options) { { path: 'test' } }
+
+    it 'call build on AssociationBuilder::HasOne' do
+      expect(AssociationBuilder::HasOne)
+        .to receive(:build)
+        .with(Trello::BasicData, association_name, association_options)
+
+      Trello::BasicData.one(association_name, association_options)
+    end
+  end
+
+end

data/spec/unit/trello/card_spec.rb

@@ -0,0 +1,103 @@
+require 'spec_helper'
+
+RSpec.describe Trello::Card do
+
+  describe '.path_name' do
+    specify { expect(Trello::Card.path_name).to eq('card') }
+  end
+
+  describe '#closed?' do
+    specify { expect(Trello::Card.new('closed' => true).closed?).to eq(true) }
+    specify { expect(Trello::Card.new('closed' => false).closed?).to eq(false) }
+  end
+
+  describe '#close' do
+    let(:card) { Trello::Card.new('closed' => false) }
+
+    it 'can mark card as closed' do
+      card.close
+      expect(card.closed).to eq(true)
+    end
+  end
+
+  describe 'close!' do
+    let(:card) { Trello::Card.new('closed' => false) }
+
+    it 'will call save' do
+      expect(card).to receive(:save)
+      card.close!
+    end
+  end
+
+  describe 'valid?' do
+    let(:card) { Trello::Card.new('name' => name, 'idList' => list_id) }
+
+    context 'when name is nil' do
+      let(:name) { nil }
+      let(:list_id) { 1 }
+
+      specify { expect(card.valid?).to eq(false) }
+    end
+
+    context 'when list_id is nil' do
+      let(:name) { 'Card Name' }
+      let(:list_id) { nil }
+
+      specify { expect(card.valid?).to eq(false) }
+    end
+
+    context "when name and list_id both aren't nil" do
+      let(:name) { 'Card' }
+      let(:list_id) { 1 }
+
+      specify { expect(card.valid?).to eq(true) }
+    end
+  end
+
+  describe '#move_to_list_on_any_board' do
+    let(:card) { Trello::Card.new(board_id: 'board-aaa') }
+    let(:move_to_list_on_any_board) { card.move_to_list_on_any_board('listid') }
+
+    let(:board) { Trello::Board.new(id: 'board-aaa') }
+    let(:target_list) { Trello::List.new(board_id: target_board_id) }
+
+    before do
+      allow(Trello::List).to receive(:find).with('listid').and_return(target_list)
+      allow(card).to receive(:board).and_return(board)
+    end
+
+    context 'when target list is in the same board' do
+      let(:target_board_id) { 'board-aaa' }
+
+      it 'call #move_to_list on card' do
+        expect(card).to receive(:move_to_list).with('listid')
+
+        move_to_list_on_any_board
+      end
+    end
+
+    context 'when target list is in a different board' do
+      let(:target_board_id) { 'board-bbb' }
+      let(:target_board) { Trello::Board.new(id: 'board-bbb') }
+
+      before { allow(Trello::Board).to receive(:find).with('board-bbb').and_return(target_board) }
+
+      it 'call #move_to_board on card' do
+        expect(card).to receive(:move_to_board).with(target_board, target_list)
+
+        move_to_list_on_any_board
+      end
+    end
+  end
+
+  describe '#created_at' do
+    it 'can get created_at from card id' do
+      card = Trello::Card.new('id' => '5e95d1b4f43f9a06497f17f7')
+      expect(card.created_at).to eq(Time.new(2020, 4, 14, 15, 7, 32, '+00:00'))
+
+      card = Trello::Card.new('id' => '5e94ee7df8784d61ee48319e')
+      expect(card.created_at).to eq(Time.new(2020, 4, 13, 22, 58, 05, '+00:00'))
+    end
+  end
+
+end

data/spec/webhook_spec.rb

@@ -106,5 +106,25 @@ module Trello
         expect(webhook).to be_activated
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'description' => 'description',
+          'idModel' => 'id_model',
+          'callbackURL' => 'callback_url',
+          'active' => 'active'
+        }
+
+        webhook = Webhook.new(expected)
+
+        webhook.update_fields({})
+
+        expected.each do |key, value|
+          expect(webhook.send(value)).to eq expected[key]
+        end
+      end
+    end
   end
 end