ruby-trello 2.0.0 → 2.3.1

data/spec/integration/card/move_to_board_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::Card#move_to_board' do
+  include IntegrationHelpers
+
+  before { setup_trello }
+
+  it 'can move a card to another board without specific the target list' do
+    VCR.use_cassette('can_move_a_card_to_another_board_without_specific_list') do
+      board = Trello::Board.find('5e94ee7357ac8a3edc2b2145')
+      card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+      response = card.move_to_board(board)
+
+      expect(response.code).to eq(200)
+      body = JSON.parse(response.body)
+      expect(body['id']).to eq('5e95d1b4f43f9a06497f17f7')
+      expect(body['idBoard']).to eq('5e94ee7357ac8a3edc2b2145')
+      expect(body['idList']).not_to be_nil
+    end
+  end
+
+  it 'can move a card to another board with a specific target list' do
+    VCR.use_cassette('can_move_a_card_to_another_board_with_specific_list') do
+      board = Trello::Board.find('5e94f5ded016b22c2437c13c')
+      list = Trello::List.find('5e95d1b07f2ff83927319128')
+      card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+      response = card.move_to_board(board, list)
+
+      expect(response.code).to eq(200)
+      body = JSON.parse(response.body)
+      expect(body['id']).to eq('5e95d1b4f43f9a06497f17f7')
+      expect(body['idBoard']).to eq('5e94f5ded016b22c2437c13c')
+      expect(body['idList']).to eq('5e95d1b07f2ff83927319128')
+    end
+  end
+end

data/spec/integration/card/move_to_list_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::Card#move_to_list' do
+  include IntegrationHelpers
+
+  before { setup_trello }
+
+  it 'can move a card to another list' do
+    VCR.use_cassette('can_move_a_card_to_another_list') do
+      list = Trello::List.find('5e95d1b2342114318522f3f1')
+      card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+      response = card.move_to_list(list)
+
+      expect(response.code).to eq(200)
+      body = JSON.parse(response.body)
+      expect(body['idList']).to eq('5e95d1b2342114318522f3f1')
+      expect(body['idList']).not_to eq(card.list_id)
+    end
+  end
+end

data/spec/integration/card/remove_member_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::Card#remove_member' do
+  include IntegrationHelpers
+
+  before { setup_trello }
+
+  it 'can remove a member to a card' do
+    VCR.use_cassette('can_remove_a_member_from_a_card') do
+      member = Trello::Member.new('id' => '5e679b808e6e8828784b30e1')
+      card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+      response = card.remove_member(member)
+
+      expect(response.code).to eq(200)
+      body = JSON.parse(response.body)
+      expect(body).to be_a(Array)
+    end
+  end
+end

data/spec/integration/card/save_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+RSpec.describe 'Trell::Card.create' do
+  include IntegrationHelpers
+
+  before { setup_trello }
+
+  it 'can success create the card' do
+    VCR.use_cassette('can_success_create_a_card') do
+      card = Trello::Card.new(
+        name: 'Test Trello::Card.create',
+        list_id: '5e93bac014d40e501ee46b8d',
+        desc: 'testing card create',
+        member_ids: '5e679b808e6e8828784b30e1',
+        card_labels: '5e93ba987669b2254983d69d,5e93ba987669b2254983d69e',
+        due: '2020-12-22T01:59:00.000Z',
+        due_complete: false,
+        pos: 'top',
+        source_card_id: '5e93ba665c58c44a46cb2ef9',
+        source_card_properties: 'comments'
+      )
+      card.save
+      expect(card).to be_a(Trello::Card)
+
+      expect(card.name).to eq('Test Trello::Card.create')
+      expect(card.list_id).to eq('5e93bac014d40e501ee46b8d')
+      expect(card.desc).to eq('testing card create')
+      expect(card.member_ids).to eq(['5e679b808e6e8828784b30e1'])
+      expect(card.labels.count).to eq(2)
+      expect(card.due).to eq(Time.new(2020, 12, 22, 1, 59, 0, '+00:00'))
+      expect(card.due_complete).to eq(false)
+      expect(card.pos).not_to be_nil
+      expect(card.source_card_id).to eq('5e93ba665c58c44a46cb2ef9')
+      expect(card.source_card_properties).to eq('comments')
+
+      expect(card.id).not_to be_nil
+      expect(card.short_id).not_to be_nil
+      expect(card.closed).not_to be_nil
+      expect(card.url).not_to be_nil
+      expect(card.short_url).not_to be_nil
+      expect(card.board_id).not_to be_nil
+      expect(card.last_activity_date).not_to be_nil
+      expect(card.card_labels).not_to be_nil
+      expect(card.badges).not_to be_nil
+      expect(card.card_members).to be_nil # default not return members
+      expect(card.cover_image_id).to be_nil # only exist when the care use a custom cover image
+    end
+  end
+
+  it 'can success update a card' do
+    VCR.use_cassette('can_success_upate_a_card') do
+      card = Trello::Card.find('5e946acb3cc40322434c214e')
+      expect(card.name).to eq('C2')
+      card.name = 'C2-changed'
+      card.save
+      expect(card.name).to eq('C2-changed')
+    end
+  end
+
+end
+

data/spec/integration/card/update!_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+RSpec.describe 'Trell::Card.update!' do
+  include IntegrationHelpers
+
+  before { setup_trello }
+
+  it 'can update! a card' do
+    VCR.use_cassette('can_success_update_bong_a_card') do
+      card = Trello::Card.find('5e94fd9443f25a7263b165d0')
+      expect(card.name).to eq('C1')
+      expect(card.desc).to eq('')
+      expect(card.member_ids).to eq([])
+      expect(card.card_labels).to eq([])
+      expect(card.due).to be_nil
+      expect(card.due_complete).to eq(false)
+      expect(card.list_id).to eq('5e94eafdf553d46ea525faa7')
+
+      card.name = 'Test Trello::Card.update!'
+      card.list_id = '5e94fa1248c5e41ad0464a7f'
+      card.desc =  'testing card update!'
+      card.member_ids = '5e679b808e6e8828784b30e1'
+      card.card_labels = '5e94eaf37669b225494161c7'
+      card.due = '2020-12-22T01:59:00.000Z'
+      card.due_complete = false
+      card.pos = 'top'
+
+      card.update!
+
+      expect(card.name).to eq('Test Trello::Card.update!')
+      expect(card.list_id).to eq('5e94fa1248c5e41ad0464a7f')
+      expect(card.desc).to eq('testing card update!')
+      expect(card.member_ids).to eq(['5e679b808e6e8828784b30e1'])
+      expect(card.card_labels.count).to eq(1)
+      expect(card.due).to eq(Time.new(2020, 12, 22, 1, 59, 0, '+00:00'))
+      expect(card.due_complete).to eq(false)
+      expect(card.pos).not_to be_nil
+
+      expect(card.id).not_to be_nil
+      expect(card.short_id).not_to be_nil
+      expect(card.closed).not_to be_nil
+      expect(card.url).not_to be_nil
+      expect(card.short_url).not_to be_nil
+      expect(card.board_id).not_to be_nil
+      expect(card.last_activity_date).not_to be_nil
+      expect(card.card_labels).not_to be_nil
+      expect(card.badges).not_to be_nil
+      expect(card.card_members).to be_nil # default not return members
+      expect(card.cover_image_id).to be_nil # only exist when the care use a custom cover image
+    end
+  end
+
+end

data/spec/integration/card/vote_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+RSpec.describe 'Trell::Card#upvote #remove_upvote' do
+  include IntegrationHelpers
+
+  before { setup_trello }
+
+  describe '#upvote' do
+    it 'can success upvote on a card' do
+      VCR.use_cassette('can_upvote_on_a_card') do
+        card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+
+        expect(card.voters.count).to eq(0)
+        card.upvote
+        expect(card.voters.count).to eq(1)
+      end
+    end
+
+    it "won't raise error when already voted" do
+      VCR.use_cassette('revote_on_a_card') do
+        card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+
+        expect(card.voters.count).to eq(1)
+        expect { card.upvote }.not_to raise_error(Trello::Error)
+        expect(card.voters.count).to eq(1)
+      end
+    end
+  end
+
+  describe '#remove_upvote' do
+    it 'can success remove an upvote on a card' do
+      VCR.use_cassette('can_remove_an_upvote_on_a_card') do
+        card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+
+        expect(card.voters.count).to eq(1)
+        card.remove_upvote
+        expect(card.voters.count).to eq(0)
+      end
+    end
+
+    it "won't raise error when haven't voted" do
+      VCR.use_cassette('remove_upvote_on_a_card_when_have_not_voted') do
+        card = Trello::Card.find('5e95d1b4f43f9a06497f17f7')
+
+        expect(card.voters.count).to eq(0)
+        expect { card.remove_upvote }.not_to raise_error(Trello::Error)
+      end
+    end
+  end
+end

data/spec/integration/custom_field_item_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+RSpec.describe 'CustomFieldItem API' do
+
+  before do
+    Trello.configure do |config|
+      config.developer_public_key = ENV['TRELLO_DEVELOPER_PUBLIC_KEY'] || 'developerpublickey'
+      config.member_token = ENV['TRELLO_MEMBER_TOKEN'] || 'membertoken'
+    end
+  end
+
+  describe '#save' do
+    context 'when id does not exists' do
+      let(:custom_field_item) {
+        Trello::CustomFieldItem.new(
+          model_id: '5e679be5d53dfa748f41d775',
+          custom_field_id: '5e68e8e87c16bf75894df21a',
+        )
+      }
+
+      it 'update the custom field' do
+        VCR.use_cassette('custom_field_item_save_1') do
+          custom_field_item.value = { text: 'cool' }
+          custom_field_item.save
+
+          expect(custom_field_item.id).not_to be_nil
+        end
+      end
+    end
+
+    context 'when id exists' do
+      let(:custom_field_item) {
+        card = Trello::Card.find('5e679be5d53dfa748f41d775')
+        card.custom_field_items.find { |item| item.id == '5e68e8f02f77a28502efd036' }
+      }
+
+      it 'update the custom field' do
+        VCR.use_cassette('custom_field_item_save_2') do
+          custom_field_item.value = { text: 'nice' }
+
+          expect { custom_field_item.save }.not_to raise_error
+        end
+      end
+    end
+  end
+
+end

data/spec/item_spec.rb

@@ -51,5 +51,25 @@ module Trello
         it { expect(item).not_to be_complete }
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'name' => 'name',
+          'type' => 'type',
+          'state' => 'state',
+          'pos' => 'pos'
+        }
+
+        item = Item.new(expected)
+
+        item.update_fields({})
+
+        expected.each do |key, value|
+          expect(item.send(value)).to eq expected[key]
+        end
+      end
+    end
   end
 end

data/spec/label_spec.rb

@@ -181,5 +181,104 @@ module Trello
         expect(label.board).to_not be_nil
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'name' => 'name',
+          'color' => 'color',
+          'idBoard' => 'board_id',
+          'uses' => 'uses'
+        }
+
+        label = Label.new(expected)
+
+        label.update_fields({})
+
+        expected.each do |key, value|
+          expect(label.send(value)).to eq expected[key]
+        end
+      end
+    end
+
+    describe '#update_fields' do
+      let(:label_detail) {{
+        'id' => 'id',
+        'name' => 'name',
+        'color' => 'color',
+        'idBoard' => 'board_id',
+        'uses' => 'uses'
+      }}
+      let(:label) { Label.new(label_detail) }
+
+      context 'when the fields argument is empty' do
+        let(:fields) { {} }
+
+        it 'card does not set any fields' do
+          label.update_fields(fields)
+
+          expect(label.id).to eq label_detail['id']
+          expect(label.name).to eq label_detail['name']
+          expect(label.color).to eq label_detail['color']
+          expect(label.board_id).to eq label_detail['idBoard']
+          expect(label.uses).to eq label_detail['uses']
+        end
+      end
+
+      context 'when the fields argument has at least one field' do
+        context 'and the field does changed' do
+          let(:fields) { { name: 'Awesome Name' } }
+
+          it 'label does set the changed fields' do
+            label.update_fields(fields)
+
+            expect(label.name).to eq('Awesome Name')
+          end
+
+          it 'label has been mark as changed' do
+            label.update_fields(fields)
+
+            expect(label.changed?).to be_truthy
+          end
+        end
+
+        context "and the field doesn't changed" do
+          let(:fields) { { name: label_detail['name'] } }
+
+          it "label attributes doesn't changed" do
+            label.update_fields(fields)
+
+            expect(label.name).to eq(label_detail['name'])
+          end
+
+          it "label hasn't been mark as changed", pending: true do
+            label.update_fields(fields)
+
+            expect(label.changed?).to be_falsy
+          end
+        end
+
+        context "and the field isn't a correct attributes of the label" do
+          let(:fields) { { abc: 'abc' } }
+
+          it "label attributes doesn't changed" do
+            label.update_fields(fields)
+
+            expect(label.id).to eq label_detail['id']
+            expect(label.name).to eq label_detail['name']
+            expect(label.color).to eq label_detail['color']
+            expect(label.board_id).to eq label_detail['idBoard']
+            expect(label.uses).to eq label_detail['uses']
+          end
+
+          it "label hasn't been mark as changed" do
+            label.update_fields(fields)
+
+            expect(label.changed?).to be_falsy
+          end
+        end
+      end
+    end
   end
 end

data/spec/list_spec.rb

@@ -228,5 +228,26 @@ module Trello
         list.close!
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'name' => 'name',
+          'closed' => 'closed',
+          'idBoard' => 'board_id',
+          'pos' => 'pos',
+          'idListSource' => 'source_list_id'
+        }
+
+        label = List.new(expected)
+
+        label.update_fields({})
+
+        expected.each do |key, value|
+          expect(label.send(value)).to eq expected[key]
+        end
+      end
+    end
   end
 end