ruby-trello 2.0.0 → 2.3.1

data/spec/member_spec.rb

@@ -132,5 +132,28 @@ module Trello
         expect { member.id = '42' }.to raise_error NoMethodError
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'fullName' => 'full_name',
+          'email' => 'email',
+          'username' => 'username',
+          'initials' => 'initials',
+          'avatarHash' => 'avatar_id',
+          'bio' => 'bio',
+          'url' => 'url'
+        }
+
+        member = Member.new(expected)
+
+        member.update_fields({})
+
+        expected.each do |key, value|
+          expect(member.send(value)).to eq expected[key]
+        end
+      end
+    end
   end
 end

data/spec/notification_spec.rb

@@ -118,5 +118,26 @@ module Trello
         expect(notification.member_creator_id).to eq notification_details['idMemberCreator']
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'unread' => 'unread',
+          'type' => 'type',
+          'date' => 'date',
+          'data' => 'data',
+          'idMemberCreator' => 'member_creator_id'
+        }
+
+        notification = Notification.new(expected)
+
+        notification.update_fields({})
+
+        expected.each do |key, value|
+          expect(notification.send(value)).to eq expected[key]
+        end
+      end
+    end
   end
 end

data/spec/organization_spec.rb

@@ -40,6 +40,32 @@ module Trello
         expect(organization.actions.count).to be > 0
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'name' => 'name',
+          'displayName' => 'display_name',
+          'desc' => 'description',
+          'url' => 'url',
+          'invited' => 'invited',
+          'website' => 'website',
+          'logoHash' => 'logo_hash',
+          'billableMemberCount' => 'billable_member_count',
+          'activeBillableMemberCount' => 'active_billable_member_count',
+          'memberships' => 'memberships'
+        }
+
+        organization = Organization.new(expected)
+
+        organization.update_fields({})
+
+        expected.each do |key, value|
+          expect(organization.send(value)).to eq expected[key]
+        end
+      end
+    end
   end
 end
 

data/spec/spec_helper.rb

@@ -1,36 +1,46 @@
-require 'rubygems'
+require 'bundler/setup'
+require 'dotenv/load'
+require 'trello'
+require 'webmock/rspec'
+require 'stringio'
+require 'vcr'
 
-unless defined? Rubinius
-  require 'simplecov'
-  SimpleCov.start
-end
+require 'pry-byebug' if RUBY_ENGINE != 'jruby'
 
-begin
-  require 'pry-byebug'
-rescue LoadError
-end
+VCR.configure do |config|
+  config.cassette_library_dir = 'spec/cassettes'
+  config.hook_into :webmock
 
-# Set up gems listed in the Gemfile.
-begin
-  ENV['BUNDLE_GEMFILE'] = File.expand_path('../Gemfile', File.dirname(__FILE__))
-  require 'bundler'
-  Bundler.setup
-rescue Bundler::GemNotFound => e
-  STDERR.puts e.message
-  STDERR.puts 'Try running `bundle install`.'
-  exit!
-end
+  config.filter_sensitive_data('DEVELOPER_PUBLIC_KEY') do |interaction|
+    CGI.parse(URI.parse(interaction.request.uri).query)['key'].first
+  end
+  config.filter_sensitive_data('MEMBER_TOKEN') do |interaction|
+    CGI.parse(URI.parse(interaction.request.uri).query)['token'].first
+  end
+  config.filter_sensitive_data('set_cookie_dsc') do |interaction|
+    set_cookie_headers = interaction.response.headers['Set-Cookie']
 
-Bundler.require(:spec)
+    if set_cookie_headers
+      set_cookie_headers.first.scan(/dsc=(\w+)/).flatten.first
+    end
+  end
 
-require 'trello'
-require 'webmock/rspec'
-require 'stringio'
+  uri_without_credentials_matcher = lambda do |match_request, coming_request|
+    without_public_key = -> (uri) { uri.sub(/key=\w+/, 'key=DEVELOPER_PUBLIC_KEY') }
+    without_member_token = -> (uri) { uri.sub(/token=\w+/, 'token=MEMBER_TOKEN') }
+    without_credentials = -> (request) { without_public_key.call(without_member_token.call(request.uri)) }
+
+    without_credentials.call(match_request) == without_credentials.call(coming_request)
+  end
+
+  config.default_cassette_options[:match_requests_on] = [:method, uri_without_credentials_matcher]
+end
 
 Trello.logger = Logger.new(StringIO.new)
 
 RSpec.configure do |rspec|
   rspec.filter_run_excluding broken: true
+  rspec.filter_run_when_matching focus: true
 
   rspec.before :each do
     Trello.reset!
@@ -42,6 +52,21 @@ RSpec.configure do |rspec|
     example.run
     $VERBOSE = verbose
   end
+
+  rspec.failure_color = :magenta
+  rspec.tty = true
+  rspec.color = true
+end
+
+RSpec::Expectations.configuration.on_potential_false_positives = :nothing
+
+module IntegrationHelpers
+  def setup_trello
+    Trello.configure do |config|
+      config.developer_public_key = ENV['TRELLO_DEVELOPER_PUBLIC_KEY'] || 'developerpublickey'
+      config.member_token = ENV['TRELLO_MEMBER_TOKEN'] || 'membertoken'
+    end
+  end
 end
 
 module Helpers
@@ -425,6 +450,54 @@ module Helpers
     JSON.generate(label_name_details)
   end
 
+  def custom_fields_details
+    [
+      {
+        'id' => 'abcdef123456789123456789',
+        'name' => 'Priority',
+        'idModel' => 'abc123',
+        'type' => 'checkbox',
+        'pos' => 123,
+        'modelType' => 'board'
+      },
+      {
+        id: 'abcdef123456789123456789',
+        name: 'Priority',
+        model_id: 'abc123',
+        type: 'checkbox',
+        pos: 123,
+        model_type: 'board'
+      }
+    ]
+  end
+
+  def custom_fields_payload
+    JSON.generate(custom_fields_details.first)
+  end
+
+  def custom_field_option_details
+    {
+      '_id'   => 'abcdefgh12345678',
+      'value' => {'text' => 'Low Priority'},
+      'color' => 'green',
+      'pos' => 1
+    }
+  end
+
+  def custom_field_item_details
+    {
+      'id' => 'abcdefg1234567',
+      'value' => { 'text' => 'hello world' },
+      'idModel' => 'abcdef123456789123456789',
+      'idCustomField' => 'abcdef123456789123456789',
+      'modelType' => 'card'
+    }
+  end
+
+  def custom_field_items_payload
+    JSON.generate(custom_field_item_details)
+  end
+
   def webhooks_payload
     JSON.generate(webhooks_details)
   end

data/spec/token_spec.rb

@@ -66,5 +66,24 @@ module Trello
         expect(token.member).to eq Member.find('abcdef123456789123456789')
       end
     end
+
+    describe "#update_fields" do
+      it "does not set any fields when the fields argument is empty" do
+        expected = {
+          'id' => 'id',
+          'idMember' => 'member_id',
+          'permissions' => 'permissions',
+          'webhooks' => 'webhooks'
+        }
+
+        token = Token.new(expected)
+
+        token.update_fields({})
+
+        expected.each do |key, value|
+          expect(token.send(value)).to eq expected[key]
+        end
+      end
+    end
   end
 end

data/spec/unit/trello/association_builder/has_many_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationBuilder::HasMany do
+
+  describe '.build' do
+    around do |example|
+      class FakeBoard; end
+
+      example.run
+
+      Object.send(:remove_const, 'FakeBoard')
+    end
+
+    it 'build has many finder method' do
+      Trello::AssociationBuilder::HasMany.build(FakeBoard, 'boards', {})
+
+      expect(FakeBoard.new.respond_to?(:boards)).to eq(true)
+    end
+
+    it 'the finder method return result from Trello::AssociationFetcher' do
+      fake_board = FakeBoard.new
+      has_many_fetcher = instance_double(Trello::AssociationFetcher::HasMany)
+      allow(Trello::AssociationFetcher::HasMany)
+        .to receive(:new)
+        .with(fake_board, 'boards', {})
+        .and_return(has_many_fetcher)
+
+      result = double('result')
+      allow(has_many_fetcher).to receive(:fetch).with(a: 1, b: 2).and_return(result)
+
+      Trello::AssociationBuilder::HasMany.build(FakeBoard, 'boards', {})
+      expect(fake_board.boards(a: 1, b: 2)).to eq(result)
+    end
+  end
+
+end

data/spec/unit/trello/association_builder/has_one_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationBuilder::HasOne do
+
+  describe '.build' do
+    around do |example|
+      class FakeBoard; end
+
+      example.run
+
+      Object.send(:remove_const, 'FakeBoard')
+    end
+
+    it 'build has one finder method' do
+      Trello::AssociationBuilder::HasOne.build(FakeBoard, 'organization', {})
+
+      expect(FakeBoard.new.respond_to?(:organization)).to eq(true)
+    end
+
+    it 'the finder method return result from Trello::AssociationFetcher' do
+      fake_board = FakeBoard.new
+      has_one_fetcher = instance_double(Trello::AssociationFetcher::HasOne)
+      allow(Trello::AssociationFetcher::HasOne)
+        .to receive(:new)
+        .with(fake_board, 'organization', {})
+        .and_return(has_one_fetcher)
+
+      result = double('result')
+      allow(has_one_fetcher).to receive(:fetch).and_return(result)
+
+      Trello::AssociationBuilder::HasOne.build(FakeBoard, 'organization', {})
+      expect(fake_board.organization).to eq(result)
+    end
+  end
+
+end

data/spec/unit/trello/association_fetcher/has_many/fetch_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationFetcher::HasMany::Fetch do
+
+  describe '.execute' do
+    let(:client) { instance_double(Trello::Client) }
+    let(:association_class) { double('Association Class') }
+    let(:association_owner) { double('association_owner', client: client) }
+    let(:fetch_path) { '/test' }
+    let(:filter_params) { { a: 1 } }
+    let(:resources) { double('resources') }
+    let(:result) { double('result') }
+
+    let(:params) { instance_double('params',
+      association_class: association_class,
+      association_owner: association_owner,
+      fetch_path: fetch_path,
+      filter_params: filter_params
+    ) }
+
+    before do
+      allow(Trello).to receive(:client).and_return(client)
+      allow(client)
+        .to receive(:find_many)
+        .with(association_class, fetch_path, filter_params)
+        .and_return(resources)
+      allow(Trello::MultiAssociation)
+        .to receive(:new)
+        .with(association_owner, resources)
+        .and_return(double('multi-association', proxy: result))
+    end
+
+    it 'return the result from Trello.client and MultiAssociation' do
+      expect(Trello::AssociationFetcher::HasMany::Fetch.execute(params)).to eq(result)
+    end
+  end
+
+end

data/spec/unit/trello/association_fetcher/has_many/params_spec.rb

@@ -0,0 +1,107 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationFetcher::HasMany::Params do
+
+  let(:params) { Trello::AssociationFetcher::HasMany::Params.new(
+    association_owner: association_owner,
+    association_name: association_name,
+    association_options: association_options,
+    filter: filter
+  ) }
+
+  let(:association_owner) { double('owner', id: 1) }
+  let(:association_name) { 'cards' }
+  let(:association_options) { { filter: :all } }
+  let(:filter) { { a: 1 } }
+
+  describe '.association_class' do
+    context 'when explicit set :via in association_options' do
+      let(:association_options) { { via: Trello::Board } }
+
+      it 'return the value under the :via key' do
+        expect(params.association_class).to eq(Trello::Board)
+      end
+    end
+
+    context 'when does not set :via in association_options' do
+      before do
+        allow(Trello::AssociationInferTool)
+          .to receive(:infer_class_on_name)
+          .with(association_name)
+          .and_return(Trello::Card)
+      end
+
+      it 'return association_class use AssociationInferTool' do
+        expect(params.association_class).to eq(Trello::Card)
+      end
+    end
+  end
+
+  describe '.association_owner' do
+    it 'return association_owner directly' do
+      expect(params.association_owner).to eq(association_owner)
+    end
+  end
+
+  describe '.fetch_path' do
+    context 'when explicit set :in, :path in association_options' do
+      let(:association_options) { { in: 'boards', path: 'cards' } }
+
+      it 'use them to generate fetch_path - formula: ":in/owner_id/:path"' do
+        expect(params.fetch_path).to eq('/boards/1/cards')
+      end
+    end
+
+    context 'when does not set :in, :path in association_options' do
+      let(:association_owner) { double('owner', id: 1, class: Trello::Member) }
+      before do
+        allow(Trello::AssociationInferTool)
+          .to receive(:infer_restful_resource_on_class)
+          .with(Trello::Member)
+          .and_return('members')
+      end
+
+      it 'will generate fetch_path use AssociationInferTool' do
+        expect(params.fetch_path).to eq('/members/1/cards')
+      end
+    end
+  end
+
+  describe '.filter_params' do
+    context 'when filter and default_filer are both nil' do
+      let(:association_options) { nil }
+      let(:filter) { nil }
+
+      it 'return a empty hash' do
+        expect(params.filter_params).to eq({})
+      end
+    end
+
+    context 'when filter is nil' do
+      let(:association_options) { { filter: :all } }
+      let(:filter) { nil }
+
+      it 'return default filter' do
+        expect(params.filter_params).to eq({ filter: :all })
+      end
+    end
+
+    context 'when default filter is nil' do
+      let(:association_options) { nil }
+      let(:filter) { { a: 1 } }
+
+      it 'return filter' do
+        expect(params.filter_params).to eq({ a: 1 })
+      end
+    end
+
+    context 'when both filter and default_filter exists' do
+      let(:association_options) { { filter: :all } }
+      let(:filter) { { a: 1, filter: :open } }
+
+      it 'return the result from merge filter on default_filter' do
+        expect(params.filter_params).to eq({a: 1, filter: :open})
+      end
+    end
+  end
+end