rubocop 1.30.1 → 1.64.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (613) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +8 -6
  4. data/assets/output.css.erb +159 -0
  5. data/assets/output.html.erb +1 -160
  6. data/config/default.yml +584 -73
  7. data/config/obsoletion.yml +30 -1
  8. data/exe/rubocop +15 -7
  9. data/lib/rubocop/arguments_env.rb +17 -0
  10. data/lib/rubocop/arguments_file.rb +17 -0
  11. data/lib/rubocop/cache_config.rb +29 -0
  12. data/lib/rubocop/cached_data.rb +11 -3
  13. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +30 -9
  14. data/lib/rubocop/cli/command/execute_runner.rb +14 -9
  15. data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
  16. data/lib/rubocop/cli/command/lsp.rb +19 -0
  17. data/lib/rubocop/cli/command/show_docs_url.rb +2 -2
  18. data/lib/rubocop/cli/command/suggest_extensions.rb +61 -16
  19. data/lib/rubocop/cli.rb +70 -11
  20. data/lib/rubocop/comment_config.rb +60 -1
  21. data/lib/rubocop/config.rb +84 -28
  22. data/lib/rubocop/config_finder.rb +78 -0
  23. data/lib/rubocop/config_loader.rb +46 -68
  24. data/lib/rubocop/config_loader_resolver.rb +8 -8
  25. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  26. data/lib/rubocop/config_obsoletion/parameter_rule.rb +13 -1
  27. data/lib/rubocop/config_obsoletion.rb +15 -7
  28. data/lib/rubocop/config_validator.rb +16 -9
  29. data/lib/rubocop/cop/autocorrect_logic.rb +37 -14
  30. data/lib/rubocop/cop/badge.rb +9 -4
  31. data/lib/rubocop/cop/base.rb +181 -98
  32. data/lib/rubocop/cop/bundler/duplicated_gem.rb +2 -1
  33. data/lib/rubocop/cop/bundler/duplicated_group.rb +127 -0
  34. data/lib/rubocop/cop/bundler/gem_comment.rb +4 -4
  35. data/lib/rubocop/cop/bundler/gem_filename.rb +4 -4
  36. data/lib/rubocop/cop/bundler/gem_version.rb +5 -7
  37. data/lib/rubocop/cop/bundler/ordered_gems.rb +11 -3
  38. data/lib/rubocop/cop/commissioner.rb +19 -6
  39. data/lib/rubocop/cop/cop.rb +54 -34
  40. data/lib/rubocop/cop/corrector.rb +33 -13
  41. data/lib/rubocop/cop/correctors/alignment_corrector.rb +3 -3
  42. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +4 -8
  43. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +6 -14
  44. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +7 -4
  45. data/lib/rubocop/cop/correctors/line_break_corrector.rb +1 -1
  46. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +26 -10
  47. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +2 -7
  48. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +58 -0
  49. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +2 -2
  50. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +1 -1
  51. data/lib/rubocop/cop/documentation.rb +16 -6
  52. data/lib/rubocop/cop/exclude_limit.rb +1 -1
  53. data/lib/rubocop/cop/gemspec/dependency_version.rb +22 -26
  54. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +33 -18
  55. data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
  56. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +1 -1
  57. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +10 -2
  58. data/lib/rubocop/cop/gemspec/require_mfa.rb +21 -21
  59. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +5 -1
  60. data/lib/rubocop/cop/generator/require_file_injector.rb +3 -3
  61. data/lib/rubocop/cop/generator.rb +6 -3
  62. data/lib/rubocop/cop/internal_affairs/cop_description.rb +38 -12
  63. data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
  64. data/lib/rubocop/cop/internal_affairs/example_description.rb +46 -24
  65. data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
  66. data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +1 -1
  67. data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
  68. data/lib/rubocop/cop/internal_affairs/location_expression.rb +37 -0
  69. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +3 -1
  70. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +8 -6
  71. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +19 -20
  72. data/lib/rubocop/cop/internal_affairs/node_first_or_last_argument.rb +53 -0
  73. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +128 -38
  74. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -1
  75. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  76. data/lib/rubocop/cop/internal_affairs/processed_source_buffer_name.rb +42 -0
  77. data/lib/rubocop/cop/internal_affairs/redundant_expect_offense_arguments.rb +34 -0
  78. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +11 -3
  79. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  80. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  81. data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +11 -2
  82. data/lib/rubocop/cop/internal_affairs/redundant_source_range.rb +66 -0
  83. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  84. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -0
  85. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  86. data/lib/rubocop/cop/internal_affairs.rb +11 -0
  87. data/lib/rubocop/cop/layout/argument_alignment.rb +1 -1
  88. data/lib/rubocop/cop/layout/array_alignment.rb +1 -1
  89. data/lib/rubocop/cop/layout/block_alignment.rb +16 -12
  90. data/lib/rubocop/cop/layout/block_end_newline.rb +31 -9
  91. data/lib/rubocop/cop/layout/class_structure.rb +44 -27
  92. data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +2 -3
  93. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +2 -6
  94. data/lib/rubocop/cop/layout/comment_indentation.rb +4 -2
  95. data/lib/rubocop/cop/layout/dot_position.rb +1 -5
  96. data/lib/rubocop/cop/layout/empty_comment.rb +6 -4
  97. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +42 -9
  98. data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +14 -7
  99. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +28 -5
  100. data/lib/rubocop/cop/layout/empty_lines.rb +3 -1
  101. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +7 -2
  102. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  103. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -0
  104. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +2 -0
  105. data/lib/rubocop/cop/layout/end_alignment.rb +23 -3
  106. data/lib/rubocop/cop/layout/end_of_line.rb +4 -4
  107. data/lib/rubocop/cop/layout/extra_spacing.rb +12 -9
  108. data/lib/rubocop/cop/layout/first_argument_indentation.rb +15 -4
  109. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +44 -20
  110. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +35 -8
  111. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +51 -12
  112. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +36 -1
  113. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +57 -8
  114. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +52 -19
  115. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +1 -1
  116. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +12 -6
  117. data/lib/rubocop/cop/layout/heredoc_indentation.rb +12 -12
  118. data/lib/rubocop/cop/layout/indentation_style.rb +8 -3
  119. data/lib/rubocop/cop/layout/indentation_width.rb +9 -5
  120. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  121. data/lib/rubocop/cop/layout/leading_comment_space.rb +2 -2
  122. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +144 -0
  123. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +140 -0
  124. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +2 -0
  125. data/lib/rubocop/cop/layout/line_length.rb +8 -1
  126. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +31 -1
  127. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +1 -1
  128. data/lib/rubocop/cop/layout/multiline_block_layout.rb +4 -2
  129. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +29 -1
  130. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +39 -2
  131. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +20 -5
  132. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +77 -0
  133. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +2 -2
  134. data/lib/rubocop/cop/layout/redundant_line_break.rb +35 -13
  135. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +6 -6
  136. data/lib/rubocop/cop/layout/single_line_block_chain.rb +5 -0
  137. data/lib/rubocop/cop/layout/space_after_comma.rb +9 -1
  138. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  139. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +2 -2
  140. data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -3
  141. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +2 -2
  142. data/lib/rubocop/cop/layout/space_around_operators.rb +54 -22
  143. data/lib/rubocop/cop/layout/space_before_block_braces.rb +22 -11
  144. data/lib/rubocop/cop/layout/space_before_first_arg.rb +2 -2
  145. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +2 -2
  146. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +22 -20
  147. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -0
  148. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +32 -12
  149. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +31 -4
  150. data/lib/rubocop/cop/layout/space_inside_parens.rb +3 -3
  151. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +34 -0
  152. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +1 -1
  153. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +10 -6
  154. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +5 -4
  155. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +6 -1
  156. data/lib/rubocop/cop/layout/trailing_whitespace.rb +13 -6
  157. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  158. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  159. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +40 -8
  160. data/lib/rubocop/cop/lint/ambiguous_operator.rb +4 -0
  161. data/lib/rubocop/cop/lint/assignment_in_condition.rb +17 -7
  162. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +2 -2
  163. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  164. data/lib/rubocop/cop/lint/constant_resolution.rb +5 -1
  165. data/lib/rubocop/cop/lint/debugger.rb +69 -34
  166. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +66 -110
  167. data/lib/rubocop/cop/lint/deprecated_constants.rb +8 -1
  168. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +1 -1
  169. data/lib/rubocop/cop/lint/duplicate_branch.rb +0 -2
  170. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +2 -1
  171. data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
  172. data/lib/rubocop/cop/lint/duplicate_match_pattern.rb +122 -0
  173. data/lib/rubocop/cop/lint/duplicate_methods.rb +49 -19
  174. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +55 -11
  175. data/lib/rubocop/cop/lint/duplicate_require.rb +1 -1
  176. data/lib/rubocop/cop/lint/else_layout.rb +3 -7
  177. data/lib/rubocop/cop/lint/empty_block.rb +4 -8
  178. data/lib/rubocop/cop/lint/empty_class.rb +3 -1
  179. data/lib/rubocop/cop/lint/empty_conditional_body.rb +110 -2
  180. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  181. data/lib/rubocop/cop/lint/erb_new_arguments.rb +15 -16
  182. data/lib/rubocop/cop/lint/float_comparison.rb +10 -0
  183. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -7
  184. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +2 -1
  185. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +16 -18
  186. data/lib/rubocop/cop/lint/identity_comparison.rb +0 -1
  187. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  188. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +5 -3
  189. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  190. data/lib/rubocop/cop/lint/inherit_exception.rb +9 -0
  191. data/lib/rubocop/cop/lint/interpolation_check.rb +5 -4
  192. data/lib/rubocop/cop/lint/it_without_arguments_in_block.rb +56 -0
  193. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +1 -1
  194. data/lib/rubocop/cop/lint/literal_as_condition.rb +5 -0
  195. data/lib/rubocop/cop/lint/literal_assignment_in_condition.rb +85 -0
  196. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +49 -3
  197. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +18 -3
  198. data/lib/rubocop/cop/lint/missing_super.rb +63 -5
  199. data/lib/rubocop/cop/lint/mixed_case_range.rb +116 -0
  200. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -0
  201. data/lib/rubocop/cop/lint/nested_method_definition.rb +53 -9
  202. data/lib/rubocop/cop/lint/next_without_accumulator.rb +11 -7
  203. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +165 -0
  204. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +15 -5
  205. data/lib/rubocop/cop/lint/number_conversion.rb +45 -13
  206. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +2 -2
  207. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -0
  208. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +4 -6
  209. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +17 -2
  210. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +6 -1
  211. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  212. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  213. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +54 -14
  214. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +7 -7
  215. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +7 -0
  216. data/lib/rubocop/cop/lint/redundant_regexp_quantifiers.rb +130 -0
  217. data/lib/rubocop/cop/lint/redundant_require_statement.rb +57 -10
  218. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +85 -8
  219. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  220. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +35 -15
  221. data/lib/rubocop/cop/lint/redundant_with_index.rb +18 -11
  222. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -12
  223. data/lib/rubocop/cop/lint/refinement_import_methods.rb +2 -1
  224. data/lib/rubocop/cop/lint/regexp_as_condition.rb +8 -2
  225. data/lib/rubocop/cop/lint/require_parentheses.rb +3 -1
  226. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  227. data/lib/rubocop/cop/lint/rescue_type.rb +2 -4
  228. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +50 -11
  229. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  230. data/lib/rubocop/cop/lint/script_permission.rb +3 -3
  231. data/lib/rubocop/cop/lint/self_assignment.rb +38 -0
  232. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +6 -6
  233. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -0
  234. data/lib/rubocop/cop/lint/shadowed_exception.rb +21 -22
  235. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +35 -4
  236. data/lib/rubocop/cop/lint/struct_new_override.rb +14 -14
  237. data/lib/rubocop/cop/lint/suppressed_exception.rb +3 -3
  238. data/lib/rubocop/cop/lint/symbol_conversion.rb +8 -3
  239. data/lib/rubocop/cop/lint/syntax.rb +10 -3
  240. data/lib/rubocop/cop/lint/to_enum_arguments.rb +23 -6
  241. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +23 -9
  242. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  243. data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +2 -2
  244. data/lib/rubocop/cop/lint/unreachable_code.rb +4 -2
  245. data/lib/rubocop/cop/lint/unreachable_loop.rb +20 -8
  246. data/lib/rubocop/cop/lint/unused_method_argument.rb +6 -1
  247. data/lib/rubocop/cop/lint/useless_access_modifier.rb +19 -14
  248. data/lib/rubocop/cop/lint/useless_assignment.rb +94 -10
  249. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +44 -0
  250. data/lib/rubocop/cop/lint/useless_method_definition.rb +12 -4
  251. data/lib/rubocop/cop/lint/useless_rescue.rb +89 -0
  252. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +15 -5
  253. data/lib/rubocop/cop/lint/useless_times.rb +3 -3
  254. data/lib/rubocop/cop/lint/void.rb +126 -25
  255. data/lib/rubocop/cop/metrics/abc_size.rb +7 -5
  256. data/lib/rubocop/cop/metrics/block_length.rb +17 -12
  257. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  258. data/lib/rubocop/cop/metrics/class_length.rb +17 -6
  259. data/lib/rubocop/cop/metrics/collection_literal_length.rb +76 -0
  260. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -1
  261. data/lib/rubocop/cop/metrics/method_length.rb +18 -12
  262. data/lib/rubocop/cop/metrics/module_length.rb +10 -5
  263. data/lib/rubocop/cop/metrics/parameter_lists.rb +27 -0
  264. data/lib/rubocop/cop/metrics/perceived_complexity.rb +1 -1
  265. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +4 -8
  266. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +43 -12
  267. data/lib/rubocop/cop/migration/department_name.rb +3 -3
  268. data/lib/rubocop/cop/mixin/alignment.rb +2 -2
  269. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +2 -2
  270. data/lib/rubocop/cop/mixin/allowed_methods.rb +23 -2
  271. data/lib/rubocop/cop/mixin/allowed_pattern.rb +17 -1
  272. data/lib/rubocop/cop/mixin/allowed_receivers.rb +34 -0
  273. data/lib/rubocop/cop/mixin/annotation_comment.rb +14 -7
  274. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  275. data/lib/rubocop/cop/mixin/code_length.rb +12 -1
  276. data/lib/rubocop/cop/mixin/comments_help.rb +37 -11
  277. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -9
  278. data/lib/rubocop/cop/mixin/configurable_formatting.rb +1 -0
  279. data/lib/rubocop/cop/mixin/def_node.rb +3 -8
  280. data/lib/rubocop/cop/mixin/documentation_comment.rb +1 -1
  281. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -1
  282. data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -1
  283. data/lib/rubocop/cop/mixin/first_element_line_break.rb +11 -7
  284. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +4 -0
  285. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +1 -1
  286. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +162 -12
  287. data/lib/rubocop/cop/mixin/hash_transform_method.rb +13 -9
  288. data/lib/rubocop/cop/mixin/heredoc.rb +6 -2
  289. data/lib/rubocop/cop/mixin/line_length_help.rb +11 -2
  290. data/lib/rubocop/cop/mixin/method_complexity.rb +28 -22
  291. data/lib/rubocop/cop/mixin/min_branches_count.rb +40 -0
  292. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +34 -12
  293. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +5 -6
  294. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +4 -3
  295. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +1 -1
  296. data/lib/rubocop/cop/mixin/percent_array.rb +58 -1
  297. data/lib/rubocop/cop/mixin/percent_literal.rb +1 -1
  298. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +7 -9
  299. data/lib/rubocop/cop/mixin/range_help.rb +28 -7
  300. data/lib/rubocop/cop/mixin/require_library.rb +2 -0
  301. data/lib/rubocop/cop/mixin/rescue_node.rb +5 -3
  302. data/lib/rubocop/cop/mixin/safe_assignment.rb +1 -1
  303. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
  304. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
  305. data/lib/rubocop/cop/mixin/statement_modifier.rb +18 -3
  306. data/lib/rubocop/cop/mixin/string_help.rb +4 -2
  307. data/lib/rubocop/cop/mixin/surrounding_space.rb +13 -11
  308. data/lib/rubocop/cop/mixin/trailing_comma.rb +3 -3
  309. data/lib/rubocop/cop/mixin/visibility_help.rb +40 -5
  310. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  311. data/lib/rubocop/cop/naming/block_forwarding.rb +39 -8
  312. data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
  313. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +3 -1
  314. data/lib/rubocop/cop/naming/constant_name.rb +4 -5
  315. data/lib/rubocop/cop/naming/file_name.rb +3 -3
  316. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  317. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +3 -1
  318. data/lib/rubocop/cop/naming/inclusive_language.rb +29 -8
  319. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +26 -11
  320. data/lib/rubocop/cop/naming/method_name.rb +3 -3
  321. data/lib/rubocop/cop/naming/predicate_name.rb +33 -4
  322. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +12 -4
  323. data/lib/rubocop/cop/naming/variable_name.rb +6 -1
  324. data/lib/rubocop/cop/registry.rb +74 -46
  325. data/lib/rubocop/cop/security/compound_hash.rb +4 -3
  326. data/lib/rubocop/cop/security/open.rb +2 -2
  327. data/lib/rubocop/cop/style/access_modifier_declarations.rb +142 -3
  328. data/lib/rubocop/cop/style/accessor_grouping.rb +50 -20
  329. data/lib/rubocop/cop/style/alias.rb +19 -9
  330. data/lib/rubocop/cop/style/arguments_forwarding.rb +414 -62
  331. data/lib/rubocop/cop/style/array_first_last.rb +64 -0
  332. data/lib/rubocop/cop/style/array_intersect.rb +119 -0
  333. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  334. data/lib/rubocop/cop/style/attr.rb +11 -1
  335. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +21 -14
  336. data/lib/rubocop/cop/style/begin_block.rb +1 -2
  337. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +3 -3
  338. data/lib/rubocop/cop/style/block_comments.rb +3 -3
  339. data/lib/rubocop/cop/style/block_delimiters.rb +52 -15
  340. data/lib/rubocop/cop/style/case_equality.rb +40 -10
  341. data/lib/rubocop/cop/style/case_like_if.rb +25 -8
  342. data/lib/rubocop/cop/style/character_literal.rb +1 -1
  343. data/lib/rubocop/cop/style/class_and_module_children.rb +9 -16
  344. data/lib/rubocop/cop/style/class_check.rb +1 -0
  345. data/lib/rubocop/cop/style/class_equality_comparison.rb +79 -12
  346. data/lib/rubocop/cop/style/class_methods_definitions.rb +2 -1
  347. data/lib/rubocop/cop/style/class_vars.rb +3 -3
  348. data/lib/rubocop/cop/style/collection_compact.rb +44 -12
  349. data/lib/rubocop/cop/style/collection_methods.rb +4 -0
  350. data/lib/rubocop/cop/style/colon_method_call.rb +2 -2
  351. data/lib/rubocop/cop/style/combinable_loops.rb +38 -8
  352. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  353. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  354. data/lib/rubocop/cop/style/commented_keyword.rb +7 -4
  355. data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
  356. data/lib/rubocop/cop/style/concat_array_literals.rb +95 -0
  357. data/lib/rubocop/cop/style/conditional_assignment.rb +16 -20
  358. data/lib/rubocop/cop/style/copyright.rb +32 -22
  359. data/lib/rubocop/cop/style/data_inheritance.rb +75 -0
  360. data/lib/rubocop/cop/style/date_time.rb +5 -4
  361. data/lib/rubocop/cop/style/dir.rb +1 -1
  362. data/lib/rubocop/cop/style/dir_empty.rb +54 -0
  363. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +2 -2
  364. data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +3 -3
  365. data/lib/rubocop/cop/style/documentation.rb +22 -10
  366. data/lib/rubocop/cop/style/documentation_method.rb +30 -4
  367. data/lib/rubocop/cop/style/double_negation.rb +4 -2
  368. data/lib/rubocop/cop/style/each_for_simple_loop.rb +45 -10
  369. data/lib/rubocop/cop/style/each_with_object.rb +40 -9
  370. data/lib/rubocop/cop/style/empty_block_parameter.rb +2 -2
  371. data/lib/rubocop/cop/style/empty_case_condition.rb +6 -1
  372. data/lib/rubocop/cop/style/empty_else.rb +37 -0
  373. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  374. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +2 -2
  375. data/lib/rubocop/cop/style/empty_literal.rb +1 -1
  376. data/lib/rubocop/cop/style/empty_method.rb +17 -2
  377. data/lib/rubocop/cop/style/encoding.rb +1 -1
  378. data/lib/rubocop/cop/style/endless_method.rb +1 -1
  379. data/lib/rubocop/cop/style/eval_with_location.rb +14 -23
  380. data/lib/rubocop/cop/style/exact_regexp_match.rb +70 -0
  381. data/lib/rubocop/cop/style/explicit_block_argument.rb +8 -4
  382. data/lib/rubocop/cop/style/fetch_env_var.rb +10 -177
  383. data/lib/rubocop/cop/style/file_empty.rb +71 -0
  384. data/lib/rubocop/cop/style/file_read.rb +3 -3
  385. data/lib/rubocop/cop/style/file_write.rb +1 -1
  386. data/lib/rubocop/cop/style/for.rb +5 -1
  387. data/lib/rubocop/cop/style/format_string.rb +33 -12
  388. data/lib/rubocop/cop/style/format_string_token.rb +73 -23
  389. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +5 -3
  390. data/lib/rubocop/cop/style/guard_clause.rb +159 -42
  391. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +2 -1
  392. data/lib/rubocop/cop/style/hash_conversion.rb +10 -0
  393. data/lib/rubocop/cop/style/hash_each_methods.rb +131 -22
  394. data/lib/rubocop/cop/style/hash_except.rb +101 -9
  395. data/lib/rubocop/cop/style/hash_like_case.rb +3 -9
  396. data/lib/rubocop/cop/style/hash_syntax.rb +51 -5
  397. data/lib/rubocop/cop/style/hash_transform_keys.rb +2 -2
  398. data/lib/rubocop/cop/style/hash_transform_values.rb +2 -2
  399. data/lib/rubocop/cop/style/identical_conditional_branches.rb +47 -3
  400. data/lib/rubocop/cop/style/if_inside_else.rb +6 -0
  401. data/lib/rubocop/cop/style/if_unless_modifier.rb +112 -16
  402. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +34 -5
  403. data/lib/rubocop/cop/style/if_with_semicolon.rb +6 -6
  404. data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -2
  405. data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
  406. data/lib/rubocop/cop/style/inverse_methods.rb +21 -16
  407. data/lib/rubocop/cop/style/invertible_unless_condition.rb +160 -0
  408. data/lib/rubocop/cop/style/keyword_parameters_order.rb +1 -1
  409. data/lib/rubocop/cop/style/lambda.rb +3 -3
  410. data/lib/rubocop/cop/style/lambda_call.rb +5 -0
  411. data/lib/rubocop/cop/style/line_end_concatenation.rb +5 -2
  412. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  413. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +8 -10
  414. data/lib/rubocop/cop/style/map_into_array.rb +175 -0
  415. data/lib/rubocop/cop/style/map_to_hash.rb +21 -8
  416. data/lib/rubocop/cop/style/map_to_set.rb +64 -0
  417. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +63 -32
  418. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +5 -1
  419. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +50 -45
  420. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +41 -2
  421. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +4 -1
  422. data/lib/rubocop/cop/style/method_def_parentheses.rb +12 -5
  423. data/lib/rubocop/cop/style/min_max.rb +3 -3
  424. data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
  425. data/lib/rubocop/cop/style/missing_else.rb +13 -1
  426. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +2 -2
  427. data/lib/rubocop/cop/style/mixin_grouping.rb +5 -5
  428. data/lib/rubocop/cop/style/module_function.rb +30 -8
  429. data/lib/rubocop/cop/style/multiline_block_chain.rb +4 -2
  430. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -6
  431. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  432. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +2 -4
  433. data/lib/rubocop/cop/style/multiline_memoization.rb +2 -2
  434. data/lib/rubocop/cop/style/multiline_method_signature.rb +18 -6
  435. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +22 -5
  436. data/lib/rubocop/cop/style/multiline_when_then.rb +1 -3
  437. data/lib/rubocop/cop/style/multiple_comparison.rb +14 -0
  438. data/lib/rubocop/cop/style/negated_if_else_condition.rb +17 -10
  439. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +10 -1
  440. data/lib/rubocop/cop/style/nested_ternary_operator.rb +18 -14
  441. data/lib/rubocop/cop/style/next.rb +4 -6
  442. data/lib/rubocop/cop/style/nil_comparison.rb +2 -0
  443. data/lib/rubocop/cop/style/nil_lambda.rb +4 -4
  444. data/lib/rubocop/cop/style/not.rb +1 -1
  445. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +11 -3
  446. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  447. data/lib/rubocop/cop/style/numeric_literals.rb +16 -1
  448. data/lib/rubocop/cop/style/numeric_predicate.rb +53 -11
  449. data/lib/rubocop/cop/style/object_then.rb +10 -3
  450. data/lib/rubocop/cop/style/one_line_conditional.rb +4 -7
  451. data/lib/rubocop/cop/style/open_struct_use.rb +1 -1
  452. data/lib/rubocop/cop/style/operator_method_call.rb +73 -0
  453. data/lib/rubocop/cop/style/parallel_assignment.rb +32 -24
  454. data/lib/rubocop/cop/style/parentheses_around_condition.rb +8 -0
  455. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +2 -3
  456. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  457. data/lib/rubocop/cop/style/perl_backrefs.rb +22 -1
  458. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  459. data/lib/rubocop/cop/style/proc.rb +4 -1
  460. data/lib/rubocop/cop/style/quoted_symbols.rb +1 -1
  461. data/lib/rubocop/cop/style/raise_args.rb +4 -1
  462. data/lib/rubocop/cop/style/redundant_argument.rb +37 -5
  463. data/lib/rubocop/cop/style/redundant_array_constructor.rb +77 -0
  464. data/lib/rubocop/cop/style/redundant_assignment.rb +10 -2
  465. data/lib/rubocop/cop/style/redundant_begin.rb +13 -2
  466. data/lib/rubocop/cop/style/redundant_condition.rb +41 -8
  467. data/lib/rubocop/cop/style/redundant_conditional.rb +2 -14
  468. data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
  469. data/lib/rubocop/cop/style/redundant_current_directory_in_path.rb +39 -0
  470. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +133 -0
  471. data/lib/rubocop/cop/style/redundant_each.rb +119 -0
  472. data/lib/rubocop/cop/style/redundant_exception.rb +32 -12
  473. data/lib/rubocop/cop/style/redundant_fetch_block.rb +10 -8
  474. data/lib/rubocop/cop/style/redundant_filter_chain.rb +118 -0
  475. data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
  476. data/lib/rubocop/cop/style/redundant_initialize.rb +3 -1
  477. data/lib/rubocop/cop/style/redundant_interpolation.rb +2 -2
  478. data/lib/rubocop/cop/style/redundant_line_continuation.rb +199 -0
  479. data/lib/rubocop/cop/style/redundant_parentheses.rb +91 -44
  480. data/lib/rubocop/cop/style/redundant_percent_q.rb +2 -2
  481. data/lib/rubocop/cop/style/redundant_regexp_argument.rb +100 -0
  482. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +9 -3
  483. data/lib/rubocop/cop/style/redundant_regexp_constructor.rb +46 -0
  484. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +22 -4
  485. data/lib/rubocop/cop/style/redundant_return.rb +21 -3
  486. data/lib/rubocop/cop/style/redundant_self.rb +19 -2
  487. data/lib/rubocop/cop/style/redundant_self_assignment.rb +1 -1
  488. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +8 -1
  489. data/lib/rubocop/cop/style/redundant_sort.rb +33 -17
  490. data/lib/rubocop/cop/style/redundant_sort_by.rb +24 -8
  491. data/lib/rubocop/cop/style/redundant_string_escape.rb +185 -0
  492. data/lib/rubocop/cop/style/regexp_literal.rb +11 -2
  493. data/lib/rubocop/cop/style/require_order.rb +139 -0
  494. data/lib/rubocop/cop/style/rescue_modifier.rb +2 -4
  495. data/lib/rubocop/cop/style/rescue_standard_error.rb +2 -2
  496. data/lib/rubocop/cop/style/return_nil.rb +6 -2
  497. data/lib/rubocop/cop/style/return_nil_in_predicate_method_definition.rb +95 -0
  498. data/lib/rubocop/cop/style/safe_navigation.rb +41 -10
  499. data/lib/rubocop/cop/style/sample.rb +3 -4
  500. data/lib/rubocop/cop/style/select_by_regexp.rb +30 -11
  501. data/lib/rubocop/cop/style/self_assignment.rb +3 -3
  502. data/lib/rubocop/cop/style/semicolon.rb +71 -8
  503. data/lib/rubocop/cop/style/send.rb +4 -4
  504. data/lib/rubocop/cop/style/send_with_literal_method_name.rb +83 -0
  505. data/lib/rubocop/cop/style/signal_exception.rb +9 -7
  506. data/lib/rubocop/cop/style/single_argument_dig.rb +7 -3
  507. data/lib/rubocop/cop/style/single_line_block_params.rb +1 -1
  508. data/lib/rubocop/cop/style/single_line_do_end_block.rb +67 -0
  509. data/lib/rubocop/cop/style/single_line_methods.rb +1 -1
  510. data/lib/rubocop/cop/style/slicing_with_range.rb +77 -11
  511. data/lib/rubocop/cop/style/sole_nested_conditional.rb +25 -12
  512. data/lib/rubocop/cop/style/special_global_vars.rb +4 -6
  513. data/lib/rubocop/cop/style/static_class.rb +32 -1
  514. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  515. data/lib/rubocop/cop/style/string_chars.rb +1 -0
  516. data/lib/rubocop/cop/style/string_hash_keys.rb +4 -1
  517. data/lib/rubocop/cop/style/string_literals.rb +1 -5
  518. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +30 -5
  519. data/lib/rubocop/cop/style/strip.rb +7 -4
  520. data/lib/rubocop/cop/style/struct_inheritance.rb +3 -3
  521. data/lib/rubocop/cop/style/super_arguments.rb +137 -0
  522. data/lib/rubocop/cop/style/super_with_args_parentheses.rb +35 -0
  523. data/lib/rubocop/cop/style/swap_values.rb +1 -1
  524. data/lib/rubocop/cop/style/symbol_array.rb +40 -19
  525. data/lib/rubocop/cop/style/symbol_proc.rb +110 -15
  526. data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -13
  527. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  528. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -0
  529. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +4 -4
  530. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +1 -1
  531. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  532. data/lib/rubocop/cop/style/trivial_accessors.rb +4 -1
  533. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -0
  534. data/lib/rubocop/cop/style/unpack_first.rb +11 -14
  535. data/lib/rubocop/cop/style/word_array.rb +59 -5
  536. data/lib/rubocop/cop/style/yaml_file_read.rb +66 -0
  537. data/lib/rubocop/cop/style/yoda_condition.rb +17 -8
  538. data/lib/rubocop/cop/style/yoda_expression.rb +91 -0
  539. data/lib/rubocop/cop/style/zero_length_predicate.rb +40 -19
  540. data/lib/rubocop/cop/team.rb +66 -56
  541. data/lib/rubocop/cop/util.rb +46 -10
  542. data/lib/rubocop/cop/utils/regexp_ranges.rb +113 -0
  543. data/lib/rubocop/cop/variable_force/assignment.rb +45 -4
  544. data/lib/rubocop/cop/variable_force/scope.rb +3 -3
  545. data/lib/rubocop/cop/variable_force/variable.rb +5 -3
  546. data/lib/rubocop/cop/variable_force/variable_table.rb +6 -4
  547. data/lib/rubocop/cop/variable_force.rb +19 -30
  548. data/lib/rubocop/cops_documentation_generator.rb +60 -18
  549. data/lib/rubocop/directive_comment.rb +14 -12
  550. data/lib/rubocop/ext/comment.rb +18 -0
  551. data/lib/rubocop/ext/processed_source.rb +2 -0
  552. data/lib/rubocop/ext/range.rb +15 -0
  553. data/lib/rubocop/ext/regexp_node.rb +10 -5
  554. data/lib/rubocop/ext/regexp_parser.rb +5 -2
  555. data/lib/rubocop/feature_loader.rb +94 -0
  556. data/lib/rubocop/file_finder.rb +4 -7
  557. data/lib/rubocop/file_patterns.rb +43 -0
  558. data/lib/rubocop/formatter/clang_style_formatter.rb +4 -8
  559. data/lib/rubocop/formatter/disabled_config_formatter.rb +47 -15
  560. data/lib/rubocop/formatter/formatter_set.rb +27 -20
  561. data/lib/rubocop/formatter/{git_hub_actions_formatter.rb → github_actions_formatter.rb} +15 -2
  562. data/lib/rubocop/formatter/html_formatter.rb +38 -18
  563. data/lib/rubocop/formatter/json_formatter.rb +0 -1
  564. data/lib/rubocop/formatter/junit_formatter.rb +4 -1
  565. data/lib/rubocop/formatter/markdown_formatter.rb +1 -1
  566. data/lib/rubocop/formatter/offense_count_formatter.rb +21 -6
  567. data/lib/rubocop/formatter/simple_text_formatter.rb +7 -8
  568. data/lib/rubocop/formatter/tap_formatter.rb +4 -8
  569. data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -3
  570. data/lib/rubocop/formatter.rb +34 -0
  571. data/lib/rubocop/lockfile.rb +56 -7
  572. data/lib/rubocop/lsp/logger.rb +22 -0
  573. data/lib/rubocop/lsp/routes.rb +243 -0
  574. data/lib/rubocop/lsp/runtime.rb +99 -0
  575. data/lib/rubocop/lsp/server.rb +73 -0
  576. data/lib/rubocop/lsp/severity.rb +27 -0
  577. data/lib/rubocop/lsp.rb +36 -0
  578. data/lib/rubocop/magic_comment.rb +13 -11
  579. data/lib/rubocop/options.rb +101 -32
  580. data/lib/rubocop/path_util.rb +54 -22
  581. data/lib/rubocop/rake_task.rb +35 -10
  582. data/lib/rubocop/result_cache.rb +29 -24
  583. data/lib/rubocop/rspec/cop_helper.rb +32 -3
  584. data/lib/rubocop/rspec/expect_offense.rb +18 -8
  585. data/lib/rubocop/rspec/shared_contexts.rb +86 -33
  586. data/lib/rubocop/rspec/support.rb +19 -2
  587. data/lib/rubocop/runner.rb +91 -23
  588. data/lib/rubocop/server/cache.rb +155 -0
  589. data/lib/rubocop/server/cli.rb +147 -0
  590. data/lib/rubocop/server/client_command/base.rb +44 -0
  591. data/lib/rubocop/server/client_command/exec.rb +64 -0
  592. data/lib/rubocop/server/client_command/restart.rb +25 -0
  593. data/lib/rubocop/server/client_command/start.rb +48 -0
  594. data/lib/rubocop/server/client_command/status.rb +28 -0
  595. data/lib/rubocop/server/client_command/stop.rb +31 -0
  596. data/lib/rubocop/server/client_command.rb +26 -0
  597. data/lib/rubocop/server/core.rb +111 -0
  598. data/lib/rubocop/server/errors.rb +23 -0
  599. data/lib/rubocop/server/helper.rb +34 -0
  600. data/lib/rubocop/server/server_command/base.rb +50 -0
  601. data/lib/rubocop/server/server_command/exec.rb +33 -0
  602. data/lib/rubocop/server/server_command/stop.rb +24 -0
  603. data/lib/rubocop/server/server_command.rb +21 -0
  604. data/lib/rubocop/server/socket_reader.rb +69 -0
  605. data/lib/rubocop/server.rb +53 -0
  606. data/lib/rubocop/string_interpreter.rb +3 -3
  607. data/lib/rubocop/target_finder.rb +92 -82
  608. data/lib/rubocop/target_ruby.rb +86 -80
  609. data/lib/rubocop/version.rb +44 -12
  610. data/lib/rubocop.rb +73 -35
  611. metadata +145 -39
  612. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -49
  613. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
@@ -0,0 +1,83 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # Detects the use of the `public_send` method with a literal method name argument.
7
+ # Since the `send` method can be used to call private methods, by default,
8
+ # only the `public_send` method is detected.
9
+ #
10
+ # @safety
11
+ # This cop is not safe because it can incorrectly detect based on the receiver.
12
+ # Additionally, when `AllowSend` is set to `true`, it cannot determine whether
13
+ # the `send` method being detected is calling a private method.
14
+ #
15
+ # @example
16
+ # # bad
17
+ # obj.public_send(:method_name)
18
+ # obj.public_send('method_name')
19
+ #
20
+ # # good
21
+ # obj.method_name
22
+ #
23
+ # @example AllowSend: true (default)
24
+ # # good
25
+ # obj.send(:method_name)
26
+ # obj.send('method_name')
27
+ # obj.__send__(:method_name)
28
+ # obj.__send__('method_name')
29
+ #
30
+ # @example AllowSend: false
31
+ # # bad
32
+ # obj.send(:method_name)
33
+ # obj.send('method_name')
34
+ # obj.__send__(:method_name)
35
+ # obj.__send__('method_name')
36
+ #
37
+ # # good
38
+ # obj.method_name
39
+ #
40
+ class SendWithLiteralMethodName < Base
41
+ extend AutoCorrector
42
+
43
+ MSG = 'Use `%<method_name>s` method call directly instead.'
44
+ RESTRICT_ON_SEND = %i[public_send send __send__].freeze
45
+ STATIC_METHOD_NAME_NODE_TYPES = %i[sym str].freeze
46
+
47
+ # rubocop:disable Metrics/AbcSize
48
+ def on_send(node)
49
+ return if allow_send? && !node.method?(:public_send)
50
+ return unless (first_argument = node.first_argument)
51
+ return unless STATIC_METHOD_NAME_NODE_TYPES.include?(first_argument.type)
52
+
53
+ offense_range = offense_range(node)
54
+ method_name = first_argument.value
55
+
56
+ add_offense(offense_range, message: format(MSG, method_name: method_name)) do |corrector|
57
+ if node.arguments.one?
58
+ corrector.replace(offense_range, method_name)
59
+ else
60
+ corrector.replace(node.loc.selector, method_name)
61
+ corrector.remove(removal_argument_range(first_argument, node.arguments[1]))
62
+ end
63
+ end
64
+ end
65
+ # rubocop:enable Metrics/AbcSize
66
+
67
+ private
68
+
69
+ def allow_send?
70
+ !!cop_config['AllowSend']
71
+ end
72
+
73
+ def offense_range(node)
74
+ node.loc.selector.join(node.source_range.end)
75
+ end
76
+
77
+ def removal_argument_range(first_argument, second_argument)
78
+ first_argument.source_range.begin.join(second_argument.source_range.begin)
79
+ end
80
+ end
81
+ end
82
+ end
83
+ end
@@ -119,11 +119,6 @@ module RuboCop
119
119
  # @!method custom_fail_methods(node)
120
120
  def_node_search :custom_fail_methods, '{(def :fail ...) (defs _ :fail ...)}'
121
121
 
122
- def on_new_investigation
123
- ast = processed_source.ast
124
- @custom_fail_defined = ast && custom_fail_methods(ast).any?
125
- end
126
-
127
122
  def on_rescue(node)
128
123
  return unless style == :semantic
129
124
 
@@ -141,7 +136,7 @@ module RuboCop
141
136
  when :semantic
142
137
  check_send(:raise, node) unless ignored_node?(node)
143
138
  when :only_raise
144
- return if @custom_fail_defined
139
+ return if custom_fail_defined?
145
140
 
146
141
  check_send(:fail, node)
147
142
  when :only_fail
@@ -151,6 +146,13 @@ module RuboCop
151
146
 
152
147
  private
153
148
 
149
+ def custom_fail_defined?
150
+ return @custom_fail_defined if defined?(@custom_fail_defined)
151
+
152
+ ast = processed_source.ast
153
+ @custom_fail_defined = ast && custom_fail_methods(ast).any?
154
+ end
155
+
154
156
  def message(method_name)
155
157
  case style
156
158
  when :semantic
@@ -196,7 +198,7 @@ module RuboCop
196
198
  end
197
199
 
198
200
  def command_or_kernel_call?(name, node)
199
- return unless node.method?(name)
201
+ return false unless node.method?(name)
200
202
 
201
203
  node.command?(name) || kernel_call?(node, name)
202
204
  end
@@ -3,8 +3,11 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # Sometimes using dig method ends up with just a single
7
- # argument. In such cases, dig should be replaced with [].
6
+ # Sometimes using `dig` method ends up with just a single
7
+ # argument. In such cases, dig should be replaced with `[]`.
8
+ #
9
+ # Since replacing `hash&.dig(:key)` with `hash[:key]` could potentially lead to error,
10
+ # calls to the `dig` method using safe navigation will be ignored.
8
11
  #
9
12
  # @safety
10
13
  # This cop is unsafe because it cannot be guaranteed that the receiver
@@ -33,6 +36,7 @@ module RuboCop
33
36
 
34
37
  MSG = 'Use `%<receiver>s[%<argument>s]` instead of `%<original>s`.'
35
38
  RESTRICT_ON_SEND = %i[dig].freeze
39
+ IGNORED_ARGUMENT_TYPES = %i[block_pass forwarded_restarg forwarded_args hash].freeze
36
40
 
37
41
  # @!method single_argument_dig?(node)
38
42
  def_node_matcher :single_argument_dig?, <<~PATTERN
@@ -44,7 +48,7 @@ module RuboCop
44
48
 
45
49
  expression = single_argument_dig?(node)
46
50
  return unless expression
47
- return if expression.forwarded_args_type?
51
+ return if IGNORED_ARGUMENT_TYPES.include?(expression.type)
48
52
 
49
53
  receiver = node.receiver.source
50
54
  argument = expression.source
@@ -33,7 +33,7 @@ module RuboCop
33
33
 
34
34
  MSG = 'Name `%<method>s` block params `|%<params>s|`.'
35
35
 
36
- def on_block(node)
36
+ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
37
37
  return unless node.single_line?
38
38
 
39
39
  return unless eligible_method?(node)
@@ -0,0 +1,67 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # Checks for single-line `do`...`end` block.
7
+ #
8
+ # In practice a single line `do`...`end` is autocorrected when `EnforcedStyle: semantic`
9
+ # in `Style/BlockDelimiters`. The autocorrection maintains the `do` ... `end` syntax to
10
+ # preserve semantics and does not change it to `{`...`}` block.
11
+ #
12
+ # @example
13
+ #
14
+ # # bad
15
+ # foo do |arg| bar(arg) end
16
+ #
17
+ # # good
18
+ # foo do |arg|
19
+ # bar(arg)
20
+ # end
21
+ #
22
+ # # bad
23
+ # ->(arg) do bar(arg) end
24
+ #
25
+ # # good
26
+ # ->(arg) { bar(arg) }
27
+ #
28
+ class SingleLineDoEndBlock < Base
29
+ extend AutoCorrector
30
+
31
+ MSG = 'Prefer multiline `do`...`end` block.'
32
+
33
+ # rubocop:disable Metrics/AbcSize
34
+ def on_block(node)
35
+ return if !node.single_line? || node.braces?
36
+
37
+ add_offense(node) do |corrector|
38
+ corrector.insert_after(do_line(node), "\n")
39
+
40
+ node_body = node.body
41
+
42
+ if node_body.respond_to?(:heredoc?) && node_body.heredoc?
43
+ corrector.remove(node.loc.end)
44
+ corrector.insert_after(node_body.loc.heredoc_end, "\nend")
45
+ else
46
+ corrector.insert_before(node.loc.end, "\n")
47
+ end
48
+ end
49
+ end
50
+ # rubocop:enable Metrics/AbcSize
51
+ alias on_numblock on_block
52
+
53
+ private
54
+
55
+ def do_line(node)
56
+ if node.numblock_type? || node.arguments.children.empty? || node.send_node.lambda_literal?
57
+ node.loc.begin
58
+ else
59
+ node.arguments
60
+ end
61
+ end
62
+
63
+ def x(corrector, node); end
64
+ end
65
+ end
66
+ end
67
+ end
@@ -135,7 +135,7 @@ module RuboCop
135
135
 
136
136
  def disallow_endless_method_style?
137
137
  endless_method_config = config.for_cop('Style/EndlessMethod')
138
- return false unless endless_method_config['Enabled']
138
+ return true unless endless_method_config['Enabled']
139
139
 
140
140
  endless_method_config['EnforcedStyle'] == 'disallow'
141
141
  end
@@ -3,12 +3,13 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # Checks that arrays are sliced with endless ranges instead of
7
- # `ary[start..-1]` on Ruby 2.6+.
6
+ # Checks that arrays are not sliced with the redundant `ary[0..-1]`, replacing it with `ary`,
7
+ # and ensures arrays are sliced with endless ranges instead of `ary[start..-1]` on Ruby 2.6+,
8
+ # and with beginless ranges instead of `ary[nil..end]` on Ruby 2.7+.
8
9
  #
9
10
  # @safety
10
11
  # This cop is unsafe because `x..-1` and `x..` are only guaranteed to
11
- # be equivalent for `Array#[]`, and the cop cannot determine what class
12
+ # be equivalent for `Array#[]`, `String#[]`, and the cop cannot determine what class
12
13
  # the receiver is.
13
14
  #
14
15
  # For example:
@@ -21,29 +22,94 @@ module RuboCop
21
22
  #
22
23
  # @example
23
24
  # # bad
24
- # items[1..-1]
25
+ # items[0..-1]
26
+ # items[0..nil]
27
+ # items[0...nil]
25
28
  #
26
29
  # # good
27
- # items[1..]
30
+ # items
31
+ #
32
+ # # bad
33
+ # items[1..-1] # Ruby 2.6+
34
+ # items[1..nil] # Ruby 2.6+
35
+ #
36
+ # # good
37
+ # items[1..] # Ruby 2.6+
38
+ #
39
+ # # bad
40
+ # items[nil..42] # Ruby 2.7+
41
+ #
42
+ # # good
43
+ # items[..42] # Ruby 2.7+
44
+ # items[0..42] # Ruby 2.7+
45
+ #
28
46
  class SlicingWithRange < Base
29
47
  extend AutoCorrector
30
48
  extend TargetRubyVersion
31
49
 
32
50
  minimum_target_ruby_version 2.6
33
51
 
34
- MSG = 'Prefer ary[n..] over ary[n..-1].'
52
+ MSG = 'Prefer `%<prefer>s` over `%<current>s`.'
53
+ MSG_USELESS_RANGE = 'Remove the useless `%<prefer>s`.'
35
54
  RESTRICT_ON_SEND = %i[[]].freeze
36
55
 
56
+ # @!method range_from_zero_till_minus_one?(node)
57
+ def_node_matcher :range_from_zero_till_minus_one?, <<~PATTERN
58
+ {
59
+ (irange (int 0) {(int -1) nil})
60
+ (erange (int 0) nil)
61
+ }
62
+ PATTERN
63
+
37
64
  # @!method range_till_minus_one?(node)
38
- def_node_matcher :range_till_minus_one?, '(irange !nil? (int -1))'
65
+ def_node_matcher :range_till_minus_one?, <<~PATTERN
66
+ {
67
+ (irange !nil? {(int -1) nil})
68
+ (erange !nil? nil)
69
+ }
70
+ PATTERN
71
+
72
+ # @!method range_from_zero?(node)
73
+ def_node_matcher :range_from_zero?, <<~PATTERN
74
+ (irange nil !nil?)
75
+ PATTERN
39
76
 
40
77
  def on_send(node)
41
- return unless node.arguments.count == 1
42
- return unless range_till_minus_one?(node.arguments.first)
78
+ return unless node.arguments.one?
43
79
 
44
- add_offense(node.first_argument) do |corrector|
45
- corrector.remove(node.first_argument.end)
80
+ range_node = node.first_argument
81
+ selector = node.loc.selector
82
+ unless (message, removal_range = offense_message_with_removal_range(range_node, selector))
83
+ return
46
84
  end
85
+
86
+ add_offense(selector, message: message) do |corrector|
87
+ corrector.remove(removal_range)
88
+ end
89
+ end
90
+
91
+ private
92
+
93
+ def offense_message_with_removal_range(range_node, selector)
94
+ if range_from_zero_till_minus_one?(range_node)
95
+ [format(MSG_USELESS_RANGE, prefer: selector.source), selector]
96
+ elsif range_till_minus_one?(range_node)
97
+ [
98
+ format(MSG, prefer: endless(range_node), current: selector.source), range_node.end
99
+ ]
100
+ elsif range_from_zero?(range_node) && target_ruby_version >= 2.7
101
+ [
102
+ format(MSG, prefer: beginless(range_node), current: selector.source), range_node.begin
103
+ ]
104
+ end
105
+ end
106
+
107
+ def endless(range_node)
108
+ "[#{range_node.begin.source}#{range_node.loc.operator.source}]"
109
+ end
110
+
111
+ def beginless(range_node)
112
+ "[#{range_node.loc.operator.source}#{range_node.end.source}]"
47
113
  end
48
114
  end
49
115
  end
@@ -138,7 +138,7 @@ module RuboCop
138
138
  corrector.insert_after(outer_condition, "#{and_operator}#{replace_condition(condition)}")
139
139
 
140
140
  range = range_between(if_branch.loc.keyword.begin_pos, condition.source_range.end_pos)
141
- corrector.remove(range_with_surrounding_space(range: range, newlines: false))
141
+ corrector.remove(range_with_surrounding_space(range, newlines: false))
142
142
  corrector.remove(if_branch.loc.keyword)
143
143
  end
144
144
 
@@ -148,7 +148,18 @@ module RuboCop
148
148
  )
149
149
  corrector.replace(range, and_operator)
150
150
  corrector.remove(range_by_whole_lines(node.loc.end, include_final_newline: true))
151
- corrector.wrap(if_branch.condition, '(', ')') if wrap_condition?(if_branch.condition)
151
+
152
+ wrap_condition(corrector, if_branch.condition)
153
+ end
154
+
155
+ def wrap_condition(corrector, condition)
156
+ # Handle `send` and `block` nodes that need to be wrapped in parens
157
+ # FIXME: autocorrection prevents syntax errors by wrapping the entire node in parens,
158
+ # but wrapping the argument list would be a more ergonomic correction.
159
+ node_to_check = condition&.block_type? ? condition.send_node : condition
160
+ return unless wrap_condition?(node_to_check)
161
+
162
+ corrector.wrap(condition, '(', ')')
152
163
  end
153
164
 
154
165
  def correct_for_outer_condition_modify_form_style(corrector, node, if_branch)
@@ -156,15 +167,15 @@ module RuboCop
156
167
  corrector.insert_before(condition,
157
168
  "#{'!' if node.unless?}#{replace_condition(node.condition)} && ")
158
169
 
159
- corrector.remove(node.condition.loc.expression)
160
- corrector.remove(range_with_surrounding_space(range: node.loc.keyword, newlines: false))
170
+ corrector.remove(node.condition)
171
+ corrector.remove(range_with_surrounding_space(node.loc.keyword, newlines: false))
161
172
  corrector.replace(if_branch.loc.keyword, 'if')
162
173
  end
163
174
 
164
175
  def correct_for_comment(corrector, node, if_branch)
165
- return if config.for_cop('Style/IfUnlessModifier')['Enabled']
166
-
167
- comments = processed_source.ast_with_comments[if_branch]
176
+ comments = processed_source.ast_with_comments[if_branch].select do |comment|
177
+ comment.loc.line < if_branch.condition.first_line
178
+ end
168
179
  comment_text = comments.map(&:text).join("\n") << "\n"
169
180
 
170
181
  corrector.insert_before(node.loc.keyword, comment_text) unless comments.empty?
@@ -177,8 +188,10 @@ module RuboCop
177
188
  begin_pos = condition.first_argument.source_range.begin_pos
178
189
  return if end_pos > begin_pos
179
190
 
180
- corrector.replace(range_between(end_pos, begin_pos), '(')
181
- corrector.insert_after(condition.last_argument.source_range, ')')
191
+ range = range_between(end_pos, begin_pos)
192
+ corrector.remove(range)
193
+ corrector.insert_after(range, '(')
194
+ corrector.insert_after(condition.last_argument, ')')
182
195
  end
183
196
 
184
197
  def insert_bang(corrector, node, is_modify_form)
@@ -207,7 +220,7 @@ module RuboCop
207
220
  end
208
221
 
209
222
  def require_parentheses?(condition)
210
- condition.send_type? && !condition.arguments.empty? && !condition.parenthesized? &&
223
+ condition.call_type? && !condition.arguments.empty? && !condition.parenthesized? &&
211
224
  !condition.comparison_method?
212
225
  end
213
226
 
@@ -219,7 +232,7 @@ module RuboCop
219
232
 
220
233
  def wrap_condition?(node)
221
234
  node.and_type? || node.or_type? ||
222
- (node.send_type? && node.arguments.any? && !node.parenthesized?)
235
+ (node.call_type? && node.arguments.any? && !node.parenthesized?)
223
236
  end
224
237
 
225
238
  def replace_condition(condition)
@@ -231,7 +244,7 @@ module RuboCop
231
244
  end
232
245
 
233
246
  def outer_condition_modify_form?(node, if_branch)
234
- node.condition.loc.expression.begin_pos > if_branch.condition.loc.expression.begin_pos
247
+ node.condition.source_range.begin_pos > if_branch.condition.source_range.begin_pos
235
248
  end
236
249
  end
237
250
  end
@@ -3,8 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- #
7
- # This cop looks for uses of Perl-style global variables.
6
+ # Looks for uses of Perl-style global variables.
8
7
  # Correcting to global variables in the 'English' library
9
8
  # will add a require statement to the top of the file if
10
9
  # enabled by RequireEnglish config.
@@ -59,9 +58,8 @@ module RuboCop
59
58
  #
60
59
  # @example EnforcedStyle: use_builtin_english_names
61
60
  #
62
- # Like `use_perl_names` but allows builtin global vars.
63
- #
64
61
  # # good
62
+ # # Like `use_perl_names` but allows builtin global vars.
65
63
  # puts $LOAD_PATH
66
64
  # puts $LOADED_FEATURES
67
65
  # puts $PROGRAM_NAME
@@ -234,9 +232,9 @@ module RuboCop
234
232
  end
235
233
 
236
234
  def matching_styles(global)
237
- STYLE_VARS_MAP.map do |style, vars|
235
+ STYLE_VARS_MAP.filter_map do |style, vars|
238
236
  style if vars.values.flatten(1).include? global
239
- end.compact
237
+ end
240
238
  end
241
239
 
242
240
  def english_name_replacement(preferred_name, node)
@@ -44,18 +44,49 @@ module RuboCop
44
44
  # end
45
45
  #
46
46
  class StaticClass < Base
47
+ include RangeHelp
47
48
  include VisibilityHelp
49
+ extend AutoCorrector
48
50
 
49
51
  MSG = 'Prefer modules to classes with only class methods.'
50
52
 
51
53
  def on_class(class_node)
52
54
  return if class_node.parent_class
55
+ return unless class_convertible_to_module?(class_node)
53
56
 
54
- add_offense(class_node) if class_convertible_to_module?(class_node)
57
+ add_offense(class_node) do |corrector|
58
+ autocorrect(corrector, class_node)
59
+ end
55
60
  end
56
61
 
57
62
  private
58
63
 
64
+ def autocorrect(corrector, class_node)
65
+ corrector.replace(class_node.loc.keyword, 'module')
66
+ corrector.insert_after(class_node.loc.name, "\nmodule_function\n")
67
+
68
+ class_elements(class_node).each do |node|
69
+ if node.defs_type?
70
+ autocorrect_def(corrector, node)
71
+ elsif node.sclass_type?
72
+ autocorrect_sclass(corrector, node)
73
+ end
74
+ end
75
+ end
76
+
77
+ def autocorrect_def(corrector, node)
78
+ corrector.remove(
79
+ range_between(node.receiver.source_range.begin_pos, node.loc.name.begin_pos)
80
+ )
81
+ end
82
+
83
+ def autocorrect_sclass(corrector, node)
84
+ corrector.remove(
85
+ range_between(node.loc.keyword.begin_pos, node.identifier.source_range.end_pos)
86
+ )
87
+ corrector.remove(node.loc.end)
88
+ end
89
+
59
90
  def class_convertible_to_module?(class_node)
60
91
  nodes = class_elements(class_node)
61
92
  return false if nodes.empty?
@@ -49,7 +49,7 @@ module RuboCop
49
49
  end
50
50
 
51
51
  def stderr_puts_range(send)
52
- range_between(send.loc.expression.begin_pos, send.loc.selector.end_pos)
52
+ range_between(send.source_range.begin_pos, send.loc.selector.end_pos)
53
53
  end
54
54
  end
55
55
  end
@@ -35,6 +35,7 @@ module RuboCop
35
35
  corrector.replace(range, 'chars')
36
36
  end
37
37
  end
38
+ alias on_csend on_send
38
39
  end
39
40
  end
40
41
  end
@@ -41,10 +41,13 @@ module RuboCop
41
41
 
42
42
  def on_pair(node)
43
43
  return unless string_hash_key?(node)
44
+
45
+ key_content = node.key.str_content
46
+ return unless key_content.valid_encoding?
44
47
  return if receive_environments_method?(node)
45
48
 
46
49
  add_offense(node.key) do |corrector|
47
- symbol_content = node.key.str_content.to_sym.inspect
50
+ symbol_content = key_content.to_sym.inspect
48
51
 
49
52
  corrector.replace(node.key, symbol_content)
50
53
  end
@@ -95,11 +95,7 @@ module RuboCop
95
95
  end
96
96
 
97
97
  def offense?(node)
98
- # If it's a string within an interpolation, then it's not an offense
99
- # for this cop.
100
- return false if inside_interpolation?(node)
101
-
102
- wrong_quotes?(node)
98
+ wrong_quotes?(node) && !inside_interpolation?(node)
103
99
  end
104
100
 
105
101
  def consistent_multiline?
@@ -3,22 +3,42 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # Checks that quotes inside the string interpolation
6
+ # Checks that quotes inside string, symbol, and regexp interpolations
7
7
  # match the configured preference.
8
8
  #
9
9
  # @example EnforcedStyle: single_quotes (default)
10
10
  # # bad
11
- # result = "Tests #{success ? "PASS" : "FAIL"}"
11
+ # string = "Tests #{success ? "PASS" : "FAIL"}"
12
+ # symbol = :"Tests #{success ? "PASS" : "FAIL"}"
13
+ # heredoc = <<~TEXT
14
+ # Tests #{success ? "PASS" : "FAIL"}
15
+ # TEXT
16
+ # regexp = /Tests #{success ? "PASS" : "FAIL"}/
12
17
  #
13
18
  # # good
14
- # result = "Tests #{success ? 'PASS' : 'FAIL'}"
19
+ # string = "Tests #{success ? 'PASS' : 'FAIL'}"
20
+ # symbol = :"Tests #{success ? 'PASS' : 'FAIL'}"
21
+ # heredoc = <<~TEXT
22
+ # Tests #{success ? 'PASS' : 'FAIL'}
23
+ # TEXT
24
+ # regexp = /Tests #{success ? 'PASS' : 'FAIL'}/
15
25
  #
16
26
  # @example EnforcedStyle: double_quotes
17
27
  # # bad
18
- # result = "Tests #{success ? 'PASS' : 'FAIL'}"
28
+ # string = "Tests #{success ? 'PASS' : 'FAIL'}"
29
+ # symbol = :"Tests #{success ? 'PASS' : 'FAIL'}"
30
+ # heredoc = <<~TEXT
31
+ # Tests #{success ? 'PASS' : 'FAIL'}
32
+ # TEXT
33
+ # regexp = /Tests #{success ? 'PASS' : 'FAIL'}/
19
34
  #
20
35
  # # good
21
- # result = "Tests #{success ? "PASS" : "FAIL"}"
36
+ # string = "Tests #{success ? "PASS" : "FAIL"}"
37
+ # symbol = :"Tests #{success ? "PASS" : "FAIL"}"
38
+ # heredoc = <<~TEXT
39
+ # Tests #{success ? "PASS" : "FAIL"}
40
+ # TEXT
41
+ # regexp = /Tests #{success ? "PASS" : "FAIL"}/
22
42
  class StringLiteralsInInterpolation < Base
23
43
  include ConfigurableEnforcedStyle
24
44
  include StringLiteralsHelp
@@ -29,6 +49,11 @@ module RuboCop
29
49
  StringLiteralCorrector.correct(corrector, node, style)
30
50
  end
31
51
 
52
+ # Cop classes that include the StringHelp module usually ignore regexp
53
+ # nodes. Not so for this cop, which is why we override the on_regexp
54
+ # definition with an empty one.
55
+ def on_regexp(node); end
56
+
32
57
  private
33
58
 
34
59
  def message(_node)
@@ -22,20 +22,23 @@ module RuboCop
22
22
 
23
23
  # @!method lstrip_rstrip(node)
24
24
  def_node_matcher :lstrip_rstrip, <<~PATTERN
25
- {(send $(send _ $:rstrip) $:lstrip)
26
- (send $(send _ $:lstrip) $:rstrip)}
25
+ {
26
+ (call $(call _ :rstrip) :lstrip)
27
+ (call $(call _ :lstrip) :rstrip)
28
+ }
27
29
  PATTERN
28
30
 
29
31
  def on_send(node)
30
- lstrip_rstrip(node) do |first_send, method_one, method_two|
32
+ lstrip_rstrip(node) do |first_send|
31
33
  range = range_between(first_send.loc.selector.begin_pos, node.source_range.end_pos)
32
- message = format(MSG, methods: "#{method_one}.#{method_two}")
34
+ message = format(MSG, methods: range.source)
33
35
 
34
36
  add_offense(range, message: message) do |corrector|
35
37
  corrector.replace(range, 'strip')
36
38
  end
37
39
  end
38
40
  end
41
+ alias on_csend on_send
39
42
  end
40
43
  end
41
44
  end