rubocop 1.24.1 → 1.64.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +11 -8
- data/assets/output.css.erb +159 -0
- data/assets/output.html.erb +1 -160
- data/config/default.yml +707 -100
- data/config/obsoletion.yml +40 -2
- data/exe/rubocop +15 -7
- data/lib/rubocop/arguments_env.rb +17 -0
- data/lib/rubocop/arguments_file.rb +17 -0
- data/lib/rubocop/cache_config.rb +29 -0
- data/lib/rubocop/cached_data.rb +11 -3
- data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +47 -11
- data/lib/rubocop/cli/command/execute_runner.rb +15 -10
- data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
- data/lib/rubocop/cli/command/lsp.rb +19 -0
- data/lib/rubocop/cli/command/show_cops.rb +1 -1
- data/lib/rubocop/cli/command/show_docs_url.rb +2 -2
- data/lib/rubocop/cli/command/suggest_extensions.rb +62 -17
- data/lib/rubocop/cli.rb +72 -12
- data/lib/rubocop/comment_config.rb +60 -1
- data/lib/rubocop/config.rb +84 -28
- data/lib/rubocop/config_finder.rb +78 -0
- data/lib/rubocop/config_loader.rb +48 -69
- data/lib/rubocop/config_loader_resolver.rb +8 -8
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +3 -1
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +13 -1
- data/lib/rubocop/config_obsoletion.rb +15 -7
- data/lib/rubocop/config_validator.rb +34 -10
- data/lib/rubocop/cop/autocorrect_logic.rb +44 -15
- data/lib/rubocop/cop/badge.rb +15 -4
- data/lib/rubocop/cop/base.rb +181 -98
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +4 -7
- data/lib/rubocop/cop/bundler/duplicated_group.rb +127 -0
- data/lib/rubocop/cop/bundler/gem_comment.rb +5 -5
- data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
- data/lib/rubocop/cop/bundler/gem_version.rb +5 -7
- data/lib/rubocop/cop/bundler/ordered_gems.rb +11 -3
- data/lib/rubocop/cop/commissioner.rb +19 -6
- data/lib/rubocop/cop/cop.rb +54 -34
- data/lib/rubocop/cop/corrector.rb +33 -13
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +5 -9
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +10 -16
- data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +8 -5
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +8 -2
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +26 -10
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +3 -8
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +3 -3
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
- data/lib/rubocop/cop/documentation.rb +16 -6
- data/lib/rubocop/cop/exclude_limit.rb +1 -1
- data/lib/rubocop/cop/force.rb +12 -0
- data/lib/rubocop/cop/gemspec/dependency_version.rb +152 -0
- data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
- data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +5 -12
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +10 -2
- data/lib/rubocop/cop/gemspec/require_mfa.rb +25 -24
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +15 -4
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
- data/lib/rubocop/cop/generator/require_file_injector.rb +3 -3
- data/lib/rubocop/cop/generator.rb +12 -13
- data/lib/rubocop/cop/internal_affairs/cop_description.rb +122 -0
- data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
- data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/example_description.rb +46 -24
- data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
- data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/location_expression.rb +37 -0
- data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +4 -2
- data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +82 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +19 -20
- data/lib/rubocop/cop/internal_affairs/node_first_or_last_argument.rb +53 -0
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +128 -38
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
- data/lib/rubocop/cop/internal_affairs/processed_source_buffer_name.rb +42 -0
- data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/redundant_expect_offense_arguments.rb +34 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +12 -4
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +11 -2
- data/lib/rubocop/cop/internal_affairs/redundant_source_range.rb +66 -0
- data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -0
- data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
- data/lib/rubocop/cop/internal_affairs.rb +14 -0
- data/lib/rubocop/cop/layout/argument_alignment.rb +57 -9
- data/lib/rubocop/cop/layout/array_alignment.rb +1 -1
- data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
- data/lib/rubocop/cop/layout/block_alignment.rb +17 -13
- data/lib/rubocop/cop/layout/block_end_newline.rb +32 -10
- data/lib/rubocop/cop/layout/case_indentation.rb +17 -1
- data/lib/rubocop/cop/layout/class_structure.rb +44 -27
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +2 -3
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +3 -7
- data/lib/rubocop/cop/layout/comment_indentation.rb +6 -4
- data/lib/rubocop/cop/layout/condition_position.rb +1 -1
- data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
- data/lib/rubocop/cop/layout/dot_position.rb +2 -6
- data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
- data/lib/rubocop/cop/layout/empty_comment.rb +7 -5
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +42 -9
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +14 -7
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +29 -6
- data/lib/rubocop/cop/layout/empty_lines.rb +4 -2
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +7 -2
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +8 -2
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
- data/lib/rubocop/cop/layout/end_alignment.rb +24 -4
- data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
- data/lib/rubocop/cop/layout/extra_spacing.rb +13 -10
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +43 -32
- data/lib/rubocop/cop/layout/first_array_element_indentation.rb +45 -21
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +36 -9
- data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +52 -13
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +37 -2
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +58 -9
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +53 -20
- data/lib/rubocop/cop/layout/first_parameter_indentation.rb +2 -2
- data/lib/rubocop/cop/layout/hash_alignment.rb +8 -1
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +13 -7
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +13 -13
- data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
- data/lib/rubocop/cop/layout/indentation_style.rb +9 -4
- data/lib/rubocop/cop/layout/indentation_width.rb +20 -14
- data/lib/rubocop/cop/layout/initial_indentation.rb +3 -3
- data/lib/rubocop/cop/layout/leading_comment_space.rb +3 -3
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
- data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +144 -0
- data/lib/rubocop/cop/layout/line_continuation_spacing.rb +140 -0
- data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +4 -2
- data/lib/rubocop/cop/layout/line_length.rb +13 -6
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +32 -2
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +5 -3
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +30 -2
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +40 -3
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +40 -8
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
- data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +77 -0
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +9 -10
- data/lib/rubocop/cop/layout/redundant_line_break.rb +39 -18
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +8 -8
- data/lib/rubocop/cop/layout/single_line_block_chain.rb +6 -1
- data/lib/rubocop/cop/layout/space_after_comma.rb +9 -1
- data/lib/rubocop/cop/layout/space_after_not.rb +2 -2
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +3 -3
- data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -3
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +2 -2
- data/lib/rubocop/cop/layout/space_around_operators.rb +54 -22
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +24 -13
- data/lib/rubocop/cop/layout/space_before_brackets.rb +7 -0
- data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +2 -2
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +3 -3
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -30
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -0
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +35 -15
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +31 -4
- data/lib/rubocop/cop/layout/space_inside_parens.rb +3 -3
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +34 -0
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +1 -1
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +11 -7
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +7 -7
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +15 -10
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +15 -8
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
- data/lib/rubocop/cop/legacy/corrector.rb +1 -1
- data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +41 -8
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +11 -7
- data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
- data/lib/rubocop/cop/lint/ambiguous_range.rb +5 -5
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +6 -2
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +18 -8
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +3 -3
- data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +5 -1
- data/lib/rubocop/cop/lint/debugger.rb +70 -35
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +67 -111
- data/lib/rubocop/cop/lint/deprecated_constants.rb +9 -2
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +1 -1
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -3
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_hash_key.rb +3 -2
- data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
- data/lib/rubocop/cop/lint/duplicate_match_pattern.rb +122 -0
- data/lib/rubocop/cop/lint/duplicate_methods.rb +50 -20
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +56 -12
- data/lib/rubocop/cop/lint/duplicate_require.rb +11 -2
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
- data/lib/rubocop/cop/lint/else_layout.rb +6 -10
- data/lib/rubocop/cop/lint/empty_block.rb +5 -9
- data/lib/rubocop/cop/lint/empty_class.rb +4 -2
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +114 -4
- data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
- data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
- data/lib/rubocop/cop/lint/empty_file.rb +1 -1
- data/lib/rubocop/cop/lint/empty_in_pattern.rb +4 -2
- data/lib/rubocop/cop/lint/empty_interpolation.rb +2 -2
- data/lib/rubocop/cop/lint/empty_when.rb +4 -2
- data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +37 -31
- data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
- data/lib/rubocop/cop/lint/float_comparison.rb +11 -1
- data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -7
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +2 -1
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +17 -19
- data/lib/rubocop/cop/lint/identity_comparison.rb +0 -1
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +2 -2
- data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +20 -10
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +2 -2
- data/lib/rubocop/cop/lint/inherit_exception.rb +28 -28
- data/lib/rubocop/cop/lint/interpolation_check.rb +6 -5
- data/lib/rubocop/cop/lint/it_without_arguments_in_block.rb +56 -0
- data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +11 -4
- data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
- data/lib/rubocop/cop/lint/literal_assignment_in_condition.rb +85 -0
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +50 -4
- data/lib/rubocop/cop/lint/loop.rb +2 -2
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +19 -4
- data/lib/rubocop/cop/lint/missing_super.rb +64 -6
- data/lib/rubocop/cop/lint/mixed_case_range.rb +116 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -0
- data/lib/rubocop/cop/lint/nested_method_definition.rb +54 -10
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +11 -7
- data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +165 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +20 -10
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
- data/lib/rubocop/cop/lint/number_conversion.rb +46 -14
- data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +3 -3
- data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +4 -3
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +4 -6
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +17 -2
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +10 -4
- data/lib/rubocop/cop/lint/percent_string_array.rb +2 -2
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +2 -2
- data/lib/rubocop/cop/lint/raise_exception.rb +2 -2
- data/lib/rubocop/cop/lint/rand_one.rb +1 -1
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +55 -15
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +8 -8
- data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +12 -0
- data/lib/rubocop/cop/lint/redundant_regexp_quantifiers.rb +130 -0
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +57 -7
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +88 -11
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +2 -2
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +35 -15
- data/lib/rubocop/cop/lint/redundant_with_index.rb +19 -12
- data/lib/rubocop/cop/lint/redundant_with_object.rb +14 -13
- data/lib/rubocop/cop/lint/refinement_import_methods.rb +52 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +9 -3
- data/lib/rubocop/cop/lint/require_parentheses.rb +4 -2
- data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
- data/lib/rubocop/cop/lint/rescue_type.rb +2 -4
- data/lib/rubocop/cop/lint/return_in_void_context.rb +6 -18
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +54 -12
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +2 -2
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
- data/lib/rubocop/cop/lint/script_permission.rb +4 -4
- data/lib/rubocop/cop/lint/self_assignment.rb +39 -1
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +6 -6
- data/lib/rubocop/cop/lint/shadowed_argument.rb +2 -1
- data/lib/rubocop/cop/lint/shadowed_exception.rb +22 -23
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +42 -1
- data/lib/rubocop/cop/lint/struct_new_override.rb +15 -15
- data/lib/rubocop/cop/lint/suppressed_exception.rb +4 -4
- data/lib/rubocop/cop/lint/symbol_conversion.rb +12 -6
- data/lib/rubocop/cop/lint/syntax.rb +12 -6
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +24 -7
- data/lib/rubocop/cop/lint/to_json.rb +1 -1
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +24 -10
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +3 -3
- data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
- data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +2 -2
- data/lib/rubocop/cop/lint/unreachable_code.rb +5 -3
- data/lib/rubocop/cop/lint/unreachable_loop.rb +23 -11
- data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
- data/lib/rubocop/cop/lint/unused_method_argument.rb +8 -3
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +20 -15
- data/lib/rubocop/cop/lint/useless_assignment.rb +95 -11
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +2 -3
- data/lib/rubocop/cop/lint/useless_method_definition.rb +13 -5
- data/lib/rubocop/cop/lint/useless_rescue.rb +89 -0
- data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +16 -6
- data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
- data/lib/rubocop/cop/lint/useless_times.rb +17 -13
- data/lib/rubocop/cop/lint/void.rb +126 -25
- data/lib/rubocop/cop/metrics/abc_size.rb +8 -6
- data/lib/rubocop/cop/metrics/block_length.rb +18 -13
- data/lib/rubocop/cop/metrics/block_nesting.rb +3 -3
- data/lib/rubocop/cop/metrics/class_length.rb +17 -6
- data/lib/rubocop/cop/metrics/collection_literal_length.rb +76 -0
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -2
- data/lib/rubocop/cop/metrics/method_length.rb +19 -13
- data/lib/rubocop/cop/metrics/module_length.rb +10 -5
- data/lib/rubocop/cop/metrics/parameter_lists.rb +28 -1
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +6 -11
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +62 -12
- data/lib/rubocop/cop/migration/department_name.rb +3 -3
- data/lib/rubocop/cop/mixin/alignment.rb +2 -2
- data/lib/rubocop/cop/mixin/allowed_identifiers.rb +2 -2
- data/lib/rubocop/cop/mixin/allowed_methods.rb +23 -2
- data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
- data/lib/rubocop/cop/mixin/allowed_receivers.rb +34 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +14 -7
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
- data/lib/rubocop/cop/mixin/code_length.rb +12 -1
- data/lib/rubocop/cop/mixin/comments_help.rb +51 -3
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -9
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +1 -0
- data/lib/rubocop/cop/mixin/def_node.rb +3 -8
- data/lib/rubocop/cop/mixin/documentation_comment.rb +1 -1
- data/lib/rubocop/cop/mixin/duplication.rb +1 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -1
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +11 -7
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +4 -0
- data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +1 -1
- data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +189 -9
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +13 -9
- data/lib/rubocop/cop/mixin/heredoc.rb +6 -2
- data/lib/rubocop/cop/mixin/line_length_help.rb +28 -8
- data/lib/rubocop/cop/mixin/method_complexity.rb +28 -22
- data/lib/rubocop/cop/mixin/min_branches_count.rb +40 -0
- data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +34 -12
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +5 -6
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +7 -5
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +1 -1
- data/lib/rubocop/cop/mixin/percent_array.rb +58 -1
- data/lib/rubocop/cop/mixin/percent_literal.rb +1 -1
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +7 -9
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +2 -2
- data/lib/rubocop/cop/mixin/range_help.rb +28 -7
- data/lib/rubocop/cop/mixin/require_library.rb +2 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +5 -3
- data/lib/rubocop/cop/mixin/safe_assignment.rb +1 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
- data/lib/rubocop/cop/mixin/statement_modifier.rb +19 -4
- data/lib/rubocop/cop/mixin/string_help.rb +5 -3
- data/lib/rubocop/cop/mixin/surrounding_space.rb +17 -13
- data/lib/rubocop/cop/mixin/trailing_comma.rb +4 -4
- data/lib/rubocop/cop/mixin/visibility_help.rb +40 -5
- data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +2 -2
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/block_forwarding.rb +61 -16
- data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +4 -2
- data/lib/rubocop/cop/naming/constant_name.rb +5 -6
- data/lib/rubocop/cop/naming/file_name.rb +5 -5
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +4 -2
- data/lib/rubocop/cop/naming/inclusive_language.rb +32 -10
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +27 -12
- data/lib/rubocop/cop/naming/method_name.rb +9 -9
- data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
- data/lib/rubocop/cop/naming/predicate_name.rb +31 -2
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +13 -5
- data/lib/rubocop/cop/naming/variable_name.rb +15 -1
- data/lib/rubocop/cop/naming/variable_number.rb +28 -18
- data/lib/rubocop/cop/offense.rb +1 -1
- data/lib/rubocop/cop/registry.rb +74 -46
- data/lib/rubocop/cop/security/compound_hash.rb +106 -0
- data/lib/rubocop/cop/security/eval.rb +1 -1
- data/lib/rubocop/cop/security/json_load.rb +1 -1
- data/lib/rubocop/cop/security/marshal_load.rb +1 -1
- data/lib/rubocop/cop/security/open.rb +3 -3
- data/lib/rubocop/cop/security/yaml_load.rb +11 -5
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +142 -3
- data/lib/rubocop/cop/style/accessor_grouping.rb +53 -23
- data/lib/rubocop/cop/style/alias.rb +23 -13
- data/lib/rubocop/cop/style/and_or.rb +12 -12
- data/lib/rubocop/cop/style/arguments_forwarding.rb +414 -62
- data/lib/rubocop/cop/style/array_coercion.rb +1 -1
- data/lib/rubocop/cop/style/array_first_last.rb +64 -0
- data/lib/rubocop/cop/style/array_intersect.rb +119 -0
- data/lib/rubocop/cop/style/array_join.rb +1 -1
- data/lib/rubocop/cop/style/ascii_comments.rb +2 -2
- data/lib/rubocop/cop/style/attr.rb +12 -2
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +22 -15
- data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
- data/lib/rubocop/cop/style/begin_block.rb +1 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +1 -1
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +4 -4
- data/lib/rubocop/cop/style/block_comments.rb +4 -4
- data/lib/rubocop/cop/style/block_delimiters.rb +57 -15
- data/lib/rubocop/cop/style/case_equality.rb +41 -11
- data/lib/rubocop/cop/style/case_like_if.rb +27 -10
- data/lib/rubocop/cop/style/character_literal.rb +2 -2
- data/lib/rubocop/cop/style/class_and_module_children.rb +10 -17
- data/lib/rubocop/cop/style/class_check.rb +2 -1
- data/lib/rubocop/cop/style/class_equality_comparison.rb +80 -13
- data/lib/rubocop/cop/style/class_methods.rb +1 -1
- data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
- data/lib/rubocop/cop/style/class_vars.rb +4 -4
- data/lib/rubocop/cop/style/collection_compact.rb +48 -16
- data/lib/rubocop/cop/style/collection_methods.rb +5 -1
- data/lib/rubocop/cop/style/colon_method_call.rb +2 -2
- data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
- data/lib/rubocop/cop/style/combinable_loops.rb +39 -9
- data/lib/rubocop/cop/style/command_literal.rb +2 -2
- data/lib/rubocop/cop/style/comment_annotation.rb +2 -2
- data/lib/rubocop/cop/style/commented_keyword.rb +10 -7
- data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
- data/lib/rubocop/cop/style/concat_array_literals.rb +95 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +17 -21
- data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
- data/lib/rubocop/cop/style/copyright.rb +37 -24
- data/lib/rubocop/cop/style/data_inheritance.rb +75 -0
- data/lib/rubocop/cop/style/date_time.rb +7 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +17 -12
- data/lib/rubocop/cop/style/dir.rb +4 -1
- data/lib/rubocop/cop/style/dir_empty.rb +54 -0
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +2 -2
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +3 -3
- data/lib/rubocop/cop/style/documentation.rb +47 -35
- data/lib/rubocop/cop/style/documentation_method.rb +31 -5
- data/lib/rubocop/cop/style/double_negation.rb +62 -3
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +46 -11
- data/lib/rubocop/cop/style/each_with_object.rb +41 -10
- data/lib/rubocop/cop/style/empty_block_parameter.rb +3 -3
- data/lib/rubocop/cop/style/empty_case_condition.rb +9 -5
- data/lib/rubocop/cop/style/empty_else.rb +40 -3
- data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +3 -3
- data/lib/rubocop/cop/style/empty_literal.rb +3 -3
- data/lib/rubocop/cop/style/empty_method.rb +18 -3
- data/lib/rubocop/cop/style/encoding.rb +2 -2
- data/lib/rubocop/cop/style/end_block.rb +1 -1
- data/lib/rubocop/cop/style/endless_method.rb +2 -2
- data/lib/rubocop/cop/style/env_home.rb +56 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +15 -24
- data/lib/rubocop/cop/style/even_odd.rb +1 -1
- data/lib/rubocop/cop/style/exact_regexp_match.rb +70 -0
- data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
- data/lib/rubocop/cop/style/explicit_block_argument.rb +9 -5
- data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
- data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
- data/lib/rubocop/cop/style/file_empty.rb +71 -0
- data/lib/rubocop/cop/style/file_read.rb +3 -3
- data/lib/rubocop/cop/style/file_write.rb +13 -1
- data/lib/rubocop/cop/style/float_division.rb +1 -1
- data/lib/rubocop/cop/style/for.rb +10 -2
- data/lib/rubocop/cop/style/format_string.rb +34 -13
- data/lib/rubocop/cop/style/format_string_token.rb +73 -23
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +10 -5
- data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
- data/lib/rubocop/cop/style/global_vars.rb +1 -1
- data/lib/rubocop/cop/style/guard_clause.rb +187 -25
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +2 -1
- data/lib/rubocop/cop/style/hash_conversion.rb +11 -1
- data/lib/rubocop/cop/style/hash_each_methods.rb +132 -23
- data/lib/rubocop/cop/style/hash_except.rb +102 -10
- data/lib/rubocop/cop/style/hash_like_case.rb +4 -10
- data/lib/rubocop/cop/style/hash_syntax.rb +66 -6
- data/lib/rubocop/cop/style/hash_transform_keys.rb +7 -2
- data/lib/rubocop/cop/style/hash_transform_values.rb +5 -2
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +51 -7
- data/lib/rubocop/cop/style/if_inside_else.rb +6 -0
- data/lib/rubocop/cop/style/if_unless_modifier.rb +117 -20
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +37 -8
- data/lib/rubocop/cop/style/if_with_semicolon.rb +6 -6
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
- data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
- data/lib/rubocop/cop/style/inline_comment.rb +1 -1
- data/lib/rubocop/cop/style/inverse_methods.rb +23 -18
- data/lib/rubocop/cop/style/invertible_unless_condition.rb +160 -0
- data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
- data/lib/rubocop/cop/style/lambda.rb +4 -4
- data/lib/rubocop/cop/style/lambda_call.rb +18 -21
- data/lib/rubocop/cop/style/line_end_concatenation.rb +6 -3
- data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
- data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +134 -0
- data/lib/rubocop/cop/style/map_into_array.rb +175 -0
- data/lib/rubocop/cop/style/map_to_hash.rb +23 -10
- data/lib/rubocop/cop/style/map_to_set.rb +64 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +68 -30
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +6 -2
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +54 -49
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +42 -3
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
- data/lib/rubocop/cop/style/method_def_parentheses.rb +13 -6
- data/lib/rubocop/cop/style/min_max.rb +4 -4
- data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
- data/lib/rubocop/cop/style/missing_else.rb +37 -25
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +3 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +7 -7
- data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
- data/lib/rubocop/cop/style/module_function.rb +30 -8
- data/lib/rubocop/cop/style/multiline_block_chain.rb +5 -3
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -6
- data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
- data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
- data/lib/rubocop/cop/style/multiline_memoization.rb +3 -3
- data/lib/rubocop/cop/style/multiline_method_signature.rb +19 -7
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +54 -11
- data/lib/rubocop/cop/style/multiline_when_then.rb +2 -4
- data/lib/rubocop/cop/style/multiple_comparison.rb +15 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +18 -11
- data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
- data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +19 -15
- data/lib/rubocop/cop/style/next.rb +5 -7
- data/lib/rubocop/cop/style/nil_comparison.rb +3 -1
- data/lib/rubocop/cop/style/nil_lambda.rb +5 -5
- data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
- data/lib/rubocop/cop/style/not.rb +2 -2
- data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
- data/lib/rubocop/cop/style/numbered_parameters_limit.rb +12 -4
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +2 -2
- data/lib/rubocop/cop/style/numeric_literals.rb +16 -1
- data/lib/rubocop/cop/style/numeric_predicate.rb +63 -13
- data/lib/rubocop/cop/style/object_then.rb +76 -0
- data/lib/rubocop/cop/style/one_line_conditional.rb +5 -8
- data/lib/rubocop/cop/style/open_struct_use.rb +2 -2
- data/lib/rubocop/cop/style/operator_method_call.rb +73 -0
- data/lib/rubocop/cop/style/option_hash.rb +1 -1
- data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +5 -4
- data/lib/rubocop/cop/style/or_assignment.rb +1 -1
- data/lib/rubocop/cop/style/parallel_assignment.rb +32 -24
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +9 -1
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +3 -4
- data/lib/rubocop/cop/style/percent_q_literals.rb +2 -2
- data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +2 -2
- data/lib/rubocop/cop/style/proc.rb +5 -2
- data/lib/rubocop/cop/style/quoted_symbols.rb +2 -2
- data/lib/rubocop/cop/style/raise_args.rb +14 -5
- data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
- data/lib/rubocop/cop/style/redundant_argument.rb +38 -6
- data/lib/rubocop/cop/style/redundant_array_constructor.rb +77 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +11 -3
- data/lib/rubocop/cop/style/redundant_begin.rb +32 -14
- data/lib/rubocop/cop/style/redundant_capital_w.rb +2 -3
- data/lib/rubocop/cop/style/redundant_condition.rb +148 -14
- data/lib/rubocop/cop/style/redundant_conditional.rb +3 -15
- data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
- data/lib/rubocop/cop/style/redundant_current_directory_in_path.rb +39 -0
- data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +133 -0
- data/lib/rubocop/cop/style/redundant_each.rb +119 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +33 -13
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +10 -8
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
- data/lib/rubocop/cop/style/redundant_filter_chain.rb +118 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
- data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
- data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
- data/lib/rubocop/cop/style/redundant_interpolation.rb +24 -3
- data/lib/rubocop/cop/style/redundant_line_continuation.rb +200 -0
- data/lib/rubocop/cop/style/redundant_parentheses.rb +92 -45
- data/lib/rubocop/cop/style/redundant_percent_q.rb +3 -3
- data/lib/rubocop/cop/style/redundant_regexp_argument.rb +100 -0
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +15 -4
- data/lib/rubocop/cop/style/redundant_regexp_constructor.rb +46 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +24 -6
- data/lib/rubocop/cop/style/redundant_return.rb +22 -4
- data/lib/rubocop/cop/style/redundant_self.rb +20 -3
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +3 -4
- data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +9 -2
- data/lib/rubocop/cop/style/redundant_sort.rb +34 -18
- data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
- data/lib/rubocop/cop/style/redundant_string_escape.rb +185 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +11 -2
- data/lib/rubocop/cop/style/require_order.rb +139 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +2 -4
- data/lib/rubocop/cop/style/rescue_standard_error.rb +15 -15
- data/lib/rubocop/cop/style/return_nil.rb +6 -2
- data/lib/rubocop/cop/style/return_nil_in_predicate_method_definition.rb +95 -0
- data/lib/rubocop/cop/style/safe_navigation.rb +58 -19
- data/lib/rubocop/cop/style/sample.rb +9 -8
- data/lib/rubocop/cop/style/select_by_regexp.rb +37 -13
- data/lib/rubocop/cop/style/self_assignment.rb +4 -4
- data/lib/rubocop/cop/style/semicolon.rb +72 -9
- data/lib/rubocop/cop/style/send.rb +5 -5
- data/lib/rubocop/cop/style/send_with_literal_method_name.rb +90 -0
- data/lib/rubocop/cop/style/signal_exception.rb +10 -8
- data/lib/rubocop/cop/style/single_argument_dig.rb +11 -2
- data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
- data/lib/rubocop/cop/style/single_line_do_end_block.rb +67 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +3 -3
- data/lib/rubocop/cop/style/slicing_with_range.rb +77 -11
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +103 -33
- data/lib/rubocop/cop/style/special_global_vars.rb +66 -10
- data/lib/rubocop/cop/style/static_class.rb +33 -2
- data/lib/rubocop/cop/style/stderr_puts.rb +2 -2
- data/lib/rubocop/cop/style/string_chars.rb +2 -1
- data/lib/rubocop/cop/style/string_concatenation.rb +13 -8
- data/lib/rubocop/cop/style/string_hash_keys.rb +5 -2
- data/lib/rubocop/cop/style/string_literals.rb +1 -5
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +30 -5
- data/lib/rubocop/cop/style/string_methods.rb +1 -1
- data/lib/rubocop/cop/style/strip.rb +8 -5
- data/lib/rubocop/cop/style/struct_inheritance.rb +5 -5
- data/lib/rubocop/cop/style/super_arguments.rb +156 -0
- data/lib/rubocop/cop/style/super_with_args_parentheses.rb +35 -0
- data/lib/rubocop/cop/style/swap_values.rb +4 -2
- data/lib/rubocop/cop/style/symbol_array.rb +46 -21
- data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
- data/lib/rubocop/cop/style/symbol_proc.rb +135 -16
- data/lib/rubocop/cop/style/ternary_parentheses.rb +19 -18
- data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +2 -1
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +5 -5
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -2
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -2
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +2 -5
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +2 -2
- data/lib/rubocop/cop/style/trivial_accessors.rb +12 -10
- data/lib/rubocop/cop/style/unless_else.rb +5 -1
- data/lib/rubocop/cop/style/unless_logical_operators.rb +2 -1
- data/lib/rubocop/cop/style/unpack_first.rb +15 -15
- data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
- data/lib/rubocop/cop/style/when_then.rb +1 -1
- data/lib/rubocop/cop/style/word_array.rb +60 -6
- data/lib/rubocop/cop/style/yaml_file_read.rb +66 -0
- data/lib/rubocop/cop/style/yoda_condition.rb +18 -9
- data/lib/rubocop/cop/style/yoda_expression.rb +91 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +41 -20
- data/lib/rubocop/cop/team.rb +70 -58
- data/lib/rubocop/cop/util.rb +45 -9
- data/lib/rubocop/cop/utils/regexp_ranges.rb +113 -0
- data/lib/rubocop/cop/variable_force/assignment.rb +45 -4
- data/lib/rubocop/cop/variable_force/branch.rb +1 -1
- data/lib/rubocop/cop/variable_force/scope.rb +3 -3
- data/lib/rubocop/cop/variable_force/variable.rb +5 -3
- data/lib/rubocop/cop/variable_force/variable_table.rb +6 -4
- data/lib/rubocop/cop/variable_force.rb +20 -35
- data/lib/rubocop/cops_documentation_generator.rb +81 -22
- data/lib/rubocop/directive_comment.rb +14 -12
- data/lib/rubocop/ext/comment.rb +18 -0
- data/lib/rubocop/ext/processed_source.rb +2 -0
- data/lib/rubocop/ext/range.rb +15 -0
- data/lib/rubocop/ext/regexp_node.rb +10 -5
- data/lib/rubocop/ext/regexp_parser.rb +5 -2
- data/lib/rubocop/feature_loader.rb +94 -0
- data/lib/rubocop/file_finder.rb +4 -7
- data/lib/rubocop/file_patterns.rb +43 -0
- data/lib/rubocop/formatter/clang_style_formatter.rb +4 -8
- data/lib/rubocop/formatter/disabled_config_formatter.rb +66 -17
- data/lib/rubocop/formatter/formatter_set.rb +27 -19
- data/lib/rubocop/formatter/{git_hub_actions_formatter.rb → github_actions_formatter.rb} +15 -2
- data/lib/rubocop/formatter/html_formatter.rb +39 -26
- data/lib/rubocop/formatter/json_formatter.rb +0 -1
- data/lib/rubocop/formatter/junit_formatter.rb +4 -1
- data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +25 -6
- data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
- data/lib/rubocop/formatter/tap_formatter.rb +4 -8
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -4
- data/lib/rubocop/formatter.rb +34 -0
- data/lib/rubocop/lockfile.rb +56 -7
- data/lib/rubocop/lsp/logger.rb +22 -0
- data/lib/rubocop/lsp/routes.rb +243 -0
- data/lib/rubocop/lsp/runtime.rb +99 -0
- data/lib/rubocop/lsp/server.rb +73 -0
- data/lib/rubocop/lsp/severity.rb +27 -0
- data/lib/rubocop/lsp.rb +36 -0
- data/lib/rubocop/magic_comment.rb +43 -15
- data/lib/rubocop/options.rb +183 -59
- data/lib/rubocop/path_util.rb +54 -22
- data/lib/rubocop/rake_task.rb +35 -10
- data/lib/rubocop/result_cache.rb +31 -17
- data/lib/rubocop/rspec/cop_helper.rb +33 -4
- data/lib/rubocop/rspec/expect_offense.rb +21 -11
- data/lib/rubocop/rspec/parallel_formatter.rb +1 -1
- data/lib/rubocop/rspec/shared_contexts.rb +100 -23
- data/lib/rubocop/rspec/support.rb +19 -2
- data/lib/rubocop/runner.rb +125 -31
- data/lib/rubocop/server/cache.rb +155 -0
- data/lib/rubocop/server/cli.rb +147 -0
- data/lib/rubocop/server/client_command/base.rb +44 -0
- data/lib/rubocop/server/client_command/exec.rb +64 -0
- data/lib/rubocop/server/client_command/restart.rb +25 -0
- data/lib/rubocop/server/client_command/start.rb +48 -0
- data/lib/rubocop/server/client_command/status.rb +28 -0
- data/lib/rubocop/server/client_command/stop.rb +31 -0
- data/lib/rubocop/server/client_command.rb +26 -0
- data/lib/rubocop/server/core.rb +111 -0
- data/lib/rubocop/server/errors.rb +23 -0
- data/lib/rubocop/server/helper.rb +34 -0
- data/lib/rubocop/server/server_command/base.rb +50 -0
- data/lib/rubocop/server/server_command/exec.rb +33 -0
- data/lib/rubocop/server/server_command/stop.rb +24 -0
- data/lib/rubocop/server/server_command.rb +21 -0
- data/lib/rubocop/server/socket_reader.rb +69 -0
- data/lib/rubocop/server.rb +53 -0
- data/lib/rubocop/string_interpreter.rb +7 -7
- data/lib/rubocop/target_finder.rb +92 -82
- data/lib/rubocop/target_ruby.rb +92 -78
- data/lib/rubocop/version.rb +44 -12
- data/lib/rubocop.rb +83 -35
- metadata +170 -45
- data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -49
- data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
data/lib/rubocop/path_util.rb
CHANGED
@@ -3,41 +3,63 @@
|
|
3
3
|
module RuboCop
|
4
4
|
# Common methods and behaviors for dealing with paths.
|
5
5
|
module PathUtil
|
6
|
+
class << self
|
7
|
+
attr_accessor :relative_paths_cache
|
8
|
+
end
|
9
|
+
self.relative_paths_cache = Hash.new { |hash, key| hash[key] = {} }
|
10
|
+
|
6
11
|
module_function
|
7
12
|
|
8
13
|
def relative_path(path, base_dir = Dir.pwd)
|
9
|
-
|
10
|
-
|
11
|
-
|
12
|
-
|
13
|
-
|
14
|
-
|
15
|
-
|
16
|
-
|
17
|
-
|
18
|
-
|
19
|
-
|
20
|
-
|
21
|
-
|
22
|
-
|
14
|
+
PathUtil.relative_paths_cache[base_dir][path] ||=
|
15
|
+
# Optimization for the common case where path begins with the base
|
16
|
+
# dir. Just cut off the first part.
|
17
|
+
if path.start_with?(base_dir)
|
18
|
+
base_dir_length = base_dir.length
|
19
|
+
result_length = path.length - base_dir_length - 1
|
20
|
+
path[base_dir_length + 1, result_length]
|
21
|
+
else
|
22
|
+
path_name = Pathname.new(File.expand_path(path))
|
23
|
+
begin
|
24
|
+
path_name.relative_path_from(Pathname.new(base_dir)).to_s
|
25
|
+
rescue ArgumentError
|
26
|
+
path
|
27
|
+
end
|
28
|
+
end
|
23
29
|
end
|
24
30
|
|
31
|
+
SMART_PATH_CACHE = {} # rubocop:disable Style/MutableConstant
|
32
|
+
private_constant :SMART_PATH_CACHE
|
33
|
+
|
25
34
|
def smart_path(path)
|
26
|
-
|
27
|
-
|
35
|
+
SMART_PATH_CACHE[path] ||= begin
|
36
|
+
# Ideally, we calculate this relative to the project root.
|
37
|
+
base_dir = Dir.pwd
|
28
38
|
|
29
|
-
|
30
|
-
|
31
|
-
|
32
|
-
|
39
|
+
if path.start_with? base_dir
|
40
|
+
relative_path(path, base_dir)
|
41
|
+
else
|
42
|
+
path
|
43
|
+
end
|
33
44
|
end
|
34
45
|
end
|
35
46
|
|
47
|
+
# rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
|
36
48
|
def match_path?(pattern, path)
|
37
49
|
case pattern
|
38
50
|
when String
|
39
|
-
|
40
|
-
|
51
|
+
matches =
|
52
|
+
if pattern == path
|
53
|
+
true
|
54
|
+
elsif glob?(pattern)
|
55
|
+
# File name matching doesn't really work with relative patterns that start with "..". We
|
56
|
+
# get around that problem by converting the pattern to an absolute path.
|
57
|
+
pattern = File.expand_path(pattern) if pattern.start_with?('..')
|
58
|
+
|
59
|
+
File.fnmatch?(pattern, path, File::FNM_PATHNAME | File::FNM_EXTGLOB)
|
60
|
+
end
|
61
|
+
|
62
|
+
matches || hidden_file_in_not_hidden_dir?(pattern, path)
|
41
63
|
when Regexp
|
42
64
|
begin
|
43
65
|
pattern.match?(path)
|
@@ -48,12 +70,18 @@ module RuboCop
|
|
48
70
|
end
|
49
71
|
end
|
50
72
|
end
|
73
|
+
# rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
|
51
74
|
|
52
75
|
# Returns true for an absolute Unix or Windows path.
|
53
76
|
def absolute?(path)
|
54
77
|
%r{\A([A-Z]:)?/}i.match?(path)
|
55
78
|
end
|
56
79
|
|
80
|
+
# Returns true for a glob
|
81
|
+
def glob?(path)
|
82
|
+
path.match?(/[*{\[?]/)
|
83
|
+
end
|
84
|
+
|
57
85
|
def hidden_file_in_not_hidden_dir?(pattern, path)
|
58
86
|
hidden_file?(path) &&
|
59
87
|
File.fnmatch?(
|
@@ -67,8 +95,12 @@ module RuboCop
|
|
67
95
|
maybe_hidden_file?(path) && File.basename(path).start_with?('.')
|
68
96
|
end
|
69
97
|
|
98
|
+
HIDDEN_FILE_PATTERN = "#{File::SEPARATOR}."
|
99
|
+
|
70
100
|
# Loose check to reduce memory allocations
|
71
101
|
def maybe_hidden_file?(path)
|
102
|
+
return false unless path.include?(HIDDEN_FILE_PATTERN)
|
103
|
+
|
72
104
|
separator_index = path.rindex(File::SEPARATOR)
|
73
105
|
return false unless separator_index
|
74
106
|
|
data/lib/rubocop/rake_task.rb
CHANGED
@@ -32,10 +32,19 @@ module RuboCop
|
|
32
32
|
|
33
33
|
private
|
34
34
|
|
35
|
+
def perform(option)
|
36
|
+
options = full_options.unshift(option)
|
37
|
+
# `parallel` will automatically be removed from the options internally.
|
38
|
+
# This is a nice to have to suppress the warning message
|
39
|
+
# about --parallel and --autocorrect not being compatible.
|
40
|
+
options.delete('--parallel')
|
41
|
+
run_cli(verbose, options)
|
42
|
+
end
|
43
|
+
|
35
44
|
def run_cli(verbose, options)
|
36
45
|
# We lazy-load RuboCop so that the task doesn't dramatically impact the
|
37
46
|
# load time of your Rakefile.
|
38
|
-
|
47
|
+
require_relative '../rubocop'
|
39
48
|
|
40
49
|
cli = CLI.new
|
41
50
|
puts 'Running RuboCop...' if verbose
|
@@ -60,19 +69,35 @@ module RuboCop
|
|
60
69
|
@formatters = []
|
61
70
|
end
|
62
71
|
|
63
|
-
def setup_subtasks(name, *args, &task_block)
|
72
|
+
def setup_subtasks(name, *args, &task_block) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
|
64
73
|
namespace(name) do
|
65
|
-
|
74
|
+
# rubocop:todo Naming/InclusiveLanguage
|
75
|
+
task(:auto_correct, *args) do
|
76
|
+
require 'rainbow'
|
77
|
+
warn Rainbow(
|
78
|
+
'rubocop:auto_correct task is deprecated; ' \
|
79
|
+
'use rubocop:autocorrect task or rubocop:autocorrect_all task instead.'
|
80
|
+
).yellow
|
81
|
+
RakeFileUtils.verbose(verbose) do
|
82
|
+
yield(*[self, task_args].slice(0, task_block.arity)) if task_block
|
83
|
+
perform('--autocorrect')
|
84
|
+
end
|
85
|
+
end
|
86
|
+
# rubocop:enable Naming/InclusiveLanguage
|
87
|
+
|
88
|
+
desc "Autocorrect RuboCop offenses (only when it's safe)."
|
89
|
+
task(:autocorrect, *args) do |_, task_args|
|
90
|
+
RakeFileUtils.verbose(verbose) do
|
91
|
+
yield(*[self, task_args].slice(0, task_block.arity)) if task_block
|
92
|
+
perform('--autocorrect')
|
93
|
+
end
|
94
|
+
end
|
66
95
|
|
67
|
-
|
96
|
+
desc 'Autocorrect RuboCop offenses (safe and unsafe).'
|
97
|
+
task(:autocorrect_all, *args) do |_, task_args|
|
68
98
|
RakeFileUtils.verbose(verbose) do
|
69
99
|
yield(*[self, task_args].slice(0, task_block.arity)) if task_block
|
70
|
-
|
71
|
-
# `parallel` will automatically be removed from the options internally.
|
72
|
-
# This is a nice to have to suppress the warning message
|
73
|
-
# about parallel and auto-correct not being compatible.
|
74
|
-
options.delete('--parallel')
|
75
|
-
run_cli(verbose, options)
|
100
|
+
perform('--autocorrect-all')
|
76
101
|
end
|
77
102
|
end
|
78
103
|
end
|
data/lib/rubocop/result_cache.rb
CHANGED
@@ -2,16 +2,23 @@
|
|
2
2
|
|
3
3
|
require 'digest/sha1'
|
4
4
|
require 'find'
|
5
|
-
require 'etc'
|
6
5
|
require 'zlib'
|
6
|
+
require_relative 'cache_config'
|
7
7
|
|
8
8
|
module RuboCop
|
9
9
|
# Provides functionality for caching RuboCop runs.
|
10
10
|
# @api private
|
11
11
|
class ResultCache
|
12
|
-
NON_CHANGING = %i[color format formatters out debug fail_level
|
12
|
+
NON_CHANGING = %i[color format formatters out debug fail_level
|
13
|
+
fix_layout autocorrect safe_autocorrect autocorrect_all
|
13
14
|
cache fail_fast stdin parallel].freeze
|
14
15
|
|
16
|
+
DL_EXTENSIONS = ::RbConfig::CONFIG
|
17
|
+
.values_at('DLEXT', 'DLEXT2')
|
18
|
+
.reject { |ext| !ext || ext.empty? }
|
19
|
+
.map { |ext| ".#{ext}" }
|
20
|
+
.freeze
|
21
|
+
|
15
22
|
# Remove old files so that the cache doesn't grow too big. When the
|
16
23
|
# threshold MaxFilesInCache has been exceeded, the oldest 50% of all the
|
17
24
|
# files in the cache are removed. The reason for removing so much is that
|
@@ -45,7 +52,7 @@ module RuboCop
|
|
45
52
|
def remove_oldest_files(files, dirs, cache_root, verbose)
|
46
53
|
# Add 1 to half the number of files, so that we remove the file if
|
47
54
|
# there's only 1 left.
|
48
|
-
remove_count =
|
55
|
+
remove_count = (files.length / 2) + 1
|
49
56
|
puts "Removing the #{remove_count} oldest files from #{cache_root}" if verbose
|
50
57
|
sorted = files.sort_by { |path| File.mtime(path) }
|
51
58
|
remove_files(sorted, dirs, remove_count)
|
@@ -66,26 +73,19 @@ module RuboCop
|
|
66
73
|
end
|
67
74
|
|
68
75
|
def self.cache_root(config_store)
|
69
|
-
|
70
|
-
|
71
|
-
|
72
|
-
# Include user ID in the path to make sure the user has write
|
73
|
-
# access.
|
74
|
-
File.join(ENV['XDG_CACHE_HOME'], Process.uid.to_s)
|
75
|
-
else
|
76
|
-
File.join(ENV['HOME'], '.cache')
|
77
|
-
end
|
78
|
-
File.join(root, 'rubocop_cache')
|
76
|
+
CacheConfig.root_dir do
|
77
|
+
config_store.for_pwd.for_all_cops['CacheRootDirectory']
|
78
|
+
end
|
79
79
|
end
|
80
80
|
|
81
81
|
def self.allow_symlinks_in_cache_location?(config_store)
|
82
82
|
config_store.for_pwd.for_all_cops['AllowSymlinksInCacheRootDirectory']
|
83
83
|
end
|
84
84
|
|
85
|
-
|
85
|
+
attr_reader :path
|
86
86
|
|
87
87
|
def initialize(file, team, options, config_store, cache_root = nil)
|
88
|
-
cache_root ||= options[:cache_root]
|
88
|
+
cache_root ||= File.join(options[:cache_root], 'rubocop_cache') if options[:cache_root]
|
89
89
|
cache_root ||= ResultCache.cache_root(config_store)
|
90
90
|
@allow_symlinks_in_cache_location =
|
91
91
|
ResultCache.allow_symlinks_in_cache_location?(config_store)
|
@@ -179,18 +179,32 @@ module RuboCop
|
|
179
179
|
.select { |path| File.file?(path) }
|
180
180
|
.sort!
|
181
181
|
.each do |path|
|
182
|
-
|
183
|
-
digest << Zlib.crc32(content).to_s # mtime not reliable
|
182
|
+
digest << digest(path)
|
184
183
|
end
|
185
184
|
digest << RuboCop::Version::STRING << RuboCop::AST::Version::STRING
|
186
185
|
digest.hexdigest
|
187
186
|
end
|
188
187
|
end
|
189
188
|
|
189
|
+
def digest(path)
|
190
|
+
content = if path.end_with?(*DL_EXTENSIONS)
|
191
|
+
# Shared libraries often contain timestamps of when
|
192
|
+
# they were compiled and other non-stable data.
|
193
|
+
File.basename(path)
|
194
|
+
else
|
195
|
+
File.binread(path) # mtime not reliable
|
196
|
+
end
|
197
|
+
Zlib.crc32(content).to_s
|
198
|
+
end
|
199
|
+
|
190
200
|
def rubocop_extra_features
|
191
201
|
lib_root = File.join(File.dirname(__FILE__), '..')
|
192
202
|
exe_root = File.join(lib_root, '..', 'exe')
|
193
203
|
|
204
|
+
# Make sure to use an absolute path to prevent errors on Windows
|
205
|
+
# when traversing the relative paths with symlinks.
|
206
|
+
exe_root = File.absolute_path(exe_root)
|
207
|
+
|
194
208
|
# These are all the files we have `require`d plus everything in the
|
195
209
|
# exe directory. A change to any of them could affect the cop output
|
196
210
|
# so we include them in the cache hash.
|
@@ -6,7 +6,11 @@ require 'tempfile'
|
|
6
6
|
module CopHelper
|
7
7
|
extend RSpec::SharedContext
|
8
8
|
|
9
|
-
let(:ruby_version)
|
9
|
+
let(:ruby_version) do
|
10
|
+
# The minimum version Prism can parse is 3.3.
|
11
|
+
ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : RuboCop::TargetRuby::DEFAULT_VERSION
|
12
|
+
end
|
13
|
+
let(:parser_engine) { ENV.fetch('PARSER_ENGINE', :parser_whitequark).to_sym }
|
10
14
|
let(:rails_version) { false }
|
11
15
|
|
12
16
|
def inspect_source(source, file = nil)
|
@@ -28,7 +32,32 @@ module CopHelper
|
|
28
32
|
file = file.path
|
29
33
|
end
|
30
34
|
|
31
|
-
RuboCop::ProcessedSource.new(
|
35
|
+
processed_source = RuboCop::ProcessedSource.new(
|
36
|
+
source, ruby_version, file, parser_engine: parser_engine
|
37
|
+
)
|
38
|
+
processed_source.config = configuration
|
39
|
+
processed_source.registry = registry
|
40
|
+
processed_source
|
41
|
+
end
|
42
|
+
|
43
|
+
def configuration
|
44
|
+
@configuration ||= if defined?(config)
|
45
|
+
config
|
46
|
+
else
|
47
|
+
RuboCop::Config.new({}, "#{Dir.pwd}/.rubocop.yml")
|
48
|
+
end
|
49
|
+
end
|
50
|
+
|
51
|
+
def registry
|
52
|
+
@registry ||= begin
|
53
|
+
keys = configuration.keys
|
54
|
+
cops =
|
55
|
+
keys.map { |directive| RuboCop::Cop::Registry.global.find_cops_by_directive(directive) }
|
56
|
+
.flatten
|
57
|
+
cops << cop_class if defined?(cop_class) && !cops.include?(cop_class)
|
58
|
+
cops.compact!
|
59
|
+
RuboCop::Cop::Registry.new(cops)
|
60
|
+
end
|
32
61
|
end
|
33
62
|
|
34
63
|
def autocorrect_source_file(source)
|
@@ -38,7 +67,7 @@ module CopHelper
|
|
38
67
|
def autocorrect_source(source, file = nil)
|
39
68
|
RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
|
40
69
|
RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}
|
41
|
-
cop.instance_variable_get(:@options)[:
|
70
|
+
cop.instance_variable_get(:@options)[:autocorrect] = true
|
42
71
|
processed_source = parse_source(source, file)
|
43
72
|
_investigate(cop, processed_source)
|
44
73
|
|
@@ -46,7 +75,7 @@ module CopHelper
|
|
46
75
|
end
|
47
76
|
|
48
77
|
def _investigate(cop, processed_source)
|
49
|
-
team = RuboCop::Cop::Team.new([cop],
|
78
|
+
team = RuboCop::Cop::Team.new([cop], configuration, raise_error: true)
|
50
79
|
report = team.investigate(processed_source)
|
51
80
|
@last_corrector = report.correctors.first || RuboCop::Cop::Corrector.new(processed_source)
|
52
81
|
report.offenses.reject(&:disabled?)
|
@@ -6,7 +6,7 @@ module RuboCop
|
|
6
6
|
#
|
7
7
|
# This mixin makes it easier to specify strict offense expectations
|
8
8
|
# in a declarative and visual fashion. Just type out the code that
|
9
|
-
# should generate
|
9
|
+
# should generate an offense, annotate code by writing '^'s
|
10
10
|
# underneath each character that should be highlighted, and follow
|
11
11
|
# the carets with a string (separated by a space) that is the
|
12
12
|
# message of the offense. You can include multiple offenses in
|
@@ -38,7 +38,7 @@ module RuboCop
|
|
38
38
|
# 'Avoid chaining a method call on a do...end block.'
|
39
39
|
# )
|
40
40
|
#
|
41
|
-
#
|
41
|
+
# Autocorrection can be tested using `expect_correction` after
|
42
42
|
# `expect_offense`.
|
43
43
|
#
|
44
44
|
# @example `expect_offense` and `expect_correction`
|
@@ -58,7 +58,7 @@ module RuboCop
|
|
58
58
|
# that there were no offenses. The `expect_offense` method has
|
59
59
|
# to do more work by parsing out lines that contain carets.
|
60
60
|
#
|
61
|
-
# If the code produces an offense that could not be
|
61
|
+
# If the code produces an offense that could not be autocorrected, you can
|
62
62
|
# use `expect_no_corrections` after `expect_offense`.
|
63
63
|
#
|
64
64
|
# @example `expect_offense` and `expect_no_corrections`
|
@@ -111,6 +111,7 @@ module RuboCop
|
|
111
111
|
source
|
112
112
|
end
|
113
113
|
|
114
|
+
# rubocop:disable Metrics/AbcSize
|
114
115
|
def expect_offense(source, file = nil, severity: nil, chomp: false, **replacements)
|
115
116
|
expected_annotations = parse_annotations(source, **replacements)
|
116
117
|
source = expected_annotations.plain_source
|
@@ -123,8 +124,15 @@ module RuboCop
|
|
123
124
|
expect(actual_annotations).to eq(expected_annotations), ''
|
124
125
|
expect(@offenses.map(&:severity).uniq).to eq([severity]) if severity
|
125
126
|
|
127
|
+
# Validate that all offenses have a range that formatters can display
|
128
|
+
expect do
|
129
|
+
@offenses.each { |offense| offense.location.source_line }
|
130
|
+
end.not_to raise_error, 'One of the offenses has a misconstructed range, for ' \
|
131
|
+
'example if the offense is on line 1 and the source is empty'
|
132
|
+
|
126
133
|
@offenses
|
127
134
|
end
|
135
|
+
# rubocop:enable Metrics/AbcSize
|
128
136
|
|
129
137
|
# rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity
|
130
138
|
def expect_correction(correction, loop: true, source: nil)
|
@@ -138,6 +146,8 @@ module RuboCop
|
|
138
146
|
|
139
147
|
source = @processed_source.raw_source
|
140
148
|
|
149
|
+
raise 'Use `expect_no_corrections` if the code will not change' if correction == source
|
150
|
+
|
141
151
|
iteration = 0
|
142
152
|
new_source = loop do
|
143
153
|
iteration += 1
|
@@ -146,7 +156,6 @@ module RuboCop
|
|
146
156
|
|
147
157
|
break corrected_source unless loop
|
148
158
|
break corrected_source if @last_corrector.empty?
|
149
|
-
break corrected_source if corrected_source == @processed_source.buffer.source
|
150
159
|
|
151
160
|
if iteration > RuboCop::Runner::MAX_ITERATIONS
|
152
161
|
raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [@offenses])
|
@@ -157,7 +166,7 @@ module RuboCop
|
|
157
166
|
_investigate(cop, @processed_source)
|
158
167
|
end
|
159
168
|
|
160
|
-
raise '
|
169
|
+
raise 'Expected correction but no corrections were made' if new_source == source
|
161
170
|
|
162
171
|
expect(new_source).to eq(correction)
|
163
172
|
end
|
@@ -168,12 +177,13 @@ module RuboCop
|
|
168
177
|
|
169
178
|
return if @last_corrector.empty?
|
170
179
|
|
171
|
-
#
|
172
|
-
# we need to run the actual corrections
|
173
|
-
|
180
|
+
# This is just here for a pretty diff if the source actually got changed
|
174
181
|
new_source = @last_corrector.rewrite
|
175
|
-
|
176
182
|
expect(new_source).to eq(@processed_source.buffer.source)
|
183
|
+
|
184
|
+
# There is an infinite loop if a corrector is present that did not make
|
185
|
+
# any changes. It will cause the same offense/correction on the next loop.
|
186
|
+
raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [@offenses])
|
177
187
|
end
|
178
188
|
|
179
189
|
def expect_no_offenses(source, file = nil)
|
@@ -205,12 +215,12 @@ module RuboCop
|
|
205
215
|
def set_formatter_options
|
206
216
|
RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
|
207
217
|
RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}
|
208
|
-
cop.instance_variable_get(:@options)[:
|
218
|
+
cop.instance_variable_get(:@options)[:autocorrect] = true
|
209
219
|
end
|
210
220
|
|
211
221
|
# Parsed representation of code annotated with the `^^^ Message` style
|
212
222
|
class AnnotatedSource
|
213
|
-
ANNOTATION_PATTERN = /\A\s*(\^+|\^{})
|
223
|
+
ANNOTATION_PATTERN = /\A\s*(\^+|\^{}) ?/.freeze
|
214
224
|
ABBREV = "[...]\n"
|
215
225
|
|
216
226
|
# @param annotated_source [String] string passed to the matchers
|
@@ -65,7 +65,7 @@ module RuboCop
|
|
65
65
|
# removed!
|
66
66
|
def output_rerun_commands(summary)
|
67
67
|
output.puts '# RERUN BEGIN'
|
68
|
-
output.puts summary.colorized_rerun_commands.lines[3
|
68
|
+
output.puts summary.colorized_rerun_commands.lines[3..].join
|
69
69
|
output.puts '# RERUN END'
|
70
70
|
end
|
71
71
|
|
@@ -2,15 +2,17 @@
|
|
2
2
|
|
3
3
|
require 'tmpdir'
|
4
4
|
|
5
|
-
RSpec.shared_context 'isolated environment'
|
5
|
+
RSpec.shared_context 'isolated environment' do # rubocop:disable Metrics/BlockLength
|
6
6
|
around do |example|
|
7
7
|
Dir.mktmpdir do |tmpdir|
|
8
|
-
original_home =
|
9
|
-
original_xdg_config_home = ENV
|
8
|
+
original_home = Dir.home
|
9
|
+
original_xdg_config_home = ENV.fetch('XDG_CONFIG_HOME', nil)
|
10
10
|
|
11
11
|
# Make sure to expand all symlinks in the path first. Otherwise we may
|
12
12
|
# get mismatched pathnames when loading config files later on.
|
13
13
|
tmpdir = File.realpath(tmpdir)
|
14
|
+
# Make upwards search for .rubocop.yml files stop at this directory.
|
15
|
+
RuboCop::FileFinder.root_level = tmpdir
|
14
16
|
|
15
17
|
virtual_home = File.expand_path(File.join(tmpdir, 'home'))
|
16
18
|
Dir.mkdir(virtual_home)
|
@@ -21,9 +23,6 @@ RSpec.shared_context 'isolated environment', :isolated_environment do
|
|
21
23
|
root = example.metadata[:root]
|
22
24
|
working_dir = root ? File.join(base_dir, 'work', root) : File.join(base_dir, 'work')
|
23
25
|
|
24
|
-
# Make upwards search for .rubocop.yml files stop at this directory.
|
25
|
-
RuboCop::FileFinder.root_level = working_dir
|
26
|
-
|
27
26
|
begin
|
28
27
|
FileUtils.mkdir_p(working_dir)
|
29
28
|
|
@@ -36,9 +35,22 @@ RSpec.shared_context 'isolated environment', :isolated_environment do
|
|
36
35
|
end
|
37
36
|
end
|
38
37
|
end
|
38
|
+
|
39
|
+
if RuboCop.const_defined?(:Server)
|
40
|
+
around do |example|
|
41
|
+
RuboCop::Server::Cache.cache_root_path = nil
|
42
|
+
RuboCop::Server::Cache.instance_variable_set(:@project_dir_cache_key, nil)
|
43
|
+
begin
|
44
|
+
example.run
|
45
|
+
ensure
|
46
|
+
RuboCop::Server::Cache.cache_root_path = nil
|
47
|
+
RuboCop::Server::Cache.instance_variable_set(:@project_dir_cache_key, nil)
|
48
|
+
end
|
49
|
+
end
|
50
|
+
end
|
39
51
|
end
|
40
52
|
|
41
|
-
RSpec.shared_context 'maintain registry'
|
53
|
+
RSpec.shared_context 'maintain registry' do
|
42
54
|
around(:each) { |example| RuboCop::Cop::Registry.with_temporary_global { example.run } }
|
43
55
|
|
44
56
|
def stub_cop_class(name, inherit: RuboCop::Cop::Base, &block)
|
@@ -49,7 +61,7 @@ RSpec.shared_context 'maintain registry', :restore_registry do
|
|
49
61
|
end
|
50
62
|
|
51
63
|
# This context assumes nothing and defines `cop`, among others.
|
52
|
-
RSpec.shared_context 'config'
|
64
|
+
RSpec.shared_context 'config' do # rubocop:disable Metrics/BlockLength
|
53
65
|
### Meant to be overridden at will
|
54
66
|
|
55
67
|
let(:cop_class) do
|
@@ -88,17 +100,29 @@ RSpec.shared_context 'config', :config do # rubocop:disable Metrics/BlockLength
|
|
88
100
|
let(:cur_cop_config) do
|
89
101
|
RuboCop::ConfigLoader
|
90
102
|
.default_configuration.for_cop(cop_class)
|
91
|
-
.merge(
|
92
|
-
|
93
|
-
|
94
|
-
|
103
|
+
.merge(
|
104
|
+
'Enabled' => true, # in case it is 'pending'
|
105
|
+
'AutoCorrect' => 'always' # in case defaults set it to 'disabled' or false
|
106
|
+
)
|
95
107
|
.merge(cop_config)
|
96
108
|
end
|
97
109
|
|
98
110
|
let(:config) do
|
99
111
|
hash = { 'AllCops' => all_cops_config, cop_class.cop_name => cur_cop_config }.merge!(other_cops)
|
100
112
|
|
101
|
-
RuboCop::Config.new(hash, "#{Dir.pwd}/.rubocop.yml")
|
113
|
+
config = RuboCop::Config.new(hash, "#{Dir.pwd}/.rubocop.yml")
|
114
|
+
|
115
|
+
rails_version_in_gemfile = Gem::Version.new(
|
116
|
+
rails_version || RuboCop::Config::DEFAULT_RAILS_VERSION
|
117
|
+
)
|
118
|
+
|
119
|
+
allow(config).to receive(:gem_versions_in_target).and_return(
|
120
|
+
{
|
121
|
+
'railties' => rails_version_in_gemfile
|
122
|
+
}
|
123
|
+
)
|
124
|
+
|
125
|
+
config
|
102
126
|
end
|
103
127
|
|
104
128
|
let(:cop) { cop_class.new(config, cop_options) }
|
@@ -116,22 +140,75 @@ RSpec.shared_context 'mock console output' do
|
|
116
140
|
end
|
117
141
|
end
|
118
142
|
|
119
|
-
RSpec.shared_context '
|
120
|
-
|
143
|
+
RSpec.shared_context 'lsp' do
|
144
|
+
before do
|
145
|
+
RuboCop::LSP.enable
|
146
|
+
end
|
147
|
+
|
148
|
+
after do
|
149
|
+
RuboCop::LSP.disable
|
150
|
+
end
|
151
|
+
end
|
152
|
+
|
153
|
+
RSpec.shared_context 'ruby 2.0' do
|
154
|
+
# Prism supports parsing Ruby 3.3+.
|
155
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.0 }
|
156
|
+
end
|
157
|
+
|
158
|
+
RSpec.shared_context 'ruby 2.1' do
|
159
|
+
# Prism supports parsing Ruby 3.3+.
|
160
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.1 }
|
161
|
+
end
|
162
|
+
|
163
|
+
RSpec.shared_context 'ruby 2.2' do
|
164
|
+
# Prism supports parsing Ruby 3.3+.
|
165
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.2 }
|
166
|
+
end
|
167
|
+
|
168
|
+
RSpec.shared_context 'ruby 2.3' do
|
169
|
+
# Prism supports parsing Ruby 3.3+.
|
170
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.3 }
|
171
|
+
end
|
172
|
+
|
173
|
+
RSpec.shared_context 'ruby 2.4' do
|
174
|
+
# Prism supports parsing Ruby 3.3+.
|
175
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.4 }
|
176
|
+
end
|
177
|
+
|
178
|
+
RSpec.shared_context 'ruby 2.5' do
|
179
|
+
# Prism supports parsing Ruby 3.3+.
|
180
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.5 }
|
181
|
+
end
|
182
|
+
|
183
|
+
RSpec.shared_context 'ruby 2.6' do
|
184
|
+
# Prism supports parsing Ruby 3.3+.
|
185
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.6 }
|
186
|
+
end
|
187
|
+
|
188
|
+
RSpec.shared_context 'ruby 2.7' do
|
189
|
+
# Prism supports parsing Ruby 3.3+.
|
190
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 2.7 }
|
191
|
+
end
|
192
|
+
|
193
|
+
RSpec.shared_context 'ruby 3.0' do
|
194
|
+
# Prism supports parsing Ruby 3.3+.
|
195
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 3.0 }
|
121
196
|
end
|
122
197
|
|
123
|
-
RSpec.shared_context 'ruby
|
124
|
-
|
198
|
+
RSpec.shared_context 'ruby 3.1' do
|
199
|
+
# Prism supports parsing Ruby 3.3+.
|
200
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 3.1 }
|
125
201
|
end
|
126
202
|
|
127
|
-
RSpec.shared_context 'ruby 2
|
128
|
-
|
203
|
+
RSpec.shared_context 'ruby 3.2' do
|
204
|
+
# Prism supports parsing Ruby 3.3+.
|
205
|
+
let(:ruby_version) { ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : 3.2 }
|
129
206
|
end
|
130
207
|
|
131
|
-
RSpec.shared_context 'ruby 3.
|
132
|
-
let(:ruby_version) { 3.
|
208
|
+
RSpec.shared_context 'ruby 3.3' do
|
209
|
+
let(:ruby_version) { 3.3 }
|
133
210
|
end
|
134
211
|
|
135
|
-
RSpec.shared_context 'ruby 3.
|
136
|
-
let(:ruby_version) { 3.
|
212
|
+
RSpec.shared_context 'ruby 3.4' do
|
213
|
+
let(:ruby_version) { 3.4 }
|
137
214
|
end
|
@@ -3,12 +3,29 @@
|
|
3
3
|
# Require this file to load code that supports testing using RSpec.
|
4
4
|
|
5
5
|
require_relative 'cop_helper'
|
6
|
-
require_relative 'host_environment_simulation_helper'
|
7
|
-
require_relative 'shared_contexts'
|
8
6
|
require_relative 'expect_offense'
|
7
|
+
require_relative 'host_environment_simulation_helper'
|
9
8
|
require_relative 'parallel_formatter'
|
9
|
+
require_relative 'shared_contexts'
|
10
10
|
|
11
11
|
RSpec.configure do |config|
|
12
12
|
config.include CopHelper
|
13
13
|
config.include HostEnvironmentSimulatorHelper
|
14
|
+
config.include_context 'config', :config
|
15
|
+
config.include_context 'isolated environment', :isolated_environment
|
16
|
+
config.include_context 'lsp', :lsp
|
17
|
+
config.include_context 'maintain registry', :restore_registry
|
18
|
+
config.include_context 'ruby 2.0', :ruby20
|
19
|
+
config.include_context 'ruby 2.1', :ruby21
|
20
|
+
config.include_context 'ruby 2.2', :ruby22
|
21
|
+
config.include_context 'ruby 2.3', :ruby23
|
22
|
+
config.include_context 'ruby 2.4', :ruby24
|
23
|
+
config.include_context 'ruby 2.5', :ruby25
|
24
|
+
config.include_context 'ruby 2.6', :ruby26
|
25
|
+
config.include_context 'ruby 2.7', :ruby27
|
26
|
+
config.include_context 'ruby 3.0', :ruby30
|
27
|
+
config.include_context 'ruby 3.1', :ruby31
|
28
|
+
config.include_context 'ruby 3.2', :ruby32
|
29
|
+
config.include_context 'ruby 3.3', :ruby33
|
30
|
+
config.include_context 'ruby 3.4', :ruby34
|
14
31
|
end
|