rubocop 1.24.1 → 1.64.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (742) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +11 -8
  4. data/assets/output.css.erb +159 -0
  5. data/assets/output.html.erb +1 -160
  6. data/config/default.yml +707 -100
  7. data/config/obsoletion.yml +40 -2
  8. data/exe/rubocop +15 -7
  9. data/lib/rubocop/arguments_env.rb +17 -0
  10. data/lib/rubocop/arguments_file.rb +17 -0
  11. data/lib/rubocop/cache_config.rb +29 -0
  12. data/lib/rubocop/cached_data.rb +11 -3
  13. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +47 -11
  14. data/lib/rubocop/cli/command/execute_runner.rb +15 -10
  15. data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
  16. data/lib/rubocop/cli/command/lsp.rb +19 -0
  17. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  18. data/lib/rubocop/cli/command/show_docs_url.rb +2 -2
  19. data/lib/rubocop/cli/command/suggest_extensions.rb +62 -17
  20. data/lib/rubocop/cli.rb +72 -12
  21. data/lib/rubocop/comment_config.rb +60 -1
  22. data/lib/rubocop/config.rb +84 -28
  23. data/lib/rubocop/config_finder.rb +78 -0
  24. data/lib/rubocop/config_loader.rb +48 -69
  25. data/lib/rubocop/config_loader_resolver.rb +8 -8
  26. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  27. data/lib/rubocop/config_obsoletion/extracted_cop.rb +3 -1
  28. data/lib/rubocop/config_obsoletion/parameter_rule.rb +13 -1
  29. data/lib/rubocop/config_obsoletion.rb +15 -7
  30. data/lib/rubocop/config_validator.rb +34 -10
  31. data/lib/rubocop/cop/autocorrect_logic.rb +44 -15
  32. data/lib/rubocop/cop/badge.rb +15 -4
  33. data/lib/rubocop/cop/base.rb +181 -98
  34. data/lib/rubocop/cop/bundler/duplicated_gem.rb +4 -7
  35. data/lib/rubocop/cop/bundler/duplicated_group.rb +127 -0
  36. data/lib/rubocop/cop/bundler/gem_comment.rb +5 -5
  37. data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
  38. data/lib/rubocop/cop/bundler/gem_version.rb +5 -7
  39. data/lib/rubocop/cop/bundler/ordered_gems.rb +11 -3
  40. data/lib/rubocop/cop/commissioner.rb +19 -6
  41. data/lib/rubocop/cop/cop.rb +54 -34
  42. data/lib/rubocop/cop/corrector.rb +33 -13
  43. data/lib/rubocop/cop/correctors/alignment_corrector.rb +4 -4
  44. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  45. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +5 -9
  46. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  47. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +10 -16
  48. data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
  49. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +8 -5
  50. data/lib/rubocop/cop/correctors/line_break_corrector.rb +8 -2
  51. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +26 -10
  52. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +3 -8
  53. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
  54. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +3 -3
  55. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  56. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  57. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  58. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  59. data/lib/rubocop/cop/documentation.rb +16 -6
  60. data/lib/rubocop/cop/exclude_limit.rb +1 -1
  61. data/lib/rubocop/cop/force.rb +12 -0
  62. data/lib/rubocop/cop/gemspec/dependency_version.rb +152 -0
  63. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  64. data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
  65. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +5 -12
  66. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +10 -2
  67. data/lib/rubocop/cop/gemspec/require_mfa.rb +25 -24
  68. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +15 -4
  69. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
  70. data/lib/rubocop/cop/generator/require_file_injector.rb +3 -3
  71. data/lib/rubocop/cop/generator.rb +12 -13
  72. data/lib/rubocop/cop/internal_affairs/cop_description.rb +122 -0
  73. data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
  74. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  75. data/lib/rubocop/cop/internal_affairs/example_description.rb +46 -24
  76. data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
  77. data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +1 -1
  78. data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
  79. data/lib/rubocop/cop/internal_affairs/location_expression.rb +37 -0
  80. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +4 -2
  81. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +82 -0
  82. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +19 -20
  83. data/lib/rubocop/cop/internal_affairs/node_first_or_last_argument.rb +53 -0
  84. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +128 -38
  85. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -1
  86. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  87. data/lib/rubocop/cop/internal_affairs/processed_source_buffer_name.rb +42 -0
  88. data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
  89. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  90. data/lib/rubocop/cop/internal_affairs/redundant_expect_offense_arguments.rb +34 -0
  91. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +12 -4
  92. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  93. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  94. data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +11 -2
  95. data/lib/rubocop/cop/internal_affairs/redundant_source_range.rb +66 -0
  96. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  97. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -0
  98. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  99. data/lib/rubocop/cop/internal_affairs.rb +14 -0
  100. data/lib/rubocop/cop/layout/argument_alignment.rb +57 -9
  101. data/lib/rubocop/cop/layout/array_alignment.rb +1 -1
  102. data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
  103. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  104. data/lib/rubocop/cop/layout/block_alignment.rb +17 -13
  105. data/lib/rubocop/cop/layout/block_end_newline.rb +32 -10
  106. data/lib/rubocop/cop/layout/case_indentation.rb +17 -1
  107. data/lib/rubocop/cop/layout/class_structure.rb +44 -27
  108. data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +2 -3
  109. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +3 -7
  110. data/lib/rubocop/cop/layout/comment_indentation.rb +6 -4
  111. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  112. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  113. data/lib/rubocop/cop/layout/dot_position.rb +2 -6
  114. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  115. data/lib/rubocop/cop/layout/empty_comment.rb +7 -5
  116. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +42 -9
  117. data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +14 -7
  118. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  119. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +29 -6
  120. data/lib/rubocop/cop/layout/empty_lines.rb +4 -2
  121. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +7 -2
  122. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  123. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  124. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  125. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
  126. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  127. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +8 -2
  128. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  129. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  130. data/lib/rubocop/cop/layout/end_alignment.rb +24 -4
  131. data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
  132. data/lib/rubocop/cop/layout/extra_spacing.rb +13 -10
  133. data/lib/rubocop/cop/layout/first_argument_indentation.rb +43 -32
  134. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +45 -21
  135. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +36 -9
  136. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +52 -13
  137. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +37 -2
  138. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +58 -9
  139. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +53 -20
  140. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +2 -2
  141. data/lib/rubocop/cop/layout/hash_alignment.rb +8 -1
  142. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +13 -7
  143. data/lib/rubocop/cop/layout/heredoc_indentation.rb +13 -13
  144. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  145. data/lib/rubocop/cop/layout/indentation_style.rb +9 -4
  146. data/lib/rubocop/cop/layout/indentation_width.rb +20 -14
  147. data/lib/rubocop/cop/layout/initial_indentation.rb +3 -3
  148. data/lib/rubocop/cop/layout/leading_comment_space.rb +3 -3
  149. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  150. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +144 -0
  151. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +140 -0
  152. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +4 -2
  153. data/lib/rubocop/cop/layout/line_length.rb +13 -6
  154. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  155. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +32 -2
  156. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
  157. data/lib/rubocop/cop/layout/multiline_block_layout.rb +5 -3
  158. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  159. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +30 -2
  160. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +40 -3
  161. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  162. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +40 -8
  163. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  164. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +77 -0
  165. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +9 -10
  166. data/lib/rubocop/cop/layout/redundant_line_break.rb +39 -18
  167. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +8 -8
  168. data/lib/rubocop/cop/layout/single_line_block_chain.rb +6 -1
  169. data/lib/rubocop/cop/layout/space_after_comma.rb +9 -1
  170. data/lib/rubocop/cop/layout/space_after_not.rb +2 -2
  171. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +3 -3
  172. data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -3
  173. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +2 -2
  174. data/lib/rubocop/cop/layout/space_around_operators.rb +54 -22
  175. data/lib/rubocop/cop/layout/space_before_block_braces.rb +24 -13
  176. data/lib/rubocop/cop/layout/space_before_brackets.rb +7 -0
  177. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
  178. data/lib/rubocop/cop/layout/space_before_first_arg.rb +2 -2
  179. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +3 -3
  180. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -30
  181. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -0
  182. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +35 -15
  183. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +31 -4
  184. data/lib/rubocop/cop/layout/space_inside_parens.rb +3 -3
  185. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +34 -0
  186. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +1 -1
  187. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +11 -7
  188. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +7 -7
  189. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +15 -10
  190. data/lib/rubocop/cop/layout/trailing_whitespace.rb +15 -8
  191. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  192. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  193. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  194. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +41 -8
  195. data/lib/rubocop/cop/lint/ambiguous_operator.rb +11 -7
  196. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  197. data/lib/rubocop/cop/lint/ambiguous_range.rb +5 -5
  198. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +6 -2
  199. data/lib/rubocop/cop/lint/assignment_in_condition.rb +18 -8
  200. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +3 -3
  201. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  202. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  203. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  204. data/lib/rubocop/cop/lint/constant_resolution.rb +5 -1
  205. data/lib/rubocop/cop/lint/debugger.rb +70 -35
  206. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +67 -111
  207. data/lib/rubocop/cop/lint/deprecated_constants.rb +9 -2
  208. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +1 -1
  209. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  210. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -3
  211. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  212. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  213. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +3 -2
  214. data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
  215. data/lib/rubocop/cop/lint/duplicate_match_pattern.rb +122 -0
  216. data/lib/rubocop/cop/lint/duplicate_methods.rb +50 -20
  217. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +56 -12
  218. data/lib/rubocop/cop/lint/duplicate_require.rb +11 -2
  219. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  220. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  221. data/lib/rubocop/cop/lint/else_layout.rb +6 -10
  222. data/lib/rubocop/cop/lint/empty_block.rb +5 -9
  223. data/lib/rubocop/cop/lint/empty_class.rb +4 -2
  224. data/lib/rubocop/cop/lint/empty_conditional_body.rb +114 -4
  225. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  226. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  227. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  228. data/lib/rubocop/cop/lint/empty_in_pattern.rb +4 -2
  229. data/lib/rubocop/cop/lint/empty_interpolation.rb +2 -2
  230. data/lib/rubocop/cop/lint/empty_when.rb +4 -2
  231. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  232. data/lib/rubocop/cop/lint/erb_new_arguments.rb +37 -31
  233. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  234. data/lib/rubocop/cop/lint/float_comparison.rb +11 -1
  235. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  236. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -7
  237. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +2 -1
  238. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +17 -19
  239. data/lib/rubocop/cop/lint/identity_comparison.rb +0 -1
  240. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +2 -2
  241. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +20 -10
  242. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +2 -2
  243. data/lib/rubocop/cop/lint/inherit_exception.rb +28 -28
  244. data/lib/rubocop/cop/lint/interpolation_check.rb +6 -5
  245. data/lib/rubocop/cop/lint/it_without_arguments_in_block.rb +56 -0
  246. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +11 -4
  247. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  248. data/lib/rubocop/cop/lint/literal_assignment_in_condition.rb +85 -0
  249. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +50 -4
  250. data/lib/rubocop/cop/lint/loop.rb +2 -2
  251. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +19 -4
  252. data/lib/rubocop/cop/lint/missing_super.rb +64 -6
  253. data/lib/rubocop/cop/lint/mixed_case_range.rb +116 -0
  254. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -0
  255. data/lib/rubocop/cop/lint/nested_method_definition.rb +54 -10
  256. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  257. data/lib/rubocop/cop/lint/next_without_accumulator.rb +11 -7
  258. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +165 -0
  259. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +20 -10
  260. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  261. data/lib/rubocop/cop/lint/number_conversion.rb +46 -14
  262. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +3 -3
  263. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +4 -3
  264. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +4 -6
  265. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +17 -2
  266. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +10 -4
  267. data/lib/rubocop/cop/lint/percent_string_array.rb +2 -2
  268. data/lib/rubocop/cop/lint/percent_symbol_array.rb +2 -2
  269. data/lib/rubocop/cop/lint/raise_exception.rb +2 -2
  270. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  271. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +55 -15
  272. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +8 -8
  273. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +12 -0
  274. data/lib/rubocop/cop/lint/redundant_regexp_quantifiers.rb +130 -0
  275. data/lib/rubocop/cop/lint/redundant_require_statement.rb +57 -7
  276. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +88 -11
  277. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +2 -2
  278. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +35 -15
  279. data/lib/rubocop/cop/lint/redundant_with_index.rb +19 -12
  280. data/lib/rubocop/cop/lint/redundant_with_object.rb +14 -13
  281. data/lib/rubocop/cop/lint/refinement_import_methods.rb +52 -0
  282. data/lib/rubocop/cop/lint/regexp_as_condition.rb +9 -3
  283. data/lib/rubocop/cop/lint/require_parentheses.rb +4 -2
  284. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  285. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  286. data/lib/rubocop/cop/lint/rescue_type.rb +2 -4
  287. data/lib/rubocop/cop/lint/return_in_void_context.rb +6 -18
  288. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +54 -12
  289. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +2 -2
  290. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  291. data/lib/rubocop/cop/lint/script_permission.rb +4 -4
  292. data/lib/rubocop/cop/lint/self_assignment.rb +39 -1
  293. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +6 -6
  294. data/lib/rubocop/cop/lint/shadowed_argument.rb +2 -1
  295. data/lib/rubocop/cop/lint/shadowed_exception.rb +22 -23
  296. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +42 -1
  297. data/lib/rubocop/cop/lint/struct_new_override.rb +15 -15
  298. data/lib/rubocop/cop/lint/suppressed_exception.rb +4 -4
  299. data/lib/rubocop/cop/lint/symbol_conversion.rb +12 -6
  300. data/lib/rubocop/cop/lint/syntax.rb +12 -6
  301. data/lib/rubocop/cop/lint/to_enum_arguments.rb +24 -7
  302. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  303. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +24 -10
  304. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +3 -3
  305. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  306. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  307. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  308. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  309. data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +2 -2
  310. data/lib/rubocop/cop/lint/unreachable_code.rb +5 -3
  311. data/lib/rubocop/cop/lint/unreachable_loop.rb +23 -11
  312. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  313. data/lib/rubocop/cop/lint/unused_method_argument.rb +8 -3
  314. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  315. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  316. data/lib/rubocop/cop/lint/useless_access_modifier.rb +20 -15
  317. data/lib/rubocop/cop/lint/useless_assignment.rb +95 -11
  318. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +2 -3
  319. data/lib/rubocop/cop/lint/useless_method_definition.rb +13 -5
  320. data/lib/rubocop/cop/lint/useless_rescue.rb +89 -0
  321. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +16 -6
  322. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  323. data/lib/rubocop/cop/lint/useless_times.rb +17 -13
  324. data/lib/rubocop/cop/lint/void.rb +126 -25
  325. data/lib/rubocop/cop/metrics/abc_size.rb +8 -6
  326. data/lib/rubocop/cop/metrics/block_length.rb +18 -13
  327. data/lib/rubocop/cop/metrics/block_nesting.rb +3 -3
  328. data/lib/rubocop/cop/metrics/class_length.rb +17 -6
  329. data/lib/rubocop/cop/metrics/collection_literal_length.rb +76 -0
  330. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -2
  331. data/lib/rubocop/cop/metrics/method_length.rb +19 -13
  332. data/lib/rubocop/cop/metrics/module_length.rb +10 -5
  333. data/lib/rubocop/cop/metrics/parameter_lists.rb +28 -1
  334. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
  335. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +6 -11
  336. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +62 -12
  337. data/lib/rubocop/cop/migration/department_name.rb +3 -3
  338. data/lib/rubocop/cop/mixin/alignment.rb +2 -2
  339. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +2 -2
  340. data/lib/rubocop/cop/mixin/allowed_methods.rb +23 -2
  341. data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
  342. data/lib/rubocop/cop/mixin/allowed_receivers.rb +34 -0
  343. data/lib/rubocop/cop/mixin/annotation_comment.rb +14 -7
  344. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  345. data/lib/rubocop/cop/mixin/code_length.rb +12 -1
  346. data/lib/rubocop/cop/mixin/comments_help.rb +51 -3
  347. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -9
  348. data/lib/rubocop/cop/mixin/configurable_formatting.rb +1 -0
  349. data/lib/rubocop/cop/mixin/def_node.rb +3 -8
  350. data/lib/rubocop/cop/mixin/documentation_comment.rb +1 -1
  351. data/lib/rubocop/cop/mixin/duplication.rb +1 -1
  352. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -1
  353. data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -1
  354. data/lib/rubocop/cop/mixin/first_element_line_break.rb +11 -7
  355. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +4 -0
  356. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +1 -1
  357. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +189 -9
  358. data/lib/rubocop/cop/mixin/hash_transform_method.rb +13 -9
  359. data/lib/rubocop/cop/mixin/heredoc.rb +6 -2
  360. data/lib/rubocop/cop/mixin/line_length_help.rb +28 -8
  361. data/lib/rubocop/cop/mixin/method_complexity.rb +28 -22
  362. data/lib/rubocop/cop/mixin/min_branches_count.rb +40 -0
  363. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +34 -12
  364. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +5 -6
  365. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +7 -5
  366. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +1 -1
  367. data/lib/rubocop/cop/mixin/percent_array.rb +58 -1
  368. data/lib/rubocop/cop/mixin/percent_literal.rb +1 -1
  369. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +7 -9
  370. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +2 -2
  371. data/lib/rubocop/cop/mixin/range_help.rb +28 -7
  372. data/lib/rubocop/cop/mixin/require_library.rb +2 -0
  373. data/lib/rubocop/cop/mixin/rescue_node.rb +5 -3
  374. data/lib/rubocop/cop/mixin/safe_assignment.rb +1 -1
  375. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
  376. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
  377. data/lib/rubocop/cop/mixin/statement_modifier.rb +19 -4
  378. data/lib/rubocop/cop/mixin/string_help.rb +5 -3
  379. data/lib/rubocop/cop/mixin/surrounding_space.rb +17 -13
  380. data/lib/rubocop/cop/mixin/trailing_comma.rb +4 -4
  381. data/lib/rubocop/cop/mixin/visibility_help.rb +40 -5
  382. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  383. data/lib/rubocop/cop/naming/ascii_identifiers.rb +2 -2
  384. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  385. data/lib/rubocop/cop/naming/block_forwarding.rb +61 -16
  386. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  387. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +4 -2
  388. data/lib/rubocop/cop/naming/constant_name.rb +5 -6
  389. data/lib/rubocop/cop/naming/file_name.rb +5 -5
  390. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
  391. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +4 -2
  392. data/lib/rubocop/cop/naming/inclusive_language.rb +32 -10
  393. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +27 -12
  394. data/lib/rubocop/cop/naming/method_name.rb +9 -9
  395. data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
  396. data/lib/rubocop/cop/naming/predicate_name.rb +31 -2
  397. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +13 -5
  398. data/lib/rubocop/cop/naming/variable_name.rb +15 -1
  399. data/lib/rubocop/cop/naming/variable_number.rb +28 -18
  400. data/lib/rubocop/cop/offense.rb +1 -1
  401. data/lib/rubocop/cop/registry.rb +74 -46
  402. data/lib/rubocop/cop/security/compound_hash.rb +106 -0
  403. data/lib/rubocop/cop/security/eval.rb +1 -1
  404. data/lib/rubocop/cop/security/json_load.rb +1 -1
  405. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  406. data/lib/rubocop/cop/security/open.rb +3 -3
  407. data/lib/rubocop/cop/security/yaml_load.rb +11 -5
  408. data/lib/rubocop/cop/style/access_modifier_declarations.rb +142 -3
  409. data/lib/rubocop/cop/style/accessor_grouping.rb +53 -23
  410. data/lib/rubocop/cop/style/alias.rb +23 -13
  411. data/lib/rubocop/cop/style/and_or.rb +12 -12
  412. data/lib/rubocop/cop/style/arguments_forwarding.rb +414 -62
  413. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  414. data/lib/rubocop/cop/style/array_first_last.rb +64 -0
  415. data/lib/rubocop/cop/style/array_intersect.rb +119 -0
  416. data/lib/rubocop/cop/style/array_join.rb +1 -1
  417. data/lib/rubocop/cop/style/ascii_comments.rb +2 -2
  418. data/lib/rubocop/cop/style/attr.rb +12 -2
  419. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +22 -15
  420. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  421. data/lib/rubocop/cop/style/begin_block.rb +1 -2
  422. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +1 -1
  423. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +4 -4
  424. data/lib/rubocop/cop/style/block_comments.rb +4 -4
  425. data/lib/rubocop/cop/style/block_delimiters.rb +57 -15
  426. data/lib/rubocop/cop/style/case_equality.rb +41 -11
  427. data/lib/rubocop/cop/style/case_like_if.rb +27 -10
  428. data/lib/rubocop/cop/style/character_literal.rb +2 -2
  429. data/lib/rubocop/cop/style/class_and_module_children.rb +10 -17
  430. data/lib/rubocop/cop/style/class_check.rb +2 -1
  431. data/lib/rubocop/cop/style/class_equality_comparison.rb +80 -13
  432. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  433. data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
  434. data/lib/rubocop/cop/style/class_vars.rb +4 -4
  435. data/lib/rubocop/cop/style/collection_compact.rb +48 -16
  436. data/lib/rubocop/cop/style/collection_methods.rb +5 -1
  437. data/lib/rubocop/cop/style/colon_method_call.rb +2 -2
  438. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  439. data/lib/rubocop/cop/style/combinable_loops.rb +39 -9
  440. data/lib/rubocop/cop/style/command_literal.rb +2 -2
  441. data/lib/rubocop/cop/style/comment_annotation.rb +2 -2
  442. data/lib/rubocop/cop/style/commented_keyword.rb +10 -7
  443. data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
  444. data/lib/rubocop/cop/style/concat_array_literals.rb +95 -0
  445. data/lib/rubocop/cop/style/conditional_assignment.rb +17 -21
  446. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  447. data/lib/rubocop/cop/style/copyright.rb +37 -24
  448. data/lib/rubocop/cop/style/data_inheritance.rb +75 -0
  449. data/lib/rubocop/cop/style/date_time.rb +7 -6
  450. data/lib/rubocop/cop/style/def_with_parentheses.rb +17 -12
  451. data/lib/rubocop/cop/style/dir.rb +4 -1
  452. data/lib/rubocop/cop/style/dir_empty.rb +54 -0
  453. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +2 -2
  454. data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +3 -3
  455. data/lib/rubocop/cop/style/documentation.rb +47 -35
  456. data/lib/rubocop/cop/style/documentation_method.rb +31 -5
  457. data/lib/rubocop/cop/style/double_negation.rb +62 -3
  458. data/lib/rubocop/cop/style/each_for_simple_loop.rb +46 -11
  459. data/lib/rubocop/cop/style/each_with_object.rb +41 -10
  460. data/lib/rubocop/cop/style/empty_block_parameter.rb +3 -3
  461. data/lib/rubocop/cop/style/empty_case_condition.rb +9 -5
  462. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  463. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  464. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +3 -3
  465. data/lib/rubocop/cop/style/empty_literal.rb +3 -3
  466. data/lib/rubocop/cop/style/empty_method.rb +18 -3
  467. data/lib/rubocop/cop/style/encoding.rb +2 -2
  468. data/lib/rubocop/cop/style/end_block.rb +1 -1
  469. data/lib/rubocop/cop/style/endless_method.rb +2 -2
  470. data/lib/rubocop/cop/style/env_home.rb +56 -0
  471. data/lib/rubocop/cop/style/eval_with_location.rb +15 -24
  472. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  473. data/lib/rubocop/cop/style/exact_regexp_match.rb +70 -0
  474. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  475. data/lib/rubocop/cop/style/explicit_block_argument.rb +9 -5
  476. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  477. data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
  478. data/lib/rubocop/cop/style/file_empty.rb +71 -0
  479. data/lib/rubocop/cop/style/file_read.rb +3 -3
  480. data/lib/rubocop/cop/style/file_write.rb +13 -1
  481. data/lib/rubocop/cop/style/float_division.rb +1 -1
  482. data/lib/rubocop/cop/style/for.rb +10 -2
  483. data/lib/rubocop/cop/style/format_string.rb +34 -13
  484. data/lib/rubocop/cop/style/format_string_token.rb +73 -23
  485. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +10 -5
  486. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  487. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  488. data/lib/rubocop/cop/style/guard_clause.rb +187 -25
  489. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +2 -1
  490. data/lib/rubocop/cop/style/hash_conversion.rb +11 -1
  491. data/lib/rubocop/cop/style/hash_each_methods.rb +132 -23
  492. data/lib/rubocop/cop/style/hash_except.rb +102 -10
  493. data/lib/rubocop/cop/style/hash_like_case.rb +4 -10
  494. data/lib/rubocop/cop/style/hash_syntax.rb +66 -6
  495. data/lib/rubocop/cop/style/hash_transform_keys.rb +7 -2
  496. data/lib/rubocop/cop/style/hash_transform_values.rb +5 -2
  497. data/lib/rubocop/cop/style/identical_conditional_branches.rb +51 -7
  498. data/lib/rubocop/cop/style/if_inside_else.rb +6 -0
  499. data/lib/rubocop/cop/style/if_unless_modifier.rb +117 -20
  500. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +37 -8
  501. data/lib/rubocop/cop/style/if_with_semicolon.rb +6 -6
  502. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  503. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  504. data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
  505. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  506. data/lib/rubocop/cop/style/inverse_methods.rb +23 -18
  507. data/lib/rubocop/cop/style/invertible_unless_condition.rb +160 -0
  508. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  509. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  510. data/lib/rubocop/cop/style/lambda.rb +4 -4
  511. data/lib/rubocop/cop/style/lambda_call.rb +18 -21
  512. data/lib/rubocop/cop/style/line_end_concatenation.rb +6 -3
  513. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  514. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +134 -0
  515. data/lib/rubocop/cop/style/map_into_array.rb +175 -0
  516. data/lib/rubocop/cop/style/map_to_hash.rb +23 -10
  517. data/lib/rubocop/cop/style/map_to_set.rb +64 -0
  518. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +68 -30
  519. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +6 -2
  520. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +54 -49
  521. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +42 -3
  522. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
  523. data/lib/rubocop/cop/style/method_def_parentheses.rb +13 -6
  524. data/lib/rubocop/cop/style/min_max.rb +4 -4
  525. data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
  526. data/lib/rubocop/cop/style/missing_else.rb +37 -25
  527. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +3 -3
  528. data/lib/rubocop/cop/style/mixin_grouping.rb +7 -7
  529. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  530. data/lib/rubocop/cop/style/module_function.rb +30 -8
  531. data/lib/rubocop/cop/style/multiline_block_chain.rb +5 -3
  532. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -6
  533. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  534. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
  535. data/lib/rubocop/cop/style/multiline_memoization.rb +3 -3
  536. data/lib/rubocop/cop/style/multiline_method_signature.rb +19 -7
  537. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +54 -11
  538. data/lib/rubocop/cop/style/multiline_when_then.rb +2 -4
  539. data/lib/rubocop/cop/style/multiple_comparison.rb +15 -1
  540. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  541. data/lib/rubocop/cop/style/negated_if_else_condition.rb +18 -11
  542. data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
  543. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  544. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  545. data/lib/rubocop/cop/style/nested_ternary_operator.rb +19 -15
  546. data/lib/rubocop/cop/style/next.rb +5 -7
  547. data/lib/rubocop/cop/style/nil_comparison.rb +3 -1
  548. data/lib/rubocop/cop/style/nil_lambda.rb +5 -5
  549. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  550. data/lib/rubocop/cop/style/not.rb +2 -2
  551. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  552. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +12 -4
  553. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +2 -2
  554. data/lib/rubocop/cop/style/numeric_literals.rb +16 -1
  555. data/lib/rubocop/cop/style/numeric_predicate.rb +63 -13
  556. data/lib/rubocop/cop/style/object_then.rb +76 -0
  557. data/lib/rubocop/cop/style/one_line_conditional.rb +5 -8
  558. data/lib/rubocop/cop/style/open_struct_use.rb +2 -2
  559. data/lib/rubocop/cop/style/operator_method_call.rb +73 -0
  560. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  561. data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
  562. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +5 -4
  563. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  564. data/lib/rubocop/cop/style/parallel_assignment.rb +32 -24
  565. data/lib/rubocop/cop/style/parentheses_around_condition.rb +9 -1
  566. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +3 -4
  567. data/lib/rubocop/cop/style/percent_q_literals.rb +2 -2
  568. data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
  569. data/lib/rubocop/cop/style/preferred_hash_methods.rb +2 -2
  570. data/lib/rubocop/cop/style/proc.rb +5 -2
  571. data/lib/rubocop/cop/style/quoted_symbols.rb +2 -2
  572. data/lib/rubocop/cop/style/raise_args.rb +14 -5
  573. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  574. data/lib/rubocop/cop/style/redundant_argument.rb +38 -6
  575. data/lib/rubocop/cop/style/redundant_array_constructor.rb +77 -0
  576. data/lib/rubocop/cop/style/redundant_assignment.rb +11 -3
  577. data/lib/rubocop/cop/style/redundant_begin.rb +32 -14
  578. data/lib/rubocop/cop/style/redundant_capital_w.rb +2 -3
  579. data/lib/rubocop/cop/style/redundant_condition.rb +148 -14
  580. data/lib/rubocop/cop/style/redundant_conditional.rb +3 -15
  581. data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
  582. data/lib/rubocop/cop/style/redundant_current_directory_in_path.rb +39 -0
  583. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +133 -0
  584. data/lib/rubocop/cop/style/redundant_each.rb +119 -0
  585. data/lib/rubocop/cop/style/redundant_exception.rb +33 -13
  586. data/lib/rubocop/cop/style/redundant_fetch_block.rb +10 -8
  587. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  588. data/lib/rubocop/cop/style/redundant_filter_chain.rb +118 -0
  589. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  590. data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
  591. data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
  592. data/lib/rubocop/cop/style/redundant_interpolation.rb +24 -3
  593. data/lib/rubocop/cop/style/redundant_line_continuation.rb +200 -0
  594. data/lib/rubocop/cop/style/redundant_parentheses.rb +92 -45
  595. data/lib/rubocop/cop/style/redundant_percent_q.rb +3 -3
  596. data/lib/rubocop/cop/style/redundant_regexp_argument.rb +100 -0
  597. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +15 -4
  598. data/lib/rubocop/cop/style/redundant_regexp_constructor.rb +46 -0
  599. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +24 -6
  600. data/lib/rubocop/cop/style/redundant_return.rb +22 -4
  601. data/lib/rubocop/cop/style/redundant_self.rb +20 -3
  602. data/lib/rubocop/cop/style/redundant_self_assignment.rb +3 -4
  603. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +9 -2
  604. data/lib/rubocop/cop/style/redundant_sort.rb +34 -18
  605. data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
  606. data/lib/rubocop/cop/style/redundant_string_escape.rb +185 -0
  607. data/lib/rubocop/cop/style/regexp_literal.rb +11 -2
  608. data/lib/rubocop/cop/style/require_order.rb +139 -0
  609. data/lib/rubocop/cop/style/rescue_modifier.rb +2 -4
  610. data/lib/rubocop/cop/style/rescue_standard_error.rb +15 -15
  611. data/lib/rubocop/cop/style/return_nil.rb +6 -2
  612. data/lib/rubocop/cop/style/return_nil_in_predicate_method_definition.rb +95 -0
  613. data/lib/rubocop/cop/style/safe_navigation.rb +58 -19
  614. data/lib/rubocop/cop/style/sample.rb +9 -8
  615. data/lib/rubocop/cop/style/select_by_regexp.rb +37 -13
  616. data/lib/rubocop/cop/style/self_assignment.rb +4 -4
  617. data/lib/rubocop/cop/style/semicolon.rb +72 -9
  618. data/lib/rubocop/cop/style/send.rb +5 -5
  619. data/lib/rubocop/cop/style/send_with_literal_method_name.rb +90 -0
  620. data/lib/rubocop/cop/style/signal_exception.rb +10 -8
  621. data/lib/rubocop/cop/style/single_argument_dig.rb +11 -2
  622. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
  623. data/lib/rubocop/cop/style/single_line_do_end_block.rb +67 -0
  624. data/lib/rubocop/cop/style/single_line_methods.rb +3 -3
  625. data/lib/rubocop/cop/style/slicing_with_range.rb +77 -11
  626. data/lib/rubocop/cop/style/sole_nested_conditional.rb +103 -33
  627. data/lib/rubocop/cop/style/special_global_vars.rb +66 -10
  628. data/lib/rubocop/cop/style/static_class.rb +33 -2
  629. data/lib/rubocop/cop/style/stderr_puts.rb +2 -2
  630. data/lib/rubocop/cop/style/string_chars.rb +2 -1
  631. data/lib/rubocop/cop/style/string_concatenation.rb +13 -8
  632. data/lib/rubocop/cop/style/string_hash_keys.rb +5 -2
  633. data/lib/rubocop/cop/style/string_literals.rb +1 -5
  634. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +30 -5
  635. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  636. data/lib/rubocop/cop/style/strip.rb +8 -5
  637. data/lib/rubocop/cop/style/struct_inheritance.rb +5 -5
  638. data/lib/rubocop/cop/style/super_arguments.rb +156 -0
  639. data/lib/rubocop/cop/style/super_with_args_parentheses.rb +35 -0
  640. data/lib/rubocop/cop/style/swap_values.rb +4 -2
  641. data/lib/rubocop/cop/style/symbol_array.rb +46 -21
  642. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  643. data/lib/rubocop/cop/style/symbol_proc.rb +135 -16
  644. data/lib/rubocop/cop/style/ternary_parentheses.rb +19 -18
  645. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  646. data/lib/rubocop/cop/style/trailing_body_on_class.rb +2 -1
  647. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  648. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  649. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +5 -5
  650. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -2
  651. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
  652. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -2
  653. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +2 -5
  654. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +2 -2
  655. data/lib/rubocop/cop/style/trivial_accessors.rb +12 -10
  656. data/lib/rubocop/cop/style/unless_else.rb +5 -1
  657. data/lib/rubocop/cop/style/unless_logical_operators.rb +2 -1
  658. data/lib/rubocop/cop/style/unpack_first.rb +15 -15
  659. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  660. data/lib/rubocop/cop/style/when_then.rb +1 -1
  661. data/lib/rubocop/cop/style/word_array.rb +60 -6
  662. data/lib/rubocop/cop/style/yaml_file_read.rb +66 -0
  663. data/lib/rubocop/cop/style/yoda_condition.rb +18 -9
  664. data/lib/rubocop/cop/style/yoda_expression.rb +91 -0
  665. data/lib/rubocop/cop/style/zero_length_predicate.rb +41 -20
  666. data/lib/rubocop/cop/team.rb +70 -58
  667. data/lib/rubocop/cop/util.rb +45 -9
  668. data/lib/rubocop/cop/utils/regexp_ranges.rb +113 -0
  669. data/lib/rubocop/cop/variable_force/assignment.rb +45 -4
  670. data/lib/rubocop/cop/variable_force/branch.rb +1 -1
  671. data/lib/rubocop/cop/variable_force/scope.rb +3 -3
  672. data/lib/rubocop/cop/variable_force/variable.rb +5 -3
  673. data/lib/rubocop/cop/variable_force/variable_table.rb +6 -4
  674. data/lib/rubocop/cop/variable_force.rb +20 -35
  675. data/lib/rubocop/cops_documentation_generator.rb +81 -22
  676. data/lib/rubocop/directive_comment.rb +14 -12
  677. data/lib/rubocop/ext/comment.rb +18 -0
  678. data/lib/rubocop/ext/processed_source.rb +2 -0
  679. data/lib/rubocop/ext/range.rb +15 -0
  680. data/lib/rubocop/ext/regexp_node.rb +10 -5
  681. data/lib/rubocop/ext/regexp_parser.rb +5 -2
  682. data/lib/rubocop/feature_loader.rb +94 -0
  683. data/lib/rubocop/file_finder.rb +4 -7
  684. data/lib/rubocop/file_patterns.rb +43 -0
  685. data/lib/rubocop/formatter/clang_style_formatter.rb +4 -8
  686. data/lib/rubocop/formatter/disabled_config_formatter.rb +66 -17
  687. data/lib/rubocop/formatter/formatter_set.rb +27 -19
  688. data/lib/rubocop/formatter/{git_hub_actions_formatter.rb → github_actions_formatter.rb} +15 -2
  689. data/lib/rubocop/formatter/html_formatter.rb +39 -26
  690. data/lib/rubocop/formatter/json_formatter.rb +0 -1
  691. data/lib/rubocop/formatter/junit_formatter.rb +4 -1
  692. data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
  693. data/lib/rubocop/formatter/offense_count_formatter.rb +25 -6
  694. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  695. data/lib/rubocop/formatter/tap_formatter.rb +4 -8
  696. data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -4
  697. data/lib/rubocop/formatter.rb +34 -0
  698. data/lib/rubocop/lockfile.rb +56 -7
  699. data/lib/rubocop/lsp/logger.rb +22 -0
  700. data/lib/rubocop/lsp/routes.rb +243 -0
  701. data/lib/rubocop/lsp/runtime.rb +99 -0
  702. data/lib/rubocop/lsp/server.rb +73 -0
  703. data/lib/rubocop/lsp/severity.rb +27 -0
  704. data/lib/rubocop/lsp.rb +36 -0
  705. data/lib/rubocop/magic_comment.rb +43 -15
  706. data/lib/rubocop/options.rb +183 -59
  707. data/lib/rubocop/path_util.rb +54 -22
  708. data/lib/rubocop/rake_task.rb +35 -10
  709. data/lib/rubocop/result_cache.rb +31 -17
  710. data/lib/rubocop/rspec/cop_helper.rb +33 -4
  711. data/lib/rubocop/rspec/expect_offense.rb +21 -11
  712. data/lib/rubocop/rspec/parallel_formatter.rb +1 -1
  713. data/lib/rubocop/rspec/shared_contexts.rb +100 -23
  714. data/lib/rubocop/rspec/support.rb +19 -2
  715. data/lib/rubocop/runner.rb +125 -31
  716. data/lib/rubocop/server/cache.rb +155 -0
  717. data/lib/rubocop/server/cli.rb +147 -0
  718. data/lib/rubocop/server/client_command/base.rb +44 -0
  719. data/lib/rubocop/server/client_command/exec.rb +64 -0
  720. data/lib/rubocop/server/client_command/restart.rb +25 -0
  721. data/lib/rubocop/server/client_command/start.rb +48 -0
  722. data/lib/rubocop/server/client_command/status.rb +28 -0
  723. data/lib/rubocop/server/client_command/stop.rb +31 -0
  724. data/lib/rubocop/server/client_command.rb +26 -0
  725. data/lib/rubocop/server/core.rb +111 -0
  726. data/lib/rubocop/server/errors.rb +23 -0
  727. data/lib/rubocop/server/helper.rb +34 -0
  728. data/lib/rubocop/server/server_command/base.rb +50 -0
  729. data/lib/rubocop/server/server_command/exec.rb +33 -0
  730. data/lib/rubocop/server/server_command/stop.rb +24 -0
  731. data/lib/rubocop/server/server_command.rb +21 -0
  732. data/lib/rubocop/server/socket_reader.rb +69 -0
  733. data/lib/rubocop/server.rb +53 -0
  734. data/lib/rubocop/string_interpreter.rb +7 -7
  735. data/lib/rubocop/target_finder.rb +92 -82
  736. data/lib/rubocop/target_ruby.rb +92 -78
  737. data/lib/rubocop/version.rb +44 -12
  738. data/lib/rubocop.rb +83 -35
  739. metadata +170 -45
  740. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -49
  741. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
  742. data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
@@ -5,12 +5,14 @@ module RuboCop
5
5
  #
6
6
  # @abstract parent of three different magic comment handlers
7
7
  class MagicComment
8
- # @see https://git.io/vMC1C IRB's pattern for matching magic comment tokens
9
- TOKEN = /[[:alnum:]\-_]+/.freeze
8
+ # IRB's pattern for matching magic comment tokens.
9
+ # @see https://github.com/ruby/ruby/blob/b4a55c1/lib/irb/magic-file.rb#L5
10
+ TOKEN = '(?<token>[[:alnum:]\-_]+)'
10
11
  KEYWORDS = {
11
12
  encoding: '(?:en)?coding',
12
13
  frozen_string_literal: 'frozen[_-]string[_-]literal',
13
- shareable_constant_value: 'shareable[_-]constant[_-]value'
14
+ shareable_constant_value: 'shareable[_-]constant[_-]value',
15
+ typed: 'typed'
14
16
  }.freeze
15
17
 
16
18
  # Detect magic comment format and pass it to the appropriate wrapper.
@@ -32,7 +34,10 @@ module RuboCop
32
34
  end
33
35
 
34
36
  def any?
35
- frozen_string_literal_specified? || encoding_specified? || shareable_constant_value_specified?
37
+ frozen_string_literal_specified? ||
38
+ encoding_specified? ||
39
+ shareable_constant_value_specified? ||
40
+ typed_specified?
36
41
  end
37
42
 
38
43
  def valid?
@@ -100,6 +105,17 @@ module RuboCop
100
105
  specified?(encoding)
101
106
  end
102
107
 
108
+ # Was the Sorbet `typed` sigil specified?
109
+ #
110
+ # @return [Boolean]
111
+ def typed_specified?
112
+ specified?(extract_typed)
113
+ end
114
+
115
+ def typed
116
+ extract_typed
117
+ end
118
+
103
119
  private
104
120
 
105
121
  def specified?(value)
@@ -113,7 +129,7 @@ module RuboCop
113
129
  # @return [String] if pattern matched
114
130
  # @return [nil] otherwise
115
131
  def extract(pattern)
116
- @comment[pattern, 1]
132
+ @comment[pattern, :token]
117
133
  end
118
134
 
119
135
  # Parent to Vim and Emacs magic comment handling.
@@ -141,10 +157,10 @@ module RuboCop
141
157
  # @return [String] extracted value if it is found
142
158
  # @return [nil] otherwise
143
159
  def match(keyword)
144
- pattern = /\A#{keyword}\s*#{self.class::OPERATOR}\s*(#{TOKEN})\z/
160
+ pattern = /\A#{keyword}\s*#{self.class::OPERATOR}\s*#{TOKEN}\z/
145
161
 
146
162
  tokens.each do |token|
147
- next unless (value = token[pattern, 1])
163
+ next unless (value = token[pattern, :token])
148
164
 
149
165
  return value.downcase
150
166
  end
@@ -170,9 +186,9 @@ module RuboCop
170
186
  # comment.encoding # => 'ascii-8bit'
171
187
  #
172
188
  # @see https://www.gnu.org/software/emacs/manual/html_node/emacs/Specify-Coding.html
173
- # @see https://git.io/vMCXh Emacs handling in Ruby's parse.y
189
+ # @see https://github.com/ruby/ruby/blob/3f306dc/parse.y#L6873-L6892 Emacs handling in parse.y
174
190
  class EmacsComment < EditorComment
175
- REGEXP = /-\*-(.+)-\*-/.freeze
191
+ REGEXP = /-\*-(?<token>.+)-\*-/.freeze
176
192
  FORMAT = '# -*- %s -*-'
177
193
  SEPARATOR = ';'
178
194
  OPERATOR = ':'
@@ -186,6 +202,9 @@ module RuboCop
186
202
  def extract_shareable_constant_value
187
203
  match(KEYWORDS[:shareable_constant_value])
188
204
  end
205
+
206
+ # Emacs comments cannot specify Sorbet typechecking behavior.
207
+ def extract_typed; end
189
208
  end
190
209
 
191
210
  # Wrapper for Vim style magic comments.
@@ -197,7 +216,7 @@ module RuboCop
197
216
  #
198
217
  # comment.encoding # => 'ascii-8bit'
199
218
  class VimComment < EditorComment
200
- REGEXP = /#\s*vim:\s*(.+)/.freeze
219
+ REGEXP = /#\s*vim:\s*(?<token>.+)/.freeze
201
220
  FORMAT = '# vim: %s'
202
221
  SEPARATOR = ', '
203
222
  OPERATOR = '='
@@ -221,6 +240,9 @@ module RuboCop
221
240
 
222
241
  # Vim comments cannot specify shareable constant values behavior.
223
242
  def shareable_constant_value; end
243
+
244
+ # Vim comments cannot specify Sorbet typechecking behavior.
245
+ def extract_typed; end
224
246
  end
225
247
 
226
248
  # Wrapper for regular magic comments not bound to an editor.
@@ -237,14 +259,16 @@ module RuboCop
237
259
  # comment2.frozen_string_literal # => nil
238
260
  # comment2.encoding # => 'utf-8'
239
261
  class SimpleComment < MagicComment
262
+ FSTRING_LITERAL_COMMENT = 'frozen_string_literal:\s*(true|false)'
263
+
240
264
  # Match `encoding` or `coding`
241
265
  def encoding
242
- extract(/\A\s*\#.*\b#{KEYWORDS[:encoding]}: (#{TOKEN})/io)
266
+ extract(/\A\s*\#\s*(#{FSTRING_LITERAL_COMMENT})?\s*#{KEYWORDS[:encoding]}: (#{TOKEN})/io)
243
267
  end
244
268
 
245
269
  # Rewrite the comment without a given token type
246
270
  def without(type)
247
- if @comment.match?(/\A#\s*#{self.class::KEYWORDS[type.to_sym]}/)
271
+ if @comment.match?(/\A#\s*#{self.class::KEYWORDS[type.to_sym]}/io)
248
272
  ''
249
273
  else
250
274
  @comment
@@ -259,13 +283,17 @@ module RuboCop
259
283
  # is the only text in the comment.
260
284
  #
261
285
  # Case-insensitive and dashes/underscores are acceptable.
262
- # @see https://git.io/vM7Mg
286
+ # @see https://github.com/ruby/ruby/blob/78b95b4/parse.y#L7134-L7138
263
287
  def extract_frozen_string_literal
264
- extract(/\A\s*#\s*#{KEYWORDS[:frozen_string_literal]}:\s*(#{TOKEN})\s*\z/io)
288
+ extract(/\A\s*#\s*#{KEYWORDS[:frozen_string_literal]}:\s*#{TOKEN}\s*\z/io)
265
289
  end
266
290
 
267
291
  def extract_shareable_constant_value
268
- extract(/\A\s*#\s*#{KEYWORDS[:shareable_constant_value]}:\s*(#{TOKEN})\s*\z/io)
292
+ extract(/\A\s*#\s*#{KEYWORDS[:shareable_constant_value]}:\s*#{TOKEN}\s*\z/io)
293
+ end
294
+
295
+ def extract_typed
296
+ extract(/\A\s*#\s*#{KEYWORDS[:typed]}:\s*#{TOKEN}\s*\z/io)
269
297
  end
270
298
  end
271
299
  end
@@ -1,7 +1,8 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  require 'optparse'
4
- require 'shellwords'
4
+ require_relative 'arguments_env'
5
+ require_relative 'arguments_file'
5
6
 
6
7
  module RuboCop
7
8
  class IncorrectCopNameError < StandardError; end
@@ -15,7 +16,7 @@ module RuboCop
15
16
  'root of the project. RuboCop will use this path to determine which ' \
16
17
  'cops are enabled (via eg. Include/Exclude), and so that certain cops ' \
17
18
  'like Naming/FileName can be checked.'
18
- EXITING_OPTIONS = %i[version verbose_version show_cops show_docs_url].freeze
19
+ EXITING_OPTIONS = %i[version verbose_version show_cops show_docs_url lsp].freeze
19
20
  DEFAULT_MAXIMUM_EXCLUSION_ITEMS = 15
20
21
 
21
22
  def initialize
@@ -24,7 +25,10 @@ module RuboCop
24
25
  end
25
26
 
26
27
  def parse(command_line_args)
28
+ args_from_file = ArgumentsFile.read_as_arguments
29
+ args_from_env = ArgumentsEnv.read_as_arguments
27
30
  args = args_from_file.concat(args_from_env).concat(command_line_args)
31
+
28
32
  define_options.parse!(args)
29
33
 
30
34
  @validator.validate_compatibility
@@ -45,34 +49,29 @@ module RuboCop
45
49
 
46
50
  private
47
51
 
48
- def args_from_file
49
- if File.exist?('.rubocop') && !File.directory?('.rubocop')
50
- File.read('.rubocop').shellsplit
51
- else
52
- []
53
- end
54
- end
55
-
56
- def args_from_env
57
- Shellwords.split(ENV.fetch('RUBOCOP_OPTS', ''))
58
- end
59
-
52
+ # rubocop:disable Metrics/AbcSize
60
53
  def define_options
61
54
  OptionParser.new do |opts|
62
55
  opts.banner = rainbow.wrap('Usage: rubocop [options] [file1, file2, ...]').bright
63
56
 
64
57
  add_check_options(opts)
65
58
  add_cache_options(opts)
59
+ add_lsp_option(opts)
60
+ add_server_options(opts)
66
61
  add_output_options(opts)
67
62
  add_autocorrection_options(opts)
68
63
  add_config_generation_options(opts)
69
64
  add_additional_modes(opts)
70
65
  add_general_options(opts)
66
+
67
+ # `stackprof` is not supported on JRuby and Windows.
68
+ add_profile_options(opts) if RUBY_ENGINE == 'ruby' && !Platform.windows?
71
69
  end
72
70
  end
71
+ # rubocop:enable Metrics/AbcSize
73
72
 
74
73
  def add_check_options(opts) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
75
- section(opts, 'Basic Options') do
74
+ section(opts, 'Basic Options') do # rubocop:disable Metrics/BlockLength
76
75
  option(opts, '-l', '--lint') do
77
76
  @options[:only] ||= []
78
77
  @options[:only] << 'Lint'
@@ -80,7 +79,7 @@ module RuboCop
80
79
  option(opts, '-x', '--fix-layout') do
81
80
  @options[:only] ||= []
82
81
  @options[:only] << 'Layout'
83
- @options[:auto_correct] = true
82
+ @options[:autocorrect] = true
84
83
  end
85
84
  option(opts, '--safe')
86
85
  add_cop_selection_csv_option('except', opts)
@@ -93,9 +92,12 @@ module RuboCop
93
92
  option(opts, '--force-exclusion')
94
93
  option(opts, '--only-recognized-file-types')
95
94
  option(opts, '--ignore-parent-exclusion')
95
+ option(opts, '--ignore-unrecognized-cops')
96
96
  option(opts, '--force-default-config')
97
97
  option(opts, '-s', '--stdin FILE')
98
+ option(opts, '--editor-mode')
98
99
  option(opts, '-P', '--[no-]parallel')
100
+ option(opts, '--raise-cop-error')
99
101
  add_severity_option(opts)
100
102
  end
101
103
  end
@@ -123,20 +125,40 @@ module RuboCop
123
125
  option(opts, '--display-time')
124
126
  option(opts, '--display-only-failed')
125
127
  option(opts, '--display-only-fail-level-offenses')
128
+ option(opts, '--display-only-correctable')
129
+ option(opts, '--display-only-safe-correctable')
126
130
  end
127
131
  end
128
132
 
129
- def add_autocorrection_options(opts)
130
- section(opts, 'Auto-correction') do
131
- option(opts, '-a', '--auto-correct') { @options[:safe_auto_correct] = true }
133
+ # rubocop:todo Naming/InclusiveLanguage
134
+ # the autocorrect command-line arguments map to the autocorrect @options values like so:
135
+ # :fix_layout :autocorrect :safe_autocorrect :autocorrect_all
136
+ # -x, --fix-layout true true - -
137
+ # -a, --auto-correct - true true -
138
+ # --safe-auto-correct - true true -
139
+ # -A, --auto-correct-all - true - true
140
+ def add_autocorrection_options(opts) # rubocop:disable Metrics/MethodLength
141
+ section(opts, 'Autocorrection') do
142
+ option(opts, '-a', '--autocorrect') { @options[:safe_autocorrect] = true }
143
+ option(opts, '--auto-correct') do
144
+ handle_deprecated_option('--auto-correct', '--autocorrect')
145
+ @options[:safe_autocorrect] = true
146
+ end
132
147
  option(opts, '--safe-auto-correct') do
133
- warn '--safe-auto-correct is deprecated; use --auto-correct'
134
- @options[:safe_auto_correct] = @options[:auto_correct] = true
148
+ handle_deprecated_option('--safe-auto-correct', '--autocorrect')
149
+ @options[:safe_autocorrect] = true
150
+ end
151
+
152
+ option(opts, '-A', '--autocorrect-all') { @options[:autocorrect] = true }
153
+ option(opts, '--auto-correct-all') do
154
+ handle_deprecated_option('--auto-correct-all', '--autocorrect-all')
155
+ @options[:autocorrect] = true
135
156
  end
136
- option(opts, '-A', '--auto-correct-all') { @options[:auto_correct] = true }
157
+
137
158
  option(opts, '--disable-uncorrectable')
138
159
  end
139
160
  end
161
+ # rubocop:enable Naming/InclusiveLanguage
140
162
 
141
163
  def add_config_generation_options(opts)
142
164
  section(opts, 'Config Generation') do
@@ -147,10 +169,12 @@ module RuboCop
147
169
  end
148
170
 
149
171
  option(opts, '--exclude-limit COUNT') { @validator.validate_exclude_limit_option }
172
+ option(opts, '--no-exclude-limit')
150
173
 
151
174
  option(opts, '--[no-]offense-counts')
152
175
  option(opts, '--[no-]auto-gen-only-exclude')
153
176
  option(opts, '--[no-]auto-gen-timestamp')
177
+ option(opts, '--[no-]auto-gen-enforced-style')
154
178
  end
155
179
  end
156
180
 
@@ -162,7 +186,10 @@ module RuboCop
162
186
  raise OptionArgumentError, message
163
187
  end
164
188
 
165
- @options[:"#{option}"] = list.empty? ? [''] : list.split(',')
189
+ cop_names = list.empty? ? [''] : list.split(',')
190
+ cop_names.unshift('Lint/Syntax') if option == 'only' && !cop_names.include?('Lint/Syntax')
191
+
192
+ @options[:"#{option}"] = cop_names
166
193
  end
167
194
  end
168
195
 
@@ -182,6 +209,23 @@ module RuboCop
182
209
  end
183
210
  end
184
211
 
212
+ def add_lsp_option(opts)
213
+ section(opts, 'LSP Option') do
214
+ option(opts, '--lsp')
215
+ end
216
+ end
217
+
218
+ def add_server_options(opts)
219
+ section(opts, 'Server Options') do
220
+ option(opts, '--[no-]server')
221
+ option(opts, '--restart-server')
222
+ option(opts, '--start-server')
223
+ option(opts, '--stop-server')
224
+ option(opts, '--server-status')
225
+ option(opts, '--no-detach')
226
+ end
227
+ end
228
+
185
229
  def add_additional_modes(opts)
186
230
  section(opts, 'Additional Modes') do
187
231
  option(opts, '-L', '--list-target-files')
@@ -206,6 +250,21 @@ module RuboCop
206
250
  end
207
251
  end
208
252
 
253
+ def add_profile_options(opts)
254
+ section(opts, 'Profiling Options') do
255
+ option(opts, '--profile') do
256
+ @options[:profile] = true
257
+ @options[:cache] = 'false' unless @options.key?(:cache)
258
+ end
259
+ option(opts, '--memory')
260
+ end
261
+ end
262
+
263
+ def handle_deprecated_option(old_option, new_option)
264
+ warn rainbow.wrap("#{old_option} is deprecated; use #{new_option} instead.").yellow
265
+ @options[long_opt_symbol([new_option])] = @options.delete(long_opt_symbol([old_option]))
266
+ end
267
+
209
268
  def rainbow
210
269
  @rainbow ||= begin
211
270
  rainbow = Rainbow.new
@@ -234,10 +293,10 @@ module RuboCop
234
293
  end
235
294
 
236
295
  # Finds the option in `args` starting with -- and converts it to a symbol,
237
- # e.g. [..., '--auto-correct', ...] to :auto_correct.
296
+ # e.g. [..., '--autocorrect', ...] to :autocorrect.
238
297
  def long_opt_symbol(args)
239
298
  long_opt = args.find { |arg| arg.start_with?('--') }
240
- long_opt[2..-1].sub('[no-]', '').sub(/ .*/, '').tr('-', '_').gsub(/[\[\]]/, '').to_sym
299
+ long_opt[2..].sub('[no-]', '').sub(/ .*/, '').tr('-', '_').gsub(/[\[\]]/, '').to_sym
241
300
  end
242
301
 
243
302
  def require_feature(file)
@@ -306,13 +365,12 @@ module RuboCop
306
365
  raise OptionArgumentError, '-C/--cache argument must be true or false'
307
366
  end
308
367
 
309
- if display_only_fail_level_offenses_with_autocorrect?
310
- raise OptionArgumentError, '--autocorrect cannot be used with ' \
311
- '--display-only-fail-level-offenses'
312
- end
313
368
  validate_auto_gen_config
314
- validate_auto_correct
369
+ validate_autocorrect
315
370
  validate_display_only_failed
371
+ validate_display_only_failed_and_display_only_correctable
372
+ validate_display_only_correctable_and_autocorrect
373
+ validate_lsp_and_editor_mode
316
374
  disable_parallel_when_invalid_option_combo
317
375
 
318
376
  return if incompatible_options.size <= 1
@@ -342,35 +400,64 @@ module RuboCop
342
400
  format('--display-only-failed can only be used together with --format junit.')
343
401
  end
344
402
 
345
- def validate_auto_correct
346
- return if @options.key?(:auto_correct)
403
+ def validate_display_only_correctable_and_autocorrect
404
+ return unless @options.key?(:autocorrect)
405
+ return if !@options.key?(:display_only_correctable) &&
406
+ !@options.key?(:display_only_safe_correctable)
407
+
408
+ raise OptionArgumentError,
409
+ '--autocorrect cannot be used with --display-only-[safe-]correctable.'
410
+ end
411
+
412
+ def validate_display_only_failed_and_display_only_correctable
413
+ return unless @options.key?(:display_only_failed)
414
+ return if !@options.key?(:display_only_correctable) &&
415
+ !@options.key?(:display_only_safe_correctable)
416
+
417
+ raise OptionArgumentError,
418
+ format('--display-only-failed cannot be used together with other display options.')
419
+ end
420
+
421
+ def validate_lsp_and_editor_mode
422
+ return if !@options.key?(:lsp) || !@options.key?(:editor_mode)
423
+
424
+ raise OptionArgumentError,
425
+ format('Do not specify `--editor-mode` as it is redundant in `--lsp`.')
426
+ end
427
+
428
+ def validate_autocorrect
429
+ if @options.key?(:safe_autocorrect) && @options.key?(:autocorrect_all)
430
+ message = Rainbow(<<~MESSAGE).red
431
+ Error: Both safe and unsafe autocorrect options are specified, use only one.
432
+ MESSAGE
433
+ raise OptionArgumentError, message
434
+ end
435
+ return if @options.key?(:autocorrect)
347
436
  return unless @options.key?(:disable_uncorrectable)
348
437
 
349
438
  raise OptionArgumentError,
350
- format('--disable-uncorrectable can only be used together with --auto-correct.')
439
+ format('--disable-uncorrectable can only be used together with --autocorrect.')
351
440
  end
352
441
 
353
442
  def disable_parallel_when_invalid_option_combo
354
443
  return unless @options.key?(:parallel)
355
444
 
356
- invalid_options = [
357
- { name: :auto_gen_config, value: true, flag: '--auto-gen-config' },
358
- { name: :fail_fast, value: true, flag: '-F/--fail-fast.' },
359
- { name: :auto_correct, value: true, flag: '--auto-correct.' },
360
- { name: :cache, value: 'false', flag: '--cache false' }
361
- ]
362
-
363
- invalid_flags = invalid_options.each_with_object([]) do |option, flags|
364
- # `>` rather than `>=` because `@options` will also contain `parallel: true`
365
- flags << option[:flag] if @options > { option[:name] => option[:value] }
366
- end
445
+ invalid_flags = invalid_arguments_for_parallel
367
446
 
368
447
  return if invalid_flags.empty?
369
448
 
370
449
  @options.delete(:parallel)
371
450
 
372
451
  puts '-P/--parallel is being ignored because ' \
373
- "it is not compatible with #{invalid_flags.join(', ')}"
452
+ "it is not compatible with #{invalid_flags.join(', ')}."
453
+ end
454
+
455
+ def invalid_arguments_for_parallel
456
+ [('--auto-gen-config' if @options.key?(:auto_gen_config)),
457
+ ('-F/--fail-fast' if @options.key?(:fail_fast)),
458
+ ('--profile' if @options[:profile]),
459
+ ('--memory' if @options[:memory]),
460
+ ('--cache false' if @options > { cache: 'false' })].compact
374
461
  end
375
462
 
376
463
  def only_includes_redundant_disable?
@@ -378,10 +465,6 @@ module RuboCop
378
465
  (@options[:only] & %w[Lint/RedundantCopDisableDirective RedundantCopDisableDirective]).any?
379
466
  end
380
467
 
381
- def display_only_fail_level_offenses_with_autocorrect?
382
- @options[:display_only_fail_level_offenses] && @options[:autocorrect]
383
- end
384
-
385
468
  def except_syntax?
386
469
  @options.key?(:except) && (@options[:except] & %w[Lint/Syntax Syntax]).any?
387
470
  end
@@ -405,12 +488,13 @@ module RuboCop
405
488
  def validate_cache_enabled_for_cache_root
406
489
  return unless @options[:cache] == 'false'
407
490
 
408
- raise OptionArgumentError, '--cache-root can not be used with --cache false'
491
+ raise OptionArgumentError, '--cache-root cannot be used with --cache false'
409
492
  end
410
493
  end
411
494
 
412
495
  # This module contains help texts for command line options.
413
496
  # @api private
497
+ # rubocop:disable Metrics/ModuleLength
414
498
  module OptionsHelp
415
499
  MAX_EXCL = RuboCop::Options::DEFAULT_MAXIMUM_EXCLUSION_ITEMS.to_s
416
500
  FORMATTER_OPTION_LIST = RuboCop::Formatter::FormatterSet::BUILTIN_FORMATTERS_FOR_KEYS.keys
@@ -433,6 +517,13 @@ module RuboCop
433
517
  auto_gen_timestamp:
434
518
  ['Include the date and time when the --auto-gen-config',
435
519
  'was run in the file it generates. Default is true.'],
520
+ auto_gen_enforced_style:
521
+ ['Add a setting to the TODO configuration file to enforce',
522
+ 'the style used, rather than a per-file exclusion',
523
+ 'if one style is used in all files for cop with',
524
+ 'EnforcedStyle as a configurable option',
525
+ 'when the --auto-gen-config was run',
526
+ 'in the file it generates. Default is true.'],
436
527
  auto_gen_only_exclude:
437
528
  ['Generate only Exclude parameters and not Max',
438
529
  'when running --auto-gen-config, except if the',
@@ -441,9 +532,10 @@ module RuboCop
441
532
  exclude_limit: ['Set the limit for how many files to explicitly exclude.',
442
533
  'If there are more files than the limit, the cop will',
443
534
  "be disabled instead. Default is #{MAX_EXCL}."],
444
- disable_uncorrectable: ['Used with --auto-correct to annotate any',
535
+ disable_uncorrectable: ['Used with --autocorrect to annotate any',
445
536
  'offenses that do not support autocorrect',
446
537
  'with `rubocop:todo` comments.'],
538
+ no_exclude_limit: ['Do not set the limit for how many files to exclude.'],
447
539
  force_exclusion: ['Any files excluded by `Exclude` in configuration',
448
540
  'files will be excluded, even if given explicitly',
449
541
  'as arguments.'],
@@ -454,6 +546,7 @@ module RuboCop
454
546
  'by a `rubocop:disable` directive.'],
455
547
  ignore_parent_exclusion: ['Prevent from inheriting `AllCops/Exclude` from',
456
548
  'parent folders.'],
549
+ ignore_unrecognized_cops: ['Ignore unrecognized cops or departments in the config.'],
457
550
  force_default_config: ['Use default configuration even if configuration',
458
551
  'files are present in the directory tree.'],
459
552
  format: ['Choose an output formatter. This option',
@@ -467,14 +560,23 @@ module RuboCop
467
560
  'This option applies to the previously',
468
561
  'specified --format, or the default format',
469
562
  'if no format is specified.'],
470
- fail_level: ['Minimum severity (A/I/R/C/W/E/F) for exit',
471
- 'with error code.'],
563
+ fail_level: ['Minimum severity for exit with error code.',
564
+ ' [A] autocorrect',
565
+ ' [I] info',
566
+ ' [R] refactor',
567
+ ' [C] convention',
568
+ ' [W] warning',
569
+ ' [E] error',
570
+ ' [F] fatal'],
472
571
  display_time: 'Display elapsed time in seconds.',
473
572
  display_only_failed: ['Only output offense messages. Omit passing',
474
573
  'cops. Only valid for --format junit.'],
475
574
  display_only_fail_level_offenses:
476
575
  ['Only output offense messages at',
477
- 'the specified --fail-level or above'],
576
+ 'the specified --fail-level or above.'],
577
+ display_only_correctable: ['Only output correctable offense messages.'],
578
+ display_only_safe_correctable: ['Only output safe-correctable offense messages',
579
+ 'when combined with --display-only-correctable.'],
478
580
  show_cops: ['Shows the given cops, or all cops by',
479
581
  'default, and their configurations for the',
480
582
  'current directory.'],
@@ -501,12 +603,14 @@ module RuboCop
501
603
  safe: 'Run only safe cops.',
502
604
  stderr: ['Write all output to stderr except for the',
503
605
  'autocorrected source. This is especially useful',
504
- 'when combined with --auto-correct and --stdin.'],
606
+ 'when combined with --autocorrect and --stdin.'],
505
607
  list_target_files: 'List all files RuboCop will inspect.',
506
- auto_correct: 'Auto-correct offenses (only when it\'s safe).',
608
+ autocorrect: 'Autocorrect offenses (only when it\'s safe).',
609
+ auto_correct: '(same, deprecated)',
507
610
  safe_auto_correct: '(same, deprecated)',
508
- auto_correct_all: 'Auto-correct offenses (safe and unsafe)',
509
- fix_layout: 'Run only layout cops, with auto-correct on.',
611
+ autocorrect_all: 'Autocorrect offenses (safe and unsafe).',
612
+ auto_correct_all: '(same, deprecated)',
613
+ fix_layout: 'Run only layout cops, with autocorrect on.',
510
614
  color: 'Force color output on or off.',
511
615
  version: 'Display version.',
512
616
  verbose_version: 'Display verbose version.',
@@ -514,7 +618,27 @@ module RuboCop
514
618
  'parallel. Default is true.'],
515
619
  stdin: ['Pipe source from STDIN, using FILE in offense',
516
620
  'reports. This is useful for editor integration.'],
517
- init: 'Generate a .rubocop.yml file in the current directory.'
621
+ editor_mode: ['Optimize real-time feedback in editors,',
622
+ 'adjusting behaviors for editing experience.'],
623
+ init: 'Generate a .rubocop.yml file in the current directory.',
624
+ server: ['If a server process has not been started yet, start',
625
+ 'the server process and execute inspection with server.',
626
+ 'Default is false.',
627
+ 'You can specify the server host and port with the',
628
+ '$RUBOCOP_SERVER_HOST and the $RUBOCOP_SERVER_PORT',
629
+ 'environment variables.'],
630
+ restart_server: 'Restart server process.',
631
+ start_server: 'Start server process.',
632
+ stop_server: 'Stop server process.',
633
+ server_status: 'Show server status.',
634
+ no_detach: 'Run the server process in the foreground.',
635
+ lsp: 'Start a language server listening on STDIN.',
636
+ raise_cop_error: ['Raise cop-related errors with cause and location.',
637
+ 'This is used to prevent cops from failing silently.',
638
+ 'Default is false.'],
639
+ profile: 'Profile rubocop.',
640
+ memory: 'Profile rubocop memory usage.'
518
641
  }.freeze
519
642
  end
643
+ # rubocop:enable Metrics/ModuleLength
520
644
  end