rubocop 0.85.1 → 0.89.0

data/lib/rubocop/cop/lint/useless_comparison.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Lint
-      # This cop checks for comparison of something with itself.
-      #
-      # @example
-      #
-      #   # bad
-      #
-      #   x.top >= x.top
-      class UselessComparison < Cop
-        MSG = 'Comparison of something with itself detected.'
-        OPS = %w[== === != < > <= >= <=>].freeze
-
-        def_node_matcher :useless_comparison?,
-                         "(send $_match {:#{OPS.join(' :')}} $_match)"
-
-        def on_send(node)
-          return unless useless_comparison?(node)
-
-          add_offense(node, location: :selector)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/classish_length.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for checking length of classes and modules.
-    module ClassishLength
-      include CodeLength
-
-      private
-
-      def code_length(node)
-        body_line_numbers = line_range(node).to_a[1...-1]
-
-        target_line_numbers = body_line_numbers -
-                              line_numbers_of_inner_nodes(node, :module, :class)
-
-        target_line_numbers.reduce(0) do |length, line_number|
-          source_line = processed_source[line_number]
-          next length if irrelevant_line(source_line)
-
-          length + 1
-        end
-      end
-
-      def line_numbers_of_inner_nodes(node, *types)
-        line_numbers = Set.new
-
-        node.each_descendant(*types) do |inner_node|
-          line_range = line_range(inner_node)
-          line_numbers.merge(line_range)
-        end
-
-        line_numbers.to_a
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/parser_diagnostic.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for cops which processes Parser's diagnostics.
-    # This mixin requires its user class to define `#relevant_diagnostic?`.
-    #
-    #     def relevant_diagnostic?(diagnostic)
-    #       diagnostic.reason == :my_interested_diagnostic_type
-    #     end
-    #
-    # If you want to use an alternative offense message rather than the one in
-    # Parser's diagnostic, define `#alternative_message`.
-    #
-    #     def alternative_message(diagnostic)
-    #       'My custom message'
-    #     end
-    module ParserDiagnostic
-      def investigate(processed_source)
-        processed_source.diagnostics.each do |d|
-          next unless relevant_diagnostic?(d)
-
-          message = if respond_to?(:alternative_message, true)
-                      alternative_message(d)
-                    else
-                      d.message.capitalize
-                    end
-
-          add_offense(find_offense_node_by(d),
-                      location: d.location,
-                      message: message,
-                      severity: d.level)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/too_many_lines.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for checking for too many lines.
-    module TooManyLines
-      include ConfigurableMax
-      include CodeLength
-
-      MSG = '%<label>s has too many lines. [%<length>d/%<max>d]'
-
-      private
-
-      def message(length, max_length)
-        format(MSG, label: cop_label, length: length, max: max_length)
-      end
-
-      def code_length(node)
-        body = extract_body(node)
-        lines = body&.source&.lines || []
-
-        lines.count { |line| !irrelevant_line(line) }
-      end
-
-      def extract_body(node)
-        case node.type
-        when :block, :def, :defs
-          node.body
-        else
-          node
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/style/method_missing_super.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Style
-      # This cop checks for the presence of `method_missing` without
-      # falling back on `super`.
-      #
-      # @example
-      #   #bad
-      #   def method_missing(name, *args)
-      #     # ...
-      #   end
-      #
-      #   #good
-      #
-      #   def method_missing(name, *args)
-      #     # ...
-      #     super
-      #   end
-      class MethodMissingSuper < Cop
-        MSG = 'When using `method_missing`, fall back on `super`.'
-
-        def on_def(node)
-          return unless node.method?(:method_missing)
-          return if node.descendants.any?(&:zsuper_type?)
-
-          add_offense(node)
-        end
-        alias on_defs on_def
-      end
-    end
-  end
-end