rubocop 0.85.1 → 0.89.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (357) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +16 -4
  3. data/bin/rubocop-profile +32 -0
  4. data/config/default.yml +227 -26
  5. data/lib/rubocop.rb +33 -5
  6. data/lib/rubocop/cli.rb +2 -4
  7. data/lib/rubocop/cli/command/auto_genenerate_config.rb +42 -7
  8. data/lib/rubocop/cli/command/base.rb +1 -0
  9. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  10. data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
  11. data/lib/rubocop/cli/command/show_cops.rb +2 -2
  12. data/lib/rubocop/cli/command/version.rb +2 -2
  13. data/lib/rubocop/comment_config.rb +2 -2
  14. data/lib/rubocop/config.rb +20 -3
  15. data/lib/rubocop/config_loader.rb +40 -68
  16. data/lib/rubocop/config_loader_resolver.rb +4 -4
  17. data/lib/rubocop/config_obsoletion.rb +6 -2
  18. data/lib/rubocop/config_store.rb +4 -0
  19. data/lib/rubocop/config_validator.rb +1 -3
  20. data/lib/rubocop/cop/autocorrect_logic.rb +14 -24
  21. data/lib/rubocop/cop/badge.rb +1 -1
  22. data/lib/rubocop/cop/base.rb +407 -0
  23. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +10 -20
  24. data/lib/rubocop/cop/commissioner.rb +47 -50
  25. data/lib/rubocop/cop/cop.rb +85 -236
  26. data/lib/rubocop/cop/corrector.rb +38 -115
  27. data/lib/rubocop/cop/correctors/line_break_corrector.rb +3 -3
  28. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +26 -0
  29. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  30. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  31. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
  32. data/lib/rubocop/cop/force.rb +1 -0
  33. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +39 -13
  34. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
  35. data/lib/rubocop/cop/generator.rb +1 -1
  36. data/lib/rubocop/cop/generator/configuration_injector.rb +3 -3
  37. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +4 -12
  38. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -1
  39. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
  40. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +8 -8
  41. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +10 -7
  42. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +7 -8
  43. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
  44. data/lib/rubocop/cop/layout/block_alignment.rb +1 -1
  45. data/lib/rubocop/cop/layout/case_indentation.rb +18 -19
  46. data/lib/rubocop/cop/layout/class_structure.rb +2 -37
  47. data/lib/rubocop/cop/layout/comment_indentation.rb +3 -3
  48. data/lib/rubocop/cop/layout/empty_comment.rb +1 -1
  49. data/lib/rubocop/cop/layout/empty_lines.rb +0 -2
  50. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +1 -0
  51. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +3 -8
  52. data/lib/rubocop/cop/layout/end_alignment.rb +3 -2
  53. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  54. data/lib/rubocop/cop/layout/extra_spacing.rb +9 -16
  55. data/lib/rubocop/cop/layout/first_argument_indentation.rb +5 -1
  56. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
  57. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  58. data/lib/rubocop/cop/layout/hash_alignment.rb +2 -3
  59. data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -2
  60. data/lib/rubocop/cop/layout/indentation_style.rb +0 -2
  61. data/lib/rubocop/cop/layout/multiline_block_layout.rb +17 -7
  62. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -1
  63. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +0 -2
  64. data/lib/rubocop/cop/layout/space_after_colon.rb +1 -1
  65. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +22 -27
  66. data/lib/rubocop/cop/layout/space_around_keyword.rb +2 -2
  67. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +33 -66
  68. data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
  69. data/lib/rubocop/cop/layout/space_before_block_braces.rb +14 -0
  70. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +4 -3
  71. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +1 -1
  72. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +2 -2
  73. data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
  74. data/lib/rubocop/cop/legacy/corrector.rb +29 -0
  75. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +7 -4
  76. data/lib/rubocop/cop/lint/ambiguous_operator.rb +15 -10
  77. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +11 -13
  78. data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
  79. data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
  80. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +49 -0
  81. data/lib/rubocop/cop/lint/boolean_symbol.rb +16 -11
  82. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  83. data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
  84. data/lib/rubocop/cop/lint/debugger.rb +7 -1
  85. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +9 -10
  86. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +21 -17
  87. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +8 -2
  88. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  89. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
  90. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  91. data/lib/rubocop/cop/lint/duplicate_methods.rb +9 -6
  92. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +60 -0
  93. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  94. data/lib/rubocop/cop/lint/else_layout.rb +1 -1
  95. data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
  96. data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
  97. data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
  98. data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -6
  99. data/lib/rubocop/cop/lint/empty_when.rb +2 -2
  100. data/lib/rubocop/cop/lint/ensure_return.rb +27 -29
  101. data/lib/rubocop/cop/lint/erb_new_arguments.rb +11 -10
  102. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  103. data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
  104. data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
  105. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +11 -5
  106. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
  107. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +5 -4
  108. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +8 -8
  109. data/lib/rubocop/cop/lint/inherit_exception.rb +12 -7
  110. data/lib/rubocop/cop/lint/interpolation_check.rb +21 -5
  111. data/lib/rubocop/cop/lint/literal_as_condition.rb +14 -2
  112. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -7
  113. data/lib/rubocop/cop/lint/loop.rb +23 -2
  114. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +6 -5
  115. data/lib/rubocop/cop/lint/missing_super.rb +99 -0
  116. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -1
  117. data/lib/rubocop/cop/lint/multiple_comparison.rb +6 -9
  118. data/lib/rubocop/cop/lint/nested_method_definition.rb +15 -21
  119. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  120. data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
  121. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +84 -13
  122. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +2 -2
  123. data/lib/rubocop/cop/lint/number_conversion.rb +6 -9
  124. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
  125. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +61 -0
  126. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +12 -13
  127. data/lib/rubocop/cop/lint/percent_string_array.rb +14 -13
  128. data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
  129. data/lib/rubocop/cop/lint/raise_exception.rb +15 -5
  130. data/lib/rubocop/cop/lint/rand_one.rb +3 -3
  131. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +31 -25
  132. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +7 -11
  133. data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -7
  134. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +15 -11
  135. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +6 -13
  136. data/lib/rubocop/cop/lint/redundant_with_index.rb +11 -14
  137. data/lib/rubocop/cop/lint/redundant_with_object.rb +11 -14
  138. data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
  139. data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
  140. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  141. data/lib/rubocop/cop/lint/rescue_type.rb +8 -8
  142. data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
  143. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +3 -6
  144. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
  145. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +10 -2
  146. data/lib/rubocop/cop/lint/script_permission.rb +10 -7
  147. data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
  148. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -11
  149. data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
  150. data/lib/rubocop/cop/lint/shadowed_exception.rb +2 -2
  151. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +3 -3
  152. data/lib/rubocop/cop/lint/struct_new_override.rb +1 -1
  153. data/lib/rubocop/cop/lint/suppressed_exception.rb +4 -7
  154. data/lib/rubocop/cop/lint/syntax.rb +11 -26
  155. data/lib/rubocop/cop/lint/to_json.rb +4 -6
  156. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
  157. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
  158. data/lib/rubocop/cop/lint/unified_integer.rb +4 -6
  159. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  160. data/lib/rubocop/cop/lint/unreachable_loop.rb +174 -0
  161. data/lib/rubocop/cop/lint/unused_block_argument.rb +8 -3
  162. data/lib/rubocop/cop/lint/unused_method_argument.rb +9 -4
  163. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  164. data/lib/rubocop/cop/lint/uri_regexp.rb +11 -31
  165. data/lib/rubocop/cop/lint/useless_access_modifier.rb +26 -16
  166. data/lib/rubocop/cop/lint/useless_assignment.rb +4 -4
  167. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +6 -15
  168. data/lib/rubocop/cop/lint/useless_setter_call.rb +4 -6
  169. data/lib/rubocop/cop/lint/void.rb +3 -7
  170. data/lib/rubocop/cop/metrics/abc_size.rb +1 -1
  171. data/lib/rubocop/cop/metrics/block_length.rb +24 -2
  172. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  173. data/lib/rubocop/cop/metrics/class_length.rb +26 -3
  174. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
  175. data/lib/rubocop/cop/metrics/method_length.rb +25 -2
  176. data/lib/rubocop/cop/metrics/module_length.rb +26 -3
  177. data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -6
  178. data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
  179. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +47 -4
  180. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +157 -0
  181. data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
  182. data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
  183. data/lib/rubocop/cop/migration/department_name.rb +13 -15
  184. data/lib/rubocop/cop/mixin/allowed_methods.rb +19 -0
  185. data/lib/rubocop/cop/mixin/array_min_size.rb +1 -1
  186. data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
  187. data/lib/rubocop/cop/mixin/check_line_breakable.rb +1 -1
  188. data/lib/rubocop/cop/mixin/code_length.rb +26 -5
  189. data/lib/rubocop/cop/mixin/configurable_formatting.rb +1 -1
  190. data/lib/rubocop/cop/mixin/configurable_naming.rb +1 -1
  191. data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -2
  192. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -1
  193. data/lib/rubocop/cop/mixin/enforce_superclass.rb +5 -1
  194. data/lib/rubocop/cop/mixin/first_element_line_break.rb +1 -1
  195. data/lib/rubocop/cop/mixin/method_complexity.rb +10 -2
  196. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +1 -1
  197. data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
  198. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
  199. data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
  200. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
  201. data/lib/rubocop/cop/mixin/range_help.rb +1 -1
  202. data/lib/rubocop/cop/mixin/regexp_literal_help.rb +27 -0
  203. data/lib/rubocop/cop/mixin/statement_modifier.rb +38 -9
  204. data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
  205. data/lib/rubocop/cop/mixin/surrounding_space.rb +7 -27
  206. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
  207. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +12 -17
  208. data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
  209. data/lib/rubocop/cop/mixin/visibility_help.rb +50 -0
  210. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  211. data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
  212. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +4 -4
  213. data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
  214. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +2 -2
  215. data/lib/rubocop/cop/naming/constant_name.rb +2 -2
  216. data/lib/rubocop/cop/naming/file_name.rb +4 -6
  217. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
  218. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +3 -3
  219. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +2 -2
  220. data/lib/rubocop/cop/naming/method_name.rb +1 -1
  221. data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
  222. data/lib/rubocop/cop/naming/predicate_name.rb +6 -10
  223. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +12 -11
  224. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  225. data/lib/rubocop/cop/naming/variable_number.rb +1 -1
  226. data/lib/rubocop/cop/offense.rb +16 -2
  227. data/lib/rubocop/cop/registry.rb +3 -3
  228. data/lib/rubocop/cop/security/eval.rb +2 -2
  229. data/lib/rubocop/cop/security/json_load.rb +6 -8
  230. data/lib/rubocop/cop/security/marshal_load.rb +2 -4
  231. data/lib/rubocop/cop/security/open.rb +2 -2
  232. data/lib/rubocop/cop/security/yaml_load.rb +6 -6
  233. data/lib/rubocop/cop/style/access_modifier_declarations.rb +11 -1
  234. data/lib/rubocop/cop/style/accessor_grouping.rb +149 -0
  235. data/lib/rubocop/cop/style/alias.rb +7 -3
  236. data/lib/rubocop/cop/style/array_coercion.rb +63 -0
  237. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +3 -2
  238. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  239. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +144 -0
  240. data/lib/rubocop/cop/style/block_delimiters.rb +2 -4
  241. data/lib/rubocop/cop/style/case_equality.rb +22 -3
  242. data/lib/rubocop/cop/style/case_like_if.rb +217 -0
  243. data/lib/rubocop/cop/style/class_and_module_children.rb +1 -1
  244. data/lib/rubocop/cop/style/class_vars.rb +21 -0
  245. data/lib/rubocop/cop/style/colon_method_call.rb +3 -3
  246. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  247. data/lib/rubocop/cop/style/commented_keyword.rb +5 -2
  248. data/lib/rubocop/cop/style/conditional_assignment.rb +11 -2
  249. data/lib/rubocop/cop/style/copyright.rb +3 -3
  250. data/lib/rubocop/cop/style/date_time.rb +1 -1
  251. data/lib/rubocop/cop/style/dir.rb +2 -2
  252. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +1 -1
  253. data/lib/rubocop/cop/style/documentation.rb +6 -6
  254. data/lib/rubocop/cop/style/each_with_object.rb +0 -2
  255. data/lib/rubocop/cop/style/empty_case_condition.rb +8 -6
  256. data/lib/rubocop/cop/style/empty_literal.rb +5 -5
  257. data/lib/rubocop/cop/style/empty_method.rb +5 -5
  258. data/lib/rubocop/cop/style/encoding.rb +1 -1
  259. data/lib/rubocop/cop/style/eval_with_location.rb +4 -0
  260. data/lib/rubocop/cop/style/expand_path_arguments.rb +6 -2
  261. data/lib/rubocop/cop/style/explicit_block_argument.rb +102 -0
  262. data/lib/rubocop/cop/style/exponential_notation.rb +8 -10
  263. data/lib/rubocop/cop/style/float_division.rb +7 -10
  264. data/lib/rubocop/cop/style/format_string.rb +4 -0
  265. data/lib/rubocop/cop/style/format_string_token.rb +6 -5
  266. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +1 -1
  267. data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
  268. data/lib/rubocop/cop/style/guard_clause.rb +2 -2
  269. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +69 -0
  270. data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
  271. data/lib/rubocop/cop/style/hash_syntax.rb +6 -3
  272. data/lib/rubocop/cop/style/identical_conditional_branches.rb +1 -1
  273. data/lib/rubocop/cop/style/if_unless_modifier.rb +8 -28
  274. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +12 -0
  275. data/lib/rubocop/cop/style/infinite_loop.rb +1 -1
  276. data/lib/rubocop/cop/style/inverse_methods.rb +3 -4
  277. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  278. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +5 -0
  279. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +1 -1
  280. data/lib/rubocop/cop/style/missing_else.rb +1 -11
  281. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +9 -2
  282. data/lib/rubocop/cop/style/multiline_block_chain.rb +10 -1
  283. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  284. data/lib/rubocop/cop/style/multiline_memoization.rb +2 -2
  285. data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -1
  286. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +17 -6
  287. data/lib/rubocop/cop/style/mutable_constant.rb +4 -4
  288. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +2 -5
  289. data/lib/rubocop/cop/style/nested_ternary_operator.rb +27 -0
  290. data/lib/rubocop/cop/style/next.rb +2 -2
  291. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +2 -2
  292. data/lib/rubocop/cop/style/numeric_predicate.rb +7 -4
  293. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +42 -0
  294. data/lib/rubocop/cop/style/parallel_assignment.rb +5 -5
  295. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +2 -2
  296. data/lib/rubocop/cop/style/proc.rb +1 -1
  297. data/lib/rubocop/cop/style/random_with_offset.rb +5 -10
  298. data/lib/rubocop/cop/style/redundant_assignment.rb +117 -0
  299. data/lib/rubocop/cop/style/redundant_condition.rb +15 -3
  300. data/lib/rubocop/cop/style/redundant_exception.rb +18 -10
  301. data/lib/rubocop/cop/style/redundant_fetch_block.rb +122 -0
  302. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +50 -0
  303. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  304. data/lib/rubocop/cop/style/redundant_parentheses.rb +8 -2
  305. data/lib/rubocop/cop/style/redundant_percent_q.rb +2 -2
  306. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +4 -3
  307. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +23 -32
  308. data/lib/rubocop/cop/style/redundant_self.rb +6 -9
  309. data/lib/rubocop/cop/style/redundant_sort.rb +28 -12
  310. data/lib/rubocop/cop/style/rescue_standard_error.rb +1 -1
  311. data/lib/rubocop/cop/style/sample.rb +1 -1
  312. data/lib/rubocop/cop/style/semicolon.rb +1 -1
  313. data/lib/rubocop/cop/style/signal_exception.rb +3 -1
  314. data/lib/rubocop/cop/style/single_argument_dig.rb +54 -0
  315. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +3 -2
  316. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  317. data/lib/rubocop/cop/style/string_concatenation.rb +92 -0
  318. data/lib/rubocop/cop/style/struct_inheritance.rb +23 -2
  319. data/lib/rubocop/cop/style/symbol_array.rb +6 -6
  320. data/lib/rubocop/cop/style/symbol_proc.rb +2 -2
  321. data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -1
  322. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -32
  323. data/lib/rubocop/cop/style/trivial_accessors.rb +8 -7
  324. data/lib/rubocop/cop/style/word_array.rb +1 -1
  325. data/lib/rubocop/cop/style/yoda_condition.rb +18 -1
  326. data/lib/rubocop/cop/style/zero_length_predicate.rb +12 -8
  327. data/lib/rubocop/cop/team.rb +98 -82
  328. data/lib/rubocop/cop/tokens_util.rb +84 -0
  329. data/lib/rubocop/cop/util.rb +3 -15
  330. data/lib/rubocop/cop/utils/format_string.rb +2 -3
  331. data/lib/rubocop/cop/variable_force.rb +0 -2
  332. data/lib/rubocop/cop/variable_force/branch.rb +1 -0
  333. data/lib/rubocop/cop/variable_force/variable.rb +7 -5
  334. data/lib/rubocop/cops_documentation_generator.rb +282 -0
  335. data/lib/rubocop/error.rb +1 -0
  336. data/lib/rubocop/file_finder.rb +12 -12
  337. data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -2
  338. data/lib/rubocop/formatter/formatter_set.rb +2 -1
  339. data/lib/rubocop/name_similarity.rb +7 -3
  340. data/lib/rubocop/options.rb +15 -8
  341. data/lib/rubocop/path_util.rb +19 -19
  342. data/lib/rubocop/platform.rb +1 -1
  343. data/lib/rubocop/rake_task.rb +7 -9
  344. data/lib/rubocop/result_cache.rb +12 -8
  345. data/lib/rubocop/rspec/cop_helper.rb +4 -4
  346. data/lib/rubocop/rspec/expect_offense.rb +63 -22
  347. data/lib/rubocop/rspec/shared_contexts.rb +19 -16
  348. data/lib/rubocop/runner.rb +34 -33
  349. data/lib/rubocop/target_finder.rb +14 -11
  350. data/lib/rubocop/target_ruby.rb +2 -2
  351. data/lib/rubocop/version.rb +2 -2
  352. metadata +49 -11
  353. data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
  354. data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
  355. data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
  356. data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
  357. data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
@@ -22,7 +22,9 @@ module RuboCop
22
22
  # # good
23
23
  # JSON.parse("{}")
24
24
  #
25
- class JSONLoad < Cop
25
+ class JSONLoad < Base
26
+ extend AutoCorrector
27
+
26
28
  MSG = 'Prefer `JSON.parse` over `JSON.%<method>s`.'
27
29
 
28
30
  def_node_matcher :json_load, <<~PATTERN
@@ -31,15 +33,11 @@ module RuboCop
31
33
 
32
34
  def on_send(node)
33
35
  json_load(node) do |method|
34
- add_offense(node,
35
- location: :selector,
36
- message: format(MSG, method: method))
36
+ add_offense(node.loc.selector, message: format(MSG, method: method)) do |corrector|
37
+ corrector.replace(node.loc.selector, 'parse')
38
+ end
37
39
  end
38
40
  end
39
-
40
- def autocorrect(node)
41
- ->(corrector) { corrector.replace(node.loc.selector, 'parse') }
42
- end
43
41
  end
44
42
  end
45
43
  end
@@ -18,7 +18,7 @@ module RuboCop
18
18
  # # okish - deep copy hack
19
19
  # Marshal.load(Marshal.dump({}))
20
20
  #
21
- class MarshalLoad < Cop
21
+ class MarshalLoad < Base
22
22
  MSG = 'Avoid using `Marshal.%<method>s`.'
23
23
 
24
24
  def_node_matcher :marshal_load, <<~PATTERN
@@ -28,9 +28,7 @@ module RuboCop
28
28
 
29
29
  def on_send(node)
30
30
  marshal_load(node) do |method|
31
- add_offense(node,
32
- location: :selector,
33
- message: format(MSG, method: method))
31
+ add_offense(node.loc.selector, message: format(MSG, method: method))
34
32
  end
35
33
  end
36
34
  end
@@ -19,7 +19,7 @@ module RuboCop
19
19
  # File.open(something)
20
20
  # IO.popen(something)
21
21
  # URI.parse(something).open
22
- class Open < Cop
22
+ class Open < Base
23
23
  MSG = 'The use of `Kernel#open` is a serious security risk.'
24
24
 
25
25
  def_node_matcher :open?, <<~PATTERN
@@ -30,7 +30,7 @@ module RuboCop
30
30
  open?(node) do |code|
31
31
  return if safe?(code)
32
32
 
33
- add_offense(node, location: :selector)
33
+ add_offense(node.loc.selector)
34
34
  end
35
35
  end
36
36
 
@@ -15,7 +15,9 @@ module RuboCop
15
15
  # YAML.safe_load("--- foo")
16
16
  # YAML.dump("foo")
17
17
  #
18
- class YAMLLoad < Cop
18
+ class YAMLLoad < Base
19
+ extend AutoCorrector
20
+
19
21
  MSG = 'Prefer using `YAML.safe_load` over `YAML.load`.'
20
22
 
21
23
  def_node_matcher :yaml_load, <<~PATTERN
@@ -24,13 +26,11 @@ module RuboCop
24
26
 
25
27
  def on_send(node)
26
28
  yaml_load(node) do
27
- add_offense(node, location: :selector)
29
+ add_offense(node.loc.selector) do |corrector|
30
+ corrector.replace(node.loc.selector, 'safe_load')
31
+ end
28
32
  end
29
33
  end
30
-
31
- def autocorrect(node)
32
- ->(corrector) { corrector.replace(node.loc.selector, 'safe_load') }
33
- end
34
34
  end
35
35
  end
36
36
  end
@@ -65,6 +65,8 @@ module RuboCop
65
65
  class AccessModifierDeclarations < Cop
66
66
  include ConfigurableEnforcedStyle
67
67
 
68
+ ACCESS_MODIFIERS = %i[private protected public module_function].to_set.freeze
69
+
68
70
  GROUP_STYLE_MESSAGE = [
69
71
  '`%<access_modifier>s` should not be',
70
72
  'inlined in method definitions.'
@@ -80,7 +82,7 @@ module RuboCop
80
82
  PATTERN
81
83
 
82
84
  def on_send(node)
83
- return unless node.access_modifier?
85
+ return unless access_modifier?(node)
84
86
  return if node.parent.pair_type?
85
87
  return if cop_config['AllowModifiersOnSymbols'] &&
86
88
  access_modifier_with_symbol?(node)
@@ -96,6 +98,14 @@ module RuboCop
96
98
 
97
99
  private
98
100
 
101
+ def access_modifier?(node)
102
+ maybe_access_modifier?(node) && node.access_modifier?
103
+ end
104
+
105
+ def maybe_access_modifier?(node)
106
+ !node.receiver && ACCESS_MODIFIERS.include?(node.method_name)
107
+ end
108
+
99
109
  def offense?(node)
100
110
  (group_style? && access_modifier_is_inlined?(node)) ||
101
111
  (inline_style? && access_modifier_is_not_inlined?(node))
@@ -0,0 +1,149 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for grouping of accessors in `class` and `module` bodies.
7
+ # By default it enforces accessors to be placed in grouped declarations,
8
+ # but it can be configured to enforce separating them in multiple declarations.
9
+ #
10
+ # @example EnforcedStyle: grouped (default)
11
+ # # bad
12
+ # class Foo
13
+ # attr_reader :bar
14
+ # attr_reader :baz
15
+ # end
16
+ #
17
+ # # good
18
+ # class Foo
19
+ # attr_reader :bar, :baz
20
+ # end
21
+ #
22
+ # @example EnforcedStyle: separated
23
+ # # bad
24
+ # class Foo
25
+ # attr_reader :bar, :baz
26
+ # end
27
+ #
28
+ # # good
29
+ # class Foo
30
+ # attr_reader :bar
31
+ # attr_reader :baz
32
+ # end
33
+ #
34
+ class AccessorGrouping < Cop
35
+ include ConfigurableEnforcedStyle
36
+ include RangeHelp
37
+ include VisibilityHelp
38
+
39
+ GROUPED_MSG = 'Group together all `%<accessor>s` attributes.'
40
+ SEPARATED_MSG = 'Use one attribute per `%<accessor>s`.'
41
+
42
+ ACCESSOR_METHODS = %i[attr_reader attr_writer attr_accessor attr].freeze
43
+
44
+ def on_class(node)
45
+ class_send_elements(node).each do |macro|
46
+ next unless accessor?(macro)
47
+
48
+ check(macro)
49
+ end
50
+ end
51
+ alias on_sclass on_class
52
+ alias on_module on_class
53
+
54
+ def autocorrect(node)
55
+ lambda do |corrector|
56
+ if (preferred_accessors = preferred_accessors(node))
57
+ corrector.replace(node, preferred_accessors)
58
+ else
59
+ range = range_with_surrounding_space(range: node.loc.expression, side: :left)
60
+ corrector.remove(range)
61
+ end
62
+ end
63
+ end
64
+
65
+ private
66
+
67
+ def previous_line_comment?(node)
68
+ comment_line?(processed_source[node.first_line - 2])
69
+ end
70
+
71
+ def class_send_elements(class_node)
72
+ class_def = class_node.body
73
+
74
+ if !class_def || class_def.def_type?
75
+ []
76
+ elsif class_def.send_type?
77
+ [class_def]
78
+ else
79
+ class_def.each_child_node(:send).to_a
80
+ end
81
+ end
82
+
83
+ def accessor?(send_node)
84
+ send_node.macro? && ACCESSOR_METHODS.include?(send_node.method_name)
85
+ end
86
+
87
+ def check(send_node)
88
+ return if previous_line_comment?(send_node)
89
+
90
+ if grouped_style? && sibling_accessors(send_node).size > 1
91
+ add_offense(send_node)
92
+ elsif separated_style? && send_node.arguments.size > 1
93
+ add_offense(send_node)
94
+ end
95
+ end
96
+
97
+ def grouped_style?
98
+ style == :grouped
99
+ end
100
+
101
+ def separated_style?
102
+ style == :separated
103
+ end
104
+
105
+ def sibling_accessors(send_node)
106
+ send_node.parent.each_child_node(:send).select do |sibling|
107
+ accessor?(sibling) &&
108
+ sibling.method?(send_node.method_name) &&
109
+ node_visibility(sibling) == node_visibility(send_node) &&
110
+ !previous_line_comment?(sibling)
111
+ end
112
+ end
113
+
114
+ def message(send_node)
115
+ msg = grouped_style? ? GROUPED_MSG : SEPARATED_MSG
116
+ format(msg, accessor: send_node.method_name)
117
+ end
118
+
119
+ def preferred_accessors(node)
120
+ if grouped_style?
121
+ accessors = sibling_accessors(node)
122
+ group_accessors(node, accessors) if node == accessors.first
123
+ else
124
+ separate_accessors(node)
125
+ end
126
+ end
127
+
128
+ def group_accessors(node, accessors)
129
+ accessor_names = accessors.flat_map do |accessor|
130
+ accessor.arguments.map(&:source)
131
+ end
132
+
133
+ "#{node.method_name} #{accessor_names.join(', ')}"
134
+ end
135
+
136
+ def separate_accessors(node)
137
+ node.arguments.map do |arg|
138
+ if arg == node.arguments.first
139
+ "#{node.method_name} #{arg.source}"
140
+ else
141
+ indent = ' ' * node.loc.column
142
+ "#{indent}#{node.method_name} #{arg.source}"
143
+ end
144
+ end.join("\n")
145
+ end
146
+ end
147
+ end
148
+ end
149
+ end
@@ -101,10 +101,14 @@ module RuboCop
101
101
  end
102
102
 
103
103
  def lexical_scope_type(node)
104
- node.each_ancestor(:class, :module) do |ancestor|
105
- return ancestor.class_type? ? 'in a class body' : 'in a module body'
104
+ ancestor = node.each_ancestor(:class, :module).first
105
+ if ancestor.nil?
106
+ 'at the top level'
107
+ elsif ancestor.class_type?
108
+ 'in a class body'
109
+ else
110
+ 'in a module body'
106
111
  end
107
- 'at the top level'
108
112
  end
109
113
 
110
114
  def bareword?(sym_node)
@@ -0,0 +1,63 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # This cop enforces the use of `Array()` instead of explicit `Array` check or `[*var]`.
7
+ #
8
+ # @example
9
+ # # bad
10
+ # paths = [paths] unless paths.is_a?(Array)
11
+ # paths.each { |path| do_something(path) }
12
+ #
13
+ # # bad (always creates a new Array instance)
14
+ # [*paths].each { |path| do_something(path) }
15
+ #
16
+ # # good (and a bit more readable)
17
+ # Array(paths).each { |path| do_something(path) }
18
+ #
19
+ class ArrayCoercion < Base
20
+ extend AutoCorrector
21
+
22
+ SPLAT_MSG = 'Use `Array(%<arg>s)` instead of `[*%<arg>s]`.'
23
+ CHECK_MSG = 'Use `Array(%<arg>s)` instead of explicit `Array` check.'
24
+
25
+ def_node_matcher :array_splat?, <<~PATTERN
26
+ (array (splat $_))
27
+ PATTERN
28
+
29
+ def_node_matcher :unless_array?, <<~PATTERN
30
+ (if
31
+ (send
32
+ (lvar $_) :is_a?
33
+ (const nil? :Array)) nil?
34
+ (lvasgn $_
35
+ (array
36
+ (lvar $_))))
37
+ PATTERN
38
+
39
+ def on_array(node)
40
+ return unless node.square_brackets?
41
+
42
+ array_splat?(node) do |arg_node|
43
+ message = format(SPLAT_MSG, arg: arg_node.source)
44
+ add_offense(node, message: message) do |corrector|
45
+ corrector.replace(node, "Array(#{arg_node.source})")
46
+ end
47
+ end
48
+ end
49
+
50
+ def on_if(node)
51
+ unless_array?(node) do |var_a, var_b, var_c|
52
+ if var_a == var_b && var_c == var_b
53
+ message = format(CHECK_MSG, arg: var_a)
54
+ add_offense(node, message: message) do |corrector|
55
+ corrector.replace(node, "#{var_a} = Array(#{var_a})")
56
+ end
57
+ end
58
+ end
59
+ end
60
+ end
61
+ end
62
+ end
63
+ end
@@ -25,10 +25,11 @@ module RuboCop
25
25
 
26
26
  def on_send(node)
27
27
  TARGET_METHODS.each do |target_class, target_method|
28
- target_receiver = s(:const, nil, target_class)
28
+ next if node.method_name != target_method
29
29
 
30
+ target_receiver = s(:const, nil, target_class)
30
31
  next if node.receiver != target_receiver
31
- next if node.method_name != target_method
32
+
32
33
  next if cleanup?(node)
33
34
 
34
35
  add_offense(node,
@@ -60,7 +60,7 @@ module RuboCop
60
60
  end
61
61
 
62
62
  def requires_percent_q?(source)
63
- style == :percent_q && source =~ /^%[^\w]/
63
+ style == :percent_q && /^%[^\w]/.match?(source)
64
64
  end
65
65
 
66
66
  def requires_bare_percent?(source)
@@ -0,0 +1,144 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for places where `attr_reader` and `attr_writer`
7
+ # for the same method can be combined into single `attr_accessor`.
8
+ #
9
+ # @example
10
+ # # bad
11
+ # class Foo
12
+ # attr_reader :bar
13
+ # attr_writer :bar
14
+ # end
15
+ #
16
+ # # good
17
+ # class Foo
18
+ # attr_accessor :bar
19
+ # end
20
+ #
21
+ class BisectedAttrAccessor < Cop
22
+ include VisibilityHelp
23
+
24
+ MSG = 'Combine both accessors into `attr_accessor %<name>s`.'
25
+
26
+ def on_class(class_node)
27
+ VISIBILITY_SCOPES.each do |visibility|
28
+ reader_names, writer_names = accessor_names(class_node, visibility)
29
+ next unless reader_names && writer_names
30
+
31
+ accessor_macroses(class_node, visibility).each do |macro|
32
+ check(macro, reader_names, writer_names)
33
+ end
34
+ end
35
+ end
36
+ alias on_sclass on_class
37
+ alias on_module on_class
38
+
39
+ def autocorrect(node)
40
+ macro = node.parent
41
+
42
+ lambda do |corrector|
43
+ corrector.replace(macro, replacement(macro, node))
44
+ end
45
+ end
46
+
47
+ private
48
+
49
+ def accessor_names(class_node, visibility)
50
+ reader_names = nil
51
+ writer_names = nil
52
+
53
+ accessor_macroses(class_node, visibility).each do |macro|
54
+ names = macro.arguments.map(&:source)
55
+
56
+ names.each do |name|
57
+ if attr_reader?(macro)
58
+ (reader_names ||= Set.new).add(name)
59
+ else
60
+ (writer_names ||= Set.new).add(name)
61
+ end
62
+ end
63
+ end
64
+
65
+ [reader_names, writer_names]
66
+ end
67
+
68
+ def accessor_macroses(class_node, visibility)
69
+ class_def = class_node.body
70
+ return [] if !class_def || class_def.def_type?
71
+
72
+ send_nodes =
73
+ if class_def.send_type?
74
+ [class_def]
75
+ else
76
+ class_def.each_child_node(:send)
77
+ end
78
+
79
+ send_nodes.select { |node| attr_within_visibility_scope?(node, visibility) }
80
+ end
81
+
82
+ def attr_within_visibility_scope?(node, visibility)
83
+ node.macro? &&
84
+ (attr_reader?(node) || attr_writer?(node)) &&
85
+ node_visibility(node) == visibility
86
+ end
87
+
88
+ def attr_reader?(send_node)
89
+ send_node.method?(:attr_reader) || send_node.method?(:attr)
90
+ end
91
+
92
+ def attr_writer?(send_node)
93
+ send_node.method?(:attr_writer)
94
+ end
95
+
96
+ def check(macro, reader_names, writer_names)
97
+ macro.arguments.each do |arg_node|
98
+ name = arg_node.source
99
+
100
+ if (attr_reader?(macro) && writer_names.include?(name)) ||
101
+ (attr_writer?(macro) && reader_names.include?(name))
102
+ add_offense(arg_node, message: format(MSG, name: name))
103
+ end
104
+ end
105
+ end
106
+
107
+ def replacement(macro, node)
108
+ class_node = macro.each_ancestor(:class, :sclass, :module).first
109
+ reader_names, writer_names = accessor_names(class_node, node_visibility(macro))
110
+
111
+ rest_args = rest_args(macro.arguments, reader_names, writer_names)
112
+
113
+ if attr_reader?(macro)
114
+ attr_reader_replacement(macro, node, rest_args)
115
+ elsif rest_args.empty?
116
+ ''
117
+ else
118
+ "#{macro.method_name} #{rest_args.map(&:source).join(', ')}"
119
+ end
120
+ end
121
+
122
+ def rest_args(args, reader_names, writer_names)
123
+ args.reject do |arg|
124
+ name = arg.source
125
+ reader_names.include?(name) && writer_names.include?(name)
126
+ end
127
+ end
128
+
129
+ def attr_reader_replacement(macro, node, rest_args)
130
+ if rest_args.empty?
131
+ "attr_accessor #{node.source}"
132
+ else
133
+ "attr_accessor #{node.source}\n"\
134
+ "#{indent(macro)}#{macro.method_name} #{rest_args.map(&:source).join(', ')}"
135
+ end
136
+ end
137
+
138
+ def indent(node)
139
+ ' ' * node.loc.column
140
+ end
141
+ end
142
+ end
143
+ end
144
+ end