rubocop 0.85.1 → 0.89.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/README.md +16 -4
- data/bin/rubocop-profile +32 -0
- data/config/default.yml +227 -26
- data/lib/rubocop.rb +33 -5
- data/lib/rubocop/cli.rb +2 -4
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +42 -7
- data/lib/rubocop/cli/command/base.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +1 -1
- data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
- data/lib/rubocop/cli/command/show_cops.rb +2 -2
- data/lib/rubocop/cli/command/version.rb +2 -2
- data/lib/rubocop/comment_config.rb +2 -2
- data/lib/rubocop/config.rb +20 -3
- data/lib/rubocop/config_loader.rb +40 -68
- data/lib/rubocop/config_loader_resolver.rb +4 -4
- data/lib/rubocop/config_obsoletion.rb +6 -2
- data/lib/rubocop/config_store.rb +4 -0
- data/lib/rubocop/config_validator.rb +1 -3
- data/lib/rubocop/cop/autocorrect_logic.rb +14 -24
- data/lib/rubocop/cop/badge.rb +1 -1
- data/lib/rubocop/cop/base.rb +407 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +10 -20
- data/lib/rubocop/cop/commissioner.rb +47 -50
- data/lib/rubocop/cop/cop.rb +85 -236
- data/lib/rubocop/cop/corrector.rb +38 -115
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +3 -3
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +26 -0
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/force.rb +1 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +39 -13
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
- data/lib/rubocop/cop/generator.rb +1 -1
- data/lib/rubocop/cop/generator/configuration_injector.rb +3 -3
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +4 -12
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +8 -8
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +10 -7
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +7 -8
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
- data/lib/rubocop/cop/layout/block_alignment.rb +1 -1
- data/lib/rubocop/cop/layout/case_indentation.rb +18 -19
- data/lib/rubocop/cop/layout/class_structure.rb +2 -37
- data/lib/rubocop/cop/layout/comment_indentation.rb +3 -3
- data/lib/rubocop/cop/layout/empty_comment.rb +1 -1
- data/lib/rubocop/cop/layout/empty_lines.rb +0 -2
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +1 -0
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +3 -8
- data/lib/rubocop/cop/layout/end_alignment.rb +3 -2
- data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
- data/lib/rubocop/cop/layout/extra_spacing.rb +9 -16
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +5 -1
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
- data/lib/rubocop/cop/layout/hash_alignment.rb +2 -3
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -2
- data/lib/rubocop/cop/layout/indentation_style.rb +0 -2
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +17 -7
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +0 -2
- data/lib/rubocop/cop/layout/space_after_colon.rb +1 -1
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +22 -27
- data/lib/rubocop/cop/layout/space_around_keyword.rb +2 -2
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +33 -66
- data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +14 -0
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +4 -3
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +1 -1
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +2 -2
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +7 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +15 -10
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +11 -13
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +49 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +16 -11
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +7 -1
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +9 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +21 -17
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +8 -2
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +9 -6
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +60 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
- data/lib/rubocop/cop/lint/else_layout.rb +1 -1
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -6
- data/lib/rubocop/cop/lint/empty_when.rb +2 -2
- data/lib/rubocop/cop/lint/ensure_return.rb +27 -29
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +11 -10
- data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +11 -5
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +5 -4
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +8 -8
- data/lib/rubocop/cop/lint/inherit_exception.rb +12 -7
- data/lib/rubocop/cop/lint/interpolation_check.rb +21 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +14 -2
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -7
- data/lib/rubocop/cop/lint/loop.rb +23 -2
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +6 -5
- data/lib/rubocop/cop/lint/missing_super.rb +99 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -1
- data/lib/rubocop/cop/lint/multiple_comparison.rb +6 -9
- data/lib/rubocop/cop/lint/nested_method_definition.rb +15 -21
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +84 -13
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +2 -2
- data/lib/rubocop/cop/lint/number_conversion.rb +6 -9
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +61 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +12 -13
- data/lib/rubocop/cop/lint/percent_string_array.rb +14 -13
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
- data/lib/rubocop/cop/lint/raise_exception.rb +15 -5
- data/lib/rubocop/cop/lint/rand_one.rb +3 -3
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +31 -25
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +7 -11
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -7
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +15 -11
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +6 -13
- data/lib/rubocop/cop/lint/redundant_with_index.rb +11 -14
- data/lib/rubocop/cop/lint/redundant_with_object.rb +11 -14
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -8
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +3 -6
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +10 -2
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -11
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +2 -2
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +3 -3
- data/lib/rubocop/cop/lint/struct_new_override.rb +1 -1
- data/lib/rubocop/cop/lint/suppressed_exception.rb +4 -7
- data/lib/rubocop/cop/lint/syntax.rb +11 -26
- data/lib/rubocop/cop/lint/to_json.rb +4 -6
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unified_integer.rb +4 -6
- data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
- data/lib/rubocop/cop/lint/unreachable_loop.rb +174 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +8 -3
- data/lib/rubocop/cop/lint/unused_method_argument.rb +9 -4
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +11 -31
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +26 -16
- data/lib/rubocop/cop/lint/useless_assignment.rb +4 -4
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +6 -15
- data/lib/rubocop/cop/lint/useless_setter_call.rb +4 -6
- data/lib/rubocop/cop/lint/void.rb +3 -7
- data/lib/rubocop/cop/metrics/abc_size.rb +1 -1
- data/lib/rubocop/cop/metrics/block_length.rb +24 -2
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +26 -3
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
- data/lib/rubocop/cop/metrics/method_length.rb +25 -2
- data/lib/rubocop/cop/metrics/module_length.rb +26 -3
- data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -6
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +47 -4
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +157 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
- data/lib/rubocop/cop/migration/department_name.rb +13 -15
- data/lib/rubocop/cop/mixin/allowed_methods.rb +19 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +1 -1
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +1 -1
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +1 -1
- data/lib/rubocop/cop/mixin/configurable_naming.rb +1 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -2
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +5 -1
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +1 -1
- data/lib/rubocop/cop/mixin/method_complexity.rb +10 -2
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +1 -1
- data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
- data/lib/rubocop/cop/mixin/range_help.rb +1 -1
- data/lib/rubocop/cop/mixin/regexp_literal_help.rb +27 -0
- data/lib/rubocop/cop/mixin/statement_modifier.rb +38 -9
- data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
- data/lib/rubocop/cop/mixin/surrounding_space.rb +7 -27
- data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +12 -17
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +50 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +2 -2
- data/lib/rubocop/cop/naming/constant_name.rb +2 -2
- data/lib/rubocop/cop/naming/file_name.rb +4 -6
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +3 -3
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +2 -2
- data/lib/rubocop/cop/naming/method_name.rb +1 -1
- data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
- data/lib/rubocop/cop/naming/predicate_name.rb +6 -10
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +12 -11
- data/lib/rubocop/cop/naming/variable_name.rb +1 -1
- data/lib/rubocop/cop/naming/variable_number.rb +1 -1
- data/lib/rubocop/cop/offense.rb +16 -2
- data/lib/rubocop/cop/registry.rb +3 -3
- data/lib/rubocop/cop/security/eval.rb +2 -2
- data/lib/rubocop/cop/security/json_load.rb +6 -8
- data/lib/rubocop/cop/security/marshal_load.rb +2 -4
- data/lib/rubocop/cop/security/open.rb +2 -2
- data/lib/rubocop/cop/security/yaml_load.rb +6 -6
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +11 -1
- data/lib/rubocop/cop/style/accessor_grouping.rb +149 -0
- data/lib/rubocop/cop/style/alias.rb +7 -3
- data/lib/rubocop/cop/style/array_coercion.rb +63 -0
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +3 -2
- data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +144 -0
- data/lib/rubocop/cop/style/block_delimiters.rb +2 -4
- data/lib/rubocop/cop/style/case_equality.rb +22 -3
- data/lib/rubocop/cop/style/case_like_if.rb +217 -0
- data/lib/rubocop/cop/style/class_and_module_children.rb +1 -1
- data/lib/rubocop/cop/style/class_vars.rb +21 -0
- data/lib/rubocop/cop/style/colon_method_call.rb +3 -3
- data/lib/rubocop/cop/style/command_literal.rb +1 -1
- data/lib/rubocop/cop/style/commented_keyword.rb +5 -2
- data/lib/rubocop/cop/style/conditional_assignment.rb +11 -2
- data/lib/rubocop/cop/style/copyright.rb +3 -3
- data/lib/rubocop/cop/style/date_time.rb +1 -1
- data/lib/rubocop/cop/style/dir.rb +2 -2
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +1 -1
- data/lib/rubocop/cop/style/documentation.rb +6 -6
- data/lib/rubocop/cop/style/each_with_object.rb +0 -2
- data/lib/rubocop/cop/style/empty_case_condition.rb +8 -6
- data/lib/rubocop/cop/style/empty_literal.rb +5 -5
- data/lib/rubocop/cop/style/empty_method.rb +5 -5
- data/lib/rubocop/cop/style/encoding.rb +1 -1
- data/lib/rubocop/cop/style/eval_with_location.rb +4 -0
- data/lib/rubocop/cop/style/expand_path_arguments.rb +6 -2
- data/lib/rubocop/cop/style/explicit_block_argument.rb +102 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +8 -10
- data/lib/rubocop/cop/style/float_division.rb +7 -10
- data/lib/rubocop/cop/style/format_string.rb +4 -0
- data/lib/rubocop/cop/style/format_string_token.rb +6 -5
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +1 -1
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/guard_clause.rb +2 -2
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +69 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +6 -3
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +1 -1
- data/lib/rubocop/cop/style/if_unless_modifier.rb +8 -28
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +12 -0
- data/lib/rubocop/cop/style/infinite_loop.rb +1 -1
- data/lib/rubocop/cop/style/inverse_methods.rb +3 -4
- data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +5 -0
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +1 -1
- data/lib/rubocop/cop/style/missing_else.rb +1 -11
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +9 -2
- data/lib/rubocop/cop/style/multiline_block_chain.rb +10 -1
- data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
- data/lib/rubocop/cop/style/multiline_memoization.rb +2 -2
- data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -1
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +17 -6
- data/lib/rubocop/cop/style/mutable_constant.rb +4 -4
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +2 -5
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +27 -0
- data/lib/rubocop/cop/style/next.rb +2 -2
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +2 -2
- data/lib/rubocop/cop/style/numeric_predicate.rb +7 -4
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +42 -0
- data/lib/rubocop/cop/style/parallel_assignment.rb +5 -5
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +2 -2
- data/lib/rubocop/cop/style/proc.rb +1 -1
- data/lib/rubocop/cop/style/random_with_offset.rb +5 -10
- data/lib/rubocop/cop/style/redundant_assignment.rb +117 -0
- data/lib/rubocop/cop/style/redundant_condition.rb +15 -3
- data/lib/rubocop/cop/style/redundant_exception.rb +18 -10
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +122 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +50 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
- data/lib/rubocop/cop/style/redundant_parentheses.rb +8 -2
- data/lib/rubocop/cop/style/redundant_percent_q.rb +2 -2
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +4 -3
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +23 -32
- data/lib/rubocop/cop/style/redundant_self.rb +6 -9
- data/lib/rubocop/cop/style/redundant_sort.rb +28 -12
- data/lib/rubocop/cop/style/rescue_standard_error.rb +1 -1
- data/lib/rubocop/cop/style/sample.rb +1 -1
- data/lib/rubocop/cop/style/semicolon.rb +1 -1
- data/lib/rubocop/cop/style/signal_exception.rb +3 -1
- data/lib/rubocop/cop/style/single_argument_dig.rb +54 -0
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +3 -2
- data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
- data/lib/rubocop/cop/style/string_concatenation.rb +92 -0
- data/lib/rubocop/cop/style/struct_inheritance.rb +23 -2
- data/lib/rubocop/cop/style/symbol_array.rb +6 -6
- data/lib/rubocop/cop/style/symbol_proc.rb +2 -2
- data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -1
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -32
- data/lib/rubocop/cop/style/trivial_accessors.rb +8 -7
- data/lib/rubocop/cop/style/word_array.rb +1 -1
- data/lib/rubocop/cop/style/yoda_condition.rb +18 -1
- data/lib/rubocop/cop/style/zero_length_predicate.rb +12 -8
- data/lib/rubocop/cop/team.rb +98 -82
- data/lib/rubocop/cop/tokens_util.rb +84 -0
- data/lib/rubocop/cop/util.rb +3 -15
- data/lib/rubocop/cop/utils/format_string.rb +2 -3
- data/lib/rubocop/cop/variable_force.rb +0 -2
- data/lib/rubocop/cop/variable_force/branch.rb +1 -0
- data/lib/rubocop/cop/variable_force/variable.rb +7 -5
- data/lib/rubocop/cops_documentation_generator.rb +282 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/file_finder.rb +12 -12
- data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -2
- data/lib/rubocop/formatter/formatter_set.rb +2 -1
- data/lib/rubocop/name_similarity.rb +7 -3
- data/lib/rubocop/options.rb +15 -8
- data/lib/rubocop/path_util.rb +19 -19
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +7 -9
- data/lib/rubocop/result_cache.rb +12 -8
- data/lib/rubocop/rspec/cop_helper.rb +4 -4
- data/lib/rubocop/rspec/expect_offense.rb +63 -22
- data/lib/rubocop/rspec/shared_contexts.rb +19 -16
- data/lib/rubocop/runner.rb +34 -33
- data/lib/rubocop/target_finder.rb +14 -11
- data/lib/rubocop/target_ruby.rb +2 -2
- data/lib/rubocop/version.rb +2 -2
- metadata +49 -11
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
@@ -42,15 +42,15 @@ module RuboCop
|
|
42
42
|
# ensure
|
43
43
|
# do_something_else
|
44
44
|
# end
|
45
|
-
class EmptyEnsure <
|
45
|
+
class EmptyEnsure < Base
|
46
|
+
extend AutoCorrector
|
47
|
+
|
46
48
|
MSG = 'Empty `ensure` block detected.'
|
47
49
|
|
48
50
|
def on_ensure(node)
|
49
|
-
|
50
|
-
end
|
51
|
+
return if node.body
|
51
52
|
|
52
|
-
|
53
|
-
lambda do |corrector|
|
53
|
+
add_offense(node.loc.keyword) do |corrector|
|
54
54
|
corrector.remove(node.loc.keyword)
|
55
55
|
end
|
56
56
|
end
|
@@ -22,13 +22,13 @@ module RuboCop
|
|
22
22
|
# if (some_expression)
|
23
23
|
# bar
|
24
24
|
# end
|
25
|
-
class EmptyExpression <
|
25
|
+
class EmptyExpression < Base
|
26
26
|
MSG = 'Avoid empty expressions.'
|
27
27
|
|
28
28
|
def on_begin(node)
|
29
29
|
return unless empty_expression?(node)
|
30
30
|
|
31
|
-
add_offense(node
|
31
|
+
add_offense(node)
|
32
32
|
end
|
33
33
|
|
34
34
|
private
|
@@ -16,18 +16,17 @@ module RuboCop
|
|
16
16
|
# # good
|
17
17
|
#
|
18
18
|
# "result is #{some_result}"
|
19
|
-
class EmptyInterpolation <
|
19
|
+
class EmptyInterpolation < Base
|
20
20
|
include Interpolation
|
21
|
+
extend AutoCorrector
|
21
22
|
|
22
23
|
MSG = 'Empty interpolation detected.'
|
23
24
|
|
24
25
|
def on_interpolation(begin_node)
|
25
|
-
|
26
|
-
end
|
26
|
+
return unless begin_node.children.empty?
|
27
27
|
|
28
|
-
|
29
|
-
|
30
|
-
collector.remove(node.loc.expression)
|
28
|
+
add_offense(begin_node) do |corrector|
|
29
|
+
corrector.remove(begin_node.loc.expression)
|
31
30
|
end
|
32
31
|
end
|
33
32
|
end
|
@@ -44,7 +44,7 @@ module RuboCop
|
|
44
44
|
# # do nothing
|
45
45
|
# end
|
46
46
|
#
|
47
|
-
class EmptyWhen <
|
47
|
+
class EmptyWhen < Base
|
48
48
|
MSG = 'Avoid `when` branches without a body.'
|
49
49
|
|
50
50
|
def on_case(node)
|
@@ -52,7 +52,7 @@ module RuboCop
|
|
52
52
|
next if when_node.body
|
53
53
|
next if cop_config['AllowComments'] && comment_lines?(node)
|
54
54
|
|
55
|
-
add_offense(when_node
|
55
|
+
add_offense(when_node)
|
56
56
|
end
|
57
57
|
end
|
58
58
|
end
|
@@ -4,57 +4,55 @@ module RuboCop
|
|
4
4
|
module Cop
|
5
5
|
module Lint
|
6
6
|
# This cop checks for `return` from an `ensure` block.
|
7
|
-
#
|
8
|
-
#
|
7
|
+
# `return` from an ensure block is a dangerous code smell as it
|
8
|
+
# will take precedence over any exception being raised,
|
9
9
|
# and the exception will be silently thrown away as if it were rescued.
|
10
10
|
#
|
11
|
+
# If you want to rescue some (or all) exceptions, best to do it explicitly
|
12
|
+
#
|
11
13
|
# @example
|
12
14
|
#
|
13
15
|
# # bad
|
14
16
|
#
|
15
|
-
#
|
17
|
+
# def foo
|
16
18
|
# do_something
|
17
19
|
# ensure
|
18
|
-
#
|
19
|
-
# return
|
20
|
+
# cleanup
|
21
|
+
# return self
|
20
22
|
# end
|
21
23
|
#
|
22
24
|
# @example
|
23
25
|
#
|
24
26
|
# # good
|
25
27
|
#
|
26
|
-
#
|
28
|
+
# def foo
|
27
29
|
# do_something
|
30
|
+
# self
|
31
|
+
# ensure
|
32
|
+
# cleanup
|
33
|
+
# end
|
34
|
+
#
|
35
|
+
# # also good
|
36
|
+
#
|
37
|
+
# def foo
|
38
|
+
# begin
|
39
|
+
# do_something
|
40
|
+
# rescue SomeException
|
41
|
+
# # Let's ignore this exception
|
42
|
+
# end
|
43
|
+
# self
|
28
44
|
# ensure
|
29
|
-
#
|
45
|
+
# cleanup
|
30
46
|
# end
|
31
|
-
class EnsureReturn <
|
47
|
+
class EnsureReturn < Base
|
48
|
+
extend AutoCorrector
|
32
49
|
include RangeHelp
|
33
50
|
|
34
51
|
MSG = 'Do not return from an `ensure` block.'
|
35
52
|
|
36
53
|
def on_ensure(node)
|
37
|
-
|
38
|
-
|
39
|
-
return unless ensure_body
|
40
|
-
|
41
|
-
ensure_body.each_node(:return) do |return_node|
|
42
|
-
next if return_node.arguments.size >= 2
|
43
|
-
|
44
|
-
add_offense(return_node, location: :keyword)
|
45
|
-
end
|
46
|
-
end
|
47
|
-
|
48
|
-
def autocorrect(node)
|
49
|
-
lambda do |corrector|
|
50
|
-
if node.arguments?
|
51
|
-
corrector.replace(node, node.source.gsub(/return\s*/, ''))
|
52
|
-
else
|
53
|
-
range = range_by_whole_lines(
|
54
|
-
node.loc.expression, include_final_newline: true
|
55
|
-
)
|
56
|
-
corrector.remove(range)
|
57
|
-
end
|
54
|
+
node.body&.each_node(:return) do |return_node|
|
55
|
+
add_offense(return_node)
|
58
56
|
end
|
59
57
|
end
|
60
58
|
end
|
@@ -59,9 +59,10 @@ module RuboCop
|
|
59
59
|
# ERB.new(str, nil, '-', '@output_buffer')
|
60
60
|
# end
|
61
61
|
#
|
62
|
-
class ErbNewArguments <
|
63
|
-
extend TargetRubyVersion
|
62
|
+
class ErbNewArguments < Base
|
64
63
|
include RangeHelp
|
64
|
+
extend TargetRubyVersion
|
65
|
+
extend AutoCorrector
|
65
66
|
|
66
67
|
minimum_target_ruby_version 2.6
|
67
68
|
|
@@ -92,13 +93,17 @@ module RuboCop
|
|
92
93
|
message = format(MESSAGES[i], arg_value: argument.source)
|
93
94
|
|
94
95
|
add_offense(
|
95
|
-
|
96
|
-
)
|
96
|
+
argument.source_range, message: message
|
97
|
+
) do |corrector|
|
98
|
+
autocorrect(corrector, node)
|
99
|
+
end
|
97
100
|
end
|
98
101
|
end
|
99
102
|
end
|
100
103
|
|
101
|
-
|
104
|
+
private
|
105
|
+
|
106
|
+
def autocorrect(corrector, node)
|
102
107
|
str_arg = node.arguments[0].source
|
103
108
|
|
104
109
|
kwargs = build_kwargs(node)
|
@@ -108,13 +113,9 @@ module RuboCop
|
|
108
113
|
str_arg, overridden_kwargs
|
109
114
|
].flatten.compact.join(', ')
|
110
115
|
|
111
|
-
|
112
|
-
corrector.replace(arguments_range(node), good_arguments)
|
113
|
-
end
|
116
|
+
corrector.replace(arguments_range(node), good_arguments)
|
114
117
|
end
|
115
118
|
|
116
|
-
private
|
117
|
-
|
118
119
|
def correct_arguments?(arguments)
|
119
120
|
arguments.size == 1 ||
|
120
121
|
arguments.size == 2 && arguments[1].hash_type?
|
@@ -0,0 +1,93 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Lint
|
6
|
+
# This cop checks for the presence of precise comparison of floating point numbers.
|
7
|
+
#
|
8
|
+
# Floating point values are inherently inaccurate, and comparing them for exact equality
|
9
|
+
# is almost never the desired semantics. Comparison via the `==/!=` operators checks
|
10
|
+
# floating-point value representation to be exactly the same, which is very unlikely
|
11
|
+
# if you perform any arithmetic operations involving precision loss.
|
12
|
+
#
|
13
|
+
# @example
|
14
|
+
# # bad
|
15
|
+
# x == 0.1
|
16
|
+
# x != 0.1
|
17
|
+
#
|
18
|
+
# # good - using BigDecimal
|
19
|
+
# x.to_d == 0.1.to_d
|
20
|
+
#
|
21
|
+
# # good
|
22
|
+
# (x - 0.1).abs < Float::EPSILON
|
23
|
+
#
|
24
|
+
# # good
|
25
|
+
# tolerance = 0.0001
|
26
|
+
# (x - 0.1).abs < tolerance
|
27
|
+
#
|
28
|
+
# # Or some other epsilon based type of comparison:
|
29
|
+
# # https://www.embeddeduse.com/2019/08/26/qt-compare-two-floats/
|
30
|
+
#
|
31
|
+
class FloatComparison < Base
|
32
|
+
MSG = 'Avoid (in)equality comparisons of floats as they are unreliable.'
|
33
|
+
|
34
|
+
EQUALITY_METHODS = %i[== != eql? equal?].freeze
|
35
|
+
FLOAT_RETURNING_METHODS = %i[to_f Float fdiv].freeze
|
36
|
+
FLOAT_INSTANCE_METHODS = %i[@- abs magnitude modulo next_float prev_float quo].to_set.freeze
|
37
|
+
|
38
|
+
def on_send(node)
|
39
|
+
return unless EQUALITY_METHODS.include?(node.method_name)
|
40
|
+
|
41
|
+
lhs, _method, rhs = *node
|
42
|
+
add_offense(node) if float?(lhs) || float?(rhs)
|
43
|
+
end
|
44
|
+
|
45
|
+
private
|
46
|
+
|
47
|
+
def float?(node)
|
48
|
+
return false unless node
|
49
|
+
|
50
|
+
case node.type
|
51
|
+
when :float
|
52
|
+
true
|
53
|
+
when :send
|
54
|
+
check_send(node)
|
55
|
+
when :begin
|
56
|
+
float?(node.children.first)
|
57
|
+
else
|
58
|
+
false
|
59
|
+
end
|
60
|
+
end
|
61
|
+
|
62
|
+
# rubocop:disable Metrics/PerceivedComplexity
|
63
|
+
def check_send(node)
|
64
|
+
if node.arithmetic_operation?
|
65
|
+
lhs, _operation, rhs = *node
|
66
|
+
float?(lhs) || float?(rhs)
|
67
|
+
elsif FLOAT_RETURNING_METHODS.include?(node.method_name)
|
68
|
+
true
|
69
|
+
elsif node.receiver&.float_type?
|
70
|
+
if FLOAT_INSTANCE_METHODS.include?(node.method_name)
|
71
|
+
true
|
72
|
+
else
|
73
|
+
check_numeric_returning_method(node)
|
74
|
+
end
|
75
|
+
end
|
76
|
+
end
|
77
|
+
# rubocop:enable Metrics/PerceivedComplexity
|
78
|
+
|
79
|
+
def check_numeric_returning_method(node)
|
80
|
+
return false unless node.receiver
|
81
|
+
|
82
|
+
case node.method_name
|
83
|
+
when :angle, :arg, :phase
|
84
|
+
Float(node.receiver.source).negative?
|
85
|
+
when :ceil, :floor, :round, :truncate
|
86
|
+
precision = node.first_argument
|
87
|
+
precision&.int_type? && Integer(precision.source).positive?
|
88
|
+
end
|
89
|
+
end
|
90
|
+
end
|
91
|
+
end
|
92
|
+
end
|
93
|
+
end
|
@@ -18,14 +18,14 @@ module RuboCop
|
|
18
18
|
# # good
|
19
19
|
#
|
20
20
|
# float = 42.9
|
21
|
-
class FloatOutOfRange <
|
21
|
+
class FloatOutOfRange < Base
|
22
22
|
MSG = 'Float out of range.'
|
23
23
|
|
24
24
|
def on_float(node)
|
25
25
|
value, = *node
|
26
26
|
|
27
27
|
return unless value.infinite? ||
|
28
|
-
value.zero? &&
|
28
|
+
value.zero? && /[1-9]/.match?(node.source)
|
29
29
|
|
30
30
|
add_offense(node)
|
31
31
|
end
|
@@ -34,7 +34,7 @@ module RuboCop
|
|
34
34
|
# # good
|
35
35
|
#
|
36
36
|
# format('Numbered format: %1$s and numbered %2$s', a_value, another)
|
37
|
-
class FormatParameterMismatch <
|
37
|
+
class FormatParameterMismatch < Base
|
38
38
|
# http://rubular.com/r/CvpbxkcTzy
|
39
39
|
MSG = "Number of arguments (%<arg_num>i) to `%<method>s` doesn't " \
|
40
40
|
'match the number of fields (%<field_num>i).'
|
@@ -44,18 +44,19 @@ module RuboCop
|
|
44
44
|
KERNEL = 'Kernel'
|
45
45
|
SHOVEL = '<<'
|
46
46
|
STRING_TYPES = %i[str dstr].freeze
|
47
|
+
FORMAT_METHODS = %i[format sprintf %].freeze
|
47
48
|
|
48
49
|
def on_send(node)
|
49
|
-
return unless format_string?(node)
|
50
|
+
return unless FORMAT_METHODS.include?(node.method_name) && format_string?(node)
|
50
51
|
|
51
52
|
if invalid_format_string?(node)
|
52
|
-
add_offense(node
|
53
|
+
add_offense(node.loc.selector, message: MSG_INVALID)
|
53
54
|
return
|
54
55
|
end
|
55
56
|
|
56
57
|
return unless offending_node?(node)
|
57
58
|
|
58
|
-
add_offense(node,
|
59
|
+
add_offense(node.loc.selector, message: message(node))
|
59
60
|
end
|
60
61
|
|
61
62
|
private
|
@@ -65,7 +66,12 @@ module RuboCop
|
|
65
66
|
end
|
66
67
|
|
67
68
|
def invalid_format_string?(node)
|
68
|
-
|
69
|
+
string = if sprintf?(node) || format?(node)
|
70
|
+
node.first_argument.source
|
71
|
+
else
|
72
|
+
node.receiver.source
|
73
|
+
end
|
74
|
+
!RuboCop::Cop::Utils::FormatString.new(string).valid?
|
69
75
|
end
|
70
76
|
|
71
77
|
def offending_node?(node)
|
@@ -30,8 +30,9 @@ module RuboCop
|
|
30
30
|
# bar
|
31
31
|
# SQL
|
32
32
|
#
|
33
|
-
class HeredocMethodCallPosition <
|
33
|
+
class HeredocMethodCallPosition < Base
|
34
34
|
include RangeHelp
|
35
|
+
extend AutoCorrector
|
35
36
|
|
36
37
|
MSG = 'Put a method call with a HEREDOC receiver on the ' \
|
37
38
|
'same line as the HEREDOC opening.'
|
@@ -41,25 +42,23 @@ module RuboCop
|
|
41
42
|
return unless heredoc
|
42
43
|
return if correctly_positioned?(node, heredoc)
|
43
44
|
|
44
|
-
add_offense(
|
45
|
+
add_offense(call_after_heredoc_range(heredoc)) do |corrector|
|
46
|
+
autocorrect(corrector, node, heredoc)
|
47
|
+
end
|
45
48
|
end
|
46
49
|
alias on_csend on_send
|
47
50
|
|
48
|
-
|
49
|
-
heredoc = heredoc_node_descendent_receiver(node)
|
51
|
+
private
|
50
52
|
|
51
|
-
|
52
|
-
|
53
|
-
|
53
|
+
def autocorrect(corrector, node, heredoc)
|
54
|
+
call_range = call_range_to_safely_reposition(node, heredoc)
|
55
|
+
return if call_range.nil?
|
54
56
|
|
55
|
-
|
56
|
-
|
57
|
-
|
58
|
-
end
|
57
|
+
call_source = call_range.source.strip
|
58
|
+
corrector.remove(call_range)
|
59
|
+
corrector.insert_after(heredoc_begin_line_range(node), call_source)
|
59
60
|
end
|
60
61
|
|
61
|
-
private
|
62
|
-
|
63
62
|
def heredoc_node_descendent_receiver(node)
|
64
63
|
while send_node?(node)
|
65
64
|
return node.receiver if heredoc_node?(node.receiver)
|
@@ -148,7 +147,7 @@ module RuboCop
|
|
148
147
|
end
|
149
148
|
|
150
149
|
def trailing_comma?(call_source, call_line_source)
|
151
|
-
call_source
|
150
|
+
"#{call_source}," == call_line_source
|
152
151
|
end
|
153
152
|
end
|
154
153
|
end
|
@@ -22,7 +22,7 @@ module RuboCop
|
|
22
22
|
# 'Item 1' \
|
23
23
|
# 'Item 2'
|
24
24
|
# ]
|
25
|
-
class ImplicitStringConcatenation <
|
25
|
+
class ImplicitStringConcatenation < Base
|
26
26
|
MSG = 'Combine %<string1>s and %<string2>s into a single string ' \
|
27
27
|
'literal, rather than using implicit string concatenation.'
|
28
28
|
FOR_ARRAY = ' Or, if they were intended to be separate array ' \
|
@@ -41,7 +41,7 @@ module RuboCop
|
|
41
41
|
elsif node.parent&.send_type?
|
42
42
|
message << FOR_METHOD
|
43
43
|
end
|
44
|
-
add_offense(
|
44
|
+
add_offense(range, message: message)
|
45
45
|
end
|
46
46
|
end
|
47
47
|
|
@@ -64,9 +64,10 @@ module RuboCop
|
|
64
64
|
|
65
65
|
def ending_delimiter(str)
|
66
66
|
# implicit string concatenation does not work with %{}, etc.
|
67
|
-
|
67
|
+
case str.source[0]
|
68
|
+
when "'"
|
68
69
|
"'"
|
69
|
-
|
70
|
+
when '"'
|
70
71
|
'"'
|
71
72
|
end
|
72
73
|
end
|