rubocop 0.76.0 → 1.50.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +72 -39
- data/assets/output.html.erb +1 -1
- data/config/default.yml +2044 -451
- data/config/obsoletion.yml +233 -0
- data/exe/rubocop +15 -9
- data/lib/rubocop/arguments_env.rb +17 -0
- data/lib/rubocop/arguments_file.rb +17 -0
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cache_config.rb +29 -0
- data/lib/rubocop/cached_data.rb +4 -4
- data/lib/rubocop/cli/command/auto_generate_config.rb +154 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +105 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +44 -0
- data/lib/rubocop/cli/command/show_cops.rb +74 -0
- data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +126 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/cli.rb +87 -233
- data/lib/rubocop/comment_config.rb +109 -94
- data/lib/rubocop/config.rb +119 -44
- data/lib/rubocop/config_finder.rb +68 -0
- data/lib/rubocop/config_loader.rb +126 -140
- data/lib/rubocop/config_loader_resolver.rb +124 -39
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +26 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +46 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +48 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +72 -186
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +31 -7
- data/lib/rubocop/config_validator.rb +135 -111
- data/lib/rubocop/cop/autocorrect_logic.rb +61 -37
- data/lib/rubocop/cop/badge.rb +27 -32
- data/lib/rubocop/cop/base.rb +482 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +34 -14
- data/lib/rubocop/cop/bundler/gem_comment.rb +121 -14
- data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
- data/lib/rubocop/cop/bundler/gem_version.rb +133 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +45 -28
- data/lib/rubocop/cop/bundler/ordered_gems.rb +7 -18
- data/lib/rubocop/cop/commissioner.rb +112 -75
- data/lib/rubocop/cop/cop.rb +98 -207
- data/lib/rubocop/cop/corrector.rb +85 -119
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +16 -26
- data/lib/rubocop/cop/correctors/condition_corrector.rb +4 -7
- data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +7 -9
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +10 -11
- data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +8 -7
- data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +7 -7
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +16 -13
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +56 -11
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +10 -16
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +64 -9
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +13 -24
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +9 -11
- data/lib/rubocop/cop/correctors/require_library_corrector.rb +23 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +3 -6
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +7 -9
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +16 -19
- data/lib/rubocop/cop/documentation.rb +39 -0
- data/lib/rubocop/cop/exclude_limit.rb +26 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/dependency_version.rb +154 -0
- data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
- data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +11 -26
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +8 -21
- data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +69 -27
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +7 -12
- data/lib/rubocop/cop/generator/configuration_injector.rb +5 -6
- data/lib/rubocop/cop/generator/require_file_injector.rb +4 -7
- data/lib/rubocop/cop/generator.rb +38 -44
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
- data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
- data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
- data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
- data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
- data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +34 -0
- data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/location_expression.rb +37 -0
- data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
- data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +50 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +4 -4
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +147 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
- data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +12 -10
- data/lib/rubocop/cop/internal_affairs/processed_source_buffer_name.rb +42 -0
- data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +73 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +13 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +12 -9
- data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
- data/lib/rubocop/cop/internal_affairs/redundant_source_range.rb +66 -0
- data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
- data/lib/rubocop/cop/internal_affairs/undefined_config.rb +73 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +6 -6
- data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
- data/lib/rubocop/cop/internal_affairs.rb +24 -1
- data/lib/rubocop/cop/layout/access_modifier_indentation.rb +12 -10
- data/lib/rubocop/cop/layout/argument_alignment.rb +158 -0
- data/lib/rubocop/cop/layout/array_alignment.rb +84 -0
- data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +10 -9
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +56 -60
- data/lib/rubocop/cop/layout/block_end_newline.rb +33 -13
- data/lib/rubocop/cop/layout/case_indentation.rb +88 -30
- data/lib/rubocop/cop/layout/class_structure.rb +90 -91
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +5 -7
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +26 -36
- data/lib/rubocop/cop/layout/comment_indentation.rb +56 -29
- data/lib/rubocop/cop/layout/condition_position.rb +17 -9
- data/lib/rubocop/cop/layout/def_end_alignment.rb +10 -11
- data/lib/rubocop/cop/layout/dot_position.rb +65 -27
- data/lib/rubocop/cop/layout/else_alignment.rb +29 -7
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -30
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +61 -37
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +161 -39
- data/lib/rubocop/cop/layout/empty_lines.rb +10 -13
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +34 -38
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +14 -10
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +139 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +8 -9
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +12 -15
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +16 -19
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +12 -15
- data/lib/rubocop/cop/layout/end_alignment.rb +34 -25
- data/lib/rubocop/cop/layout/end_of_line.rb +13 -13
- data/lib/rubocop/cop/layout/extra_spacing.rb +38 -48
- data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +80 -42
- data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +41 -28
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +43 -11
- data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +86 -31
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +51 -8
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +66 -14
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +54 -8
- data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +13 -12
- data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +86 -52
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +56 -34
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +162 -0
- data/lib/rubocop/cop/layout/indentation_consistency.rb +10 -7
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +51 -26
- data/lib/rubocop/cop/layout/initial_indentation.rb +9 -13
- data/lib/rubocop/cop/layout/leading_comment_space.rb +48 -15
- data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +7 -12
- data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +136 -0
- data/lib/rubocop/cop/layout/line_continuation_spacing.rb +140 -0
- data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +141 -0
- data/lib/rubocop/cop/layout/line_length.rb +276 -0
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +53 -8
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +41 -19
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +55 -40
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +9 -16
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +53 -10
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +65 -15
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +52 -24
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +28 -15
- data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +8 -7
- data/lib/rubocop/cop/layout/redundant_line_break.rb +138 -0
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +61 -41
- data/lib/rubocop/cop/layout/single_line_block_chain.rb +64 -0
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -9
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +7 -10
- data/lib/rubocop/cop/layout/space_after_not.rb +11 -12
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -54
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +20 -23
- data/lib/rubocop/cop/layout/space_around_keyword.rb +64 -28
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +110 -34
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +55 -20
- data/lib/rubocop/cop/layout/space_before_brackets.rb +73 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +11 -12
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +22 -16
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +19 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +54 -61
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +8 -15
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +63 -50
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +52 -51
- data/lib/rubocop/cop/layout/space_inside_parens.rb +92 -29
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +38 -9
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +27 -34
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +18 -18
- data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +20 -25
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +73 -19
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
- data/lib/rubocop/cop/legacy/corrector.rb +27 -0
- data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +44 -11
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +64 -12
- data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
- data/lib/rubocop/cop/lint/ambiguous_range.rb +105 -0
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +44 -7
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +20 -8
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +68 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +30 -5
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -2
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
- data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +93 -0
- data/lib/rubocop/cop/lint/debugger.rb +60 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +76 -69
- data/lib/rubocop/cop/lint/deprecated_constants.rb +88 -0
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +154 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +33 -4
- data/lib/rubocop/cop/lint/duplicate_branch.rb +153 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +4 -14
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +3 -5
- data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
- data/lib/rubocop/cop/lint/duplicate_match_pattern.rb +102 -0
- data/lib/rubocop/cop/lint/duplicate_methods.rb +64 -35
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +94 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +56 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +6 -4
- data/lib/rubocop/cop/lint/else_layout.rb +33 -9
- data/lib/rubocop/cop/lint/empty_block.rb +94 -0
- data/lib/rubocop/cop/lint/empty_class.rb +95 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +177 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +6 -8
- data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
- data/lib/rubocop/cop/lint/empty_file.rb +48 -0
- data/lib/rubocop/cop/lint/empty_in_pattern.rb +64 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -8
- data/lib/rubocop/cop/lint/empty_when.rb +34 -9
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -16
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +28 -30
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +3 -4
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +57 -15
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +47 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +30 -34
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +8 -8
- data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +79 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +17 -23
- data/lib/rubocop/cop/lint/inherit_exception.rb +32 -36
- data/lib/rubocop/cop/lint/interpolation_check.rb +28 -9
- data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +51 -0
- data/lib/rubocop/cop/lint/literal_as_condition.rb +43 -17
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +93 -18
- data/lib/rubocop/cop/lint/loop.rb +32 -9
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +51 -24
- data/lib/rubocop/cop/lint/missing_super.rb +130 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
- data/lib/rubocop/cop/lint/multiple_comparison.rb +48 -0
- data/lib/rubocop/cop/lint/nested_method_definition.rb +71 -31
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +19 -7
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +26 -6
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +185 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +13 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +137 -27
- data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
- data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +42 -0
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +16 -20
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +128 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +42 -14
- data/lib/rubocop/cop/lint/percent_string_array.rb +19 -14
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -15
- data/lib/rubocop/cop/lint/raise_exception.rb +91 -0
- data/lib/rubocop/cop/lint/rand_one.rb +6 -5
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +191 -124
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +62 -43
- data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +62 -0
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +55 -15
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +91 -0
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +74 -37
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +72 -0
- data/lib/rubocop/cop/lint/redundant_with_index.rb +27 -29
- data/lib/rubocop/cop/lint/redundant_with_object.rb +26 -30
- data/lib/rubocop/cop/lint/refinement_import_methods.rb +52 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +13 -5
- data/lib/rubocop/cop/lint/require_parentheses.rb +8 -8
- data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
- data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +3 -4
- data/lib/rubocop/cop/lint/rescue_type.rb +12 -18
- data/lib/rubocop/cop/lint/return_in_void_context.rb +7 -22
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +48 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +16 -18
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +13 -5
- data/lib/rubocop/cop/lint/script_permission.rb +11 -8
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +14 -21
- data/lib/rubocop/cop/lint/shadowed_argument.rb +10 -16
- data/lib/rubocop/cop/lint/shadowed_exception.rb +35 -42
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +56 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +55 -18
- data/lib/rubocop/cop/lint/symbol_conversion.rb +179 -0
- data/lib/rubocop/cop/lint/syntax.rb +14 -30
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +99 -0
- data/lib/rubocop/cop/lint/to_json.rb +22 -14
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
- data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +6 -8
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +90 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +7 -8
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +6 -8
- data/lib/rubocop/cop/lint/unreachable_loop.rb +202 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +19 -12
- data/lib/rubocop/cop/lint/unused_method_argument.rb +48 -13
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +6 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +13 -48
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +107 -52
- data/lib/rubocop/cop/lint/useless_assignment.rb +11 -15
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +8 -13
- data/lib/rubocop/cop/lint/useless_method_definition.rb +77 -0
- data/lib/rubocop/cop/lint/useless_rescue.rb +89 -0
- data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +127 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +20 -11
- data/lib/rubocop/cop/lint/useless_times.rb +114 -0
- data/lib/rubocop/cop/lint/void.rb +36 -32
- data/lib/rubocop/cop/message_annotator.rb +5 -4
- data/lib/rubocop/cop/metrics/abc_size.rb +35 -3
- data/lib/rubocop/cop/metrics/block_length.rb +46 -10
- data/lib/rubocop/cop/metrics/block_nesting.rb +7 -12
- data/lib/rubocop/cop/metrics/class_length.rb +47 -12
- data/lib/rubocop/cop/metrics/collection_literal_length.rb +76 -0
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +30 -7
- data/lib/rubocop/cop/metrics/method_length.rb +42 -7
- data/lib/rubocop/cop/metrics/module_length.rb +35 -10
- data/lib/rubocop/cop/metrics/parameter_lists.rb +106 -13
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +8 -10
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +73 -16
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +182 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +54 -17
- data/lib/rubocop/cop/mixin/alignment.rb +19 -12
- data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +42 -0
- data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +58 -23
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +56 -19
- data/lib/rubocop/cop/mixin/code_length.rb +30 -9
- data/lib/rubocop/cop/mixin/comments_help.rb +82 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +28 -14
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -11
- data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +4 -11
- data/lib/rubocop/cop/mixin/documentation_comment.rb +9 -9
- data/lib/rubocop/cop/mixin/duplication.rb +1 -1
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +14 -14
- data/lib/rubocop/cop/mixin/empty_parameter.rb +2 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +17 -4
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +22 -8
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +14 -10
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +45 -10
- data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
- data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +22 -13
- data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +226 -0
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +192 -0
- data/lib/rubocop/cop/mixin/heredoc.rb +5 -0
- data/lib/rubocop/cop/mixin/interpolation.rb +1 -3
- data/lib/rubocop/cop/mixin/line_length_help.rb +110 -0
- data/lib/rubocop/cop/mixin/match_range.rb +2 -5
- data/lib/rubocop/cop/mixin/method_complexity.rb +27 -10
- data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
- data/lib/rubocop/cop/mixin/min_branches_count.rb +40 -0
- data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +39 -16
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +6 -7
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +18 -46
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +15 -15
- data/lib/rubocop/cop/mixin/negative_conditional.rb +6 -4
- data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +17 -7
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +85 -12
- data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +16 -14
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +6 -9
- data/lib/rubocop/cop/mixin/range_help.rb +50 -18
- data/lib/rubocop/cop/mixin/rational_literal.rb +19 -0
- data/lib/rubocop/cop/mixin/require_library.rb +61 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +15 -7
- data/lib/rubocop/cop/mixin/safe_assignment.rb +6 -2
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +6 -7
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +7 -7
- data/lib/rubocop/cop/mixin/statement_modifier.rb +62 -24
- data/lib/rubocop/cop/mixin/string_help.rb +5 -2
- data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -5
- data/lib/rubocop/cop/mixin/surrounding_space.rb +31 -43
- data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_body.rb +2 -3
- data/lib/rubocop/cop/mixin/trailing_comma.rb +20 -29
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +25 -32
- data/lib/rubocop/cop/mixin/unused_argument.rb +5 -9
- data/lib/rubocop/cop/mixin/visibility_help.rb +72 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +22 -4
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +30 -12
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +18 -8
- data/lib/rubocop/cop/naming/block_forwarding.rb +125 -0
- data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +6 -6
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +16 -4
- data/lib/rubocop/cop/naming/constant_name.rb +9 -6
- data/lib/rubocop/cop/naming/file_name.rb +74 -39
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +13 -7
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +9 -9
- data/lib/rubocop/cop/naming/inclusive_language.rb +289 -0
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +137 -28
- data/lib/rubocop/cop/naming/method_name.rb +37 -9
- data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +5 -5
- data/lib/rubocop/cop/naming/predicate_name.rb +45 -19
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +68 -17
- data/lib/rubocop/cop/naming/variable_name.rb +13 -2
- data/lib/rubocop/cop/naming/variable_number.rb +107 -12
- data/lib/rubocop/cop/offense.rb +46 -12
- data/lib/rubocop/cop/registry.rb +146 -42
- data/lib/rubocop/cop/security/compound_hash.rb +106 -0
- data/lib/rubocop/cop/security/eval.rb +5 -3
- data/lib/rubocop/cop/security/io_methods.rb +49 -0
- data/lib/rubocop/cop/security/json_load.rb +17 -16
- data/lib/rubocop/cop/security/marshal_load.rb +5 -5
- data/lib/rubocop/cop/security/open.rb +29 -11
- data/lib/rubocop/cop/security/yaml_load.rb +22 -10
- data/lib/rubocop/cop/severity.rb +4 -14
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +126 -13
- data/lib/rubocop/cop/style/accessor_grouping.rb +176 -0
- data/lib/rubocop/cop/style/alias.rb +56 -47
- data/lib/rubocop/cop/style/and_or.rb +42 -30
- data/lib/rubocop/cop/style/arguments_forwarding.rb +155 -0
- data/lib/rubocop/cop/style/array_coercion.rb +87 -0
- data/lib/rubocop/cop/style/array_intersect.rb +111 -0
- data/lib/rubocop/cop/style/array_join.rb +9 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +8 -12
- data/lib/rubocop/cop/style/attr.rb +21 -13
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +10 -13
- data/lib/rubocop/cop/style/bare_percent_literals.rb +13 -15
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
- data/lib/rubocop/cop/style/block_comments.rb +16 -20
- data/lib/rubocop/cop/style/block_delimiters.rb +169 -29
- data/lib/rubocop/cop/style/case_equality.rb +84 -6
- data/lib/rubocop/cop/style/case_like_if.rb +280 -0
- data/lib/rubocop/cop/style/character_literal.rb +20 -16
- data/lib/rubocop/cop/style/class_and_module_children.rb +69 -34
- data/lib/rubocop/cop/style/class_check.rb +7 -12
- data/lib/rubocop/cop/style/class_equality_comparison.rb +149 -0
- data/lib/rubocop/cop/style/class_methods.rb +9 -15
- data/lib/rubocop/cop/style/class_methods_definitions.rb +158 -0
- data/lib/rubocop/cop/style/class_vars.rb +24 -8
- data/lib/rubocop/cop/style/collection_compact.rb +120 -0
- data/lib/rubocop/cop/style/collection_methods.rb +34 -21
- data/lib/rubocop/cop/style/colon_method_call.rb +8 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +7 -7
- data/lib/rubocop/cop/style/combinable_loops.rb +95 -0
- data/lib/rubocop/cop/style/command_literal.rb +23 -29
- data/lib/rubocop/cop/style/comment_annotation.rb +70 -37
- data/lib/rubocop/cop/style/commented_keyword.rb +43 -24
- data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
- data/lib/rubocop/cop/style/concat_array_literals.rb +94 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +102 -109
- data/lib/rubocop/cop/style/constant_visibility.rb +32 -3
- data/lib/rubocop/cop/style/copyright.rb +22 -25
- data/lib/rubocop/cop/style/data_inheritance.rb +75 -0
- data/lib/rubocop/cop/style/date_time.rb +22 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +22 -20
- data/lib/rubocop/cop/style/dir.rb +15 -13
- data/lib/rubocop/cop/style/dir_empty.rb +60 -0
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +87 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +123 -22
- data/lib/rubocop/cop/style/documentation_method.rb +12 -5
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +7 -16
- data/lib/rubocop/cop/style/double_negation.rb +134 -10
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +48 -16
- data/lib/rubocop/cop/style/each_with_object.rb +54 -25
- data/lib/rubocop/cop/style/empty_block_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_case_condition.rb +32 -27
- data/lib/rubocop/cop/style/empty_else.rb +54 -25
- data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_literal.rb +48 -33
- data/lib/rubocop/cop/style/empty_method.rb +29 -25
- data/lib/rubocop/cop/style/encoding.rb +30 -23
- data/lib/rubocop/cop/style/end_block.rb +8 -5
- data/lib/rubocop/cop/style/endless_method.rb +101 -0
- data/lib/rubocop/cop/style/env_home.rb +56 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +145 -56
- data/lib/rubocop/cop/style/even_odd.rb +11 -13
- data/lib/rubocop/cop/style/expand_path_arguments.rb +28 -26
- data/lib/rubocop/cop/style/explicit_block_argument.rb +153 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +116 -0
- data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
- data/lib/rubocop/cop/style/file_empty.rb +71 -0
- data/lib/rubocop/cop/style/file_read.rb +112 -0
- data/lib/rubocop/cop/style/file_write.rb +136 -0
- data/lib/rubocop/cop/style/float_division.rb +69 -12
- data/lib/rubocop/cop/style/for.rb +13 -13
- data/lib/rubocop/cop/style/format_string.rb +31 -25
- data/lib/rubocop/cop/style/format_string_token.rb +138 -31
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +100 -41
- data/lib/rubocop/cop/style/global_std_stream.rb +70 -0
- data/lib/rubocop/cop/style/global_vars.rb +3 -3
- data/lib/rubocop/cop/style/guard_clause.rb +186 -32
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +100 -0
- data/lib/rubocop/cop/style/hash_conversion.rb +134 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +144 -0
- data/lib/rubocop/cop/style/hash_except.rb +177 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +71 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +109 -44
- data/lib/rubocop/cop/style/hash_transform_keys.rb +95 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +93 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +106 -11
- data/lib/rubocop/cop/style/if_inside_else.rb +65 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +210 -52
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +163 -0
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +6 -4
- data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
- data/lib/rubocop/cop/style/infinite_loop.rb +30 -31
- data/lib/rubocop/cop/style/inline_comment.rb +5 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +60 -57
- data/lib/rubocop/cop/style/invertible_unless_condition.rb +114 -0
- data/lib/rubocop/cop/style/ip_addresses.rb +8 -9
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
- data/lib/rubocop/cop/style/lambda.rb +12 -18
- data/lib/rubocop/cop/style/lambda_call.rb +20 -45
- data/lib/rubocop/cop/style/line_end_concatenation.rb +40 -28
- data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
- data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
- data/lib/rubocop/cop/style/map_to_hash.rb +71 -0
- data/lib/rubocop/cop/style/map_to_set.rb +64 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +226 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +48 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +87 -227
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +41 -15
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +17 -7
- data/lib/rubocop/cop/style/method_def_parentheses.rb +43 -29
- data/lib/rubocop/cop/style/min_max.rb +14 -18
- data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
- data/lib/rubocop/cop/style/missing_else.rb +54 -47
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +12 -6
- data/lib/rubocop/cop/style/mixin_grouping.rb +30 -43
- data/lib/rubocop/cop/style/mixin_usage.rb +13 -31
- data/lib/rubocop/cop/style/module_function.rb +99 -33
- data/lib/rubocop/cop/style/multiline_block_chain.rb +17 -7
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +6 -17
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +60 -0
- data/lib/rubocop/cop/style/multiline_memoization.rb +17 -15
- data/lib/rubocop/cop/style/multiline_method_signature.rb +38 -5
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +74 -12
- data/lib/rubocop/cop/style/multiline_when_then.rb +26 -17
- data/lib/rubocop/cop/style/multiple_comparison.rb +78 -13
- data/lib/rubocop/cop/style/mutable_constant.rb +117 -44
- data/lib/rubocop/cop/style/negated_if.rb +10 -11
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +135 -0
- data/lib/rubocop/cop/style/negated_unless.rb +10 -11
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
- data/lib/rubocop/cop/style/nested_modifier.rb +11 -18
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +35 -23
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +43 -5
- data/lib/rubocop/cop/style/next.rb +25 -36
- data/lib/rubocop/cop/style/nil_comparison.rb +20 -12
- data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +57 -35
- data/lib/rubocop/cop/style/not.rb +23 -29
- data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
- data/lib/rubocop/cop/style/numbered_parameters_limit.rb +58 -0
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +7 -12
- data/lib/rubocop/cop/style/numeric_literals.rb +51 -32
- data/lib/rubocop/cop/style/numeric_predicate.rb +72 -32
- data/lib/rubocop/cop/style/object_then.rb +74 -0
- data/lib/rubocop/cop/style/one_line_conditional.rb +53 -31
- data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
- data/lib/rubocop/cop/style/operator_method_call.rb +67 -0
- data/lib/rubocop/cop/style/option_hash.rb +7 -8
- data/lib/rubocop/cop/style/optional_arguments.rb +9 -8
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +64 -0
- data/lib/rubocop/cop/style/or_assignment.rb +15 -13
- data/lib/rubocop/cop/style/parallel_assignment.rb +31 -26
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +20 -9
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +24 -33
- data/lib/rubocop/cop/style/percent_q_literals.rb +12 -15
- data/lib/rubocop/cop/style/perl_backrefs.rb +106 -17
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +21 -22
- data/lib/rubocop/cop/style/proc.rb +10 -7
- data/lib/rubocop/cop/style/quoted_symbols.rb +124 -0
- data/lib/rubocop/cop/style/raise_args.rb +49 -39
- data/lib/rubocop/cop/style/random_with_offset.rb +31 -36
- data/lib/rubocop/cop/style/redundant_argument.rb +98 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +113 -12
- data/lib/rubocop/cop/style/redundant_capital_w.rb +9 -14
- data/lib/rubocop/cop/style/redundant_condition.rb +184 -26
- data/lib/rubocop/cop/style/redundant_conditional.rb +15 -20
- data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
- data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +45 -0
- data/lib/rubocop/cop/style/redundant_each.rb +116 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +23 -18
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +119 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +61 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +16 -14
- data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
- data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
- data/lib/rubocop/cop/style/redundant_interpolation.rb +71 -31
- data/lib/rubocop/cop/style/redundant_line_continuation.rb +167 -0
- data/lib/rubocop/cop/style/redundant_parentheses.rb +72 -61
- data/lib/rubocop/cop/style/redundant_percent_q.rb +17 -21
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +119 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +135 -0
- data/lib/rubocop/cop/style/redundant_return.rb +39 -38
- data/lib/rubocop/cop/style/redundant_self.rb +60 -28
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +118 -0
- data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +83 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +86 -43
- data/lib/rubocop/cop/style/redundant_sort_by.rb +27 -14
- data/lib/rubocop/cop/style/redundant_string_escape.rb +183 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +26 -32
- data/lib/rubocop/cop/style/require_order.rb +133 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +41 -14
- data/lib/rubocop/cop/style/rescue_standard_error.rb +36 -34
- data/lib/rubocop/cop/style/return_nil.rb +15 -9
- data/lib/rubocop/cop/style/safe_navigation.rb +107 -56
- data/lib/rubocop/cop/style/sample.rb +18 -17
- data/lib/rubocop/cop/style/select_by_regexp.rb +152 -0
- data/lib/rubocop/cop/style/self_assignment.rb +28 -24
- data/lib/rubocop/cop/style/semicolon.rb +88 -33
- data/lib/rubocop/cop/style/send.rb +6 -8
- data/lib/rubocop/cop/style/signal_exception.rb +39 -32
- data/lib/rubocop/cop/style/single_argument_dig.rb +65 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +39 -15
- data/lib/rubocop/cop/style/single_line_methods.rb +82 -20
- data/lib/rubocop/cop/style/slicing_with_range.rb +51 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +248 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +107 -57
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +18 -25
- data/lib/rubocop/cop/style/static_class.rb +128 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +10 -14
- data/lib/rubocop/cop/style/string_chars.rb +41 -0
- data/lib/rubocop/cop/style/string_concatenation.rb +178 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +16 -8
- data/lib/rubocop/cop/style/string_literals.rb +20 -20
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +6 -4
- data/lib/rubocop/cop/style/string_methods.rb +8 -18
- data/lib/rubocop/cop/style/strip.rb +11 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +38 -5
- data/lib/rubocop/cop/style/swap_values.rb +112 -0
- data/lib/rubocop/cop/style/symbol_array.rb +22 -28
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -10
- data/lib/rubocop/cop/style/symbol_proc.rb +135 -35
- data/lib/rubocop/cop/style/ternary_parentheses.rb +47 -51
- data/lib/rubocop/cop/style/top_level_method_definition.rb +85 -0
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +5 -7
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +11 -10
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +4 -7
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +42 -32
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +44 -6
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +105 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +47 -6
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +10 -39
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +24 -33
- data/lib/rubocop/cop/style/trivial_accessors.rb +112 -49
- data/lib/rubocop/cop/style/unless_else.rb +10 -10
- data/lib/rubocop/cop/style/unless_logical_operators.rb +106 -0
- data/lib/rubocop/cop/style/unpack_first.rb +11 -14
- data/lib/rubocop/cop/style/variable_interpolation.rb +9 -12
- data/lib/rubocop/cop/style/when_then.rb +7 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +17 -25
- data/lib/rubocop/cop/style/word_array.rb +79 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +63 -25
- data/lib/rubocop/cop/style/yoda_expression.rb +90 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +64 -35
- data/lib/rubocop/cop/team.rb +156 -81
- data/lib/rubocop/cop/util.rb +106 -30
- data/lib/rubocop/cop/utils/format_string.rb +22 -9
- data/lib/rubocop/cop/variable_force/assignment.rb +3 -3
- data/lib/rubocop/cop/variable_force/branch.rb +19 -10
- data/lib/rubocop/cop/variable_force/reference.rb +1 -3
- data/lib/rubocop/cop/variable_force/scope.rb +9 -12
- data/lib/rubocop/cop/variable_force/variable.rb +14 -15
- data/lib/rubocop/cop/variable_force/variable_table.rb +5 -3
- data/lib/rubocop/cop/variable_force.rb +29 -57
- data/lib/rubocop/cops_documentation_generator.rb +329 -0
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +144 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/ext/comment.rb +18 -0
- data/lib/rubocop/ext/processed_source.rb +20 -0
- data/lib/rubocop/ext/range.rb +15 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +92 -0
- data/lib/rubocop/feature_loader.rb +94 -0
- data/lib/rubocop/file_finder.rb +12 -13
- data/lib/rubocop/file_patterns.rb +43 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +5 -5
- data/lib/rubocop/formatter/disabled_config_formatter.rb +82 -39
- data/lib/rubocop/formatter/emacs_style_formatter.rb +2 -0
- data/lib/rubocop/formatter/formatter_set.rb +24 -22
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +57 -0
- data/lib/rubocop/formatter/html_formatter.rb +17 -26
- data/lib/rubocop/formatter/json_formatter.rb +11 -11
- data/lib/rubocop/formatter/junit_formatter.rb +96 -0
- data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +17 -8
- data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
- data/lib/rubocop/formatter/progress_formatter.rb +3 -4
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +42 -8
- data/lib/rubocop/formatter/tap_formatter.rb +7 -5
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +8 -6
- data/lib/rubocop/formatter.rb +34 -0
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +101 -17
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +360 -189
- data/lib/rubocop/path_util.rb +68 -42
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +43 -16
- data/lib/rubocop/remote_config.rb +17 -15
- data/lib/rubocop/result_cache.rb +91 -45
- data/lib/rubocop/rspec/cop_helper.rb +36 -37
- data/lib/rubocop/rspec/expect_offense.rb +137 -42
- data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
- data/lib/rubocop/rspec/shared_contexts.rb +122 -34
- data/lib/rubocop/rspec/support.rb +17 -1
- data/lib/rubocop/runner.rb +223 -90
- data/lib/rubocop/server/cache.rb +155 -0
- data/lib/rubocop/server/cli.rb +147 -0
- data/lib/rubocop/server/client_command/base.rb +44 -0
- data/lib/rubocop/server/client_command/exec.rb +64 -0
- data/lib/rubocop/server/client_command/restart.rb +25 -0
- data/lib/rubocop/server/client_command/start.rb +48 -0
- data/lib/rubocop/server/client_command/status.rb +28 -0
- data/lib/rubocop/server/client_command/stop.rb +31 -0
- data/lib/rubocop/server/client_command.rb +26 -0
- data/lib/rubocop/server/core.rb +111 -0
- data/lib/rubocop/server/errors.rb +23 -0
- data/lib/rubocop/server/helper.rb +34 -0
- data/lib/rubocop/server/server_command/base.rb +50 -0
- data/lib/rubocop/server/server_command/exec.rb +34 -0
- data/lib/rubocop/server/server_command/stop.rb +24 -0
- data/lib/rubocop/server/server_command.rb +21 -0
- data/lib/rubocop/server/socket_reader.rb +69 -0
- data/lib/rubocop/server.rb +53 -0
- data/lib/rubocop/string_interpreter.rb +7 -4
- data/lib/rubocop/target_finder.rb +58 -48
- data/lib/rubocop/target_ruby.rb +271 -0
- data/lib/rubocop/util.rb +16 -0
- data/lib/rubocop/version.rb +84 -7
- data/lib/rubocop/yaml_duplication_checker.rb +2 -1
- data/lib/rubocop.rb +261 -118
- metadata +362 -117
- data/bin/console +0 -10
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -82
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -115
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -71
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/float_node.rb +0 -12
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/int_node.rb +0 -12
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -35
- data/lib/rubocop/ast/node/resbody_node.rb +0 -24
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/return_node.rb +0 -24
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -644
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -183
- data/lib/rubocop/cop/layout/align_arguments.rb +0 -93
- data/lib/rubocop/cop/layout/align_array.rb +0 -39
- data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
- data/lib/rubocop/cop/layout/tab.rb +0 -75
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/multiple_compare.rb +0 -48
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +0 -59
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/metrics/line_length.rb +0 -318
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -19
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -24
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -209
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -801
- data/lib/rubocop/processed_source.rb +0 -216
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -3,7 +3,30 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Naming
|
6
|
-
#
|
6
|
+
# Checks that predicate methods names end with a question mark and
|
7
|
+
# do not start with a forbidden prefix.
|
8
|
+
#
|
9
|
+
# A method is determined to be a predicate method if its name starts
|
10
|
+
# with one of the prefixes defined in the `NamePrefix` configuration.
|
11
|
+
# You can change what prefixes are considered by changing this option.
|
12
|
+
# Any method name that starts with one of these prefixes is required by
|
13
|
+
# the cop to end with a `?`. Other methods can be allowed by adding to
|
14
|
+
# the `AllowedMethods` configuration.
|
15
|
+
#
|
16
|
+
# NOTE: The `is_a?` method is allowed by default.
|
17
|
+
#
|
18
|
+
# If `ForbiddenPrefixes` is set, methods that start with the configured
|
19
|
+
# prefixes will not be allowed and will be removed by autocorrection.
|
20
|
+
#
|
21
|
+
# In other words, if `ForbiddenPrefixes` is empty, a method named `is_foo`
|
22
|
+
# will register an offense only due to the lack of question mark (and will be
|
23
|
+
# autocorrected to `is_foo?`). If `ForbiddenPrefixes` contains `is_`,
|
24
|
+
# `is_foo` will register an offense both because the ? is missing and because of
|
25
|
+
# the `is_` prefix, and will be corrected to `foo?`.
|
26
|
+
#
|
27
|
+
# NOTE: `ForbiddenPrefixes` is only applied to prefixes in `NamePrefix`;
|
28
|
+
# a prefix in the former but not the latter will not be considered by
|
29
|
+
# this cop.
|
7
30
|
#
|
8
31
|
# @example
|
9
32
|
# # bad
|
@@ -27,7 +50,16 @@ module RuboCop
|
|
27
50
|
# # good
|
28
51
|
# def value?
|
29
52
|
# end
|
30
|
-
|
53
|
+
#
|
54
|
+
# @example AllowedMethods: ['is_a?'] (default)
|
55
|
+
# # good
|
56
|
+
# def is_a?(value)
|
57
|
+
# end
|
58
|
+
#
|
59
|
+
class PredicateName < Base
|
60
|
+
include AllowedMethods
|
61
|
+
|
62
|
+
# @!method dynamic_method_define(node)
|
31
63
|
def_node_matcher :dynamic_method_define, <<~PATTERN
|
32
64
|
(send nil? #method_definition_macros
|
33
65
|
(sym $_)
|
@@ -40,10 +72,8 @@ module RuboCop
|
|
40
72
|
next if allowed_method_name?(method_name.to_s, prefix)
|
41
73
|
|
42
74
|
add_offense(
|
43
|
-
node,
|
44
|
-
|
45
|
-
message: message(method_name,
|
46
|
-
expected_name(method_name.to_s, prefix))
|
75
|
+
node.first_argument.source_range,
|
76
|
+
message: message(method_name, expected_name(method_name.to_s, prefix))
|
47
77
|
)
|
48
78
|
end
|
49
79
|
end
|
@@ -56,8 +86,7 @@ module RuboCop
|
|
56
86
|
next if allowed_method_name?(method_name, prefix)
|
57
87
|
|
58
88
|
add_offense(
|
59
|
-
node,
|
60
|
-
location: :name,
|
89
|
+
node.loc.name,
|
61
90
|
message: message(method_name, expected_name(method_name, prefix))
|
62
91
|
)
|
63
92
|
end
|
@@ -67,19 +96,20 @@ module RuboCop
|
|
67
96
|
private
|
68
97
|
|
69
98
|
def allowed_method_name?(method_name, prefix)
|
70
|
-
!method_name.
|
99
|
+
!(method_name.start_with?(prefix) && # cheap check to avoid allocating Regexp
|
100
|
+
method_name.match?(/^#{prefix}[^0-9]/)) ||
|
71
101
|
method_name == expected_name(method_name, prefix) ||
|
72
|
-
method_name.end_with?('=') ||
|
73
|
-
|
102
|
+
method_name.end_with?('=') || # rubocop:todo InternalAffairs/MethodNameEndWith
|
103
|
+
allowed_method?(method_name)
|
74
104
|
end
|
75
105
|
|
76
106
|
def expected_name(method_name, prefix)
|
77
|
-
new_name = if
|
107
|
+
new_name = if forbidden_prefixes.include?(prefix)
|
78
108
|
method_name.sub(prefix, '')
|
79
109
|
else
|
80
110
|
method_name.dup
|
81
111
|
end
|
82
|
-
new_name << '?' unless method_name.end_with?('?')
|
112
|
+
new_name << '?' unless method_name.end_with?('?') # rubocop:todo InternalAffairs/MethodNameEndWith
|
83
113
|
new_name
|
84
114
|
end
|
85
115
|
|
@@ -87,18 +117,14 @@ module RuboCop
|
|
87
117
|
"Rename `#{method_name}` to `#{new_name}`."
|
88
118
|
end
|
89
119
|
|
90
|
-
def
|
91
|
-
cop_config['
|
120
|
+
def forbidden_prefixes
|
121
|
+
cop_config['ForbiddenPrefixes']
|
92
122
|
end
|
93
123
|
|
94
124
|
def predicate_prefixes
|
95
125
|
cop_config['NamePrefix']
|
96
126
|
end
|
97
127
|
|
98
|
-
def predicate_whitelist
|
99
|
-
cop_config['NameWhitelist']
|
100
|
-
end
|
101
|
-
|
102
128
|
def method_definition_macros(macro_name)
|
103
129
|
cop_config['MethodDefinitionMacros'].include?(macro_name.to_s)
|
104
130
|
end
|
@@ -3,12 +3,17 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Naming
|
6
|
-
#
|
6
|
+
# Makes sure that rescued exceptions variables are named as
|
7
7
|
# expected.
|
8
8
|
#
|
9
9
|
# The `PreferredName` config option takes a `String`. It represents
|
10
10
|
# the required name of the variable. Its default is `e`.
|
11
11
|
#
|
12
|
+
# NOTE: This cop does not consider nested rescues because it cannot
|
13
|
+
# guarantee that the variable from the outer rescue is not used within
|
14
|
+
# the inner rescue (in which case, changing the inner variable would
|
15
|
+
# shadow the outer variable).
|
16
|
+
#
|
12
17
|
# @example PreferredName: e (default)
|
13
18
|
# # bad
|
14
19
|
# begin
|
@@ -53,28 +58,33 @@ module RuboCop
|
|
53
58
|
# # do something
|
54
59
|
# end
|
55
60
|
#
|
56
|
-
class RescuedExceptionsVariableName <
|
61
|
+
class RescuedExceptionsVariableName < Base
|
62
|
+
extend AutoCorrector
|
63
|
+
|
57
64
|
MSG = 'Use `%<preferred>s` instead of `%<bad>s`.'
|
58
65
|
|
59
66
|
def on_resbody(node)
|
60
|
-
|
61
|
-
return unless
|
62
|
-
return if preferred_name(name).to_sym == name
|
67
|
+
offending_name = variable_name(node)
|
68
|
+
return unless offending_name
|
63
69
|
|
64
|
-
|
65
|
-
|
70
|
+
# Handle nested rescues by only requiring the outer one to use the
|
71
|
+
# configured variable name, so that nested rescues don't use the same
|
72
|
+
# variable.
|
73
|
+
return if node.each_ancestor(:resbody).any?
|
66
74
|
|
67
|
-
|
68
|
-
|
69
|
-
offending_name = variable_name(node)
|
70
|
-
preferred_name = preferred_name(offending_name)
|
71
|
-
corrector.replace(offense_range(node), preferred_name)
|
75
|
+
preferred_name = preferred_name(offending_name)
|
76
|
+
return if preferred_name.to_sym == offending_name
|
72
77
|
|
73
|
-
|
74
|
-
|
78
|
+
# check variable shadowing for exception variable
|
79
|
+
return if shadowed_variable_name?(node)
|
75
80
|
|
76
|
-
|
77
|
-
|
81
|
+
range = offense_range(node)
|
82
|
+
message = message(node)
|
83
|
+
|
84
|
+
add_offense(range, message: message) do |corrector|
|
85
|
+
corrector.replace(range, preferred_name)
|
86
|
+
|
87
|
+
correct_node(corrector, node.body, offending_name, preferred_name)
|
78
88
|
end
|
79
89
|
end
|
80
90
|
|
@@ -82,7 +92,44 @@ module RuboCop
|
|
82
92
|
|
83
93
|
def offense_range(resbody)
|
84
94
|
variable = resbody.exception_variable
|
85
|
-
variable.
|
95
|
+
variable.source_range
|
96
|
+
end
|
97
|
+
|
98
|
+
def variable_name_matches?(node, name)
|
99
|
+
if node.masgn_type?
|
100
|
+
node.each_descendant(:lvasgn).any? do |lvasgn_node|
|
101
|
+
variable_name_matches?(lvasgn_node, name)
|
102
|
+
end
|
103
|
+
else
|
104
|
+
node.children.first == name
|
105
|
+
end
|
106
|
+
end
|
107
|
+
|
108
|
+
def correct_node(corrector, node, offending_name, preferred_name)
|
109
|
+
return unless node
|
110
|
+
|
111
|
+
node.each_node(:lvar, :lvasgn, :masgn) do |child_node|
|
112
|
+
next unless variable_name_matches?(child_node, offending_name)
|
113
|
+
|
114
|
+
corrector.replace(child_node, preferred_name) if child_node.lvar_type?
|
115
|
+
|
116
|
+
if child_node.masgn_type? || child_node.lvasgn_type?
|
117
|
+
correct_reassignment(corrector, child_node, offending_name, preferred_name)
|
118
|
+
break
|
119
|
+
end
|
120
|
+
end
|
121
|
+
end
|
122
|
+
|
123
|
+
# If the exception variable is reassigned, that assignment needs to be corrected.
|
124
|
+
# Further `lvar` nodes will not be corrected though since they now refer to a
|
125
|
+
# different variable.
|
126
|
+
def correct_reassignment(corrector, node, offending_name, preferred_name)
|
127
|
+
if node.lvasgn_type?
|
128
|
+
correct_node(corrector, node.child_nodes.first, offending_name, preferred_name)
|
129
|
+
elsif node.masgn_type?
|
130
|
+
# With multiple assign, the assignments are in an array as the last child
|
131
|
+
correct_node(corrector, node.children.last, offending_name, preferred_name)
|
132
|
+
end
|
86
133
|
end
|
87
134
|
|
88
135
|
def preferred_name(variable_name)
|
@@ -106,6 +153,10 @@ module RuboCop
|
|
106
153
|
preferred_name = preferred_name(offending_name)
|
107
154
|
format(MSG, preferred: preferred_name, bad: offending_name)
|
108
155
|
end
|
156
|
+
|
157
|
+
def shadowed_variable_name?(node)
|
158
|
+
node.each_descendant(:lvar).any? { |n| n.children.first.to_s == preferred_name(n) }
|
159
|
+
end
|
109
160
|
end
|
110
161
|
end
|
111
162
|
end
|
@@ -3,7 +3,7 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Naming
|
6
|
-
#
|
6
|
+
# Makes sure that all variables use the configured style,
|
7
7
|
# snake_case or camelCase, for their names.
|
8
8
|
#
|
9
9
|
# @example EnforcedStyle: snake_case (default)
|
@@ -19,14 +19,25 @@ module RuboCop
|
|
19
19
|
#
|
20
20
|
# # good
|
21
21
|
# fooBar = 1
|
22
|
-
|
22
|
+
#
|
23
|
+
# @example AllowedPatterns: ['_v\d+\z']
|
24
|
+
# # good
|
25
|
+
# :release_v1
|
26
|
+
class VariableName < Base
|
27
|
+
include AllowedIdentifiers
|
23
28
|
include ConfigurableNaming
|
29
|
+
include AllowedPattern
|
24
30
|
|
25
31
|
MSG = 'Use %<style>s for variable names.'
|
26
32
|
|
33
|
+
def valid_name?(node, name, given_style = style)
|
34
|
+
super || matches_allowed_pattern?(name)
|
35
|
+
end
|
36
|
+
|
27
37
|
def on_lvasgn(node)
|
28
38
|
name, = *node
|
29
39
|
return unless name
|
40
|
+
return if allowed_identifier?(name)
|
30
41
|
|
31
42
|
check_name(node, name, node.loc.name)
|
32
43
|
end
|
@@ -3,57 +3,152 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Naming
|
6
|
-
#
|
6
|
+
# Makes sure that all numbered variables use the
|
7
7
|
# configured style, snake_case, normalcase, or non_integer,
|
8
8
|
# for their numbering.
|
9
9
|
#
|
10
|
-
#
|
10
|
+
# Additionally, `CheckMethodNames` and `CheckSymbols` configuration options
|
11
|
+
# can be used to specify whether method names and symbols should be checked.
|
12
|
+
# Both are enabled by default.
|
13
|
+
#
|
14
|
+
# @example EnforcedStyle: normalcase (default)
|
11
15
|
# # bad
|
16
|
+
# :some_sym_1
|
17
|
+
# variable_1 = 1
|
12
18
|
#
|
13
|
-
#
|
19
|
+
# def some_method_1; end
|
20
|
+
#
|
21
|
+
# def some_method1(arg_1); end
|
14
22
|
#
|
15
23
|
# # good
|
24
|
+
# :some_sym1
|
25
|
+
# variable1 = 1
|
16
26
|
#
|
17
|
-
#
|
27
|
+
# def some_method1; end
|
18
28
|
#
|
19
|
-
#
|
29
|
+
# def some_method1(arg1); end
|
30
|
+
#
|
31
|
+
# @example EnforcedStyle: snake_case
|
20
32
|
# # bad
|
33
|
+
# :some_sym1
|
34
|
+
# variable1 = 1
|
21
35
|
#
|
22
|
-
#
|
36
|
+
# def some_method1; end
|
37
|
+
#
|
38
|
+
# def some_method_1(arg1); end
|
23
39
|
#
|
24
40
|
# # good
|
41
|
+
# :some_sym_1
|
42
|
+
# variable_1 = 1
|
25
43
|
#
|
26
|
-
#
|
44
|
+
# def some_method_1; end
|
45
|
+
#
|
46
|
+
# def some_method_1(arg_1); end
|
27
47
|
#
|
28
48
|
# @example EnforcedStyle: non_integer
|
29
49
|
# # bad
|
50
|
+
# :some_sym1
|
51
|
+
# :some_sym_1
|
30
52
|
#
|
31
53
|
# variable1 = 1
|
32
|
-
#
|
33
54
|
# variable_1 = 1
|
34
55
|
#
|
56
|
+
# def some_method1; end
|
57
|
+
#
|
58
|
+
# def some_method_1; end
|
59
|
+
#
|
60
|
+
# def some_methodone(arg1); end
|
61
|
+
# def some_methodone(arg_1); end
|
62
|
+
#
|
35
63
|
# # good
|
64
|
+
# :some_symone
|
65
|
+
# :some_sym_one
|
36
66
|
#
|
37
67
|
# variableone = 1
|
38
|
-
#
|
39
68
|
# variable_one = 1
|
40
|
-
|
69
|
+
#
|
70
|
+
# def some_methodone; end
|
71
|
+
#
|
72
|
+
# def some_method_one; end
|
73
|
+
#
|
74
|
+
# def some_methodone(argone); end
|
75
|
+
# def some_methodone(arg_one); end
|
76
|
+
#
|
77
|
+
# # In the following examples, we assume `EnforcedStyle: normalcase` (default).
|
78
|
+
#
|
79
|
+
# @example CheckMethodNames: true (default)
|
80
|
+
# # bad
|
81
|
+
# def some_method_1; end
|
82
|
+
#
|
83
|
+
# @example CheckMethodNames: false
|
84
|
+
# # good
|
85
|
+
# def some_method_1; end
|
86
|
+
#
|
87
|
+
# @example CheckSymbols: true (default)
|
88
|
+
# # bad
|
89
|
+
# :some_sym_1
|
90
|
+
#
|
91
|
+
# @example CheckSymbols: false
|
92
|
+
# # good
|
93
|
+
# :some_sym_1
|
94
|
+
#
|
95
|
+
# @example AllowedIdentifiers: [capture3]
|
96
|
+
# # good
|
97
|
+
# expect(Open3).to receive(:capture3)
|
98
|
+
#
|
99
|
+
# @example AllowedPatterns: ['_v\d+\z']
|
100
|
+
# # good
|
101
|
+
# :some_sym_v1
|
102
|
+
#
|
103
|
+
class VariableNumber < Base
|
104
|
+
include AllowedIdentifiers
|
41
105
|
include ConfigurableNumbering
|
106
|
+
include AllowedPattern
|
107
|
+
|
108
|
+
MSG = 'Use %<style>s for %<identifier_type>s numbers.'
|
42
109
|
|
43
|
-
|
110
|
+
def valid_name?(node, name, given_style = style)
|
111
|
+
super || matches_allowed_pattern?(name)
|
112
|
+
end
|
44
113
|
|
45
114
|
def on_arg(node)
|
115
|
+
@node = node
|
46
116
|
name, = *node
|
117
|
+
return if allowed_identifier?(name)
|
118
|
+
|
47
119
|
check_name(node, name, node.loc.name)
|
48
120
|
end
|
49
121
|
alias on_lvasgn on_arg
|
50
122
|
alias on_ivasgn on_arg
|
51
123
|
alias on_cvasgn on_arg
|
124
|
+
alias on_gvasgn on_arg
|
125
|
+
|
126
|
+
def on_def(node)
|
127
|
+
@node = node
|
128
|
+
return if allowed_identifier?(node.method_name)
|
129
|
+
|
130
|
+
check_name(node, node.method_name, node.loc.name) if cop_config['CheckMethodNames']
|
131
|
+
end
|
132
|
+
alias on_defs on_def
|
133
|
+
|
134
|
+
def on_sym(node)
|
135
|
+
@node = node
|
136
|
+
return if allowed_identifier?(node.value)
|
137
|
+
|
138
|
+
check_name(node, node.value, node) if cop_config['CheckSymbols']
|
139
|
+
end
|
52
140
|
|
53
141
|
private
|
54
142
|
|
55
143
|
def message(style)
|
56
|
-
|
144
|
+
identifier_type =
|
145
|
+
case @node.type
|
146
|
+
when :def, :defs then 'method name'
|
147
|
+
when :sym then 'symbol'
|
148
|
+
else 'variable'
|
149
|
+
end
|
150
|
+
|
151
|
+
format(MSG, style: style, identifier_type: identifier_type)
|
57
152
|
end
|
58
153
|
end
|
59
154
|
end
|
data/lib/rubocop/cop/offense.rb
CHANGED
@@ -7,8 +7,7 @@ module RuboCop
|
|
7
7
|
include Comparable
|
8
8
|
|
9
9
|
# @api private
|
10
|
-
COMPARISON_ATTRIBUTES = %i[line column cop_name
|
11
|
-
message severity].freeze
|
10
|
+
COMPARISON_ATTRIBUTES = %i[line column cop_name message severity].freeze
|
12
11
|
|
13
12
|
# @api public
|
14
13
|
#
|
@@ -54,17 +53,56 @@ module RuboCop
|
|
54
53
|
# @api private
|
55
54
|
attr_reader :status
|
56
55
|
|
56
|
+
# @api public
|
57
|
+
#
|
58
|
+
# @!attribute [r] corrector
|
59
|
+
#
|
60
|
+
# @return [Corrector | nil]
|
61
|
+
# the autocorrection for this offense, or `nil` when not available
|
62
|
+
attr_reader :corrector
|
63
|
+
|
64
|
+
PseudoSourceRange = Struct.new(:line, :column, :source_line, :begin_pos,
|
65
|
+
:end_pos) do
|
66
|
+
alias_method :first_line, :line
|
67
|
+
alias_method :last_line, :line
|
68
|
+
alias_method :last_column, :column
|
69
|
+
|
70
|
+
def column_range
|
71
|
+
column...last_column
|
72
|
+
end
|
73
|
+
|
74
|
+
def size
|
75
|
+
end_pos - begin_pos
|
76
|
+
end
|
77
|
+
alias_method :length, :size
|
78
|
+
end
|
79
|
+
private_constant :PseudoSourceRange
|
80
|
+
|
81
|
+
NO_LOCATION = PseudoSourceRange.new(1, 0, '', 0, 0).freeze
|
82
|
+
|
57
83
|
# @api private
|
58
|
-
def initialize(severity, location, message, cop_name,
|
59
|
-
status = :uncorrected)
|
84
|
+
def initialize(severity, location, message, cop_name, # rubocop:disable Metrics/ParameterLists
|
85
|
+
status = :uncorrected, corrector = nil)
|
60
86
|
@severity = RuboCop::Cop::Severity.new(severity)
|
61
87
|
@location = location
|
62
88
|
@message = message.freeze
|
63
89
|
@cop_name = cop_name.freeze
|
64
90
|
@status = status
|
91
|
+
@corrector = corrector
|
65
92
|
freeze
|
66
93
|
end
|
67
94
|
|
95
|
+
# @api public
|
96
|
+
#
|
97
|
+
# @!attribute [r] correctable?
|
98
|
+
#
|
99
|
+
# @return [Boolean]
|
100
|
+
# whether this offense can be automatically corrected via
|
101
|
+
# autocorrect or a todo.
|
102
|
+
def correctable?
|
103
|
+
@status != :unsupported
|
104
|
+
end
|
105
|
+
|
68
106
|
# @api public
|
69
107
|
#
|
70
108
|
# @!attribute [r] corrected?
|
@@ -102,9 +140,7 @@ module RuboCop
|
|
102
140
|
# @return [Parser::Source::Range]
|
103
141
|
# the range of the code that is highlighted
|
104
142
|
def highlighted_area
|
105
|
-
Parser::Source::Range.new(source_line,
|
106
|
-
column,
|
107
|
-
column + column_length)
|
143
|
+
Parser::Source::Range.new(source_line, column, column + column_length)
|
108
144
|
end
|
109
145
|
|
110
146
|
# @api private
|
@@ -174,16 +210,14 @@ module RuboCop
|
|
174
210
|
# returns `true` if two offenses contain same attributes
|
175
211
|
def ==(other)
|
176
212
|
COMPARISON_ATTRIBUTES.all? do |attribute|
|
177
|
-
|
213
|
+
public_send(attribute) == other.public_send(attribute)
|
178
214
|
end
|
179
215
|
end
|
180
216
|
|
181
217
|
alias eql? ==
|
182
218
|
|
183
219
|
def hash
|
184
|
-
COMPARISON_ATTRIBUTES.
|
185
|
-
hash ^ send(attribute).hash
|
186
|
-
end
|
220
|
+
COMPARISON_ATTRIBUTES.map { |attribute| public_send(attribute) }.hash
|
187
221
|
end
|
188
222
|
|
189
223
|
# @api public
|
@@ -195,7 +229,7 @@ module RuboCop
|
|
195
229
|
# comparison result
|
196
230
|
def <=>(other)
|
197
231
|
COMPARISON_ATTRIBUTES.each do |attribute|
|
198
|
-
result =
|
232
|
+
result = public_send(attribute) <=> other.public_send(attribute)
|
199
233
|
return result unless result.zero?
|
200
234
|
end
|
201
235
|
0
|