rubocop 0.71.0 → 0.72.0

data/lib/rubocop/rspec/support.rb

@@ -5,7 +5,6 @@
 require_relative 'cop_helper'
 require_relative 'host_environment_simulation_helper'
 require_relative 'shared_contexts'
-require_relative 'shared_examples'
 require_relative 'expect_offense'
 
 RSpec.configure do |config|

data/lib/rubocop/runner.rb

@@ -24,14 +24,6 @@ module RuboCop
 
     def initialize(options, config_store)
       @options = options
-
-      if @options.key?(:rails)
-        warn <<~MESSAGE
-          `-R/--rails` option and Rails cops will be removed from RuboCop 0.72. Use the `rubocop-rails` gem instead.
-          https://github.com/rubocop-hq/rubocop/blob/master/manual/migrate_rails_cops.md
-        MESSAGE
-      end
-
       @config_store = config_store
       @errors = []
       @warnings = []
@@ -281,10 +273,6 @@ module RuboCop
 
     def inspect_file(processed_source)
       config = @config_store.for(processed_source.path)
-      if @options[:rails] ||
-         ConfigLoader.required_features.include?('rubocop-rails')
-        enable_rails_cops(config)
-      end
       team = Cop::Team.new(mobilized_cop_classes(config), config, @options)
       offenses = team.inspect_file(processed_source)
       @errors.concat(team.errors)
@@ -292,11 +280,6 @@ module RuboCop
       [offenses, team.updated_source_file?]
     end
 
-    def enable_rails_cops(config)
-      config['Rails'] ||= {}
-      config['Rails']['Enabled'] = true
-    end
-
     def mobilized_cop_classes(config)
       @mobilized_cop_classes ||= {}
       @mobilized_cop_classes[config.object_id] ||= begin

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.71.0'
+    STRING = '0.72.0'
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'

data/lib/rubocop/yaml_duplication_checker.rb

@@ -4,8 +4,14 @@ module RuboCop
   # Find duplicated keys from YAML.
   module YAMLDuplicationChecker
     def self.check(yaml_string, filename, &on_duplicated)
-      # Specify filename to display helpful message when it raises an error.
-      tree = YAML.parse(yaml_string, filename)
+      # Ruby 2.6+
+      tree = if Gem::Version.new(Psych::VERSION) >= Gem::Version.new('3.1.0')
+               # Specify filename to display helpful message when it raises
+               # an error.
+               YAML.parse(yaml_string, filename: filename)
+             else
+               YAML.parse(yaml_string, filename)
+             end
       return unless tree
 
       traverse(tree, &on_duplicated)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.71.0
+  version: 0.72.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-30 00:00:00.000000000 Z
+date: 2019-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler
@@ -128,20 +128,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rack
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.0'
 description: |2
       Automatic Ruby code style checking tool.
       Aims to enforce the community-driven Ruby Style Guide.
@@ -175,9 +161,11 @@ files:
 - lib/rubocop/ast/node/def_node.rb
 - lib/rubocop/ast/node/defined_node.rb
 - lib/rubocop/ast/node/ensure_node.rb
+- lib/rubocop/ast/node/float_node.rb
 - lib/rubocop/ast/node/for_node.rb
 - lib/rubocop/ast/node/hash_node.rb
 - lib/rubocop/ast/node/if_node.rb
+- lib/rubocop/ast/node/int_node.rb
 - lib/rubocop/ast/node/keyword_splat_node.rb
 - lib/rubocop/ast/node/mixin/basic_literal_node.rb
 - lib/rubocop/ast/node/mixin/binary_operator_node.rb
@@ -187,6 +175,7 @@ files:
 - lib/rubocop/ast/node/mixin/method_dispatch_node.rb
 - lib/rubocop/ast/node/mixin/method_identifier_predicates.rb
 - lib/rubocop/ast/node/mixin/modifier_node.rb
+- lib/rubocop/ast/node/mixin/numeric_node.rb
 - lib/rubocop/ast/node/mixin/parameterized_node.rb
 - lib/rubocop/ast/node/mixin/predicate_operator_node.rb
 - lib/rubocop/ast/node/module_node.rb
@@ -242,6 +231,7 @@ files:
 - lib/rubocop/cop/gemspec/duplicated_assignment.rb
 - lib/rubocop/cop/gemspec/ordered_dependencies.rb
 - lib/rubocop/cop/gemspec/required_ruby_version.rb
+- lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb
 - lib/rubocop/cop/generator.rb
 - lib/rubocop/cop/generator/configuration_injector.rb
 - lib/rubocop/cop/generator/require_file_injector.rb
@@ -488,7 +478,6 @@ files:
 - lib/rubocop/cop/mixin/string_help.rb
 - lib/rubocop/cop/mixin/string_literals_help.rb
 - lib/rubocop/cop/mixin/surrounding_space.rb
-- lib/rubocop/cop/mixin/target_rails_version.rb
 - lib/rubocop/cop/mixin/target_ruby_version.rb
 - lib/rubocop/cop/mixin/too_many_lines.rb
 - lib/rubocop/cop/mixin/trailing_body.rb
@@ -512,57 +501,6 @@ files:
 - lib/rubocop/cop/naming/variable_name.rb
 - lib/rubocop/cop/naming/variable_number.rb
 - lib/rubocop/cop/offense.rb
-- lib/rubocop/cop/rails/action_filter.rb
-- lib/rubocop/cop/rails/active_record_aliases.rb
-- lib/rubocop/cop/rails/active_record_override.rb
-- lib/rubocop/cop/rails/active_support_aliases.rb
-- lib/rubocop/cop/rails/application_job.rb
-- lib/rubocop/cop/rails/application_record.rb
-- lib/rubocop/cop/rails/assert_not.rb
-- lib/rubocop/cop/rails/belongs_to.rb
-- lib/rubocop/cop/rails/blank.rb
-- lib/rubocop/cop/rails/bulk_change_table.rb
-- lib/rubocop/cop/rails/create_table_with_timestamps.rb
-- lib/rubocop/cop/rails/date.rb
-- lib/rubocop/cop/rails/delegate.rb
-- lib/rubocop/cop/rails/delegate_allow_blank.rb
-- lib/rubocop/cop/rails/dynamic_find_by.rb
-- lib/rubocop/cop/rails/enum_uniqueness.rb
-- lib/rubocop/cop/rails/environment_comparison.rb
-- lib/rubocop/cop/rails/exit.rb
-- lib/rubocop/cop/rails/file_path.rb
-- lib/rubocop/cop/rails/find_by.rb
-- lib/rubocop/cop/rails/find_each.rb
-- lib/rubocop/cop/rails/has_and_belongs_to_many.rb
-- lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb
-- lib/rubocop/cop/rails/http_positional_arguments.rb
-- lib/rubocop/cop/rails/http_status.rb
-- lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb
-- lib/rubocop/cop/rails/inverse_of.rb
-- lib/rubocop/cop/rails/lexically_scoped_action_filter.rb
-- lib/rubocop/cop/rails/link_to_blank.rb
-- lib/rubocop/cop/rails/not_null_column.rb
-- lib/rubocop/cop/rails/output.rb
-- lib/rubocop/cop/rails/output_safety.rb
-- lib/rubocop/cop/rails/pluralization_grammar.rb
-- lib/rubocop/cop/rails/presence.rb
-- lib/rubocop/cop/rails/present.rb
-- lib/rubocop/cop/rails/read_write_attribute.rb
-- lib/rubocop/cop/rails/redundant_allow_nil.rb
-- lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb
-- lib/rubocop/cop/rails/reflection_class_name.rb
-- lib/rubocop/cop/rails/refute_methods.rb
-- lib/rubocop/cop/rails/relative_date_constant.rb
-- lib/rubocop/cop/rails/request_referer.rb
-- lib/rubocop/cop/rails/reversible_migration.rb
-- lib/rubocop/cop/rails/safe_navigation.rb
-- lib/rubocop/cop/rails/save_bang.rb
-- lib/rubocop/cop/rails/scope_args.rb
-- lib/rubocop/cop/rails/skips_model_validations.rb
-- lib/rubocop/cop/rails/time_zone.rb
-- lib/rubocop/cop/rails/uniq_before_pluck.rb
-- lib/rubocop/cop/rails/unknown_env.rb
-- lib/rubocop/cop/rails/validation.rb
 - lib/rubocop/cop/registry.rb
 - lib/rubocop/cop/security/eval.rb
 - lib/rubocop/cop/security/json_load.rb
@@ -616,6 +554,7 @@ files:
 - lib/rubocop/cop/style/eval_with_location.rb
 - lib/rubocop/cop/style/even_odd.rb
 - lib/rubocop/cop/style/expand_path_arguments.rb
+- lib/rubocop/cop/style/float_division.rb
 - lib/rubocop/cop/style/for.rb
 - lib/rubocop/cop/style/format_string.rb
 - lib/rubocop/cop/style/format_string_token.rb
@@ -783,7 +722,6 @@ files:
 - lib/rubocop/rspec/expect_offense.rb
 - lib/rubocop/rspec/host_environment_simulation_helper.rb
 - lib/rubocop/rspec/shared_contexts.rb
-- lib/rubocop/rspec/shared_examples.rb
 - lib/rubocop/rspec/support.rb
 - lib/rubocop/runner.rb
 - lib/rubocop/string_interpreter.rb
@@ -802,28 +740,7 @@ metadata:
   source_code_uri: https://github.com/rubocop-hq/rubocop/
   documentation_uri: https://docs.rubocop.org/
   bug_tracker_uri: https://github.com/rubocop-hq/rubocop/issues
-post_install_message: |
-  Rails cops will be removed from RuboCop 0.72. Use the `rubocop-rails` gem instead.
-
-  Put this in your `Gemfile`.
-
-  ```rb
-  gem 'rubocop-rails'
-  ```
-
-  And then execute:
-
-  ```sh
-  $ bundle install
-  ```
-
-  Put this into your `.rubocop.yml`.
-
-  ```yaml
-  require: rubocop-rails
-  ```
-
-  More information: https://github.com/rubocop-hq/rubocop-rails
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib

data/lib/rubocop/cop/mixin/target_rails_version.rb

@@ -1,16 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for checking target rails version.
-    module TargetRailsVersion
-      def minimum_target_rails_version(version)
-        @minimum_target_rails_version = version
-      end
-
-      def support_target_rails_version?(version)
-        @minimum_target_rails_version <= version
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/action_filter.rb

@@ -1,117 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # This cop enforces the consistent use of action filter methods.
-      #
-      # The cop is configurable and can enforce the use of the older
-      # something_filter methods or the newer something_action methods.
-      #
-      # If the TargetRailsVersion is set to less than 4.0, the cop will enforce
-      # the use of filter methods.
-      #
-      # @example EnforcedStyle: action (default)
-      #   # bad
-      #   after_filter :do_stuff
-      #   append_around_filter :do_stuff
-      #   skip_after_filter :do_stuff
-      #
-      #   # good
-      #   after_action :do_stuff
-      #   append_around_action :do_stuff
-      #   skip_after_action :do_stuff
-      #
-      # @example EnforcedStyle: filter
-      #   # bad
-      #   after_action :do_stuff
-      #   append_around_action :do_stuff
-      #   skip_after_action :do_stuff
-      #
-      #   # good
-      #   after_filter :do_stuff
-      #   append_around_filter :do_stuff
-      #   skip_after_filter :do_stuff
-      class ActionFilter < Cop
-        extend TargetRailsVersion
-        include ConfigurableEnforcedStyle
-
-        MSG = 'Prefer `%<prefer>s` over `%<current>s`.'
-
-        FILTER_METHODS = %i[
-          after_filter
-          append_after_filter
-          append_around_filter
-          append_before_filter
-          around_filter
-          before_filter
-          prepend_after_filter
-          prepend_around_filter
-          prepend_before_filter
-          skip_after_filter
-          skip_around_filter
-          skip_before_filter
-          skip_filter
-        ].freeze
-
-        ACTION_METHODS = %i[
-          after_action
-          append_after_action
-          append_around_action
-          append_before_action
-          around_action
-          before_action
-          prepend_after_action
-          prepend_around_action
-          prepend_before_action
-          skip_after_action
-          skip_around_action
-          skip_before_action
-          skip_action_callback
-        ].freeze
-
-        minimum_target_rails_version 4.0
-
-        def on_block(node)
-          check_method_node(node.send_node)
-        end
-
-        def on_send(node)
-          check_method_node(node) unless node.receiver
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node.loc.selector,
-                              preferred_method(node.loc.selector.source).to_s)
-          end
-        end
-
-        private
-
-        def check_method_node(node)
-          return unless bad_methods.include?(node.method_name)
-
-          add_offense(node, location: :selector)
-        end
-
-        def message(node)
-          format(MSG, prefer: preferred_method(node.method_name),
-                      current: node.method_name)
-        end
-
-        def bad_methods
-          style == :action ? FILTER_METHODS : ACTION_METHODS
-        end
-
-        def good_methods
-          style == :action ? ACTION_METHODS : FILTER_METHODS
-        end
-
-        def preferred_method(method)
-          good_methods[bad_methods.index(method.to_sym)]
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/active_record_aliases.rb

@@ -1,48 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # Checks that ActiveRecord aliases are not used. The direct method names
-      # are more clear and easier to read.
-      #
-      # @example
-      #   #bad
-      #   Book.update_attributes!(author: 'Alice')
-      #
-      #   #good
-      #   Book.update!(author: 'Alice')
-      class ActiveRecordAliases < Cop
-        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
-
-        ALIASES = {
-          update_attributes: :update,
-          update_attributes!: :update!
-        }.freeze
-
-        def on_send(node)
-          ALIASES.each do |bad, good|
-            next unless node.method?(bad)
-
-            add_offense(node,
-                        message: format(MSG, prefer: good, current: bad),
-                        location: :selector,
-                        severity: :warning)
-            break
-          end
-        end
-
-        alias on_csend on_send
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(
-              node.loc.selector,
-              ALIASES[node.method_name].to_s
-            )
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rails/active_record_override.rb

@@ -1,82 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # Checks for overriding built-in Active Record methods instead of using
-      # callbacks.
-      #
-      # @example
-      #   # bad
-      #   class Book < ApplicationRecord
-      #     def save
-      #       self.title = title.upcase!
-      #       super
-      #     end
-      #   end
-      #
-      #   # good
-      #   class Book < ApplicationRecord
-      #     before_save :upcase_title
-      #
-      #     def upcase_title
-      #       self.title = title.upcase!
-      #     end
-      #   end
-      #
-      class ActiveRecordOverride < Cop
-        MSG =
-          'Use %<prefer>s callbacks instead of overriding the Active Record ' \
-          'method `%<bad>s`.'
-        BAD_METHODS = %i[create destroy save update].freeze
-        ACTIVE_RECORD_CLASSES = %w[ApplicationRecord ActiveModel::Base
-                                   ActiveRecord::Base].freeze
-
-        def on_def(node)
-          return unless BAD_METHODS.include?(node.method_name)
-
-          parent_class_name = find_parent_class_name(node)
-          return unless active_model?(parent_class_name)
-
-          return unless node.descendants.any?(&:zsuper_type?)
-
-          add_offense(node, message: message(node.method_name))
-        end
-
-        private
-
-        def active_model?(parent_class_name)
-          ACTIVE_RECORD_CLASSES.include?(parent_class_name)
-        end
-
-        def callback_names(method_name)
-          names = %w[before_ around_ after_].map do |prefix|
-            "`#{prefix}#{method_name}`"
-          end
-
-          names[-1] = "or #{names.last}"
-
-          names.join(', ')
-        end
-
-        def message(method_name)
-          format(MSG, prefer: callback_names(method_name), bad: method_name)
-        end
-
-        def find_parent_class_name(node)
-          return nil unless node
-
-          if node.class_type?
-            parent_class_name = node.node_parts[1]
-
-            return nil if parent_class_name.nil?
-
-            return parent_class_name.source
-          end
-
-          find_parent_class_name(node.parent)
-        end
-      end
-    end
-  end
-end